From nobody Mon Sep 28 21:03:32 2026 Received: from mail-pj2-f10.google.com (mail-pj2-f10.google.com [74.125.227.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44786442385 for ; Mon, 17 Aug 2026 15:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.138 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786979855; cv=none; b=dDCyDl+J7wJ26TS1oE46Hk4enL3CxjhaUbjeAFZJaLNBjm1ySjM0FrGeJm5DOaP5IwuqxNbiPFszip2oWD10XYv0ANulOO+i3APlgdpmf/lMdHMnXnrpV25sAN5H5XmyQ5U7yXbmkdiKvd69uihGpbCHNFHuu0KHfaS2Iqz2atQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786979855; c=relaxed/simple; bh=PnXURDT7TF7E+506PXiwQOaLGHxh0vguz1r+5WkZrfM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LUPQFJT0zJtlOoXuzY8Um/153nS0D757oL+P3WYQoEHbCvi8umk21A3rWNDqfmY1vFTjnkI9+jbCrAzwt+YMGOGvU0xrDDcBTDokmnp3JK7sVODBwbbeSigMAZTMGrU8C1Eld0h47rFkGebljIR4CKu/luJKhPJPOIAXZnVFn1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kw9O+om/; arc=none smtp.client-ip=74.125.227.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kw9O+om/" Received: by mail-pj2-f10.google.com with SMTP id 98e67ed59e1d1-3931e624fd8so1863610a91.1 for ; Mon, 17 Aug 2026 08:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786979850; x=1787584650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3xmJpE2fneh7wGrqaQEZBQ9HCgMVcK1jLUppAI08kRg=; b=kw9O+om/OGVb4xFU6iKtsd5qyHctqP5WRs6ADXtwIzMb3u7eIE2Q+IlKa5sO87eZSy 1g5KaOaAWlZ3GhCDnnjGhwPE4c3caK3010g/NuM9VH1PBKjpt9zIgqU1xlbyvmA1zYFX M7VAxWw5X+KkhVsR1nZff/QovjNsF7n9cx1sQ3+/D00ynquz7PM3LbKGj20JMwyMmFVa JH6hef5Yl5L4FUUG+1Oxl+rqYoJGyE14ibp0mjUAs5MlMc0yL6dksjBYIsqY9fTrdrX4 0ZwSCQRIg0ShJ0O+BqTPXBOsjW9nyD3m2aCYV3xlHN7SiddCy/NtFep8PFQ51xD9C1GS /M4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786979850; x=1787584650; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3xmJpE2fneh7wGrqaQEZBQ9HCgMVcK1jLUppAI08kRg=; b=MMa+FThFpQW+QPBk1PLwznVDx5ZibG3rk321JAx+DmTbZkYIWCLhxPaz2JKUqkaoJD WPAqEV+YBdltogK/ZvWTXZo18j7J8d+iCvLcHWf4mfBd5zfunkhJNngegdtlDDqnYbed 3N9gnaxkClflEcIUtlS494X1WRUMYshdKqHfTR1QnAcVqgJFs0GC1ju/Lyy1KA/nCsz9 2rGy9H9cUe83JMwyCkcv600fVzDGPCdDYw34Bhp/wf/8zKgLNoNF+88fFToaKajje99G raH/cXhuIbYsHFW/S7gHW8QN2BR+1rucmn8GYeVKY+MdmvwDIdgA1Ne3mRumtrt3mwJf 21Rw== X-Forwarded-Encrypted: i=1; AHgh+RpAfk4XLVwiFVutl1yQJuO14eOky198tij5QKGY8yk8LunLGkIL/n28AhXuIttzQoUHeV+KenxVj/Bam04=@vger.kernel.org X-Gm-Message-State: AOJu0YwI77TiGYiogSqBfHa/8NZSEGK/VqTvjBkcxhATy0XO3M31GmgL l//LjeAPgdgxbYbonMxtzNfOxgyQ0902tavOf/Q5IHzd/pe+Y6eHe5NR0F0VIJXg X-Gm-Gg: AR+sD11yIdrZb7SouWSv37VZQfvtgh3nI3JRU0ZLZgio6AlxiQ/V2J74FRIo2Beji/C eIkoLD231F1NFV9PPKz0tr6O6C/e5duiAz0fvkSDm90hFNU96DikYapFyTYT8NB9fTni6ELiwim tyTmrZBmMH2YjplN5V4VpP70D8m/Ao0NMAB202dOMEMVChLAOlVo3Ll8Od8eHjGW6Yg24qJAvqk /PpP4u9jG695IgSGsI9ZSAqFQgiuQnENI8dRe+CldyeG4/hqlSEDGGwi8q2ggcrpNoHJYJbZWXx OJ4tYosASWtkTgf2T0BkkZhufA7xO3JaIqSyUn7I7ozb3P3q0QKy2rTlmODiRLBc7JRUGw5Wnqh TGPcX4edUwaSLB+UY6EpgYIqP7JJ++ao1SSxDPxHJ5MbJy+0fLAWCqxkflmMuMWY5tXKYmq21R1 iwkx3IS8ONQACZlwOts0Ws1C/IbJTJnzwNKmNc6KWR4g2y1cWzNybmYIyPUr+6rxDbLKBTEwWwr 99JcV7mxXPM20WN7WxdbH97kzvyp9qsJ2YoClXckvhLQN0YZA4TXhPMvd4o6EI= X-Received: by 2002:a17:90b:53c8:b0:392:c80b:8ef7 with SMTP id 98e67ed59e1d1-3955aa68f86mr1278380a91.18.1786979849772; Mon, 17 Aug 2026 08:17:29 -0700 (PDT) Received: from localhost.localdomain (111-242-148-125.dynamic-ip.hinet.net. [111.242.148.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531e84118sm5708876a91.5.2026.08.17.08.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 08:17:29 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH] staging: rtl8723bs: simplify rtw_free_xmitframe() Date: Mon, 17 Aug 2026 15:17:11 +0000 Message-ID: <20260817151711.24385-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rtw_free_xmitframe() always returns _SUCCESS and the return value is not used by its callers. Convert the function to return void and remove the redundant _SUCCESS return value. Also replace the goto used to skip the xmit frame queue handling with an early return. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 14 +++++++------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 81d9e713fc12..230ae52ef04c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1734,14 +1734,14 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct = xmit_priv *pxmitpriv) return pxframe; } =20 -s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxm= itframe) +void rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *px= mitframe) { struct __queue *queue =3D NULL; struct adapter *padapter =3D pxmitpriv->adapter; struct sk_buff *pndis_pkt =3D NULL; =20 if (!pxmitframe) - return _SUCCESS; + return; =20 if (pxmitframe->pkt) { pndis_pkt =3D pxmitframe->pkt; @@ -1750,7 +1750,11 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, = struct xmit_frame *pxmitfram =20 if (pxmitframe->alloc_addr) { kfree(pxmitframe->alloc_addr); - goto check_pkt_complete; + + if (pndis_pkt) + rtw_os_pkt_complete(padapter, pndis_pkt); + + return; } =20 if (pxmitframe->ext_tag =3D=3D 0) @@ -1769,12 +1773,8 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, = struct xmit_frame *pxmitfram =20 spin_unlock_bh(&queue->lock); =20 -check_pkt_complete: - if (pndis_pkt) rtw_os_pkt_complete(padapter, pndis_pkt); - - return _SUCCESS; } =20 void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue = *pframequeue) diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index 917e846e9ce2..28615fe72b80 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -416,7 +416,7 @@ extern s32 rtw_put_snap(u8 *data, u16 h_proto); extern struct xmit_frame *rtw_alloc_xmitframe(struct xmit_priv *pxmitpriv); struct xmit_frame *rtw_alloc_xmitframe_ext(struct xmit_priv *pxmitpriv); struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit_priv *pxmitpriv); -extern s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_fra= me *pxmitframe); +void rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *px= mitframe); extern void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct _= _queue *pframequeue); struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac); int rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe); --=20 2.43.0