From nobody Mon Sep 28 21:03:32 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E3353F9F2F for ; Mon, 17 Aug 2026 11:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786964956; cv=none; b=Hy52rvdWFD1tJMgB/jhBGawRVAVSKXZ+t+XusJx5nT/txAJSBLJpAYBlMMoReHHGFXPviVQmIApYPHrBY2j+hE1olrp6qEz/ywJ8YhF9fpAxdRdEFd9qOH9jQRqb18EcFdbNYK85wiKdOxB9hb8qNvYvwxEdY690be1uQra+9P4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786964956; c=relaxed/simple; bh=zQITEraiHsGpDDYt9Nt1jR8D0YOYzfn8aHodB9I1nps=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HcTK4LjZugI5NbvVDlzgii1TEXF3XP+C0azKS8wMdNu9C8KC7yqLb1sg4PL5P8E2jVUofukzGQBHX3O3Y2BRN/4ZvTq4jryycqLDJxdKmdqi/QcKPCoSD5gN/t8qxJlK6UxjRiHmdIOFJu4SpUW98oK4Yzqubth7e2X/PvW0ttQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bk/Qv4rs; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bk/Qv4rs" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c96c92c0980so1808836a12.3 for ; Mon, 17 Aug 2026 04:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786964955; x=1787569755; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bbOXjIOE5eUZ77E2jan3Zky2z5kifDys7cgukCqXI+w=; b=bk/Qv4rsJKuR0lKES/Ci2m7JR9S86vVNBP31BLixS28E1NYeyQU9bGI+sI8Z71aUQg GlQz/ouBILSYBhy18AElqf66Fu9AcFn4NMNT3N/0wUZFoRNA/aLJoTXXojF7HiNQPpB/ ahuLCn++7eMwG8mjs/wORExiKeUQX0uGlIgNCUwp+/us8W8bgMLIb1yFM1KZ7sI4Poe/ RztxfGlprLGYQ5LxXnpi2eRLp1seTCPsBZiUab/GSwcXW8ZRv9hJ0RHyFQ+ExNTOZM/Q uXjg9RFlyhkys0welLXTUKfoDaMJiLUMHsDwTVVE3avSGlaaO1Q/EVhMVgTLk5YJmZU3 SW8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786964955; x=1787569755; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bbOXjIOE5eUZ77E2jan3Zky2z5kifDys7cgukCqXI+w=; b=aVHa6Cc0GFG2Gh4KKD9awn2o4QVIDp1QYp5eqeqVQkHeQUGr8KkrVTkJL+8o/LNQOS /gpKT4MwIzREihHY8J37K01s7R5olVtdjf+un+TFCsaiY868m30zUFuRQXPyvnOHW3KM sdb79IkMjW5T+r52ZhT5HwrLVpBmktaXFSh3sPxrVfRVbbTidGQ6xTc20AKEzuwNtZdH Rk1G26ttkwA/ARtbikiBWXz4hVjs8EMgvkYq13udpDpUXsUdyAwwdpWBLdDsyh5LF7Iw ei7Af2wqo02kKevenDUKDc2fyrpDyBXLzEp1C4mzzZHm+cv0pbDjRulXI/uvksFko+ch UeWA== X-Forwarded-Encrypted: i=1; AHgh+RoCQHSWErsp++lyTG8iIw3n+casM4R9OKo8Chl9w6gfng20oDT/mK/SWZV15Fz7b+8W/3acjzNSe4JOWRE=@vger.kernel.org X-Gm-Message-State: AOJu0YySO5bl/Xa6azdOXpQ2srLb+9Hw96+45eM2Yi2y2WqyFxUOgnLH AL3FzkHMpR7pTbk3NdaV8hVi5V41t4aS6uveuVtuIiBu2KK26LrjD29P X-Gm-Gg: AR+sD105yJ2lxFQvFB8jflC8kUFKhLuLJocPD9pAOK3MJLogJzi5E/ZLQjQ01xqTYRj 6sD6GBJFuI7QcpNXw0Woqeqb7aWr30gZQ+QRSxGIwLOUaCS+w1NVNd8ZIfoPtfE5hCQxxi4ISkp 9PdXR5GqZ5vkQRJ048jPwVpPgH8TNvJLjdyFa/4HuqotkRozU/x2DDt4/xuGI+4Rkj/BJuIw8VH M0tO2rOyO6PaXlmg5TPr41DnGe5sTyQV3j/1VHC4fNni+RUbN6SOCJJAN4CNMgjAfJOcIIzpCHM mNGDcgQypEcRwh0G1bXsUK/54ZWq0EaOqi/NGKm7vI5gsMuIkrHLD+qWxmnGI2B/xzaLZX7EeNl 3Y7rtK0PEtS4feFCcKAy5zPVm5EJnRyGBRffC+z6h+VrrRwHN1d7YBAV39oZIAqfHIT5+udSsUM C8GrRAZYabqT9iAzvGEoG1IGJt8Ntd3e+g189oRJD3ALK9UOrKvYXjNtO2WhxZ71YisA== X-Received: by 2002:a05:6a21:6110:b0:3cc:1d2b:2ac3 with SMTP id adf61e73a8af0-3cc71d195cdmr26060283637.26.1786964954730; Mon, 17 Aug 2026 04:09:14 -0700 (PDT) Received: from Default ([2409:40f4:102a:23fd:2be3:947e:c2d2:30da]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1415305e48esm6077568c88.5.2026.08.17.04.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 04:09:13 -0700 (PDT) From: Jeffin Philip To: gregkh@linuxfoundation.org, felipe.balbi@linux.intel.com Cc: christophe.jaillet@wanadoo.fr, kees@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+791be35f1fbcc85d06d7@syzkaller.appspotmail.com, Jeffin Philip , stable@vger.kernel.org Subject: [PATCH] usb: gadget: f_mass_storage: fix null pointer dereference in fsg_common_set_num_buffers() Date: Mon, 17 Aug 2026 16:38:39 +0530 Message-ID: <20260817110839.8201-1-jeffinphilip14@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In fsg_common_set_num_buffers(), n can be 0 as conversion to u8 using kstrtou8() in fsg_opts_num_buffers_store() can return values from _0_ to 255. When passing 0 as "n" value to kzalloc_objs, it can return a ZERO_SIZE_PTR, which passes the null check for buffhds. This leads to a null pointer dereference later in bh->next in the do while loop. Fix this by adding a check for n =3D 0 case and returning -EINVAL if n is 0. Reported-by: syzbot+791be35f1fbcc85d06d7@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D791be35f1fbcc85d06d7 Fixes: fe5a6c48fd95 ("usb: gadget: storage: get rid of fsg_num_buffers_vali= date()") Cc: stable@vger.kernel.org Signed-off-by: Jeffin Philip --- drivers/usb/gadget/function/f_mass_storage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gad= get/function/f_mass_storage.c index a50743caf083..640d3bcb7bf0 100644 --- a/drivers/usb/gadget/function/f_mass_storage.c +++ b/drivers/usb/gadget/function/f_mass_storage.c @@ -2747,6 +2747,9 @@ int fsg_common_set_num_buffers(struct fsg_common *com= mon, unsigned int n) struct fsg_buffhd *bh, *buffhds; int i; =20 + if (!n) + return -EINVAL; + buffhds =3D kzalloc_objs(*buffhds, n); if (!buffhds) return -ENOMEM; --=20 2.55.0