From nobody Mon Sep 28 21:53:23 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C323B1B3 for ; Mon, 17 Aug 2026 04:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786941139; cv=none; b=JXEoErcLDiFmyHV7LVS8HyuYo80GusUDBuEi0jyA3B3QjJnNvDxzOcG63f5g4KgETrox4XSXdLIIin8ByUfJUvuVRyaikTMRKZZCUnms4+uLxN/t0n6d7ycqtUk99sVdISPV9GX9pWXL/HqyN2S0HAjL7RMr7fmGi8slW5hjUcg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786941139; c=relaxed/simple; bh=sqsToIPQilvysXv8NKykHueDkEcBewEOF9CRoMnm8rc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pprx9OWMX0k94NlGu3BS5Y4XcYjID6FPqOx2xM1/S0ec5zSQUaRcoaljHRanG1RmMcUQzHODiJxjzU9gvy5V0qMPBO+jv6EDZk2Q8hq1mS6Ya7vMR6Td3NB8AvF0BGOEMcwlFW7/nbbeNjLi+Qz87BQAlOMITY46AFhbLGcvP9M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z0qAs5f6; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z0qAs5f6" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-476a130c138so3086871f8f.0 for ; Sun, 16 Aug 2026 21:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786941136; x=1787545936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Uj3EudBSTWdM9VnNGeDbLYrQoc+1vLbVkReBzm+LJ5o=; b=Z0qAs5f6u0SN6F6m1FH4aIulcVP9FJN/vc7Ar0lMxcUsT3SA2e9BEsDxZv7d8PnVHX GBsY9bpBW9xVoaEyAGawYFcigzvqZqCqCGeKaKyaZLdFYEVV1B38a/d8ib4LvntO2bvg eIA8s4w0xTbLGImNwi9vRN3jvUd8gvYB3SZEIKXfod5TsV6u2eu4TOS/weUqBVyrorwG NmE6t9ZJYEXJxFpw2xMoILhBt0KwxWH0vRPCE7K0w7wtybvpd/4htjCTJ+FCrBMc4LCU y6TBD2IPKtzPwAJ7jD50wxdKsh8PlHNRgv9+DkXVMuXa1l1RSEaTzLtfCjCtgIj2r0Sf eOrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786941136; x=1787545936; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Uj3EudBSTWdM9VnNGeDbLYrQoc+1vLbVkReBzm+LJ5o=; b=ml7LopjCu6CF6UW1TI3/nda4vJskJYkRfSzdiWSDwUPhGZXDRRm3bAGZ0wlVBP560C 1GJ11JeOsA6grC7gc7b10wSsnIxOyquoogEccZ1wzYvgn266LTxDpf6YsVCBLTIMzUY5 m1n07DBX8semCgA1I56o6AlC4iX5tpgDVvHKXSbLDOFcLCuoNaEZjWAmr7oVPEsSuCae d6ShVMAWa/R6I+hviP8gKUQX2rDHrlzH/+iO167n1MdX0ZrN5oHkZF3cecg+aEROvJvM ITF1FgRv+fpFxQ+wH5aDzMTnuHbaGLPEwXwenkzsEy68FLY98eyAU3iXIv7dl0afFkI8 T36g== X-Forwarded-Encrypted: i=1; AHgh+RqlvtYFeiowwftZkqbELWE366wWnNkZ6569Qr2Pwi3e4+yeaw4OFMr5hx0EwKXiXd7NIuuYW8tUDDOjTcs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtlc1wkGIbYZCIOIJKRQA2/c00kiQptsDpd2Ht+H8+9GdFMFNg uLIjbDdhisczhgxWsmI9s08JT4ycRzIL60Z71528qbNTCVBuxh2TKO6A X-Gm-Gg: AR+sD1238IIOa7a8IIAXU/U4f6jYSTpLror0m+SQtkdGhROrEBL5QQH7vMEQ13y22X6 20kcH2h88U9DBWX3KfKsIPjMoovcvADrqbNIrpCHvQn2PTlIgM7zDMuubbc5pLKyDNXbwcOPfLY YUTMGX5vkpMRL6cd0o4OdR21SGzpVYM3FeL2cGZBnkoLAGXX+xu4ikYeC4kqCyv3Mtl3ACIw/QW Ln6TJb0wxf2vwk5+4isJGUM6IMFNMCMHsImHs+eSBLGhv8kfRa3uDjc9cY2+o+VGMHT1aIl8mVI DHgE+MNGUrjackIIBPYGB8OqFWqh0mOiCeCO7aYx5VKfTrWGLVyJm2+IT/gPKdlRW5ODfgIavRH miaN7osZu2K597QUGMQkZ3nWbgkMqKHv8PcW/DSieRQr0Qq2CIJy52MVSTtrt/0ynM75nSv8Fgx dmddjsWp1rgc2v3ohYp/yGSAO8fH7R64qmewo8lnu56c7z86BkeQilSLFjDLROAY0qG5VtgOzB3 XR/lYb00daRUkyOATllwGS24XrN5UJk6i45WwJTyhR1H6/iRQiFRHJNEGq06O8/PaiJMm/nY2u0 GEH9wGAXQflNidbtR30qVmZ5xMT2uc9YNNttSk8= X-Received: by 2002:a05:6000:41cf:b0:482:96bc:3717 with SMTP id ffacd0b85a97d-48296bc37ffmr21474458f8f.21.1786941135933; Sun, 16 Aug 2026 21:32:15 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-219-094.95.114.pool.telefonica.de. [95.114.219.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a315bfsm540465f8f.1.2026.08.16.21.32.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 21:32:15 -0700 (PDT) From: Karl Mehltretter To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Karl Mehltretter , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] 8139cp: fix Rx and Tx not being disabled in cp_suspend Date: Mon, 17 Aug 2026 06:30:57 +0200 Message-Id: <20260817043057.20099-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On QEMU rtl8139 model, frames that arrive while the interface is suspended still end up in the stack after resume. With pm_test=3Ddevices, which keeps devices suspended for 5s, 200 frames sent to interface during that time and 50 frames after resume, eth0 reports 113 received frames. cp_suspend() is supposed to stop receiver and the transmitter, but the mask is wrong: (~RxOn | ~TxOn) is ~0, nothing is cleared and Cmd still reads 0x0d when cp_suspend() returns. Use ~(RxOn | TxOn) so both bits are actually cleared. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Karl Mehltretter Reviewed-by: Andrew Lunn --- drivers/net/ethernet/realtek/8139cp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/r= ealtek/8139cp.c index 5652da8a178c0..9016527e229ac 100644 --- a/drivers/net/ethernet/realtek/8139cp.c +++ b/drivers/net/ethernet/realtek/8139cp.c @@ -2066,7 +2066,7 @@ static int __maybe_unused cp_suspend(struct device *d= evice) =20 /* Disable Rx and Tx */ cpw16 (IntrMask, 0); - cpw8 (Cmd, cpr8 (Cmd) & (~RxOn | ~TxOn)); + cpw8 (Cmd, cpr8 (Cmd) & ~(RxOn | TxOn)); =20 spin_unlock_irqrestore (&cp->lock, flags); =20 base-commit: 3eb40771c00a8488fa6ed2cc1fe203477908bf38 --=20 2.53.0