From nobody Mon Sep 28 20:14:31 2026 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A85361DA7 for ; Mon, 17 Aug 2026 18:45:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786992341; cv=none; b=ftna9A5kPI5oz/XLaZ/41aKeLlHUcZIF8AeFZb6LWDoENowBX5VpwvpEMAAJGowNihbv9I1FLriLXGzZ6mC79YtmgODN+Runvj/i6JkARs95aJnZSniS88Au+ePjLxVu3wKmRR3Z4XW4vELngpQTtKFaX3GClv97FErDI4mHipE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786992341; c=relaxed/simple; bh=yGAaKFJAzH37Muwf5TnNtOV64qpWtP5WCb/iQ1KXRSc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=HlwFqyNKyhcvZtVzoeZuRENHfW0d9LmDhE83adI4qY6uqLISfdZccfDQBbSEztoVb4sFYv+ZP4jcZ64n1MTqqbB/yh32lR/mVwLFEdmEYS0Rkwz+5C2y/6KsM6FRHZDp9kX5oX52c7FjTXDewF9Tt6KA4w8VFbmH3Swe9Mrztk8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=Lu7z3KMT; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="Lu7z3KMT" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:Message-Id:Content-Transfer-Encoding:Content-Type: MIME-Version:Subject:Date:From:From:Reply-To; bh=gtm9xUw2u/GN7ZmZC4DeoeJKYlW2jBvNe8u6Se+tv5c=; b=Lu7z3KMTjGulART6X0qUh9y0XW O/nxih5ZXMbMjuMmguisqXZuOCFnNXYVIDYvBBh8sBarNOLQPTwxzZFSrXNsz/+1jRULqla2Giyt0 LchXOGaVybHdj5nnbP9iGYP0vGtGnhaVkuOatNGlliygs9/q6QkGVF16jVB4LkeMxhdAFttdmKvmM mEN2B5/3EQ5mkB7Mc68Ui5NG9FeKsnx4kNswPVy4pp2grJGMr2/KfI5Nsy+TbRarKDMvF0JsguZmg x3WtVKvG5CK1QHj0jBta2bH07kikK30Jw3vF0oxuWLdzxo5A2SyJPc4NYXKbc5WdSiLZKTLHZ7EgZ v31ZXNIg==; Received: from 189-69-160-4.dial-up.telesp.net.br ([189.69.160.4] helo=[127.0.0.1]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1ww2Kw-004rtf-GR; Mon, 17 Aug 2026 20:45:30 +0200 From: Thadeu Lima de Souza Cascardo Date: Mon, 17 Aug 2026 15:45:20 -0300 Subject: [PATCH v2] drm/atomic: remove bogus check for file_priv Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260817-drm_atomic_bogus_check-v2-1-2b9e60f32a7e@igalia.com> X-B4-Tracking: v=1; b=H4sIAMBWg2oC/4WNQQ6CMBBFr0JmbQ00BcWV9zCEtNMBRi01LRAN4 e4CHsDlS95/f4ZIgSnCJZkh0MSRfb+CPCSAne5bEmxXBpnKIj3JUtjgaj14x1gb346xxo7wIVR e2LwxBRGVsI5fgRp+7+Fb9eM4mjvhsNU2o+M4+PDZn6ds8/6eTJnIhFY2N1ZpUni+cqufrI/oH VTLsnwBSOqRU88AAAA= X-Change-ID: 20260729-drm_atomic_bogus_check-456d5fb6eee9 To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Melissa Wen , kernel-dev@igalia.com, Thadeu Lima de Souza Cascardo X-Mailer: b4 0.16-dev-62088 Since file_priv can never be NULL at prepare_signaling() as it is only called by drm_mode_atomic_ioctl(), remove the check. If that was not the case, skipping the rest of the block here would cause the drm_pending_vblank_event object to leak and fail to set up the fence in case out_fence_ptr is set. Since the check is unreachable, there is no possible leak. Signed-off-by: Thadeu Lima de Souza Cascardo Reviewed-by: Melissa Wen --- Changes in v2: - Change commit message to indicate this is not a reachable leak. - Link to v1: https://patch.msgid.link/20260729-drm_atomic_bogus_check-v1-1= -a4d5bd4ae4c8@igalia.com --- drivers/gpu/drm/drm_atomic_uapi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic= _uapi.c index e997917819e8..657c15474ed5 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -1445,9 +1445,6 @@ static int prepare_signaling(struct drm_device *dev, if (arg->flags & DRM_MODE_PAGE_FLIP_EVENT) { struct drm_pending_vblank_event *e =3D crtc_state->event; =20 - if (!file_priv) - continue; - ret =3D drm_event_reserve_init(dev, file_priv, &e->base, &e->event.base); if (ret) { --- base-commit: ab243f74ab4084ca5c8dec608cb5b0deb27db067 change-id: 20260729-drm_atomic_bogus_check-456d5fb6eee9 Best regards, -- =20 Thadeu Lima de Souza Cascardo