From nobody Mon Sep 28 20:05:43 2026 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28A45446842 for ; Mon, 17 Aug 2026 19:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.139.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786994973; cv=none; b=MVIgQjlxERFg4but03zcl9d84nHbgevkr30Sdv+I47UlHORGy2hiPMybKkxuMEoUGfTbGStodbOwUMKNz6lFSUFVxi5LUIicoUn3zGRGWXkuY0RcYlxfO6jqZU7wP/eQEkXi3YSIUNK79hMYR8LuRE9Hly2jh/PQT6ABc2kk2/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786994973; c=relaxed/simple; bh=sQa7UCD0szsYuQ5e/aenabYsYKMOIzSf4csEoE48M9s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=dxcauF/uiCFIHPReoamAnk9T7whchmkf/RO/n/cfWEI4YYPLJGlow7kMXWtMV0MKV8kvRBSHOjjZPDx4nKGgqToetuxwvk9uvipvp3pHfrlHDQ97GiIhmxA46/Il5txU6HQAmva522OzunGCh0nQu9yc8RHqKKbAP3xXN/ul8S0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=Ml6JzkNA; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=x1E5sDz6; arc=none smtp.client-ip=148.163.139.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="Ml6JzkNA"; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="x1E5sDz6" Received: from pps.filterd (m0167075.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HIYkX73617245 for ; Mon, 17 Aug 2026 15:29:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pps01; bh=tCSIsrM7OmCnAlwZ/2327BIkvY 40J+xCImoJUZ21VW8=; b=Ml6JzkNAZ4RpelKuMPr8FfHzGhTszj4acrOcKVBNbd 3yOyJuV5U6A4IskJVSL8oZ8BoOUv+dQx6/O2MS86TcSi4V5015fq7sKs8m5DkMXK z+OUmSNF8gJvl5XEuGNWX1ZracHm0nILwlvwHtP/lqAyaihZBSrBECsbjBN+Q1lg 9VHwCmTuGoReAtL6FBnOAjJOF1wu28SQytXhPiZRF7xJgUatrgI6I3geO7lSDgJK atKO/6NWiH3RdAByaKuOac0tRISESogdmtmtFFwJuvDjUE2knpKTuigufNYWUQ6o WGBNkIcAwykaGbf1sWWPbtQYGlWKWSx6Yn/5d+rFDCmQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4g3kbte5t6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 15:29:28 -0400 (EDT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e5fc4c7e9so493648585a.3 for ; Mon, 17 Aug 2026 12:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; s=lionmail; t=1786994968; x=1787599768; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tCSIsrM7OmCnAlwZ/2327BIkvY40J+xCImoJUZ21VW8=; b=x1E5sDz6ZdunL6LAF8cFWXRB3mKu+EMiCZ0x9ZwYRgAMjXkadoN+E+S2XklDBE4OGB uSwoAgW7CgX9luIU303BsNL6lxF+OvUHvyvnrAqr/SfKRaGHJg4sYMcqwX9MP3JM/rZ3 IeiZZh5RdTL168Qgwy6ecgT2qJwVeB8S34gKvV8nKE69wfru5mSgwYUPU7bNaJRP0Zmi XVYu3Keqe6j1vYWvokzSSntJ3+kATPTmqAvYDeSSDqN8HSwDrh+c/dkTSCSL13Bl+8Qq lnu4PxEpFo0HnPCB99EkNdKA5cJE0tbA6x1tIJtCn8JJEC0CTj7Yt/JvfW2PhARoGIgj tvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786994968; x=1787599768; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=tCSIsrM7OmCnAlwZ/2327BIkvY40J+xCImoJUZ21VW8=; b=Q2azZ8Rjq44Q8fde21iqGpF1wYNuUltCCf0KvV2FQYKpgjt8kxCWQN/ukAjuVePzZd NjT0IViry7opO4RIlNp1LAsuQrY0BjMTa3fTHs6vvJclzDLRSJ98Rllb4M/ba7pPaWrB Y/g2vD8j+PrFICf6l31fymll/RaP6l3HmR9YXkXh2v2GCKBmG5KIagnMt0gmadnTjv95 dXSYUzg5wXFg5MKB6FC+y8ml8KQIKlAKAQj6hIZaXGsQ71Nafkslu+mdKX1XdFdt5bro pbPuI4IFIsD930cj3tyQpjhmRlkHs0qkOS4BSgNIGVgjM4uhz9wzfIDhliEqQfmd0CSZ BmRw== X-Forwarded-Encrypted: i=1; AHgh+RrqOySg+ZaBRTX9WNOdX0SgamP6JkrFF4PtW7FDbEDDLF25GHLxAon/KB0L7XC6sASzMcuFANp0yiP+CXQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3UEcWeW08ZbO7m5HSbJQDBPbE2hANLBsa2GXx4AK0iejPxOhU qQVDSuEwBhKmD4znZHVLY+bLoqDnAcaCVFJHEPFXT6VTZsTt7AITeSqVW0NspesZnSXuEXYPSmW ZmqlQ81dUchMD5KdKgdt+NbQOE3z6DMCrTjugd9D1uLJWfNL8MBF+hcJjAdz5Cw== X-Gm-Gg: AR+sD10wXx4z+VWfjVpf4/hfq2qu17JYJaz2LuZeu6ZTHPd8Lmsuf+kT0Sbk6PJ//Bw e0R7TrAxawO7K4ABeVZW2XyCzCVkcYAtt4jG0LNqTLBsQZACAnJwVzGIfVq4IX24dwqumjXrUag Vi8Cyxi6WWlyIw8KkbOjgeRlHTi0ecsIaJlqWbm+Pjh3ysjrQ5yzc8fkkpTVNXnCLuk/PEUmfvr HWXOxU0xd/4iH29U9Wpotr12Q8E7Lviz6O81fY6rB3eN5frtfN7UEi5sHSNjB0uLjpDaRpsNhHU JxgkgM3xmrKJlLf88rgS/jAHmLf8ysnDMeFkJogjrQKkDZWpzJei30VQgVjTMOMILxsFgyTKG8U IPdRhWvri X-Received: by 2002:a05:620a:720a:b0:936:695a:185a with SMTP id af79cd13be357-936d2356e91mr2453562885a.44.1786994968404; Mon, 17 Aug 2026 12:29:28 -0700 (PDT) X-Received: by 2002:a05:620a:720a:b0:936:695a:185a with SMTP id af79cd13be357-936d2356e91mr2453557085a.44.1786994967795; Mon, 17 Aug 2026 12:29:27 -0700 (PDT) Received: from [127.0.1.1] ([77.137.67.107]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a7c57fsm5972617f8f.22.2026.08.17.12.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 12:29:26 -0700 (PDT) From: Tal Zussman Date: Mon, 17 Aug 2026 15:29:17 -0400 Subject: [PATCH v2] libceph: remove ceph_put_page_vector() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260817-ceph-put-page-vector-v2-1-477dce5372dc@columbia.edu> X-B4-Tracking: v=1; b=H4sIAAxhg2oC/4WNQQ6CMBREr0K69ptSBYor72FYtOUj3yhtWtpoC He34AFcvsybmYUF9ISBXYqFeUwUyE4ZxKFgZlTTHYH6zExwUXPJWzDoRnBxBqdymNDM1sO5klq flJLNULNcdR4Heu+zt+7HIepHlretzRgp5OJn/03l5v25SCWUUDVKC8UlmpZfjX3GlyZ1xD6yb l3XLzL8p6DNAAAA X-Change-ID: 20260809-ceph-put-page-vector-458bb3aa87f6 To: Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786994966; l=3080; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=sQa7UCD0szsYuQ5e/aenabYsYKMOIzSf4csEoE48M9s=; b=6R7TZmrHc+YmdrSyvO3WLU9j2dvmPV77Hm1eZprfueiqbEnzKZzHaN5TQitXcEp+wrJ4jY2rO PenEP2NzQjBCr10xQZ34bIB65MEN06UDqk4lpDrgS9zyU1+O+i2YArC X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-ORIG-GUID: Wc8qscDVgP2VZOgiyfG_0COIByE1_UqD X-Authority-Analysis: v=2.4 cv=McdcfZ/f c=1 sm=1 tr=0 ts=6a836118 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=+gpNN1aRt999K7yrv1sWlQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=A0y_DWxS2BwA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=HpS3TJQ9O3Ob1ozEcmik:22 a=VwQbUJbxAAAA:8 a=9oKN_-3_2LoZvJdpknsA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDE0OCBTYWx0ZWRfXzLW+b7YmwNwl S22gE6Rf12Sg8m2XvVqeX9WAO4Nt+UEgluDK28eqki2XiVmy/ayVxb7LKsaIZrjLFb9jZY5i/8r YeE/c0LW10QQd0Ag2jw3LjOdALQEUlhP5SzBTGqyrUXz803qss1c X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDE0OCBTYWx0ZWRfX1JAYIi2MXh2b A3M0vwvx5kZ72klXD2YJyJUATydZiF275sCLs+KoyX7yN8CUaSj50tJgMOejfpEuZKFb6IN9ICo ob7KyMSgDirx0WKRy2ncJx+w+V8FtOaW5LUKEgfKaGoTlrzJ8QDfNHHBUhdGg10VHPoKIEMTErH 94sBJEjAIPCU2SVLo7hLMFkHxa9Yd37SetAU1mPJyihS4JFx6BVjMYcTIgJQvDVF7RRcPYXycpd I+lyWVuTt6/8OqcAlvp3yYGsJZfiEoUbYdIQ//2XTVQWc2S7i1DUvFahg0vFUQm+9Xi5+Fg3JDG zP31GTarmU6KjD9oJDW5AbzqtRpWg40nwDLSuKuAxIk9i9tZMhjfNoT4zk7uUeQM/MI3eZZ+UDZ 4TwypghwmXNqushj4LmEC//yWZ9yEdQ7ThpajCIog8NfyK9uNyicU5zZWz8yx0mfgKx6mNrR/eI Tc2wCEYhieDXPzVnOww== X-Proofpoint-GUID: Wc8qscDVgP2VZOgiyfG_0COIByE1_UqD X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11878 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 malwarescore=0 suspectscore=0 bulkscore=10 lowpriorityscore=10 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=10 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170148 ceph_put_page_vector() was paired with ceph_get_direct_page_vector(), which was removed in commit 97a385e55829 ("libceph: remove ceph_get_direct_page_vector()"). Its only remaining caller, finish_netfs_read(), uses it to put a page vector allocated with iov_iter_get_pages_alloc2(), which is confusing. Open-code the put_page() loop and kvfree() there instead. The caller passed dirty =3D false, so this also removes the dead dirty branch and with it a call to the deprecated set_page_dirty_lock(). Signed-off-by: Tal Zussman --- Changes in v2: - Remove ceph_put_page_vector() entirely instead of only the dead dirty path, open-coding the cleanup in finish_netfs_read(), per Ilya - Rebase onto ceph/for-linus - Link to v1: https://lore.kernel.org/r/20260809-ceph-put-page-vector-v1-1-= 57ab2a08ec90@columbia.edu --- fs/ceph/addr.c | 9 ++++++--- include/linux/ceph/libceph.h | 2 -- net/ceph/pagevec.c | 13 ------------- 3 files changed, 6 insertions(+), 18 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index ecf33b66610c..0af7387ce7ec 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -255,9 +255,12 @@ static void finish_netfs_read(struct ceph_osd_request = *req) } =20 if (osd_data->type =3D=3D CEPH_OSD_DATA_TYPE_PAGES) { - ceph_put_page_vector(osd_data->pages, - calc_pages_for(osd_data->alignment, - osd_data->length), false); + int num_pages =3D calc_pages_for(osd_data->alignment, + osd_data->length); + + for (int i =3D 0; i < num_pages; i++) + put_page(osd_data->pages[i]); + kvfree(osd_data->pages); } if (err > 0) { ceph_subvolume_metrics_record_io(fsc->mdsc, ceph_inode(inode), diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h index 63e0e2aa1ce9..691e1bdece49 100644 --- a/include/linux/ceph/libceph.h +++ b/include/linux/ceph/libceph.h @@ -313,8 +313,6 @@ int ceph_wait_for_latest_osdmap(struct ceph_client *cli= ent, =20 /* pagevec.c */ extern void ceph_release_page_vector(struct page **pages, int num_pages); -extern void ceph_put_page_vector(struct page **pages, int num_pages, - bool dirty); extern struct page **ceph_alloc_page_vector(int num_pages, gfp_t flags); extern void ceph_copy_from_page_vector(struct page **pages, void *data, diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 858359873c4d..a6aa5b3b7a1e 100644 --- a/net/ceph/pagevec.c +++ b/net/ceph/pagevec.c @@ -10,19 +10,6 @@ =20 #include =20 -void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty) -{ - int i; - - for (i =3D 0; i < num_pages; i++) { - if (dirty) - set_page_dirty_lock(pages[i]); - put_page(pages[i]); - } - kvfree(pages); -} -EXPORT_SYMBOL(ceph_put_page_vector); - void ceph_release_page_vector(struct page **pages, int num_pages) { int i; --- base-commit: 91880e4a7fac45bc407771bc57bbaf4f37e9b4c3 change-id: 20260809-ceph-put-page-vector-458bb3aa87f6 Best regards, --=20 Tal Zussman