From nobody Mon Aug 24 04:17:54 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DAE3CB2C7 for ; Sun, 16 Aug 2026 19:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909182; cv=none; b=ZcBNnX+grFdOtJg/hKS6HmBgq5lWuBV2KAQ3uXhc5D07SXRErdjq2Sw2tNIPz5jPK7Rh+1VmUMDweW0rQFv6+t8R5McTXZ2x5n4Y68Y0IOG10hXHmLRn81paZRRnjVohjswuFwfRXxa9xY6F2o7IUagFAP2zavhzqPvM0hqwjpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909182; c=relaxed/simple; bh=3pCFJIQOEu9d96vXOMLd4lwrCzD6ScI84FNbite1h+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j1M3qDTN9DSdAiMVQZlbfy+ElRAtUGiG0+KKkdlP0bul/fteaOOPATQOdjfBBmHbHwgORaJa3zrqGVVatuD6PIVjYBXSyfX0qm/zcFa+AJugx9KkStTsDdKXcxPPHnjf6boQPErCSEELHRu+cGwxhMVLmTC/MpUOaMvoIMqrRd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F2/42HVG; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F2/42HVG" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-cbe6295f05bso2563507a12.1 for ; Sun, 16 Aug 2026 12:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786909180; x=1787513980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WZYHIFroVmV+7VlNpb25EE1plVrmMIM2jzBfwjtS3Q8=; b=F2/42HVG00p7KPzqIMw+5VUcOh9JIOHYFGQGzE/SLIxmn0lc1By+vRvtvPy58rDtF7 sPV1Cenu/aNq7HMBgJDlus7sSYXAvBdmhcvYfXrMcMILRamkCWunREcvTNpF0CZmRf1Y O6EpCwWiGsrtP04+Yfz5WlBi/4l8J9Ayk0sD5tIR8NFdOFI+kLVbieR8beqg6iLFwQOg mbkipcPuoF5q6ykqtO7rClAyZLXY+fOfVGDb7PYq8dPLZtNxWdi9YHigc5YBsIQaC/9E 5BInzyss/CpRWOj08UGK/0RICyddCc5mL0y6mkwu58e6N0eAxpX4/OsdynJk2M3mrpW0 gb/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786909180; x=1787513980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WZYHIFroVmV+7VlNpb25EE1plVrmMIM2jzBfwjtS3Q8=; b=d8Fh95g17afooxykw/utQdh76SJ8aSEoT7A/8IBiFQP9GBqJdYRIPfeZ9E3Rc5VPKq cmNuO05eMbuqDDraPVVzuDwB1n1SMHRX9wIzp1O6sciwC7V1rIE9hdLF1N8iuTGffwgb c9gUWhgHl0kLScsIVZfD2RM9KOk66r+xri2DQwwZypwJ5YQmTcn+YMkZ+w6TgLr16hsP fOcbEJbktywqDpB7ugnheVlTizll8pnF3zELsMb1grdvMp4J4t0yakMDYTbefQcE7xtL g7aF1izSv5OincMX/ErPI3+0cFq1LJ7TiQvE+pBE34+ZXuTIBtn39Ob/TAqe2HuVHPyt 8X5g== X-Forwarded-Encrypted: i=1; AHgh+RpGw+M46xlbKvH+VUWPHGhuBUerrsSAe47Rul1pTS9J8hr5SxXHpAd1U4p5lg4+zuBnzIZm04JGU4XV3RQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyJv/+wXjut4GkunhBNZ0pXAPwT11gXpSpXGY7EfRZK0EkheqWR P6mhqBr2nRyMG7Xnr0jRDJXyaNv91C6j3A5ZfwNdkG8CWjlPpwsTucrO X-Gm-Gg: AR+sD12VkNhxOydRhw4rt+4f3jZV3SANpnQV1hokpDFU4i8sTj47/qZnUqpLsXQkSpX x/M+2SVXXsGrvjz0U8RqnmtEr1/DyC9OUm6PrdpyZ8NhAX6zlvLleGCpm6txaEmzi8iwLbbRO4f f72sTkUc/05Q5f4v+Ozi0Vk+mbI4yMT4ShEh4km+Dd8iDFZx7VY2hiE0SyAEU4XCSjXIb4S+/A0 xYHxvD6a/lHyWd5CPmnYIrzq8c/xPTsznrucMRHyyuAQSSDKOjB1R1S+S+D3RSQLHq9ZAOP9io1 runVbcbI9HJ4PjG7zrrLtyB4AOc5K0ZKfga7l1V2tcJucKigy3sFMtM8Jae012yqSBBF2o/uH1+ 8u3rCTfwmw9jy7VXazIpZfyEeGWkafv80sARys83598ezHfKgo4c9txw1kUH9M8nM6nsCcm6SPY vsN2rTK8i6zlepSFq8Xda4B7Q2aGyssH6Vs+GJh9Zga06aLCvNuxJzthNywhV1K9z6Gk70+2wge ABgLE3Y9cPezKdAfreK4Kp3 X-Received: by 2002:a17:90b:1d01:b0:38e:7f22:f674 with SMTP id 98e67ed59e1d1-3933b09e9e2mr14971429a91.11.1786909179611; Sun, 16 Aug 2026 12:39:39 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac1:7680:d30::4cf:1a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531e10d9fsm2244065a91.3.2026.08.16.12.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 12:39:39 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v10 1/4] net: dsa: motorcomm: Move to subdirectory Date: Mon, 17 Aug 2026 03:38:56 +0800 Message-ID: <20260816193905.218112-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816193905.218112-1-mmyangfl@gmail.com> References: <20260816193905.218112-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" yt921x is already the longest single-file DSA driver, so it's time to split it into parts. Signed-off-by: David Yang Reviewed-by: Andrew Lunn --- MAINTAINERS | 2 +- drivers/net/dsa/Kconfig | 10 ++-------- drivers/net/dsa/Makefile | 2 +- drivers/net/dsa/motorcomm/Kconfig | 8 ++++++++ drivers/net/dsa/motorcomm/Makefile | 3 +++ drivers/net/dsa/{yt921x.c =3D> motorcomm/chip.c} | 2 +- drivers/net/dsa/{yt921x.h =3D> motorcomm/chip.h} | 0 7 files changed, 16 insertions(+), 11 deletions(-) create mode 100644 drivers/net/dsa/motorcomm/Kconfig create mode 100644 drivers/net/dsa/motorcomm/Makefile rename drivers/net/dsa/{yt921x.c =3D> motorcomm/chip.c} (99%) rename drivers/net/dsa/{yt921x.h =3D> motorcomm/chip.h} (100%) diff --git a/MAINTAINERS b/MAINTAINERS index 991460050da7..55cc5ac0e86f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18256,7 +18256,7 @@ M: David Yang L: netdev@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/net/dsa/motorcomm,yt921x.yaml -F: drivers/net/dsa/yt921x.* +F: drivers/net/dsa/motorcomm/ F: net/dsa/tag_yt921x.c =20 MOXA SMARTIO/INDUSTIO/INTELLIO SERIAL CARD diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index 4ab567c5bbaf..98e9bbe47de7 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig @@ -72,6 +72,8 @@ config NET_DSA_MV88E6060 =20 source "drivers/net/dsa/microchip/Kconfig" =20 +source "drivers/net/dsa/motorcomm/Kconfig" + source "drivers/net/dsa/mv88e6xxx/Kconfig" =20 source "drivers/net/dsa/mxl862xx/Kconfig" @@ -158,12 +160,4 @@ config NET_DSA_VITESSE_VSC73XX_PLATFORM This enables support for the Vitesse VSC7385, VSC7388, VSC7395 and VSC7398 SparX integrated ethernet switches, connected over a CPU-attached address bus and work in memory-mapped I/O mode. - -config NET_DSA_YT921X - tristate "Motorcomm YT9215 ethernet switch chip support" - select NET_DSA_TAG_YT921X - select NET_IEEE8021Q_HELPERS if DCB - help - This enables support for the Motorcomm YT9215 ethernet switch - chip. endmenu diff --git a/drivers/net/dsa/Makefile b/drivers/net/dsa/Makefile index d2975badffc0..138225baa4d5 100644 --- a/drivers/net/dsa/Makefile +++ b/drivers/net/dsa/Makefile @@ -14,11 +14,11 @@ obj-$(CONFIG_NET_DSA_SMSC_LAN9303_MDIO) +=3D lan9303_md= io.o obj-$(CONFIG_NET_DSA_VITESSE_VSC73XX) +=3D vitesse-vsc73xx-core.o obj-$(CONFIG_NET_DSA_VITESSE_VSC73XX_PLATFORM) +=3D vitesse-vsc73xx-platfo= rm.o obj-$(CONFIG_NET_DSA_VITESSE_VSC73XX_SPI) +=3D vitesse-vsc73xx-spi.o -obj-$(CONFIG_NET_DSA_YT921X) +=3D yt921x.o obj-y +=3D b53/ obj-y +=3D hirschmann/ obj-y +=3D lantiq/ obj-y +=3D microchip/ +obj-y +=3D motorcomm/ obj-y +=3D mv88e6xxx/ obj-y +=3D mxl862xx/ obj-y +=3D netc/ diff --git a/drivers/net/dsa/motorcomm/Kconfig b/drivers/net/dsa/motorcomm/= Kconfig new file mode 100644 index 000000000000..1fddd386f866 --- /dev/null +++ b/drivers/net/dsa/motorcomm/Kconfig @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: ISC +config NET_DSA_YT921X + tristate "Motorcomm YT9215 ethernet switch chip support" + select NET_DSA_TAG_YT921X + select NET_IEEE8021Q_HELPERS if DCB + help + This enables support for the Motorcomm YT9215 ethernet switch + chip. diff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm= /Makefile new file mode 100644 index 000000000000..afd03be9fa35 --- /dev/null +++ b/drivers/net/dsa/motorcomm/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: ISC +obj-$(CONFIG_NET_DSA_YT921X) +=3D yt921x.o +yt921x-objs :=3D chip.o diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/motorcomm/chip.c similarity index 99% rename from drivers/net/dsa/yt921x.c rename to drivers/net/dsa/motorcomm/chip.c index 159b16606f6c..f070732845eb 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/motorcomm/chip.c @@ -26,7 +26,7 @@ #include #include =20 -#include "yt921x.h" +#include "chip.h" =20 struct yt921x_mib_desc { unsigned int size; diff --git a/drivers/net/dsa/yt921x.h b/drivers/net/dsa/motorcomm/chip.h similarity index 100% rename from drivers/net/dsa/yt921x.h rename to drivers/net/dsa/motorcomm/chip.h --=20 2.53.0 From nobody Mon Aug 24 04:17:54 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECF913C8C7D for ; Sun, 16 Aug 2026 19:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909188; cv=none; b=lC/wH39x5efnD2ZA/ZQtHQ10Dfzj/oYd5Q3p3kQqOMoVgWNArY6Tm+6LiyeL0TQCyOEAGom5ByfJKLkLK2HQcblX2WQ5ojSvHoVPmj6IlDluEPf2ikCjWb5W1Nk2m/p7Kc/uZbo5Jhfn4lq6DaODH4kwjygnLFh+Qo/qIyCnUqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909188; c=relaxed/simple; bh=eEcN1HXPyBaQGvYWryjFTWu7HvxXkOWR9Ns4Hw2kwNk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qIP8dTkzcb8HOdecercncs2FtWmIWigO4oHgbl3s0V7FtYyfcwm185iZmG9efN3RbRJithZY884O9vX5ykjwNeYmtr2dBZ17O0AemQ/fcHDuQYvjX8nFJ8F5OXEVCE7SrRnTeoHEJRarDS8ImXBiuuU4rh75FtfQmAuq4oDyjVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h++h8zO1; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h++h8zO1" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cc61541f8cso46044605ad.0 for ; Sun, 16 Aug 2026 12:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786909183; x=1787513983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Fr1adCZarShVnf0lDmjhW7xvO8QbtTma3JXt+bfZWsA=; b=h++h8zO1PAMGT9xJauZYAnQm/R/lW0KlpcHe13MXu0ptLo7150EaI/RhbDXEnqtw7H VhI0K0GOhanbNLI9K3H/TaafxWaDEQE3WSgcxzaxadBjVxYCyqf8e3LMpTlx1FQw9N+C x0ECms3zX5wGO1WiBXp+U/lDtZJYhba5mW8E60OYz1d57jBr1jDtGjP+4kl9rGdMTIri yPqetHejaIw3jGJBPrGdI09e4nRucxFQUuQRqSRvrMu/ZTMCmYWI7HEXQlqmbifwcBJf LiV0gWXt3M+4uQDL6n4zN8//fGchCbeKzWBswog7TUrLyPIVWc9hI+eXASq0YfsicZID eZwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786909183; x=1787513983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Fr1adCZarShVnf0lDmjhW7xvO8QbtTma3JXt+bfZWsA=; b=NUga1sPBdUhUgwnMzrkOHWpQTPvw1X1e2RpHTGwrJJLdOJBVpZPSut5TocwRzO+qt4 t/HENX06/a2bk5fzuXuXworRIxCooKHc7eWEGL1yjuFev5uqi4ujILcf03se1WhKY9LF LJzTbx1aDy+7dLmXGGbytZdSiQqbSYz5qbAEEMUnUQEN4DpGACVOQFir2nRhpE14cM4Z m1fzkIfVREDuOXUAqwjAWwyXKuCF+TuqM5GIo91i2LbFtQumHZ0efjdBaeEcu41mAoCc 41exeGBzjdVItijF1HEruPpgSHkjdET8HO/Besu2fQhPLPWe5qrQrV8e0PJOHZhiSSjZ X6bw== X-Forwarded-Encrypted: i=1; AHgh+RrTsmCdETY4XfGdgO5tftnI6DWzXpBeDq0QlBB/228mvFCDCtB1mrUe2S8wWIpYYDxBb4DZeo1ke33cXcc=@vger.kernel.org X-Gm-Message-State: AOJu0YzJU1/hqKoPjLmpkuy1UGwkee2xq7O1Q6QyNOsQiJFW8mBEbypI j9/Gyc4LYsoNzwAkO9UjJx7Q5fAkYu7+BXinDA4TupoCTjV2Jao1KVO4 X-Gm-Gg: AR+sD10QQtudoepJatSUIX2eAPrBeul95k137oyz2PH/EmhHy8Ehurwcz9WblUSmkpI svH+zwLrfWAN9fau0UUS23bil3lvsGjGhNNv143/5E0rz38BCxl+NQ64cGAuzA0V1V//n0tZGze fBDYHbgRRaKv99Hgj+3ABTlAwAcwFTUKn9dHi8geJKVzKS4f0u9Nawe3TfxVO7xUCzZ+K+4RTS8 mSadtP6QUYZPnUukgXJb5U00Yn5J2pA8SDFOK5hiuZ3Xdxmzom7uwG3GjyUnFAeq5WSmiFfE/jT qymCYgpiti/IR31r1X1IKcyvnuVsfzI8g0hszoSLNFVJAvCOw7nyFVVKauPU1iVh4hyl5wa8Txt TlGVIlq42zWlM5pW49JxtaITzEx7UtJkfmZGFHvwz6IHccTMeX6qy8fhWtdlLnWQF7BGESNeuCM WtDiAJGqNNRwCt+Je0LobL09/IRm5+/yEOL5zAGtnf54BMOkf0JZW7mkSF9m05bWKEXdtYRkDyU nrS08ein1kxmg== X-Received: by 2002:a17:90a:d610:b0:38e:c232:9d2c with SMTP id 98e67ed59e1d1-3933af03952mr15499145a91.2.1786909182974; Sun, 16 Aug 2026 12:39:42 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac1:7680:d30::4cf:1a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531e10d9fsm2244065a91.3.2026.08.16.12.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 12:39:42 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v10 2/4] net: dsa: motorcomm: Split SMI module Date: Mon, 17 Aug 2026 03:38:57 +0800 Message-ID: <20260816193905.218112-3-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816193905.218112-1-mmyangfl@gmail.com> References: <20260816193905.218112-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SMI operations are going to be used across different modules. Minor changes are applied to fix build errors. Signed-off-by: David Yang Reviewed-by: Andrew Lunn --- drivers/net/dsa/motorcomm/Makefile | 1 + drivers/net/dsa/motorcomm/chip.c | 207 +---------------------------- drivers/net/dsa/motorcomm/smi.c | 157 ++++++++++++++++++++++ drivers/net/dsa/motorcomm/smi.h | 92 +++++++++++++ 4 files changed, 251 insertions(+), 206 deletions(-) create mode 100644 drivers/net/dsa/motorcomm/smi.c create mode 100644 drivers/net/dsa/motorcomm/smi.h diff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm= /Makefile index afd03be9fa35..6cea5313a444 100644 --- a/drivers/net/dsa/motorcomm/Makefile +++ b/drivers/net/dsa/motorcomm/Makefile @@ -1,3 +1,4 @@ # SPDX-License-Identifier: ISC obj-$(CONFIG_NET_DSA_YT921X) +=3D yt921x.o yt921x-objs :=3D chip.o +yt921x-objs +=3D smi.o diff --git a/drivers/net/dsa/motorcomm/chip.c b/drivers/net/dsa/motorcomm/c= hip.c index f070732845eb..6dee25b6754a 100644 --- a/drivers/net/dsa/motorcomm/chip.c +++ b/drivers/net/dsa/motorcomm/chip.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include @@ -27,6 +26,7 @@ #include =20 #include "chip.h" +#include "smi.h" =20 struct yt921x_mib_desc { unsigned int size; @@ -155,9 +155,6 @@ static const struct yt921x_info yt921x_infos[] =3D { =20 #define YT921X_VID_UNWARE 4095 =20 -#define YT921X_POLL_SLEEP_US 10000 -#define YT921X_POLL_TIMEOUT_US 100000 - /* The interval should be small enough to avoid overflow of 32bit MIBs. * * Until we can read MIBs from stats64 call directly (i.e. sleep @@ -196,208 +193,6 @@ static u32 ethaddr_lo2_to_u32(const unsigned char *ad= dr) return (addr[4] << 8) | addr[5]; } =20 -static int yt921x_reg_read(struct yt921x_priv *priv, u32 reg, u32 *valp) -{ - WARN_ON(!mutex_is_locked(&priv->reg_lock)); - - return priv->reg_ops->read(priv->reg_ctx, reg, valp); -} - -static int yt921x_reg_write(struct yt921x_priv *priv, u32 reg, u32 val) -{ - WARN_ON(!mutex_is_locked(&priv->reg_lock)); - - return priv->reg_ops->write(priv->reg_ctx, reg, val); -} - -static int -yt921x_reg_wait(struct yt921x_priv *priv, u32 reg, u32 mask, u32 *valp) -{ - u32 val; - int res; - int ret; - - ret =3D read_poll_timeout(yt921x_reg_read, res, - res || (val & mask) =3D=3D *valp, - YT921X_POLL_SLEEP_US, YT921X_POLL_TIMEOUT_US, - false, priv, reg, &val); - if (ret) - return ret; - if (res) - return res; - - *valp =3D val; - return 0; -} - -static int -yt921x_reg_update_bits(struct yt921x_priv *priv, u32 reg, u32 mask, u32 va= l) -{ - int res; - u32 v; - u32 u; - - res =3D yt921x_reg_read(priv, reg, &v); - if (res) - return res; - - u =3D v; - u &=3D ~mask; - u |=3D val; - if (u =3D=3D v) - return 0; - - return yt921x_reg_write(priv, reg, u); -} - -static int yt921x_reg_set_bits(struct yt921x_priv *priv, u32 reg, u32 mask) -{ - return yt921x_reg_update_bits(priv, reg, 0, mask); -} - -static int yt921x_reg_clear_bits(struct yt921x_priv *priv, u32 reg, u32 ma= sk) -{ - return yt921x_reg_update_bits(priv, reg, mask, 0); -} - -static int -yt921x_reg_toggle_bits(struct yt921x_priv *priv, u32 reg, u32 mask, bool s= et) -{ - return yt921x_reg_update_bits(priv, reg, mask, !set ? 0 : mask); -} - -/* Some multi-word registers, like VLANn_CTRL, should be treated as a sing= le - * long register. More specifically, writes to parts of its words won't be= come - * visible, until the last word is written. - * - * Here we require full read and write operations over these registers to - * eliminate potential issues, although partial reads/writes are also poss= ible. - */ - -static void update_ctrls_unaligned(u32 *lo, u32 *hi, u64 mask, u64 val) -{ - *lo &=3D ~lower_32_bits(mask); - *hi &=3D ~upper_32_bits(mask); - *lo |=3D lower_32_bits(val); - *hi |=3D upper_32_bits(val); -} - -static int -yt921x_regs_read(struct yt921x_priv *priv, u32 reg, u32 *vals, - unsigned int num_regs) -{ - int res; - - for (unsigned int i =3D 0; i < num_regs; i++) { - res =3D yt921x_reg_read(priv, reg + 4 * i, &vals[i]); - if (res) - return res; - } - - return 0; -} - -static int -yt921x_regs_write(struct yt921x_priv *priv, u32 reg, const u32 *vals, - unsigned int num_regs) -{ - int res; - - for (unsigned int i =3D 0; i < num_regs; i++) { - res =3D yt921x_reg_write(priv, reg + 4 * i, vals[i]); - if (res) - return res; - } - - return 0; -} - -static int -yt921x_regs_update_bits(struct yt921x_priv *priv, u32 reg, const u32 *mask= s, - const u32 *vals, unsigned int num_regs) -{ - bool changed =3D false; - u32 vs[4]; - int res; - - BUILD_BUG_ON(num_regs > ARRAY_SIZE(vs)); - - res =3D yt921x_regs_read(priv, reg, vs, num_regs); - if (res) - return res; - - for (unsigned int i =3D 0; i < num_regs; i++) { - u32 u =3D vs[i]; - - u &=3D ~masks[i]; - u |=3D vals[i]; - if (u !=3D vs[i]) - changed =3D true; - - vs[i] =3D u; - } - - if (!changed) - return 0; - - return yt921x_regs_write(priv, reg, vs, num_regs); -} - -static int -yt921x_regs_clear_bits(struct yt921x_priv *priv, u32 reg, const u32 *masks, - unsigned int num_regs) -{ - bool changed =3D false; - u32 vs[4]; - int res; - - BUILD_BUG_ON(num_regs > ARRAY_SIZE(vs)); - - res =3D yt921x_regs_read(priv, reg, vs, num_regs); - if (res) - return res; - - for (unsigned int i =3D 0; i < num_regs; i++) { - u32 u =3D vs[i]; - - u &=3D ~masks[i]; - if (u !=3D vs[i]) - changed =3D true; - - vs[i] =3D u; - } - - if (!changed) - return 0; - - return yt921x_regs_write(priv, reg, vs, num_regs); -} - -static int -yt921x_reg64_write(struct yt921x_priv *priv, u32 reg, const u32 *vals) -{ - return yt921x_regs_write(priv, reg, vals, 2); -} - -static int -yt921x_reg64_update_bits(struct yt921x_priv *priv, u32 reg, const u32 *mas= ks, - const u32 *vals) -{ - return yt921x_regs_update_bits(priv, reg, masks, vals, 2); -} - -static int -yt921x_reg64_clear_bits(struct yt921x_priv *priv, u32 reg, const u32 *mask= s) -{ - return yt921x_regs_clear_bits(priv, reg, masks, 2); -} - -static int -yt921x_reg96_write(struct yt921x_priv *priv, u32 reg, const u32 *vals) -{ - return yt921x_regs_write(priv, reg, vals, 3); -} - static int yt921x_reg_mdio_read(void *context, u32 reg, u32 *valp) { struct yt921x_reg_mdio *mdio =3D context; diff --git a/drivers/net/dsa/motorcomm/smi.c b/drivers/net/dsa/motorcomm/sm= i.c new file mode 100644 index 000000000000..164c25ef494a --- /dev/null +++ b/drivers/net/dsa/motorcomm/smi.c @@ -0,0 +1,157 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2026 David Yang + */ + +#include + +#include "chip.h" +#include "smi.h" + +#define YT921X_POLL_SLEEP_US 10000 +#define YT921X_POLL_TIMEOUT_US 100000 + +int yt921x_reg_read(struct yt921x_priv *priv, u32 reg, u32 *valp) +{ + WARN_ON(!mutex_is_locked(&priv->reg_lock)); + + return priv->reg_ops->read(priv->reg_ctx, reg, valp); +} + +int yt921x_reg_write(struct yt921x_priv *priv, u32 reg, u32 val) +{ + WARN_ON(!mutex_is_locked(&priv->reg_lock)); + + return priv->reg_ops->write(priv->reg_ctx, reg, val); +} + +int yt921x_reg_wait(struct yt921x_priv *priv, u32 reg, u32 mask, u32 *valp) +{ + u32 val; + int res; + int ret; + + ret =3D read_poll_timeout(yt921x_reg_read, res, + res || (val & mask) =3D=3D *valp, + YT921X_POLL_SLEEP_US, YT921X_POLL_TIMEOUT_US, + false, priv, reg, &val); + if (ret) + return ret; + if (res) + return res; + + *valp =3D val; + return 0; +} + +int yt921x_reg_update_bits(struct yt921x_priv *priv, u32 reg, u32 mask, u3= 2 val) +{ + int res; + u32 v; + u32 u; + + res =3D yt921x_reg_read(priv, reg, &v); + if (res) + return res; + + u =3D v; + u &=3D ~mask; + u |=3D val; + if (u =3D=3D v) + return 0; + + return yt921x_reg_write(priv, reg, u); +} + +int +yt921x_regs_read(struct yt921x_priv *priv, u32 reg, u32 *vals, + unsigned int num_regs) +{ + int res; + + for (unsigned int i =3D 0; i < num_regs; i++) { + res =3D yt921x_reg_read(priv, reg + 4 * i, &vals[i]); + if (res) + return res; + } + + return 0; +} + +int +yt921x_regs_write(struct yt921x_priv *priv, u32 reg, const u32 *vals, + unsigned int num_regs) +{ + int res; + + for (unsigned int i =3D 0; i < num_regs; i++) { + res =3D yt921x_reg_write(priv, reg + 4 * i, vals[i]); + if (res) + return res; + } + + return 0; +} + +int +yt921x_regs_update_bits(struct yt921x_priv *priv, u32 reg, const u32 *mask= s, + const u32 *vals, unsigned int num_regs) +{ + bool changed =3D false; + u32 vs[4]; + int res; + + if (WARN_ON_ONCE(num_regs > ARRAY_SIZE(vs))) + return -EINVAL; + + res =3D yt921x_regs_read(priv, reg, vs, num_regs); + if (res) + return res; + + for (unsigned int i =3D 0; i < num_regs; i++) { + u32 u =3D vs[i]; + + u &=3D ~masks[i]; + u |=3D vals[i]; + if (u !=3D vs[i]) + changed =3D true; + + vs[i] =3D u; + } + + if (!changed) + return 0; + + return yt921x_regs_write(priv, reg, vs, num_regs); +} + +int +yt921x_regs_clear_bits(struct yt921x_priv *priv, u32 reg, const u32 *masks, + unsigned int num_regs) +{ + bool changed =3D false; + u32 vs[4]; + int res; + + if (WARN_ON_ONCE(num_regs > ARRAY_SIZE(vs))) + return -EINVAL; + + res =3D yt921x_regs_read(priv, reg, vs, num_regs); + if (res) + return res; + + for (unsigned int i =3D 0; i < num_regs; i++) { + u32 u =3D vs[i]; + + u &=3D ~masks[i]; + if (u !=3D vs[i]) + changed =3D true; + + vs[i] =3D u; + } + + if (!changed) + return 0; + + return yt921x_regs_write(priv, reg, vs, num_regs); +} diff --git a/drivers/net/dsa/motorcomm/smi.h b/drivers/net/dsa/motorcomm/sm= i.h new file mode 100644 index 000000000000..2995e91f3b3d --- /dev/null +++ b/drivers/net/dsa/motorcomm/smi.h @@ -0,0 +1,92 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (c) 2026 David Yang + */ + +#ifndef _YT_SMI_H +#define _YT_SMI_H + +#include +#include + +struct yt921x_priv; + +int yt921x_reg_read(struct yt921x_priv *priv, u32 reg, u32 *valp); +int yt921x_reg_write(struct yt921x_priv *priv, u32 reg, u32 val); +int yt921x_reg_wait(struct yt921x_priv *priv, u32 reg, u32 mask, u32 *valp= ); +int yt921x_reg_update_bits(struct yt921x_priv *priv, u32 reg, u32 mask, + u32 val); + +static inline int +yt921x_reg_set_bits(struct yt921x_priv *priv, u32 reg, u32 mask) +{ + return yt921x_reg_update_bits(priv, reg, 0, mask); +} + +static inline int +yt921x_reg_clear_bits(struct yt921x_priv *priv, u32 reg, u32 mask) +{ + return yt921x_reg_update_bits(priv, reg, mask, 0); +} + +static inline int +yt921x_reg_toggle_bits(struct yt921x_priv *priv, u32 reg, u32 mask, bool s= et) +{ + return yt921x_reg_update_bits(priv, reg, mask, !set ? 0 : mask); +} + +/* Some multi-word registers, like VLANn_CTRL, should be treated as a sing= le + * long register. More specifically, writes to parts of its words won't be= come + * visible, until the last word is written. + * + * Here we require full read and write operations over these registers to + * eliminate potential issues, although partial reads/writes are also poss= ible. + */ + +static inline void update_ctrls_unaligned(u32 *lo, u32 *hi, u64 mask, u64 = val) +{ + *lo &=3D ~lower_32_bits(mask); + *hi &=3D ~upper_32_bits(mask); + *lo |=3D lower_32_bits(val); + *hi |=3D upper_32_bits(val); +} + +/* yt921x_regs_*() are exported for linkage only. Do not use them directly= . Use + * yt921x_reg64_*() or yt921x_reg96_*() instead. + */ + +int yt921x_regs_read(struct yt921x_priv *priv, u32 reg, u32 *vals, + unsigned int num_regs); +int yt921x_regs_write(struct yt921x_priv *priv, u32 reg, const u32 *vals, + unsigned int num_regs); +int yt921x_regs_update_bits(struct yt921x_priv *priv, u32 reg, const u32 *= masks, + const u32 *vals, unsigned int num_regs); +int yt921x_regs_clear_bits(struct yt921x_priv *priv, u32 reg, const u32 *m= asks, + unsigned int num_regs); + +static inline int +yt921x_reg64_write(struct yt921x_priv *priv, u32 reg, const u32 *vals) +{ + return yt921x_regs_write(priv, reg, vals, 2); +} + +static inline int +yt921x_reg64_update_bits(struct yt921x_priv *priv, u32 reg, const u32 *mas= ks, + const u32 *vals) +{ + return yt921x_regs_update_bits(priv, reg, masks, vals, 2); +} + +static inline int +yt921x_reg64_clear_bits(struct yt921x_priv *priv, u32 reg, const u32 *mask= s) +{ + return yt921x_regs_clear_bits(priv, reg, masks, 2); +} + +static inline int +yt921x_reg96_write(struct yt921x_priv *priv, u32 reg, const u32 *vals) +{ + return yt921x_regs_write(priv, reg, vals, 3); +} + +#endif --=20 2.53.0 From nobody Mon Aug 24 04:17:54 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5F73CA4AD for ; Sun, 16 Aug 2026 19:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909192; cv=none; b=lpKyQMHmQ2daVclQ63w2OualgJ4mZ6BxSG7eeQQJweJkdsznHpSDbAbuvoY/iVVOqvXKbfazkCt8C8BECmacChOoRx+gEwF0jTDAZGGI7K0lOc6c9C7pXyK5ZkgdWtghZykfkk9kZgFm30m9wqcraTS65BDoWymDxr3HoEp34Kk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909192; c=relaxed/simple; bh=b4Xba3vX41HeX7M+vcCjGwE9EIeSWTYkrjco9nr0raI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RiSSlqsXCTTw/3eoIMUM2qJbAA03LTfZtFsjDEOxyB38xaIdigpXydPOszFRf6aRrCjoz4hSSBkxv0xfNa1P5RzYBsZGCPNmHFpKnDI/r8BbX8BEPxiKpGQnnTbZfb6FOeZnnlSoQzcuPmQBG0qW95xuRZi5tAjQo+Tw4VA1Js4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SlSpWCH6; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SlSpWCH6" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38de840f2f0so2218009a91.0 for ; Sun, 16 Aug 2026 12:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786909186; x=1787513986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XK/tWeGsDzPaJsNrG47hdDUV6mp1i7umEdY9dGxUAgc=; b=SlSpWCH6TSflN8uO7tHDQhDxUvdJqNBmMjaJTe73muv+IWMGRPRwwpHtXXm0RNZVIm O3hKkKSqzE09yDYM0HpJwbSQ52glos/9Rw7hrddox5Y9St6p3gXZ3Pf+L1d8WI265DYK ogWLNLsNdghuhfbqKU9ziu+JAo7KNrmGyUxXxg6SCSsPQ23X894iaZNAtVzZHs/hiG4L CLafg8crc1mWzG7uDubQr0wUB6gAKHqudCUZvSjHGJ0fP1v1CaajoVLicLEiZk4sFcgX I3KDd53EXKmcTLIhoUQeXohQC4DbdpSdLDzMBdSbemm7RXlkfhr/lXl+mWp+NxHBNnGP 5ssg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786909186; x=1787513986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XK/tWeGsDzPaJsNrG47hdDUV6mp1i7umEdY9dGxUAgc=; b=hQ5QxbDuHvQ+UjUcfWF+4Txwo75uKMjXpx6H734uPCm3RcvGpSkSzqQGIYQD7XWo+F i/tUU9wPzMPmGo4NvxZcaDJF5lo0Ik5zG6ejmfdGsBnd6+reeFGiqu7LwS/DMPDoco9i aIKrkY3lDxhwndFhKppDpo9IxM0G5xsj5i35AXcP5GVinUR6eOQYPmdVr+vB3khmZK0V 1YOOE05kLfwXay05ZDnhWiv/mhPN/6UmXwi2X1xFNl34khL5euCS4+koA0fIlioSRt1D V8/Ua2wwHzJV9/Xb2ElrYPjVQx9QmN9a8JTsGPq21kgj0j6Erp/JDInNlAPo9iuKgcxJ 5Irg== X-Forwarded-Encrypted: i=1; AHgh+RqjOHKvFYyaDQg/R7WAqu2MD1qax1O8OqnrjcOvQ1Hjnjxt1QWcBwxIJ05SZ8Ay3VO5FeKXRYHj4rlJOR0=@vger.kernel.org X-Gm-Message-State: AOJu0YxCrnMy0D9Ylo47FuaVVsX5f0sNqsca0jiJ+k4JTt9anBVW5WZP wFEnQp8ED1iQOKK4XjHkJE/Q7DV9yxttV5Rc8IGBEIawi+ujh14oRj43 X-Gm-Gg: AR+sD10z3njGvPjeTvAFRdrACKVrKU3ORs88CaEKZSDD4/0vQWPFsZ4lAK2azLkGxe+ z1rjbvTkkR70kkWcENyd1NxWmEAgvPhMItJuUWLYS52oPyXrsNnoyB1AiL+jYwonaIR6W78qgvU YtlswPZzQHnP7iAIZKWyYDQsa2NU/Hw0ZJeC5nbmsXMVzLCTHAUMAeu1rXfVQtOPi+rOPDCgZSp YmwAlYzLMr8PU7+mI+boGtmyH6HhUDOzVYNsFuEboToCxzzoDksl4tDd5l/3pGEtcB3u9rKyz/0 ssv4izE33YrfApktgBGlpTnDaKWAXAoOV2G/pt0drMs6SWvI7N6dRYatnkWSHh/ikvHw+NagHoD kAi6/Q7cARFHVuJXd6ZgE3sueeYtdD9CcjWW7YcxKq2cwswL/QYIOxe+jEmLk9CW388VbTTHn2i FgStVjuNtpH2LzDbqu4vACBOIxNQrXeXYqk8b6orBe7oiwBqx3aDTLjmywtyBjKQmbUUFEPMYxu Mv1FOZhXf722g== X-Received: by 2002:a17:90b:4d8b:b0:375:2a38:1d40 with SMTP id 98e67ed59e1d1-3933bce0960mr19663287a91.20.1786909186386; Sun, 16 Aug 2026 12:39:46 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac1:7680:d30::4cf:1a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531e10d9fsm2244065a91.3.2026.08.16.12.39.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 12:39:46 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v10 3/4] net: dsa: motorcomm: Add LED support Date: Mon, 17 Aug 2026 03:38:58 +0800 Message-ID: <20260816193905.218112-4-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816193905.218112-1-mmyangfl@gmail.com> References: <20260816193905.218112-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Each port has at most 3 LEDs connected and can be declared using the standard LEDs structure. Currently, only parallel mode and strict 1:1 mapping (i.e. the HW default) are supported. Signed-off-by: David Yang Reviewed-by: Andrew Lunn --- drivers/net/dsa/motorcomm/Kconfig | 9 + drivers/net/dsa/motorcomm/Makefile | 1 + drivers/net/dsa/motorcomm/chip.c | 13 +- drivers/net/dsa/motorcomm/chip.h | 12 + drivers/net/dsa/motorcomm/leds.c | 654 +++++++++++++++++++++++++++++ drivers/net/dsa/motorcomm/leds.h | 121 ++++++ 6 files changed, 808 insertions(+), 2 deletions(-) create mode 100644 drivers/net/dsa/motorcomm/leds.c create mode 100644 drivers/net/dsa/motorcomm/leds.h diff --git a/drivers/net/dsa/motorcomm/Kconfig b/drivers/net/dsa/motorcomm/= Kconfig index 1fddd386f866..3438e0b14361 100644 --- a/drivers/net/dsa/motorcomm/Kconfig +++ b/drivers/net/dsa/motorcomm/Kconfig @@ -6,3 +6,12 @@ config NET_DSA_YT921X help This enables support for the Motorcomm YT9215 ethernet switch chip. + +config NET_DSA_YT921X_LEDS + bool "LED support for Motorcomm YT9215" + default y + depends on NET_DSA_YT921X + depends on LEDS_CLASS=3Dy || LEDS_CLASS=3DNET_DSA_YT921X + help + This enables support for controlling the LEDs attached to the + Motorcomm YT9215 switch chips. diff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm= /Makefile index 6cea5313a444..5a63db0029ff 100644 --- a/drivers/net/dsa/motorcomm/Makefile +++ b/drivers/net/dsa/motorcomm/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: ISC obj-$(CONFIG_NET_DSA_YT921X) +=3D yt921x.o yt921x-objs :=3D chip.o +yt921x-$(CONFIG_NET_DSA_YT921X_LEDS) +=3D leds.o yt921x-objs +=3D smi.o diff --git a/drivers/net/dsa/motorcomm/chip.c b/drivers/net/dsa/motorcomm/c= hip.c index 6dee25b6754a..553efacd4f5e 100644 --- a/drivers/net/dsa/motorcomm/chip.c +++ b/drivers/net/dsa/motorcomm/chip.c @@ -26,6 +26,7 @@ #include =20 #include "chip.h" +#include "leds.h" #include "smi.h" =20 struct yt921x_mib_desc { @@ -151,8 +152,6 @@ static const struct yt921x_info yt921x_infos[] =3D { {} }; =20 -#define YT921X_NAME "yt921x" - #define YT921X_VID_UNWARE 4095 =20 /* The interval should be small enough to avoid overflow of 32bit MIBs. @@ -4581,6 +4580,12 @@ static int yt921x_dsa_setup(struct dsa_switch *ds) if (res) return res; =20 +#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS) + res =3D yt921x_leds_setup(priv); + if (res) + dev_warn(dev, "Failed to setup LEDs: %d\n", res); +#endif + return 0; } =20 @@ -4681,6 +4686,10 @@ static void yt921x_mdio_remove(struct mdio_device *m= diodev) if (!priv) return; =20 +#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS) + yt921x_leds_remove(priv); +#endif + for (size_t i =3D ARRAY_SIZE(priv->ports); i-- > 0; ) { struct yt921x_port *pp =3D &priv->ports[i]; =20 diff --git a/drivers/net/dsa/motorcomm/chip.h b/drivers/net/dsa/motorcomm/c= hip.h index 5f3b99e189c4..e6815cf9cb3c 100644 --- a/drivers/net/dsa/motorcomm/chip.h +++ b/drivers/net/dsa/motorcomm/chip.h @@ -850,9 +850,14 @@ enum yt921x_fdb_entry_status { #define YT921X_ACL_NUM (YT921X_ACL_BLK_NUM * YT921X_ACL_ENT_PER_BLK) #define YT921X_UDF_NUM 8 =20 +#define YT921X_LED_GROUP_NUM 3 +#define YT921X_LED_PORT_NUM 10 + /* 8 internal + 2 external + 1 mcu */ #define YT921X_PORT_NUM 11 =20 +#define YT921X_NAME "yt921x" + #define yt921x_port_is_internal(port) ((port) < 8) #define yt921x_port_is_external(port) ((port) =3D=3D 8 || (port) =3D=3D 9) =20 @@ -938,6 +943,13 @@ struct yt921x_port { struct yt921x_mib mib; u64 rx_frames; u64 tx_frames; + +#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS) + unsigned char led_duty; + unsigned short led_cycle; + + struct yt921x_led *leds[YT921X_LED_GROUP_NUM]; +#endif }; =20 struct yt921x_reg_ops { diff --git a/drivers/net/dsa/motorcomm/leds.c b/drivers/net/dsa/motorcomm/l= eds.c new file mode 100644 index 000000000000..e7ef0ef80a26 --- /dev/null +++ b/drivers/net/dsa/motorcomm/leds.c @@ -0,0 +1,654 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2026 David Yang + */ + +#include + +#include "chip.h" +#include "leds.h" +#include "smi.h" + +#define to_yt921x_led(led_cdev) \ + container_of_const((led_cdev), struct yt921x_led, cdev) +#define to_yt921x_port(led) ((led)->port) +#define to_yt921x_priv(pp) \ + container_of_const((pp), struct yt921x_priv, ports[(pp)->index]) +#define to_device(priv) ((priv)->ds.dev) + +static u32 yt921x_led_regaddr(struct yt921x_priv *priv, int port, int grou= p) +{ + switch (group) { + case 0: + default: + return YT921X_LED0_PORTn(port); + case 1: + return YT921X_LED1_PORTn(port); + case 2: + return YT921X_LED2_PORTn(port); + } +} + +static int +yt921x_led_force_get(struct yt921x_priv *priv, int port, int group, bool *= onp) +{ + u32 val; + int res; + + res =3D yt921x_reg_read(priv, YT921X_LED2_PORTn(port), &val); + if (res) + return res; + + *onp =3D (val & YT921X_LED2_PORT_FORCEn_M(group)) =3D=3D + YT921X_LED2_PORT_FORCEn_ON(group); + return 0; +} + +static int +yt921x_led_force_set(struct yt921x_priv *priv, int port, int group, bool o= n) +{ + struct yt921x_port *pp =3D &priv->ports[port]; + struct yt921x_led *led =3D pp->leds[group]; + u32 ctrl; + u32 mask; + + led->use_cycle =3D false; + led->use_duty =3D false; + + mask =3D YT921X_LED2_PORT_FORCEn_M(group); + ctrl =3D on ? YT921X_LED2_PORT_FORCEn_ON(group) : + YT921X_LED2_PORT_FORCEn_OFF(group); + return yt921x_reg_update_bits(priv, YT921X_LED2_PORTn(port), mask, + ctrl); +} + +static int +yt921x_led_blink_select(const struct yt921x_priv *priv, unsigned long on, + unsigned long off, unsigned short *cyclep, + unsigned char *dutyp) +{ + static const unsigned char dutys[] =3D { + YT921X_LED_DUTY(1, 6), + YT921X_LED_DUTY(1, 4), + YT921X_LED_DUTY(1, 3), + YT921X_LED_DUTY(1, 2), + }; + unsigned int cycle_upper; + unsigned int cycle_req; + unsigned int duty_req; + unsigned int cycle; + unsigned int duty; + + cycle =3D YT921X_LED_BLINK_MAX; + cycle_upper =3D cycle * 11585 / 8192 + 1; /* M_SQRT2 * cycle */ + if (check_add_overflow(on, off, &cycle_req) || cycle_req >=3D cycle_upper) + return -EOPNOTSUPP; + + for (; cycle > YT921X_LED_BLINK_MIN; cycle_upper >>=3D 1, cycle >>=3D 1) + if (cycle_req >=3D cycle_upper >> 1) + break; + *cyclep =3D cycle; + + duty_req =3D DIV_ROUND_CLOSEST(YT921X_LED_DUTY_DENOM * + (on > off ? off : on), cycle_req); + for (unsigned int i =3D ARRAY_SIZE(dutys) - 1;; i--) + if (i =3D=3D 0 || duty_req >=3D (dutys[i - 1] + dutys[i]) / 2) { + duty =3D dutys[i]; + break; + } + if (on > off) + duty =3D YT921X_LED_DUTY_DENOM - duty; + *dutyp =3D duty; + + return 0; +} + +static int +yt921x_led_blink_set(struct yt921x_priv *priv, int port, int group, + unsigned long *onp, unsigned long *offp) +{ + struct yt921x_port *pp =3D &priv->ports[port]; + struct yt921x_led *led =3D pp->leds[group]; + unsigned short cycle; + unsigned char duty; + bool use_cycle; + u32 ctrl; + u32 mask; + u32 val; + int res; + + if (!*onp && !*offp) { + cycle =3D YT921X_LED_BLINK_DEF; + duty =3D YT921X_LED_DUTY(1, 2); + for (unsigned int i =3D 0; i < YT921X_LED_GROUP_NUM; i++) + if (i !=3D group && pp->leds[i] && + pp->leds[i]->use_duty) { + duty =3D pp->led_duty; + break; + } + + use_cycle =3D false; + } else { + bool change_cycle; + bool change_duty; + + res =3D yt921x_led_blink_select(priv, *onp, *offp, &cycle, &duty); + if (res) + return res; + + use_cycle =3D cycle < YT921X_LED_BLINK_DEF; + change_cycle =3D use_cycle && cycle !=3D pp->led_cycle; + change_duty =3D duty !=3D pp->led_duty; + if (change_cycle || change_duty) + for (unsigned int i =3D 0; i < YT921X_LED_GROUP_NUM; + i++) { + if (i =3D=3D group || !pp->leds[i]) + continue; + if ((change_cycle && pp->leds[i]->use_cycle) || + (change_duty && pp->leds[i]->use_duty)) + return -EOPNOTSUPP; + } + } + + /* The chip seems to jam a while if changing duty directly */ + res =3D yt921x_reg_read(priv, YT921X_LED2_PORTn(port), &val); + if (res) + return res; + + ctrl =3D val & ~YT921X_LED2_PORT_FORCEn_M(group); + ctrl |=3D YT921X_LED2_PORT_FORCEn_DONTCARE(group); + if (val !=3D ctrl) { + res =3D yt921x_reg_write(priv, YT921X_LED2_PORTn(port), ctrl); + if (res) + return res; + } + + mask =3D YT921X_LED1_PORT_BLINK_DUTY_M | YT921X_LED1_PORT_BLINK_DUTY_COMP; + switch (duty >=3D YT921X_LED_DUTY(1, 2) ? duty : + YT921X_LED_DUTY_DENOM - duty) { + default: + duty =3D YT921X_LED_DUTY(1, 2); + fallthrough; + case YT921X_LED_DUTY(1, 2): + ctrl =3D YT921X_LED1_PORT_BLINK_DUTY_1_2; + break; + case YT921X_LED_DUTY(2, 3): + ctrl =3D YT921X_LED1_PORT_BLINK_DUTY_2_3; + break; + case YT921X_LED_DUTY(3, 4): + ctrl =3D YT921X_LED1_PORT_BLINK_DUTY_3_4; + break; + case YT921X_LED_DUTY(5, 6): + ctrl =3D YT921X_LED1_PORT_BLINK_DUTY_5_6; + break; + } + if (duty < YT921X_LED_DUTY(1, 2)) + ctrl |=3D YT921X_LED1_PORT_BLINK_DUTY_COMP; + if (use_cycle) { + mask |=3D YT921X_LED1_PORT_OTHER_BLINK_M; + ctrl |=3D YT921X_LED1_PORT_OTHER_BLINK(9 - __fls(cycle)); + } + res =3D yt921x_reg_update_bits(priv, YT921X_LED1_PORTn(port), mask, ctrl); + if (res) + return res; + + ctrl =3D val & ~(YT921X_LED2_PORT_FORCEn_M(group) | + YT921X_LED2_PORT_FORCE_BLINKn_M(group)); + ctrl |=3D YT921X_LED2_PORT_FORCEn_BLINK(group); + if (use_cycle) + ctrl |=3D YT921X_LED2_PORT_FORCE_BLINKn_OTHER(group); + else + ctrl |=3D YT921X_LED2_PORT_FORCE_BLINKn(group, __fls(cycle) - 9); + res =3D yt921x_reg_write(priv, YT921X_LED2_PORTn(port), ctrl); + if (res) + return res; + + led->use_cycle =3D use_cycle; + if (use_cycle) + pp->led_cycle =3D cycle; + led->use_duty =3D true; + pp->led_duty =3D duty; + + *onp =3D DIV_ROUND_CLOSEST(duty * cycle, YT921X_LED_DUTY_DENOM); + *offp =3D cycle - *onp; + return 0; +} + +struct yt921x_led_trigger_map { + unsigned long flags; + u32 mask; +}; + +static const struct yt921x_led_trigger_map yt921x_led_trigger_maps[] =3D { + {BIT(TRIGGER_NETDEV_LINK), + YT921X_LEDx_PORT_ACT_DUPLEX_HALF | YT921X_LEDx_PORT_ACT_DUPLEX_FULL}, + {BIT(TRIGGER_NETDEV_LINK_10), YT921X_LEDx_PORT_ACT_10M}, + {BIT(TRIGGER_NETDEV_LINK_100), YT921X_LEDx_PORT_ACT_100M}, + {BIT(TRIGGER_NETDEV_LINK_1000), YT921X_LEDx_PORT_ACT_1000M}, + {BIT(TRIGGER_NETDEV_HALF_DUPLEX), YT921X_LEDx_PORT_ACT_DUPLEX_HALF}, + {BIT(TRIGGER_NETDEV_FULL_DUPLEX), YT921X_LEDx_PORT_ACT_DUPLEX_FULL}, + {BIT(TRIGGER_NETDEV_TX), YT921X_LEDx_PORT_ACT_TX_BLINK}, + {BIT(TRIGGER_NETDEV_RX), YT921X_LEDx_PORT_ACT_RX_BLINK}, + {BIT(TRIGGER_NETDEV_TX_ERR) | BIT(TRIGGER_NETDEV_RX_ERR), + YT921X_LEDx_PORT_ACT_COLLISION_BLINK}, +}; + +static bool +yt921x_led_trigger_is_supported(const struct yt921x_priv *priv, int port, + int group, unsigned long flags) +{ + if (!flags) + return true; + + for (unsigned int i =3D 0; i < ARRAY_SIZE(yt921x_led_trigger_maps); i++) { + const struct yt921x_led_trigger_map *map =3D &yt921x_led_trigger_maps[i]; + + if ((flags & map->flags) =3D=3D map->flags) { + flags &=3D ~map->flags; + if (!flags) + return true; + } + } + + return false; +} + +static int +yt921x_led_trigger_get(struct yt921x_priv *priv, int port, int group, + unsigned long *flagsp) +{ + u32 addr; + u32 val; + int res; + + res =3D yt921x_reg_read(priv, YT921X_LED2_PORTn(port), &val); + if (res) + return res; + + if ((val & YT921X_LED2_PORT_FORCEn_M(group)) !=3D + YT921X_LED2_PORT_FORCEn_DONTCARE(group)) { + *flagsp =3D 0; + return 0; + } + + if (group !=3D 2) { + addr =3D yt921x_led_regaddr(priv, port, group); + res =3D yt921x_reg_read(priv, addr, &val); + if (res) + return res; + } + + *flagsp =3D 0; + for (unsigned int i =3D 0; i < ARRAY_SIZE(yt921x_led_trigger_maps); i++) { + const struct yt921x_led_trigger_map *map =3D &yt921x_led_trigger_maps[i]; + + if ((val & map->mask) =3D=3D map->mask) + *flagsp |=3D map->flags; + } + + return 0; +} + +static int +yt921x_led_trigger_set(struct yt921x_priv *priv, int port, int group, + unsigned long flags) +{ + struct yt921x_port *pp =3D &priv->ports[port]; + struct yt921x_led *led =3D pp->leds[group]; + u32 addr; + u32 ctrl; + u32 mask; + int res; + + ctrl =3D 0; + for (unsigned int i =3D 0; i < ARRAY_SIZE(yt921x_led_trigger_maps); i++) { + const struct yt921x_led_trigger_map *map =3D &yt921x_led_trigger_maps[i]; + + if ((flags & map->flags) =3D=3D map->flags) { + flags &=3D ~map->flags; + ctrl |=3D map->mask; + if (!flags) + break; + } + } + if (flags) + return -EOPNOTSUPP; + + led->use_cycle =3D false; + led->use_duty =3D false; + + mask =3D !group ? YT921X_LED0_PORT_ACT_M : YT921X_LEDx_PORT_ACT_M; + if (group =3D=3D 2) { + mask |=3D YT921X_LED2_PORT_FORCEn_M(group); + ctrl |=3D YT921X_LED2_PORT_FORCEn_DONTCARE(group); + } + addr =3D yt921x_led_regaddr(priv, port, group); + res =3D yt921x_reg_update_bits(priv, addr, mask, ctrl); + if (res) + return res; + + if (group !=3D 2) { + mask =3D YT921X_LED2_PORT_FORCEn_M(group); + ctrl =3D YT921X_LED2_PORT_FORCEn_DONTCARE(group); + res =3D yt921x_reg_update_bits(priv, YT921X_LED2_PORTn(port), + mask, ctrl); + if (res) + return res; + } + + return 0; +} + +static int +yt921x_cled_brightness_set_blocking(struct led_classdev *led_cdev, + enum led_brightness brightness) +{ + struct yt921x_led *led =3D to_yt921x_led(led_cdev); + struct yt921x_port *pp =3D to_yt921x_port(led); + struct yt921x_priv *priv =3D to_yt921x_priv(pp); + int res; + + mutex_lock(&priv->reg_lock); + res =3D yt921x_led_force_set(priv, pp->index, led->group, brightness); + mutex_unlock(&priv->reg_lock); + + return res; +} + +static int +yt921x_cled_blink_set(struct led_classdev *led_cdev, unsigned long *delay_= on, + unsigned long *delay_off) +{ + struct yt921x_led *led =3D to_yt921x_led(led_cdev); + struct yt921x_port *pp =3D to_yt921x_port(led); + struct yt921x_priv *priv =3D to_yt921x_priv(pp); + int res; + + mutex_lock(&priv->reg_lock); + res =3D yt921x_led_blink_set(priv, pp->index, led->group, delay_on, + delay_off); + mutex_unlock(&priv->reg_lock); + + return res; +} + +static struct device * __maybe_unused +yt921x_cled_hw_control_get_device(struct led_classdev *led_cdev) +{ + struct yt921x_led *led =3D to_yt921x_led(led_cdev); + struct yt921x_port *pp =3D to_yt921x_port(led); + struct yt921x_priv *priv =3D to_yt921x_priv(pp); + struct dsa_port *dp; + + dp =3D dsa_to_port(&priv->ds, pp->index); + if (!dp) + return NULL; + + if (dsa_port_is_user(dp)) + return &dp->user->dev; + if (dsa_port_is_cpu(dp)) + return &dp->conduit->dev; + + return NULL; +} + +static int __maybe_unused +yt921x_cled_hw_control_is_supported(struct led_classdev *led_cdev, + unsigned long flags) +{ + struct yt921x_led *led =3D to_yt921x_led(led_cdev); + struct yt921x_port *pp =3D to_yt921x_port(led); + struct yt921x_priv *priv =3D to_yt921x_priv(pp); + + if (yt921x_led_trigger_is_supported(priv, pp->index, led->group, flags)) + return 0; + return -EOPNOTSUPP; +} + +static int __maybe_unused +yt921x_cled_hw_control_get(struct led_classdev *led_cdev, unsigned long *f= lagsp) +{ + struct yt921x_led *led =3D to_yt921x_led(led_cdev); + struct yt921x_port *pp =3D to_yt921x_port(led); + struct yt921x_priv *priv =3D to_yt921x_priv(pp); + int res; + + mutex_lock(&priv->reg_lock); + res =3D yt921x_led_trigger_get(priv, pp->index, led->group, flagsp); + mutex_unlock(&priv->reg_lock); + + return res; +} + +static int __maybe_unused +yt921x_cled_hw_control_set(struct led_classdev *led_cdev, unsigned long fl= ags) +{ + struct yt921x_led *led =3D to_yt921x_led(led_cdev); + struct yt921x_port *pp =3D to_yt921x_port(led); + struct yt921x_priv *priv =3D to_yt921x_priv(pp); + int res; + + mutex_lock(&priv->reg_lock); + res =3D yt921x_led_trigger_set(priv, pp->index, led->group, flags); + mutex_unlock(&priv->reg_lock); + + return res; +} + +static int +yt921x_led_setup(struct yt921x_priv *priv, int port, + struct fwnode_handle *fwnode) +{ + struct yt921x_port *pp =3D &priv->ports[port]; + struct device *dev =3D to_device(priv); + struct led_init_data init_data; + struct led_classdev *led_cdev; + char name[LED_MAX_NAME_SIZE]; + enum led_default_state state; + struct yt921x_led *led; + bool force_high; + bool force_low; + u32 group; + u32 mask; + u32 ctrl; + u32 val; + bool on; + int res; + int ret; + + res =3D fwnode_property_read_u32(fwnode, "reg", &group); + if (res) + return res; + if (group >=3D YT921X_LED_GROUP_NUM) { + dev_err(dev, "Invalid LED reg %u for port %d\n", group, port); + return -EINVAL; + } + if (pp->leds[group]) + return -EEXIST; + + force_high =3D fwnode_property_read_bool(fwnode, "active-high"); + force_low =3D fwnode_property_read_bool(fwnode, "active-low"); + if (force_high && force_low) { + dev_err(dev, "Duplicate polarities for LED %02d:%02u\n", + port, group); + return -EINVAL; + } + + led =3D devm_kzalloc(dev, sizeof(*led), GFP_KERNEL); + if (!led) + return -ENOMEM; + led->port =3D pp; + led->group =3D group; + + state =3D led_init_default_state_get(fwnode); + + mutex_lock(&priv->reg_lock); + + /* Inversion is internal - force on will give low logic. + * In the rest of the file, treat LEDs as if active-low. + */ + if (force_high || force_low) { + res =3D yt921x_reg_read(priv, YT921X_LED_PAR_INV, &val); + if (res) + goto unlock; + + mask =3D YT921X_LED_PAR_INV_INVnm(group, port); + ctrl =3D force_high ? val | mask : val & ~mask; + res =3D yt921x_reg_write(priv, YT921X_LED_PAR_INV, ctrl); + if (res) + goto unlock; + } + + pp->leds[group] =3D led; + + switch (state) { + case LEDS_DEFSTATE_OFF: + case LEDS_DEFSTATE_ON: + default: + on =3D state =3D=3D LEDS_DEFSTATE_ON; + res =3D yt921x_led_force_set(priv, port, group, on); + break; + case LEDS_DEFSTATE_KEEP: + res =3D yt921x_led_force_get(priv, port, group, &on); + break; + } + +unlock: + mutex_unlock(&priv->reg_lock); + if (res) + goto err; + + led_cdev =3D &led->cdev; + led_cdev->brightness =3D on; + led_cdev->max_brightness =3D 1; + led_cdev->flags =3D LED_RETAIN_AT_SHUTDOWN; + led_cdev->brightness_set_blocking =3D yt921x_cled_brightness_set_blocking; + led_cdev->blink_set =3D yt921x_cled_blink_set; +#ifdef CONFIG_LEDS_TRIGGERS + led_cdev->hw_control_trigger =3D "netdev"; + led_cdev->hw_control_get_device =3D yt921x_cled_hw_control_get_device; + led_cdev->hw_control_is_supported =3D yt921x_cled_hw_control_is_supported; + led_cdev->hw_control_get =3D yt921x_cled_hw_control_get; + led_cdev->hw_control_set =3D yt921x_cled_hw_control_set; +#endif + + snprintf(name, sizeof(name), YT921X_NAME "-%u:%02d:%02u", + priv->ds.index, port, group); + init_data =3D (typeof(init_data)){ + .fwnode =3D fwnode, + .default_label =3D ":port", + .devicename =3D name, + .devname_mandatory =3D true, + }; + res =3D devm_led_classdev_register_ext(dev, led_cdev, &init_data); + if (res) + goto err; + + return 0; + +err: + ret =3D res; + + mutex_lock(&priv->reg_lock); + if (pp->leds[group]) { + if (force_high || force_low) { + res =3D yt921x_reg_write(priv, YT921X_LED_PAR_INV, val); + if (res) + dev_warn(dev, + "Failed to revoke initialization for LED %02d:%02u\n", + port, group); + } + + pp->leds[group] =3D NULL; + } + mutex_unlock(&priv->reg_lock); + + devm_kfree(dev, led); + return ret; +} + +static void yt921x_leds_remove_port(struct yt921x_priv *priv, int port) +{ + struct yt921x_port *pp =3D &priv->ports[port]; + struct device *dev =3D to_device(priv); + bool has_leds =3D false; + + for (int group =3D 0; group < YT921X_LED_GROUP_NUM; group++) { + struct yt921x_led *led =3D pp->leds[group]; + + if (led) { + devm_led_classdev_unregister(dev, &led->cdev); + has_leds =3D true; + } + } + + if (!has_leds) + return; + + /* Now no one can access the LED control blocks, free them without + * holding the lock. + */ + for (int group =3D 0; group < YT921X_LED_GROUP_NUM; group++) { + struct yt921x_led *led =3D pp->leds[group]; + + if (led) { + pp->leds[group] =3D NULL; + devm_kfree(dev, led); + } + } +} + +static int yt921x_leds_setup_port(struct yt921x_priv *priv, int port) +{ + struct device *dev =3D to_device(priv); + struct dsa_switch *ds =3D &priv->ds; + struct device_node *leds_np; + struct dsa_port *dp; + + dp =3D dsa_to_port(ds, port); + leds_np =3D of_get_child_by_name(dp->dn, "leds"); + if (!leds_np) + return 0; + + if (port >=3D YT921X_LED_PORT_NUM) { + dev_err(dev, "Cannot configure LEDs for port %d\n", port); + of_node_put(leds_np); + return -EINVAL; + } + + for_each_child_of_node_scoped(leds_np, led_np) { + yt921x_led_setup(priv, port, of_fwnode_handle(led_np)); + /* Allow partial configuration: LEDs are optional */ + } + + of_node_put(leds_np); + return 0; +} + +void yt921x_leds_remove(struct yt921x_priv *priv) +{ + for (int port =3D 0; port < YT921X_LED_PORT_NUM; port++) + yt921x_leds_remove_port(priv, port); +} + +int yt921x_leds_setup(struct yt921x_priv *priv) +{ + struct dsa_switch *ds =3D &priv->ds; + struct dsa_port *dp; + + /* LEDs are always enabled. There is no way to disable them altogether + * (as far as I know). + */ + + dsa_switch_for_each_port(dp, ds) { + int port =3D dp->index; + + if (!dp->dn) + continue; + + yt921x_leds_setup_port(priv, port); + /* Allow partial configuration: LEDs are optional */ + } + + return 0; +} diff --git a/drivers/net/dsa/motorcomm/leds.h b/drivers/net/dsa/motorcomm/l= eds.h new file mode 100644 index 000000000000..3c3642988ac7 --- /dev/null +++ b/drivers/net/dsa/motorcomm/leds.h @@ -0,0 +1,121 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (c) 2026 David Yang + */ + +#ifndef _YT_LEDS_H +#define _YT_LEDS_H + +#include +#include +#include +#include + +#define YT921X_LED_CTRL 0xd0000 +#define YT921X_LED_CTRL_UNK BIT(21) +#define YT921X_LED_CTRL_LOOPDETECT_BLINK_M GENMASK(20, 19) /* cycle =3D 5= 12 * x ms */ +#define YT921X_LED_CTRL_LOOPDETECT_BLINK(x) FIELD_PREP(YT921X_LED_CTRL_= LOOPDETECT_BLINK_M, (x)) +#define YT921X_LED_CTRL_PORT_NUM_M GENMASK(16, 13) +#define YT921X_LED_CTRL_PORT_NUM(x) FIELD_PREP(YT921X_LED_CTRL_PORT_NU= M_M, (x)) +#define YT921X_LED_CTRL_MODE_M GENMASK(1, 0) +#define YT921X_LED_CTRL_MODE(x) FIELD_PREP(YT921X_LED_CTRL_MODE_M, (x)) +#define YT921X_LED_CTRL_MODE_PARALLEL YT921X_LED_CTRL_MODE(0) +#define YT921X_LED_CTRL_MODE_SERIAL YT921X_LED_CTRL_MODE(2) +#define YT921X_LED0_PORTn(port) (0xd0004 + 4 * (port)) +#define YT921X_LED0_PORT_ACT_M GENMASK(17, 0) +#define YT921X_LED0_PORT_ACT_LINK_TRY_DIS BIT(17) +#define YT921X_LED0_PORT_ACT_COLLISION_BLINK_INDI BIT(16) +#define YT921X_LED1_PORTn(port) (0xd0040 + 4 * (port)) +#define YT921X_LED1_PORT_OTHER_BLINK_M GENMASK(31, 30) /* cycle =3D 512 = >> x ms */ +#define YT921X_LED1_PORT_OTHER_BLINK(x) FIELD_PREP(YT921X_LED1_PORT_OTH= ER_BLINK_M, (x)) +#define YT921X_LED1_PORT_EEE_BLINK_M GENMASK(29, 28) /* cycle =3D 512 >>= x ms */ +#define YT921X_LED1_PORT_EEE_BLINK(x) FIELD_PREP(YT921X_LED1_PORT_EEE_= BLINK_M, (x)) +#define YT921X_LED1_PORT_BLINK_DUTY_COMP BIT(27) +#define YT921X_LED1_PORT_BLINK_DUTY_M GENMASK(26, 25) +#define YT921X_LED1_PORT_BLINK_DUTY(x) FIELD_PREP(YT921X_LED1_PORT_BLIN= K_DUTY_M, (x)) +#define YT921X_LED1_PORT_BLINK_DUTY_1_2 YT921X_LED1_PORT_BLINK_DUTY(0) +#define YT921X_LED1_PORT_BLINK_DUTY_2_3 YT921X_LED1_PORT_BLINK_DUTY(1) +#define YT921X_LED1_PORT_BLINK_DUTY_3_4 YT921X_LED1_PORT_BLINK_DUTY(2) +#define YT921X_LED1_PORT_BLINK_DUTY_5_6 YT921X_LED1_PORT_BLINK_DUTY(3) +#define YT921X_LED2_PORTn(port) (0xd0080 + 4 * (port)) +#define YT921X_LED2_PORT_FORCEn_M(grp) GENMASK(4 * (grp) + 19, 4 * (grp)= + 18) +#define YT921X_LED2_PORT_FORCEn(grp, x) ((x) << (4 * (grp) + 18)) +#define YT921X_LED2_PORT_FORCEn_DONTCARE(grp) YT921X_LED2_PORT_FORCEn(g= rp, 0) +#define YT921X_LED2_PORT_FORCEn_BLINK(grp) YT921X_LED2_PORT_FORCEn(grp,= 1) +#define YT921X_LED2_PORT_FORCEn_ON(grp) YT921X_LED2_PORT_FORCEn(grp, 2) +#define YT921X_LED2_PORT_FORCEn_OFF(grp) YT921X_LED2_PORT_FORCEn(grp, 3) +#define YT921X_LED2_PORT_FORCE_BLINKn_M(grp) GENMASK(4 * (grp) + 17, 4 * = (grp) + 16) /* cycle =3D 512 << x ms */ +#define YT921X_LED2_PORT_FORCE_BLINKn(grp, x) ((x) << (4 * (grp) + 16)) +#define YT921X_LED2_PORT_FORCE_BLINKn_OTHER(grp) YT921X_LED2_PORT_FORCE_= BLINKn(grp, 3) +#define YT921X_LEDx_PORT_ACT_M GENMASK(15, 0) +#define YT921X_LEDx_PORT_ACT_EEE_BLINK BIT(15) +#define YT921X_LEDx_PORT_ACT_LOOPDETECT_BLINK BIT(14) +#define YT921X_LEDx_PORT_ACT_ACTIVE_BLINK BIT(13) +#define YT921X_LEDx_PORT_ACT_DUPLEX_FULL BIT(12) +#define YT921X_LEDx_PORT_ACT_DUPLEX_HALF BIT(11) +#define YT921X_LEDx_PORT_ACT_TX_BLINK BIT(10) +#define YT921X_LEDx_PORT_ACT_RX_BLINK BIT(9) +#define YT921X_LEDx_PORT_ACT_TX BIT(8) +#define YT921X_LEDx_PORT_ACT_RX BIT(7) +#define YT921X_LEDx_PORT_ACT_1000M BIT(6) +#define YT921X_LEDx_PORT_ACT_100M BIT(5) +#define YT921X_LEDx_PORT_ACT_10M BIT(4) +#define YT921X_LEDx_PORT_ACT_COLLISION_BLINK BIT(3) +#define YT921X_LEDx_PORT_ACT_1000M_BLINK BIT(2) +#define YT921X_LEDx_PORT_ACT_100M_BLINK BIT(1) +#define YT921X_LEDx_PORT_ACT_10M_BLINK BIT(0) +#define YT921X_LED_SER_CTRL 0xd0100 +#define YT921X_LED_SER_CTRL_UNK GENMASK(25, 24) /* delay? */ +#define YT921X_LED_SER_CTRL_ACTIVE_LOW BIT(4) +#define YT921X_LED_SER_CTRL_GRP_NUM_M GENMASK(1, 0) /* #grp - 1 */ +#define YT921X_LED_SER_CTRL_GRP_NUM(x) FIELD_PREP(YT921X_LED_SER_CTRL_G= RP_NUM_M, (x)) +#define YT921X_LED_SER_MAPnm(grp, port) (0xd0104 + 8 * (2 - (grp)) + 4 * (= (port) / 5)) +#define YT921X_LED_SER_MAP_DSTn_PORT_M(port) GENMASK(6 * ((port) % 5) + 5= , 6 * ((port) % 5) + 2) +#define YT921X_LED_SER_MAP_DSTn_PORT(port, x) ((x) << (6 * ((port) % 5)= + 2)) +#define YT921X_LED_SER_MAP_DSTn_LED_M(port) GENMASK(6 * ((port) % 5) + 1,= 6 * ((port) % 5)) +#define YT921X_LED_SER_MAP_DSTn_LED(port, x) ((x) << (6 * ((port) % 5))) +#define YT921X_LED_PAR_PORTS 0xd01c4 +#define YT921X_LED_PAR_INV 0xd01c8 +#define YT921X_LED_PAR_INV_INVnm(grp, port) BIT(10 * (grp) + (port)) +#define YT921X_LED_PAR_MAPn(port) (0xd01d0 + 4 * (port)) +#define YT921X_LED_PAR_MAP_DSTn_PORT_M(grp) GENMASK(6 * (grp) + 5, 6 * (g= rp) + 2) +#define YT921X_LED_PAR_MAP_DSTn_PORT(grp, x) ((x) << (6 * (grp) + 2)) +#define YT921X_LED_PAR_MAP_DSTn_LED_M(grp) GENMASK(6 * (grp) + 1, 6 * (gr= p)) +#define YT921X_LED_PAR_MAP_DSTn_LED(grp, x) ((x) << (6 * (grp))) + +#define YT921X_LED_BLINK_MIN 64 +#define YT921X_LED_BLINK_DEF 512 +#define YT921X_LED_BLINK_MAX 2048 + +/* 2 * lcm(2, 3, 4, 6) */ +#define YT921X_LED_DUTY_DENOM 24 +#define YT921X_LED_DUTY(nom, denom) (YT921X_LED_DUTY_DENOM * (nom) / (deno= m)) + +struct yt921x_priv; + +struct yt921x_led { + struct led_classdev cdev; + struct yt921x_port *port; + unsigned char group; + + bool use_cycle:1; + bool use_duty:1; +}; + +#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS) + +void yt921x_leds_remove(struct yt921x_priv *priv); +int yt921x_leds_setup(struct yt921x_priv *priv); + +#else + +static inline void yt921x_leds_remove(struct yt921x_priv *priv) {} + +static inline int yt921x_leds_setup(struct yt921x_priv *priv) +{ + return 0; +} + +#endif + +#endif --=20 2.53.0 From nobody Mon Aug 24 04:17:54 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BD323CC7CC for ; Sun, 16 Aug 2026 19:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909194; cv=none; b=AKorvDphJWw/GNu6OIw9CTKmbP0RoyOqllf9fMmfZDHREpg3owyG2vxXrpweRFYpnB0fgmw7HwpkElCq8i6MmVZfgi1mOzqwZr7H7DFKeboRpkdMyF97PJx92bR78oNs2OiFNaB8UKr2s+evkM1zGvzb0TjLRQ2nNIe7jBcL75E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909194; c=relaxed/simple; bh=p+sNV03OlGGYrUReYHOX7R8PzXHgdO/RXCMs0dYPR+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y+oIPUgp4i1uhawZ+4wOcSZFCJ3u2wdwB80jMTfVelxx3fzWlaTWU8wHUK56Qw9qUXkKNa0WxaLBYcgsoBZW4B4BcCY52am8D9hl4JNMIHzva1Dk95lo+lVWBGirferjJIWEGx9dZyyjB8FHw8En3YVIiv3wkshd7Oz7vREJtps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KP+k0r6N; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KP+k0r6N" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cf50c6f235so32792805ad.0 for ; Sun, 16 Aug 2026 12:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786909190; x=1787513990; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4r7CVU6P+Php5YYpvBxb/ynZhMEbMhKfdVoPSFU1jjQ=; b=KP+k0r6NVsOODmK7Op08a1NwvY2WxyvbI8G8OQrVwUTzPLpZkPjSm5wS+vy0snjEEJ CSwCgarAA0Hw3/ndJDAAFiFOsOTI/BwiTs7Telp4Z2mO1sz9tFjV3jL+69jBcUvkCADK 2RgNF4zwlIXDXhcklJQ8sxTcuUwQQQZj3T77JQ8zialpLGR3LZ73lRZveXP5umI8PTnO LOdaZiLKe4KD+5DdZmTvKfggh4ptetzVr76QV1MFn0WzhVnGon4tHNsMpkGWNTKodaVh RAG3YoErD8jzUrgAROR9gwwEDYf0zTntUF8/HncljYm0+ozA/mHTQtGZKuk6D2xt8bvd Hxxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786909190; x=1787513990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4r7CVU6P+Php5YYpvBxb/ynZhMEbMhKfdVoPSFU1jjQ=; b=gCTA696tlPfYer8aK5TmOeYiL7LglYaK0XZuOLxiFqWkdQ01lGEm3SNr/EPkl8g2rw nENDhW1WeulqHZqUMs9NI1OmLdXpDeuZnF+bv7/eOKeY3ypgzF9lLswapjZnbc9nYCGV l3aHO4iNQflroKBbD4yJt7YLi3M3Mu7VCtcyZcx4E9MXd4F/E0x8FngVBO0dlHGpIPZ9 MRPEWISntIaPnMVtsDCy4nef3uZp2iwJr46WapIsda5nGq8dxynNe+eZKbmY/2OcAYcT Z5ATV4rHf15fG2C+MZnTl8sfg3QGdzXub82ac0CibvhT//bjCYshy3bss1DaF8px+CWU pWfQ== X-Forwarded-Encrypted: i=1; AHgh+RoD0VDF/fpUEvrHLhtw0Wyup/yxwe/FSohd4bouvjhB7ZqRvEJpbbtzG+eKXGcI+1QcDIxL8R+T+9oqa6Y=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy1CvGW/xT24SbrINmtoazVr7BwWwNFATQF12PRPv4pLr35dBp CC01cjSWi41QMnxfkOxHMYBVinHmzz9Cq1mzmki7nSzTj3XY0XXFaGbS X-Gm-Gg: AR+sD13eyM73gEhQbyAh/oZswrpZaPhnLdkHkDWuTEzlL5sc+fTLAI5K65Gybvc/Wvv RbjZnBJbTgycf1cqTf6Tuih7avYYN6gWwKIvhvsc5fSIOZEBQUCgoRClKtaey6mGuS1rGHUeOsF 67FCNXIG1Hdn8GvWqanLlMBs0kJUfHBWef4guVGwcN14gV6dVzNdCMmUD4OQgMAbsLPov9SmWG5 GeqkeboJY7atEBda0cHQ7prCL34E9uUHFlVyyrbfEU+iYr8ZsrErXdlvNty6rwTTuKlTzkC0yNw GgGQJ+1bianGwxaRTr3ryFd3i4ZnhTkULQHqWfwUfHQzqjFW9nmSfvA9aBokYYKN2i6Aq2eW7Ah /pwZSFn2KoHKkIcJ4kL/NYZpjGz5lFJ08+zPLgbHJqx2HVPjNt/ryB4Bfl2erYpW6nau/iREkfO 5PQIVvBd5L+f5sKZHhO8eKBfYwpqDYsA1OIc/Hmld5zGfc8zXwHHlR5m3tGpjrqemQETcCj/bka lYD3Ioyz1UVqNM= X-Received: by 2002:a17:90b:57cf:b0:390:8361:a532 with SMTP id 98e67ed59e1d1-3933b8072a0mr22653003a91.7.1786909189720; Sun, 16 Aug 2026 12:39:49 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac1:7680:d30::4cf:1a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531e10d9fsm2244065a91.3.2026.08.16.12.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 12:39:49 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v10 4/4] dt-bindings: net: dsa: yt921x: Add LEDs definition example Date: Mon, 17 Aug 2026 03:38:59 +0800 Message-ID: <20260816193905.218112-5-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816193905.218112-1-mmyangfl@gmail.com> References: <20260816193905.218112-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add LEDs definition example for yt921x to describe how they should be defined for a correct usage. Signed-off-by: David Yang Reviewed-by: Krzysztof Kozlowski --- .../bindings/net/dsa/motorcomm,yt921x.yaml | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/motorcomm,yt921x.yam= l b/Documentation/devicetree/bindings/net/dsa/motorcomm,yt921x.yaml index 33a6552e46fc..93ba5b181205 100644 --- a/Documentation/devicetree/bindings/net/dsa/motorcomm,yt921x.yaml +++ b/Documentation/devicetree/bindings/net/dsa/motorcomm,yt921x.yaml @@ -21,6 +21,9 @@ description: | =20 Any port can be used as the CPU port. =20 + Each port has at most 3 LEDs connected and can be declared using the sta= ndard + LEDs structure. + properties: compatible: const: motorcomm,yt9215 @@ -59,6 +62,7 @@ unevaluatedProperties: false examples: - | #include + #include =20 mdio { #address-cells =3D <1>; @@ -113,6 +117,25 @@ examples: label =3D "lan1"; phy-mode =3D "internal"; phy-handle =3D <&sw_phy0>; + + leds { + #address-cells =3D <1>; + #size-cells =3D <0>; + + led@0 { + reg =3D <0>; + color =3D ; + function =3D LED_FUNCTION_LAN; + default-state =3D "keep"; + }; + + led@1 { + reg =3D <1>; + color =3D ; + function =3D LED_FUNCTION_LAN; + default-state =3D "keep"; + }; + }; }; =20 ethernet-port@1 { --=20 2.53.0