From nobody Mon Aug 24 04:18:41 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48D921F936 for ; Sun, 16 Aug 2026 16:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786897836; cv=none; b=EFUx880Z9TREL8gKimDFXa+hQZa0UE0HiOwtWma5Z9mnHdfcaKqOhffbrpiNP+yxnV1ICbFPrk6EZ9Rc0ntFFBkzRFfoXRORL49Je+SL26wTknsFnDU+jGus+EG3fIrQhNXxyRNpyIUWBsXcrKy8ylwpkvqt/Fvx4S1GpsTgPoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786897836; c=relaxed/simple; bh=xeqKHCxk8uzzxR5jVoi9Wb+ttjz99HJmOAmzy5h8c24=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=kGkfJE+HCqu6y4VcYKe2ouBUxr8vLOWGOKY/cU60wEUln5nBgQrNTml7khEoNInPwHhIgZ4u2jkp/CVCAxGT5+/4kW7VfxF0ltfmy9KkGKsgeFngK+b/+DbzOVD9WPQdTeRjPAXYfvncZ26Md1iBcjGpP+3DxSKJYgEsy2PFbJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G9HWFHB8; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G9HWFHB8" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f703a9d05so1696677f8f.0 for ; Sun, 16 Aug 2026 09:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786897833; x=1787502633; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dp3y9HY6+OBWpLZwlaCANPDZ2TwUIEWZnAMUMpPK+e8=; b=G9HWFHB8BAqW+t2V967Ej8VLyq+hdRRdp+tv5pgYxaUy05j94huNij6EEBu3oN/10K Gl9JUUIbzN3gJWgnJoRFl9ApVlZQ1JLcpg1AvT7/bi5HuoUbBTGatt+PTeqzH+3QbWf8 ITmOVALxibeadNuTFa0xbA/PUVyQnsenpCXu+DQlRHYP39Xb3satIKVOfcq67GHY0dCg c/bBwaovz6sN/MKkmZkHVnEkeFCLqtpWr03dEGZiWERBH3Zq/tPEfVTbBNLN+vts6Htv n+3Vp7LYv37B9jEPyWTLs1RPpAHC9Up7K0TQwBBS42sOwAQrNw1CBdkxYkVzCqL+kTyB JEuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786897833; x=1787502633; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dp3y9HY6+OBWpLZwlaCANPDZ2TwUIEWZnAMUMpPK+e8=; b=DeDSlh6EAsYOmgtVp2e78ldTktq9qiMiEdrjBnFmCMSn15Cx/Q5yxzk8Elb/AOM/hS Krsh7CRSu5FWfFui2QtrvX1hqMiD1Rb40jncbhaiqLk2C9OzASiqQ2HhNEQmvs595YxB ZnuyAdGYVGlGqdEXB3V6KyrKUgBCbAiFk+UfcQEYNd3CSPu43/Q/1Ev0NK0EWmBVc/yJ G7WOO1lwqnU3A4DZCASzU5e2HDQKvQ6wcg7qOy+OuNI+FbhBBz3HoX1SK8SGuZsqAS3h NgMHEyIEV7Q1UDTAzoCVAmutgvryHmG4NgCKk3TN1w5IZ+JkbRlyEPSk3aRySp8Xdgwt 3MSQ== X-Forwarded-Encrypted: i=1; AHgh+RrqxbvBO0GHn6Y+Rgk0cmhCg/JAIMebPy7jnxahkeLXk5drrs/iBGidob0/wWF6VtYVB6B0QtbK+Ne8LNQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxBPVg+4BoVZEp/1RV7vRMxxU2mhWtE4QfdCOR5nB3tl5n1SLzj cYcqC06oWFd94OJStjuntr10Ok4/qoAMkUEnzWa/YbifA4BmWxa78lz2 X-Gm-Gg: AR+sD1188H3cOYBwQxE7ACSTg9L66mh/oXVlIfIbUvYLof5Rr3tRTXVij/TlqLQRYSW JiN7z/TMqqI6rw5XaGrCpm8Ghtb8nUq6yUtu3vKuvnFFLbjOMNdErKOCAt7oNrC1INr0vibZWuh Hr+FnHCWXOK4T5d5rcGBCzBrDMspp+c/MoZlhnr6pKNl+UXB1tHCb7lQZbmLrkrlAp0iBoEHHmY nABT3dt3LNtlGOszThP/Qo7N17oZASmZBHdXlfZVHAl2ldB1G/EoVObc9LcOVrtf9OcxbFR28iu AQIgjw75rbQTPmIGdoYyg9/gzsstywgXiDKrxjmqS3vwq6m3erQ6TQRxREy/47zBmuVkpDwmsGL 2lHl2a5nsE/n5C/9zHuPr/jEQCKCH4xSo8YoVG/UE54O+Ys0t1wid/lll0bGCn0+23K949dm2Vr r04SxLymVqS960A5fLiXRmRc7Hu/RS36n3dY598p9CC4D0f098t1ox/7G/mLbLPfACE0y7R6Osr tRcTcsQ2ZZIrQiEgYZuMGaZCnP7sjYHBidBD4AhVCisz3rfH4Ex/Oc+Z3sgxi8vKw4PHgq0I5wf tVqZtCNGC/wrtnRb3YeCd90n+pq7YIkf6dO+ti20gPKwsyhVJGu/41qT/xtqToWzluo= X-Received: by 2002:a05:6000:41eb:b0:47f:91f0:9a8 with SMTP id ffacd0b85a97d-4816079ece5mr35344656f8f.23.1786897832962; Sun, 16 Aug 2026 09:30:32 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-9dc5-9401-09c8-a88d-e919-d148.310.pool.telefonica.de. [2a02:3100:9dc5:9401:9c8:a88d:e919:d148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f219d3dsm25555239f8f.14.2026.08.16.09.30.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 09:30:32 -0700 (PDT) From: Karl Mehltretter To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: Karl Mehltretter , Michael Walle , Mika Westerberg , Aapo Vienamo , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] mtd: core: avoid double-free of OTP NVMEM device Date: Sun, 16 Aug 2026 18:30:27 +0200 Message-Id: <20260816163027.10044-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If factory OTP setup fails after the user OTP NVMEM device has been registered, mtd_otp_nvmem_add() unregisters the user device but leaves mtd->otp_user_nvmem set. On an error, the caller unregisters it again. For -EOPNOTSUPP, registration continues and normal teardown unregisters it again. Clear mtd->otp_user_nvmem after unregistering it. Fixes: e0489f6e221f ("mtd: core: fix error path for nvmem provider") Fixes: fe0b8213c012 ("mtd: core: Don't fail mtd_otp_nvmem_add() if OTP is u= nsupported") Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Karl Mehltretter --- drivers/mtd/mtdcore.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 16629382a787b..6158452be24d6 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -1083,6 +1083,7 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd) =20 err: nvmem_unregister(mtd->otp_user_nvmem); + mtd->otp_user_nvmem =3D NULL; /* Don't report error if OTP is not supported. */ if (err =3D=3D -EOPNOTSUPP) return 0; base-commit: 3eb40771c00a8488fa6ed2cc1fe203477908bf38 --=20 2.53.0