From nobody Mon Aug 24 04:18:05 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012030.outbound.protection.outlook.com [40.107.200.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3462F182D6; Sun, 16 Aug 2026 14:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.30 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890091; cv=fail; b=b02j4pCHAe96tS6U6qHbEfYPjww2kDPZkQUudvQ5qwi5pBmMj3k6q7fmpXMdBF91fppzLMIERb+ovkzOhEeqrXrQEbIMbTflK77js7GBfyzWoHD2gvmdjR2IepurF+2fi7KAMFNf2Zv5NtXMClsB2Kt7vpNq3DC1JB3rTSK/7ec= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890091; c=relaxed/simple; bh=W3O9sQIGbCzRUNvJmxf7/Nma0YTqbhLOYhDc3ozP5qs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CXZiO0Yd1oQ5K+aO8LvQn/tPc7AlbbOR7+PNWOyZoQLINCljLm5TtcDYnHv1Y6zmvJ8S0SxRDKMgWJbe4EhdfrpSNGECS7Yv9WJ1Ysg5hvVYwG7SVlYG+oPzZI1lyD5ciMwALzJLTN9SPBcBTTQRu8OL/RZcZxauW+dbgslHAVE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=kqq/sFpe; arc=fail smtp.client-ip=40.107.200.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="kqq/sFpe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O2rYegbXM1GfOZLcad2hk8vFDMrQCi+NLeXuzy1vr2hp9C/FYgJDrPVerTUzgj1c+v/NvH62/sbj3CA9yXuXbCCOrpELE5dmitYMxyxqaiHd8Pdf8F4PJ4I4WL99tpSau/v3B0RtlVeAg37vieK7m2PlwpCM+l3nY21rQdgisLgI4NAcMZx/tmCn2Zwc1rG5dhYfqi3dBtweeQzZl6hcgvtrkDYgmds5YFs7lKR4PI0SgrpaHORHO8kqcFc+17VgEfP0OuAkBKFPqvQNdHuMc7TKtDuInVv1r940/idvrLZG7AbjRzsvwFNQE/b/6poNCoHQ7lxUGKwNeEjIQn7UxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oyvfa1vyixYOAS8wi4hl6y4ND+r7pB0CRgEW5wYmB5E=; b=o9E9f/BzTPhs36uQ9qLtnGAWNxC6cQgP28gDr3cjrAHdrca/KLjAR+pRCDDDgDaSe3MxgbN/FhkLwgBOjprHw8D8rcvr2mxe4H8fiyjAORQiZtgJFzsr+oOCsEW+c/Eg/sL1s8Y2p9DqpXy+Kbp7X5Lq5tVF0WgCIDTwWG8WRVGlmtZ688CfwOcMgJw1AXjl5wazZ3sviYAdtFsX9f0Pe25Xodbg/2G+hN53x24RcctmCkd9RU+0++sU2L5dS3sZy0wuqIJu4y86LBrnCNAj4rKXN5ZhMhRoAcLM43cwM+y92RvkAc7r9BkYp5aSDPUezOKVXaLVuJs8hy0FTS1SiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oyvfa1vyixYOAS8wi4hl6y4ND+r7pB0CRgEW5wYmB5E=; b=kqq/sFpeqFDTM6f8kLQJEN3Tn28+IqNhBw9f5p+Ut+qlWabvLzuZkeTiTRLQoyKD3GUdguBWQtmziSVxVgzYoFIhMIejpjxmSD2Qet2ACvDgmLeBdNNkuWeZNtu7iHfan7vXzUlqii2bQ22tZS9T0P5XG6cCJf1JCYb4RJ+Qmu7FvdjPEN0zgLVqer/YgB4YOqQbLsBWbS8Lg2StI5A8G+gsHBLqJ7rltAjoz8DFCOpWWwc1qR+sVT4hfSMDb+zBDMQPVhs7ZJcna3X9bQhJ0mpO4I6k0o+jTtymdL/BNSan2guffXZcCLbXHsk2k+GCp7afAHPB/G8Pf+Ni0igrrg== Received: from BN9PR03CA0560.namprd03.prod.outlook.com (2603:10b6:408:138::25) by PH7PR12MB7257.namprd12.prod.outlook.com (2603:10b6:510:205::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.17; Sun, 16 Aug 2026 14:21:24 +0000 Received: from BN1PEPF0000468D.namprd05.prod.outlook.com (2603:10b6:408:138:cafe::ac) by BN9PR03CA0560.outlook.office365.com (2603:10b6:408:138::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.16 via Frontend Transport; Sun, 16 Aug 2026 14:21:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN1PEPF0000468D.mail.protection.outlook.com (10.167.243.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Sun, 16 Aug 2026 14:21:23 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:11 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 16 Aug 2026 07:21:11 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 16 Aug 2026 07:21:05 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , "Erez Shitrit" , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V3 1/5] net/mlx5: HWS, Print more details for bad completion Date: Sun, 16 Aug 2026 17:20:41 +0300 Message-ID: <20260816142045.3289452-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260816142045.3289452-1-tariqt@nvidia.com> References: <20260816142045.3289452-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF0000468D:EE_|PH7PR12MB7257:EE_ X-MS-Office365-Filtering-Correlation-Id: 213c5b64-c278-4c2f-4aab-08defba1a6ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|82310400026|376014|1800799024|36860700016|6133799003|22082099003|18002099003|10067099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: RQprUb+ff7XeDpKvOVAPqKipV+LiNQ4QwtUPqjLiA5fxR6lTwvXs49hOE3A5SoR9NrKPPaSGX0Hmn8yyxDvVje61841T/wrZLa6nFRlxZbEWGNH4UwuTWlre5PxMmmcmrhd2LRPDZfNEVBWyRpFIfi7x6nMWWrGQbRDTLPF7zIfgkpwGUgjccq8/nAzzfgesq0vXLU7/DS8Zer9gPk4fjZ4pqYwMQLOBMT8U3658QBVPExO9z6OGTwz31Ixn4cXRg5J+lflvzFqg0coM+L+5RxKWEcq5muyBu0g6zd0niK6CiZXWnTTY5Vgzqjz6FX1robfcDChuaWSG15jXvNYDLwUoYEppsGhSFSMEJQ1qFE3n6HyqDQUwB/pBBmuM0Gs8hvVFucQ08TkGAUauSb9YbaCUthg/TuQxDFxUPyJ7slZeZehUgQqsSNX/K0Clh1Pm/2r8AtiXGVSxSGSNjJ+lehej51EUB7T/ooL99E8U6VUE1ml9veTzJvkqRdbcrVKs50UX6WiPfqmp/yUZ9LvK+yroyByc4QY3eP0FgRJ0f1zxZy1ORv4aYvB5ZsFn3ryGXNQdY26rCRjNSGq8acEGd+mkJ8zfHVR76UE2U471VTuW9gKbrpaiyDCWI1/br0MkYzeb21Dw3zDGTpkWJ25koEfn0WA0PLXmuaPx9CtAYg0ZBOvv9QNDX30Jom9BMxK7MuFRNNTVyvMg0xPIvyhHEQ== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(82310400026)(376014)(1800799024)(36860700016)(6133799003)(22082099003)(18002099003)(10067099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: C2Ka64jaJTrVPvQjngrdCc/q8BHEyzcW1qgQfVBgv0oZ3Nc2d5MmgsQKGzWRIiB7xd5VouGEnCQmHa10xzvJly4Z4sXeAAjCHOgugaPKuDjapc5I7fc08TsR6koyK9KdfV3uvrTLhtPo6eVz/XSnmYty3PV7DVAowlyHNjgeN0eAZpSOpvB7KhNu3hbFrfgrIaudGS1tc8G36+lRabd+beDoSVC9G/BPVYkiyGL08n4gcURDB9QPhmiTBfjTEBL6wlMovsRQ6aJ3nfWA5w+QQIWTzGYCgS4joWzc/cOO92JTC0c1oZbTmBI6hYFCvDJUADrVdu4iSXTor/cjjURWKfApX6upj6gWeMiC5l4/0SYtO3vO7spIJvAN5C2yjNUeIdGahRyLwn7cSMmNILRNJ8Ckd00UmSpWKzrLX9M8aHdE8yEk6vTosDNwwerRmWAD X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2026 14:21:23.8250 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 213c5b64-c278-4c2f-4aab-08defba1a6ce X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF0000468D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7257 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When polling for completion returned completion with error, parse some more details: WQE count and syndrome number. Also, extract all the long value-to-string if conditions to a short value-to-string functions: do it for rule resize state, rule status, and syndrome. v2: removed duplicated QPN print Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/steering/hws/send.c | 63 +++++++++++++------ 1 file changed, 44 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index aed009aec4fe..6612e58c896a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -344,6 +344,36 @@ hws_send_engine_update_rule_resize(struct mlx5hws_send= _engine *queue, } } =20 +static const char *hws_rule_status_to_string(enum mlx5hws_rule_status stat= us) +{ + switch (status) { + case MLX5HWS_RULE_STATUS_CREATING: return "CREATING"; + case MLX5HWS_RULE_STATUS_UPDATING: return "UPDATING"; + case MLX5HWS_RULE_STATUS_DELETING: return "DELETING"; + case MLX5HWS_RULE_STATUS_FAILING: return "FAILING"; + default: return "NA"; + } +} + +static const char *hws_rule_resize_state_to_string(u8 state) +{ + switch (state) { + case MLX5HWS_RULE_RESIZE_STATE_IDLE: return "IDLE"; + case MLX5HWS_RULE_RESIZE_STATE_WRITING: return "WRITING"; + case MLX5HWS_RULE_RESIZE_STATE_DELETING: return "DELETING"; + default: return "UNKNOWN"; + } +} + +static const char *hws_gta_syndrome_to_string(u8 syndrome) +{ + switch (syndrome) { + case 1: return "SET_FLOW_FAIL"; + case 2: return "DISABLE_FLOW_FAIL"; + default: return "UNKNOWN"; + } +} + static void hws_send_engine_dump_error_cqe(struct mlx5hws_send_engine *que= ue, struct mlx5hws_send_ring_priv *priv, struct mlx5_cqe64 *cqe) @@ -352,6 +382,7 @@ static void hws_send_engine_dump_error_cqe(struct mlx5h= ws_send_engine *queue, struct mlx5hws_context *ctx =3D priv->rule->matcher->tbl->ctx; u32 opcode =3D cqe ? get_cqe_opcode(cqe) : 0; struct mlx5hws_rule *rule =3D priv->rule; + u8 syndrome; =20 /* If something bad happens and lots of rules are failing, we don't * want to pollute dmesg. Print only the first bad cqe per engine, @@ -364,26 +395,17 @@ static void hws_send_engine_dump_error_cqe(struct mlx= 5hws_send_engine *queue, =20 if (mlx5hws_rule_move_in_progress(rule)) mlx5hws_err(ctx, - "--- rule 0x%08llx: error completion moving rule: phase %s, wqes le= ft %d\n", + "--- rule 0x%08llx: error completion moving rule: phase %s (%d), wq= es left %d\n", HWS_PTR_TO_ID(rule), - rule->resize_info->state =3D=3D - MLX5HWS_RULE_RESIZE_STATE_WRITING ? "WRITING" : - rule->resize_info->state =3D=3D - MLX5HWS_RULE_RESIZE_STATE_DELETING ? "DELETING" : - "UNKNOWN", + hws_rule_resize_state_to_string + (rule->resize_info->state), + rule->resize_info->state, rule->pending_wqes); else mlx5hws_err(ctx, "--- rule 0x%08llx: error completion %s (%d), wqes left %d\n", HWS_PTR_TO_ID(rule), - rule->status =3D=3D - MLX5HWS_RULE_STATUS_CREATING ? "CREATING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_DELETING ? "DELETING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_FAILING ? "FAILING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_UPDATING ? "UPDATING" : "NA", + hws_rule_status_to_string(rule->status), rule->status, rule->pending_wqes); =20 @@ -423,6 +445,10 @@ static void hws_send_engine_dump_error_cqe(struct mlx5= hws_send_engine *queue, " rule 0x%08llx: |--- syndrome =3D 0x%x\n", HWS_PTR_TO_ID(rule), err_cqe->syndrome); + mlx5hws_err(ctx, + " rule 0x%08llx: |--- WQE_CNT =3D 0x%04x\n", + HWS_PTR_TO_ID(rule), + (u32)be16_to_cpu(err_cqe->wqe_counter)); } =20 mlx5hws_err(ctx, @@ -433,13 +459,12 @@ static void hws_send_engine_dump_error_cqe(struct mlx= 5hws_send_engine *queue, HWS_PTR_TO_ID(rule), (be32_to_cpu(cqe->byte_cnt) & 0x80000000) ? "FAILURE" : "SUCCESS"); + /* syndrome is in the lower 2 bits of byte_cnt */ + syndrome =3D be32_to_cpu(cqe->byte_cnt) & 3; mlx5hws_err(ctx, - " rule 0x%08llx: |------- SYNDROME =3D %s\n", + " rule 0x%08llx: |------- SYNDROME =3D %s (%u)\n", HWS_PTR_TO_ID(rule), - ((be32_to_cpu(cqe->byte_cnt) & 0x00000003) =3D=3D 1) ? - "SET_FLOW_FAIL" : - ((be32_to_cpu(cqe->byte_cnt) & 0x00000003) =3D=3D 2) ? - "DISABLE_FLOW_FAIL" : "UNKNOWN"); + hws_gta_syndrome_to_string(syndrome), syndrome); mlx5hws_err(ctx, " rule 0x%08llx: cqe->sop_drop_qpn =3D 0x%08x\n", HWS_PTR_TO_ID(rule), be32_to_cpu(cqe->sop_drop_qpn)); --=20 2.44.0 From nobody Mon Aug 24 04:18:05 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010039.outbound.protection.outlook.com [52.101.85.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE0633E36A; Sun, 16 Aug 2026 14:21:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890094; cv=fail; b=r+dmnxcGQHrT5p3/tJWclfXRt2sRPOJg0TDCLppW6i8H1zYVYKXp8tUBR549g/rhbUdskeHRO2l8UOa3bopujHkC0rWXTkCQy4pkUUfm0iVcgdW4qR7gFs7IuB9o8WGnVBU64veTGKcHsqEgp+YDHyJVHt5B63DzDiUAMGMLS0c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890094; c=relaxed/simple; bh=0m8mCVS+W6tXKvqCGJc5a6INAggMb6XXEK/0w5v29z8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QCIBwBivHQi0VYwO2ogKGGpoy9DNRDLjpLLAa1SGLOl0iwqwvlZ6GQZGLkSUBxC5uBgQeNs8MtViKaLxKBiyChxTrTtpW+Lia3HWx5lcu4VDLE+EQx55baZnLplsyD2dLQd703bWPm9NxBT5SbK22H8OCc0Gc5UN/SKCRySWoD4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=odslr2C+; arc=fail smtp.client-ip=52.101.85.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="odslr2C+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sn2zrQ5h+L69fGezy9rG/cEU441wBFEqym8BI9pLJQ0WBOD+kuevh46rRObAR4HWhoaTmtUEWxI3IkIHwUIB15qoNQ2hEjaTxMwfnllwLzwbwcXQem8jyyg2AlzhIlDmb/Z8WuG2VglX1y50+gZcLHmRNxKPglkr7PKJivQ/4Hcw0jDXOt9SWoHth2IqNtSzjBrhC+vNLZ0BkpvIVbp4PeZuI7iq7M+bCekkfmDqCepr4/FrCGdf0yyqv0ASzDlRFcOREhRAlx+2uz/Wv1HfeQajOgtlAte4JnbNquFaQGLUy1toM+RQnO0CY4/+xKAWc3Yz+Y0iNsyex/3yJIbqsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QMwqRO2GT1S34YUWsQdcgV++iivfvLQglnsQWEcU1Ss=; b=aeL6fEJE7k+OfsGD/uq07DWdHGJxlFReiETrbHO7bzymH3B1yvlMg1GdIBiOTot/X8MivtONr89xZ5+LcX7XPf38WVSlVhaGmQdHlKHyZ6JNqr4EvSEVwkk4jMGD9FRCEPTriojfBPYeOcfB9CEz1dV/VGsXGIh+bPjUnOSKsOrPxsljk/JMSl1hQ01BW909Oac/8qCLDXpvOPOTPnld/WZGNzGzQYUzvo/pxwCESxPnEmrmpE7I6K/IdvZuW6311iccnwKD6fwp8tAC4re4ZqgjcLBuA/BX1XSEmIrA/u3BQBpTH+FtDmHpvD67+BHMS/xlVOIH6nK4HF3Y+ufcLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMwqRO2GT1S34YUWsQdcgV++iivfvLQglnsQWEcU1Ss=; b=odslr2C+jZT0W96a9U08LhylDaRITmG3+M6aR8Ag7uZN52VIpxFIBVCzqwVMkcgqFQMoZCmTJN7c+X58apSVJq2gYeo0F4EMJlGJp6OoIw9qFNLs0HFC+1eykygxTeSP90CcgD4b09tGdYj9jGfrWDApYv/L9HIBAn3LGIdqmnqq+cMrh7R+u5wO9d/os6abCqsnWX1AgG2sMDsKpD7dttnNzaQJiBgPLfOtiim9M2vw5DVE9cx0Dox354BO9HhQIQDeFU/HXmYvtkRIAwzHesQ4Vjfv77oyQ6oI8LQTTorgVwCz3c7c/P3splm3vxENaxnQFCiVeq7GTtWk9AkTig== Received: from DS7PR03CA0133.namprd03.prod.outlook.com (2603:10b6:5:3b4::18) by SA1PR12MB6948.namprd12.prod.outlook.com (2603:10b6:806:24f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.12; Sun, 16 Aug 2026 14:21:29 +0000 Received: from DS1PEPF00017091.namprd03.prod.outlook.com (2603:10b6:5:3b4:cafe::64) by DS7PR03CA0133.outlook.office365.com (2603:10b6:5:3b4::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.17 via Frontend Transport; Sun, 16 Aug 2026 14:21:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017091.mail.protection.outlook.com (10.167.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Sun, 16 Aug 2026 14:21:28 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:18 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:17 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 16 Aug 2026 07:21:11 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , "Erez Shitrit" , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V3 2/5] net/mlx5: HWS, Log syndrome on STC modify failure Date: Sun, 16 Aug 2026 17:20:42 +0300 Message-ID: <20260816142045.3289452-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260816142045.3289452-1-tariqt@nvidia.com> References: <20260816142045.3289452-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017091:EE_|SA1PR12MB6948:EE_ X-MS-Office365-Filtering-Correlation-Id: b32174bc-bdbf-4a8e-5295-08defba1a9ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|7416014|376014|36860700016|82310400026|3023799007|10067099003|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Ye229HOhLM0sefPawYXL03Lym67UNALga2pyFvfwjKVgztpziNXpQA3IyFDb+iWA7vAT3hPvjAxYfdokO3FGrOW7Vs/yK5B1aAYhzzyjrGDeyJMcM32tXXCun1oi5fRPpsRrtSC2mVvw4FpWolr0V6RbeReE9051LIXOAnsxtQhEuhy82hRtA0c55i55sz92am2w1sJKVZWeAn6xDWbA7s0SizOovkdriwMEIjDOyLpRTJvil4on8jAWJ24ls1qODieD5OqSW/4gPR/+/sBNLdaj/bpWLlGQ0GpGwphFnAbTHZ9jC12qYmZ1+g5nSoFDxtH6BoZ5cMyLDL8AKh0SC2oYqoUXyMhvhypjOUiVFgZcrEZ6p0NvyStOlnlb98nXr4f1nZEEmK9JnM4ESill6E5XFWqUZBr+JQjD6wFAKe5cT/4a734K+Wi++zGGjTyQECnWTQNWci7ZkTo81WFLmqE4PDjoJYPn2Gc+m0nh517ZgM3w1dLapxNgKUG4reGTE9lYkyvYoxoh7+q7LWT0YC+ZsGfrqIQ+Tu+w7INZc4kbwSgE8o8C8L81eAPKeutmurdZ7UkNIGl2fUf87jUv/BnActuZZolczXR/VKKOYgOe7/4NmnArrf8fqOQcXtzMvuFQd1G6AfC2Hltukvu2LWEJaq4KftbShnjQ5cBbN+gphBNBaFufiqgVPjGq2dXQRNOOmNNY5c6AH0S+obMVow== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(7416014)(376014)(36860700016)(82310400026)(3023799007)(10067099003)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: i6ByCRruZGhSg5VGXu88XWXRALnGBgJjOXVWB/samTk65ziorc4PoxfcPgWVSZiaLt4spYdjn94frtY+9EhhKnm78FllCjIHE58XXE/341ASvth3e3rG66HPE0VZ/cmID1zBpDXglB3Rt4KhoPxbGX4Hi5brQtGAoKwHF0SW2elDz2qPHLNq+GGwWtDmYDxFVTOEMZpTuyLc261UiofLEqaj/Ca/xiqJTJZm4h7DyvRiKiYz+qpACOrjyukXbJFyZ+l5I2HSDL4bsV+ksZGsWcfZWcOOZd7lpLBpevfYKCkFps+/sFLN3FNgQ59RiRXJbW+yQAMQQqSm/fCLBsGW2qRP8lu5PJuBIkSIrqH+BuICmqILz3bwaVOGTDHtyi1wNZgsUlZaSla+0MltnZN09PAfycmxgNZE2aqp+C0NWKbsWIiMD41lmetOs0YxcETu X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2026 14:21:28.6536 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b32174bc-bdbf-4a8e-5295-08defba1a9ac X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017091.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6948 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When mlx5_cmd_exec fails for STC modify, include the command syndrome from the output buffer in the error message to aid debugging. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index 8fae90101653..2cdc03421433 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -611,9 +611,11 @@ int mlx5hws_cmd_stc_modify(struct mlx5_core_dev *mdev, =20 ret =3D mlx5_cmd_exec(mdev, in, sizeof(in), out, sizeof(out)); if (ret) - mlx5_core_err(mdev, "Failed to modify STC FW action_type %d\n", - stc_attr->action_type); - + mlx5_core_err(mdev, + "Failed to modify STC action_type %d, err %d, syndrome 0x%x\n", + stc_attr->action_type, ret, + MLX5_GET(general_obj_out_cmd_hdr, + out, syndrome)); return ret; } =20 --=20 2.44.0 From nobody Mon Aug 24 04:18:05 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010030.outbound.protection.outlook.com [52.101.85.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09E6233E36A; Sun, 16 Aug 2026 14:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.30 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890104; cv=fail; b=AFYGm3rF69DJR2hM0u7++umRz1vCCXrVECk37kQn1NKbpTpfES4wcMbKWCOrNr012N92Ie//VprA3iHtoyEmbFkZ+TfTxxS+tQZKJhl//5CxM0Ilk9cWtgTyyPA/Psjf9t9B1Bqqei329B3RPkj+M8MbApgRcnQ2BrsbGMDoZUA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890104; c=relaxed/simple; bh=Oae45WZrDulG6LPQimjkx4Vq0xSfKRNDyWF/9k3u1m4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZUCVcF85UozlgLgxdj3Zmg9FZMte8QRvykbjLNFavvlc8tsQiG4wUQGkfpWNY1siyFK26DkKb7VPxqpauKnsWE0EZo3oMYeCy69amXmjIoLHKTW8s2kRipql+vgtmhdw4REtVgHQZDvZmGLZHpszOf1TR5cN9xd9DN732U57lEs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Fo7LA7MN; arc=fail smtp.client-ip=52.101.85.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Fo7LA7MN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=URnUs8QuUf0URqCVBxpCCwPAqQSEUTT/RMo+Iyn+r36HWYAY/ZxiY4Uur5PzeBcY6DV3M7XM8q/db9CsJNIQos2A66p5Ngi7wW+x3/GFFZ9OoGlKfn2ZIhw122vKuUSGMzUxRR384noE0vhTqFKCtT7BbKUkJLX1bDKo/IBpGX6X3n3vWScWSTkxl+vSIjdFzsNCz5hnjK4HYAYZQcSuVMUV3OLc2YGHXbw6bFdFxZ7UuXf/uBrWNKmWkj/mw8kVwy2PdB2bfj0HT9FZuclNYJmvzetK6PDWtGaX4bxfNNUWiYHj2/PggRfWKtf61akfHXNpNzPSu8kvBB8BVHo3Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Avbxoj4msPmpU72pq89HoJIublgsoOiA8HZqD4RaxAo=; b=UzZfuvEPJnoSTEpC02faFG4ZjD4YI/TTpk8a+xIzYUtaC9qp0StvZBnzBUa6LEyBbnx4vkIhHZw9ac5IDYxEBscdiuIasRWrSPjieYg4EU7nqzmou6URaTGEmcEJYFwbPtqiiazNSuiYVVNgPL6VMsU7tKqY1NnT2bh7hJ/8r4WCudYlOfQlctq+tiXOece1JqdwcaVz6YfEMuQRAjN9sf2VxvEDhZCQ32ADiCTvveMovZuGSum//XKsxhoylxOI6CEDGlseTnHQ8l229BP45HazhsgHHSdPfgIaj+GveS42jLCQEuehNUXMm1EDw1+a0cwbDZqZgwIXuByOcYW5Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Avbxoj4msPmpU72pq89HoJIublgsoOiA8HZqD4RaxAo=; b=Fo7LA7MNO4BN8WilJo6ELTkuD1yHSKU9XwKqWhabVo66fMeQga2hN/dLakLzE8+n3x2ZZLkg7KqGonxRt+tFWom+E6Y5sVXbsxw9+RKgtZgg87lEGZEhSV6FYr9+iCkjFvQs6zVZh29seKMc88mAf/AYsXWtMey15foISvBeItJroJcl64/u0lIKhDsH14ehbVyZ2A2UIGC1ghA7BwI74VIJF1JyFFtO6j/+i4ZwHKlyBtRU8F+C1iUd6lOLlyPcgCJYXHfyZZ1s21vO2SA+eImqZWReou/aR1PydquoQ/upTLH4yuQuwWqrAhdWSw/J33cyyEqei4WVZbBMU29KJg== Received: from DS7PR03CA0131.namprd03.prod.outlook.com (2603:10b6:5:3b4::16) by CH2PR12MB4088.namprd12.prod.outlook.com (2603:10b6:610:a5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.17; Sun, 16 Aug 2026 14:21:37 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:5:3b4:cafe::73) by DS7PR03CA0131.outlook.office365.com (2603:10b6:5:3b4::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.17 via Frontend Transport; Sun, 16 Aug 2026 14:21:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Sun, 16 Aug 2026 14:21:35 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:24 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 16 Aug 2026 07:21:24 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 16 Aug 2026 07:21:18 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , "Erez Shitrit" , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V3 3/5] net/mlx5: HWS, Set the num of queues only when alloc succeeded Date: Sun, 16 Aug 2026 17:20:43 +0300 Message-ID: <20260816142045.3289452-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260816142045.3289452-1-tariqt@nvidia.com> References: <20260816142045.3289452-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|CH2PR12MB4088:EE_ X-MS-Office365-Filtering-Correlation-Id: 836e65e0-bffa-4618-7e96-08defba1add8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|1800799024|82310400026|36860700016|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: 8ZfSbU4aE2UUenDUoWdhbRf9YHO+YANOhLofM5ft7lWHgbkIS8oxHc27HkFbRUhlTBWSxhnY2Gk1g7sR0y4jRsYEB3oMTg0SqvCuZwM8125rXFDEjN12UvBBypdkLIry6TzNh1cHmcm9tl7GLMCsboUNr/mTGS/7fwDdysxBM8+BmmDRUUNIbCz8DVhINAlzGX7PdoKYhB1jFOqB6fG/tnVyxdvIAoL55j1pndJiI1sv/+bKua3dWkZvEMjBhT5BhaH5ItJuZjjhC364GJ/HDyLdpaduyobGfzfHtLWVygv6cCSWLt/vXGnSdj+Czt+F2mEmqdqwQ5SaIDqQThwtieJHosUvFXbby99LWL5TFocjnvwkhzYoOCEjkIrG4hmu2ZwyJgCbsZUeViYdChbp5YTTM5r8eVjoBe9ddpzhQd8c4/QfY1rx0/P1mWcvhYxZQClSpNiqpXay3sLgNZ54Wq9TSvIExFDnvqJAYS1N/g5DxIizKMy3UhgtHyYs5ohRznfpnTT0J24wPIt/dB8DNjLzOeuzKxX/jaf5wIPCPqzfG1Mnnba2CCs9L4EEzdjKb+vS0LXtg4yuf/Z1zKQj9qfaTPo4QWjRCvnUms171cagxJEewsOFkDKrU8JvRa+5hbuaHUtY2W+wm3Oi7GcqowywgvWct0qPSD90U/CI9Ph4pia8lNe5NdS72f+av3LyYaXFPA5y/CewzS9vN3cZ/Q== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(1800799024)(82310400026)(36860700016)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wPvr3Z9Mp+hOmKTynkqrSwJDKVahb/yAjD47oNqVRVsoGHpSwwluQWBMsl/IPChQF1CBCxZQEbMF2uiY0hsrycS3KNICNDf4oZU6mo205MdIkykr088mLBNy0H/Y98XV6NDEh62MIl5Zv1tV2hv7g7w01fTJ3OUIB3v59ygZJPKlfB83lpi8zdRGGg9Xbwvhm6Zy/sYGyFuakzM/Nvz8H34QqwLIHP8XIqFXakaC6PRYjlzT7knp5v/5AJ+6kCW6hjn4+EIFzHr9eP1IUAbu72bzoHt6IRCC5NV5TLqRIdQzsmcLmpB1QAPoH2kBN07qQ8fbgICkvUzeL4d9mXY6VMh2yaz2bX6gU1+x0DuYW/uuZeT/bs9R52qAPRN12VEz9Sg2Gcaojv2N384RxztI0+GzUFkWL3K/ZWXDJ+ZGrwfOoodpgPbZym7jtwgS1x53 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2026 14:21:35.6715 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 836e65e0-bffa-4618-7e96-08defba1add8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4088 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When initializing send queues, set the number of queues only when allocations are over. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index 6612e58c896a..df3b93499eeb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -1116,8 +1116,6 @@ static int hws_bwc_send_queues_init(struct mlx5hws_co= ntext *ctx) if (!mlx5hws_context_bwc_supported(ctx)) return 0; =20 - ctx->queues +=3D bwc_queues; - ctx->bwc_send_queue_locks =3D kzalloc_objs(*ctx->bwc_send_queue_locks, bwc_queues); =20 @@ -1129,6 +1127,8 @@ static int hws_bwc_send_queues_init(struct mlx5hws_co= ntext *ctx) if (!ctx->bwc_lock_class_keys) goto err_lock_class_keys; =20 + ctx->queues +=3D bwc_queues; + for (i =3D 0; i < bwc_queues; i++) { mutex_init(&ctx->bwc_send_queue_locks[i]); lockdep_register_key(ctx->bwc_lock_class_keys + i); --=20 2.44.0 From nobody Mon Aug 24 04:18:05 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010050.outbound.protection.outlook.com [52.101.201.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E072F2417D1; Sun, 16 Aug 2026 14:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890116; cv=fail; b=hD945KZtBTt4zltooV+s/mynDXdnJLZ8l976B512Z1rVCc6zx8sj0rCkS6mAoZjF2/IRa/HlXTQQUEN9WuPUodfvhizdbbguNhRVRj3gJnjWfyJ0yf/RS64HGg5FFGqTVg6MpK1gy3tnv394Zm1QsREcco3XnY0MnlAE3FDWVzk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890116; c=relaxed/simple; bh=BqdBky2MpSvkGrYn8twM8y154qItT/kJtjkfI/3F3vE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Xk5QB9G0tuTvNB2OSu64wQZsA/BbO8A3LkONwXGS4GxPRjzrNYfTgRuE/zgBkr+vp/CM83+UaMDyTFX2J+pQaZ5DsAcY25oqrTirXXWzY2Z89K+RcQA21IebjDuFi1C1OVJyjOoRhTd2MOwzGltsxtBeC2zQhejiVz/QY8Cwx+w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=DpSnQGRC; arc=fail smtp.client-ip=52.101.201.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="DpSnQGRC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F8n5xanI/7XLrlE0Cgi7THUQ9ZF78wRMMYO8KpmkBHsf70QA5y68toPAYm+ueeLMZmZ5ujPMYCyS4DZrEaSUPYxY0FrcWmyMhK4kii/ae8hhq9k/pmcYpdE7Z2P3jTfPztqScFTIp1bIye93ThqM9RTsKY+FU9by1X6+M92ej0UPThO+eoccIawZIV8rrY7TEdYmQ3Rnrq+1bikjctrEIDywOn7bK7EJJjAJ2osMpreZqvUZUrB62TshgS/ndH8xHb5UflYuxhqx+W1x/MNOGJrOVtG8BDenbMQB8yxU0puyztO+TU3TFKrECzxFGqv0wnKPhqg1ytjARTdYUxNm5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=waAq3pvXpaIpOkJbZrJVLU1YE3sH/BXHRAoWZqWHDQ8=; b=OcAr2SlkDkOd3O7pAOzPS8GshQl6JjEd3q7yqSnllWvYivdCAkTJlO5K5LXf3MLjCNWbf2mgWuI8CoJPjmVKY3fdtP6FVRwV/IeWRCUKKFhEZfuYhIbdkvP/81HRJ9+71kUlQJzfSaZ8ch6uPPOCR4GKL0SNbn9bwvz2xqtKqB5DLLhRa5/0Q9kM7v9Rg7EmJQ4dAdBWCmFsk9qRz4UU763DyzxhtBfU56cXeW7upskxRW+JWJEgZIoBv3ugKVShdY2U7cefJKUL/lQDHUztBsR1uZgb2PDtW+HdAAaTRo4y1fhGoffs5oXLhdAXbSNJiolg5EC/A+arkl13lkHvNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=waAq3pvXpaIpOkJbZrJVLU1YE3sH/BXHRAoWZqWHDQ8=; b=DpSnQGRCTGhb1UgJmihHQ07THN7kvaEzdpPlLaFlWEBl3lfFs0lSyJEoTgyUCM8Hfl0pq91RQtiziQg8zheUyONQrWLn3cMno3lLIYpznDfAE/xJWh3I9e4QxgAIk1ZvBXA2/oRwBphBzB9cOd1wq8lMMprEaXC1R1aKYmsoZmPg0M4G7TRYP3QYTRs+OKBUB3ujwIqJBzv9HMn+dudiD4M58xjFJ812w5KWqUnFK7Xr+3qpaHM9RP/Ph36qrEGIQRPOZd+iOn6dQuugx/y1mD18GJRbXokbBpZq2SnG4l1qh9DmLRnsuzeJybDYoO6D+imEkW/4HFBQ369oNO2jDg== Received: from BN9P222CA0018.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::23) by DS7PR12MB6239.namprd12.prod.outlook.com (2603:10b6:8:95::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.17; Sun, 16 Aug 2026 14:21:47 +0000 Received: from BN1PEPF0000468B.namprd05.prod.outlook.com (2603:10b6:408:10c:cafe::26) by BN9P222CA0018.outlook.office365.com (2603:10b6:408:10c::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.17 via Frontend Transport; Sun, 16 Aug 2026 14:21:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN1PEPF0000468B.mail.protection.outlook.com (10.167.243.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Sun, 16 Aug 2026 14:21:46 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:31 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:31 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 16 Aug 2026 07:21:25 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , "Erez Shitrit" , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V3 4/5] net/mlx5: HWS, Remove redundant MLX5_SET in RTC creation Date: Sun, 16 Aug 2026 17:20:44 +0300 Message-ID: <20260816142045.3289452-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260816142045.3289452-1-tariqt@nvidia.com> References: <20260816142045.3289452-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF0000468B:EE_|DS7PR12MB6239:EE_ X-MS-Office365-Filtering-Correlation-Id: 03543b20-33b1-4ae2-b094-08defba1b487 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|82310400026|376014|1800799024|36860700016|22082099003|18002099003|10067099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: lvsZYTxrcF2/MjrNme/xnin1tFx8eMQ6Wcp6lX111/erbUF9kQXafvgipeYTHYeBq8nhsogIhr04bY4/rRXKDuBlgBcuQl+tiBnAOLtK5wO5bdV1W6CKEwqCjU7dJAGNrFpI6jdpXNP5DafGcY0kk5SO0eC06pD2Qysqu2+XLs5HkiqncYDSIv1CZ6U/eV/jUHY2nnT8x8t5JCZr+nisXUtSZnTxVl4ICD5eFzU4Tyt3zcL/rebAkW6dTAs+ama/eLepIilQxfEGYvgbPpR/02ZD6kAL8gmYI4N8zpXX6/JeWm3MoQSXe5WvN8MP90hdHzIVRK3URykKq9etGtKvYMKswdEjwGL0FE/Isuc+6EWZVWqo828Y6IKUe11be0w1sGK5X7h1Mt0znYCxbTbd/oYP/zJWEAlO9ypeWZcuGsUDtcQjfmL/LrZ/o3aTVmOcnq5E8SCupz3dhx+7AWhZgXfMHxJK66W2uU8blAlgP6nHWLHr8oZ97KSgaLbg/iZu6QXQtxeQjOLjkP7TGQibeeRsWw4JgYp49DrTcN0jU1MN+RQhs0qHFkyA0y6N7W143k7qmHo2EtG3MfmIMXAAmf/BunbGpb47G2WNPbiTZJhuShhMTAHL1mH8dUGrXdMS+p9Mwhu26jgEsw4xwpV4IpyVZ6bEr9nshLekwob+jBeceHowJXiFPwHPedt7i6mg8VKEX8LiBGq1cqL+KZqcuA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(82310400026)(376014)(1800799024)(36860700016)(22082099003)(18002099003)(10067099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: flMQSCZK++psD2u/PxtZSjhKa1DDTd5G+BBXyFx7Rvn142RlX7sxyXdYFHi29VNY3s0tuqlRSE9JXOycXRBenTVtKaH5TTu5huVEvkQmWELNdnpwNlEUwBZ5bxdU5JpIsg+J507MacV1hasKR470AV7z39bqbxZMYTAVIbuEwkKh4XxXZWVIYozrk+PDII2gHgSSAYUii5uljbwMiDtuyBrJ0ZGoRU2z/WAJI2PENaJCkia0UNWyrTOFuRbEaHluwMg9GqIaSJdziMUWqcIPdZojhJ6BM+V7OyL1BD0N9HEwkCzrPM7rMHH1q5YRGu+lMa4x57Z6hR97rAnlwo6pHIE/6hiiOuh6su3Xj1xPHbOVHcNZIgvZIuJWxu+KY7W7WhMNAgJXDOam5HznRrhlRn30Q4wfwvypsccCtKrCFDWqkvHJ2+Vl8OnQY/c4AySl X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2026 14:21:46.8370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03543b20-33b1-4ae2-b094-08defba1b487 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF0000468B.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6239 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Remove duplicated setting of field in mlx5hws_cmd_rtc_create(). Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index 2cdc03421433..3782d793550d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -398,7 +398,6 @@ int mlx5hws_cmd_rtc_create(struct mlx5_core_dev *mdev, MLX5_SET(rtc, attr, update_method, rtc_attr->fw_gen_wqe); MLX5_SET(rtc, attr, update_index_mode, rtc_attr->update_index_mode); MLX5_SET(rtc, attr, access_index_mode, rtc_attr->access_index_mode); - MLX5_SET(rtc, attr, num_hash_definer, rtc_attr->num_hash_definer); MLX5_SET(rtc, attr, log_depth, rtc_attr->log_depth); MLX5_SET(rtc, attr, log_hash_size, rtc_attr->log_size); MLX5_SET(rtc, attr, table_type, rtc_attr->table_type); --=20 2.44.0 From nobody Mon Aug 24 04:18:05 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010063.outbound.protection.outlook.com [52.101.56.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6C513B27E8; Sun, 16 Aug 2026 14:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890119; cv=fail; b=oga4FWQIwsAyoC4G7CVUfOnjQmoNaBwOkksfyjOBOf9ZNchObPClaKwyPVnM4pQVjmFD6uv5Tk/VeTri0ddkntzXdghtnN3bvVUvaE9uF6cebdSwPynr4TJlYMLFtHS9/dIFUxptyIgdDsbL8K+Di25d+0f846ZVgrdHHFiOqYo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786890119; c=relaxed/simple; bh=ZfmuYhxhzd7qOVmX2xgtJ3BnW+EAFsqjVi7n0Yy9Uvk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q2gXSVNgRxeTZTbh3XcXYAzERIGWprUYEwgA/aUGXeAREGlBsww3SFiIWH/4JFEfpjfWFldskgRvEITu2cQFvbeRcQolytPE9i0ohJ9I6JVIDO1s1V4Cm1R5e1foyX81VQtAin7/3Wt7YyFPyIrmXMfBw7nsQQ+zin+rGX/geHw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=WW0B/TYm; arc=fail smtp.client-ip=52.101.56.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WW0B/TYm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qRB03xvQJY9bV7Es207xuU4JpJbLR1wuy5W2NVxzhWEmpHPkRxuXLqZYjPpg9GbLlDiy6joMH8QOvP2hEWZmzoADp3t4cgbLdNl08ajskL5fPc9Gc+4ZAE5K5+pG/E4xddhWb7vAq09Tmi/CV00/8i7mInUnEcENKATrG/4cla/0MfWUrbtmN3d9pM8MbArkbTAlk+trtJjWeJR022DPNTcjJd6bbreNkpuZZozZGwO6db0kHs1K21TeYRVFUKv0G3CrYWOFE7IfTJoUEQSmMgSRInSO7EzWm1e8kT6dBHfvLp+2casjbTenKk7xbEqwv9gsjgGo9iZMiLiy3dsXFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fw336ks0vWngNLjiNjUDNAt3ba7wb2b7GXRkR/DneGU=; b=nDIoqUd681ioCLFBTSN/eHaPMtCww+4TfWvlytQ/2abuZmhMXwsbwTAQhmjnDZUigfBopf7kmgHu/Sbm8Ars089MMgLfFYTM1V0WI75ACeTQeUJs7y6sMs1eO8fgh+KC1Qvwek8e6LCdskuV4gFffQQF8le9k0ObNnuR/wjMrGVG/m+fdFJ8lIgn8CxdGXGDavnK1YBCNb4spfCTLCsuv4sgXSoSrOC7kwtb7FELg9I3WHSUMNB8iQzbrOXvjNOhvvM/WWrROS75lZCrbVbGGOu0oV1gPBW/fra9Nkri1jPxgMahLxkUpIKLxr/E1e2kX2P+8gYQor9tBsh5XHPffA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fw336ks0vWngNLjiNjUDNAt3ba7wb2b7GXRkR/DneGU=; b=WW0B/TYmnK3xzm+4b7NdFt0MTdp52W04MvSzPjzLzYag1k9Yh2AHl8Ev7hxu/yvYFK/irfLTVE6a9tmrlTrxtX2YIiI5tcd8bVf83T0g1o1O3tW+X+dSwk56wINxnyBJaO+sf7qQqEt0zUdRV+u/4LPqydNjeb7t+obdPjH6VGoBFe0ujpofzx6SSiMbmXPZuj0Z8p70WIrEQ9BbltT3j4qBRnJiIOKtpUIxYdw0+XUru1XdArfPo+4kXc03VK0qWnbBgML/H3yv1lBupN48z2h1jS4vh+f4sYoDWWJskRQRuZOGGGWZ2hoOMA3WsHvwO3SQV6qF50iCISyo+6AmZg== Received: from DS7PR03CA0126.namprd03.prod.outlook.com (2603:10b6:5:3b4::11) by SA1PR12MB7441.namprd12.prod.outlook.com (2603:10b6:806:2b9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.17; Sun, 16 Aug 2026 14:21:53 +0000 Received: from DS1PEPF00017091.namprd03.prod.outlook.com (2603:10b6:5:3b4:cafe::a8) by DS7PR03CA0126.outlook.office365.com (2603:10b6:5:3b4::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.17 via Frontend Transport; Sun, 16 Aug 2026 14:21:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017091.mail.protection.outlook.com (10.167.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Sun, 16 Aug 2026 14:21:53 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:38 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sun, 16 Aug 2026 07:21:37 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 16 Aug 2026 07:21:31 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , "Erez Shitrit" , Gal Pressman , Jacob Keller , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Saeed Mahameed , Shay Drory , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next V3 5/5] net/mlx5: HWS, Remove redundant FW command when reading caps Date: Sun, 16 Aug 2026 17:20:45 +0300 Message-ID: <20260816142045.3289452-6-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260816142045.3289452-1-tariqt@nvidia.com> References: <20260816142045.3289452-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017091:EE_|SA1PR12MB7441:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d216873-a5d2-45f8-c530-08defba1b83b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|82310400026|7416014|376014|1800799024|10067099003|56012099006|22082099003|18002099003|11063799006; X-Microsoft-Antispam-Message-Info: v+ItfRgU7LIbn728kSAdd9kvGdtReMOdPn/42ErvA7qIczK/IyAc6bDe8vihsgB4a3FQtx4I9nC5xEFUjFSi/zTOqLoWwKnz3d/eaUMf5mjmhyVd5XhfAY+aa2MLv9w+UqVHGvkWr9Lg2ImCHtM3lBjU46PjezAMz/8LP+XIXO1VF+a9SlKiVb/hoCLWcPcNyt05W5189g0aTL9wWGAgL2byFcVYuvkpvFacaXHk8BbatxzQGxg6buV943ZPytOhAT7lePW/W3ghRd4kXgv1S25i0n2JWJXCWPRPCuSCIQTumu+fn8FLK/oYOVQ0nJj6JBTVk3yhO7DiGgYaXV//O5LsvumpiIvz69TvsorScjUOYTBvMVhSqF6lME7JC0n5TlKgwuXlHioMK2Fn9/wR/b0WtLu0Y/anpMSFqmW2A6+PMmB/7DaW4y745EYp8JP80mGDsLAABwHqHrvlo564W9hvNvUqfroyWe4IudZbgaeM1j7+/AkRXD1ajso/x2uohWkiYNoXeNNQK9tlLEA5LGWZsHtmBplgULIOxZoQU08T+Ztj3Qwm+MCNt2Kt716PPEXaLoxIqz63b//eIdVE2eX1MwzfuyMAmx2yfs3QRvo1Cd3KOB1iN9cYysxS4F4zGEl50XAI/MKtj/SMfbytvQJH8yN6wIpE7GfF3hfg0JYlL8JVO5ZJXr77/A4eHMME3HmQuqGOYnTTshwBSNgfpw== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(82310400026)(7416014)(376014)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: aYPpBTA98adRrlLboy5yoHtchmBStjnZ4Dvfg/4Lf5Kfc8svJeggjnkwjuOQAHu3+yMp8I2V6dhdpeICuLy5FzItdBd3lCttqE+N7sgs88I4RV08vF0TmWcLNY8CPcqdIXqf/ccJVeEJzzbe9PpWZWD2vwDydiJLSADywX2uWq38Kd+HnTmwKeCImu1t5AGGqrwThuVtA44ileDWlA+OnrE1S6Ba5j26ofnd7oGZIGCty8VDNPhSEroujDS4WdqBia6jifeesPwR+0ziUZkVXQ+7LpT/LgnlWEd02GzHAaroXHMpVBPaypHVuOKcedouIoPpDkIfq+bZnhbYM0IzuxojaHholL6QSF3xx+TuPFtxTyojxbDyutXTcKPpGZq8jmU0Q3TYzCckFpi/giYY9bjpMDXyOvYvai6088ZoHRYU9BGFERdUzlaG50KVrvbw X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2026 14:21:53.0861 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d216873-a5d2-45f8-c530-08defba1b83b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017091.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7441 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Remove redundant FW query that isn't really in use. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index 3782d793550d..775dc5c2d7a6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -1182,12 +1182,6 @@ int mlx5hws_cmd_query_caps(struct mlx5_core_dev *mde= v, capability.e_switch_cap.merged_eswitch); } =20 - ret =3D mlx5_cmd_exec(mdev, in, sizeof(in), out, out_size); - if (ret) { - mlx5_core_err(mdev, "Failed to query device attributes\n"); - goto out; - } - snprintf(caps->fw_ver, sizeof(caps->fw_ver), "%d.%d.%d", fw_rev_maj(mdev), fw_rev_min(mdev), fw_rev_sub(mdev)); =20 --=20 2.44.0