From nobody Mon Sep 28 22:31:02 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA28381C4 for ; Sun, 16 Aug 2026 06:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786861050; cv=none; b=fc486cJygiIsNck7tze3QhD2Dp3eamb7BRcgXoLasK/hyqGhZZ90KdApNo/WqyO1qilAYqhf//pBu+oDx+fZcZ96vkwSJSxYOUNxJN6gC8g+AkYHWyeO9w1vJMw5fzHLWHr2m+fNISOriv5awuCayk5cV1g1TXX0bb7PmP06gBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786861050; c=relaxed/simple; bh=9rkh+l6xraLTWwL32qe6TKz2/frEdnGi3YOr9WdAETs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FU3zWSq2crLKbt8yXIVa/UsWRYaOwOYa9XtmJCAxm/8c1pdZpB4iYd5AipEK5xCVSCFh3kKP95exWL68RbDE3Z9hSThgaIF79Hk+SYKqIO0KWBvPWwfuer60prE+lf2oIaHrMJOUzm9VDwv2a017npkABlJatwPx+8+D0ruA9JA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DEE9Swyi; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DEE9Swyi" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cc7e86e7aeso25680985ad.2 for ; Sat, 15 Aug 2026 23:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786861049; x=1787465849; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/lt0MYPB2A8n9D+NrNfP6TZGyktOpHcmig9SIzvH9ZY=; b=DEE9SwyicVMYdnUaIW1jzVnbllX3Na5ABZ7ZwM7WadjOJrd+aW9UXvmeJUJoAl7/Cc yyOEMM1iCuhZR0Uh5uyZ5PzYcMX93bLZg2qaiH9WMl+8aAcTuO0JwfQu+/v3W0e/gEn4 2/CvOFqUr1kg7XspSrdWLLLp5k9ItSi0pzUDx75Hh6r3OYbrnqBG/KjwHSa8lhzaCCpY Z3lmuGWm0TgqLF7T/tnVNi3ATuS4aOA1x+58FgVlpbwT6GJ4S4cNo6FlR6jlEKogQnoO rGj9Z/hZlhYYxt0IfJJ7ec4v6bKLkw/40RfO23gYCc3pR1e2Fsudjk55tlB3aKEXGyMW Si9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786861049; x=1787465849; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/lt0MYPB2A8n9D+NrNfP6TZGyktOpHcmig9SIzvH9ZY=; b=j/CgYB10BunB0O/3igBKTcTVRgQz5/Yc7TNlLGQW+GnsALrpvOzKbnS5xStJHpWa0D OAboek5CNkHs66PmKAhIZd5GWM9JX5Jv1DqA0LnU+GG7/PYXQLZ5l3bjm4ikz4pqGOFy lC1KYNfp83wCMMNBttm6pIAsbPc3ha42y4QgirgTYd5Xb4P7QEd3d2YbZYu1fAHiq/Wt jpniDKAaE0HfesQdMiazeoePYbYs5jxA1EdjakmH71pUv8FAsYZHFwEXVi4RLIJPpMfT M75zrRSe+YdRSPaGdMCXB2o86LdgUI+C3WUtgZJ1UF66uGd/kb3tPpdYznjHysZHOoEg RNVQ== X-Forwarded-Encrypted: i=1; AHgh+RrmPNUJHEmXMwHOamZMS9+fzvxg7E0r3AIMopz1bIZBEakCcHq6dmY4Qg5C8pK2Uvm/xiLv0QkhTHqKl8A=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0SeHSJO1rrLK6zcaVjwYN8Sd/H07mCX8k1jcMXC4upGiJ0puW Qydvl4B7hpkJvLNTUq7hET+LKb2SVbt7xrv6KHHkEUuV2lZAAMOAr+NhLblodA== X-Gm-Gg: AR+sD129L0qxg0bd/A/dOHoC98gj1rzex4rk1axLYXkjF4IM6p40kFsCs14JIhVzjVc mg3e+WtRjPEtBk5O3eQsnQ8DU6CzcCintWhJflHT4TT9AJn6TSZNao6uJtxY5oYT62HwyZmwUPM e0BSmurMoHu4GZwbhjE/aCkSci5/m3WP/kUV/dAARYwmea7EFVy39HJCbvRaKLAS0T7WwsWA70o NT4Sut+OBAxrpNr2VjDI8Ku6jLyZyvta2VMT9qOZgN2LaXUO+ldm/y+ekOY5t1fInTTkppkJJAE fr5wP/SOVanNUfGJ/+hvrIp4CMIkNVEm9tkzukM7ycg7TdgWhbxfGm6AaAg5lEznjpAm4GjaPyi T9WEAu1XI9rvRdSgBJbLNjQnIYOyPlP/dQMR50kWHutRdsooVB2O5ivl4M/LXwlnEdrwdJvy0/B 7Y6zkCJKZsOdbU1HfeYrdWhx3du4QXnyh1uONEc++TqhbN6R40j6o1ADyml8ZExzfNNg== X-Received: by 2002:a17:90b:3c91:b0:380:f85c:94b4 with SMTP id 98e67ed59e1d1-3933b78e3c2mr19285769a91.7.1786861048973; Sat, 15 Aug 2026 23:17:28 -0700 (PDT) Received: from Default ([2409:40f4:1032:c11e:2df8:ef26:4db8:5cbd]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141387e49d3sm27378993c88.7.2026.08.15.23.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 23:17:28 -0700 (PDT) From: Jeffin Philip To: gregkh@linuxfoundation.org Cc: jeffinphilip14@gmail.com, balbi@ti.com, bigeasy@linutronix.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+fd6ef980cf1c722be639@syzkaller.appspotmail.com Subject: [PATCH] usb: gadget: fix null pointer dereference in usb_put_function_instance() Date: Sun, 16 Aug 2026 11:47:12 +0530 Message-ID: <20260816061712.15547-1-jeffinphilip14@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" usb_put_function_instance() attempts to dereference fd inside fi struct to get mod in uvc_alloc_inst() error path. However, fd is not allocated until later in try_get_usb_function_instance() after allocating fi in uvc_alloc_inst() and thus guranteed to be null in error path. Fix this by adding a null check for fi->fd that returns if fd is null. Reported-by: syzbot+fd6ef980cf1c722be639@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Dfd6ef980cf1c722be639 Fixes: 0062f6e56f70 ("usb: gadget: add a forward pointer from usb_function = to its "instance"") Cc: stable@vger.kernel.org Signed-off-by: Jeffin Philip --- drivers/usb/gadget/functions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/functions.c b/drivers/usb/gadget/functions.c index 203361a64212..70e31c40e267 100644 --- a/drivers/usb/gadget/functions.c +++ b/drivers/usb/gadget/functions.c @@ -70,7 +70,7 @@ void usb_put_function_instance(struct usb_function_instan= ce *fi) { struct module *mod; =20 - if (!fi) + if (!fi || !fi->fd) return; =20 mod =3D fi->fd->mod; --=20 2.55.0