From nobody Mon Sep 28 23:07:47 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AD4519F12D for ; Sat, 15 Aug 2026 13:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786801704; cv=none; b=YBiYEJIsvgBxtCSLVJcq32KxE/2Bmdl8E1KCS9eU1AIM1LBkkOTQEkIzn6tCFM9boIm2ExRA1SdCpPq4kpcJhr6e0j/7/THc2m3im/kYBy95gjR+23e0uWzNKjliMkAjhQxL8LeI1wfsZr32VEJLBGx+INREeQ6wTgALOh35VKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786801704; c=relaxed/simple; bh=bKn+IkaMmtzY07xIuBqZ90CnPdWfJTBZmFmcpyDyyLY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gOfRCnrKfY5UcJIOC7Xr+dI8AmjonLgvHVbPsplg94wIJTR68PJ+yB7honfvB7KCLlmxklnbEOpY02thcNHyCnyTdMPQBuxopuWr8g+5gNmugBfhi8CSifOXrpUnxcHdBPHB7SsJTLT+mitGkUipPEIsc9WfTunsURNjY7IfTE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S/k4XwDd; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S/k4XwDd" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-383cb94f742so2287109a91.3 for ; Sat, 15 Aug 2026 06:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786801702; x=1787406502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=2eb8yhaSP6esKUtShVLG/ljDKlqOdP+bfjrtAJ32aMY=; b=S/k4XwDdo80L6yheLv2JLkjMXcTUSE7uIxaojx13O616hfDrm44MMkVmUaWJM/OFLO 7rBawkVba4HWZ7SpW6QmrnERYw9m99SBQI+G8mflz1VvvU1PEteub1ZqLUyloFdTBwGD zrnlOk8SFnK6t5s8KkeRlLIjMXX0Tc1YXeBEXr/GCC/1zJnaLnyFlikv96X/Xgs78heK ThEr6eDGycFcxWuq9b8ZQDOVbjprkZAQ6ehCZ9F5RfwWJwXNmdKNoFsIwQzGO9wUqXn4 bZxz9icQrz2Y5tzekCTr1KvsqSzT+PjVBEpX+mTGqh+4RFBSRLSeD5Dh1ttvHcHSXbTH 9PKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786801702; x=1787406502; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2eb8yhaSP6esKUtShVLG/ljDKlqOdP+bfjrtAJ32aMY=; b=IxmCB+eUavYc1oE6paadxnycVoWK1s1iLqp70Gb5VNCbamc+W2BQ3NfuCSqSc7mp22 ZWYIOYSAN6LjXRj3qB/KifnMaI7+LnwKW4KXgbDyvKablD3N5pi1cL5pS+Zqkg4E8rVL TzuR/4kCTa5ofIXkPHtiVk5oenh8FGZyfUmsxiPhPqRFD2+WJZOGLAAZZTPpTdJYFhLd KCgsMaRzLkSV3OXPc0RoxA8OSv+vYK326QNm5C3NkwdLpy70yIjrOXnksjJ1fLpSf1/a gm4eW/zyq6r2Iave9s8EzWrfpSJbcAnLZ+v+q+s0YAUCnKeSUzyGL4qSK2nrmPsMGrtn JQ5Q== X-Forwarded-Encrypted: i=1; AHgh+Ro47tLNa3T+KSaAc7kyjtLs7dbcQ5Ep2uO4d1j0OLiKK8IV2R0MwaIGPLYdJy3FZwSifnB0bje405iyvF0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx89I4yeO9GjCSyob7DpEAiuDkF7fEYTmHsMknygJxppCv5TGBn ZC9dCnfijsO3kXIHoyjym7wnkeXgLwGUDiumaPSL67vgN93aRMDjrsYO X-Gm-Gg: AR+sD135CHay2C60vcCnTv6xQJsjpuHCdszwYwCZr3eWnrCetTtDMz9yfwjxGO1oaiK dQAmy4rkkSQ4yXKwPJVqLW6N+2UY4tud+IbVK67KGEEVUFrDiaCKDlOCBhZIoWQhzHWIvu87u5r /ET9ZJ9m7gAXoORyvYXS56Prwobqb373xxASwVu7g/oNp51eSNPAjg0M4l/X5PlawxAM9cDRRK4 UunMBTP8/y+YS8Lw/PjS0VSmew5CdnQ5HjrC3vvb9yqIcnZwEaBIexLiycfbuA3W/lK0pD+7T1z AXWVbA1+uQdsnfrJhiKqXE6vRWCvfWxcHai9Y31RrI0KpYVsJl274cRi7lByWVZI++hg+2Q6Cmz Zbcm2VfcwoWD40VjpcvUW+3gr/PQl4jzwrOGb0h/jY5wNP6mQugSALu/RA/gWIVUnxKGbou57FF LxvGcbshr5lzJbKzyeqol3sf/MM564Dleu2bW6oaO4Vg1SYsXaAm/H0UWf0T8wBeSvmeESwiv9X anlN+doSlBYp3NO87xS+b7f X-Received: by 2002:a17:90b:2d4c:b0:37f:f4ae:5f25 with SMTP id 98e67ed59e1d1-3933ed3fd54mr15227726a91.20.1786801702349; Sat, 15 Aug 2026 06:48:22 -0700 (PDT) Received: from localhost.localdomain ([103.179.231.124]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141388b2554sm28629273c88.14.2026.08.15.06.48.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 06:48:21 -0700 (PDT) From: Sreeraj S Kurup To: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, axboe@kernel.dk Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Sreeraj S Kurup Subject: [PATCH] nvme-pci: return -EINVAL when failing to parse quirk parameter Date: Sat, 15 Aug 2026 13:47:45 +0000 Message-ID: <20260815134745.7263-1-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In quirks_param_set(), if nvme_parse_quirk_entry() fails to parse an entry from the user-provided quirks string, the function prints an error message with pr_err() and jumps to out_free_qlist to free resources. However, the variable 'err' is not updated upon parse failure, retaining the value '0' from the preceding call to param_set_copystring(). As a result, quirks_param_set() frees the allocated memory but returns 0 (success) to the kernel parameter subsystem, silently masking the parsing failure and incorrectly reporting success to the caller. Fix this by explicitly setting 'err =3D -EINVAL;' before jumping to out_free_qlist, ensuring that parse failures are correctly propagated to the caller. Signed-off-by: Sreeraj S Kurup Reviewed-by: Christoph Hellwig --- drivers/nvme/host/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 69932d640b53..560560268c05 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -213,6 +213,7 @@ static int quirks_param_set(const char *value, const st= ruct kernel_param *kp) if (nvme_parse_quirk_entry(field, &qlist[i])) { pr_err("nvme: failed to parse quirk string %s\n", value); + err =3D -EINVAL; goto out_free_qlist; } =20 --=20 2.54.0