From nobody Mon Sep 28 23:53:42 2026 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F2AA3515CE for ; Fri, 14 Aug 2026 20:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786739277; cv=none; b=jzdYUHosSDbtdzVkMsnJewAO4vWtg9VgiArvowSXkLSDQvIMYNsGJXCWl3GHltQQ16gV/TtmB8Ph/qgxJLxLahr2b36H3AUAqTKZVV2EKL4K030AYO9DjlXC8DyP+zo9w8WTes1MrNd+AnRVTQwb5MJhEK6PT2d/trRQMH7lbDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786739277; c=relaxed/simple; bh=HFXSVOgmCdmw3rAs3NeHiZ5PVmxyIWzkuC2DG3r9bQc=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=pjPvOXYRKQ1qu31hH5T6IB0yEEJomJjVbEYt92dGVqjTvXluUy/6WVFgAtGljXAWsRgRmGLWmg91MO9phfb+cj9+scqStidUkkA3AohANYF2GfCYBghVM0b57UShkq3RB1D9b10bMXeGWx9d6wWcJgGgZFdkAdm//pd6aqyrMt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Kr43rJDC; arc=none smtp.client-ip=209.85.215.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Kr43rJDC" Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c9fe4c5eb39so963516a12.1 for ; Fri, 14 Aug 2026 13:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786739275; x=1787344075; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UPJWlKjLv6ZDAjliELzzhodIr3XvyErgyPYy/hwtGcA=; b=Kr43rJDC5eXIUi9SV0IMcFOocXgllX/ht+gOXq9asjegVngmv1/VPC1XbY3vZ2Y8M5 WhFICzvLszHUh+1bjrN2I6eExM/n/XcPnKU0YdGDlfSKkw5hdaC44MyVL2cxFKTe6niD +52GwQE6pFByRyDRxuuQRfUSZgQRtX5QQraBtc+Pfa/B7NouepT+uyMvnUkpgul34BJo vX3eyk/tetWa4T0rcuSIvYV/iCHFOZwzgJQt/egHKOCsVF5osY5CCkheWr7D8rftqbw8 s6Ukppsan5SCXVwzctPZyEg3ug7sGLQZENV/XsVXm7dJo8DgiX0EwkvCYez1/oeFOSgt CFNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786739275; x=1787344075; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UPJWlKjLv6ZDAjliELzzhodIr3XvyErgyPYy/hwtGcA=; b=SejT51/qKBO6NZufVZdKVNhPHqgFFO694IRIfh/YL53v5HTpOobbCYvZxbb2xfEozJ o1g2XUi1v23JLcicaf6iJZVNctRYFdjnvKGjXVcs/6ppBGkIjJkEmVrdeUVjw5/RfN7u F5uO2wEw0qxwD/SnMA7PrhfW9Adhz6ZBi6E/zmLe1MtB72dDpmsH/nbZxMmzU7UC4b85 CwMoSoJicryHf6R/jkmBbmc7uOUoB+JPIobzp3AuimIXZGBjdbizsyRs9ifsWa/a9z4d jlfvWQqMxPHqCumEgKxLCSkOHyLJuCNTV4L8GRWPzcjkUlad0PvyRZoNafwvTQUbO/6p 2KoQ== X-Forwarded-Encrypted: i=1; AHgh+RqR7+COtVUqhdkoFKUUi51mtq2Jn/onc+VctFXWKbWl49dKk7IeBM+HxnPEckBFIkcNJ7YQVijCqX1TeA0=@vger.kernel.org X-Gm-Message-State: AOJu0YxZ8Js9CEG5o8Kli+y9kGe2VACAJtF3INZM+MvxShwC0KPUVTnJ HUkiwPDWWdD8yv757R1/pA7+cVLn1tZJRb/Lf2yjvTWtGnSQVFCs7B3VaclfOG3zMbp5dhpdCCi vKdjjpCi1HpVXHddEaYhEpk56Rg== X-Received: from dys15.prod.google.com ([2002:a05:693c:800f:b0:30c:5c4a:b8b1]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:728a:b0:3cc:51ff:c2e7 with SMTP id adf61e73a8af0-3cc71dd8814mr8340939637.10.1786739274588; Fri, 14 Aug 2026 13:27:54 -0700 (PDT) Date: Fri, 14 Aug 2026 20:27:32 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.691.gc56d675ccc-goog Message-ID: <20260814202754.433725-1-almasrymina@google.com> Subject: [PATCH net-next v3] selftests: drv-net: devmem: fix 5-tuple flow steering From: Mina Almasry To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mina Almasry , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Bobby Eshleman , Stanislav Fomichev , Nikolay Aleksandrov , Breno Leitao Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" `check_rx` sets the `flow_steer=3Dnot hasattr(cfg, 'netns')` kwarg, which signals `ncdevmem` to attach the client IP as a param (enabling 5-tuple flow steering) when running on the host. However, `check_rx_hds` currently omits this kwarg, forcing `ncdevmem` to only support 3-tuple flow steering. If tests are run on a real NIC that requires 5-tuple steering (e.g. `gve`), `check_rx_hds` unconditionally fails because `ethtool` rejects the 3-tuple rule. Testing on `gve` with `devmem` enabled shows the failure is rectified when parity is restored to `check_rx_hds`. Test results before this change: # ./devmem.py ok 1 devmem.check_rx ok 2 devmem.check_tx ok 3 devmem.check_tx_chunks # Exception| CMD: /usr/src/kernel/tools/testing/selftests/drivers/net/hw/n= cdevmem -l -f eth1 -s 192.168.1.89 -p 39105 -L # Exception| Running: ethtool -N eth1 flow-type tcp4 dst-ip 192.= 168.1.89 dst-port 39105 queue 15 # Exception| rmgr: Cannot insert RX class rule: Invalid argument # Exception| ncdevmem: Failed to configure flow steering not ok 4 devmem.check_rx_hds Test results after this change: # ./devmem.py ok 1 devmem.check_rx ok 2 devmem.check_tx ok 3 devmem.check_tx_chunks ok 4 devmem.check_rx_hds Signed-off-by: Mina Almasry --- v3: - Sent as a standalone patch. Dropped Patch 2 (gracefully retry bind) from the series as it is no longer needed. - Dropped the 'extras =3D [f"-c {cfg.addr}"]' addition to ncdevmem_tx as it was unnecessary. v2: https://lore.kernel.org/all/20260803181852.491437-1-almasrymina@google.= com/ --- tools/testing/selftests/drivers/net/hw/devmem_lib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/hw/devmem_lib.py b/tools/t= esting/selftests/drivers/net/hw/devmem_lib.py index 3554954a6691b..5a519713b2769 100644 --- a/tools/testing/selftests/drivers/net/hw/devmem_lib.py +++ b/tools/testing/selftests/drivers/net/hw/devmem_lib.py @@ -306,7 +306,7 @@ def run_rx_hds(cfg): port =3D rand_port() =20 listen_cmd =3D ncdevmem_rx(cfg, port, verify=3DFalse, - fail_on_linear=3DTrue) + fail_on_linear=3DTrue, flow_steer=3Dnot h= asattr(cfg, 'netns')) socat =3D socat_send(cfg, port, buf_size=3Dsize) =20 with bkg(listen_cmd, exit_wait=3DTrue, ns=3Dnetns) as ncdevmem: base-commit: 9958e69b98930834a576e156f6458166d1db1c02 --=20 2.55.0.691.gc56d675ccc-goog