From nobody Tue Sep 29 03:55:07 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C58E385D7E for ; Fri, 14 Aug 2026 19:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734881; cv=none; b=iNkcUWNhFvQ16q7rwE8759pKRQ+ahATYq28PIHZ6sp7vPA02ugi+zdG3BwBH/oJQPwrglWE6xESYDTdZCnxAvHJkadrxOYaag7g1ViEtLQxFY/omCY8MY0PEvH+y9VtswN6jXe75+0M9bR3UVwFuMjm6A24Bqe7w0d1TlVYN2Zg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734881; c=relaxed/simple; bh=5Y5sL6+J7vx7knLCO6QvJggTZVlGNEgVsdnejYmQ5hw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HRl80f328EqTcIrUNU3uOaXJa3pQNsIQ37VqJ9wPo7c/YqSRB6i2bcsRXvEVttrNiS7nUaN4W8dI2mxM9zsWMtc3YNij0rQ4gpOE7TFM+EqcT+BZ6vH23xsmTJCLElOxPqy+rWy8z+0tciX7bCcNxltVnFfXMz+DvS3kbUhG6rU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bywXAKZk; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bywXAKZk" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2d049069377so15341535ad.0 for ; Fri, 14 Aug 2026 12:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786734880; x=1787339680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tcB5rq4VZBgFk1thgYSh8cIbkfOzI14sOVjDrq4EZoo=; b=bywXAKZkv+PUj3UcegTh+QMlAWRgbf3btpBGnJ/VINrPf2fdNVDXNKcOXXi4insOWB NCnfHf1L5W+Gsf9/ZbfaGi/CJXQdRwdFDYhGjnnnumrfJvVnM0svnzgzuFN09HE0bugN BoFxna0xvQTWaJi5E8RviII1ExWSfmO/ObirdSpBjTr4Ep9z+oLSmeC5GsFk8c0+odts 3U+Oi8vtRXCwgYhhI9xlKJxb6TOUKaCAZKALLO+JNmMCZ+LZE8NHhoKAqwPSssgqH0jH ZFmVFgjGGzp7kb4O7uKLG5bGzteVdYn2DK7UmfuOFgxSWHMiFFfhm7MYxpX04vbsbG7d B6Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786734880; x=1787339680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tcB5rq4VZBgFk1thgYSh8cIbkfOzI14sOVjDrq4EZoo=; b=a1mbuFxca4xfbbA7OMHVvkKzyCW99bd8ggQ4xIzZTaqSdoQkgKyiUZzTIXICayZF8V vNoVkqJQbMSh1EQYx3IQ/hE6TtvES2iIcOeFHoxzqZgHr39S2RKD2+4vRI0Kq5IbyMJT kJExXKHqu60+s+qAVGW90xmGELtYG0scG29p6unz9k6hQtfJb3IQbMeLsiduHl1bwlvK LVCULDF24Qcc7KM57fCoXH4AGJVDWbnf9JzoGFLgP7+SP1WdtW8wxrWLTikaxXNpyKaP uDNCfAEgQeS4JqKtM0Dg9K/YmOCybUEp9ha2DFGb7h06vCQVHdShZmy/UXM+8sGZpyEh XPog== X-Forwarded-Encrypted: i=1; AHgh+RoNM3oObYXSI0RGaJKF5t3Xx/v5+bgRbMA9VY4fCWbNrTImO/i/Uc6E5UsoW3sGr9PqK6mykZjL/ulu6Tk=@vger.kernel.org X-Gm-Message-State: AOJu0YzmvLu5zAt6Fbfe0IZc55nC7bKLG2pShJ0b7jqm7PJcZ4eDKS3a g4Dbi5U0epw6Ght6dFk0fZ29cNscwCUMDSKbAlqlTLznI1rNdfGO4FyV X-Gm-Gg: AR+sD12LDOGhlqASnMLNTQmR+oc+gi2QeZDPKHYGHiLkFKzIlScfCL+BdjCvwOyOifW pRLbXENDVT7OQfSjPNA73EreHnbfFy2odSLyoGXhsHOPRWSKhDfFus7TSYdn2QHt7shoDzOAk97 PLO/QUGyYGMoZgymBQNXRDPNZT2SVwGSBSD7umk0SPuiKLzUY5JrK4J4O8IIJc/G0r81iwGpgdI mplzWCfcdE5EY5wBm9aYAhz/vALWU95xUIivh6b4flM86PnMf1i6RTgzCnjbqgN3V+UZ1/DGij0 ZYXJtUK8idUQtxGHwwlG3C4JoDOEt+SaBPyafryWHNnZxa/BgiAS3nSDfdAD6AM0B2pC0+ZQ32G 7ZgGXIVRXkvvGxbhZ7CCaGA74bdq08JIKaIBWeLln6scHPsEu/iGpkP/ugTt07yVy1vEDMNQMaL hzHYcjDEXe1KdCO7GHEvUvGHYCeTFZukDLdpU/O1jFEcacQ+SDK1h6oG5GFQgBm/5tqkVMqKiYJ qXF08Oo+FlVnYpMAqiLeZVa9ntR70rypE0SAo7YdftKCT304nydpEG+DsW3jeP7NXSv6gUxawOS aE4swLoI X-Received: by 2002:a17:903:2bce:b0:2d0:cc92:f7a9 with SMTP id d9443c01a7336-2d3b0aeeb33mr96710455ad.4.1786734879498; Fri, 14 Aug 2026 12:14:39 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c06:2735:bd48:a716:c86d:67a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320ead105a9sm6734865eec.31.2026.08.14.12.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 12:14:39 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Guenter Roeck , Wim Van Sebroeck , Philipp Zabel Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v3 1/3] watchdog: rzv2h_wdt: Propagate WDTDCR access errors Date: Fri, 14 Aug 2026 20:14:12 +0100 Message-ID: <20260814191415.2110732-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260814191415.2110732-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260814191415.2110732-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar The WDTDCR helpers currently access the register directly using `readl()`/`writel()` and therefore cannot report failures to their callers. WDTDCR is located in a shared syscon region and will be accessed through regmap in a subsequent change, where register accesses can fail. Make `rzt2h_wdt_wdtdcr_count_start()` and `rzt2h_wdt_wdtdcr_count_stop()` return an error so their callers can propagate failures. Handle these errors in the watchdog start, stop and restart paths and unwind resources acquired before the WDTDCR access. In particular, restore the reset and clock state and release the runtime PM reference as appropriate when an access fails. The helpers still return zero with the current `readl()`/`writel()` implementation, so this change does not alter the driver's behaviour by itself. It prepares the error handling required for the subsequent regmap conversion of WDTDCR access. Signed-off-by: Lad Prabhakar --- v2->v3: - New patch, split from v2 patch #1 to make thing easier to review. --- drivers/watchdog/rzv2h_wdt.c | 49 ++++++++++++++++++++++++++++-------- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c index 3b6abb66a1da..b770226f785e 100644 --- a/drivers/watchdog/rzv2h_wdt.c +++ b/drivers/watchdog/rzv2h_wdt.c @@ -89,18 +89,22 @@ static int rzv2h_wdt_ping(struct watchdog_device *wdev) return 0; } =20 -static void rzt2h_wdt_wdtdcr_count_stop(struct rzv2h_wdt_priv *priv) +static int rzt2h_wdt_wdtdcr_count_stop(struct rzv2h_wdt_priv *priv) { u32 reg =3D readl(priv->wdtdcr + WDTDCR); =20 writel(reg | WDTDCR_WDTSTOPCTRL, priv->wdtdcr + WDTDCR); + + return 0; } =20 -static void rzt2h_wdt_wdtdcr_count_start(struct rzv2h_wdt_priv *priv) +static int rzt2h_wdt_wdtdcr_count_start(struct rzv2h_wdt_priv *priv) { u32 reg =3D readl(priv->wdtdcr + WDTDCR); =20 writel(reg & ~WDTDCR_WDTSTOPCTRL, priv->wdtdcr + WDTDCR); + + return 0; } =20 static void rzv2h_wdt_setup(struct watchdog_device *wdev, u16 wdtcr) @@ -150,8 +154,14 @@ static int rzv2h_wdt_start(struct watchdog_device *wde= v) rzv2h_wdt_setup(wdev, of_data->cks_max | WDTCR_RPSS_100 | WDTCR_RPES_0 | of_data->tops); =20 - if (priv->of_data->wdtdcr) - rzt2h_wdt_wdtdcr_count_start(priv); + if (priv->of_data->wdtdcr) { + ret =3D rzt2h_wdt_wdtdcr_count_start(priv); + if (ret) { + reset_control_assert(priv->rstc); + pm_runtime_put(wdev->parent); + return ret; + } + } =20 /* * Down counting starts after writing the sequence 00h -> FFh to the @@ -171,8 +181,13 @@ static int rzv2h_wdt_stop(struct watchdog_device *wdev) if (ret) return ret; =20 - if (priv->of_data->wdtdcr) - rzt2h_wdt_wdtdcr_count_stop(priv); + if (priv->of_data->wdtdcr) { + ret =3D rzt2h_wdt_wdtdcr_count_stop(priv); + if (ret) { + reset_control_deassert(priv->rstc); + return ret; + } + } =20 pm_runtime_put(wdev->parent); =20 @@ -188,9 +203,10 @@ static int rzv2h_wdt_restart(struct watchdog_device *w= dev, unsigned long action, void *data) { struct rzv2h_wdt_priv *priv =3D watchdog_get_drvdata(wdev); + bool active =3D watchdog_active(wdev); int ret; =20 - if (!watchdog_active(wdev)) { + if (!active) { ret =3D clk_enable(priv->pclk); if (ret) return ret; @@ -234,8 +250,19 @@ static int rzv2h_wdt_restart(struct watchdog_device *w= dev, rzv2h_wdt_setup(wdev, priv->of_data->cks_min | WDTCR_RPSS_25 | WDTCR_RPES_75 | WDTCR_TOPS_1024); =20 - if (priv->of_data->wdtdcr) - rzt2h_wdt_wdtdcr_count_start(priv); + if (priv->of_data->wdtdcr) { + ret =3D rzt2h_wdt_wdtdcr_count_start(priv); + if (ret) { + if (!active) { + reset_control_assert(priv->rstc); + clk_disable(priv->oscclk); + clk_disable(priv->pclk); + } else { + reset_control_reset(priv->rstc); + } + return ret; + } + } =20 rzv2h_wdt_ping(wdev); =20 @@ -266,11 +293,11 @@ static int rzt2h_wdt_wdtdcr_init(struct platform_devi= ce *pdev, if (ret) return ret; =20 - rzt2h_wdt_wdtdcr_count_stop(priv); + ret =3D rzt2h_wdt_wdtdcr_count_stop(priv); =20 pm_runtime_put(&pdev->dev); =20 - return 0; + return ret; } =20 static int rzv2h_wdt_probe(struct platform_device *pdev) --=20 2.43.0 From nobody Tue Sep 29 03:55:07 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0603499F2A for ; Fri, 14 Aug 2026 19:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734886; cv=none; b=CpD1hJmRJw0o2QB8hRRqpHzyUFDZRuDHT78b5d6JRkOvhhccN+rkldjbclnQlMXHOiv8TvMC/+2PEAhmIZBRNvSWPNq+wDOxST2qfr3qSgmds+ZBfijghZjBGKZjciWJJUpEdhHd7F+NrNxSjhOvMpNvkcRFCjXTgv0w8LqhGrM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734886; c=relaxed/simple; bh=/09DTtTCMypMTcOM7Qu02qHInaA1waoebLUsozhfRFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sxA5TdfZFb0t4sipPGOoB7i6M90+CgADBkM3TS0kspOs7SqOViKGNefm61/8anksVo0kgMl19cNjDELF4RQa/gWO5n5NIalTn25Mu1gTnj7TlLLCuDrw9Lwblq4y1Aox46TEpq6M0WTunB2lqz/TYce1/jcZ3bySjV868ixrH2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HU83H7u7; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HU83H7u7" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c9eefcf9175so1220080a12.3 for ; Fri, 14 Aug 2026 12:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786734884; x=1787339684; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=99FrBqwTWX0f3PFQFTl56F/G9CXlcTrdnsEsEmu1Nq4=; b=HU83H7u7MuE3bbZSEDIsDWkckzguj6Z1PwuKV8xuCjeYeEFNPcUbBfvme9boC0WAbf J7vt4lrsBE0HbjP7Jaeb3G2HkxQV0sV/Xv8o8L1HWedARziW/dc5dAWSBcMBsSwwn1y6 RUUnsrWkOTVR4J+FFjBJkW3dHf7S23Me7TMcHJwfrXSxck/ytoL1gY2+T9w/Qv8mroe9 84IwU8mfDXOM/0QoZCk7D5FJDxKs9zHIYQFYl6f6nWP/1HaGUKLb1D042uv5H7fjtjE0 268V1AzTQKD1W00cZM7K8b23mrFoyEW8KP7xAp19hRmWJzspotBWezsePNmRJCLQ3Vpy jZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786734884; x=1787339684; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=99FrBqwTWX0f3PFQFTl56F/G9CXlcTrdnsEsEmu1Nq4=; b=JI32QGILB3uL24th/Gq/uKTBffV9nC069UZnCldoIsagb+A/eQ9q16P3lj4VKxJmLC BFnDNr5O0udYSFMbNMJArLI2Bfq23xtJjKmp1v0M0EhsIP55zWyoZms0xk/1QeykLpPc eFpUg5UdGAw17ghH5BkeaWgee/RXtHcv2vUwK17wywgFUjJXrkSEkK0a6lt6Tcny3xak 4vrStPNv4rnwyZfoaUW6qRlowBDEybwoGni+Dm4cd+8qhxX7S3FUrGNo6razpWVv51Dq XsMXeWptaCflm+ujR8wIOv4reeI9DowXizwo9v66ST6P7pfTgjmc/cv9W67jptQAheB3 Dt4w== X-Forwarded-Encrypted: i=1; AHgh+RpvQoKHDxkmj28dmPFZk5xxVJBFJ1niHgoW8hc/2XqwTzoMUP2UA/mH8zZMBtvRW/5zAY9O8WqBgG8auYo=@vger.kernel.org X-Gm-Message-State: AOJu0YymZRN4yMbKoZX9gv5Teux9eJoWWF9qBVVCqSNkTCpnnAVr/yrr piRqiczF/G/xDEaQ3muMFpAQX4jqCosBvuQxP7T1oBtlvViBDq2dQ64Svwv81w== X-Gm-Gg: AR+sD13Idqv8hsj1/5jgtP50U07+q7Oi9JnAbipYvFqES/X5gEmBmULlI70zJxRGL/J k0FfS2SVI6UuvEPjKhtAqTA+khE371LypaXfrGyfpVcItRcdxAEkyDFtAmpBS+W5kqQh6NAO1qN i/m85M3b86xh3fyN+HSC6jd1xODt/yBeLAVUCjQqdRTwu1WfBP2PhcWYSgXoriY9bZQBgW5T32b yOiX6iJPgq60trd1JPE/WfFtkxuUMZuXSH1kKhhZXeUMAzV17LBkHb4LrGkwPIXNrN4vNLAcexG BEqWaBZ8GNE38hn7csKuHL4JdRDLBwErCJ8OGjPd9aAhIaZpEVy0ILu22pQec0uavFX3Z04ISxt 6ZS1RbxBi5U49EwPfYGvmIu06dmKqTdmOcx61B3Ok0BzpyHMz7jZUoILRxQBe3x/muDtOpRbcZ3 Ui8QgrDbnR+nzg2SGgHXV9lNgQ1QRUnqSBaWTSddPyDCKjfAbeaiB3w6HeG/CmXpymcxNlMuT/e GAQaiK4AybrZhBo6rmd7t5QBKYr3GJk+ADZ2GKkD/WpYCdX6MN1AdcMubHewvAtdqKRMVqjvFaE DIWpDsKzCj98c7c5qWE= X-Received: by 2002:a05:6300:4c:b0:3c3:89ce:b5bc with SMTP id adf61e73a8af0-3cc71ac4503mr10507025637.15.1786734883803; Fri, 14 Aug 2026 12:14:43 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c06:2735:bd48:a716:c86d:67a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320ead105a9sm6734865eec.31.2026.08.14.12.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 12:14:43 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Guenter Roeck , Wim Van Sebroeck , Philipp Zabel Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v3 2/3] watchdog: rzv2h: Convert WDTDCR handling to regmap Date: Fri, 14 Aug 2026 20:14:13 +0100 Message-ID: <20260814191415.2110732-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260814191415.2110732-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260814191415.2110732-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Convert the WDTDCR register access from raw readl/writel variants over to the regmap framework using devm_regmap_init_mmio(). This conversion serves as a preparatory refactoring step. It allows the driver to subsequently support syscon-based system controllers natively by passing along alternative regmap handles without forcing messy architectural branching at runtime. Signed-off-by: Lad Prabhakar --- v2->v3: - Dropped unwinding changes to patch#1. - Set use_raw_spinlock to true in regmap config as certain watchdog operati= ons runs in an atomic panic context. --- drivers/watchdog/rzv2h_wdt.c | 37 ++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c index b770226f785e..cf28caef31e8 100644 --- a/drivers/watchdog/rzv2h_wdt.c +++ b/drivers/watchdog/rzv2h_wdt.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -67,7 +68,7 @@ struct rzv2h_of_data { =20 struct rzv2h_wdt_priv { void __iomem *base; - void __iomem *wdtdcr; + struct regmap *wdtdcr_regmap; struct clk *pclk; struct clk *oscclk; struct reset_control *rstc; @@ -91,20 +92,12 @@ static int rzv2h_wdt_ping(struct watchdog_device *wdev) =20 static int rzt2h_wdt_wdtdcr_count_stop(struct rzv2h_wdt_priv *priv) { - u32 reg =3D readl(priv->wdtdcr + WDTDCR); - - writel(reg | WDTDCR_WDTSTOPCTRL, priv->wdtdcr + WDTDCR); - - return 0; + return regmap_set_bits(priv->wdtdcr_regmap, WDTDCR, WDTDCR_WDTSTOPCTRL); } =20 static int rzt2h_wdt_wdtdcr_count_start(struct rzv2h_wdt_priv *priv) { - u32 reg =3D readl(priv->wdtdcr + WDTDCR); - - writel(reg & ~WDTDCR_WDTSTOPCTRL, priv->wdtdcr + WDTDCR); - - return 0; + return regmap_clear_bits(priv->wdtdcr_regmap, WDTDCR, WDTDCR_WDTSTOPCTRL); } =20 static void rzv2h_wdt_setup(struct watchdog_device *wdev, u16 wdtcr) @@ -280,14 +273,30 @@ static const struct watchdog_ops rzv2h_wdt_ops =3D { .restart =3D rzv2h_wdt_restart, }; =20 +static const struct regmap_config rzv2h_wdtdcr_regmap_config =3D { + .name =3D "wdtdcr", + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, + .max_register =3D WDTDCR, + .fast_io =3D true, + .use_raw_spinlock =3D true, +}; + static int rzt2h_wdt_wdtdcr_init(struct platform_device *pdev, struct rzv2h_wdt_priv *priv) { + void __iomem *wdtdcr; int ret; =20 - priv->wdtdcr =3D devm_platform_ioremap_resource(pdev, 1); - if (IS_ERR(priv->wdtdcr)) - return PTR_ERR(priv->wdtdcr); + wdtdcr =3D devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(wdtdcr)) + return PTR_ERR(wdtdcr); + + priv->wdtdcr_regmap =3D devm_regmap_init_mmio(&pdev->dev, wdtdcr, + &rzv2h_wdtdcr_regmap_config); + if (IS_ERR(priv->wdtdcr_regmap)) + return PTR_ERR(priv->wdtdcr_regmap); =20 ret =3D pm_runtime_resume_and_get(&pdev->dev); if (ret) --=20 2.43.0 From nobody Tue Sep 29 03:55:07 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E28C34A791 for ; Fri, 14 Aug 2026 19:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734890; cv=none; b=RToTtAglBkzmZTiJzycWn+d1YY1Tt5Mqpi1skEeuGjDOo74BPwsWhA8HgZ+t73WZxczKpL7zID4vgtbpMy7lirHoNCeJ+eX9D01c51jHSJK4UGzJPzuGQFXeiuo/AJz8SdkwYIPR4vimLNsCEv81aI1LmlAiYEI4UXuwmqgXLDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786734890; c=relaxed/simple; bh=Z1V63TLbOOJiZ9OWYBLhtvG8u+j5Z+qNWVfO33Rsqbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eHgUYSDaT2VL231FhxPqXtE4EbV/8+EHWYruaV7o+9be6RvEMQNoxCLKsR/nlLH+8DLGkqDI/v7xCoUfO5kVmAUseCRnveuQkTDH9KKaWgQ12tm7tMIvtpijNunYPsNeHUTDSvDEF8Ak0vyvX8YXhynvk0PDZMidEAJupgBafZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=foTh9Tw6; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="foTh9Tw6" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cf452def93so20602455ad.1 for ; Fri, 14 Aug 2026 12:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786734888; x=1787339688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ljw4i24OukbGiQJQCxBeHaTi06GYjymaKq0wZtgmu0Q=; b=foTh9Tw6FGITm44TapakljVHUFl7ily/F6IQ2hFlk731P5UIQzGVPrNZa9XC5CXRN3 Dp4MYl6dzKTx15EnB6FUhr94/HHT7QvmznUNECtOigPx84Gng11bZ8fWYlVOcJSoXTA7 LaDxlsUM9X6goUVozGHUxcnqfCVVdnt3eSbtFLnA0toEaTjBVZK+Xwpqz221F8e4K9BN R6aOfEPY0E4G500WR9nz8+aE5dQqxshAmmTkQ0s/Prhzhe7Pvs0LxmJMtJDxiPazI4Qv gbtBirf19IlPyxqyn2vS33xq8USl2Xj9wIxawTlilUU3kkn9dhChLKrDC4PAcmJwjx2p qPkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786734888; x=1787339688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ljw4i24OukbGiQJQCxBeHaTi06GYjymaKq0wZtgmu0Q=; b=Fg1Xfg9N67dQfYlG/7WUr/K75NZPkuZU76CBCaHo/I5qnaCGc6bosERm1yan2M2XsL J7n/fcGjR4uEGfM2RIF0GJFK53i3+gR9J292UaeDmfaUCoI2WwCQRO5DSn7DWy/dOT2d r8SMwLlMtKQzvC29yf3a53B5R+ZpsuPeHE38+7naP8TUyWZZguEgoYEeAC/yBviJmbOE fbzYzUQ4wtLRfKNxT1a9SIVLPeNoQmKeIsxE9WziCYuktgNvS6MxvstN1MDTDcto0yil ovOJ1Qx8YRwbh2Teh0xTGIo4HQwJl49XsycRHZy4EpR04oHJHn8x7NlyhRk4KdryqHSl p4EA== X-Forwarded-Encrypted: i=1; AHgh+Roiv1R/UeM01EwYZ/1YPvVnQJ5tnCyDvMsh3HmrcQ+8uMvNcrsVmd0ivRdUC6VIw/M3tQzo5tfzVP8STqA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw86MUnfQp+WiOfsY5D5R4HuH9HPT0OlDZEpXtZ3112r/yn8cQP AFwz8AVjwFuxEUHoJ32Ts/oCnj281op/yoGDYQfoHpscnH5/ez7L0sC2 X-Gm-Gg: AR+sD12UKBM7J+DC/dyCPk9t2kUB12GR+a23g9AMYgmdMj2SZCq+08BEu98vLJfaevW K9Cv5XCRALeneN62qtmUDlA3cQ5VS8H60zg6I4NDNJStuRcS7fHPIWQxsJc4yBBdgwH/Wo9V0Yy bEjJj5esVtfxXWkN39WwqqCmGfjJ3KMtDjrj4yDAyjSoLVZdmVLcXvrTVktixQFtMpjszdZLZsX P0lM78rXGmt4spBtNhkcbdKYPW7xlhnr2WpHsf+ftRZLQ5tgdPAUEMgJr+N+GhYBs0fScet+Q8P BFNTomjX5aNC/Usy7xIK9wH+TeFYIHzh2z0P4qKyGmbqVA7hkYno1TOfQq2FK53oDuSlDJGrc73 Y+QPW6biADn4NQhRD51iAcCkNc9JSJjL7AcmAB4iTI370r0m1oytSxAv3wyzC4kvxpJXsKyrtZU ybcIH3GSjlOiZY6CbLGKx11334NN0cvTIbFmOgKs/rTi5SoTDO895+DCNlrPb7nV1usbZVwYLWZ XU0s0FkviQgF6ahOA+8zD8lA62cYR0v6jk3RFrxec9mJKstEJ8OanVtmsr5H73l+xoCzSv5+yT0 8zCEL8/X X-Received: by 2002:a17:903:1a0d:b0:2d2:72b6:556b with SMTP id d9443c01a7336-2d37f7b7ca7mr177972955ad.13.1786734888228; Fri, 14 Aug 2026 12:14:48 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c06:2735:bd48:a716:c86d:67a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320ead105a9sm6734865eec.31.2026.08.14.12.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 12:14:47 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Guenter Roeck , Wim Van Sebroeck , Philipp Zabel Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v3 3/3] watchdog: rzv2h: Drop WDTRCR_RSTIRQS define Date: Fri, 14 Aug 2026 20:14:14 +0100 Message-ID: <20260814191415.2110732-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260814191415.2110732-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260814191415.2110732-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar WDTRCR_RSTIRQS is unused, so drop it. Signed-off-by: Lad Prabhakar --- v2->v3: - Updated commit message to reflect the change in v3. --- drivers/watchdog/rzv2h_wdt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c index cf28caef31e8..8af2f33b5680 100644 --- a/drivers/watchdog/rzv2h_wdt.c +++ b/drivers/watchdog/rzv2h_wdt.c @@ -40,8 +40,6 @@ #define WDTCR_RPSS_25 0x00 #define WDTCR_RPSS_100 0x3000 =20 -#define WDTRCR_RSTIRQS BIT(7) - #define WDTDCR_WDTSTOPCTRL BIT(0) =20 #define WDT_DEFAULT_TIMEOUT 60U --=20 2.43.0