From nobody Fri Aug 14 15:49:21 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1A947606B for ; Fri, 14 Aug 2026 13:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714873; cv=none; b=U9A74sL+W8grb/iM2sQxkLVMydJyGqq3qxIVpU1lTChVTpa+rbjmrkvaa/iARc26gn3L5ag3jcbQnQ9CbHY+/c8Qr7vFbopou7fqy7aUCcrrZ6beyGxswQRACY5PX8oWmy1lPRGLwZCNPbgwuwBIxAKqs/fFl7W/mM7xx/4Syow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714873; c=relaxed/simple; bh=Zs3qq8nZ9iq/Ua310mm7kdVlhyBdkLgBtMEYQXg0wmE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qwa6t7/71QANrjp850TdWS0zpk54UZSna9jQYBrhmOmBkh66uj2fNjiOM8Jp2MRXy/P7IBo7alXouTD0u0LdwoiZ1CmBfykQzLZqLJA2j49bWECaYOJIbx4d3ohyIT1BsqmyLJdPxCdc9UIOAjeHEY6BubLmU5KsmBdts3LpGUs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XaHlH57S; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XaHlH57S" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cf452def93so17440985ad.1 for ; Fri, 14 Aug 2026 06:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786714871; x=1787319671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=AbuKvj4W+YXhwTeR+EPxopLpAn5mAXQN8Q4JWVhztYQ=; b=XaHlH57SqJTTv/+9LFXpLF9xoyvU0aQVBaoJaMYz5U+tX+jwgS1ftM/qs93+wBPydu DtCZmPm4EewXBPLLh1KbcC64trylSx9O05j5dFWOVh7gx6tDSZUezkzO0lQcBaQ2YV8r JbGlR6b3yPFf+laLAzV6xa4lNbZMFQ0W9+OmdkD/QalFnEAt+0tneisK0SgCvIUKhR0+ I6LIcDt6hsIftcozTaSCQB200JVM0yGTeETNp2URnubZFM3w/UgObs/kJX2lbGZrJhLv Tj5OirFX3LOj3aXLVDo5ffARLNIJeGMdXIZwtQFz5gvoDOHOD9veUJ96sGHHrlsifT6k XALA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786714871; x=1787319671; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AbuKvj4W+YXhwTeR+EPxopLpAn5mAXQN8Q4JWVhztYQ=; b=I1okwmvFxNQVlhAsHf7L0wlfY6SMFYBj8m7oVFrFwyIXc3Moub4EfpU/vqdQ+QEZGE bM0o8fX7hz3sVbGNJTXypQuznr45f8guQJiqgvXoyyh4AfPQEaPaH5dkI8SaSVK22wqo AscuhK7oy1U7fyb2x3E3WJAGfcFTtUJrwdgHbQlorchQmG/O6f8Y/U2eCOweFWdifI3V qnF4VlQ0MzyyDO86bOb37nFeeqFlgZ6D2O4tb7CF1whOAhq7Zx+xtkVsMvU3WGactzYA FnFvU2dAuAgW72dBB23QzmJ0uMBOM4ObTjS+mkZQhVex58ja4JVcv9jDCptPJTed8ixa vexQ== X-Forwarded-Encrypted: i=1; AHgh+Rp5jTGEKNsATjB25eCL3mmrwWuMtRaxY6jQ46kXzNvm1kqxk7Z878R8sDHKPcr4XD94LRNwjv0nzb7dgFU=@vger.kernel.org X-Gm-Message-State: AOJu0YzCxLbbkYKgC0HGBNMGJKIRvsGbt6NEsPH33IoIV+gf3mH/YB0n +A/V2PUOixLfzmyygpt64eYP1KqV3OWBPXgMEFUOljKKpHrCf0U9mmZ8 X-Gm-Gg: AR+sD10NWH1YGY0TIcnmeB9KGyHDPQyj6E5gQgR/z3p3DbqRbZKES/bU7u/ZKyGVIk7 oMl7FlTZsRo/UJDIbwEMBjuaUAHRYu111Q/bjIISBbOLw/SjXaohfvU7Dp1xIJeHVs9cAdW+lqy C/yTF58dgVZnE2xfbr6XqMkjpZYoN2G6gE0yxjBRSPdWxqNtW4xAeAL/Plyu94DNV5jVrNorEQa PfA9AHGtF2lIyDtpWQZJYr4jjnnXdQEWFjCmDKUUJ9smuxPWDPCLQjnAGURXeWr4qgmMTmj1qze uwti4ON4SeefwLZGYoMcvi/R6EEhw/NRMEuexHJUVlIyOLL8CufPfgxyXa0horH7uFwGKfFIeuv lhbi0bBkz0zkY8sj/3EZ29YS01gCcGjf9mNSl3N7XEtUaJot8DXsdthjVnx6x9IcQJlrZ08GAVa Q+ZS/eboUv36an1pAEw1uE2xDnZzITW+MsXMZ39Kr/x5RM25Sja5yZvEkf+UTc5XxmTxM/lDd04 brArDUe X-Received: by 2002:a17:903:22cb:b0:2ca:53f7:3c69 with SMTP id d9443c01a7336-2d37f72fad4mr143515685ad.9.1786714871119; Fri, 14 Aug 2026 06:41:11 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:e9af:7c0e:be31:2c3f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d3aebf1ba7sm9810265ad.78.2026.08.14.06.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 06:41:10 -0700 (PDT) From: Ruoyu Wang To: Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Jacopo Mondi , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] media: adv748x: Fix endpoint reference leaks on probe failure Date: Fri, 14 Aug 2026 21:41:06 +0800 Message-ID: <20260814134106.1387486-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" adv748x_parse_dt() takes an extra reference for every endpoint saved in state->endpoints. If parsing later fails, adv748x_probe() skips adv748x_dt_cleanup(), so the saved references remain held. A CSI-2 lane parsing error also returns from for_each_endpoint_of_node() without dropping the iterator's reference. Drop the iterator reference before returning a lane parsing error and route all parse failures through the endpoint cleanup path. This balances both reference classes while retaining the endpoints for a successful probe. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes desc= ribed in device tree") Fixes: eccf442ce156 ("media: i2c: adv748x: Support probing a single output") Signed-off-by: Ruoyu Wang --- drivers/media/i2c/adv748x/adv748x-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/a= dv748x/adv748x-core.c index 3eb6d5e8f0826..010a4c55b4002 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -689,8 +689,10 @@ static int adv748x_parse_dt(struct adv748x_state *stat= e) =20 /* Store number of CSI-2 lanes used for TXA and TXB. */ ret =3D adv748x_parse_csi2_lanes(state, ep.port, ep_np); - if (ret) + if (ret) { + of_node_put(ep_np); return ret; + } } =20 return in_found && out_found ? 0 : -ENODEV; @@ -739,7 +741,7 @@ static int adv748x_probe(struct i2c_client *client) ret =3D adv748x_parse_dt(state); if (ret) { adv_err(state, "Failed to parse device tree"); - goto err_free_mutex; + goto err_cleanup_dt; } =20 /* Configure IO Regmap region */ @@ -809,7 +811,6 @@ static int adv748x_probe(struct i2c_client *client) adv748x_unregister_clients(state); err_cleanup_dt: adv748x_dt_cleanup(state); -err_free_mutex: mutex_destroy(&state->mutex); =20 return ret; --=20 2.51.0