From nobody Fri Aug 14 15:49:20 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA6F94756B2 for ; Fri, 14 Aug 2026 13:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714842; cv=none; b=qhnZCFpANiHtm7mnOM35PmPXntx52LSmq6Jw8rFU8bpSlt+9GuHph0Jm/hLoBnU/3UKpWYG6boIuCr3ZWOEw7Hp4i0v6kwDlDD6MmY0dv1oweuWiDxbY2URcDxMt4RPoN/b4upn0nq5CJ+2H+Zyqfj8ZHWJ5ixtPW6n5ch19dIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714842; c=relaxed/simple; bh=ZFcWIVAF5GwsG/s4LdZRYp+ubN6mNHhGokZn49msOb0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UV/Tfw29U1dF8aA3YydPAOrrY3d+eQ8x9gp+k/+1KMD15OKxKY9MMUSz3Tf67xtJcmYbfpobUxvIIkpRzGr9CxQlh3JnjEChjDiTRhs+hgEqnz87LUSjVONOMiE/5oD7YOS4aeEpJbub9uFtVyiXM1VKdLV/Kimd6p7IJS1S1j8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iLpgpsDm; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iLpgpsDm" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2d530328efbso3028025ad.0 for ; Fri, 14 Aug 2026 06:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786714840; x=1787319640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=OUSt8iKsvLES1DoWZPe2NRZJAWICuOCKAgFaBxq4B1Q=; b=iLpgpsDmmHH/0UEm0F6qf9XUEO2XnvWLU2/Wxi315LxaQGFtbQ/tQXBr6hDmkZRcBh uz1MDe2zo24xk2wVx3CNnPkwLJP0uS2uWdK4ep0AbjVClkfIr+pRNccAIV1sb7E57yET 85K7gI8uWiVuOd43YYD4cHx7AOTQztkJ6UY8+KN7LqTnoenm7/Ccad7pjycS0wgD/HJ2 7D95e0KqHDkR5NYn74fl2NRpqyMw7UUeWupgZFZRypdpm4ub/ZGHQ+Wi+U57vzXEDzuI giXEdFbVPJyvCVo0N3i6fNRA2fK9jNA4IUMc7oX0GyWf+v5Jsavn+sGCk7ur9ivhQ0uX yMjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786714840; x=1787319640; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OUSt8iKsvLES1DoWZPe2NRZJAWICuOCKAgFaBxq4B1Q=; b=Sa5F1wApkrqGFOosh5LQqvwMPxOdfRg2Map7u4CC6jklXZgPEROatTADMfa6vzPnxu P0SQUyxyfMclhaFaHdrJTMriPlOYLlV0ABuCQjRVbjIjYDcLvj7pxA6h8aOvnL+QTozo oKNPyW7UTqlif29kIYq4tPe03dXPtRXjxu2FpAOImg45pAx+qu3v3NIiygbPw5gJGys8 da+91QnTWEMOQmncRLjEa0wtuF9Uu6Aqxdw0NoavTZj5iyUkoobt/A4gLUasZm2Ou4vq X6Ln5kF2YcOfWMYspNryJebbChV5hbyZOM0fYt7hplEbBkrjcgq7gbhVck5Ek+GLEHbs Vt9A== X-Forwarded-Encrypted: i=1; AHgh+RrXrHv8S/e+l0nnV6JK7DrcjDBHJpL6CcghrmoYJGLM/26Cc+WX+bI0HVsJXB953trS6wl8daYKgJFxS+E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8LCmeFOfOFuXiTjxAvjX/Mw8SvJufZREUhXp53WPQDYFMev8v qDYymRROPkg0YdDAdOB3Bgcf7ZdDEHqBRPbDxqhzf9mqgX6X3rfjWzu7 X-Gm-Gg: AR+sD13ICdkeKg5pefyj/+EjHDbeGmWnG90Am465crnrTQTr8OOaUWzgExHFKg9zDq+ 9KJgKhkjmWAPDTRjeem9bqGNKPlAOEijlMX/ig0+Ch6iyv//j3xBqpKELFvV0VYSLrvoUaMiCfz cqx1RbPYMxV3KhcZH1em8EqpEH6ruUjCFXn2Lz91nnu6Jx3xKJ5jn4dON0i7433b8MtyuTsOIx1 4trT0tD54OlL6pk3USrelBXd7qw+FFOjmYH3IjKE887kSkt8v/T6Bi0Lfe76ylqSTB80fSKBBu2 TI0vi/BrK0+lompBXeCyCExwM+HofKeJ7cQNoveaWppGWCRgJEF98QXsBUH8uSq6XZwCr5wm+KI B9udUO5x0W8Iq7xYo1sWnHaCy+kv6pDzFF7lmXY9nB2M7FoAoCBCBiJj/XXF5N0zR4bFS+/D3T4 7WxBYjephqmOUKfztvR6GygXRkiijVxzJPuuzhyHSxACFA8lbCt/zL7VrFPTlA7uem1Zt/ir2xl bSNMR/7 X-Received: by 2002:a17:902:da92:b0:2cf:9f0b:b562 with SMTP id d9443c01a7336-2d3b0cf922amr67711065ad.22.1786714839447; Fri, 14 Aug 2026 06:40:39 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:e9af:7c0e:be31:2c3f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d3aeb2a085sm9837125ad.42.2026.08.14.06.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 06:40:39 -0700 (PDT) From: Ruoyu Wang To: Andi Shyti , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Marek Vasut , Wolfram Sang Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] i2c: mxs: fix DMA channel leak on probe error Date: Fri, 14 Aug 2026 21:40:33 +0800 Message-ID: <20260814134033.1386874-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dma_request_chan() grants the driver exclusive use of the channel until dma_release_channel() is called. If controller reset or I2C adapter registration fails after the request, mxs_i2c_probe() returns without releasing it. The failed probe does not invoke mxs_i2c_remove(), so the channel remains allocated and can prevent a later probe from acquiring it. Release the DMA channel on both post-request error paths. Keep the adapter-registration unwind ordered after the existing controller reset. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 62885f59a261 ("MXS: Implement DMA support into mxs-i2c") Signed-off-by: Ruoyu Wang --- drivers/i2c/busses/i2c-mxs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c index 4e07babea9c3f..a5c8b44ec8142 100644 --- a/drivers/i2c/busses/i2c-mxs.c +++ b/drivers/i2c/busses/i2c-mxs.c @@ -849,8 +849,10 @@ static int mxs_i2c_probe(struct platform_device *pdev) =20 /* Do reset to enforce correct startup after pinmuxing */ err =3D mxs_i2c_reset(i2c); - if (err) + if (err) { + dma_release_channel(i2c->dmach); return err; + } =20 adap =3D &i2c->adapter; strscpy(adap->name, "MXS I2C adapter", sizeof(adap->name)); @@ -865,6 +867,7 @@ static int mxs_i2c_probe(struct platform_device *pdev) if (err) { writel(MXS_I2C_CTRL0_SFTRST, i2c->regs + MXS_I2C_CTRL0_SET); + dma_release_channel(i2c->dmach); return err; } =20 --=20 2.51.0