From nobody Fri Aug 14 15:49:50 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A9244734CC for ; Fri, 14 Aug 2026 13:39:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714793; cv=none; b=a88ntvCVyNhgYLJZPHbrjLLSvGjfxJrEVyv3ERpwSDl6La76QeV2KYsu7iuiHgZS05rHns5SMenJ6+PIcp/3IuhffyH5+KQoH0d5YT7k7l6A3D6gYn35uiRlHBdv4VbWJwDVD5nYoPPtRa9j8MGMPsubS+tDuGNK86n9yEtLkZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714793; c=relaxed/simple; bh=B3gfuhws0pYqc23JndJcKaw6kIoIG0lBlkwgZJQREMc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dquEordYLqscmZYw8WYtWimyO6jZ+bBZ6fhjfoQYDTLYVrU7Y7Hk0f3ErhIuX/5Dk5gMVSZXu194Tm/mo61qn4WkPPLxu/ua0oa2EABKMvyBbehj2apnO4YMiGeMoftSeMjKKCuL9rklxmaL4VFFUZK+j6p48+iMQT4+2U6cg+k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I1a7f1/D; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I1a7f1/D" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so965079a91.2 for ; Fri, 14 Aug 2026 06:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786714791; x=1787319591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Eai7N6LQSKOAhn2kwlaYr6G2ZcZC8xtYeQrNIjwdpvo=; b=I1a7f1/DJ83uLgTMpJnlYc/PSkkVWqSZQUoPD4abmC7R+Ma1Wvy4s7Vmn8/YfEyA/c teV/Up5F8dYAj3NjgX4bV2+KIkDF/1n4jvZ8WkSgGEJqf3xzRGERkKeD6pG2KgkVjkHg cQzAL8x6qKAwf/jE7C3JBgrKf7iUE7N7D7U4fGoTaE0xazAS+L4fOX32VX6jSeg7Y82H Jkh/sxRZTV46E+nfW2yJrJpPVP0FNigT9zHK2RDrLXz8wEXAnUExwTV9E5s5Icj+d0rJ ycNppddIlJEVtI1nU/OeB2f6HpK8ZGK4uHQNWvbVr6HkjQLE0r9K/CsXJzZr57UTxyHM 9XFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786714792; x=1787319592; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Eai7N6LQSKOAhn2kwlaYr6G2ZcZC8xtYeQrNIjwdpvo=; b=C6pjH8s4jGCT4yTCF91Duj0zfshC6zYrc1w7m4EiJg+RvhLumNmGovQgsN6Xn6huCE y9vq36zQFpGUG+d+mlOKCm0li54fEvL1wLeffmVieFBMnUAeiLhcCemuDAbfFnAqTewU BIk/RgtZ+TlOG28MiYQlJYXGvdOg+WO74Kxa1I+gxOZkxiI5VmrIV9Aqx2PKD061BTuQ 0P4FQftKmIWdifoXME1nrEj3rhtQR+s8iYdlzBrf+kUv+kKGzDp4rnzqFtCq47aoc4kK sXlSkZAJ2zATJYuA2Oi+bXfhyuyRR5/L3O8ydHNjow1STDBTAovmDWcJ3CioGZcO2CkC avkA== X-Gm-Message-State: AOJu0YyjyjTBBfUjTxzJSfcRlAAKQ6xHCqz5y9i/7I0fnHbWOL5Mp9c0 jFrS+EQStmIj7OHejgGGSr3nHxtjFzz8ma+sFu1frqji6w/MJFql+R6z X-Gm-Gg: AR+sD10BpENX5dntHQMYYdNnust8MfrLa6uSV7IC1TicWhr5gGAcgOoGNvkNWU+fZ9l UCoHlMHJbN6WflQBerCmH2GX+9Fdc2tQfjHnpb+S+LxHaeLc6fMK266IcKlJM1CqgTyeUeSifBg LkX8TkKQUfHRwneQebVfeKGkvUNmoJub46yFmnIVSsRLVsNyQ/cJ0p6EPfxJDbAU05ZeEwgXiF2 RQDZJoilyZNAO0njmVjeyus2J/ZM6y0wSu6pJYO3H1xH1IjHE2GP76tkWcppg/fqkfKtCpoJ/95 3ONg0WSb2MKfj3i0IluC6mD5BOr4gNowGY/qLtjHhPa8jIdPHHyYsNLuL5vsdEKcGL7BeyVK9OH mmUUSxF4Dme48SHlyhxc19v7xRtg6W+xLxZPFG1oMhpOisTu9dWLP45RUCaSw7m4HNbQgi6WUj7 k4LdRXx4qniZI4K+2+KWWA5jUnVYlUlNWwbOo95/72ksle6BfGHiJtP5cBre2xzr3ovAZGf1bTa fRT7aCvizq832Lev2nM X-Received: by 2002:a17:90a:e7c8:b0:38d:adae:4866 with SMTP id 98e67ed59e1d1-3933bd2066dmr5807532a91.21.1786714791509; Fri, 14 Aug 2026 06:39:51 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:e9af:7c0e:be31:2c3f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-394eb752fd7sm2946040a91.13.2026.08.14.06.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 06:39:51 -0700 (PDT) From: Ruoyu Wang To: Eric Piel , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Samu Onkalo Cc: linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] misc: lis3lv02d: Handle click source read errors Date: Fri, 14 Aug 2026 21:39:46 +0800 Message-ID: <20260814133946.1386063-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The threaded click handler ignores the status returned when reading CLICK_SRC. With the SPI transport, spi_w8r8() can fail without storing anything in the output byte. The handler then tests an uninitialized click_src and can report spurious axis button events. Check the read status and skip the event when CLICK_SRC cannot be fetched. Exit through the common unlock path so successful event handling and mutex coverage remain unchanged. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 6d94d4081048 ("lis3: interrupt handlers for 8bit wakeup and click ev= ents") Signed-off-by: Ruoyu Wang --- drivers/misc/lis3lv02d/lis3lv02d.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/li= s3lv02d.c index 21e8ad0a74442..450a0bf15bdcd 100644 --- a/drivers/misc/lis3lv02d/lis3lv02d.c +++ b/drivers/misc/lis3lv02d/lis3lv02d.c @@ -511,7 +511,8 @@ static void lis302dl_interrupt_handle_click(struct lis3= lv02d *lis3) u8 click_src; =20 mutex_lock(&lis3->mutex); - lis3->read(lis3, CLICK_SRC, &click_src); + if (lis3->read(lis3, CLICK_SRC, &click_src) < 0) + goto out; =20 if (click_src & CLICK_SINGLE_X) { input_report_key(dev, lis3->mapped_btns[0], 1); @@ -528,6 +529,7 @@ static void lis302dl_interrupt_handle_click(struct lis3= lv02d *lis3) input_report_key(dev, lis3->mapped_btns[2], 0); } input_sync(dev); +out: mutex_unlock(&lis3->mutex); } =20 --=20 2.51.0