From nobody Fri Aug 14 15:49:49 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32625459AF4 for ; Fri, 14 Aug 2026 13:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714780; cv=none; b=VcofK5GqjTZlLvaFG72l7FL+hLvTnyJIdkJDRoL0q5vpk8dTuXAkcbQSJ2JPqQenTjQ50Xw72EO77UAE5uANwaDn5MjVx/Ox5JFnDmay+W+9oUps4s2w1UBGrojxT8c2EQPHikgv7F1ElmK7eCDbFf5GgIljeJvEFLZKbBw5PtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714780; c=relaxed/simple; bh=s6stw3qekj32gPO2Cbo5W9gIsKVEW343T7LTAMhAC2c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WJqC4lb34FGjnlV0+tJW3w0pVVpOK1/usb5WbafUuY3c3xRW8Q0VjrzBW7RUicuSW/BSrYGuzh/tygkjqE20f8NCoJvcyPpu82HPKQ/Q0WVhKq56ObGsCeA/3nBumKx9YJ/Fr1QXI8btl54VECVoqMC+gUrUUdGvjPImv4J2hJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hk2MVYQc; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hk2MVYQc" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso616196a12.2 for ; Fri, 14 Aug 2026 06:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786714778; x=1787319578; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=q56pSemoPlmRoOMF/Kg5BWEkXRAm+Wr9UjJACPvLbeo=; b=hk2MVYQc1l9bofdSGVqrnTxtOQG71zqNPgu9sWrh+km7bZ/RkwM5/Q0fay/zq6l4Qo EVCyaRb6vc8k4IqbUNiu7ZyqG2459uKGiyaU6HJip8G2Rh2Z9M45UeH/uN0keKwVo4Lf ZQkdKcoeQQCBwNq24KKcegvrNMO9Is9ApqcQUN/2owe+wS3+BDKzY2Vqw067KUZeFzm6 9DXrH7ytcBmypWqHrtK3JhLDU0FE33SLB+jZybs7rodHC0aZdGyX5U7qcaXY1FcM7ARJ 88ZBn4EHa7nQ/jwdzwKx+kk1NrzFsLzyaTZcRuT41cyh5JFWn+8x5b1w42SGcIBbkSdY j0dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786714778; x=1787319578; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q56pSemoPlmRoOMF/Kg5BWEkXRAm+Wr9UjJACPvLbeo=; b=QArjXK1KH6qT5pEqpaxIcPiSwpG3cD2IAV62I0sHKbrgjMu94FZWPXG4K5+mtJJlpU PvX3XBwEU/EodQzDxdeQNJ0FCPNgTLkDpy/vUs3vMRRZQb+2/qgwNCBL4dagORAByTFR cmBrW/SMzlaiwysk3I0aB7Mxz7p6Q5jB7/pHmiVvGi9NAAnStztHlxq/U436OpmjM7xQ /Ct4aNbkt6fKP3X5KP+CQvgfelZ81lXuAtXI/Ta66/A3p98J72GEjPRNfh0ccAfWZEXF DPg272soE5PLLUmCsCtPQDdjnLZ9N2ob3gL+bh5zvWxCmbuLlizyxOvBHvkwKpHkpFDR OcTg== X-Forwarded-Encrypted: i=1; AHgh+Rrwh+qMPiVJjba1phpucPcfcyJgG6n0bgNof2ItJyplOW+ewhJ/M4eYODaGwoC395QhZ9Pms3obJO6Z+C8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/RTh3+LAHFWlt5PuRFf/FlvRIvnUD7fvJuLne/hBl9O9YlQnR fOdfiWANyXpeS7xaDww/RcwTrD/+WyUjs295kkBloyg8vJN3I3KvunSw X-Gm-Gg: AR+sD107WX2Ij9SZs89tz43Eftu/tiJRgYHWVTt5okg2cCw4tQWymSIvwA9cMzZTIK3 3R2QDRnmtfyH32rI41xK/Vpme/aVNtwk4pYTrWvt0ecGrJ2wiAEKmr0Ppd72Q3zTm3U5Kf8aDiy cQb2sQjgcXXjcferBDx12oZ49e3bG1dzHop8SXVnP/cBUe9RvL63tVXKDq7OiKl52VJCpx5Rc5U 1cPYRO8UwLGXS9B/0HPVlbLDYFVeZeqWANlA7zFVrGqgqEC7aI667K5hgieHPNTZLYBKlTMnJCN CZwNrZ07+SpxbxfKMlr3sih6D0U4VaP3uSCUz7FNNuoW1R/qLV/+Y0FmcsILDavQlUxOkaZ3Pr8 Uk9um4nOLXdeB8KVBqigR0mE6g55WzLOqB6XNmMf8dM+NzNqN8UAro221Hjv038+BPK7nB+R4nU UrqyG+yDEFUtuMDmEvTr+DIY3YReCLMOpAZV14tB11KShns7Q8q4QTq/SASXyDkR3HCFOslebQr xN98Mx6 X-Received: by 2002:a05:6a21:3281:b0:3cc:56be:a559 with SMTP id adf61e73a8af0-3cc71fa8c5dmr5670551637.23.1786714778197; Fri, 14 Aug 2026 06:39:38 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:e9af:7c0e:be31:2c3f]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc08f388bf9sm608922a12.5.2026.08.14.06.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 06:39:37 -0700 (PDT) From: Ruoyu Wang To: Hadar Gat , Olivia Mackall , Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] hwrng: cctrng - Fix runtime PM usage counter leak Date: Fri, 14 Aug 2026 21:39:33 +0800 Message-ID: <20260814133933.1385764-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pm_runtime_get_sync() increments the device usage counter even when runtime resume fails. cctrng_read() propagates errors from cc_trng_pm_get() without scheduling the work that later drops the counter, so a clock or reset-completion failure in cctrng_resume() leaves the counter elevated. Use pm_runtime_resume_and_get(), which drops the usage counter when resume fails and returns zero on success. This preserves the existing success path while balancing the error path. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver") Signed-off-by: Ruoyu Wang --- drivers/char/hw_random/cctrng.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrn= g.c index a5be9258037f8..41c338a768ce9 100644 --- a/drivers/char/hw_random/cctrng.c +++ b/drivers/char/hw_random/cctrng.c @@ -86,12 +86,7 @@ static inline u32 cc_ioread(struct cctrng_drvdata *drvda= ta, u32 reg) =20 static int cc_trng_pm_get(struct device *dev) { - int rc =3D 0; - - rc =3D pm_runtime_get_sync(dev); - - /* pm_runtime_get_sync() can return 1 as a valid return code */ - return (rc =3D=3D 1 ? 0 : rc); + return pm_runtime_resume_and_get(dev); } =20 static void cc_trng_pm_put_suspend(struct device *dev) --=20 2.51.0