From nobody Fri Aug 14 15:50:39 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E6C7459AF4 for ; Fri, 14 Aug 2026 13:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714774; cv=none; b=L7OV433fAg+bujaB02U3E45Q86rYl5yMwyyBb61t11A7WnbSbPWwUVR+PAG8UzYwwfeXjPjqvTpZ6nCkvLhvSV+PDmG0gG9VInNB7phHFf5CUgiBzCe1lBsiSZKFiMKwQbG/zP0eQgjScirkwCRgio0RKUexIV12mig2TPzG0Dw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786714774; c=relaxed/simple; bh=lInajHjkw4Q8LcDb/Gghh8m3vt/7wxvz8fOnYTKBJHs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e1DyH5qGfWhzu83RbmbKX5dqE2Z21bS5xbkAdCJvu7I5q2ejqnVm/V2Mi4mbvIBLcXaK1p9A/3UhKoj/bMgQeo7mQvbwt/R3WQAo+HP9mduhextQB11rXEOZrVK36I5Db5sS43jZUHWT4hGHzqOYP6qt3W+qq36h5AB1hD1Jl+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C71W79fL; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C71W79fL" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so964591a91.2 for ; Fri, 14 Aug 2026 06:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786714773; x=1787319573; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=si0qdL0+WRVmcaDS3m3V+/d5WwTk85WNRswe6KdeyhE=; b=C71W79fLDG5CcAEAk0qPMNyjAIwaFSB7CqwyhXTcp8jHtKrr1IbFtB5Msmvxe9ZJIc /AZS+9VPb4Ma/bE/Fk9JzpKMdgXUJ6IGSe3zx+wORlTFq/4J5CRm8FPjkdkocF1dtnTA 6gQrbx71mAoi8t27CO/txASCp3dE4nyOcB6EohWFEjJL5BJesPjfzk9yBVkeD5JeE3Tu VU+v29Xa3tXebr277ugXGyfV9fiE2kqpz2GQ3bL0g6OlPegLZWTLpUvWLGXt9LnrfT5w g82mE9/1Ns8iya0llyq8ZlbxWAE5/14ZEe4Icv+2WxHZnOygrE0NMnItl3o5suQGD9k3 IA1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786714773; x=1787319573; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=si0qdL0+WRVmcaDS3m3V+/d5WwTk85WNRswe6KdeyhE=; b=BEWSjxHhaU1jMlOd8ZrG4UTCJJum0o5huTEb2DNUZ3Bs8ufsdeBSWs8KIe7ax15xaS tEpo+PgwAFOIA+JhxmS/9kddzSPXOM/ekeycldoSHxnQn/LWkQnJccgSHq9KVCVONSEQ 45XIRCzgexIavpERU3SBSVIjGtBfOqYO6zl52El+p9H3BrMIG54NDT9DXJbWqm2CX3g/ JdYsX7O/QXvbESXQGGshdfE4EKE7556jDe4K/oXo87j5C5NlUbe9/Rw3YkgpRgh5pNy0 iQxftRXR0xs3vebKQ4cxGWee4obg60sm2neJy4yDNmrmVccmgoGqEJ7gmFZGxJEgkd8S H+lw== X-Forwarded-Encrypted: i=1; AHgh+RpjjaaPzbc6AQqFKTPWwF+VMND22pPWq5+7Da2UjM0DSaQA5ebjKmHrpRt8q7xRxbO6SWQCU9zvXQYj1uk=@vger.kernel.org X-Gm-Message-State: AOJu0YzM729qQJH/qBtfkkAAvrNLHQfzuEls+zIuDRPrWPL3al4YxP/a JkvaPukaolJxeqKTSELQXmuzsGtG0ELjJSI5vsChlH38u1Qf50mLoq+Y X-Gm-Gg: AR+sD1042fxMJSimmGeTOpmiYnayNKhDHVC9lkthpVtCch90GLa6zRWav444XWB+u0A jQXMgjeI4X09vzUN22PXXNeQuGo0GC+BJOFRj8fY1FKJolRYj1CDG4A76k9xO/hEfbZ9qlBZxRy PrLLMozjZOucRRr5HslVjBdZ681iQuCLXkSqA+xrU7xVxmpey8lpeJRLWCzdp2ferieJsuJcGYT woiPdS09PLYfxXOvopBVDiL/DUqqTt5odrJHGaFnOn1S9tIUjRTfQP04hjNruO3pM5y0zRK9EEh fDtvh2e2wbDDqTRXBRDeXsD0PpkEGhbXnejmPPf9NlWI+cDGbFSuU5m1cW7xGqkPBG/Qb9fwR+K xKqJOQbvvpjRpyEJZenIgW6bERi8HkOcv/1k9pIhYQ9MtL+Ip9PAdvsACrP3H+mB52usMhbMSae A0Gyf9X0ONJSp/P5jFmK/BGZ3DJ2e8OdMWNXrpHxKiHwAKWWg+/MFX3Plz4Uh5hHjYroeyeviMx thEnwrO X-Received: by 2002:a17:90b:448c:b0:38e:6dd:a9ad with SMTP id 98e67ed59e1d1-3933b52354emr5655567a91.0.1786714772510; Fri, 14 Aug 2026 06:39:32 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:e9af:7c0e:be31:2c3f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-394eaca8e4fsm2767080a91.12.2026.08.14.06.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 06:39:32 -0700 (PDT) From: Ruoyu Wang To: Shuai Xue , Jing Zhang , Will Deacon , Mark Rutland , Yunhui Cui Cc: linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] perf/dwc_pcie: Fix PCI device reference leak in probe Date: Fri, 14 Aug 2026 21:39:25 +0800 Message-ID: <20260814133925.1385687-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pci_get_domain_bus_and_slot() returns a referenced PCI device. When the subsequent RAS DES capability lookup fails, dwc_pcie_pmu_probe() returns -ENODEV without releasing that reference. Repeated failed probes can therefore keep the PCI device allocated after removal. Move the existing pci_dev_put() immediately after capability discovery so the temporary lookup reference is released on both success and failure paths. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 7f35b429802a ("perf/dwc_pcie: fix duplicate pci_dev devices") Signed-off-by: Ruoyu Wang --- drivers/perf/dwc_pcie_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c index 5385401fa9cf6..baa736fd9a6ef 100644 --- a/drivers/perf/dwc_pcie_pmu.c +++ b/drivers/perf/dwc_pcie_pmu.c @@ -710,10 +710,10 @@ static int dwc_pcie_pmu_probe(struct platform_device = *plat_dev) } =20 vsec =3D dwc_pcie_des_cap(pdev); + pci_dev_put(pdev); if (!vsec) return -ENODEV; =20 - pci_dev_put(pdev); name =3D devm_kasprintf(&plat_dev->dev, GFP_KERNEL, "dwc_rootport_%x", sb= df); if (!name) return -ENOMEM; --=20 2.51.0