From nobody Tue Aug 25 14:36:10 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D59935C1BD for ; Fri, 14 Aug 2026 05:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786686282; cv=none; b=HNVfrCooM9MlAlf2d3SLxtV7O2GssIWEv+sKq7cNbMSvQNPKWDZgw08gyaGlzyhUdREeyklu+9scPw2x4D6dqG1l8uyj1Mo6WKv0JamQUqsl7YKFIl/7knex9SFp6zxMGkJJ0uPth/rOk/DqVhrxq0ZOroAI3upYhPtKUtOsVGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786686282; c=relaxed/simple; bh=Irt16XWHLS1CMKe/yepyHno5CoudNScpDp9oO0tCzZ8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=TkrDdIvDGXE8gXQHBm+MgRBWC0PBSuW0DYQrZk7vTwXSuBiarJ6LCcTq+gsRF2UP3hcL6W1AxKCTZorIusN/6CRce4EkZTyP0ompEORDNd6f8OJf5VSqgpV39NuCxsjD5Bw6ZuROJVTyXFRXfsY8evx4a0RIA3jyNfnn4rvPh/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 3962151c97a311f1aa26b74ffac11d73-20260814 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:38849c2b-f25a-45a4-a612-4d3156bf9758,IP:0,U RL:0,TC:0,Content:0,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:25 X-CID-META: VersionHash:e7bac3a,CLOUDID:793b16005a7e15cc3cb6bece35214b59,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|865|898,TC:nil,Content:0|15|50,E DM:5,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA: 0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 3962151c97a311f1aa26b74ffac11d73-20260814 X-User: gonglinkai@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 784210597; Fri, 14 Aug 2026 13:44:32 +0800 From: Linkai Gong To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Linkai Gong Subject: [PATCH] char: dsp56k: check device_create() return value Date: Fri, 14 Aug 2026 13:44:26 +0800 Message-Id: <20260814054426.2508939-1-gonglinkai@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" device_create() can fail, but the driver ignored the return value and still reported init success. That leaves a registered char device without its /dev node. Check the return value, report the error, and unwind the class and chrdev registration on failure. Signed-off-by: Linkai Gong --- drivers/char/dsp56k.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/char/dsp56k.c b/drivers/char/dsp56k.c index 1c2c8439797c..cbcfef44a075 100644 --- a/drivers/char/dsp56k.c +++ b/drivers/char/dsp56k.c @@ -509,12 +509,20 @@ static int __init dsp56k_init_driver(void) err =3D class_register(&dsp56k_class); if (err) goto out_chrdev; - device_create(&dsp56k_class, NULL, MKDEV(DSP56K_MAJOR, 0), NULL, - "dsp56k"); + + err =3D PTR_ERR_OR_ZERO(device_create(&dsp56k_class, NULL, + MKDEV(DSP56K_MAJOR, 0), NULL, + "dsp56k")); + if (err) { + pr_err("DSP56k driver: Unable to create device\n"); + goto out_class; + } =20 printk(banner); goto out; =20 +out_class: + class_unregister(&dsp56k_class); out_chrdev: unregister_chrdev(DSP56K_MAJOR, "dsp56k"); out: --=20 2.25.1