From nobody Tue Aug 25 14:34:37 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013038.outbound.protection.outlook.com [40.93.196.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC5430E85D; Fri, 14 Aug 2026 04:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683397; cv=fail; b=BO4ElPEgnQcfWgct048aOe5h3ffD2EE1gsU2JN53Se1YOX3oxQGTZOQonuaDaqPTK6M/H8alvHJ4aNmMOUM6ch4og2+2arEwuLIgCX4ORcjAwrygSI2RA3Re7O3iFn5AkHkJO9KLj8j51eCAlGd3eF7VI6pHxVCByAN/0IEkbRw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683397; c=relaxed/simple; bh=+QtVjkh5t8bOr/Gqf2HghDyTox+j0s/6VGTpSnjPrGc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R3Tmp0enaZZnEXcHlgO3eEDzXwYk8DgYUcWoJTYV+NWmJ2F8mB/yv7t+5xJ8AJYeieez847UwBcksR8bbWcz7HX7ZzhCltFTlCQKkEkdMCaLGruNMgPJ948GyuJDk/e/Tuu4UIUnpkxktbCVSbHCtKQzt1kogAS2fKiyoLtE1XE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=aTE8UGGc; arc=fail smtp.client-ip=40.93.196.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="aTE8UGGc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gxijpD+mUL/PgLsdKU0L8HNEBnsSqProRT48VuLFKhyIM8vqeSy2Bz14ZTzOJtI8RRZCleq2M1lnnDFe9dwypwB78U3rXF9rQlowBGOYMlgIzF20qiS3fGnfoMkFadLfcEEbunvkEjHOjccZR4eLQlWcNF9FJVf3CwSVwkH2qIGLHLK6GROpCVw6GXNe10wwP38NzaTkBRnh6a1/6DKocZbXBOTbWNYvULRoMl+NnXTTlOJvsxUdzLnEedfO1W+m/P7KR20Hw1wzoBNulhjlHsuo77K4BOBl+eQQRvP2SdBCN5Tyh1EnvdFnMVR0pFfDerVroYdQ3sy+9AJrYB37rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HSlMFIa+cO6IhmomOYMXs1vF4YEeFIBKdUngi/THcIA=; b=SCa9rK8C8xVEVf/jprpi5NTo5ZMoLY4BGLI2XNMi6NqtLVX+2XWXw+IDaznrtSUf+6Iiigo4EtdRvCCYsPVMB23/UW+WJSreUjnKZd9HKKWoA6gJyWIGyHNXYaXCoE4N2seCM3rLkU9PskeY5ZT48IV7+g0iknaCzei3As/XqORl69jX/4fttK+uytno+QgxdfBhRCwb4ldx9+O5oz83E2ABwtAm6jlCtAKAXq/4fqG5Dt/m6IcjZHwkAckX+DPusYyP5h40vJUXcW1gRIotu5isKauJVMsWNV734xNhChV4CHHlHntQ1at+vKaF/6S9z6Tvy5vbcqjwR42d6iR7xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSlMFIa+cO6IhmomOYMXs1vF4YEeFIBKdUngi/THcIA=; b=aTE8UGGch51J124che9nehKwrzCg0yC7wFcFOE0HWY456+VhQZM+P1nnrdBlR8gtmbYX3WDA0Tb5DOrVzMcOnujH7Q1017jEwyBFmbu0R7wsivXZ5peTvtUA0IVH6oX0l2CKCJtB8e1YoijMqL0ms9wbw+K9UXUByfrO+KY6y3M= Received: from BN9P221CA0003.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::25) by IA1PR12MB6627.namprd12.prod.outlook.com (2603:10b6:208:3a1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.13; Fri, 14 Aug 2026 04:56:28 +0000 Received: from BN2PEPF0000449D.namprd02.prod.outlook.com (2603:10b6:408:10a:cafe::18) by BN9P221CA0003.outlook.office365.com (2603:10b6:408:10a::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.14 via Frontend Transport; Fri, 14 Aug 2026 04:56:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN2PEPF0000449D.mail.protection.outlook.com (10.167.243.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Fri, 14 Aug 2026 04:56:28 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:28 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:27 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:25 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 1/8] dmaengine: zynqmp_dma: Fix PM rollback on sw_desc_pool alloc failure Date: Fri, 14 Aug 2026 10:26:09 +0530 Message-ID: <20260814045616.1661199-2-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449D:EE_|IA1PR12MB6627:EE_ X-MS-Office365-Filtering-Correlation-Id: 707484ba-0915-483a-1663-08def9c066b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|82310400026|1800799024|22082099003|18002099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: GoU1m7HJsYnhZ3T+d1FNTYXqbqW6kNjSVrN6E9/NR0vmgrbnuOpAKhY5Yj+CZNxHrpDafgtWinWqXqJBQgjfo2Zf1NlCN0uGAo+H+uZKtO8FKmqG1MG8l+t77Q6EvuZ7m9dZZESuc02LvYTplckaGsJv9gAcV1Yu0Nv36PxB2TcMCnVnAKijtJVEht6ri9PRg2pxWTUt73Zq1yYOSEs+bo+wX3Vxg2LXS3VqULaoWK+3JKV7AQhXDnfnb9eBNhiFo4aZN9z74O6CPWxZFHqjJhJL5+fUgzzTXWf6jOFUXs5o1Or9w1nbZnBLIk77EXnXTOD1vogkMj5SLftcjpFvgc1n8avs0n3pb0+w++A3kgzdVeVg4p3j2hAsdaVQcmR3SqX+EPVEtq45HDcHUjqabe4D8q/UGIlMVdV3EcGAt/qFgoY5sM0i+4qLcdykBq8tCTlinVxgM7HOs1CNOEyCp3iAfUGlcjw76Z0ylZaEk0pTLErtzDI/TwNRkzAjWqgq2NvhxdNo116AlBar+rcVnq5pcPHFsvK9C2zqQtiphXhaLY21ekQEafDCqcRFs+XPeXHt3WM5ZokHO3s6zbF0w1ODhm+JaXyL0vvLjn2OGhcbwNCQ71x0F+pe2KM+TJawKxTSlcziYNcsQHTYh+mZOQHq5MP3XOdlKHf8IcD3Hm0DH2uzpLDSj+bulOUawq08036Q20TUtF2w0LxQZC4ULg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(82310400026)(1800799024)(22082099003)(18002099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vkkY/HfDppB9rS0aqhRNAK7LCccmvMxeFfGEL0Ty77ZyWhC5UhZb4bhyYV80ABl6A021e9krdkE4ZpiEFh7Uv7qYiAP8Sw/7hGSFutbZLCTgUKQ12Z7H6yGYGKE8N8sR+tSYjTQ7NPGcxhMyUv+san57TjMDR+4YsMtJVWUwFgYlgH3JMUOwtEXxwNvrSByhKSDAw6p7vi2VUALLId/Xufqcl1kdj77Zkou1Bwm4JPUaqiUkm4PoZjXP19yScIdY6RRMxVwPFrfd30CJb2Yo8VmYa/+nB6a0PAeZlqCL8W0mNQM+fOFvVSTI5ow8ZovcO+amsR1EN7GTgs+AaH7UWM8BihsFM8cwZ8kWqGh3yMPOfKseZbxwh+Uqm3Xe+LFBwljcyXPhMgl+BnRsU0UqrNWHxQ8v3e9FwhD+BZXTrIPgSZgKwDneWI/pdcoXmdAS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:28.4749 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 707484ba-0915-483a-1663-08def9c066b2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6627 Content-Type: text/plain; charset="utf-8" If sw_desc_pool allocation fails after pm_runtime_resume_and_get() succeeds in zynqmp_dma_alloc_chan_resources(), the error path returns without dropping the runtime PM reference. Route that failure path through err_pm so the runtime PM reference is balanced before returning the error. Fixes: 8982d48af36d ("dmaengine: zynqmp_dma: Fix PM reference leak in zynqm= p_dma_alloc_chan_resourc()") Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- changes in v2: - Reworked the patch so sw_desc_pool allocation failure goes through err_pm, ensuring the runtime PM reference is dropped before returning the error - Updated commit description to match the new behavior --- drivers/dma/xilinx/zynqmp_dma.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index f6a812e49ddc..9f1e69700dd0 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -483,8 +483,10 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_= chan *dchan) return ret; =20 chan->sw_desc_pool =3D kzalloc_objs(*desc, ZYNQMP_DMA_NUM_DESCS); - if (!chan->sw_desc_pool) - return -ENOMEM; + if (!chan->sw_desc_pool) { + ret =3D -ENOMEM; + goto err_pm; + } =20 chan->idle =3D true; chan->desc_free_cnt =3D ZYNQMP_DMA_NUM_DESCS; @@ -516,6 +518,10 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_= chan *dchan) } =20 return ZYNQMP_DMA_NUM_DESCS; + +err_pm: + pm_runtime_put_autosuspend(chan->dev); + return ret; } =20 /** --=20 2.44.4 From nobody Tue Aug 25 14:34:37 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012052.outbound.protection.outlook.com [40.107.209.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 452C03502A5; Fri, 14 Aug 2026 04:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683401; cv=fail; b=ckDpVmPF4xPeboHm2Us/uzEw/PLJ+E7siljVsnkpxLDlQUiCNsajL9pSeqeVgSwyDGk0/L0BuB2rQ8qAOxttWeUYdb/7ojvDim+vH/HQ3mi8qZ7q3ppwfbEch1tf4zjcGsjxOjqUa42x0pOG/zSXzCuPm4cDSSdzfaWOF/YcW04= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683401; c=relaxed/simple; bh=C1aoY7hD4GFPVMTLV0k4ugXgNKsb8MMAf9+O103L6YM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uTVdNXp4C9TuaxbivqQCmm/8KHI72vCFdjfdlMe+lnZRXJvIE1fO5/ka3ld2Eoqcitb8gLB42Xu27iL/OcBUiHvJD3XVk7u98nUcRrVGrgAymBPTyEfKddmXHpVIcdew9619PLN0AR28ZLpEQNIvt0icQczLBeAN1pz4HwGF2gI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NtZEitYi; arc=fail smtp.client-ip=40.107.209.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NtZEitYi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y1+3FlU/83jB69+dpO49NhwNva9oqrjmoAd4TzBefe3s9HkdmpWmPacZH0mRdsh0Kf09aQhJ5YSK7lMfOjnSszFLQqgh9z2cdJK2UvqaRsY09cKi+Nns8IuGt/EHm1MYo6WZC+XT4s/DRNPvjaanOguzn9OmEbkwFub7pfWYTTIm/WgEPLzU8dH4KwdXDTNgZyJGLXIwCqCNSCGDMzYNype/QEl4yNyO2004LkFEPaO30+HyR0n0Cy5PbTXqjmSTtOwsLMz+e0C4aCNBwlkOx4NGwCi7qz95/mFaZkva0PWzKF7On4dvygi0MlJuwA5ajZk5NZO6uzjn7ZWCOerkLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=us//KYrtTaCNhoRgyl9hUTq7eDbaoS/cbFSWzNjP4oU=; b=xjY1V+PQms8NxzXcwDANuNNx3HTPMPCAIX8Q5xxllkr1F32rOpLUWCDozWM8UtzcOavfYd8lKTeT9H/zSN4fs4TMvowfvsnYHzqzL0/RmQJ5dZPj0kcAW3Y3aENyclU7B82zbCBmFLygs+un00b2DXfqKwFz6ok2SvB8MmKATKRuXxn8cQpzhDHvo+LJtHSorZtBnJJ14i7DZQ1AoCh4FtXGYsSwU1Ye9oQgouAQXYBzT3V7d7ePoVqzd1nmsILcISVIMr7aoZ1ECzMrxFiuhHh1/+OFrS9LfANn2pYNrrtWPCPGraepOiU4HMmQXtc2ivCC6a+U/fPVgawIR+q2ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=us//KYrtTaCNhoRgyl9hUTq7eDbaoS/cbFSWzNjP4oU=; b=NtZEitYilv5A6b2k+tmdl5NxPsaUiwZ2vcg84okRw6K7Yn95Mp18TufkT0qnQ1v9awq/HDVzv0jBLQABkIrg5Zi4VKcWE/akHnSYhGuMddr29uO3BMsEHW75GZlRt97BG+RyF6sqhmpZPEh4DFEYFtibNTH9O8r37uTRU3ZvD6A= Received: from BN9PR03CA0302.namprd03.prod.outlook.com (2603:10b6:408:112::7) by PH7PR12MB7355.namprd12.prod.outlook.com (2603:10b6:510:20e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.16; Fri, 14 Aug 2026 04:56:31 +0000 Received: from BN2PEPF0000449E.namprd02.prod.outlook.com (2603:10b6:408:112:cafe::ab) by BN9PR03CA0302.outlook.office365.com (2603:10b6:408:112::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.15 via Frontend Transport; Fri, 14 Aug 2026 04:56:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN2PEPF0000449E.mail.protection.outlook.com (10.167.243.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Fri, 14 Aug 2026 04:56:31 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:29 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:27 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 2/8] dmaengine: zynqmp_dma: Free sw_desc_pool on desc_pool_v alloc failure Date: Fri, 14 Aug 2026 10:26:10 +0530 Message-ID: <20260814045616.1661199-3-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449E:EE_|PH7PR12MB7355:EE_ X-MS-Office365-Filtering-Correlation-Id: d65c2fed-8bb5-4c4c-dfa0-08def9c0685a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|82310400026|376014|36860700016|22082099003|18002099003|56012099006|10067099003|11063799006; X-Microsoft-Antispam-Message-Info: lBDn8vN3TwsFwlsrPiFY1JxEjZ4CP2dg8odv3WeR3sjSISVUsE0yJQXjKz8KQL/xjGA/1hS1IQxhq3KEz0nKBXu8qlLgGmsuSJ2hG/yiCyelUXB0d1M+DgSbIpI9Swc0/ViTXvUx3aMO456A18Fz8cIPaYXMn9q6ltfVe2oG5UDJKoCHai9BM+PXTkKGLucVz19Dnd8fa8IyseswzNSZtMGGm4v2G4esOo69JZVxs89S5DjiRpH83Gi4KiP3t1dT3ySWEs/MgUVY0xNspq5Z9MhB3A7vaOeXPA4YoVWyXDmAiZRoxdOr/pypcyU1fn5M7VYGptGmUnTQMDO94xrrly2l+9OgORiejWBY9UWf32HVcfGZP5iYwTw56wVxN4YRqHSPIc5kgful2Gcf4Iaadi3TZOUnNYz8KPH+FI1Y734LYzMFLUEyyjkjcnQ/t4YzY2/0cQlvbF0cvK/OyjSdyakwu6z+7RS1w57ZJYhE4ThZ4z0BD1VqnntrjiDGWs6lckpVVCIB78OA+nSt0IRWOsBHgrTkkZQ9MNxTIhgAS3+yXcWG1MtMV9BgiQxdBql2xb1siyoxx9adNJRPWk+NTKOO4ysUkTKnWS75VhUnQNjzYmpFJXV4eNkZ2h64kIABao6LNcAw9gdho+FuDQtoea4wO/e/GVjispbEnWat7yOgak12Z9To84le3x4auG2I3Vkfolsh6mmHd1hldqOcSg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(82310400026)(376014)(36860700016)(22082099003)(18002099003)(56012099006)(10067099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /EYY5xvG0yVWw1K75TL4DzVWy3VsVK5RwdI3w/OPGzDC5VopTIq9vMs/un9va6YVvcDkOMsrJM1y0rAPHQJpiPXXYN09HwAzIZtudhG7M/fJO3NxnRNWHXQqRj9x5hPF7jAcws/KzD4rj/+ugpAn7rjbOjxg7pf8QwbZ+fBtGsr17ILKz2I4Gpfheq9cayWa0x2F0NVSJUX+8fGX8DZD9zgnltO4rXArtqiqNVgFKUFKu94/GZXd19DRovUe+oC194CvIP4zsvhiEkxu8pua7uKSYbCquCjnKfeyPEVj6j4bD32Nlb6edYfsgaCCno6YclYESOpCFNvAE1laZSs5s/Wl1M4+oQ7dPWf+fXLXUwUnrJs5Z+S8+qQJn2JCarxz5aYu5ppmSRcC+tAPnD2zjGz/j58C6JunxRuw6LOCLrU3arxvjinVpOxdBsw5PcKc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:31.2583 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d65c2fed-8bb5-4c4c-dfa0-08def9c0685a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7355 Content-Type: text/plain; charset="utf-8" In zynqmp_dma_alloc_chan_resources(), sw_desc_pool is allocated before desc_pool_v. If dma_alloc_coherent() for desc_pool_v fails, the function currently exits through the runtime PM rollback path but leaves the already allocated sw_desc_pool behind. Add a dedicated err_free_sw_desc_pool label for the desc_pool_v failure path, free sw_desc_pool there, then fall through to err_pm for pm_runtime_put_autosuspend(). This keeps the error unwind symmetric and avoids leaking the software descriptor pool on coherent descriptor allocation failure. Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver suppor= t") Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- changes in v2: - Split this cleanup from the previous combined alloc_chan_resources patch - Added err_free_sw_desc_pool label for desc_pool_v allocation failure, freeing sw_desc_pool before falling through to err_pm - Updated commit description to match the exact cleanup path --- drivers/dma/xilinx/zynqmp_dma.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index 9f1e69700dd0..b7c561280694 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -504,8 +504,10 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_= chan *dchan) (2 * ZYNQMP_DMA_DESC_SIZE(chan) * ZYNQMP_DMA_NUM_DESCS), &chan->desc_pool_p, GFP_KERNEL); - if (!chan->desc_pool_v) - return -ENOMEM; + if (!chan->desc_pool_v) { + ret =3D -ENOMEM; + goto err_free_sw_desc_pool; + } =20 for (i =3D 0; i < ZYNQMP_DMA_NUM_DESCS; i++) { desc =3D chan->sw_desc_pool + i; @@ -519,6 +521,9 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_c= han *dchan) =20 return ZYNQMP_DMA_NUM_DESCS; =20 +err_free_sw_desc_pool: + kfree(chan->sw_desc_pool); + chan->sw_desc_pool =3D NULL; err_pm: pm_runtime_put_autosuspend(chan->dev); return ret; --=20 2.44.4 From nobody Tue Aug 25 14:34:37 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010053.outbound.protection.outlook.com [40.93.198.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585F83612EF; Fri, 14 Aug 2026 04:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683400; cv=fail; b=B9sLxhRNVNQUINTZ3RmlXrRa8TRoXRDHu1XxD3cUiqR0GRFaRVY2JzzOmsmAGuZMFDguQrqfaPyTKiZTBEdJSZcuYRr6dvQwevoeWOw6Jz2o5IK4BmOpL3ESM7WDZSqak/1A9STZq0ocY+SU5hVdX8DZnmE8WeBo/RSIWeyrIEs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683400; c=relaxed/simple; bh=LhKmY8uQ9iWRwoEAEsLRgzdDIecSCwWcsDwBA6zY+k0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TYvsfl5z/3krXtslAurSkZKpe7OhaQ8A9LQF/UqqbDOWvv2nudl+gWYzG1qJUnVpIGqC4F/TF9yUh2HN3Lq2yyXPhGM5Y3HuugPM60qlyy9uaco5I8pAvpzfS7cwcXizPKs2Xt4zJGztGN44soTRi8QeescFwVsKwozf/BI7AFM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=4BqSdTQQ; arc=fail smtp.client-ip=40.93.198.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="4BqSdTQQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t+nyb/9So5PfxWCVYN79I2xgTPU9tAh9oJwYvxQn/96OSGu6DCq1ZdpfunhB/ttqJKy0ethRbs3L+I2YO2IWjOswZpO8df7h+lepOAlBEMKYy8I3ykJepn9X/iJfUlaFlRVE6xVh5H0OYWkjUojH26/6Kuec9aGUcenixFVqAT7mQugEFi69+jNyuAhne0Wf6ClFQVoDag2CPQDRvTcvUQ34N1d9wECZ+RsNud2AT61YdUyESqDejG5yVU9Zhq+JBZi1qC+v/Od6d9OTRhPudOH9mTZ7e/n7SexBwNi0TASMkkqRxerkdYopQok6tA3kYo+NHrEYcE/r5FcbROXi5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FD95NEgSPfRUx4uogB4xp9929ZyFC+gQ+3iUJOuVITY=; b=PcUNf554Dkv1M2lZ+x+FrFQ4XMGPSE1snfa6v/whl4lS6uy+fYPJ6sjRe0wZa6eKlWUSOpRpAyuhDy9e78JOKrRr/vzvQKH05TCWQ1A6s2hXNTz8GouoGXCxaWKf/iIT6XfIDibVJNzSVhtQSBr9H21GDnb39FW4qzj59qxOfjlNtJfzBFbnbyS7/hx0KjF2MfX7t3u+RHPMTtw0wXh3Mi8PAlx5Ph7l2fps7a/dOkDrLNDmBJbFa34kMOHmWZn4F+oPWru8wTzy/Ap06+pgLt9xNHEKIqWVpzjjmeId2Wb5mToj6Zedg0ovGe11GQin/euOgX1w/HOH1g0HEo94zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FD95NEgSPfRUx4uogB4xp9929ZyFC+gQ+3iUJOuVITY=; b=4BqSdTQQlOR3iIY7LUz2Kfu3iPdTLWEeVj0gutmdQFQrjNZYqEbwgSZ/wOZL8yY2Maw7Ef+7EJvAXKLP73MZ7xhvd481Sg9VQhvgSU3+g6OAefAoZga7iYek/81qeAaFeMPEXG5Uddbpa5EMtr0ht802oHCn4RZyQW4I3trj1Cs= Received: from BN0PR08CA0012.namprd08.prod.outlook.com (2603:10b6:408:142::34) by MW4PR12MB7031.namprd12.prod.outlook.com (2603:10b6:303:1ef::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.11; Fri, 14 Aug 2026 04:56:35 +0000 Received: from BN2PEPF000044A0.namprd02.prod.outlook.com (2603:10b6:408:142:cafe::19) by BN0PR08CA0012.outlook.office365.com (2603:10b6:408:142::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.15 via Frontend Transport; Fri, 14 Aug 2026 04:56:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN2PEPF000044A0.mail.protection.outlook.com (10.167.243.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Fri, 14 Aug 2026 04:56:34 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:33 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:32 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:30 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 3/8] dmaengine: zynqmp_dma: Fix chan probe/remove error handling Date: Fri, 14 Aug 2026 10:26:11 +0530 Message-ID: <20260814045616.1661199-4-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A0:EE_|MW4PR12MB7031:EE_ X-MS-Office365-Filtering-Correlation-Id: d9839df1-9569-4aa1-4456-08def9c06a5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|23010399003|36860700016|376014|6133799003|56012099006|10067099003|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: gzS3flSh6v2sWaP/60kzPgNGYoBdWE3XV2ekMUgFpxZpuwGMQ/ohlkt7vA6xU6nN9YGQa9RBbE1WPG376juD+EFfYFMUgcgDH3Pp4A0Qgrs9XKIpea/AiK3ppJ2yoCcSKqyGInVwdTRFp9at+01mojXvo0MFE0SHdyrx+oV0FaCZbQbJj5/T50uyLVGxm1SyYZ6BNdLTyOPviyqhQpU/fiKCK31ZZ2OPjMbNVRPNaj5hyY8PdgntamETUaXlUz9MiWhLRReVSnLC6BLDzFoz6Fae7dyGbBSu3hgqwh7tyfBFSQOUeJi+HU6/mLkHXNCSYosjX4Enq65LkfQET0s1ZyYgNcNNrbM7i3NgzhHVnDzTfL/sLi6SrA2tbovfhX3RIkec0ZDR/5qu9xaR9XGIkXPLkM0FvT8wFXru5jz7mTytQbncfdT2/c5AFGWxjfVRSBkVaMNXPQZ45W/B4LB9vdqzw5TrkrcthZ0fCl5HoMod2VEJDQCWjP2ppqP+eqR1FdybVuKL1PkQvXXaJqK/7aydnajj8grHXHHCTFGDilPndcBmH/EwdU1s7pccjiydU3AJlqcoPNi2XfAvBqyonMyl1DednyKI8WDpDbPHXf3hpmm48FsYErOVsH7M528jUtjK1/dp7PQ4XZVhTNSdKsixbTBnkiP6ebjHIIE2omMLZNNJzMIWfFvQLsupBsuh6bEajc8iToSkE8bxKHLVdg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(23010399003)(36860700016)(376014)(6133799003)(56012099006)(10067099003)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: s7aAN05sJ6u5vew//Ye1uqW+Bv9H80cGi3VWXebBRrqOANO/oC5gAx5Xff174uKQgJ4JEkmrASsbm3+pJLQhMPcbVfPEop/Y1hghXtiZVvi0Lnx+whQ2/L1ugbJjq5rhRMU+9jMD00JC5wWWg4tbHHOIIYlZCbH6kaNDd6vINBL6GFPDmHiGRyoe0BJjHwJ9er6P6vaeJ3kYCTAz3quTDTVbiiJg9y3M5qPePlYwCR/VAuLYeDnLFPtY/pdbQdsxKwPIVaF5MIzOe914U80J2Ibb8yfyZY3d/5EyWuvETN1ZiDztL0hjM8FJ4mVanL4OA+mWzIZhSeUTUjJRpp2VL3zZJYVq5C21WRVT9yyVanHYjk6//EOCKjOZePE98AL7pfWV2Seili6/+FdfrWv2LJyk5GlGAJ7423H7lH1GqyWBOm3rZHDLMsk2eAWqMSNU X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:34.6232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9839df1-9569-4aa1-4456-08def9c06a5c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A0.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7031 Content-Type: text/plain; charset="utf-8" Keep the real platform_get_irq() error by returning ret directly, stage IRQ setup via a local ret variable, and assign chan->irq only after devm_request_irq() succeeds. Initialize chan->irq to -1 and initialize chan->common.device_node before it may be touched by teardown. In channel remove, free IRQ only for valid IRQ numbers and delete the channel node only when it is linked. Register the channel node only after successful IRQ setup. On channel probe failure in zynqmp_dma_probe(), route cleanup through the existing free_chan_resources teardown path. Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver suppor= t") Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- changes in v2: - Reworked probe failure cleanup to use the existing free_chan_resources te= ardown path instead of adding direct tasklet kill in the outer probe failur= e block - Kept IRQ/list initialization and channel registration ordering fixes in t= his patch --- drivers/dma/xilinx/zynqmp_dma.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index b7c561280694..22b517c57003 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -205,7 +205,7 @@ struct zynqmp_dma_desc_sw { * @desc_pool_p: Physical allocated descriptor base * @desc_free_cnt: Descriptor available count * @dev: The dma device - * @irq: Channel IRQ + * @irq: Linux IRQ number, or -1 when not registered * @is_dmacoherent: Tells whether dma operations are coherent or not * @tasklet: Cleanup work after irq * @idle : Channel status; @@ -896,10 +896,11 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_= chan *chan) if (!chan) return; =20 - if (chan->irq) + if (chan->irq >=3D 0) devm_free_irq(chan->zdev->dev, chan->irq, chan); tasklet_kill(&chan->tasklet); - list_del(&chan->common.device_node); + if (!list_empty(&chan->common.device_node)) + list_del(&chan->common.device_node); } =20 /** @@ -915,13 +916,14 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_de= vice *zdev, struct zynqmp_dma_chan *chan; struct device_node *node =3D pdev->dev.of_node; const struct zynqmp_dma_config *match_data; - int err; + int err, ret; =20 chan =3D devm_kzalloc(zdev->dev, sizeof(*chan), GFP_KERNEL); if (!chan) return -ENOMEM; chan->dev =3D zdev->dev; chan->zdev =3D zdev; + chan->irq =3D -1; =20 chan->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(chan->regs)) @@ -954,22 +956,26 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_de= vice *zdev, INIT_LIST_HEAD(&chan->pending_list); INIT_LIST_HEAD(&chan->done_list); INIT_LIST_HEAD(&chan->free_list); + INIT_LIST_HEAD(&chan->common.device_node); =20 dma_cookie_init(&chan->common); chan->common.device =3D &zdev->common; - list_add_tail(&chan->common.device_node, &zdev->common.channels); - zynqmp_dma_init(chan); - chan->irq =3D platform_get_irq(pdev, 0); - if (chan->irq < 0) - return -ENXIO; - err =3D devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0, + ret =3D platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + + err =3D devm_request_irq(&pdev->dev, ret, zynqmp_dma_irq_handler, 0, "zynqmp-dma", chan); if (err) return err; =20 + chan->irq =3D ret; + chan->desc_size =3D sizeof(struct zynqmp_dma_desc_ll); chan->idle =3D true; + list_add_tail(&chan->common.device_node, &zdev->common.channels); + return 0; } =20 @@ -1134,7 +1140,7 @@ static int zynqmp_dma_probe(struct platform_device *p= dev) ret =3D zynqmp_dma_chan_probe(zdev, pdev); if (ret) { dev_err_probe(&pdev->dev, ret, "Probing channel failed\n"); - goto err_disable_pm; + goto free_chan_resources; } =20 p->dst_addr_widths =3D BIT(zdev->chan->bus_width / 8); --=20 2.44.4 From nobody Tue Aug 25 14:34:37 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010038.outbound.protection.outlook.com [52.101.56.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69E8C35DA65; Fri, 14 Aug 2026 04:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683402; cv=fail; b=YP6iilyb26UkVpiWhFvD1TR2n/0bYyyeTEBFkog47ZC4aXWpaHF6LAcadnh9J9/dXj9MkADJGGo3aWBfjP1e/Sefr/MRyK1ySQk6vAXvkaCR/DucDtEgUzSD5zXX8zy9snTud1Uer6KRlr6mp3LqB8UPiz5J61YS02NNdBftbzo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683402; c=relaxed/simple; bh=tsJL8Y2ycYmCElfQvicp1NDETIwfrO+JD0T1eE0Aogo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AlqRAlV5U9f0o6RNhy0Bwjq4UGXBVM/Q9LCyR2pW9OiBHNOJt2zkX6IWwNmQ4dCLYZqkKHZX5WwgEiLYphRtHy41zEWJhFwO3SMVDZ9FT9LbYKtknRkXz09UidzcFEwyu4UTebzlE+q6/9JwONJVCDj4fun1ZW1I8Sp8XvtdnLY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=m6mHrvjP; arc=fail smtp.client-ip=52.101.56.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="m6mHrvjP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kwfZM3xCKy6DgCxDOgNf63yeuU9ihjc4RZrdTNu6E/fANvDos9YxWV9Hvd1TVauu40WvD3ur223aLVGbb8khSaGLaqH94wZqeotVJ8OTdGZ+F9wtEXpY+7ZNyUCLwGvehOVZKnvaqM7JgR+z8ZiiHxig+q74Fg0tB1o0Cbcl8ioz5v2b7jfZJttueMzaf4CvI+sYBff8G9RejznYOSIXwzwxicFXD44Xv/z7fDy13/P7CKFouAM+0ihvy9qRtL+0b2ZaZrLEu++zIdB7kl96wDte8VsYNS5x11DkuJxcAKCPnCV2XE1KVKJcpkP+EKixyyAx3T6tJSEejlgSavW/sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jvm1Wke/S0GmURkJ31/52raMZhorVEqB9/iGa0DqSA4=; b=W3BnHcTvj7SHWUrtGdr0Iz9zN0gbYNGE9Nqj8lALkB93E5wmZZLFFTGxTVgR6StQwnBmtHiPiLKgvJbCgYdvr/+tEes8XOSS8wXe+VWoFcKYKQnNQpco5X5xYuJpMrGy/MPjMh42R+5pyQ29ipybEIAAIDCrTC3oGcNYfvklJi/WpTrCNs6HXFwODCX+NqEtpW01XOyPXPfm3btjrTN5ytoeCM0zL8tBMf9kPUYmanYS7K2Jwyq6OLqhbhAkDwEGGZ4AFVE2ALWxwzcsgNSOJYsTBz84gE/sxxRLYVCo1YHA/5vv07vk+80o0k0im6ZtgUUNOA473OQNJRLKRylIeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jvm1Wke/S0GmURkJ31/52raMZhorVEqB9/iGa0DqSA4=; b=m6mHrvjPVc6LzbCR8oIej/1ElFVE4/aBIoUKvBIwFSQ67neiC0TJsjPMWpyVDrZykmDz2Nw7mCVhWYgoFNFmTJssx0TxB5gIh/aoVHeHrLpeJZbfm+hvpRad4YqXzGVig7gns2dL+JEDi0j2ogqs3wLwrhvcD44pPQ/dpDJwNsQ= Received: from CH3P220CA0012.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:1e8::32) by LV3PR12MB9165.namprd12.prod.outlook.com (2603:10b6:408:19f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.16; Fri, 14 Aug 2026 04:56:36 +0000 Received: from CH3PEPF00000012.namprd21.prod.outlook.com (2603:10b6:610:1e8:cafe::67) by CH3P220CA0012.outlook.office365.com (2603:10b6:610:1e8::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.16 via Frontend Transport; Fri, 14 Aug 2026 04:56:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000012.mail.protection.outlook.com (10.167.244.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.0 via Frontend Transport; Fri, 14 Aug 2026 04:56:36 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:36 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:35 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:32 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 4/8] dmaengine: zynqmp_dma: Fix stale kerneldoc comments Date: Fri, 14 Aug 2026 10:26:12 +0530 Message-ID: <20260814045616.1661199-5-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000012:EE_|LV3PR12MB9165:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e0213ab-490c-4f21-adf0-08def9c06b74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|23010399003|376014|36860700016|22082099003|18002099003|56012099006|5023799004|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: S6A8/RjudkN+Wjzp43XglBpDQVTfeooCtoq0FzJfUtnQCkz4Xfb4UgxEajsPnnl2yoM5tnvT8zGa0DVDQ5/ITXefXfOA8Jj2p2NB6l9B/tEtn2VRKgrVLBquApMYjAIH3ewgm/a4vgjM/NkKgx1KmykYwarZaqa3z2gog2ZZLpya72ctIegH3hUfvgYUBk+fQvUPws5wsSmjht8KtBlwNWDK4asPTp7jkJ2VWcoeBX/u4+crE5HrZiuC2G9c4qtbsxMtcq6oRhuIFGXolSETMQTJ1z0xs2lpe0SQvmtM93Jqn9KZLFOa+uxWMkLXEHHdvzuM93SADxiyKd0dPA74g/WhUXAwDOuqnY8oQ0CPf2HZoaiAAIj10JYPxxdgNjLQ78ruen3VG5sFk+4DOfwmMV9Bhhq8tjunuLxk8Z0H83HZvAW8ANhOmd/+pt9ZQAf2cPD3PWc8TcX+DmEnHDC/PhVps/ANRimFPRy9C3FpqPMuCGRg4CVRtoVt6wWIxfiraE/CWfzt8vyfH63xht7Aqq6CaAo7OmCtuFK4vgxxDsH1OKY7/K2xr2otpDCddhdWwvm8OKwlOCpVdP4Lh+n6bEDcq2RnuepvtN+SJuPzZar00Kq4elQz0x84r3YKRmfhf34tWUZ47tgHGLhzxIGT5hFq9GUM50XxcnO8IY5yuaxuIav7pHpZwiYZcwJJBpEkpImys6s2BD18GRjfnlrOCw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(23010399003)(376014)(36860700016)(22082099003)(18002099003)(56012099006)(5023799004)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Rql0xvFaOn4R3rIlpkzqkmE4g2+re6X9VtAd/49E8rzbIDHRP9pjp3uIprjOVs84FxGwrpmsT4XHmm16d04SSd8Emi8IYi5lUyGKg08DMNSzCPHdUPvrkePQAtZUzkVF1ieHL6/yAUrkonLFg0bd4bz58QV1b/bO3hCCWnYMUX05ewpSGEX2ysg6ancswtLsvzHc0m8kIDHEDTx3PsRWLD2X47Do7Z78mrPzzd9eQQIT8xZ3vQq7KUkCNdMfTdMHICqwoKJ25ftECLKAbntJpcSkm20RLk9Rkw57azUGUx8Kw6Hpywe21KrY7qhpGSei2zh415M+nXrjQVNFx56qkv0ZLiUPlA2c1ZAbr/8SNR+ws7T26TOqQWfB1274f9KKjInZTz34WF4sNx39jSFbK7HIM0udEs1VqNLNPLR3OHHZq+QcIVtH4oIcIeurODJy X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:36.4475 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e0213ab-490c-4f21-adf0-08def9c06b74 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000012.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9165 Content-Type: text/plain; charset="utf-8" Correct kerneldoc comments that no longer matched the code. Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- Changes in V2: - No Change --- drivers/dma/xilinx/zynqmp_dma.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index 22b517c57003..a2fbefbb43b6 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -208,7 +208,7 @@ struct zynqmp_dma_desc_sw { * @irq: Linux IRQ number, or -1 when not registered * @is_dmacoherent: Tells whether dma operations are coherent or not * @tasklet: Cleanup work after irq - * @idle : Channel status; + * @idle: Channel status * @desc_size: Size of the low level descriptor * @err: Channel has errors * @bus_width: Bus width @@ -435,7 +435,7 @@ zynqmp_dma_get_descriptor(struct zynqmp_dma_chan *chan) } =20 /** - * zynqmp_dma_free_descriptor - Issue pending transactions + * zynqmp_dma_free_descriptor - Return a descriptor to the free pool * @chan: ZynqMP DMA channel pointer * @sdesc: Transaction descriptor pointer */ @@ -617,7 +617,6 @@ static void zynqmp_dma_start_transfer(struct zynqmp_dma= _chan *chan) zynqmp_dma_start(chan); } =20 - /** * zynqmp_dma_chan_desc_cleanup - Cleanup the completed descriptors * @chan: ZynqMP DMA channel @@ -908,7 +907,7 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_ch= an *chan) * @zdev: Driver specific device structure * @pdev: Pointer to the platform_device structure * - * Return: '0' on success and failure value on error + * Return: 0 on success and negative error code on failure */ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, struct platform_device *pdev) @@ -1042,11 +1041,11 @@ static int __maybe_unused zynqmp_dma_runtime_suspen= d(struct device *dev) } =20 /** - * zynqmp_dma_runtime_resume - Runtime suspend method for the driver + * zynqmp_dma_runtime_resume - Runtime resume method for the driver * @dev: Address of the device structure * - * Put the driver into low power mode. - * Return: 0 always + * Enable device clocks. + * Return: 0 on success and failure value on error */ static int __maybe_unused zynqmp_dma_runtime_resume(struct device *dev) { --=20 2.44.4 From nobody Tue Aug 25 14:34:37 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012070.outbound.protection.outlook.com [40.93.195.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B465366806; Fri, 14 Aug 2026 04:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683405; cv=fail; b=fU06KFLz9HiL+K76M55aG7c5irCVmwhYiewuua0E7lmJGTTBH26ZK20QlSPllQI0rtBde7R/VxIjHwqPtl1O2zWLbn4q4px9jmQsjnqyBcltMQsClJTYiSN/qbhFVYYQKupkMhI0sdRBEun/KShqh4f1EdpTpT0l5ptPFxr0VV4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683405; c=relaxed/simple; bh=Zrnt2jFZJE/P5IGcEfn4GjHDFcgJ5PIOp6wrHPOlwc0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l2B1NJaj9IFntjRDVp+j7iaccxzN6cjMZQry7EH4g9bd6TmIKaPeK6iF/hdL5wEOmuMDxwRvkrgIFEYoTC5tOcD73QDcu8Gxu8sUDsTmY2nf9234b5u0c2jdA93GM+vlDQqvxem36ZyuQO4PXj0w2rKkmYohmV149pYR/uQlpAo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=nH1Hhf/m; arc=fail smtp.client-ip=40.93.195.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="nH1Hhf/m" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sGWOcmo+r/DMU27loXTvqaz/gkyjGfixWLwd8Yf0kfRsEoekc9e4UxPVk5ZVKjv6zsw2G5B3+tNHDGCFFtjs7/BsDpBpxar8fhqavG4Wc9TvpMjF2FuwyYxoqKf9LPmR8Q2rL7+foJmMmQbh/QYVxLI/ZttVlJqzZvVSe2GOHiiHVurMGLIDRK5daPHRUbzFMsTJVLbaddn4aZcNsLy1VIF76Ro5DKwnMDZbD/zE40YJiS7BuSNGRiCvbmkf/UU3SUF71TBdm+x4mo/zerr88jbUWnipYXegv7jtGb8ECsxLFGh2PxUMDR5ScT8SpaPspYT9Rh8Lfkl2v1EZRJWzXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QUdaDLXm87ra3aESe+PWAgGk2dCFEey7V9ArA9gPYos=; b=IOwaikaDkG1xeV0fsrCRGmqcyarerzbjFG2SWj1A9XqorZ/677jbToaspGWqSDegvhfrxCmla5Hn+xJmJxINFZwQebY2ZIWWSZbYM4Rn/RxRT+NUXYEk4fJUjEaANEEVZl1ew5G6ab/uTsc14GagIiPlckNOx+WF6i8tUT0t7GgsQYCAE6wXVTGzELdGp1zJI8HrpG3WJUByRHoi2lrt7A52+SdO1Qjn1Nap2cHC0f78C9WVj7x9Q/iUaHPd9MUIJZryivC/d1YWVWKOJLIMFmmYjYs3A62kx285xS9agYkanPyAxORbo7SbQz5AXEeB7BORCf1nEOX0CVRePpdOmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QUdaDLXm87ra3aESe+PWAgGk2dCFEey7V9ArA9gPYos=; b=nH1Hhf/m2+KkpKRqmo7z/nPIX47ztG/fn1SFRc4C0yI1gw9NNSTDLH2IoHuVah+6eNs2Tu+qQQrH/jqZxgNMazpkF2S7Uv/Piv76M/poEpuNCNmVn3D9afyLxpH1s2i0qE8HIRn+F77KkuooODyuGEI+3ISoeqKGPPfHUZbXOz4= Received: from DS1P222CA0011.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:454::11) by SJ1PR12MB6316.namprd12.prod.outlook.com (2603:10b6:a03:455::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.15; Fri, 14 Aug 2026 04:56:39 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:8:454:cafe::77) by DS1P222CA0011.outlook.office365.com (2603:10b6:8:454::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.15 via Frontend Transport; Fri, 14 Aug 2026 04:56:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.0 via Frontend Transport; Fri, 14 Aug 2026 04:56:38 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:37 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:35 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 5/8] dmaengine: zynqmp_dma: Fix minor whitespace Date: Fri, 14 Aug 2026 10:26:13 +0530 Message-ID: <20260814045616.1661199-6-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|SJ1PR12MB6316:EE_ X-MS-Office365-Filtering-Correlation-Id: 3fb098c1-d9e1-47ab-5b00-08def9c06ce9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|376014|1800799024|82310400026|6133799003|10067099003|11063799006|22082099003|18002099003|56012099006; X-Microsoft-Antispam-Message-Info: XGfeBjqxfeRODmIex8oNXIQHc/sRBj4tNR+EGQsUfZsVroIuqZwmnL1qtimIuuW1rsrepM3p5uvPkjJaC2LwTOcvL2fsiYd9ZbgTD1Vu7UOwLLCSdX0bthCSD57Ua7pLPWFGFTJcNRiIrDvtJfIVdyMOy3jSTz37/FNzh6ElyazwZmxfI/vqpB/xcR53bf65oIPn/u2rZVF8BI3AgJbz0fs4Z9Qhf1tqUvNC9MWqlguMSx0dhKNfILtqP5/nzW6CUI7tOeUINpFD3xaRYNQ4XgPsVMCgVxnJQHnyzmQKDeezUdwer0ZAwx3zqsUlEkSAysZkyW9DxnGbv6wO7NDucO1HqK3ef5F2ybhwYQimO75FJSACIb2sKUxgiCjtSGVc+pZ+2wP7RcpSbm81N32Ea4v0MyZl+XFdxRzdXo3v6hlWD5k5BAgSz3Ht2D3t3PV63fNuwPUwCa48xNI82rWtVRTEoTDh4jFkKxqydjkv1BfOtBz8KbIcDLY2GtCylwF/QkHAXZtKzUmL5ouadLCYLfMl6ks1xyCU5668/up+/iIpMcijcf95ZmAmGLT4euTQtVkPsxR2HYoDu009ccLEwrsbnSXN1xGeshWw3bZmeTAaXqr8fQ5ZPFnP0eWz8P2NZWqPexxQkboECOmcyy6xymLBzcLsogM6PNfNwmyt+URiY7IDIR4bzgDvOA+63A5ZK47lH1MKP7EjvMh8DbLWkw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(376014)(1800799024)(82310400026)(6133799003)(10067099003)(11063799006)(22082099003)(18002099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0uphHFDXkH4eFjQmj6PLXiQu9Rwrs153V9cq2uSzf2pi7JUpc1ITjlxyMByVM5iS1PF76Drr13kjSk89B41t556CqvZYfQjZGHBrpYmhR5gX00ix3kBPrFjRXI32op4pAZ8Jr+WJGnv4zTVIgmZMG/2lw/t5nwjWLuZr7kFZCZ6DjLtTQvd7sx3h25UnGPp1WNRSZuAd/iYslwRmr8kCIlfqU/pP1FzPUEmoEfo26r7AGWmQ5JCR3Htb9xtTGkoI2V5J4Hhj4TKwbYStJ7chAv7d61nl8g/rUVz8Gc6r2S6yXIFCu9uc35B4FXugraznPB44ax36+ms0nRHGocW/ZYPv8L0VfUb6Cz9rd7dOAhh5vHouZUdYCyKfG7zXAa78J4PeZx+q93xyor6/V/Mr+V1mw4xUG+sXmsVH3BvvT6ujzShiD8lrwNXa6rbkLUHd X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:38.8906 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3fb098c1-d9e1-47ab-5b00-08def9c06ce9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6316 Content-Type: text/plain; charset="utf-8" Add a blank line in zynqmp_dma_chan_probe() to separate channel initialization from hardware setup. Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- changes in v2: - Split whitespace-only cleanup from the kerneldoc patch into this dedicate= d patch --- drivers/dma/xilinx/zynqmp_dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index a2fbefbb43b6..5e81e0d950e8 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -959,6 +959,7 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_devi= ce *zdev, =20 dma_cookie_init(&chan->common); chan->common.device =3D &zdev->common; + zynqmp_dma_init(chan); ret =3D platform_get_irq(pdev, 0); if (ret < 0) --=20 2.44.4 From nobody Tue Aug 25 14:34:37 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012029.outbound.protection.outlook.com [40.107.209.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB0435CB6F; Fri, 14 Aug 2026 04:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683409; cv=fail; b=tcCaE/Pt1xFKJfdQXpJB/RdboFudkfAWuJ13JCdB0QH0m32IvwXyd+1R7HypuBb/XFPXLah9ru085PKp8nSINtyuOfZ2YVY/beOQVGMn9IkiEd3LcBfQs9MKGGXllw3FoePjrxurCbntgMaIZr2PvoA3p6gy4OwlzXZfsI3g48E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683409; c=relaxed/simple; bh=1KiH1LO+H5txy8jfqeuI5svWs0OVzDzCDsEIJ1dKCJE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DyEPpWRGGreD3iQDPpbXWxlas6zUz2jeovEk6R/SuygAqAbhtyLuO9WwkrT+iXrt1FpsLSG+7I397jlwYLnx/nIDD7Yu3ehelYJuRrFIgSn12o+yRkTdOthSWufwC/5E6ERazauKE0QOVFD4ZeY4QTQt/BFuBmi5vRq0IEuR/Hk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=AMFTL2aB; arc=fail smtp.client-ip=40.107.209.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="AMFTL2aB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=edAokBGtySjYmALgeGbzpL/I3euI+PAeJbCTdX4sLqgdqdbFzK4EDOUxPaxnEMhK7B6N5hGBwF8RFJJnVIpAQj3XBAIUrrYqQ9+GM9Vh5P1FNs0vs1J2vCYWV7U5aInuUbLDhj03vNSFGNylvKICmhwcIfgwt7XoDbg2t88xV7JWL2oJG+1STQ8Krxl72d6DGQ1z4H89Vmn3NOMKPCfE7ke0ereraf589j8eJ+8KJWUru/vcownlrkA1M4Yexk05XKdgKwI/mTs2sm6UxqSzX6IT/YI6U3MKqPcsUjQ3u5F8aewLfCfSZosIeS0lnrnvtzaCRNMmXPvMzNJy5zwUrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UKEQlEwZMjKmYBgoCBXyrvg9G6ParjLNFQ61kbn3HyI=; b=DTLDrpYbXCgn1TV4DAlty0VHe64Czk51rQAstQNqTVNPI/Pn/0CNfynAV5ql8iTdfPkr9s9oTuAEvOVwLHs663ovXmd4FpUQNf7jn61ZABcwz/Ip+BxMVHARzUiiYaBoFwsRfFHQ10Oo9cYIWiVKiiXJ+sAivqsBc41gxe8conFBh6H8iXIFqe/rAce/O+e0c0F5nj9ZBwSeZR26r3qXAnHwgD1KDC5vSNwywc633RDLFw724+BJQUdpnz0rFLXX56zyLKF5kJ2cJjsqYKfq0OiLM0VrEzmxX0Q/ic0ccnhfvqfDJie+WetAttdNjALk+CKAR7CgqIbT51M1PysgZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UKEQlEwZMjKmYBgoCBXyrvg9G6ParjLNFQ61kbn3HyI=; b=AMFTL2aB5f6332v/psJKTYxTPiRhCg5tyB3QiPikSci+vV15uL9TOcbvTpFvkhbsC6YvHrFKCGQe3ITuGmqjejyy0etY7j5lYWELKYi7GcMJcky+yK2aFv3TaMBuMYwhVRtQK6B/su7mnqGyMBGrhUKbyKJFFkeCRS912xI7WbQ= Received: from DS1P222CA0004.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:454::6) by CH2PR12MB4118.namprd12.prod.outlook.com (2603:10b6:610:a4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.15; Fri, 14 Aug 2026 04:56:42 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:8:454:cafe::83) by DS1P222CA0004.outlook.office365.com (2603:10b6:8:454::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.15 via Frontend Transport; Fri, 14 Aug 2026 04:56:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.0 via Frontend Transport; Fri, 14 Aug 2026 04:56:42 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:40 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:38 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 6/8] dmaengine: zynqmp_dma: Use of_dma_is_coherent for dma-coherent Date: Fri, 14 Aug 2026 10:26:14 +0530 Message-ID: <20260814045616.1661199-7-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|CH2PR12MB4118:EE_ X-MS-Office365-Filtering-Correlation-Id: cc12e42b-2160-44b8-0b0b-08def9c06efb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|23010399003|1800799024|82310400026|10067099003|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: pkT6inmWZy2cvHeAileYEubkGLoCXM99lYtOwB5ak+CXMFWjuTUihYvS+Wn5z2LOBkoo0IWUqAQwMmMAWc6Au5Pv0MSL2pbUvMi+4l/hljGkK7Nj6pE/Lru+yd0KZkxtc8ECClfKcPoJ9sUdCbOAWarxe7o06T6Haoqh3IV/3L7RTE3K2yaUuc3KbdblXaEVRUpLaDf2P8B+To6eMZlNJWGFwEpU25JVNjUSP5Mu6tSDRWKS15a+S9vuw7F0CHu4p/48BYvS/HqK/Vo+ykIcLcZBeJ5r90KbY04ckrrHEyxGr/QHCDTwbJK+URuvyVeN/6AxJ+jgs9yUNx7U7RyA02W/f9GrWEknbJUxaWACH+MKTSdhx1MWH4fTHNUAsVOJ1IY0i6jojaqfWvyW9lTdEsl71q4xXZ+iWn19IOmKdqRrSZe0uhnJOqJasJOwXW0kGltKPNVBNlROJ2jJil9YR6/5issBnl7t6UcaDyGpapmwp01U/Vpp22UEm/nzZeatk0K7bQp33QnNgtJi8ivdU1dQ4j0tpAsmSpS8Io3bEwdK1UsA2osFcO8J3KIuJphl+dXfgtoGT/4E7NwUS5eOqENiQfQnoPzzjX4S+Pxpri6KaoGLhf1N4/63kfDfX54LOuCsE6T3VJLt8Wm1MIAg+NEtc3crJKedQwz1iz/2l1uvwMtrEnkpvgU85OYBdAs73edsELPdJnQvvrlOlt1wSg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(23010399003)(1800799024)(82310400026)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mBJqZF7hi5cL9jRAua7SA64d6poKpcwuo48hPbLLcQRZjwtnx3cfiqyIABWQY1O8j0y5GEBMiGqLTcaNPB9Ym2wKQtPI3n4TuiX4aVxyQ403IXivAs2eAJ/9AqpDZjtfWAPyytiIKBXBjkZVORuxc/6kxDpr5GddwNd2kuvQyAyw+usS+Q5eKcdGmLw0eI0rus7gmXgX4XGj7Q2oojSeZVYscJVRZhrhBw6CKJTwtoPUCaJSKg7gi5Pgp7J/wVikz4PPPcMSj5SzXibZXJ3c6sQClzDbYthp1W6dR4x2Jf2bHhQH0TLPg7UgGHw0IpWhVy5GHFTXVUT3OPqqzw6gTpmVblBK8R/+Kiz8jnmslCrv4kLXBrQrdzo/Ejq+HahvaZpYyJb++x7YnNEbnQm/QpU8bDJ/SqTDhhP7FQMJnDWFMH9JnuY01vw9pAYc2nrQ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:42.3621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc12e42b-2160-44b8-0b0b-08def9c06efb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4118 Content-Type: text/plain; charset="utf-8" Use of_dma_is_coherent() instead of parsing the common dma-coherent device-tree property directly. Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- changes in v2: - Added as a dedicated patch based on review feedback to use of_dma_is_cohe= rent()=20 for the common dma-coherent property --- drivers/dma/xilinx/zynqmp_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index 5e81e0d950e8..194abfd6cb25 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -947,7 +948,7 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_devi= ce *zdev, if (match_data) chan->irq_offset =3D match_data->offset; =20 - chan->is_dmacoherent =3D of_property_read_bool(node, "dma-coherent"); + chan->is_dmacoherent =3D of_dma_is_coherent(node); zdev->chan =3D chan; tasklet_setup(&chan->tasklet, zynqmp_dma_do_tasklet); spin_lock_init(&chan->lock); --=20 2.44.4 From nobody Tue Aug 25 14:34:37 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012038.outbound.protection.outlook.com [52.101.48.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BF383655C9; Fri, 14 Aug 2026 04:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683416; cv=fail; b=T4rCSAeU1WOgSJRTix/VYBvVUCOGiOX/nddn4QodiTje3+1AkrUHAePvYtJbeeXdQ/z1FZFlTxyml/3o7fJX/SBEx0mMDMRc1e0Kavlrw8vYVSsj0YFnnjUliZrMBqeSCFVBhkFNawwIcBS4qkj+pfodrNlZIVzFIegTNBCY6Bc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683416; c=relaxed/simple; bh=d455VKLTVwZZSnxDFxjHTU5tjoQ2qqCRSdXRolttdnY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p7nQVrNctz2Yb1BaNKwkK7qxJgXCJBGYFrqL3dG0z9HK1zJoYwinBgfNz6QG++ETTfXRtM08g6YtZ+gkR7tAFadpZMN7AfhLY/EYlaE0P5zWs4xw2xU5YKU03HEp8bzM/xNrNfYyc3jtCg4TUeC8LZK9JKVb764QxeFj9El3GlQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=AZZPP7YD; arc=fail smtp.client-ip=52.101.48.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="AZZPP7YD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b+++EnExHYS3l6saQqoqav+Hvachw9ESZEU2fr8vhHiXbhs9ZknH9XGA+gaaq3WugaZe3w7UCwkkrIPjgWxJapekSwfOGJIMow8FcEFIwuyevrfdTDFaLcmynoOjI/U5yktjMj3ioGAb/YczGPK8MUrMAKR4RJPtE9/tlNAGmoocdFJfFt7EKZn47Ivbm1gnbXZvL9Xyfrh9WP9HYBEusPH5ZsJ1fuMCLPOMIt/c9XNwV0ibYhIHHsmf3t5GdPIOh/vs7Xl4XwKv18vxkilLkWJj4mW6UeCyUagFGScI2RZNLxNMCGiFnq5XTbto4uJRxPJJrNjO1WzTCyvYco2I4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2w83qc5TmicNhbJwH3LL3cy3JhQtxVsFPjPDQ5bffRY=; b=XZeqg0BWAvCVTc0RjHoPf8kw4WPwA8MC5d5SxA5mfe4iT3nMD4FAaG9k4kBwmbvet9WUA2d7rbVLOkD8cx4C7X96dOT8RoTIqyvlLHYeAFwwQ9Q5ECw32YmgzzAMntaumeylQE4Hfp0hKoM+JTCXerJqYP8uHuhEUyHtz1ZPgsoAshrzzwNFzNJC3n2DT1y9A994akiG3nLbwvDhEp+orIdkCfYBo3xeElPyl6GKQ1YooRf6rgmGe/H30KDaNzKROmnXRPLYyncjhw0mDvq8j2nTUdmGuvvLsFRJSoY1AyBtpiKZ3ZXgaeoNxywaD2b+1JieWy3ajQhCJmAbtUP1NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2w83qc5TmicNhbJwH3LL3cy3JhQtxVsFPjPDQ5bffRY=; b=AZZPP7YDSedK00d+RNO+S7D9HRN1kKkecmJk4lSZ/nLXanFo7+W6m9xJUrO6dtL1amy55PcPyUoM1s0SMN7SX7+ytCL13ncxt+Ih1bfrQPjAAjDWWfFYP/E1MTLDIrWlTqWfAMfmbdGDaX0Sh+Sjm6jbxxkFJtUxRfi6w1/IEv4= Received: from BN9PR03CA0399.namprd03.prod.outlook.com (2603:10b6:408:111::14) by PH7PR12MB6933.namprd12.prod.outlook.com (2603:10b6:510:1b7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.14; Fri, 14 Aug 2026 04:56:44 +0000 Received: from BN2PEPF000044A4.namprd02.prod.outlook.com (2603:10b6:408:111:cafe::68) by BN9PR03CA0399.outlook.office365.com (2603:10b6:408:111::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.15 via Frontend Transport; Fri, 14 Aug 2026 04:56:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN2PEPF000044A4.mail.protection.outlook.com (10.167.243.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.3 via Frontend Transport; Fri, 14 Aug 2026 04:56:44 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:43 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:43 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:41 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 7/8] dmaengine: zynqmp_dma: Reject zero-length memcpy transfers Date: Fri, 14 Aug 2026 10:26:15 +0530 Message-ID: <20260814045616.1661199-8-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A4:EE_|PH7PR12MB6933:EE_ X-MS-Office365-Filtering-Correlation-Id: aa71fa25-09ea-4b9a-12f5-08def9c0700e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|23010399003|36860700016|22082099003|18002099003|56012099006|10067099003|11063799006; X-Microsoft-Antispam-Message-Info: Xsrc17x6uLIEdMSQqbNPNY57bS9g4MYy53wa9wcfZVOtzQjyCUxQTZUNbNvQboMH5eRZytnarFim1tu8DOVLQ6l5JloLC1SBFr4v/bnncNeRbgV9y4HmG7igeZjDZ2DZSqHOYAXdnUT6aWa5hIyjdzyN4mhSgZZ5rTZlQ6H7ipK0kr4l5iQnnblDWdn76gq3evwnRmJZBom0QSNkEm1LxeJqGsg8DfiSAKwbmNJFnapBSijIDpA8EciD+Lco0ANApoxbzkdQqhKQi9pPBWliUEDkmFws+bMDDBhwlsZhey04Hd2itbCfK9erk/u0YgJdxw84HnbXdJA/ivfvl1opIyFI3VZaE+exRsADzaospLfoIJv6EXjX6Cp4cVvkp8A9SX/LNAGOw4uvwq3Cs03BBRmPKO6GyUG+URYb8eQrpw7iLockA2S4AMpDTf6Zk38TYrO+cGDnmr1btLUAmrCTzH0JyVQ90xDRwLATRfh7FDEMQbmEyLkZxabwcIHYnPSGqoRFEoWrJEBTUFTf5LWp3tllbfyeAddzC3wzHsyrw+qn/5tDVdg5y/GTajPPSMgA3+oG2CceYGQsGT4KsSLaLstEEjURzFlV7w739kHGp5e1Zxu1K+bBAP1Iy7OTWkeE29/h+a+7zDShxrvSTvy+Ts6AzGl6docbUjLpwmMdFQx6pULmgVx0GIv3TdZXHw4JrbNzFQkIGZCJbJwPrGWSag== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(23010399003)(36860700016)(22082099003)(18002099003)(56012099006)(10067099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NF9vQuWIvLQwRQXD5XbLaDXjYYSiINk/Oy3A11aFWl5ZqpKai464VjXDypUCJFHUIXBZtfo4uOSco8aQw1sbc6DqvXOizh/LE4P6mFPb4PneLHERB8V5NOKzpfe8ht8Q3nWtyCYjENRqEsm7Hodz1o8g1Y0yLe+BdnB0drmxaj+T/s0cS9asgdvvBOyexcEpCPusfYldw4UvswcSETp08OBtaCRhN5+Hni28+E0g9SFyT1CDfFh8FIM37bPcdc795FuK1l8Y+QVUs9wmTd7dG14yBHy/i2RKADeRt6L8gaxioeCwvWea4KhQ9HnQdtWQndXl9gd0Gy6e+jW7ZTHhEhEdfbAWRFeV3CZubbQSiI+QEBQh91DEXg7Zf/5tWX4qMtqP3OU9A8oQAieiY1ZZqxa9BGUI8e2zwLFM9Trogz7Gbuyiyo8Ifb/xxjTfFJat X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:44.1756 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa71fa25-09ea-4b9a-12f5-08def9c0700e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6933 Content-Type: text/plain; charset="utf-8" Zero-length prep_memcpy() needlessly consumed a descriptor slot. Reject zero-length memcpy at prep time and document the behaviour. Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- Changes in V2: - No change --- drivers/dma/xilinx/zynqmp_dma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index 194abfd6cb25..921d3d9f6ed6 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -837,7 +837,8 @@ static void zynqmp_dma_synchronize(struct dma_chan *dch= an) * @len: Transfer length * @flags: transfer ack flags * - * Return: Async transaction descriptor on success and NULL on failure + * Return: Async transaction descriptor on success and NULL on failure or + * zero length transfer */ static struct dma_async_tx_descriptor *zynqmp_dma_prep_memcpy( struct dma_chan *dchan, dma_addr_t dma_dst, @@ -852,6 +853,9 @@ static struct dma_async_tx_descriptor *zynqmp_dma_prep_= memcpy( =20 chan =3D to_chan(dchan); =20 + if (!len) + return NULL; + desc_cnt =3D DIV_ROUND_UP(len, ZYNQMP_DMA_MAX_TRANS_LEN); =20 spin_lock_irqsave(&chan->lock, irqflags); --=20 2.44.4 From nobody Tue Aug 25 14:34:37 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012046.outbound.protection.outlook.com [52.101.43.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED6A35CB6F; Fri, 14 Aug 2026 04:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683413; cv=fail; b=WQ4TKS+V5ZFVQ+tBJbYafx/yZ8AC1wYcElRF/pUZBEO2Swfp7fbUnicDcVebYu7Usnqm44Q72HJWUobYE03CxT4vja3hv41fYBURp6IjGePuiZIA5RbN5tjEsMk4YljHT5PW0cd2AJMZEQea4tcygvWphbr0F7J9+GV9rdmt92U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786683413; c=relaxed/simple; bh=LsM3983usFFrmZ6P4WpWqHAkPhT5WR4zK7LBQVVzKgo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=suDKkp3ReAqLZxqeDsY4dcc1Bwhnk0doTH8XWZPW7bG9d4cdE4GsEm+usPC7dYfz86KVvAsTXBwlvWsd6CIFz/DMC1XzA2UFJl/vJmJZdghaFbXabAbOOYgttF79S29KBsKeCgYduwgBQM/piALE017kLHYAiSsWHdqw/urI1hk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=yjzIDSNj; arc=fail smtp.client-ip=52.101.43.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="yjzIDSNj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ay9Ir+QTI/Tgk6flhuUqLs1VkQslKRnv/uB1pgmjruy4ir4VZKfMyHwxVkMR8mJ06BEnmo7wwJa/n3KYgiWTLxaq37v+c6K5XcytoHvFd+m6Ht34ebm78u75zKMzE4plbYVwEwGlO+hVJHTuCrpCF9BJvjJFivScCj6I4TGD+dP9NwdclrLwC8EdAIq1RPgFQfyJyhjA/0sQGb3mu0lTZ2LscPcaPAl2HzFoKX8jYgOljiLnRpjuN6U5eDUuonKc9E1gPrZxqMlhD2GcmJbRhgbsD19Wsd9QeLweYds4iKHIaHpcinUPHU3bCjBhPuW3Fj2jEDgXfKIdLekohB1ShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UBQk1MA5V172eRwjlwGrAmqOYoUmM+y8gGMOO5nXIgE=; b=RGzn8N5nLWIp8sH59m+f0pG0v62Debn+uNRTS6X8xRrTUQB3orZpnXW4YgwaMkQQ+hT2PDOtoaJO8BfuF4o53nDY7VveAUIgYWRLSkULGpE5Kdgt3+n9j/RYIodphE9q8tqUcJLB88+uj51nmL5XUhscruNiTltmuyP/sDM2WJQzlSaBtslVzC+L5Og6JkHrpUsb3czcijzSCe1chJl471FoOLYBTTDoamK0enwUyajisE1qsSwcyWmHa7F0BkTSjvRzWfW+WVTkHbGh70R8CvzTlFmGzER6uAFBOsF6Y4iXFvnaVSukZ6G8Obq+OZDvMASypQhSYarRGiD9XJYuig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UBQk1MA5V172eRwjlwGrAmqOYoUmM+y8gGMOO5nXIgE=; b=yjzIDSNj6cHhkrVRzt0LthcCUvU94YQLP/WgvBo7ZRy5QZN2VYMroy4Adsu43xiHziXp/52fepU60CowzIswDb+R9qdQgLrktIQXcd2CQ52XbAZQP499HgVIy5pk0YD/NUp+ffcrSTX2dX9BvioaH9GDL4T5HYE8pAtQ8ZzpnlY= Received: from CH3P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:1e8::11) by CY5PR12MB6106.namprd12.prod.outlook.com (2603:10b6:930:29::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.13; Fri, 14 Aug 2026 04:56:46 +0000 Received: from CH3PEPF00000012.namprd21.prod.outlook.com (2603:10b6:610:1e8:cafe::94) by CH3P220CA0029.outlook.office365.com (2603:10b6:610:1e8::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.15 via Frontend Transport; Fri, 14 Aug 2026 04:56:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000012.mail.protection.outlook.com (10.167.244.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.0 via Frontend Transport; Fri, 14 Aug 2026 04:56:46 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 13 Aug 2026 23:56:45 -0500 Received: from xhdappanad40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Thu, 13 Aug 2026 23:56:43 -0500 From: Golla Nagendra To: , , CC: , , , , Subject: [PATCH V2 8/8] dmaengine: zynqmp_dma: Remove unused define and duplicate IRQ bit Date: Fri, 14 Aug 2026 10:26:16 +0530 Message-ID: <20260814045616.1661199-9-nagendra.golla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260814045616.1661199-1-nagendra.golla@amd.com> References: <20260814045616.1661199-1-nagendra.golla@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000012:EE_|CY5PR12MB6106:EE_ X-MS-Office365-Filtering-Correlation-Id: 495fae45-76b2-4ddf-8d3d-08def9c0718a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|1800799024|82310400026|10067099003|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: iWwhjuDgWmSFDpHme1uVcLvLoT1X64DxSqUx6RfPfJWW1Xp8DJaik5oRDLCiV7ktKKmOGyoAhdHH2yI+7tve0LzezecOqrcZPUmmuIMoYr4opzodky4DMjckaVjMMt1saKFh/IZRcVN1CVhsY4JDEhFz19d6HnlzflGWCzT7KPYVKDSyWRRavpc2sZHCKbbpweLVwWaPdf0tZi1v+WcBB5TmRrzqfnFYJth9T9MYYVL2WZarvz9tlq6dayHD4TZ7LttKMuTHCWHdXdoX8ueIHYldsExXAQN23BGDK3dgtn07SpDeEoCatgMiQ/tVCU3R2xSo5NmolZoVVHbh8A2F3mpb/jtBc8eMKpJUI+Butm2G9FGPylCPfjPBonZXrei0fsu723BHaquVtx0og58QtA+zGO4qc1KOjo+M6b5QrhTk7XuLhidDcUbqo+ZXF7ZoeH90paawE0rEE7HdmwWtGbr1J39eapijWhYnIqZhLpLlGz6w5/pOTUVhCMrxU7dvVsw2zlJLSZGOmmGtQvvyfxOxG3UUx+5Ex0WoNAKyn68iA7hfyd1UvkRc+9sNN8zuNnFXnf2REY/FfPJ9+SU/RR8cHQ246U9Q5LOnVQaIw5OsUH0Je8IydoFEt4AtwY6t6DkOCPw3cbsj/S9OHft3DbyBOYONz1lWWUqVHgf/qbUcIPK97D58Wq+v+31Qrtj0I++Jym+WLUcVOTxwre/s5g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(1800799024)(82310400026)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CG04vl13V81VD6SqNKAE8BndWjzAFwaU1vzGir+0sSA758pVrdlbqKEh5rcUTmxidGMMpiHfNZu24SoZnk3jWHbaJPUm9idk0hP6WWIoV1JAYwBE0SxHYkZbxZn0G1hvrYWzJ3rTbGFOYRyjBbpUgwUPV3l5KX97npfqe29AWY+ah+cIoeMT5mYp/XJYzYDv0rODPeE6fXVyx+Vdqlu9rS4VJiEXr6gnK6eHKXLoOr7oO6oSpE3erjykExYWvp0Xn+dE5wHRwEM8Evra/oA6SAcSi7/7sbp22/jARa1Py500NjX70nTtxAuYbSNCa+Ye3Ucln3mgnZty/IwN0bv98kGa29lFfznZo5YDfKOEGY+Z3D0s6rsA8qNd27IKAgN0zzMESilXC/5CNmfU2L+v5qshvSbMQzm34dkcV82QsA4PxvXSR68UKucicZE8bLdB X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2026 04:56:46.6524 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 495fae45-76b2-4ddf-8d3d-08def9c0718a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000012.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6106 Content-Type: text/plain; charset="utf-8" Remove the unused ZYNQMP_DMA_SRC_ISSUE_RST_VAL define. ZYNQMP_DMA_DST_DSCR_DONE was also set twice in the default interrupt enable mask; remove the duplicate bit. Signed-off-by: Golla Nagendra Reviewed-by: Frank Li --- Changesin V2: - No Change --- drivers/dma/xilinx/zynqmp_dma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dm= a.c index 921d3d9f6ed6..b2a9b60f3052 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -113,8 +113,7 @@ #define ZYNQMP_DMA_INT_DONE (ZYNQMP_DMA_DONE | ZYNQMP_DMA_DST_DSCR_DONE) #define ZYNQMP_DMA_INT_EN_DEFAULT_MASK (ZYNQMP_DMA_INT_DONE | \ ZYNQMP_DMA_INT_ERR | \ - ZYNQMP_DMA_INT_OVRFL | \ - ZYNQMP_DMA_DST_DSCR_DONE) + ZYNQMP_DMA_INT_OVRFL) =20 /* Max number of descriptors per channel */ #define ZYNQMP_DMA_NUM_DESCS 32 @@ -129,8 +128,6 @@ /* Reset values for data attributes */ #define ZYNQMP_DMA_AXCACHE_VAL 0xF =20 -#define ZYNQMP_DMA_SRC_ISSUE_RST_VAL 0x1F - #define ZYNQMP_DMA_IDS_DEFAULT_MASK 0xFFF =20 /* Bus width in bits */ --=20 2.44.4