From nobody Tue Aug 25 14:34:12 2026 Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA6963D3326 for ; Fri, 14 Aug 2026 02:26:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.34.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674412; cv=none; b=aj+BXN6QJTyfD4kZ+jXR1/AylYtHFdl9VvGBIGMjexNyErlwAnxjY8Yw317ZNRemNQIT2wL7eFyNOuD4x/pwQ0HBa4CTxVL59W6uAU1Moe74JHycawLW/EPDfcp7L7qzwzBcIwL3sBquEhSeP8g3SNz4ODCSLfL/YXsgQ72EXQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674412; c=relaxed/simple; bh=F/4l4uC1TJj363BXewZpAtIOagfIUhC1W95a/e7S2dE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=azRyJtfbU2TsLPyN99T4ywXjsI1bljZTtUFwp3cjA1Jx25PoKa3izX1OPSAOy4wzD5GsBs5k6prfd/PYtSB0gw4UtgyF8Tql8QDZCt0FrfMPFQ5teh+WpvbEEYt94WXFkuIsnYmNShy6FNgjJ2NvIapbuXrjgRxBZDThCbtT27M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com; spf=pass smtp.mailfrom=airkyi.com; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b=Ayg2j/u8; arc=none smtp.client-ip=54.206.34.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=airkyi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b="Ayg2j/u8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=airkyi.com; s=altu2504; t=1786674320; bh=05fYjb00YYXJ31+phLSkqPQi+wABn/rqNlkF5fHNFZ8=; h=From:To:Subject:Date:Message-Id; b=Ayg2j/u8FPvn549nWWSRSiWFs5ivamzvBnJ51ppvO/9rD3xjw44bMeNCzT+/pBkKK E3iMPZPwzP6j9edqXS19Cjbla/rjZc6JaRkqIrmcnLehIWar4VWSmHDd6WW1J/2B2d 9fu08lRr+7bvbmfFXgFt4ScIJYvIeIoj5y5qr8w8= X-QQ-mid: esmtpgz13t1786674312tab322716 X-QQ-Originating-IP: 4bqnD55VqWoLJQzWwMaI0Eywi9ybW5lEk3/kjTWN/vM= Received: from DESKTOP-8BT1A2O.localdomain ( [58.22.7.114]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 14 Aug 2026 10:25:09 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 4802896716217213205 From: Chaoyi Chen To: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner , Jeff Hugo Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Chaoyi Chen Subject: [PATCH 1/4] accel/rocket: Fix the IOMMU domain leak in rocket_ioctl_create_bo Date: Fri, 14 Aug 2026 10:24:50 +0800 Message-Id: <20260814022453.437-2-kernel@airkyi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260814022453.437-1-kernel@airkyi.com> References: <20260814022453.437-1-kernel@airkyi.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:airkyi.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: MbYyxy1Fep3Pj+UY4JV1dG8p4VtqC9gMYBVZz+li+uKhqy5kVO9qNBMi oGgcABFbN1HEf7XpHrBghxEeNVak2WZYJSXUHyXGZhgW+HyXTGlobnvR/2GEBgZqKYrDmzG Qd5o1ZFguNdgBDvYNpMldeG+sch2yjN67T0VfGS6HvL48wraXGJrC0IzIRvPgCgTDKNATI9 kFU2/4sIzSSfhT/C7wzxhfRMTsbYPat8heBrhbWoSl7MBhZCE/YB5vWJhQy108XzNtGxECV C5CDskUWb0lmAA1G/ypy2y1vR/3Dk4DuxjyUYQKpYLPe3vWEA9Om1kzpY7Ms0WMCzUPb5qh CDg47DEAVnVjLaI0VTVH3wzvitkMy9pyDutTO5TEqxLi2kMPEdPE7SxoXIyyLPZC1VYQY6V xeLZu3B57otVVMcFCNxfJmHr7kR7oxckeicSC303fVD1CCoiTiwfgwMNPbPDFEv4O9f+k7R HtajO7DS192xmtE6e1kmQcQpnJKlXnhDSoxh4JgwP1TebOvbuEgu5kcgRoMOMuvsM0kEkiM P/JekH8KbckiK9N6BC9dY1vEgQqv4ZL6YQxZ25mstECHVm0+kTFPsAo4nccE9iBwUCPsrtf dJqOn+ffJaVAjNvN2KKbNJvaZb2/WGcHRkeuVxMI+EguZQceWq89v4yul+r+G54KM6+PzpZ Mvi0AAyFszDgRJZ2kODDtgDFf24KD2TyXQENxrUuWq7bHyK96iYF+2UTyVkWAOoYAB2gFGG ZN50cEbIkOl99UFd++ZFS3BorQowk1gQ7Vlt5pa3LsQXgAQGBiPwvvhiGA9KZLXhuFOLx+9 NSlZXnhZmUCG5hRjecfQe6VmDVy4/F6YEZoqEaMhkhdJ5WgtEBZKeZrE0nc+Ja/Qz8AWbq5 DzinlHJZVOvyDrDDoEJt3wnMoSALGGSku6y2uQGYvxeDhwCgEiHYBSYpr5m/tQDVtZF9J9b 2IDeDJjt9SkvlO40DrbIq95+i2Ged6SBdgyerVTohUYJTeauYYeFAKyLBr/TLFeh4lOPDTx kaOpQfClD0pYBnkjc7 X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== X-QQ-RECHKSPAM: 0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Chaoyi Chen When rocket_ioctl_create_bo fails, rocket_iommu_domain_put should be called to avoid an IOMMU domain leak. Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation") Signed-off-by: Chaoyi Chen --- drivers/accel/rocket/rocket_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/rocket/rocket_gem.c b/drivers/accel/rocket/rocke= t_gem.c index a5fffa51ff35..438694ba567b 100644 --- a/drivers/accel/rocket/rocket_gem.c +++ b/drivers/accel/rocket/rocket_gem.c @@ -127,6 +127,8 @@ int rocket_ioctl_create_bo(struct drm_device *dev, void= *data, struct drm_file * mutex_unlock(&rocket_priv->mm_lock); =20 err: + rocket_iommu_domain_put(rkt_obj->domain); + rkt_obj->domain =3D NULL; drm_gem_shmem_object_free(gem_obj); =20 return ret; --=20 2.53.0 From nobody Tue Aug 25 14:34:12 2026 Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E93592F8EA5 for ; Fri, 14 Aug 2026 02:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.132.163.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674391; cv=none; b=XOFQNmwnGCTeEZvMSDBgP9Y86BfhjqYzeAh+coYHgKKvXxB2v6LiJHBFqSQhNXhblg9Lv6rwBNK651lC3c8xI49ikUe+z6F0BFPWzDRo+8rmoespDsWk643VJsbTFEAvDVOUZNqCbyP23GanE2evLMijVvNsobfXGXBQBvondpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674391; c=relaxed/simple; bh=b8v6+oW8XYPcf6Ow6JOeBzc22azMIzP3tvAuSiEfzTg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=egxH8MxYTsxJY1Vy3ccckdXlxxOMM2xsiHkkS73Fb5CUPoIapZh36s1TedLjyfVRTnBKZz4Z4Z3MoNQJT6J1uac1u/eohKTbNoL28f81dluH9hvIgEV+nDubjBcpzcEAHpFwTZBpbAZ8wDUklHz3xV6qRpcd56Lr9uZeTo6cX/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com; spf=pass smtp.mailfrom=airkyi.com; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b=GE1+24LD; arc=none smtp.client-ip=18.132.163.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=airkyi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b="GE1+24LD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=airkyi.com; s=altu2504; t=1786674326; bh=/o2N6AOO5SDPq+gKcLIfQMliV3bDPAzt5Mxh6KWAXg8=; h=From:To:Subject:Date:Message-Id; b=GE1+24LDg7pw527IWxCXEWnC2L8KWfVuxPyqdIK6gl7EvV2vplNi0QKgg2Ya0iaP1 x3sjjbOkyxxEMXF66VboUAjcIG8vTBf31iXun6e3nJ/uC/mfaohiGjLnRA7f1QGrKL +pfa5iOf5rkNTdW+x8D+hAbMu93lemZogLmHdd+k= X-QQ-mid: esmtpgz13t1786674316t587edcb4 X-QQ-Originating-IP: ShomYSSLc05a5nnPIAHJ0xSIToXotN6/p8YKknY9MSg= Received: from DESKTOP-8BT1A2O.localdomain ( [58.22.7.114]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 14 Aug 2026 10:25:13 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 9044457741757422384 From: Chaoyi Chen To: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner , Jeff Hugo Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Chaoyi Chen Subject: [PATCH 2/4] accel/rocket: Fix the panic in rocket_iommu_domain_put when the domain is NULL Date: Fri, 14 Aug 2026 10:24:51 +0800 Message-Id: <20260814022453.437-3-kernel@airkyi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260814022453.437-1-kernel@airkyi.com> References: <20260814022453.437-1-kernel@airkyi.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:airkyi.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: MMnP0fEUKo/h07zcrFdjgHgf/shhYqtpl6SZAKaSVnzuyj8lnkpO3xHu 6aBCLumhL/h19tcS1WCAsjwRfyZbJDIUzUd+YuTfU7Gu/CnyASgNlr8yxLgg3w72ccTHnD1 0/SUMWW03i0+epR5p/IqR8pb0h2o1/a/D+VJ231UGKam3/RLmGL7VAX4E8E3Wk0bpT/jmlO VERMZFZ7HECKDbjVSxa5Mdt8VjWQXJwFwaRhhyqQ5rrQ4wLmwp1J3c38KOE/VQ35Wu5tkA6 4+jH02CT7DwPHqrwulb+1dzLAvpOjICttE8KeWUgOI3rErv0LGH4IwfpmZyBZNBq5V0ZRNz kS5T7+JuKd/Lk3jYx4ZKR7g64AcekD8+MrK+dfqsVpNlavneCl6IGVOork0sm8Yf2qehl5m U0cFMtrBfgOIqsBij1R80CavEaerbs+FQK3vT5Oj3smBKfZh+NDHbNQ0lEp2hxcWWukj75A 9sGjl9g6ZfY9kf8/5cUw7qhC0a7ew2JI/RdiK8zcRApPJHHZJ+tuRg4yIiPyf4A4DPd8l32 /mnUkFhKcwtJGO1Y9zySwalT7AMmuHvkjMaC/gPc8J+MD1Y8stLyWHstAG7cKTveG7rjWDv c83/JCDgkblmmTwQNrxvaOJ4W2X3yQg2NJFOl6uuZxmlyBHnZqRtNMSn6LeXyEB9DCl+GAK Go033SMoiE1gI0yiKuk8DvHUAYt1jOnHHvxGNebXQms5ASwrm/DySTuP6gzQmETcWVJZv0x 7++0o/vDOwIADS6cpxbfClh/hZsrOEYF5AUHJgCKXCe2kbbfII6P2nZBLxdrQqqK+fFld5j h9ssZFAN3ebmkgNfDY5NFbhS2MIIcNT+lj6+B8+E4IUen7xvArban0xySrvkmwZiI26oBVu TJhTvsakEapN/twU3tb3D0MI+w+ffz/4BGFC1AoJkb2sgOZz/fGs0JlFS+TCWQa0g4jEg1O rMle7786GtmWJfKc2YNYiT3LBiWah34zos+9dtoSyt419sO/QKyglRY3mBCn/wMU794GKru pM708hcCAyh4cT0aCo X-QQ-XMRINFO: OD9hHCdaPRBwH5bRRRw8tsiH4UAatJqXfg== X-QQ-RECHKSPAM: 0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Chaoyi Chen In rocket_ioctl_submit_job(), since the domain is assigned last, an error before that triggers rocket_job_put() -> rocket_job_cleanup() -> rocket_iommu_domain_put() with the domain still NULL, causing a panic in that function. Therefore, the input parameters should be validated. Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation") Signed-off-by: Chaoyi Chen --- drivers/accel/rocket/rocket_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/accel/rocket/rocket_drv.c b/drivers/accel/rocket/rocke= t_drv.c index 8bbbce594883..77cd2ecce001 100644 --- a/drivers/accel/rocket/rocket_drv.c +++ b/drivers/accel/rocket/rocket_drv.c @@ -65,7 +65,8 @@ rocket_iommu_domain_get(struct rocket_file_priv *rocket_p= riv) void rocket_iommu_domain_put(struct rocket_iommu_domain *domain) { - kref_put(&domain->kref, rocket_iommu_domain_destroy); + if (domain) + kref_put(&domain->kref, rocket_iommu_domain_destroy); } =20 static int --=20 2.53.0 From nobody Tue Aug 25 14:34:12 2026 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E2203914FA for ; Fri, 14 Aug 2026 02:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674398; cv=none; b=IOY/FZhkYC+CiOp6n0V5mt2/X28JssEDiS05v5d7VMI+lQVue1DEQtziao6X4xd2BI0F5SViAz+xeDAEfH7OHx9IvB9ga1j9RqSq1wyCjDZr+qt6f+W+/ySLiC96Qm8mpGfcqgXwB51l6tQFmH3TpJ+iZh10yfay5Wov2Y5V4Cw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674398; c=relaxed/simple; bh=RSH0kCD1nbcyWDW8whSU4Br/VbLPBzd0jiN7RFfN3pY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=rljJUf2NiHkGgdp/Sug1EI0fcdFq3wk9C0prW2IUHcbX6+bcLNy32fihPvJJgzuNq10vBmLuQ/1pO5J6BGoPpmY6+e7VYxpZAkb3ghpaob+VRT5Q/+342pBx2luxfQNt/6EwIR1BsVuuVU2FcPdCbajRP0oJn+U0jb9fMJIR7WI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com; spf=pass smtp.mailfrom=airkyi.com; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b=mdonYydk; arc=none smtp.client-ip=54.204.34.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=airkyi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b="mdonYydk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=airkyi.com; s=altu2504; t=1786674328; bh=+JHsOsDckHVo//w2VdgCEPkkctFcuV1bEYTIhxBYox8=; h=From:To:Subject:Date:Message-Id; b=mdonYydkaZWCy9rPc3xl60ffhU8oiCOL31GMJAkhVcNqN1ZtlLS8MMPQqa0LIvNAT pH+VR9m4NvAFMSkp+aFNIELoH7iDxMb5/3il03Q7WNx3zZVrslK65OmsgFfdATwd0H XR38N97qhxIq9fHBd6tIjFx+W5YHHHBBHKDZA+W8= X-QQ-mid: esmtpgz13t1786674319t3b7866cd X-QQ-Originating-IP: GlwC8Vr0+V7hKAQdo72tO4IUyru3W/s/wqJTId8HJ4s= Received: from DESKTOP-8BT1A2O.localdomain ( [58.22.7.114]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 14 Aug 2026 10:25:17 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 9741115489482611219 From: Chaoyi Chen To: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner , Jeff Hugo Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Chaoyi Chen Subject: [PATCH 3/4] accel/rocket: Fix the extra iommu_group_get call in rocket_job_handle_irq Date: Fri, 14 Aug 2026 10:24:52 +0800 Message-Id: <20260814022453.437-4-kernel@airkyi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260814022453.437-1-kernel@airkyi.com> References: <20260814022453.437-1-kernel@airkyi.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:airkyi.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: OSUW9vQLVhiZnVnT0iJ0+gB+gVXLNLc+u2f6OAwE7CJ5njNmd42e20Ut latgoRVgYiij1hDnX0WX3lh2+rd9DNctZgne9HlJTbUM3Ia601EDVm8mbxyfFc+2ZTHJMBN f8XFMcgQGKDXGoLDHeNkRBvFJChIJwUn+jXnDEYPmBhM8fdQ7e8VH/lfRIc8nM8fHSnwXIA h/nQWo4wl8VVtx4VVMDBbwhFkDnttuwAxBpoum80VUOb2wGgh637zTuHGWtFoXOSfbEsoiW JCUogacEmy90vVhQO7U+V6hrXlQTp8fNsm3Jp2tp3P1hh5L7REpjS+JypKJdj+V921kjxOI FxdeluE9nHXczk8tES/frfnaGm+FiT/Le6d0tEZm+kA8pODTOibcmD2lWHHkOSjdaQ3OFAM M/kFDI7kSGsMYV/1Rx8EGqvpc+aE4U7Og1wlUhj1md9NmLbpyfv0AclmYF9OcEWBKSoJKaU sRg9vzD86KPBBXo4+XN1QCC01llJpEwVoCMMMryW7J1yEzUB6huz99AFvEb8F/Ns/HEzIUM Ypyv2yoHb/sedSdOa5eFgC/tHpb1yRKUbrT6J8aVlx2GRaIEpH3XUIGO7io+Zs+iL75Ae00 lj5+w6tkxrf3pLXQ4Z8PiTCqpchgXN/lC9aZFjxO/C4RYlVy4kBJL9koWMiFVWRfk8SzZP+ q/IRGJX148MwSiCotZpdxVEYH2yC2AkjUttvMtm/qfJNwpnFKzqNXjjCkxqsppwpFF9oWM2 r76wCw94soR+l6gBGuEEowGA7BJr2wVUrYb2OM4IouovpKrkG4NYTngcBBSCA3QOCVzNg27 FdgP1DeNPWeqIQebjrw9zJVqT8KCHVYybpyYMC8pOzltOHgLGw4wQAo7+E2AR06fgzbiO/L 3032yPvgggi2j9h5NaMJEotRQXhineV99uHId3afSh6MinMIaN2j4VmEKsCIFoABX95iq2m YtvI3jzRSdjMlKHv0QsG6e2Fbdte/2+Cs6CCOgy7ZaBSCSRRYrVMAAlGcVFs6DfX12yRZZe 0VcxriPYjt8C7Oj5Wl X-QQ-XMRINFO: OD9hHCdaPRBwH5bRRRw8tsiH4UAatJqXfg== X-QQ-RECHKSPAM: 0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Chaoyi Chen The rocket attaches the IOMMU group in rocket_job_run() and detaches it in rocket_job_handle_irq(). Calling iommu_group_get() in rocket_job_handle_irq() causes the reference count to increase unexpectedly. And this causes rocket_core_fini() to fail to release the IOMMU group, leading to a resource leak. Fixes: 658ebeac3351 ("accel/rocket: Add IOCTL for BO creation") Signed-off-by: Chaoyi Chen --- drivers/accel/rocket/rocket_job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocke= t_job.c index 2f1861f960cc..db10848926d8 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -340,7 +340,7 @@ static void rocket_job_handle_irq(struct rocket_core *c= ore) return; } =20 - iommu_detach_group(NULL, iommu_group_get(core->dev)); + iommu_detach_group(NULL, core->iommu_group); dma_fence_signal(core->in_flight_job->done_fence); pm_runtime_put_autosuspend(core->dev); core->in_flight_job =3D NULL; --=20 2.53.0 From nobody Tue Aug 25 14:34:12 2026 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337AE314D13 for ; Fri, 14 Aug 2026 02:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674394; cv=none; b=hHXz8OmFmr9CHc5E3YknqOk+GU9jAFIzLXjh+33Feumd/cOAFeYAfQ5hc6IJabPfkAP3eF348FTWsjyrC80JrKArqvgBItpxMFLbPQT/G8fy0u/2GkB76oLAd697CYEkYQRBUeYf/4bq2z/vxIlwUGAmKV1mekhZ5PpQZmHlfSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786674394; c=relaxed/simple; bh=DFZlMnMtKghOUgDk+7CYzHN+I9rm1NUI+tu19fZ0Q30=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=Z3Opsd8Ns+tQxLQ+NnkRtGCrkDb/g3gulX4TaabzKkfHV2Lm6B57JNsD3IYQbyLNyvx0WEXJPKYVbksIP5bCb0pFFErJBekdbBt3GlRiOKwEZyGkw2FEzq8+eZFZGh6JjxtnRhbcJIncSzcXQJ9SC464hoBv0Xas8mLYpvioH3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com; spf=pass smtp.mailfrom=airkyi.com; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b=BxlejEfZ; arc=none smtp.client-ip=54.204.34.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=airkyi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=airkyi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=airkyi.com header.i=@airkyi.com header.b="BxlejEfZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=airkyi.com; s=altu2504; t=1786674335; bh=zwIQVsJa3bKVMiFSZ+kPNaDWDdjE00ekRDJBwDGVRHQ=; h=From:To:Subject:Date:Message-Id; b=BxlejEfZpiHpBD13kqh95waqcwroRvlN0Hz1hOeuKkIcVmMrDR4MEM8Gg+89e1M5L W/2fmz4MobI9hEItALRdKp2gKr4EKO4t4+o9Z6jFpS9r+Ty7P27NFtMhMhfhEqpmb9 iaIBy3TykWCxqFPZXDe1HYoRzVkY0QGSNHKf2Xok= X-QQ-mid: esmtpgz13t1786674326tbdf7c49c X-QQ-Originating-IP: b3yIyDj93Zk6Fw5hzBP5dySljjYsCy8cXF5fAZrH/yE= Received: from DESKTOP-8BT1A2O.localdomain ( [58.22.7.114]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 14 Aug 2026 10:25:20 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 7240023971590159997 From: Chaoyi Chen To: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner , Jeff Hugo Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Chaoyi Chen Subject: [PATCH 4/4] MAINTAINERS: accel/rocket: Add rockchip mail list for rocket Date: Fri, 14 Aug 2026 10:24:53 +0800 Message-Id: <20260814022453.437-5-kernel@airkyi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260814022453.437-1-kernel@airkyi.com> References: <20260814022453.437-1-kernel@airkyi.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:airkyi.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: OE1h366RMh4bPIWp9FHW6/AyL21r43hkn7NAzLdL/UoB/ZlYxeaJpgBe jsmaXS+sgNe0JQ+ktXJK+DapnfYapIM8J7P5e3OPctWLYAti++KpBE6pJb7kl3tXGQAhiVf zhYkFdXNLhvWJTHYq+68z/DTy+R9Jqh2KTouquLFmP23/uJVu5dmlx5O/HV/IpcnQk3B1F6 hPwpYHjYHciJeCbGnKQrBZBLIC0OobpUjU8GWHsGW+1SVUuGbVBxCT5l75s6DUwjitXgm4r DyRRGtTQ+jYvmfld5drhgavFWEnnLIPaL2pn6GUzZjuO8mmOKJNYyv/8jLB7o3jDN2/VyWD vM6IFkYmt9/Mbei0dOwwzbtYTL7tRS22NLKbJ71q+sRiz5OHAExzzFeBTqtPOsBpyijwkJ/ ACgfnCVPIe1Qa4hu+TC3lrg4w8ZId0uDhBpjb2Sjl2+7x3n5KVNftlo5xcZRXCC/APEVedW M/UIpAc0yGfj2n8s8kGALfteq36TI3TeaHKdjVS1DAO5jgdgfdOm0JU+iMsQajlTyUJhnqP sixjDoq0sIIRcxmCt2TVNNqmMXq6xJcvaT/emRnIYKimf/88Jlnw4E6x+WaTipt2IN9SB7z qG+jOyyG/yJQhiDPorbqRBIHOH62kS6JznEN5fTlNrkz4reCff2Osi035wpwBHeHJD2DfK8 FpMc0cyRN72K1MwGsHPi65DRq7s3spGgyMUKjjB1dKxRruHhQhozTvI2lxEojBSvZi0QUq6 S/aG0yawPQHN8JO2LzTBFkIgoDSEAI3mhXN7SXbQI8eDrwOXCbU7x7iSvFClUXgGI9hfQuq GDTieul7ZVYpUF0qg1WorYi7ZN/HrhTwJmzvAYgTr2D0mtp5u+nZdvcnHW0fwHyGoyKJ1qw bpxC4Fxd5FLU44gAw6EYz9V9Zwj3fJVS0WTSdUeFS1jWjm7eiXp1XY9EhunHFbHNts5XgO+ 1EoVSu6m2JN5nS90NJfMfcz+lT/vtMj8xMY8wXSDP/MQLgw2pfaM34z7yt9hrgGjn3hHcBu QNeVWI4HWqdOeZHuTyi4ufGGs/2vC2QGNTX1gNQDV5mHLxpsF+ X-QQ-XMRINFO: Mp0Kj//9VHAxzExpfF+O8yhSrljjwrznVg== X-QQ-RECHKSPAM: 0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Chaoyi Chen The rocket is a DRM accel driver for the Rockchip NPU. Add the Rockchip mailing listso that changes can be tracked. Signed-off-by: Chaoyi Chen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4a8b0fd665ce..388ec1758ce7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7942,6 +7942,7 @@ F: include/uapi/drm/ivpu_accel.h DRM ACCEL DRIVER FOR ROCKCHIP NPU M: Tomeu Vizoso L: dri-devel@lists.freedesktop.org +L: linux-rockchip@lists.infradead.org S: Supported T: git https://gitlab.freedesktop.org/drm/misc/kernel.git F: Documentation/accel/rocket/ --=20 2.53.0