From nobody Wed Sep 30 02:58:50 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EB063CD8A4; Thu, 13 Aug 2026 23:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786663792; cv=none; b=EtcEbm2ZGHKlFsxkV0WJv+qU/B3bUvlRDrq3cF11v/Lwpg95HeIo7p4K8YVHwPVorey8DJFCn1r0aTDUUJVLzxlPw6VQS1BKrvG5XlyivFA+RA/4zNTf+9rkOOaoFV2QGUIXAnDoosqa9QDgfmuZlFBSaE6yD9kfwPrzqy/mzKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786663792; c=relaxed/simple; bh=c8y50wvMrO/x2QcUvtSYsEz/WyNIgpJCN2AzBDqh9oc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YMbhun55KLwBiWaAj5mrJVwFtx2ZE9ZzWxtGZ6IsIFn4J5koN2TOpzDF7OptKI1gkO2OmRfciXt6uUd7FIZgcdihms2Ex9xVE+DK9Wk5FSm54II3kFv06KqOX4MCEEQI+Kdhlj9aP36DEqqeKEIi+UaiOzPu50rbwH17cOp1mdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=so5yq1AP; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="so5yq1AP" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=FnV5OU5FndSzEfnBWZbVh/mfI5hpBGsj+wc3TOdgS8I=; b=so5yq1AP/aUOJsu5w0nbovZvaU sU73CIh5jiXovrEwD6q5v/moZOBz+nQooq49zw+kt5Ij9CaSDO4H05nz6mzkhFFzOTUW/Vvvkx0Tt 91zkN5vBZvHHtBoqOSq6ZpucSxbyUlrinVNy5ELN400PYS43pAVnF9CCkJC7fBo7mv7+qeiJyk4KI tDYpXGCtZtKjzWwanIq6Mcg11CnS/1d6EnhVOnWGSsvlOgS/Au2zenFeEv70icAH5iq1Xe1vompMl shouza6IjclEoEkoTSq5wH2JfJeFYFJvi9gLoGsWa7mW/wcwC/5qZ2MkM1cfcMWyufqvv7e7ziAgg /TfJcUcQ==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuerf-00000001k8D-1KBy; Thu, 13 Aug 2026 23:29:35 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Maciej W. Rozycki" Subject: [PATCH 01/03] fbdev: maxine: make functions static Date: Thu, 13 Aug 2026 16:29:32 -0700 Message-ID: <20260813232934.2718291-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260813232934.2718291-1-rdunlap@infradead.org> References: <20260813232934.2718291-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make 3 functions static so that they don't need to be declared in a header file. ../drivers/video/fbdev/maxinefb.c:64:6: warning: no previous prototype for = 'maxinefb_ims332_write_register' [-Wmissing-prototypes] 64 | void maxinefb_ims332_write_register(int regno, register unsigned in= t val) ../drivers/video/fbdev/maxinefb.c:74:14: warning: no previous prototype for= 'maxinefb_ims332_read_register' [-Wmissing-prototypes] 74 | unsigned int maxinefb_ims332_read_register(int regno) ../drivers/video/fbdev/maxinefb.c:114:12: warning: no previous prototype fo= r 'maxinefb_init' [-Wmissing-prototypes] 114 | int __init maxinefb_init(void) Signed-off-by: Randy Dunlap Acked-by: Maciej W. Rozycki --- Cc: Helge Deller Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: "Maciej W. Rozycki" drivers/video/fbdev/maxinefb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-next-20260812.orig/drivers/video/fbdev/maxinefb.c +++ linux-next-20260812/drivers/video/fbdev/maxinefb.c @@ -61,7 +61,7 @@ static struct fb_fix_screeninfo maxinefb =20 /* Handle the funny Inmos RamDAC/video controller ... */ =20 -void maxinefb_ims332_write_register(int regno, register unsigned int val) +static void maxinefb_ims332_write_register(int regno, register unsigned in= t val) { register unsigned char *regs =3D (char *) MAXINEFB_IMS332_ADDRESS; unsigned char *wptr; @@ -71,7 +71,7 @@ void maxinefb_ims332_write_register(int *((volatile unsigned short *) (wptr)) =3D val; } =20 -unsigned int maxinefb_ims332_read_register(int regno) +static unsigned int maxinefb_ims332_read_register(int regno) { register unsigned char *regs =3D (char *) MAXINEFB_IMS332_ADDRESS; unsigned char *rptr; @@ -111,7 +111,7 @@ static const struct fb_ops maxinefb_ops .fb_setcolreg =3D maxinefb_setcolreg, }; =20 -int __init maxinefb_init(void) +static int __init maxinefb_init(void) { unsigned long fboff; unsigned long fb_start; From nobody Wed Sep 30 02:58:50 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3C13CB2C7; Thu, 13 Aug 2026 23:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786663792; cv=none; b=bsB8ORnVGnq8wo1S/P8dqDpIzL0K06EI0ecnQQc8jkj0wSWTiv+WbNoojoNKONSHPk3yJl+/Uy6om1aC3evj6t0fn74Vf6S+JBlcpTAtwom2voYcDd08OmnIE8ZQrELRAivfw/ikfLRTBM928F3EVkMUDSMM+UYz+Lr7xRhC9XQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786663792; c=relaxed/simple; bh=FcJxeYeA8CsjKL3qpHQ6+0ih7ry8XJgrKuoF2oVC9uE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qkInMYJTOO+wnJn/OztP7zqITxVyFrxxygnL5Azgyyc9s1uDde7UagtDYiFuWwclk0HzwxGheGON1AGpBYbYTajyRXvICE2UaOAqZQh/eiiFADiiWXEv1ibmmqyK1Lm7SR29p8e6cc+bau2TeZfmsCK+NZbunHVnxInd/8ImS/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=EVliN0QM; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="EVliN0QM" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=kM2TD3DfowE2cKLzEA2GjNOhlCpAPeFQCX6hfajS8yc=; b=EVliN0QM38cMZWlTNeL5gCPy+K VZf8RdAyKQjW0nqTlXmuuoXsdZgBvHa+6IU2eXU4o674tbZdCIK94Ii9YpzNDXNw6wjrvuiPPOE5P oqUUHUayH/SAiYnNDZBd6UJHN7FtqEEhqudlkncym8zppzWnzi21UWxzeFnbzM6kCj5ndUglmNsJO MhFIONmM49ulnLh/6/wrfaeVl2i6Um0RCx0ad+KaMtRYNSx6m60aYvjk68vvlodQIYspy3yMm5kNw aqMWFt0FyKO5/MJksDXnIUsT40ZmGlD9BPyoFeZOlBXwZ+0zzE3mdyUm0lE7YRswTyNXIyh/U8wLp K7JLJeVQ==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuerf-00000001k8D-2Tqz; Thu, 13 Aug 2026 23:29:35 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Maciej W. Rozycki" Subject: [PATCH 02/03] fbdev: maxine: elide an unused function Date: Thu, 13 Aug 2026 16:29:33 -0700 Message-ID: <20260813232934.2718291-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260813232934.2718291-1-rdunlap@infradead.org> References: <20260813232934.2718291-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" maxinefb_ims332_read_register() is not used, but since it describes a hardware interface, leave it in the source file as documentation and surround it inside an #if 0/#endif block. ../drivers/video/fbdev/maxinefb.c:74:21: warning: 'maxinefb_ims332_read_reg= ister' defined but not used [-Wunused-function] 74 | static unsigned int maxinefb_ims332_read_register(int regno) Signed-off-by: Randy Dunlap Acked-by: Maciej W. Rozycki --- Cc: Helge Deller Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: "Maciej W. Rozycki" drivers/video/fbdev/maxinefb.c | 3 +++ 1 file changed, 3 insertions(+) --- linux-next-20260812.orig/drivers/video/fbdev/maxinefb.c +++ linux-next-20260812/drivers/video/fbdev/maxinefb.c @@ -71,6 +71,8 @@ static void maxinefb_ims332_write_regist *((volatile unsigned short *) (wptr)) =3D val; } =20 +#if 0 +/* dead code: leave here for hardware interface documentation */ static unsigned int maxinefb_ims332_read_register(int regno) { register unsigned char *regs =3D (char *) MAXINEFB_IMS332_ADDRESS; @@ -83,6 +85,7 @@ static unsigned int maxinefb_ims332_read =20 return (j & 0xffff) | ((k & 0xff00) << 8); } +#endif =20 /* Set the palette */ static int maxinefb_setcolreg(unsigned regno, unsigned red, unsigned green, From nobody Wed Sep 30 02:58:50 2026 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AFFB3C1097; Thu, 13 Aug 2026 23:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786663791; cv=none; b=c8CNut8wi3xPTlAfnJwazxXpYkKAhsiFrtLm0vK7Cq7PPjBsv00Wva9Itah2xLrpGbxoOE89Vl7kfXIBU/wNZ37uyG6HyVomiTZKer22YlxhEQXmfaaD5yOHuteicKK5xjfEz35p8ijkLC5CJCFhnKspZiNb0xzc1JBk52kzfzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786663791; c=relaxed/simple; bh=FENAHiiY61uTPh06NvQTs6VSgs8gXfkDcKFIhTaFVMw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DqCfuvyXGnl7WEFgFnYArxVV0sKiSMHbab8qYEi7ZwAypuzX05apmCtZSE+LEXsmXCM2ZJcyIdQwx6Ftm6nE05Ez0PpXU1Wq8utDVbMlMhqRlERvmm9wr4JB8+Hn2117Q2Wjkkmn1r2jRpiX9Sk1EM2hoX0sDSiF9dB8an2DMDQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=yXQTj52Q; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="yXQTj52Q" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=j/xHcrj4xyL74ydO2CkiHOif5W5/Vh+Dsdgi9S/OuXU=; b=yXQTj52QIAbsvUAtGE+xsxtalo iAtQ/L/izVMWbFjLgPUZ1F6WMKS0PVm69SDhSjLTvSadTovaZ0Om5d8wj+Oz4+5Lo8FM2r/Tk6sn4 CGwk01GWWpDN+6494/gGCZUl0TC9OVWRBPQr/zhKcidnfe0RAnrpa1UhFssfruUhQN6vK8qd6DPpl PdsXa/2bB8uECToFJx8myFfWmk4EdlxMY54WKvLYSr5iVrU8yi3wCpQr8bdQz2v5mT0eqSZZHGqmh xgq9tL2vuqPdYYqRf25R/Xa0gBdHpt7P+dpYhhPaM3X6aGkI8TWAl+Omw/6GamSSPuJYFsKhbIuWo 0ntSuutw==; Received: from [50.53.43.113] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuerf-00000001k8D-3fbO; Thu, 13 Aug 2026 23:29:35 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Maciej W. Rozycki" Subject: [PATCH 03/03] fbdev: maxine: fix 64-bit build error Date: Thu, 13 Aug 2026 16:29:34 -0700 Message-ID: <20260813232934.2718291-4-rdunlap@infradead.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260813232934.2718291-1-rdunlap@infradead.org> References: <20260813232934.2718291-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The KSEG1ADDR() macro is only defined for non-64BIT builds. Use the CKSEG1ADDR() macro instead. In file included from ../drivers/video/fbdev/maxinefb.c:34: ../drivers/video/fbdev/maxinefb.c: In function 'maxinefb_ims332_write_regis= ter': ../include/video/maxinefb.h:16:41: error: implicit declaration of function = 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? [-Wimplicit-function-declaration] 16 | #define MAXINEFB_IMS332_ADDRESS KSEG1ADDR(0x1c140000) ../drivers/video/fbdev/maxinefb.c:66:49: note: in expansion of macro 'MAXIN= EFB_IMS332_ADDRESS' 66 | register unsigned char *regs =3D (char *) MAXINEFB_IMS332_A= DDRESS; ../drivers/video/fbdev/maxinefb.c:66:40: warning: cast to pointer from inte= ger of different size [-Wint-to-pointer-cast] 66 | register unsigned char *regs =3D (char *) MAXINEFB_IMS332_A= DDRESS; Signed-off-by: Randy Dunlap Acked-by: Maciej W. Rozycki --- Cc: Helge Deller Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: "Maciej W. Rozycki" include/video/maxinefb.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20260812.orig/include/video/maxinefb.h +++ linux-next-20260812/include/video/maxinefb.h @@ -13,13 +13,13 @@ /* * IMS332 video controller register base address */ -#define MAXINEFB_IMS332_ADDRESS KSEG1ADDR(0x1c140000) +#define MAXINEFB_IMS332_ADDRESS CKSEG1ADDR(0x1c140000) =20 /* * Begin of DECstation 5000/xx onboard framebuffer memory, default resolut= ion * is 1024x768x8 */ -#define DS5000_xx_ONBOARD_FBMEM_START KSEG1ADDR(0x0a000000) +#define DS5000_xx_ONBOARD_FBMEM_START CKSEG1ADDR(0x0a000000) =20 /* * The IMS 332 video controller used in the DECstation 5000/xx series