From nobody Tue Sep 29 02:02:25 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C8CA48AE1F for ; Thu, 13 Aug 2026 15:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786635094; cv=none; b=q5uzHfRzP5bIsLULzeeCDY+cAOfZBL5bMifySUWGXCcHu5Yhl9RugJFbrqcPdE0JWKhZQWg7sFlkjTxI00Ka8KUR1eVZShxjjCXMzh7Hfq/vk1t8AOyaJFTpYPY0IujZstXUrJ8aRZSRxaLNURs9FkNXVI5BC0/2ERXhZO7kyOg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786635094; c=relaxed/simple; bh=YK5PsZK3kKo7Jm2OqTBXVV6R9je6KgY3acUnepOtEyg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=raUMjejSTgSBC2CcnFs3CJyokTDQFeBQhZF52lothSWA0wWsrtQ5foH3RjdxE+5bDkY8D3OlAXxSOY704069GOVT3bc2C1P5dW5NtkbsDvZowXTfc7cHKRAV9YNvTOqPEwIy+Gr6TxMFYWbPHM4C+GpgIsB429Z2HswFk/chMww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lSVGgjat; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lSVGgjat" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-84e04df8c46so2449139b3a.2 for ; Thu, 13 Aug 2026 08:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786635091; x=1787239891; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=KoIS/EkathyELulFahQfkRCm6vzfTrZEsTXUD7JHWaw=; b=lSVGgjatXh0n8Ex6Kvm8ErJtCXn314zf/+9nOf+wsTFkyW5NDQSxFGW0UL3zKCATqe lVHP/c95tC9DBfcG1d34hCDA1HFbu5JtAgWYNdl0wX+k9AX65f23X/OGBMcRuJTjtmbC zIRoHUqKFXv0jNHbt6XO13hmUIait2ZfaDhw74KqISUSSE+RQfOS/br46qRR1UMr6f5E 1qebGclgRZ9NdJ9/PA5lJzd+hwp4+RkDs6iaYTzSvPUJ/qw3roefJRurvr5S2WwMsRkT Bk+N5nnWp4WkK3QgIFk90kaPawonPcBl2WXAaXXCzW6YzCmquoA60iirI7rJekPLoYeq KoIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786635091; x=1787239891; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KoIS/EkathyELulFahQfkRCm6vzfTrZEsTXUD7JHWaw=; b=YJ+HbIWin2a8w7Gop4Aym3ZzTM1S7FG2OIz/fnHdSRYYCsKJNG0sQlXLBhqaxhe9Rd 6/o5xB64FI981Fu9aB4oTCP3NcxKoqWDNWo2XW/r2CXXWlNyFqn5I8bR6iywtJmKXzA8 tXsuPwUw7E4MdBqweehComugM8XiENv4SAlBaPFcb0NkzkOUAOJuhF/Y+LcZWviH0coh ziHOQ0i8drnfc+6RpBZrePXBBcZVC1zvNKJuV3mnTJrb5vZBXYMn+O6B1T/xLTXMgOlY vu6kslSrRal1oRO0SKs7uMWuJBNrKzyL+e7gfgCdvOg0Fo7lev1E9IH5UQUOpRtksdpM Dqgg== X-Forwarded-Encrypted: i=1; AHgh+RrOZI91u4CifW+AtNkOiMsz8gzzjDp4de+BvH4sX7XfYgPobPMSqbA5o6hJodn5S8WVzqHRSuaMzKW6t9I=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1hKgDteneHjiexYI7cILfItVAVwUopzgq5yY5NQpc95WTa0R3 9LNKPtwtk5o360qSCg9PsdR1yU2+mS91ON3yy0bpNMvcw8XL8BQ/sm/5bLubXWHDJZs= X-Gm-Gg: AR+sD12uF+v2hVkL/rOMtfDBENzLZY/cVS7NNhWY0C1HDKA59nla2k74gu5/wAGWgl4 b9cMGqacwvpPM93v7yZP7I/9IxQz8U+vu7z8VlvuD9BcVItWSnaoZhEf1lgoDfklH5OgOiGc5Nf 40b5DD5Rt8SmECPQ2YJZcSkBYfovJdkcDNphekh+ytYoY0pMK5T5cRl62UVFnjq2Pfn2NRoJHkK bary7r2LkU7xQ+dSN8rZJMfRlv5s5A2T9n2yQO7X0G485NJo4OtmDFXLxVhZaPSybmVi0cEMqzE VNkHimLYJVLjklMwb2kgFYnTUHCEJh/QJ1zn9B8yWQCIyRu7NAl/aymFvElKMmRqZyqt2pCymP0 mV/yKcYEoDzqIuKGWn7fQ2hd8H0gWP8tyrrEeZXSa8zpkIEQ70a57+Irv217to6dT9thwFD2HCm MFXATRUJJDM562eo5vWDKT9sV4G0D4gszR5VDWR87iH10BpHSJphKQ2fFccdUuxWBN49gR7SE3F w/iuZQ= X-Received: by 2002:a05:6a00:e19:b0:848:44ae:47c4 with SMTP id d2e1a72fcca58-84fc6dc7110mr7997042b3a.20.1786635091229; Thu, 13 Aug 2026 08:31:31 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:3b7:6da1:c188:d14f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84fc5a5635dsm1077920b3a.46.2026.08.13.08.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 08:31:30 -0700 (PDT) From: Ruoyu Wang To: netdev@vger.kernel.org Cc: jv@jvosburgh.net, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH net] bonding: initialize err for empty target lists Date: Thu, 13 Aug 2026 23:31:26 +0800 Message-ID: <20260813153126.3952893-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Empty NLA_NESTED attributes are valid, and bonding uses them to clear the ARP and NS target lists. When either target attribute is empty, nla_for_each_nested() does not execute, so err retains an uninitialized value before it is tested. The request can consequently return an unpredictable error after clearing the targets. Initialize err to zero so an empty target list completes successfully. Non-empty lists still propagate errors from __bond_opt_set() unchanged. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 4fb0ef585eb2 ("bonding: convert arp_ip_target to use the new option = API") Signed-off-by: Ruoyu Wang Acked-by: Jay Vosburgh Reviewed-by: Hangbin Liu Reviewed-by: Nikolay Aleksandrov --- drivers/net/bonding/bond_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_= netlink.c index 4a11572f663d31..87d92d3cce4a88 100644 --- a/drivers/net/bonding/bond_netlink.c +++ b/drivers/net/bonding/bond_netlink.c @@ -220,7 +220,7 @@ static int bond_changelink(struct net_device *bond_dev,= struct nlattr *tb[], struct bonding *bond =3D netdev_priv(bond_dev); struct bond_opt_value newval; int miimon =3D 0; - int err; + int err =3D 0; =20 if (!data) return 0; --=20 2.51.0