From nobody Wed Sep 30 03:46:02 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14AF94508F8 for ; Thu, 13 Aug 2026 10:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786618499; cv=none; b=toxTEpLJZUQy55FZiKijDQFh5GBOqW6TWfH2KXee5NCQvxMck0O4ylAw8f/qygd5oYwT2A2VsZWSF81IrcVFR5/ljN+eaPEkWEGBpiJ5pdGvEdqf/ATFuNSrbd0BuwwAEE6/XB+iOU0ZcE2M90lo361PMyEAxiQ5eiiN7u+psH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786618499; c=relaxed/simple; bh=sfDOcGj49I5Lg9sqPabm+sCqAk30xgmrYMvMPJ1OC10=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gDB7p4J1uuR+2huWljO566gUxinoTTQWBNYRPKVu9ZrY50umg6hiGYq23Iqo23Y5vNQNO54YNQnm9O7l4T02A/kx9Y+aLN4Yg/fawSiq4vvbJyoCIJIveCwOwW+gXLstpXl+snfqR8BzGVZPqsHCUYHwBZXCjlP0rD3B0lH5MnI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FgAE86Zb; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FgAE86Zb" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cace91f112so6662075ad.0 for ; Thu, 13 Aug 2026 03:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786618484; x=1787223284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zrd3znC9RvuRXBUcV5HRJ1iH8to7j8zaCuT9EPtB96s=; b=FgAE86ZbbKeeIYOmx2o2D9xXE0tyZ1zIfA/6cDwbPd75MszIy+FJeqPz/P+HHcB+wn mYxYsx4zBKxUYDkF6EA51NsTDekBzbs+AY2RhBwf0Ys9b3IvKA0rZGmRK7ODxo6IQy2o 9grOrfnKC5eojKg/xsNWlUrL03P1GX2g10xkF4FMG//7KuY5eJeojlmPY+Pwcp09vZG7 B22AFrlHTJBLXh82uDOiqv4KC3Sy7V7Do6UqFk3ANGlgdrjqd8lhFXWqrJ9Mx9mmORYU rZBBUtQCjv+VPh8IcKn2+sAUZ59CQOemSKb/cdnGhLiIc4phssIccus1X5hXkq8WBNSx x17A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786618484; x=1787223284; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zrd3znC9RvuRXBUcV5HRJ1iH8to7j8zaCuT9EPtB96s=; b=YwyuUawRNOInoCPYhbpm68iw4K4qHlgs5B70uNjnJmPfQHQLFvdpfvoTzgZ7Uc0PPJ jlJQFcjoF6prLaQlQ6aLNOM76yKhvDyhWF6G9Vf6ycYjD104LO0sh0PurQqWdpdlUUe7 gHMzBxEox71u3tbrMMdAKgFtWWrxONdpGl/rU1t8k5dnsO9VxgjUn3vsrrXMhJ7F8nmv pagdGg5QtNnFKvxNew4EhbG4QeFyNokExypyM2xgqKVd0tRdISTjaQGIsR8AoAGWboeM Vt7d60yxD67BBaAcgbvSBUIAqUuus6TWzkvQ8Ur2ZQeZdwvmJfgyYpgQAQa7r6OOHGmP c5Vg== X-Forwarded-Encrypted: i=1; AHgh+Rr06YrjyrgDOSeadVRLyYr6EDi3eitkPRZz7tqEujc4Q9oxeT9XgqvQeGXB8k0PBJmyZbCtOLHphvtUdK8=@vger.kernel.org X-Gm-Message-State: AOJu0YzR0pYFHiylMuQ0aoIRxASqxyZk/n2ExQJeEoZdgNT92PXZl9Yk COz8T8Gbj2qxBG985Sc2rf8sSBydPUNHEqrr4wkRRYRz/cqbR9FVEz5X X-Gm-Gg: AR+sD10C++045e6OcxAFs9HKUmQ83VAPag9uZ6t7ptIM9kv0IN99cYSlZOyh73iXRn2 BGzH0NeOaAlZnsOy+mQu5ab45kls+5v2ZA72SanAGGb191q4BXD2fgI/CsCev2IhoFqDVcweHaq aZ25vCREmDkr5SZK1lkz7jsDR41RSkBERVJpQa1wrOvJAx1Uke4205rIh9ViHGLgcMEpPE+q5T/ IPDjprpl2rlIDN7ZUGf2YAC5jklNb++sya85z/L/mnRri4SqaZjglHH5sRuf3wKR+4WhRHJR4d1 sJtwtHUMuIEuPnDLmVpRESo6AKLNKODOYzwKbFTynhcG3smHkit1BU5TddxgD6EIS50vJv+hs7T uarhlDDb1D4AO/xKr5aqXHOmZlONxts9ItLj4KQ2HLM5hzUTSL3Mvg6P0IPX7FmZubbTq3zaHSz zzCYB0F68ATHiHoj6BB3cq50Dsw5q3faH23Qwlax/jjLMoLWkAEl7DMQuMBMp0bp3S5aLd1wek9 Q== X-Received: by 2002:a17:902:cec5:b0:2d3:1411:3888 with SMTP id d9443c01a7336-2d37e833f67mr49532675ad.12.1786618484169; Thu, 13 Aug 2026 03:54:44 -0700 (PDT) Received: from amd.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ebf732166sm11395032eec.18.2026.08.13.03.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 03:54:43 -0700 (PDT) From: Chaithanya Lagisetty To: Eugeniy Paltsev , Vinod Koul Cc: Frank Li , Chaithanya Lagisetty , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dmaengine: dw-axi-dmac: fix clock imbalance in resume error path Date: Thu, 13 Aug 2026 10:54:32 +0000 Message-ID: <20260813105432.2577322-1-nagachaithanya9911@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" axi_dma_resume() enables cfgr_clk and then core_clk. If enabling core_clk fails, the function returns the error without disabling cfgr_clk, which was already enabled, leaving the clock refcount unbalanced. Disable cfgr_clk on the core_clk enable failure path. Fixes: 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver") Signed-off-by: Chaithanya Lagisetty --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/d= w-axi-dmac/dw-axi-dmac-platform.c index bcefaff03b5c..9db8993e0bc6 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1335,8 +1335,10 @@ static int axi_dma_resume(struct axi_dma_chip *chip) return ret; =20 ret =3D clk_prepare_enable(chip->core_clk); - if (ret < 0) + if (ret < 0) { + clk_disable_unprepare(chip->cfgr_clk); return ret; + } =20 axi_dma_enable(chip); axi_dma_irq_enable(chip); --=20 2.43.0