From nobody Wed Sep 30 03:54:13 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F35F3449995 for ; Thu, 13 Aug 2026 10:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786618470; cv=none; b=VnB7lxD1UMNH87H9ev6Prz3wvVohE+LB8P+zB/oVZ2z2dCPfaBUUGddEo15Vw2bwpwrft634qAHSn8/V8KBZf4cNUsVeRntaCRztjgb+Vq39/YwGiZzOjb5GLwQuB2s3clU+Fcz/sKYriyPOuJpWNHeXesAMCQETuC+JBdey1/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786618470; c=relaxed/simple; bh=Gy7scZmeerBSr7PmVaP7q0xEqYZTtW6OqxPH0TsjCig=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mD8MTFkRhX00IH/VzTsFAJGO6tYpjBtTXYvCbC6IE9vEzV2Np8k7jInW8z+k38e4SAVBi2qJkEwQYlv6+lnuP+kg3GA+09SN5ERvCJQodESKt1f+htHXfnlQOPyLu3NjBzMru+LAqzBQzVjdVLorOPat3GL6dwDxeETFUY4Y218= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WMQcfpA0; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WMQcfpA0" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-ca7c1176317so487000a12.1 for ; Thu, 13 Aug 2026 03:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786618457; x=1787223257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3TGfFltkMtoPUdIhLUzSLkz57kkTwRQHJDF5g28rmK0=; b=WMQcfpA0lDohhHRXM4PyjQo3Pr7KJiLleAom7h/88W+sS7TK9dgeReh7SjbUlOfysP ReywFdPUElPkwkmiuFGeKdFTH8sxVw3Cd48L1S2eY+0Fs1nRKK6amXGGuA43pHbNGIYz 1dXKh0IsqVsKzGyQUM+HSDMaV15hFDJjqvwBX3U5qNVaa5TqxEACEkgrBAmd9BInP/hH mTTSZ7rmerY0WcOC83QyonzAe49lupOMuLfRnXgGsw23dDUx6xQ3FkqOfWFa2xUNP0OB witH2/qvvBdg3DfWFmRB8+BXHAnx+tjYuQ2mRcEpdKWCkPaDQDF/afpl5OptSo8u8O+/ SAMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786618457; x=1787223257; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3TGfFltkMtoPUdIhLUzSLkz57kkTwRQHJDF5g28rmK0=; b=AbnW8an4O+V/X4HPxR5ZO1qWNQC5eiiKlM7Q6dV+oXQ8zKE3XZGa3v9rDYXbNGQKD7 W4FqP0hfIfoegeaOMAiZTxsaqlPIfNrPCqqaNXUoDUYM35GkugjNlksO/pXo16IFqmgd nfArcMUnNal0991Kvpk9VHj9Vw+xnmjJB5MIoj14JXWXTI7wlldGBC3WQkjKg4DtoyNU Wky6/kNgdl+vUQTvW0AcdhHVut10hRfKZlirrZDBk9+FftgzRl1l289uJT/BHouMsGs/ qJXIcu1L56yLy2rsCj3rud+1wXan8SlRPxlwLXSK+8mnUVHHMRrWshwbnmV7WJrdbaCr 9hOQ== X-Forwarded-Encrypted: i=1; AHgh+RoY692+GKxKlJ1sjuMW6EWiHzXj1dSVIUrxFGTexfb+W09OS9VBscqEPJZB/DGY5vj7A0CC7aeBnIKSWxk=@vger.kernel.org X-Gm-Message-State: AOJu0YxbPwoc6Bh1uw55KZCNlSljPkn2znhrIbmZARn2zSEss1753bgF aWFrg42pKmsdppIbXpyDMxksePMT0ncy2v5N/pF/xqUNCvgEg2vXJ+k2 X-Gm-Gg: AR+sD11axGuDKzmyTTBGjryTqirR/YpzvQXdBTvk9Z2fWhRO5H8yE1UyiHcviyjzfMp lnuQ/QTqDiWdzjhjdAVunW5a9dPEQkNSXoqwzCyCdIZpaMsqIvcKPdHhCFSSykv4Pc3f7Snjvz4 roowIBPJEmNRAjDCKv4JrBo7G3wyNWrFw8hq96FSjvbmRW26yZujyGLEmk2JRKJd1p4Lt6P7Nj+ 8OyLx/WDxX2UZGNXFg3RO2vFiNOtmN7cY/x6vQimNvoGN+75rRuH7KbxL3gkesexS+jayjnzFpF U8auwEJVvuuMf1xJQF8fgOq2ZLaBPZ9rDAEMUUYrLg4v7d0Env/OK4auJx24cA+XVaTFJWd8s1/ gBtQk+dJkXMJdWyOgsEX9p1evgy8obiRm+Qs4RZXpc+VbGuyQOtgfj9QNXi1hxIzQwWf/fJCc9q eUp6Xg+uuWNQmpW/gGa06AN0Je0ahzUFNMQ80aeLvNp5ypDBxplWe/U4n56s4/e/wPYgxN9POBm Og9nf/fIWrczQ== X-Received: by 2002:a05:6a20:729f:b0:3b4:7b3d:179b with SMTP id adf61e73a8af0-3cc5508c813mr6357614637.12.1786618457246; Thu, 13 Aug 2026 03:54:17 -0700 (PDT) Received: from amd.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1412d8a8eb2sm11623804c88.3.2026.08.13.03.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 03:54:17 -0700 (PDT) From: Chaithanya Lagisetty To: Vinod Koul , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: Frank Li , Chaithanya Lagisetty , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dmaengine: sprd: fix clock imbalance when enabling ashb_clk fails Date: Thu, 13 Aug 2026 10:53:54 +0000 Message-ID: <20260813105354.2577040-1-nagachaithanya9911@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sprd_dma_enable() enables sdev->clk and then enables the optional ashb_clk. If clk_prepare_enable() for ashb_clk fails, the function returns the error without disabling sdev->clk, which was already enabled. Both callers (probe and resume) treat a non-zero return as "nothing was enabled" and bail out, so sdev->clk is leaked. Disable sdev->clk on the ashb_clk enable failure path. Fixes: 9b3b8171f7f4 ("dmaengine: sprd: Add Spreadtrum DMA driver") Signed-off-by: Chaithanya Lagisetty --- drivers/dma/sprd-dma.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 087fea3af2e4..3ea5c3ba1a8c 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -270,9 +270,16 @@ static int sprd_dma_enable(struct sprd_dma_dev *sdev) * The ashb_clk is optional and only for AGCP DMA controller, so we * need add one condition to check if the ashb_clk need enable. */ - if (!IS_ERR(sdev->ashb_clk)) + if (!IS_ERR(sdev->ashb_clk)) { ret =3D clk_prepare_enable(sdev->ashb_clk); + if (ret) + goto disable_clk; + } =20 + return 0; + +disable_clk: + clk_disable_unprepare(sdev->clk); return ret; } =20 --=20 2.43.0