From nobody Tue Sep 29 03:53:13 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8420D4457A4 for ; Thu, 13 Aug 2026 08:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611155; cv=none; b=KaqJiQtJUzSUsfxOIF8E1E5xfUwoCrkntnbFMkpP7vR2t85SEHxaAK/feXFcWQ2ziaEPliQitMLgMyMnbCO6n2SvlN9LQV0OKiRU66HSxGA+lzzNv+1hrdZnHW8nWS5YvHDeInwQp2Igo3dwfuxRHWbcnV22emIN+YoLfHg9sKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611155; c=relaxed/simple; bh=ZgxTFZcf40IOcm2DafLWlJOaKw16R2DhB9yXYf3EDzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T9ZAppXbieCFBMH7Bi5dQInjHCQGdjbh3HHnWTXKGaMRhd3Lb22kVhEZ03wp2momPFjvYOJBfei/P2w0+pef47rkLkGQYApW4E6lMkHE9MATNpkRWeIUJtmRtOFOwNj/1oAUbgnw6gssZx6BWDpZTMo2cna9rq6qzMWmSzKUnbw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Heg9/Yr7; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Heg9/Yr7" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ccf2360620so19774485ad.3 for ; Thu, 13 Aug 2026 01:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786611154; x=1787215954; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RHtK6ZnzwEf/ipBzEmZ+Ey8tpxuxKg88KuJsAtOmL1k=; b=Heg9/Yr7lNfcC3slgwAswoOQHyYhqPaRUF6HZdkp3jDT0kNlS61rAnxOXzWCc1U74G a2LFJu3vksxhk37ibMPNCTn8yhVl0+8Gxk4hNzf9i+j+TDiq8TK/LajhGxCz0hfY4kww NgzfCzKoHkrmws7upx3pAOZCMt5CcRfwHLNNPhIIFzVd7WPnzrhzZgz4vmDIYL8OfcUy Ql6aTeO3hpa3rwOdjz8Zj6F8jidoMyuzPDPq1hMTuzhvT/ttgLamDbwVMGNk7DOeHUpn iAgIsZHblVeBDDEMMMeI5pksoka2OGrZa3KUL576dxjkuQn6NBVnUwfG65IDoRFXYjEn lRGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786611154; x=1787215954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RHtK6ZnzwEf/ipBzEmZ+Ey8tpxuxKg88KuJsAtOmL1k=; b=JJb5TmizZosvRs9FYD4d8dpYnnaT83Y5s2zw9Av4s4lyyl5x2os2+Qj5C6TlyfrLr0 qApKKUKxeEpsVKkMdocl0WcZWTH5W9duREEOEJy0KKCP2935rfskRnoMcW6kg0wd5KUa O4MtLcI6JA/hQOW+TaM8n7PjsCJaH3mYsjJ5WkEsbdjJigr9uK5Cm339lI8tRp6O0LVR +dtlHKaV9qVc9YgTRio/Eb3hGHim2+fKaiYrMzJrNZZj7uREfF0wPEDh6dW3UBDX2ZgZ FbvqzsmO/0pBxG4ckneiO0UqEASfJ4ym+ilj4iateymrIJxssu31sj29D58zaOrrxFSu Xb7A== X-Forwarded-Encrypted: i=1; AHgh+RoSWiYe2EHsJXAcFfmsOSyu5IbrqS2/ETfX0xgn6KhLVk8BWa1bDNYqn+LQI/yYXbYSBaUCHaSohmmX348=@vger.kernel.org X-Gm-Message-State: AOJu0YxSZpKsWyb9xYhUG0xZ8QygEiV1dwdTOFbOTEpukMGntgXR04uG WNDq3urOpcJ8l4KRm8unzEhRlMItS4aCHTjfGty0fNTr2+FQHSQiT4D5 X-Gm-Gg: AR+sD10xLa4E4jML8LsZMU4cNT/Ve5CgNKG6jPazJxjE3nQ5Q5F00rJGXmIj34byGHn AP9Q8EPGkDmUaOpE/adCIEggmga8+Zsig7YP+1nvffwBJ4IPGeLw9+nJGzgQtHla1ZlXdeIzBOI N29d4gMhkbOtD7bC/0hJ55+DxcIktFucXR4MIsY5hZCC+hy9zm+7C0m16P3D8SQ6tgFDy4dIva0 PMUYZOYzxLUYGSefcL9NUHR5w0f4RCch0xLl4vLhri3nuoz2S6SgQWBYNxKfy5iEgWvp0z6qwSU WaYvu+0qZ7HCtfgBlGevhOgiGrEihMdf22SnTX5XQfkjzrHM/izuGmeZWx06Axmc7gLWkDIil5g 7BlVPNtps39YPb8cLlyxunQ/WR/L8GCBDHlX3nrwhDhmF03tJ1ywd73nkT3sfTePDCckaHu8gOK +z4/WS1rCOO6z+wM4sFWH8vCj7DaV3PtbiYyVB+zgyrXnQaRCLzM6t8CNNkly8v+fh3FaPsQk9+ lCKWMCGw40cLknqN5FXG9kmDaHXs37uBhaSw1TrrjC1FNmEOQOgpEyN+pvOiz9anUoRCbXgldRy Tjpm X-Received: by 2002:a17:90b:568d:b0:380:f85c:94b4 with SMTP id 98e67ed59e1d1-3931e02fb3amr5399769a91.7.1786611153889; Thu, 13 Aug 2026 01:52:33 -0700 (PDT) Received: from phuc-desktop.. ([14.160.25.72]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ec0223e31sm5465372eec.25.2026.08.13.01.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 01:52:33 -0700 (PDT) From: phucduc.bui@gmail.com To: Kamal Dasu , Broadcom internal kernel review list , Andi Shyti , Florian Fainelli , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang , bui duc phuc Subject: [PATCH 1/3] i2c: pca-platform: Handle errors from optional IRQ lookup Date: Thu, 13 Aug 2026 15:52:11 +0700 Message-ID: <20260813085213.44001-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813085213.44001-1-phucduc.bui@gmail.com> References: <20260813085213.44001-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. Propagate negative errors other than -ENXIO. Signed-off-by: bui duc phuc --- drivers/i2c/busses/i2c-pca-platform.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c= -pca-platform.c index c0f35ebbe37d..63c8ca1f1870 100644 --- a/drivers/i2c/busses/i2c-pca-platform.c +++ b/drivers/i2c/busses/i2c-pca-platform.c @@ -139,8 +139,11 @@ static int i2c_pca_pf_probe(struct platform_device *pd= ev) =20 irq =3D platform_get_irq_optional(pdev, 0); /* If irq is 0, we do polling. */ - if (irq < 0) + if (irq < 0) { + if (irq !=3D -ENXIO) + return irq; irq =3D 0; + } =20 i2c =3D devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL); if (!i2c) --=20 2.43.0 From nobody Tue Sep 29 03:53:13 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEA0E445AC8 for ; Thu, 13 Aug 2026 08:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611161; cv=none; b=s/CVb2Pv/OmE51d3eKDpOuAwhoMvoOEhgX506kierpfA6fEW/uI/CJ6YBf8xPI+mgF6ifxDaEqCvAKZQ/eP8AnbLAiPKI4ATv6nPczDCsKN0j0Hm33mdV3abT8nh5rook8Mh2ajW/zkQmxPEtHuQQvsHNs0o/kVzrYobnHsZCCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611161; c=relaxed/simple; bh=KjvjKvkgL644W4yGzFffrW4wGqvGgxi3zwpZYuA1u/U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DHJvrp41qluNfbLLbVFc7uHR01ZPezxC9+zN6x8ZTFcvo/sUxlu4JOzOXo/5F114AJqTs3mQzVZbTsYkFol4jcn6pJqrsj8duDd9JYqc7yY6V10KEtnX+NmQuL75Pmhi5Y2FSpnfBD3UqeZEAkh27henl2/xLbHtrIBI4/21QdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B6f/bHOx; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B6f/bHOx" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-cbedf318752so1390186a12.0 for ; Thu, 13 Aug 2026 01:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786611159; x=1787215959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+jR/AjpIRwYXk9oHrDaUFtlf2egH/aUGrOWWf2J37lM=; b=B6f/bHOxnOAUh63MteX4T72gKEFI3Rs05Ubn/MUgnhlTFrwI2iwbbqlieMOBqm//CW Go9q+XUCIaPnM7bPrFl7DqXr8zraFxZtLT30O9/SaEAo4qu89FSA4IGgzQqoVD6XanHC 6suHYUyt2g+6QefE5gkBeBtz1sMnbT5oHpwNGOMp6OOsmsw+z9Xte7iWY3oWVWgrTYfw DteMVylGLhciq9vBaH4F18WQlkrwLrq5ujRaI/Fkuao3mBx/KS+f9kUlHOC5O6GdM8Qe lRgIl8+EN617qugQXl3cwy3HP/JMAB2QXqxN2jxewuNlwHcOpML13IRe/J6p4qxD56/u BMpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786611159; x=1787215959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+jR/AjpIRwYXk9oHrDaUFtlf2egH/aUGrOWWf2J37lM=; b=DrD2/Gob8cLY3nwPzyY+zC2mUb6jo1YeKoBTl1rW8g81Imd+SWok55t2d7UXYPAKKD agfcTzTSR9+MZSjYFBql8g/MZ3OGHLtJedXBXm3OUXMNaxYL0Bya6ZBRBXCFiRwPLQdI pry3fvbQRNyXINJhwKbL1KV+db/QrtL9Q6LZU/0bu2D+iYtdTlvG0y1SQJGOI/e7Kwmq kstT/gwkkkLRQxwNelTDRS+QLl3UB0XTJ0Qddf0+UytBXhiD46jmaTCLiQawTQacHlba XjzsjulizSnlinI3Wl7+i9pcK/j5jXw8P3nybHFCV8FwCugR1xGT0lxiUz+cfDJEbb67 XFfw== X-Forwarded-Encrypted: i=1; AHgh+Rr1K2DBH6pxc51O2ESROBJZpcZidOzgEe9EUNLf35vdJDh66eCFwfe1xQ7q6Pu65CQQDvNl2vuOmDX2Ysg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfa5zo7wJHOizKYIbXyV+wiByP0Euc/VyigHCGew2nhdsqfCOw 0TrVx2C0a8Ref/hGx1b0G47RYzPhMDaJljY8DYhZaHlfU+TvJQasUpJ1 X-Gm-Gg: AR+sD1082JGwDXF6/p4RBd4FJs7HNQ/ClTQqNEvTqheyUNDFq+GVHqJaPoD+BDTZ3IX hCGmWKpV5CxprUABuCKpKichXfRF61h5ZaXILfQXxuXNrxEjIGJQQzHm5ZY8Ww368EgkVb+3YG4 CESlZl3Xj9is4ETFY5NuYQcb5JkU1kOZ4I20q0CvvBDqEDjm7orZCt9Bt/cG5HVtayfy7APYNWQ 0R6vw5lFE1QI22fFSenWtJiyeDuzB1Xn3D/CwIzc97txU00zomLlMXosv/dmNITqThYgAbVQitz KH2HhK3vFY3QcAOa5gCTSzeqNPW4811mNbD+Wxg9fEkxm7S0Kg5Ua3WLlW6zb5+8uuZ2QGcGGV7 I1w0VOulYmaM5uYQDXlyk8S6X96GcEmfzhKIaITPjdm/sHCYTrc/VBMfdtsxW4AxWnz3vEj9P1a O0ZFP58b9Vkkp6ieqbpiIhJRVPRvl8IAqTssaiRKrHLiQeJk97ojguCaDBfNldGWWlVlSmP6a+z UFP2vT+dUGRUzAzbQYMZyH5QWkAJ0v/ezI05VBsWpyC/xty/4n76tdkW4G5UNq3y5lu586Kqvpg UiM/vxmEytunATY= X-Received: by 2002:a05:6a20:6f02:b0:3cc:36a0:3ff6 with SMTP id adf61e73a8af0-3cc553971a7mr6274859637.19.1786611159290; Thu, 13 Aug 2026 01:52:39 -0700 (PDT) Received: from phuc-desktop.. ([14.160.25.72]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ec0223e31sm5465372eec.25.2026.08.13.01.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 01:52:38 -0700 (PDT) From: phucduc.bui@gmail.com To: Kamal Dasu , Broadcom internal kernel review list , Andi Shyti , Florian Fainelli , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang , bui duc phuc Subject: [PATCH 2/3] i2c: brcmstb: Handle errors from optional IRQ lookup Date: Thu, 13 Aug 2026 15:52:12 +0700 Message-ID: <20260813085213.44001-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813085213.44001-1-phucduc.bui@gmail.com> References: <20260813085213.44001-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. Propagate negative errors other than -ENXIO. Signed-off-by: bui duc phuc --- drivers/i2c/busses/i2c-brcmstb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcm= stb.c index 5fa30e8926c5..91525a36e575 100644 --- a/drivers/i2c/busses/i2c-brcmstb.c +++ b/drivers/i2c/busses/i2c-brcmstb.c @@ -648,6 +648,8 @@ static int brcmstb_i2c_probe(struct platform_device *pd= ev) =20 /* Get the interrupt number */ dev->irq =3D platform_get_irq_optional(pdev, 0); + if (dev->irq < 0 && dev->irq !=3D -ENXIO) + return dev->irq; =20 /* disable the bsc interrupt line */ brcmstb_i2c_enable_disable_irq(dev, INT_DISABLE); --=20 2.43.0 From nobody Tue Sep 29 03:53:13 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3508446846 for ; Thu, 13 Aug 2026 08:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611167; cv=none; b=iYgWA/C6hGYbQEeoZfN5Mok4TnLqp+ijNyxsYiWGys9wE5FD6NWUlfOX075HUz7ZHa6q5jtmzrXxifFZZ571YFQ5J+SwmC9HjIfOCAvm3GAVU1bIe9SNNphs5d3hH80EStTZqHy1/57GGgUYTxwAOzPXZKMPhaWg+bSJSlcQ6+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611167; c=relaxed/simple; bh=ldbF5ILBtjfVdXOICss/RvJxBQ+h5ZIfdab/mT+/gKk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nPQiHtbK8Y17jZyKvHXxMbJXscXu3JQkF2gS6LjqU5PpZjGfH7dy4Kc8dcuJCo2ww0674zEr118crCvNHiNb9wqEHrHvO1dJofXnMWNgUnCEh5U3P4rAp1UawD/uQNGuZ8gCLGVL3RKk1lQbJ/phBtwTNRfBQqXc3R9avy3mns8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aKMSe8rB; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aKMSe8rB" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38ea87caafeso1784105a91.3 for ; Thu, 13 Aug 2026 01:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786611165; x=1787215965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sX9XI6O6qjCjlu3Bv7EdsrhNGWhNvzRT2+KyAOXZhAk=; b=aKMSe8rB+bOM7nIKZPrqaIcQ+zsSf5HAW4IAAZW+xj1HQJdFdRstb5GRwXycvF4ZWe E3tA9XPUX8mKMVu9OxuYTCSA5fD068gyTF0aOnASajKyEUMxvPBvevUvJfo96s+Lxuyk 2u7RHratoi2iY0o5oq9/81ncqcsicFhZDM580xHCQbrMd4fN69yinuHPe2vYjbjvdSPQ S7Zwj7wehsojA7OLR13GPTF6njsmNP4uLfSU1Mep6SfR0NOg6EfFo+Iq56xmFXuyXl7j B7I8UqyeqJGBTAIHdYNxpIhD8VPFBHuJvzN4idFBkDR6x4dJwGNrBrqDsXKDGlgbnjHr XSAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786611165; x=1787215965; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sX9XI6O6qjCjlu3Bv7EdsrhNGWhNvzRT2+KyAOXZhAk=; b=CmNiFjdn5HPh5SopaW/NBfTtS0BRyHq48xOLEb3Fy4Mf+s7EPwxCb5lLbM3e56lxfk 1xe5Um9d5jH4TdiXW1yGitaEBtaC1gJ5HGWXegv7aEuOYrCXzR8f/bHacBIOOWISqer9 AIE3Eb/Up9tzd2YP8rSof/DhcnYeWRUjY96BIna9cbbiSauVRoKTp1FLqn0gHIqnrHFE rWAjmsYl148IyKxaFm/8IbmrAwKUJ5ZL4/zAfiMFMWAFUYFn1COwgRfpFK2rvux0V2GX lBElgj8CVUj00i50dVoXnQ927rb1llfOJVxcK7c3xITze2eil5ODhyZSBmP27u6i7+Cw /Hkw== X-Forwarded-Encrypted: i=1; AHgh+RqTX78BWT43zAIHzaO/OngvNNkFJVftmDTyG5UNu5a4ofg/cc96/nvicr11EiWjUeHwrleBJPF+qv48nzs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy504l1XEwaXxvCoycb+rXcX/Acj+PGAKg0MXHJkxMiCaxR5DYI P07rLSmYnDaQ7Td0e8KBa+4v3+N/Ho8NwMmkEnYMr0ZU6PKqxIEiGc86 X-Gm-Gg: AR+sD136smpf3bg2S3UIdZkPfVG11z2Qs81WC3btwU7adO7Z4qDyEtxH3frQN4/VO40 tkSzGuD2g1tQRwgRMs1HRn73hRwE522VebgnmMypHzf7yYaySW//+kdAtNHBGi6lECGzQ2jhnCy zKoWzhSrGqM0KjtQ7y9U3PRWT6hev12sxVkwwfZ4an8vyPRIOcWr7FYMy52t86ulowJQzh4i9Go gOOt26rR1dlOirqkq6CgCuKQh2ImRtBGOAZflJc4y3rqWH9Vg87KHNfzlPt0GFMm9P2XCVIe9Ow cHIEujHGHB8tuYFcKUT0Zee/ffQq0gRe7uJREmkhkXm+PkUqUp2NSovjRCd0sBK3/YASD690Xo1 RGq7K1CBYVeS5dplIXehAkwh8ih1tt0SGI8wwjVDf/2/u4L13tc1Vs3duogqxWkZrXCRKmN6otT qamRIFgFVSEtod61KtQ17J/GkO53TPB0dVuxrag5B7uLunlMiG+Kp+qp3R196FGsSU0rJVh4BsK YAvdOk/I9e6vA4Xoq9cSHqlOoFWDq3SfF6sZwGRXu+Ik1PwyQpOtyKKu+v05qs2GEQ18q25qg/R le+sdBhNlBQIzOc= X-Received: by 2002:a17:90b:278e:b0:381:25ce:bcc2 with SMTP id 98e67ed59e1d1-3931e0242f8mr5395506a91.6.1786611165058; Thu, 13 Aug 2026 01:52:45 -0700 (PDT) Received: from phuc-desktop.. ([14.160.25.72]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ec0223e31sm5465372eec.25.2026.08.13.01.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 01:52:44 -0700 (PDT) From: phucduc.bui@gmail.com To: Kamal Dasu , Broadcom internal kernel review list , Andi Shyti , Florian Fainelli , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang , bui duc phuc Subject: [PATCH 3/3] i2c: brcmstb: Correct optional IRQ handling Date: Thu, 13 Aug 2026 15:52:13 +0700 Message-ID: <20260813085213.44001-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813085213.44001-1-phucduc.bui@gmail.com> References: <20260813085213.44001-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc dev->irq is assigned from platform_get_irq_optional(), which returns a non-zero interrupt number on success or a negative error number on failure. Therefore, 0 is not a valid IRQ number. Check for a positive IRQ number before requesting the IRQ instead of treating 0 as a valid IRQ. Also use a positive IRQ number when reporting the operating mode. The driver sets dev->irq to -1 when devm_request_irq() fails, so the mode check should only consider positive IRQ numbers as interrupt mode. Signed-off-by: bui duc phuc --- drivers/i2c/busses/i2c-brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcm= stb.c index 91525a36e575..3adc73f3d608 100644 --- a/drivers/i2c/busses/i2c-brcmstb.c +++ b/drivers/i2c/busses/i2c-brcmstb.c @@ -655,7 +655,7 @@ static int brcmstb_i2c_probe(struct platform_device *pd= ev) brcmstb_i2c_enable_disable_irq(dev, INT_DISABLE); =20 /* register the ISR handler */ - if (dev->irq >=3D 0) { + if (dev->irq > 0) { rc =3D devm_request_irq(&pdev->dev, dev->irq, brcmstb_i2c_isr, IRQF_SHARED, int_name ? int_name : pdev->name, @@ -697,7 +697,7 @@ static int brcmstb_i2c_probe(struct platform_device *pd= ev) =20 dev_info(dev->device, "%s@%dhz registered in %s mode\n", int_name ? int_name : " ", dev->clk_freq_hz, - (dev->irq >=3D 0) ? "interrupt" : "polling"); + (dev->irq > 0) ? "interrupt" : "polling"); =20 return 0; } --=20 2.43.0