From nobody Tue Sep 29 02:33:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEDB843441C; Thu, 13 Aug 2026 07:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605570; cv=none; b=omlmDvyIVglIOv6m9e1xbPker4DHEAmyS2mHb4PT4nZGIw1K4ZwfzPLWpO+6c4wFYTiW5gWMd1Wbsp59yaMsakmgdpxeYu1sjPXnTMByuacufvpYpRe6qqeZbLfpejhKaVVB98A7s17IpR4QWfLDTnRpi8cVQLW2qCix4mMsojQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605570; c=relaxed/simple; bh=eAWIBrQWLETu+nZHLtHg3nJVtjZwcFnWQJ7W7jTlwW4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VamKh8nOg7RJcQ4lHGgzYnolHVrVF69NwvlHGmETqUy7/chaGUej317AFZZahCjPigHVMnRlqlkjiAtJ0mbMW/veX5219WJ8ure3aHaEMcDXDvvKDP4ejNkwqquXI5zxEs2IgLtRAe7p052q/yK5meQbDwyitoMcqmIPYm45l/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WpHQS9sP; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WpHQS9sP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786605567; x=1818141567; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eAWIBrQWLETu+nZHLtHg3nJVtjZwcFnWQJ7W7jTlwW4=; b=WpHQS9sPiEozZHhiHyqaYYf377JgYNEKRe8vyA/rhGObyc05dDqgJIeC 6CQiv9rKce5wBPOXNTRRWMDIZssmq923CpJSczRWMyY92W41DAxjoCPpc NkOfVBOxKPziRjhCQM5Af+7zsIS+tdTwc9ts9iqGIWOuVFB5JZqCu3d3b fBErAJFvyqA/7ScDBY91EVAaWFisAPV/Sq+vjP3j9bv04gvTr31/ExF+q ohEfa2ZqBSiuABnAqxOUttSFYzweO8cPdHuXQ7GCjuVQ+jMSm8tcMrc9l oJsieMb6W+QJBLTUzk1br7jP4WnOVlntpRPWxgCsZX/ADXWnqcGX7Lgv6 w==; X-CSE-ConnectionGUID: zWb+eCvaTQybRtRggQge1g== X-CSE-MsgGUID: PsS7HrRPSbulQ0MmokrNHg== X-IronPort-AV: E=McAfee;i="6800,10657,11873"; a="86936983" X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="86936983" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2026 00:19:19 -0700 X-CSE-ConnectionGUID: 5TiFO+P4Ro6bKMzgpBJxeQ== X-CSE-MsgGUID: VwxuEc0oRnqQnUuWedXykw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="268138715" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa005.jf.intel.com with ESMTP; 13 Aug 2026 00:19:16 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id DD60F9B; Thu, 13 Aug 2026 09:19:14 +0200 (CEST) From: Andy Shevchenko To: Jonathan Cameron , Maxwell Doose , Sakari Ailus , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marius Cristea , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Tomasz Duszynski , Jean-Baptiste Maneyrol Subject: [PATCH v1 1/4] iio: light: Unshadow error codes in ->store() Date: Thu, 13 Aug 2026 09:16:50 +0200 Message-ID: <20260813071912.2465208-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> References: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kstrtox() may return different error codes. Unshadow them in the ->store() callback to give better error report. While at it, add missing kstrtox.h inclusion. Signed-off-by: Andy Shevchenko Reviewed-by: Maxwell Doose --- drivers/iio/light/isl29018.c | 7 +++++-- drivers/iio/light/lm3533-als.c | 11 +++++++---- drivers/iio/light/tsl2583.c | 15 +++++++++++---- drivers/iio/light/tsl2772.c | 16 ++++++++++++---- 4 files changed, 35 insertions(+), 14 deletions(-) diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c index 759cb71ed1c5..7f7a563df4d9 100644 --- a/drivers/iio/light/isl29018.c +++ b/drivers/iio/light/isl29018.c @@ -10,6 +10,7 @@ =20 #include #include +#include #include #include #include @@ -339,9 +340,11 @@ static ssize_t proximity_on_chip_ambient_infrared_supp= ression_store struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct isl29018_chip *chip =3D iio_priv(indio_dev); int val; + int ret; =20 - if (kstrtoint(buf, 10, &val)) - return -EINVAL; + ret =3D kstrtoint(buf, 10, &val); + if (ret) + return ret; if (!(val =3D=3D 0 || val =3D=3D 1)) return -EINVAL; =20 diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c index 99f0b903018c..5db9591a85b9 100644 --- a/drivers/iio/light/lm3533-als.c +++ b/drivers/iio/light/lm3533-als.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -434,8 +435,9 @@ static ssize_t store_thresh_either_en(struct device *de= v, if (!als->irq) return -EBUSY; =20 - if (kstrtoul(buf, 0, &enable)) - return -EINVAL; + ret =3D kstrtoul(buf, 0, &enable); + if (ret) + return ret; =20 int_enabled =3D test_bit(LM3533_ALS_FLAG_INT_ENABLED, &als->flags); =20 @@ -542,8 +544,9 @@ static ssize_t store_als_attr(struct device *dev, u8 val; int ret; =20 - if (kstrtou8(buf, 0, &val)) - return -EINVAL; + ret =3D kstrtou8(buf, 0, &val); + if (ret) + return ret; =20 switch (als_attr->type) { case LM3533_ATTR_TYPE_TARGET: diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c index 53fd423aa7ae..2d041b7530e6 100644 --- a/drivers/iio/light/tsl2583.c +++ b/drivers/iio/light/tsl2583.c @@ -7,10 +7,11 @@ * Copyright (c) 2016-2017 Brian Masney */ =20 -#include #include #include #include +#include +#include #include #include #include @@ -483,9 +484,12 @@ static ssize_t in_illuminance_input_target_store(struc= t device *dev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct tsl2583_chip *chip =3D iio_priv(indio_dev); - int value; + int value, ret; =20 - if (kstrtoint(buf, 0, &value) || !value) + ret =3D kstrtoint(buf, 0, &value); + if (ret) + return ret; + if (!value) return -EINVAL; =20 mutex_lock(&chip->als_mutex); @@ -503,7 +507,10 @@ static ssize_t in_illuminance_calibrate_store(struct d= evice *dev, struct tsl2583_chip *chip =3D iio_priv(indio_dev); int value, ret; =20 - if (kstrtoint(buf, 0, &value) || value !=3D 1) + ret =3D kstrtoint(buf, 0, &value); + if (ret) + return ret; + if (value !=3D 1) return -EINVAL; =20 mutex_lock(&chip->als_mutex); diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c index 4486a1d9d84d..c8a7afc65c1f 100644 --- a/drivers/iio/light/tsl2772.c +++ b/drivers/iio/light/tsl2772.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -951,8 +952,9 @@ static ssize_t in_illuminance0_target_input_store(struc= t device *dev, u16 value; int ret; =20 - if (kstrtou16(buf, 0, &value)) - return -EINVAL; + ret =3D kstrtou16(buf, 0, &value); + if (ret) + return ret; =20 chip->settings.als_cal_target =3D value; ret =3D tsl2772_invoke_change(indio_dev); @@ -970,7 +972,10 @@ static ssize_t in_illuminance0_calibrate_store(struct = device *dev, bool value; int ret; =20 - if (kstrtobool(buf, &value) || !value) + ret =3D kstrtobool(buf, &value); + if (ret) + return ret; + if (!value) return -EINVAL; =20 ret =3D tsl2772_als_calibrate(indio_dev); @@ -1061,7 +1066,10 @@ static ssize_t in_proximity0_calibrate_store(struct = device *dev, bool value; int ret; =20 - if (kstrtobool(buf, &value) || !value) + ret =3D kstrtobool(buf, &value); + if (ret) + return ret; + if (!value) return -EINVAL; =20 ret =3D tsl2772_prox_cal(indio_dev); --=20 2.50.1 From nobody Tue Sep 29 02:33:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4E113E7BC6; Thu, 13 Aug 2026 07:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605564; cv=none; b=dH+WU57/MRbi6xlNXXqTJHRWVEdpI+BV//A3R2tId32WCivod75oL495pJ/oh18Sn1VejZDIqBKFw9FNtpIaFLYK1E6mQb32p7utt7ZyGJ//sDEO5D4OgPRenrAbjLjJHKfJb2bMoBiCDWJErHPDjH3uUtdff+16cgLCN4I9jt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605564; c=relaxed/simple; bh=uRV56n5MxzD2fGsyRgTGrGLMf5tZTR65vbwBkxNa7W4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T9eCHVe1QJHLkmPt9ea9JbKpCuv7WWR3pU56F37aW1YAwlmnbzd/WB2qb0yAnqylx6poDeDD5Mm6OU7yVp3/X4aGvAIHEbQNFfYMl2kSTRSN9Xs+ZQUagGimMwBCacLCV5cGoicqDQaWLAT3wglY34exiMucMjaO5NM8f6oX6o0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VeVr9qku; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VeVr9qku" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786605560; x=1818141560; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uRV56n5MxzD2fGsyRgTGrGLMf5tZTR65vbwBkxNa7W4=; b=VeVr9qkumGPEVXcm8qZ0da5v1LS2MdUVcVBxnxK5GPe37504rjlwcyTa hftkhxuNGPfq/gMQQliw6C+EcxqImP5T7hQx778Jl3NskwfuVhfScYJzo QgaU6VpMGHpxw/RUbndPaIi9HvgwnrrSLnvkbHUPxCTxlWoxH0+Ssz+61 /DyfhgSzUZcC5JUgIh2dhaNUhNvUGWrKL83yS8ymSKt3XK8TTvvPSG+mk Tht0lb5JzvgiDBwcdUe7IQiLgUgBobINGAf9vixPIUZIk0AxtKYZHxyQ2 BhQ+iPLBpFo/QZejBX2qofiMzfmajjpid+GLFGeqBiWd2qMxllo0joRbT g==; X-CSE-ConnectionGUID: /rxkie1dT8KajmxaO8eJZg== X-CSE-MsgGUID: ahlsysVpTymkaQM3m4Hcaw== X-IronPort-AV: E=McAfee;i="6800,10657,11873"; a="86936967" X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="86936967" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2026 00:19:19 -0700 X-CSE-ConnectionGUID: x+oaR0miRJC+Gus05eNzmw== X-CSE-MsgGUID: fzyFRs8RQgiaMVnC3K11gg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="268138716" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa005.jf.intel.com with ESMTP; 13 Aug 2026 00:19:16 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id E88859D; Thu, 13 Aug 2026 09:19:14 +0200 (CEST) From: Andy Shevchenko To: Jonathan Cameron , Maxwell Doose , Sakari Ailus , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marius Cristea , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Tomasz Duszynski , Jean-Baptiste Maneyrol Subject: [PATCH v1 2/4] iio: imu: inv_mpu6050: Unshadow error codes in ->store() Date: Thu, 13 Aug 2026 09:16:51 +0200 Message-ID: <20260813071912.2465208-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> References: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kstrtox() may return different error codes. Unshadow them in the ->store() callback to give better error report. While at it, add missing kstrtox.h inclusion. Signed-off-by: Andy Shevchenko Reviewed-by: Maxwell Doose --- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/i= nv_mpu6050/inv_mpu_core.c index 5796896d54cd..38c3f3b398d4 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -1303,8 +1304,9 @@ inv_mpu6050_fifo_rate_store(struct device *dev, struc= t device_attribute *attr, struct inv_mpu6050_state *st =3D iio_priv(indio_dev); struct device *pdev =3D regmap_get_device(st->map); =20 - if (kstrtoint(buf, 10, &fifo_rate)) - return -EINVAL; + result =3D kstrtoint(buf, 10, &fifo_rate); + if (result) + return result; if (fifo_rate < INV_MPU6050_MIN_FIFO_RATE || fifo_rate > INV_MPU6050_MAX_FIFO_RATE) return -EINVAL; --=20 2.50.1 From nobody Tue Sep 29 02:33:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AA7643550A; Thu, 13 Aug 2026 07:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605567; cv=none; b=MT7Jdr/xzO8lGbXJunif5SBJUeOftiuUPRpDs5Tw37VH7Z8mkX7L3O3flOXHJMxNQsuDfSmVuH6nuua44r4qffoRzv7LMxmmP+WwG8i0CJ6Xq4aK7noENJDt3EePZTV3At1Oqv7rIUYiH8H4tP/8lGhudKbeySOPyS87wk7kkYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605567; c=relaxed/simple; bh=oqgL0oIQvfUY3wKeSrEAs/o9m4Hle+wsoIiN9GUcc84=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YgwHhApx1BRv3G30RXrMFtC99+VZsmd84l2ACp6QWeSqwgWW1134OMMR32qFNu64cqFBrjIvIJOqtnNUFFL+LIaFyoczv5ANQAm0z0BhZgkoonuN1tNtuXFR3r1lmi8NZtxqgi0ri+wXQCEVqahhpGyC4wvGUwkL/N4ok8N/YdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bCFWM2v1; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bCFWM2v1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786605560; x=1818141560; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oqgL0oIQvfUY3wKeSrEAs/o9m4Hle+wsoIiN9GUcc84=; b=bCFWM2v1Ls97xVukXiY5AOSjwCiatzVzPusCLYdbTjvyhYXwRrWkMn4X PJ2TAgaBZdlFuodk4hNSWCzMKs4pSqqrjNCE0JipvueOFbtbmSr2nKi5o 8DSwuoAoHq+ezpDG9vOAzjCNGi22pLVNDQj6UxXOTBOB6TRDxM45qye3A yoLTmQANVsrPm/ugSlvsXx6AZu5GApsBDcoZQTxdhDD2JcN0R4ZGY+nSR 9pZYrWmR9SECm3jhU4COTd4seBMmIuqXC2z4P3qr7dpUEfgIsAXukfnCB BCwGvM2yBCLZSYl3paa0bdbcymo0XIF3/c6kLLS5ZTcgHLU7SXT15kPXE A==; X-CSE-ConnectionGUID: yQ8TrAokQI6rhra4uDSmPw== X-CSE-MsgGUID: CLuIje9sRyOSr2lT0Dx2QA== X-IronPort-AV: E=McAfee;i="6800,10657,11873"; a="87297005" X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="87297005" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2026 00:19:18 -0700 X-CSE-ConnectionGUID: juHRrH4URuSF/WL0oWe4Kw== X-CSE-MsgGUID: P/XcKvVURu+eVf9bbewa7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="263402936" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa008.jf.intel.com with ESMTP; 13 Aug 2026 00:19:16 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 01B4E9E; Thu, 13 Aug 2026 09:19:15 +0200 (CEST) From: Andy Shevchenko To: Jonathan Cameron , Maxwell Doose , Sakari Ailus , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marius Cristea , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Tomasz Duszynski , Jean-Baptiste Maneyrol Subject: [PATCH v1 3/4] iio: chemical: sps30: Unshadow error codes in ->store() Date: Thu, 13 Aug 2026 09:16:52 +0200 Message-ID: <20260813071912.2465208-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> References: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kstrtox() may return different error codes. Unshadow them in the ->store() callback to give better error report. While at it, add missing kstrtox.h inclusion. Signed-off-by: Andy Shevchenko Reviewed-by: Maxwell Doose --- drivers/iio/chemical/sps30.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c index 8e15baa31423..b47d08ab4d0f 100644 --- a/drivers/iio/chemical/sps30.c +++ b/drivers/iio/chemical/sps30.c @@ -15,6 +15,7 @@ #include #include #include +#include #include =20 #include "sps30.h" @@ -193,7 +194,10 @@ static ssize_t start_cleaning_store(struct device *dev, struct sps30_state *state =3D iio_priv(indio_dev); int val, ret; =20 - if (kstrtoint(buf, 0, &val) || val !=3D 1) + ret =3D kstrtoint(buf, 0, &val); + if (ret) + return ret; + if (val !=3D 1) return -EINVAL; =20 guard(mutex)(&state->lock); @@ -230,8 +234,9 @@ static ssize_t cleaning_period_store(struct device *dev= , struct device_attribute struct sps30_state *state =3D iio_priv(indio_dev); int val, ret; =20 - if (kstrtoint(buf, 0, &val)) - return -EINVAL; + ret =3D kstrtoint(buf, 0, &val); + if (ret) + return ret; =20 if ((val < SPS30_AUTO_CLEANING_PERIOD_MIN) || (val > SPS30_AUTO_CLEANING_PERIOD_MAX)) --=20 2.50.1 From nobody Tue Sep 29 02:33:19 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFEEB43785C; Thu, 13 Aug 2026 07:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605572; cv=none; b=o9ux8GhO3FqeW2jRUwcDmXXBCxy3PKLCzM+Y6DWKJdNacM4QDxP9JW2Yc+yJgRXMK0MSBk4mmAXacWT4Hxv4vugZS6rnZNY1M/5Y4EY3LjUaFvsjIf4nZIs0AbCOirUAPnc2y5ppirITlZNy+N5Ud4ZoQ/eToc2rR5qXX3ZoP9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786605572; c=relaxed/simple; bh=4vEfbJ1bFrwiB8zuPyABnVqy7qXxeSMyybLAVMQoo1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gSic6I9AdOkE3eHXbzUW2I8ma9/ZjAa5Lk+ATdgcFQstgdQFKL8G4Iol3hz4DS+RqQzJy+C45rYXQbEJ6qO1KCykzS5OsSuolxZjKz2gInXfmU9Stug3CwlA19MBjRASDpcaItdWR0MV8toUjqhRidgQkz6fumLWjbUXZzZhox8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=es6QJpCq; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="es6QJpCq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786605568; x=1818141568; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4vEfbJ1bFrwiB8zuPyABnVqy7qXxeSMyybLAVMQoo1k=; b=es6QJpCq8nJpb4ViigwZjDK5yPksfKFVDpwyySXF+6kZ4hj1U6JcNYHL WEJl5SF8CMuOEW4SrujpBKSErO2XnJUW/+61AMSSapgLtcuGPkSW7CiIj VIysQCKoUD++Nx/1dhGGwkhsm8htNqs5DXjjWJHsEooDMmG8SFf4zQYUS eIxn+RYLCd+jYYflj3OQZBRPnLfy6VpXsZ9rWgGCdvmqLIopPKckcthq9 LPMn49/dft+Z6rbQDRtj8LD8h7meMP/5TsxcSZMqzNJQJbGUaQ+oKm07a 1bxlZ3V0arIqcRpWH/2pSAO79J/+b9HmmJwx72xD1oBd8gLdpUAXi9Utw w==; X-CSE-ConnectionGUID: 0iKr0ltVQCWAEZxG+DsL5Q== X-CSE-MsgGUID: qEnWypWFQTuZdMTq8Ekk7Q== X-IronPort-AV: E=McAfee;i="6800,10657,11873"; a="87297017" X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="87297017" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2026 00:19:18 -0700 X-CSE-ConnectionGUID: VUvg0XJyTZq/rlVIpU5egw== X-CSE-MsgGUID: jj4+YFg1SlmR94MBqFVfSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,220,1779174000"; d="scan'208";a="263402935" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa008.jf.intel.com with ESMTP; 13 Aug 2026 00:19:16 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 0D985A1; Thu, 13 Aug 2026 09:19:15 +0200 (CEST) From: Andy Shevchenko To: Jonathan Cameron , Maxwell Doose , Sakari Ailus , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marius Cristea , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Tomasz Duszynski , Jean-Baptiste Maneyrol Subject: [PATCH v1 4/4] iio: adc: pac1934: Unshadow error codes in ->store() Date: Thu, 13 Aug 2026 09:16:53 +0200 Message-ID: <20260813071912.2465208-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> References: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kstrtox() may return different error codes. Unshadow them in the ->store() callback to give better error report. While at it, add missing kstrtox.h inclusion. Signed-off-by: Andy Shevchenko Reviewed-by: Marius Cristea Reviewed-by: Maxwell Doose --- drivers/iio/adc/pac1934.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c index 23055405a6e0..2d934452eb11 100644 --- a/drivers/iio/adc/pac1934.c +++ b/drivers/iio/adc/pac1934.c @@ -19,6 +19,7 @@ #include #include #include +#include #include =20 /* @@ -494,11 +495,13 @@ static ssize_t pac1934_shunt_value_store(struct devic= e *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct pac1934_chip_info *info =3D iio_priv(indio_dev); struct iio_dev_attr *this_attr =3D to_iio_dev_attr(attr); - int sh_val; + unsigned int sh_val; + int ret; =20 - if (kstrtouint(buf, 10, &sh_val)) { + ret =3D kstrtouint(buf, 10, &sh_val); + if (ret) { dev_err(dev, "Shunt value is not valid\n"); - return -EINVAL; + return ret; } =20 scoped_guard(mutex, &info->lock) --=20 2.50.1