From nobody Tue Sep 29 02:32:57 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F2A23FA5CC for ; Thu, 13 Aug 2026 05:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599270; cv=none; b=RJBOjs6Ljnw/4NCDqw+2t1O1V9UXUsZnDn8CbaMqpCkMnfSbIqUloFf+duHyWXeTxqXTmB5vDBcKATEoQdHQwNyYeJg28QHgIevXniXEMYrldeTDfmL9EaNfrZFsKQsOHB9oJPpHvIjYcbW08U5Vqzv4lnJyUHhKFiS5uWgLbfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599270; c=relaxed/simple; bh=Mhj3jWYbiVdYMnI3fvWRvTxrfRl3RdIu2H/JxIENP4k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XzKiZ/FLXwF1aQnWOiq0nHIDEWifa9j/wbnb1pmaN9GPEFE6kZ98xbSBEV4C6RvKDrWyYfhQfVfsgANapqM2PTIZqVdondbXJQWnP5NLJ90qRjhPRg8+JlrorL+sXRha7EsMR5PLZJFFJ26cNw53Le/QWJQhKt1CzvIVH9Fdaxw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BUPuLKOD; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BUPuLKOD" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3811f512167so2274863a91.3 for ; Wed, 12 Aug 2026 22:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786599265; x=1787204065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Sg48OebW8O5DYM3I5rKP0/NygxmXw5dDjKnd0RIjz50=; b=BUPuLKODAaPmgjLsr7zfA8+I8jTgKDiqW9sS+gl1leplmc6MFmiIg2lew2BBTKRmOC iaUOtRNyrJaHfUL2oiVdJ5oSngJT5HYaS+Ey2jPvzWozH3415Ui6ViGhevEzlV3hnLY6 SVoeyya3HXarsFJJjo1bMr/8iYSyg2t7AacAn+EmZkv+3HDRoAMX5hbzSmigC1vCR4Dx xyVpr2VmYHhKy+RCLbmsAgFre5c4rKgA+VaoCFLRkjPbotggvKoSxRlEXQv37jLzve9u 8giV6Zi/fuUVfgOAlSuEqPANMH/K9WfhM+l8c9uhcZ4ksJwBiZ8h2NEmRVeaAe3vb3V+ 1nYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786599265; x=1787204065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Sg48OebW8O5DYM3I5rKP0/NygxmXw5dDjKnd0RIjz50=; b=Djkz/wIKn+IAlivR8knTOpt2hKJ/R9MdDKkeYK0xo5CJUZP4voefzPXOg9vnLtsN6k MR//j6i30Ugw8Adk183uxHMUPH2UvFhP/27btw658ZQ2cdTCCSaSLOOlkb5vOq/vtjKy KDuBRaZswYJMreEmhfKbtnSAF9EjbMJgRyqQvnWmZV/nEH4l4dFCmwzfv3It1FF7+TeS rdjfyMRP8zpeW0bjtDsQ/ZrLxtF3P7We+O+jzlytAxIiZG95G1rZfmU/RNiINzDYxXAJ 7Hr9zKA7MJ6rwDhk8Zt4Hh9bMwmZd3K89QFqlZln1sjesrhHWC5FrbL3uGmtjR/M36C3 aszQ== X-Gm-Message-State: AOJu0Yw9O9a8ffOzZFVBG+2fEoZ9oLgc5NtxP2eMES68ZMj1MRN1LhgK TSjMDk5UFX6cWJlzLtGoNFiRwSFk9wuVE2fb0/+AcNl9yxCAc69GPhOG X-Gm-Gg: AR+sD138zIkkkRIkG4VofvCTPwVvuALJtVDEHQXYTiMI/oMrLHdi+hrOqmxDM7e7OJT T1PcPvXJoWMJjnHUVioNXeOCfgTGqaVprosdllyozmSLqdB8Tyuw8UFINqUsDnCParYniBw+fLr PgZkFojtiZ1rbbzdRO2872qc2SM26FRW1z34WYEX+I/qw1xd2+Pyvhu8W+jDH8Qx23otDdCA3Ve +JMoylidifKcTz1JYSKiibzWmNQ1ucTdoOViEZrLqRmnESwj4+2ITD/KPUIvFwGCZZpUzzLnkuC BYmkiWbT6U4mAyRD6zx356wIK8zNKTnevS3wJp3PTIeamqtX2k1eRuN59GrwK9Chq8WDBXbmZvS 9eNrLbXAFKuntICpLR4ZlAM5WtNN+81FydjXrD2Zg5WWktYLmnz5IQqFxUQU5eK30yup57AwkXj I29KYL6wgzJBhrnkb88OC1YAuHQDYGw0J0iXmUkNYjrEldXASg/8PdPD92FrhqtR0wt70kby9Go Uk6rdW+HAgltYjhSrFSt6N8EAXegBZFDx5iQzzeCF2a2Yb9jS32KFTOPyduu09NKBe0fedl7oi0 E9uaLx5o/A== X-Received: by 2002:a17:90a:d40b:b0:393:19a3:4f1 with SMTP id 98e67ed59e1d1-3931e058763mr3777372a91.6.1786599264874; Wed, 12 Aug 2026 22:34:24 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3931d872ec5sm594734a91.0.2026.08.12.22.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 22:34:24 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 1/3] mmc: meson-gx: Handle errors from optional IRQ lookup Date: Thu, 13 Aug 2026 12:34:02 +0700 Message-ID: <20260813053404.21553-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813053404.21553-1-phucduc.bui@gmail.com> References: <20260813053404.21553-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. However, the driver currently stores the return value directly in cd_irq and continues probing. Propagate negative errors other than -ENXIO, and only assign the IRQ to cd_irq when a valid IRQ number is returned. Signed-off-by: bui duc phuc --- Changes in v2: - Initialize cd_irq to -ENXIO. drivers/mmc/host/meson-gx-mmc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mm= c.c index 694bb443d5f3..d2903e3dfd6f 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1141,7 +1141,8 @@ static int meson_mmc_probe(struct platform_device *pd= ev) struct meson_host *host; struct mmc_host *mmc; struct clk *core_clk; - int cd_irq, ret; + int cd_irq =3D -ENXIO; + int ret; =20 mmc =3D devm_mmc_alloc_host(&pdev->dev, sizeof(struct meson_host)); if (!mmc) @@ -1185,7 +1186,11 @@ static int meson_mmc_probe(struct platform_device *p= dev) if (host->irq < 0) return host->irq; =20 - cd_irq =3D platform_get_irq_optional(pdev, 1); + ret =3D platform_get_irq_optional(pdev, 1); + if (ret < 0 && ret !=3D -ENXIO) + return ret; + if (ret > 0) + cd_irq =3D ret; mmc_gpio_set_cd_irq(mmc, cd_irq); =20 host->pinctrl =3D devm_pinctrl_get(&pdev->dev); --=20 2.43.0 From nobody Tue Sep 29 02:32:57 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E133F44F4 for ; Thu, 13 Aug 2026 05:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599274; cv=none; b=JcO/OQEWWn2IwOxbmRaMej/jKtlfoZDz348OPe/aLQZqU7+AVdqITHz3QukWLZukDFawrkBNfryMadlSKcj2fr6ZHjcyUz6WN+6Ij4os7SS8eNUC45FHvXWaia46lfE83ag9D8oh+63t5oYdKrhqUUCYqoPEAZN9fVsFp0RIfwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599274; c=relaxed/simple; bh=NLgdqVpvj8F7Pc9lFCCGOBeSdXFVDC7SLYvEkF+P6DI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aUsqc4wbqgFX1BHE+7kv+Sqbj26A0sucjq/aZt0DuIk/M0fFGoEInzuMyBabVI/y318qi2LG1u8eWP/ZuBFW58p4Kbd+aUte3cr/UBL3u5fxL2In49rJXFjliZJz8ZosRASqVduK9wkjUnvdGNjHvDRm+TryJM7yxsHRcKao74k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fdpp+R5p; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fdpp+R5p" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38101f85591so623677a91.1 for ; Wed, 12 Aug 2026 22:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786599269; x=1787204069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6xzFkArDiYUJVrphFijlWZtDKj/k87XskzGvkdFKreQ=; b=fdpp+R5pOdizxM/gpWSXoFzMol+JHK25dXtq9Pvbff/y9bSwm6Jhle5vYUqdvENkAa ciOKFBmQ39yY0Cu35hrCJl1TAVRTQlCL++rq96pbpNravcV2AC6dL1RyWFKFklo35GIc SViRvMkUoZdhISEWZO4NDlzd+dbVQCo7LRGJrnSQDGGE/vCAWxUZPZmXE0P/JDk/9Ikc hIReSxJeu9faoov/jwRc48EPBbRZXlzI9iGPOYi0aTvJmsnVgCACZWkRPSiy5xRCJql0 0zq9fNRRQcfPo+/ES7v9pJ4TSUfOMf2qxUEecC3tySp70R+p4OB/dqzBlxeGWrNtTuN5 XQcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786599269; x=1787204069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6xzFkArDiYUJVrphFijlWZtDKj/k87XskzGvkdFKreQ=; b=llfSQNAZxtL7fnM97Tmlb0rlPVlFEu3dnFcge/NVZ0hxOM9RJdwcoRx5a5DHB4f40z XdIwmbHVlkbuyub8+g7IukmzO/z/KcOYFe+PMeWqpW7RwpyP0G2tBg+eRK/OXlnR31k7 BY7+m8H18wWlYJy4eO3rAunQtahRnIOtzPseK7bPKs2tlS9WNhdMji/tySdDLAw94e0g 0Jt4WDA5ISf0eweia/waSvl82W65VH1ksq2X8tAG5a+pl2z0blLEufR5aWeYMbOBQUo6 4d9a3qAfB/5aM0Z/7RRf2+bROtaUu/LbcRzi0rPpnDFJXxXLX0rMi/Tr7L1/SUUL8KYG tsWw== X-Gm-Message-State: AOJu0YyNP/+h5rl2BGaOGVhOl2R0TennpsSOaEJnQsunVSJ3AoIglAsl fVim1DYq4Aia2r/ZLc6ohDzi+bcWZcYU0zZ7X6c+1+aGuDhhgvXk6xVS X-Gm-Gg: AR+sD1273PpU20Ec0sFQD/jRKfZDYUkdh9rj4jlbKMA3MsTxa6ye5O1QEg5S5Bjv0Dj ZYCFLqiJJtlK2vUUyuvrQce5MgpBL246l0fgfw/Ip+Iqv1zYV2v9RcHFdKLZ1DwfD4C4JNNS0EL GzjuFsFmPwU5V8Oyr02ry6DWZpY3On9KUzjk+zUNIF0wEoCvTIqc6wtrydOY4DGenrzSxNNzxHV imku/7/JwmIk69Uum+yjSZCobQehBLTltu3c6edwCN/GsQWwj4ozBE/RjQiIA9U6WaBEQOoHYcB TFJDDui1Q3hIBYQcjXZxRpslURM1I2rrOtJYIRU93pGOqQgVbxc+p4l0wlqaSkEIYv7DrmhdJ4b 1sKpwfGBRrdV6oB+gihgz3evbEJILpnxV9zvU4s2E4IAgVhTrVuIVNBLnBV91ulgdHcxXg2jujM rZKHgsffZ8GDZvuHds7b8ZdBKV5eYomtgghBf7KDX3PYYAerr0MArEG1ylT+/6f+h5XDo4a4h+v ypdG54jOdE+wMDJSJnvdRJFWx0GmBk9JXKGylyKbZU8Nke+A4IoFp/eAjMSlcfCCGMOkKwW8s53 jbcX0knQxi82bzCkRxK+CXNz6Bs= X-Received: by 2002:a17:90b:4990:b0:38e:b3fd:d584 with SMTP id 98e67ed59e1d1-3931f94365cmr1262125a91.15.1786599268892; Wed, 12 Aug 2026 22:34:28 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3931d872ec5sm594734a91.0.2026.08.12.22.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 22:34:28 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/3] mmc: davinci: Handle errors from optional IRQ lookup Date: Thu, 13 Aug 2026 12:34:03 +0700 Message-ID: <20260813053404.21553-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813053404.21553-1-phucduc.bui@gmail.com> References: <20260813053404.21553-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. However, the driver currently stores the return value directly in host->sdio_irq and continues probing. Propagate negative errors other than -ENXIO. Signed-off-by: bui duc phuc --- Changes in v2: - Use parse_fail for proper cleanup on IRQ lookup errors. - Keep the value returned by platform_get_irq_optional()=20 in host->sdio_irq, since it is already checked=20 before calling devm_request_irq(). drivers/mmc/host/davinci_mmc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index cdb9fa94b56d..773577a10512 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1249,6 +1249,10 @@ static int davinci_mmcsd_probe(struct platform_devic= e *pdev) host->use_dma =3D use_dma; host->mmc_irq =3D irq; host->sdio_irq =3D platform_get_irq_optional(pdev, 1); + if (host->sdio_irq < 0 && host->sdio_irq !=3D -ENXIO) { + ret =3D host->sdio_irq; + goto parse_fail; + } =20 if (host->use_dma) { ret =3D davinci_acquire_dma_channels(host); --=20 2.43.0 From nobody Tue Sep 29 02:32:57 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABD893FA5C7 for ; Thu, 13 Aug 2026 05:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599278; cv=none; b=b4MdTQvyaHvu01xyQ0svGdWdeVKsnFDKWNK772gcNC3zS7u73wdCST1p5HAf5GK/o4/QnkPU9i6vY1E8zPlpNklqqD0KoYg61AtTJ+TH8QK1dtx/hxWs1dEuQMKFnUDzLkChrm1TubPznv4rMclx3V7bCQQmKBAgNq3aS23c4Bc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599278; c=relaxed/simple; bh=d+qPrP6oSu2aMxcgbd5QZLwjghoOCkMl7GCAc+Moo/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VUV/YokN4+5vNbf6SwMQbPcsOjVvvwBfC8Ioh9hf/OsW1zViQW5Evftkg78QIgqIwOWmK17rPChTFBQTm+BEadM42THkQ76L3W5k8MXnmkByoLuellbhHdF9qSdBDxnfEn90HoZaBUtrKcR1VTmzzozu1r87G0pO18Fx4XpwaWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UcUNmA+A; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UcUNmA+A" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cf50c6f235so25501755ad.0 for ; Wed, 12 Aug 2026 22:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786599273; x=1787204073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R9jEpSymG16S90LWBY9Z/OiKp+TcgWzc+6zLqoEqqxY=; b=UcUNmA+AOgQYdnIx60JqzkDLof6PZm6H+Ni0biiyiaPre4UCKn2iB3mqdsOI/kxujx i6Oa3QOFsMJupqPOwVAyHmAXonxrEOl35ZckiYX1KkHVdZblGnTJBAcT1PPaiBM22RJn Q8gz7HjVPrq8+4VYsGTKxQq64/NkR03QBRklNA/HJlzR5UcMIvjJ/gkCb8OWieL6NoHe 8rGTLyj1Vo2diXujeOutrDqlYTOApnE4alan+SvODjzI8LRW0lLnTQx9q3r5606rHGXB OUgDGjKgHyfFV+ruGpPbUTdxd3LO2hQbMIQU9Up4vKuB4RNWL5Kjm9yjTHNbIYv3jPG/ fM8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786599273; x=1787204073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=R9jEpSymG16S90LWBY9Z/OiKp+TcgWzc+6zLqoEqqxY=; b=s1q5KO+7f/lA/f7aFG882dZ7Mpt20eUt3jbeACdSnqB1akPW8CLzoPUhhFlZDEFSNU l15DxhiDw1yu0iuqVjFPJrgzZ0pPjW2WfP2yNcbrfFCKKdHi1wY2tDcCk9MCvcoPkjQd 5xXiWauY54YD+tuKClbxuZsUsQaXRmkmfypKyS2xRc1D80l/ush36uPIZkbKXGkNG2N+ /Zwb6KMllalCI2THw89sjwz1BxgCcw0jrTBsq7PXxSS4/OotMDvJz0GZQ6pIgHS8MWza OrY2LdlZUUAIMbqRiNV+jpLRx7ZdtG0G5WTnmqiLrTuOUfJH3rEIV0YRCc8Pp+sV38Qy Evfg== X-Gm-Message-State: AOJu0YwFDqpe216slsMcwPQd8dptZtAVw6T8UwBVdSpBnjb6aP8ZDctz YuMOZW3RfW23CWFh9Uxp7m8lz7mOU4izocQ8Znem8w5AP0+z2pcUCByX X-Gm-Gg: AR+sD12zJ9yHrzHLKsDeEfh/QZ+BMGtBmdNqY+2qniiE6rWKpBu0DfTMJq4iALqHUxE 0AX8CmwJnZoAY9XmEmWOW6Ch1KuqcvaIdZnv+rCve8jrhdbJmi2TmbIFwFAOprSqXgfQ+Wyu7dt bO7jramykCFnuoAm0/BbW9Qe9vtHqcRQlbFQf6d127p/ufX8XrWgPC/hMun5J1W1iQUptD4EsO6 sm/MXCuPMWIdBW3VaM5bTBFjr0YIUspd5HG/0IxNm1UueT1n2lJmsmBktBjQymmuyvU3YQNMpLl XLX9q8cFzefZofsUB+ABZ9mghzZ0+K2UWmPe8PHSca+5F+GFfhM0O2CPrMbI+7AO1bfX7WnOvXd vQvhrRin5Dq2r97up+weA4jLr4Vo1XJQtfhC8Q27oFu6QpOEgK8Hua3y1ztcuJPkIoUn1cFDGyC OIY04UC63XWztpWPuxMvrsUpEGqlzFyFFkngg4ToKzGVY7gJrPwMjIutLrOygIFcEimGMhiJsA5 9wC+9OfvD4JcabGWWXnt5CZByGPL3ui/GIiNdvHF5mNY0mRpFAWeoI5hrMGaMAuJEvp8YRU4fOj b1ExZBS1VKLZkS4= X-Received: by 2002:a17:90b:52cf:b0:38e:9e9d:9209 with SMTP id 98e67ed59e1d1-3931e278f94mr3672086a91.17.1786599272978; Wed, 12 Aug 2026 22:34:32 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3931d872ec5sm594734a91.0.2026.08.12.22.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 22:34:32 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/3] mmc: davinci: Handle optional IRQ return value correctly Date: Thu, 13 Aug 2026 12:34:04 +0700 Message-ID: <20260813053404.21553-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813053404.21553-1-phucduc.bui@gmail.com> References: <20260813053404.21553-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc host->sdio_irq is assigned from platform_get_irq_optional(), which returns a positive IRQ number on success or a negative error code on failure. Therefore, 0 is not a possible return value from this API. Check for a positive IRQ number before requesting the SDIO IRQ instead of treating zero as a valid IRQ. Signed-off-by: bui duc phuc --- drivers/mmc/host/davinci_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 773577a10512..c503e5f5c886 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1303,7 +1303,7 @@ static int davinci_mmcsd_probe(struct platform_device= *pdev) if (ret) goto mmc_add_host_fail; =20 - if (host->sdio_irq >=3D 0) { + if (host->sdio_irq > 0) { ret =3D devm_request_irq(&pdev->dev, host->sdio_irq, mmc_davinci_sdio_irq, 0, mmc_hostname(mmc), host); --=20 2.43.0