From nobody Tue Sep 29 01:20:05 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EADDA3A5E78 for ; Thu, 13 Aug 2026 21:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786655215; cv=none; b=hV1WLkACGVpd8DaJI0iAtylwqLSWr94km/8ff3TUEivUEE6HXfxm6GETktwaDShY1DWaClN+xCYuBLxycGbPRg+WPWWOhhO7ZHX4EH1UrrpXQsI4Mxy+/rlpIW7k86g+vZQW/6eYQBPj/kEdYGKrkxQJ2DXBjBkwmvosdvq6/Bs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786655215; c=relaxed/simple; bh=+Iyoqht06orAWWu+u7sHJGc4N1C/gzIr5LzUDuiY8Bc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=DzsI5Wz7YxCxS+my2qEo7tmiGnEGGk9gsRDRcM9E4IE4WjI58b0BE7Ppbmf/ONQlhhljNi8xKwx/TJzTUuwTf16K/Y8Iy9R6EUF+ZaWwlUEVBfzDZ98Q9DMyIUZX1uzeATc+w8k75G7BV7tAGdG/OTBqBIg9m0ZRPYqTZDApgb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai; spf=pass smtp.mailfrom=nexthop.ai; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b=YRJrVvYJ; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b="YRJrVvYJ" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cbe6295f05bso1100610a12.1 for ; Thu, 13 Aug 2026 14:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexthop.ai; s=google; t=1786655206; x=1787260006; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ultvd+YwB2CCLSLTdZwfLPvD251NBr4TYb3rtNreqUc=; b=YRJrVvYJ41jpJFl3nnKHGmmdguXAwWSgdgAymXvI66PrLPTfImx5XAK1lGMAtFtcJc cutf5XEL2QjR8cuan55gdbxOk7Z24mZpvj04yu6YMlhDXHkJniKU22h5VYRBbKK7NqAu rpgczz5iJBxIaFRuTtKI0zaUW9f7YjrdG3zIoPSxYI6mdJ1tT82bsS6INfNUCLyY1We6 mt9ym0eW4WYy7VIwczI14tV+YTWquID+gzu4hT4s2wUDqGByFdcYTaWDGH4E2CT5wAIF JFFE5QS8FSPDWAibxbRCbCt4EQj4oSoBLqlOwBRUurN5yyAlrv9sQXTtz8Akqb2Rf9iM //gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786655206; x=1787260006; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=ultvd+YwB2CCLSLTdZwfLPvD251NBr4TYb3rtNreqUc=; b=S9f+GGX97bjYOjp7uzQa06pL8C3f07N6meBdhCqrMlqhE/yeFJTxbtE2X84oW+VwdJ xQ0nU4r1VQGJulnhfgP0P5dwOj55FnrszYce1czrLZx24y8E7X7nRe4p9FIj+6LbM+6M 4wEm5eqgBKMJmgUfouSzD6XoexThUujJ3gfm6k6QYOMknwZxiC45x2W17/TjAGKEOsto DpSEwUBF83SETaRkLQlaJ4rNf5t3KZd5AF4qIWG6q43tmJwE81OyP9XgOV7Jcb1N3nIN a0rDnzUoNsNCHVwU12aKPqrLeFcZal6brdK/kSnGnVhL+O4i9DA14CggMoumeVzdEfhI DOqQ== X-Forwarded-Encrypted: i=1; AHgh+RpVUoJZv+YnxAZQJu1PS8aRQF8l4KWSeE69OdjD32s8NGR+j5pq6ftGNvctzQKSA3xLz2m5QniHAJ62aUA=@vger.kernel.org X-Gm-Message-State: AOJu0YzGgro5OwCJzKi9PQ/kpMQ9/X9cDkHitMWBrWKd93qAHxfTBHA+ DM+nwxS7R6/9AlgHALRt/CfV1NYx0oW6iEEV5mxKGepTxRyMHghu4Kcoms6mtoCfeyeT7EHQkMk NmQA4UVk= X-Gm-Gg: AR+sD10ZCaAL2C30jkAxJ7oy930TIoS/+CzkoHQt1x999xD/Fp/XzbmSW99FKfScPna B4yAiWcVKuZaIgAuX5bW3K16Pyye2mlCCYR+9AWvPlkIzbFKtPbh0GLDLCh8IEkSeCPk3tcaP+V qkRHNVez9BUCbSiDNeedKePiSoZv99jv7/cVAL/77jCxmPUUQebFLLfHfRpo/aJmRz9f9nVg0mT z/6MNjfJGbsktVpgPqG/PeGffpxmXd/zqHUeOxac9KpCrqp5CmFnYqhjvTNMVCPTYcY4Er6idNa xK3S1/MHaS+6NTvOplGJpECFihVW3ALq4jfGv4mICmtTjI7ZkKTlHd/vtSFfruo/AXgonVQGEAP 1z0iyAYc1+96i3KBJlV+XQ0JGOxa11VvT9QVC54rQZ0xmaKIlwJkI1pN8AE1et5xrnkKwCw8Bmu WfUXx3+FhVBhjQ64VH5gLzY8IUMdyIfQcRD13El+W2LFjBEIMeDcm6rvHlYGfaFcc= X-Received: by 2002:a17:90a:e7c8:b0:37f:a913:1554 with SMTP id 98e67ed59e1d1-3931f5b9ec6mr4934140a91.16.1786655206294; Thu, 13 Aug 2026 14:06:46 -0700 (PDT) Received: from [127.0.0.2] ([50.145.100.174]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ebf732526sm9841832eec.19.2026.08.13.14.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 14:06:45 -0700 (PDT) From: Abdurrahman Hussain Date: Thu, 13 Aug 2026 14:06:40 -0700 Subject: [PATCH] i2c: xiic: restore runtime PM teardown in remove to fix clk WARN flood Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260813-i2c-xiic-restore-runtime-pm-teardown-v1-1-0e7dfb206790@nexthop.ai> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXNwQrCMAyA4VcZORtoK4j4KuKhTaNGWDuSbg7G3 t2qx+/y/xsYq7DBZdhAeRGTWjr8YQB6xvJglNwNwYWTO/sjSiBcRQiVrVVl1Lk0GRmnERtHzfV dMGcXk88pkAvQU5PyXdbf5nr72+b0YmrfNuz7BzsuC02IAAAA X-Change-ID: 20260813-i2c-xiic-restore-runtime-pm-teardown-dd0ab1db2c02 To: Michal Simek , Andi Shyti , Andy Shevchenko Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786655204; l=1608; i=abdurrahman@nexthop.ai; s=20260510; h=from:subject:message-id; bh=+Iyoqht06orAWWu+u7sHJGc4N1C/gzIr5LzUDuiY8Bc=; b=aZPjAYgXpSdHMLsS5PSsc0LoM9SiqlcTXDl56EtQPLQhYYNTWWCUoXuF4aTG3wyNCHQg0xcQ/ UbKAg7bvJgxBmyzrDURg6yFE93cZkVoIsmJ3HkhI3eAvhqCeGMUFeD6 X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=omTm9cCAbO0ZhS32aKfJDKue0W3sQGpG9ub5eYHif8I= The devres conversion dropped the remove-time runtime PM trailer (pm_runtime_disable + pm_runtime_set_suspended + pm_runtime_dont_use_autosuspend). devm_pm_runtime_enable's release action then calls pm_runtime_dont_use_autosuspend() while runtime PM is still enabled, triggering an immediate runtime suspend: the suspend callback clk_disable()s the clock that the devm_clk_get_enabled() release is about to clk_disable_unprepare(), and every device teardown WARNs in clk_core_disable() ("clkN already disabled"). Restore the trailer: with runtime PM disabled and the state forced to suspended before devres runs, the suspend callback cannot fire and the clock enable count stays balanced. Fixes: 50c63491ff26 ("i2c: xiic: switch to devres managed APIs") --- Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 3e7735e1dae0..89636ca36915 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1545,6 +1545,9 @@ static void xiic_i2c_remove(struct platform_device *p= dev) xiic_deinit(i2c); =20 pm_runtime_put_sync(dev); + pm_runtime_disable(dev); + pm_runtime_set_suspended(dev); + pm_runtime_dont_use_autosuspend(dev); } =20 static const struct dev_pm_ops xiic_dev_pm_ops =3D { --- base-commit: d58772d8520c7ef247c4b95c9bd76d3a25da9ff5 change-id: 20260813-i2c-xiic-restore-runtime-pm-teardown-dd0ab1db2c02 Best regards, -- =20 Abdurrahman Hussain