From nobody Tue Sep 29 01:19:49 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0122E7635 for ; Thu, 13 Aug 2026 17:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786642869; cv=none; b=GSMPdbfqhHGrW/NbVGU/iDITjdj5JBg6+pNzYnOvESjFk0BCFTlxgZcIxUxWIFViXqcAzB8ZXoMVXAFJPnLNfTSoy33rPNIItHSlPqBIftVUohFBBqrc97VfTcHc8hBIveGI3T8fgDYI59VQYNTwmRQP6ahtznlBVHNyx0bL7kU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786642869; c=relaxed/simple; bh=ERB3Ht3KQ7PJfL69qf4To3ZximdNxC6SNofrFvNxe0U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=JAhs6EdA7d1TF9ASlQjl7iHOGAa+NWVXSrRDXGx7yifBJnEU+WN2DWutSP5QEBD4URgocFMyNrqiUN0wQFi/ouF6sgV/80RY4zWf0oBC8HbCGE+Ks2dxcQaDjnFF39mHwoM4uauwrPSvMpv6EUfCH6IIlfPmFvSZzASNPgGiiCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ESXHz0IT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z7et89Bl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ESXHz0IT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z7et89Bl" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFr1qs3181512 for ; Thu, 13 Aug 2026 17:41:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=JLpr7daqz7OTT67FQV80/z +XbfGvlShMvH/5gavUb5M=; b=ESXHz0ITk82PMgKwDSgDOl7y9fDfTGO8NghIae /fNEOTWzqqHaVe5bYu2ftaUKyARIYDdVIpBdpdHqaSfq8ZlM0DXeke1uqNDwK5fw vQ9R7wgvfE/b8W4vdlyJW4lVb2HwgKGJdaJ0zGdwSja73NomEhabEZLnoe1W6I83 SbFdNMvkYswc8fRUtz+F7XwCbQp+4zyx15qCaht4FWsk35i0w8LOQZXQRDmdTDDt Pqkj44Nkb/Qm/nfGEYPtGElM7CU9eBobuc7r2HdLr8jP3+B5MF+zxha7r1yXp4oo IeApzNgQd8FstirbTO3w16oTLiSHc33p95E8nFn2aI8iAPsw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1gy4rh8u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 17:41:06 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cbb20f82a0eso58142a12.0 for ; Thu, 13 Aug 2026 10:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786642866; x=1787247666; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=JLpr7daqz7OTT67FQV80/z+XbfGvlShMvH/5gavUb5M=; b=Z7et89Bls50T96oL0/05IamVPG/jz4quT+Hcd9pNhTRndJsCNtqV5YfORf5Vx06wPU q7sgBlC31cseOmvjhMxHbQLiKw7zPgMAUr6DmvhNFMTMmxZSsgViaD1MVTorrvK5jPsc zvJx8zmFeLms40qQhJdC+xfcrQF3Kgimj0XyNLvFte0qk9WAixnaxVn27XEZ1WUcQiR/ D4zzznej1eI8cBsDdFBtJoNKg1CziRtH2JYEdEZWPheOqANuAx+3dU8UC5U+YGh9/Qi8 wT5qPS1bgGmfxQ4WDSiK97i/OkdrW+rxuCZqub5MKnaDT9gFFFZxRMe+ThQ9b0IfJqBC 9ERA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786642866; x=1787247666; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=JLpr7daqz7OTT67FQV80/z+XbfGvlShMvH/5gavUb5M=; b=WqC9q5dPF0M8aO9u0C56xaxu6eAf+pJLmRBFLXKryuraDOnonixBtgWWjzFGmCp1HE niynI3JnBzBqMrekv0PP2tTfmV/00q0C/bLqMi+FP0qoCPu3OxFdU6D3bxj4rgAOqb6t Udb32Kgk+q+NuqEIBvmOoEtvtIXirjoyrq4W8bUDAan8U7lwNE6w6FwcVgku2fqc1TG5 +eFmRpFDof/CSf6xk6SnRKUKtZEKh3g17cGzlglBBTsTTkQYaGlrN5eT6qQlgXP7DBJw m5/E8qvD63xOd0y8hKAXUyJyOgGQPzQ0KqzjYaje1JwdVJQktmecuActjfP7489nkBUo I9BQ== X-Forwarded-Encrypted: i=1; AHgh+Roc3Foif9TdOhrvgXPwTLZK0ZBbMryUWPnBMYPKXrMSUIUc9E1p80oBSJl+jfooHzZ0SWmxe87a6p3h1N0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6Nb5TL9SiluOwZArIgJcFESr4ow0AHpSJ/ZS9R3hkMqshl5JX 8PkeOWWcw3LMVopPq233EjtV8DZ9MOtZ4JzMMy2gHNtTqC0xVY7G2nk2YvAlh0dCcAX13HXd+wM Jfreiybd6UwGoopcEabHrCDiAm/mX9+92758oxto0OP5DeAHd4ObDAvuXIBKSiNXqAQc= X-Gm-Gg: AR+sD10d1QKY4uweKYihdRK7btmoGJ52FWmBApOuds7Ub0rNnUvaiasK+q58ExsXXhw Hmsjh2OJbNAposh7o1GGrp09ZLlp+onAM1sh8xsObYZZcr9NW88wdneMgHf+G0Q2bqbtQrjhHBu 6wGGNTQq+fVtSOrUJmOGvpNGZ9BrNoo1ftG6Xb0zv/rkUePYFe3h1OYFmQnENqzwLrt8EMJbRKl ftsuXxJjKryfoDZkLDDYpOb+W6kB20GmSXyjos8RuQJ9r0dG1abhNZU1qFPSf8Sl6zi9rbMXL8i 0EiOIBWXUFS9bXTHZwC8+blCA/4nY6vSAxtNFglBSNXFTyi6d7j6SMwMYBElfB6y453ToK4nOQ/ mtW3gWEiVNF7NHOYtrwIs3YpEUeH3I0gV3Jd6m4skaRhCl1XMR3c1uYY= X-Received: by 2002:a05:6a21:3282:b0:3c3:b57b:6459 with SMTP id adf61e73a8af0-3cc54f3e1demr9186868637.7.1786642865575; Thu, 13 Aug 2026 10:41:05 -0700 (PDT) X-Received: by 2002:a05:6a21:3282:b0:3c3:b57b:6459 with SMTP id adf61e73a8af0-3cc54f3e1demr9186802637.7.1786642865089; Thu, 13 Aug 2026 10:41:05 -0700 (PDT) Received: from hu-jjohnson-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ebf732166sm16244436eec.18.2026.08.13.10.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 10:41:04 -0700 (PDT) From: Jeff Johnson Date: Thu, 13 Aug 2026 10:41:02 -0700 Subject: [PATCH ath-next] wifi: ath9k: use rcu_dereference_bh() for sta->rates in ath_merge_ratetbl() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260813-ath9k-rcu-fix-v1-1-424665a1ce60@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAK4BfmoC/x2MSwqAMAwFryJZG6ifFutVxEXR1AahSqsiiHc3u JzHvHkgU2LK0BcPJLo48xYFqrKAKbi4EPIsDLWqjeqqBt0R7IppOtHzjbo11rVGNX7WIJ89kcx /bwBRMdJ9wPi+H3vKONNpAAAA X-Change-ID: 20260813-ath9k-rcu-fix-5469a4603fd5 To: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , pengdonglin Cc: Jose Ignacio Tornos Martinez , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Johnson X-Mailer: b4 0.14.3 X-Proofpoint-ORIG-GUID: frezyaFl9dB8d7W4zFmgxB8amj11RbF2 X-Authority-Analysis: v=2.4 cv=ZYAt8MVA c=1 sm=1 tr=0 ts=6a7e01b2 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=6wmsvPg6niT-l0PZxM0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEyNyBTYWx0ZWRfX28kxESOPD3lW tCuNTYMPh9K1I266QMk/p4fxOmwLr+hZBcVW3gwYv1ndCFGROdiUGTchgSqxtY6w8I4tGECbuhr vQt25Gc9/RAD2Zw+yQcZlgxNLWTfUm0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEyNyBTYWx0ZWRfXxxOx0hdUhjbn 1odVyboMCaD45tfbeyanZT+nmT3Yl3+5Oqc+CtDIrhoYF6yolZOedDkAYXtrerrKUFN4MB/noir veHj3+AdY61PbRDu6RKuTdtp3IAd2XlL9iAqbWMf3glEu9Ual/N+AYHiQO7UlHPgny9eAAr1CC0 hkacjDDK1zC7qeePnSyFI//gfzLB3VBwD82CcKnUsoxU/JzSeVpAFEoPIhHSbPngT3ZQYNsMwZq Kbr8IoVmn78FXTUJ68j3mKsqriS8Gn+PP+BfUa3fXR6l9TNLiYKa5V1JfvHx5KiCETPjL9qlbDA Pe73xYlFQkLUtzfpHYsSrJ7Sb5vvWH94stTCUf1s4xL6wb8z2Oym8BhZzC3rOBx6DPlUITekcDc 9RiBBtFtIczvGKyqOk9aVCZiWZnSm0L0yvZ6vVUWabb0kNtxJjLbogkHnwUtSMLTfGb85CCz/9C hMiXkxWKcy8xBE/HDxQ== X-Proofpoint-GUID: frezyaFl9dB8d7W4zFmgxB8amj11RbF2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130127 Commit c4f518736472 ("wifi: ath9k: Remove redundant rcu_read_lock/unlock() in spin_lock") removed the explicit rcu_read_lock()/rcu_read_unlock() pair from ath_txq_schedule(), relying on spin_lock_bh() to provide an implicit RCU read-side critical section. That is correct on kernels without CONFIG_DEBUG_LOCK_ALLOC, where rcu_read_lock_any_held() falls back to !preemptible() as a proxy, and spin_lock_bh() disables preemption. However, rcu_dereference() in ath_merge_ratetbl() checks rcu_read_lock_held(), which under CONFIG_DEBUG_LOCK_ALLOC only returns true when lock_is_held(&rcu_lock_map) =E2=80=94 set exclusively by an expli= cit rcu_read_lock(). A spin_lock_bh() does not set rcu_lock_map, so on a CONFIG_DEBUG_LOCK_ALLOC + CONFIG_PROVE_RCU kernel, any call path that reaches ath_merge_ratetbl() with a non-NULL sta will produce a lockdep splat. The correct fix is to use rcu_dereference_bh(), whose validity check calls rcu_read_lock_bh_held(), which returns true whenever BH is disabled (in_softirq() || irqs_disabled()). This matches the actual protection at all callers of ath_set_rates() that pass a non-NULL sta: they all hold a spin_lock_bh() (either sc->chan_lock or txq->axq_lock). Fixes: c4f518736472 ("wifi: ath9k: Remove redundant rcu_read_lock/unlock() = in spin_lock") Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Jeff Johnson Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen --- drivers/net/wireless/ath/ath9k/xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/a= th/ath9k/xmit.c index 89d8b3178784..3413bb4906d4 100644 --- a/drivers/net/wireless/ath/ath9k/xmit.c +++ b/drivers/net/wireless/ath/ath9k/xmit.c @@ -168,7 +168,7 @@ static bool ath_merge_ratetbl(struct ieee80211_sta *sta= , struct ath_buf *bf, if (!sta) return false; =20 - ratetbl =3D rcu_dereference(sta->rates); + ratetbl =3D rcu_dereference_bh(sta->rates); if (!ratetbl) return false; =20 --- base-commit: e07447e654476262558bee570f4cf456e2b32565 change-id: 20260813-ath9k-rcu-fix-5469a4603fd5