From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDD58353A66 for ; Wed, 12 Aug 2026 16:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553096; cv=none; b=gWvLVXr8C6teuM9MQXgltcpb6C2JlP1W4sknBqdc1LVYPy/3Mq2sSjAvlrE7dKF1PGgmHmSvkEQ90C0ri2unq/EkK9hPvnWBjV0qfZRW5WGYPAEdsRi4uXqYbHdxPiideCh0gkeGws9OwQDxxOYVaTrxy6S6zdJXhpXSUHJi82U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553096; c=relaxed/simple; bh=KqU7hUX6EEnvGvvXp6tf05FdZonTZfQ28JEGxpEGpyc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nK2s5ihFxDJNOQzVFXn9903JXatIikpHmBqIdJ9EDn08JLJlngOjiF/4FLAl2zMxx7+2GSnWzviTgQ6dGLmIwDSHMJN6t0jJdvy6UYDgWN3HCn0Dn+X8+2j6ATAvXCjf6jehuFV18FkrI+BCCezII12iqkPgZXViU2aUsAMqivE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DcBPDYcn; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DcBPDYcn" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c999f162c9aso867256a12.3 for ; Wed, 12 Aug 2026 09:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553094; x=1787157894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nAYjNEgUAHuckjfKebSgoAzLO2c7KwVpNw4ZzJakepY=; b=DcBPDYcndhL1YJyNEYXf13gUmOR2fHQalnG+42YPHE6qJJ58UrVAvMUG563f4UqMUB zCbqL03ki1Gn9c9JWzOAOmsVS3rlbY2cIUtEr2LIn1Gs/tVDGALvVWZZ4Tbg0McDnvVm 3Cg4tAy2jBtfjmWdpLkRimxE/yIRynCOHUPTDc+HdOC9Tu2/LO15Cy5Cap61y0Bs/m7c sTKLYQNJrI1NPkOHIvgL1M/cFCc2bZKI7JWnSJ0eoPenx8/w1hifng+w+fpdDoxyUMz/ erH6hYvJ3pwBUtO74k6ldEfeCbzbIsbWFaGgd99py41FRVJNRjgQxMDDo6mY9pD35NO5 lPvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553094; x=1787157894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=nAYjNEgUAHuckjfKebSgoAzLO2c7KwVpNw4ZzJakepY=; b=WUGdv3dCvOZcznTOHzpVuK82gNUUS7DwpehBnMFGRNmqSpKp+T9mgzXNmLOyeEjLhm YFhUXHAPiS2Yt06vneDrWiGt7Fw7Q1rLMZ0KVCTpsexoJFB7i5SOSfutMc4y2jUftpyA zgiIUZHDOJQv+zDLUS5Gcaa0VSLNOPsqRzCWSYacYMN8LAE71P3ajyKmBd9wgGAXuGbp QNZs6pajp1WU8E5giY1VlpTja1n+GX/9d4S/CEKcPv0lj7MVB/zBFfUG9CUWGDB/Bz/y R7sGGYTDxTGISUqOPr21w92b6HmdROXtPVkGnqEAZ16IJz5ew5RRpzO/qI1VGLMLCZ2i cTUw== X-Forwarded-Encrypted: i=1; AHgh+Rp4PR2DyodrYW5nm2QNuaFt5nFloBH/BTCDTVAVv3SJ64055CcV+mHr4EojEZJPlBsXl//r7MaCVYCO2n8=@vger.kernel.org X-Gm-Message-State: AOJu0YwvmSsxxq6um1jHD0ZWVMd+flp+HOx9aV1FVOye8GH8NpE+jjte 9PNDLNXI9sxUEeZkvqThfVFFdtP42d0LLnwstkRw6ErS803yctJ9DRQ/xFrHCyHd X-Gm-Gg: AR+sD111jlDPdf9CX+T9iW7mw9aVTVStcAvOBdP74h0f3+XvuZzpXxfBUBqh1twV49z CGAIBRSwstos+ZpgjzVnISUlnxxBpwSSWNr3XjX39yz9PBeG/3j50kSfh0tF6xdiDFynvgRkWXP oRCAtfurRDx8IKba2ZzMBtQ3KLOIJ0U23AAe5Ykud1pzlHTI40pMryTNY4xvWmSJ5DmdhHf54IT Mau8PenLYKu22akdXqygPbQugF0dPqIuqEJ+hA1M+Pjnl3sjnVyLTDxwmVX5hcDQN/WIDH6psiw jVbOdM+JtMFXR6a+cKR61Y+iz1QOlWbMDqR6KYavJsWzxbwnMx3FoTSr9GXbUF1UWoXCuMXqtp1 dtyS3IPSSczEQuXEd0DndDyVinkQ5injzyW4j7Oe+WXxNoivzS6joprNjVXJmLexMlrpbnWBS/a asBC28YfEhduGwe2ukpTKs5OC/ZI0aUnx7u38JZZUWmrZpnqu3DmOTgjSGilwpBQbZZ3H6dVsU4 tsv/30KHIGJ++yoW6OBJ1b9abk/Rg1TCWs= X-Received: by 2002:a05:6a20:a10c:b0:3c4:397a:69aa with SMTP id adf61e73a8af0-3cc3f764199mr6486915637.31.1786553093808; Wed, 12 Aug 2026 09:44:53 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:44:53 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 1/8] iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS() Date: Wed, 12 Aug 2026 22:14:26 +0530 Message-Id: <20260812164433.23011-2-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the deprecated SET_RUNTIME_PM_OPS() with the modern DEFINE_RUNTIME_DEV_PM_OPS() macro. This allows for the removal of the macro automatically handles dropping unused functions when PM is disabled. Update the driver struct to use pm_ptr() to avoid unused variable warnings. Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 8a272af69f7d..9cd620b71429 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -1066,7 +1066,6 @@ static void ads1015_remove(struct i2c_client *client) ERR_PTR(ret)); } =20 -#ifdef CONFIG_PM static int ads1015_runtime_suspend(struct device *dev) { struct iio_dev *indio_dev =3D i2c_get_clientdata(to_i2c_client(dev)); @@ -1087,12 +1086,11 @@ static int ads1015_runtime_resume(struct device *de= v) =20 return ret; } -#endif =20 -static const struct dev_pm_ops ads1015_pm_ops =3D { - SET_RUNTIME_PM_OPS(ads1015_runtime_suspend, - ads1015_runtime_resume, NULL) -}; +static DEFINE_RUNTIME_DEV_PM_OPS(ads1015_pm_ops, + ads1015_runtime_suspend, + ads1015_runtime_resume, + NULL); =20 static const struct ads1015_chip_data ads1015_data =3D { .channels =3D ads1015_channels, @@ -1147,7 +1145,7 @@ static struct i2c_driver ads1015_driver =3D { .driver =3D { .name =3D ADS1015_DRV_NAME, .of_match_table =3D ads1015_of_match, - .pm =3D &ads1015_pm_ops, + .pm =3D pm_ptr(&ads1015_pm_ops), }, .probe =3D ads1015_probe, .remove =3D ads1015_remove, --=20 2.39.5 From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78D36468C22 for ; Wed, 12 Aug 2026 16:44:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553100; cv=none; b=EhhEAf01DHUMm/SAnWj/Hg+8NO7ZMqampaHslaYvypzBGDC1qwQcI4fa69K4b30NS5mAWtiewpF5+Tkt9R9evQbqXjxmyF1Qd3IWxSIhgWSAWWvF/ahxQbLoAOgtSVFKkwZTcqowAnGYL7d9NtVjGYbSDTa0eClAV5TkKYrwN1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553100; c=relaxed/simple; bh=f/UUJEQwVW/zzZmUVc5qiSPTThaU5hzPDPyQD5pCBD4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jdFHM7P8I9ej6YKz+yYrlhbThUu0529j6GMMLOzXrxyfMqYfQoFixtxP+LJT8ONbpVpGC0uGBTeMP7Z/XY69iwOrvZZkQkpQHvMIB9s9mROO/K23SZwXhIm+PTxzhjZV0xHBbNItBcwrgWVqNFrmhQMjLtdqWTWup4HilIATbgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RExa3QpF; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RExa3QpF" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c9cf07d2df6so791398a12.2 for ; Wed, 12 Aug 2026 09:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553098; x=1787157898; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=moa1cK3lyfsCbpEdiaubsjKB+6nL5U25oPdI+VgXliM=; b=RExa3QpFqURe3OAhgJ9IoXRvPAXa7kWZhoN0F9yztNCWXJ7aAxp/hzkA2Kvx9m10nU tD4+5bDEitfVtR8fp+cODAkabSwUyJSQNFyEzYYmRDqIo3fEpxAGKj+q3vYOSEdw+jFK UkYqjxt+IwzUMgW7eKy27xzTtePC27yNIfG7xkKsG9v1+4qckaBjZdXM9ZwqlrxJRlmq DQ0Dq9ntz58SaEavfCvZxf10VbNHTIg2ITsodfVu3QpEzi5H9APrTI/myl2+v/Z3OpHo ga8lgBCI7f6qrfCJtb3HDzgQHVzWlbIyzKMbQkAZ+QOlwUyNnI/UYxCPNwcg5iPYQKc7 FFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553098; x=1787157898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=moa1cK3lyfsCbpEdiaubsjKB+6nL5U25oPdI+VgXliM=; b=pusfLbHt2NHesJpSKEAYMOxK+vEJl1Ha+zi/DIE6VnukgUturfETiudvesFAhPfMuB 7xLvu5MsfTK8l2OEFf7mXJjemrqeCCcSOVPde0dhBrZJl9fNBn22WSQyMd5e7sxLxfMt a9S9ZIVEkUFzTfQJpeAlN0wwqebsp/aI0vPWOwSRZHtyNDepL47uAMGnjB0AlpSiNIf5 o9kWTllxfKIJbJTxWpRXDp1UrjJEmJdQTVpiih2DZHNqDCOF/DU53UmwyNQhoAFUArcL oODh+8XyH//FJn2NyPjVyHJCkk+7yJrtsMq8DSSM4ARLQyafgXXgEb8wmfJr1Zc5NUPN mD/Q== X-Forwarded-Encrypted: i=1; AHgh+Rr0s5ZoTRqta0Y6zlylYM2yyiM5ju0o7wbyzPrQStxeeVgagyYl0cFymz7J6KdiqyUy4jOATxSX+HNBO7o=@vger.kernel.org X-Gm-Message-State: AOJu0YwoFGYTlcZtaHTf7sOrheiJrhsY6atZ2NQKSacHG6TW2WF8zJcn YbTEwzQA/Ye5HI2fV0ZJ3p/rVjnps5CTnUValaez8lOklWKQsB+rOKSX X-Gm-Gg: AR+sD104s/eAXPrd9ss1zdWz6+CxOxPWjtDkl1hGao8odSY5DGw75PsRk/0+9YsLOJi VT5GTx08s0DsgduM2R+Hn52vopOd60iAJrQn9Sm3KRkaV8pvxsjj676m1uQm7kwor59gus8ttq5 Y8iWJJOBt4Hur6Vzp2xqFts5cdjuNZk0UwWjVtalXip3aUiy6ZofmKRwmR1NNwdCmXMxpRkUucP QOfFY3ccP3uV/5WSSlRj4PYNuRIn7IYp+lsxytMMnvHOIVcCHbyIL93ZiEmk//Wr/ADe2jw8Zld GFzSroN7JYGZc+0Apds01aRCZEvrEQvLv+yrK03sjw22fc8AydZwnvV09jmxoA1BnkEP+f+dbA2 VLBjU1QAOy32bd1iRkcW5k2D8NizqbuR7fPAs2XZp/HIu7XfmZfs1k0UcjvSGL3LEyfwCDPqZnE gdI43QRXyO7lBVoCGXfK3JOqf5Gs+kE1m+S39HbSUnWOIKxZcJDkmdRmBLxxXV17zLqzWAxJ+T2 +oz9QDSpnYN4C41c0W0nfX4NSfjo95VJpc= X-Received: by 2002:a05:6a20:748c:b0:3c3:954d:278d with SMTP id adf61e73a8af0-3cc3f5b8607mr6676207637.9.1786553098174; Wed, 12 Aug 2026 09:44:58 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:44:57 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 2/8] iio: adc: ti-ads1015: fix PM leak on probe failure Date: Wed, 12 Aug 2026 22:14:27 +0530 Message-Id: <20260812164433.23011-3-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If iio_device_register() fails during probe(), the runtime PM subsystem is left enabled. This leads to a resource leak upon failure. Add the missing pm_runtime_disable() and pm_runtime_set_suspended() calls to the probe() error path to ensure proper cleanup. Reported-by: Jonathan Cameron Link: https://lore.kernel.org/linux-iio/20260718225515.7e49a458@jic23-huawe= i/ Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 9cd620b71429..3a14fdab56d8 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -1042,6 +1042,8 @@ static int ads1015_probe(struct i2c_client *client) ret =3D iio_device_register(indio_dev); if (ret < 0) { dev_err(&client->dev, "Failed to register IIO device\n"); + pm_runtime_disable(&client->dev); + pm_runtime_set_suspended(&client->dev); return ret; } =20 --=20 2.39.5 From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EC4F476697 for ; Wed, 12 Aug 2026 16:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553105; cv=none; b=VwoOr1rQUQK3/YaVQaVPcoCChZYsjyB8cK7grjgyGcNxyBwan8zkBcUG3qutymYQ3vMeuh5LaH4ojHfHtlxiuRX/Yzoa3+idZAfylRPFFnUqcLY74vnW6t/uchIEt6mPVOgh8D3yTpt3al+lSmSHeHtUZ2TAp131VKEToXTqyfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553105; c=relaxed/simple; bh=bB7cTFtQkA6GY2hg96XdtGA5bAmnXPgrq8JSiOvFnOM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HUdG1CvpNyx1cpIV06B2UAGpqE5TIMR/nsgx3qjW2GSVKbMn0E6/QcNBbHdxHcpijvQ4OPe29ijPA8/FWZcoSdRycKQHL4SmQT2iy4pHlZQsi+lGAFtsT8zrB04Qe55URx1+FJMsn6oV18XyC8SGOSF+TzQOuAxFt4hVH1ku8rA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RhjT1m5H; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RhjT1m5H" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ceb096e675so16128835ad.0 for ; Wed, 12 Aug 2026 09:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553103; x=1787157903; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wctmwy/+rV9SrvO63suyHx9jYj3uIcWMAuL/oEwqgBs=; b=RhjT1m5HHICXFfJeY1CYm48RyuFpqWsnrR85PwfcuOdgbTywP9menu2qB41SVdjR3e nwK2KnLLt3CN4IDoGmMmbjLetbF32JcMczX+jZ/V4IWoeMgSnmYBJMCYdBsPXNZEHNIv CjeQDxP3P9vj2ZqF1+n6GA/S+6dN5Eo/vowQB5LGuqEhTHi8huhfcHfKt1o3cpY+JOWp kuUwycosWV2Pdidz/wNxpjEKlmnQgt7YSn0HhC5+V9mel2EJcrlRf3Dpc6SGMpRAO5Vc W2IXKuUluyjnTabulcQy5rM0aSAaHrtiFKtwas2bxbU7UeHYoT8r8yZLqIUY9jBflO76 TV4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553103; x=1787157903; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wctmwy/+rV9SrvO63suyHx9jYj3uIcWMAuL/oEwqgBs=; b=NIQTsT0ULK9HmdbI1u/bwzgwk2OvgujumFFLeHuub/cyKxjJZnvst/pRR/I9ILFbNK JEnXRKnycC+JheyUGFl3b0zYSOXbDxplK3K8KypC8TntW8ZC1CpFMyEv3yJo7RVoumAK leHR4PRkeNOqg83nSHWYL3gqG5+aFXwhQTBttiVguslzNPyWjj5O2lck9X6q5gAotfiD V/tOpb5Lv4Uq7a1je553qwDwa1JN58+9V6TPu7R3i8iiK0XIiZL8UOHe65hY8PUlg6Ih sJsZnFShdz+YOviBYw4kWtAbud6qkYprqEohCU/zgMXyrrUolqN2ipAspfMVaLFBeTsn u4Bw== X-Forwarded-Encrypted: i=1; AHgh+RoOPWlyqdr4fGKIs0EAH5bLc9OJI18aynkUuOKBDeZWdQVq3fWYtCcsPHUP95JCjx2WgqnmqDhAxxH74p4=@vger.kernel.org X-Gm-Message-State: AOJu0YwFQKVqzKfnOSSfe/Rpbi9th7SoGV3KLrt7T0HkXTG6go8Lww+o 0Mk/SLywg5nBSl9oGiGB38Yceh0s+zBJGX02F1D0JX3pr6fA4VxUN83J X-Gm-Gg: AR+sD10YHCkTY5yapgHQ6/pl82IsGDPmF643VbZqAiAqUncREVrvF1Nn2TjVjrtyiF0 uc7rCyyzfBqRIvK+BcGGVjaNc/NYKV0wkJqf4vOKDxThDxYbQh7VZ0y2cRlFQ0cfhHeyP9q9YgM 7TJHZk4mMPXYBuPR+G57mWbuL2Nha2GZO7PhgniddzzJ+JdHilr8Rc764qt6ZE84N8rqPx9tGTb uf+Tb+T8P/QeVdPmIDKYaZmR1jdpCkouswPbHsE5Fc5HL5LHD7a3+ii5KRLFxVVRqEeTt0deIGZ 5dIkp1YMFxodxFK6rxlFbGYJNNxacnXJD4c2lHK/vviS7W5yZXEmUaAUqRFYrm41uJbOSVRr0oX qEXz3wFA1mJpVVtYQWmgBD72a0TbBpvZS7A+QxX8YYPLXmtkwL90JxXsQ1NwOkQw1xalENBQ9xW aPnvDdnxQ5knKMCqnPsPg+dmCGDGeUSd/4AysunPOJIfOWL1jWpVU5p5A5NE+KOMwekmzee6jzu BnUR2BogVc3ERqFHy3f1krs510CjEFw/o2+BKYaJIQfYQ== X-Received: by 2002:a05:6a20:734b:b0:3c0:b766:74f4 with SMTP id adf61e73a8af0-3cc3f7e214emr6339487637.31.1786553102742; Wed, 12 Aug 2026 09:45:02 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:45:02 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 3/8] iio: adc: ti-ads1015: sort headers alphabetically Date: Wed, 12 Aug 2026 22:14:28 +0530 Message-Id: <20260812164433.23011-4-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reorder include headers alphabetically to comply with the preferred coding style and improve maintainability. No functional changes. Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 3a14fdab56d8..293fdd49381f 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -11,24 +11,24 @@ * * 0x4B - ADDR connected to SCL */ =20 -#include #include +#include +#include #include #include -#include +#include +#include +#include #include #include -#include -#include -#include =20 +#include +#include #include -#include #include -#include -#include -#include #include +#include +#include =20 #define ADS1015_DRV_NAME "ads1015" =20 --=20 2.39.5 From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 459A147886D for ; Wed, 12 Aug 2026 16:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553109; cv=none; b=rRiAxiLBZx/FwH5jdWrDKUzbmAl2ppxp7owsjY3wuX2KyH99r79f8O9LBjBmXJu+8TR5ojIpguVAbwCwsh33e74v8wRhCYPcnejqYVD/l6JMuucjwVFMqmrQFQSZgIlb0C9Q+Lz9YbPztsLcx6+DC8naMSswJ6u5kARtMLB0TUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553109; c=relaxed/simple; bh=QUvio3n6vPHiBUgFY09fwlmR9f+9a3qZYiwY31q8giQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AnQiAzJFF3C3hKHzmSiRNzvcvWXo4FfeH79th5DfaaYeevGTcGD9kJe4BPzVatiZsyHFjAQAvCdWgLKUf9rRJLmxughT8OkfeoPveEJ/P4NZlR5PTh0rDXd5dYVRr1Toh8HOBhPFEC7Pkp6V/Rgb0zZAg3gZaAVkDzY1JCHr0mM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nyVTSxmI; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nyVTSxmI" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ce87c7e3bbso17387135ad.1 for ; Wed, 12 Aug 2026 09:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553108; x=1787157908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tc+m+PQKLTrKTCoguHDmD+VKsM+Xs95ymj9GwCb18tw=; b=nyVTSxmI6w6Dm0D3LfDo2Vrst5QyhdGJhxtcws5/JC1e7/CQjveTsc8ve70oO5C8XY BTLRBKCs48jeEusc8yXuCahuWkla+j3AksOMepr+tEVJGRKrNWSqmzU9WvHuYoGuQCEi pW1g9wnFXnhiitqFW9kxkJPXvlnmeQdDPEVPqCmJmmA16AO3rZD8O1LBeqQoa9EUQBvo D4MhtZ35f9S2jbjKDisR8MyEOvQofoBUDqSQeMT18DsUQecnAChC9QMI2+kloORvMqA7 MvrjKq3h/lXEUSBBQBIyPWhnqzkBAeqGEEQDHQ090zgrOUy+ARK1D2+XcG8TYgzQGYVO m1Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553108; x=1787157908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tc+m+PQKLTrKTCoguHDmD+VKsM+Xs95ymj9GwCb18tw=; b=JxAE1irCpewJh1JaqExkbyRi31d1fvmfSQolU0sRwwj5COfOCciD1LF8okbMMTtir3 d6C0lDz/HsjGW0opnDbk0EEzF1bj4R8SMd1IY3DdoHxIyQxwmVSn4FCdWmjXugTtQ9nt fZvpvgHBb4BP3mB7UnfUPZZRbmrjyprEUwA6OwBglUS3bjEcmuRwlQNSGRxosT3qA1rS Y7C5NYOhyDv++t8J79DwbhlLakOXHroQHhKtAe770mLcx4NzIRdq4XdBXZr1lBDw9iSj LtfyQIIG0KbOjXJxPI452YxE17BCFbC5wtAvaNNnJA0Ukck4JiTIvtfQOldLXbKKOV0Z sO0g== X-Forwarded-Encrypted: i=1; AHgh+RqMBFfLcm1s/HtP2fyLjOFwqej0sReX6bGjh66GBSzFqXa3IP+jvfHA4OgqGA0nmHaAuYMErjmQpnq57vI=@vger.kernel.org X-Gm-Message-State: AOJu0YyO2Frd/cdQTJ4NzH6nUWTLwXLoD8vYDADxLK40T0+IFwAHUC5A D5ui6uOaD/hBnA41ZMNgjoLwg1BZ0HAjGMdrEWb/Gqha7CpRFSujATF3 X-Gm-Gg: AR+sD134ZZOmg37KfceV099NxVvzoZJgTH3k+wPn2dqLdA4iam52b0Oh5vJyPjIGJWl QL/gFRL7mH6SHA/KLnSi6w9cH5luVO1VTYmCHSa1PIO0DyuZTqBA2OJtYgWMgds6v+BgUzrvGcz 2cl3z6D9QWSGlj07JAM03HIS1nsnwEeCzapXfW3lnPgU6mfCQfMpWI7ZfsLrdIJ/EXz7BETI8V4 e6tw/Gup62VMEGN34wYAEzFYrJui0y7Y/FaWzpx39hHljZcZRNvMYs9tAxNRf0OJoGqV02B2W18 nqE+oWGXNGfv1A8UkIcfcRxFbcNDh6Jlj6PKmDWLme5UMfwtyQabFz8qDS9IFUovBsteGyZ+lq6 ib2kcT3LLHIc4zXBrYHWB6bECEEQhUekk4vWr579249TK8DMkF6NuxwYy7pu9veY8Fq3w9DYFYG 789IFWaWGNa1OR7g4CmAKY/UjuyRsxkcmvkL1CCUuvBJEZfGZFTEPaJUKqYIPt80G+w24md/erw 6VLywkL1EzO6swA3otPKdBFBApVyHpfdNg= X-Received: by 2002:a05:6a21:3988:b0:3bf:c223:4640 with SMTP id adf61e73a8af0-3cc3f78f35fmr8729657637.32.1786553107445; Wed, 12 Aug 2026 09:45:07 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:45:07 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 4/8] iio: adc: ti-ads1015: use local device pointer in probe Date: Wed, 12 Aug 2026 22:14:29 +0530 Message-Id: <20260812164433.23011-5-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a local device pointer 'dev' in ads1015_probe to avoid accessing &client->dev repeatedly. Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 293fdd49381f..c88904d7190d 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -933,6 +933,7 @@ static int ads1015_set_conv_mode(struct ads1015_data *d= ata, int mode) static int ads1015_probe(struct i2c_client *client) { const struct ads1015_chip_data *chip; + struct device *dev =3D &client->dev; struct iio_dev *indio_dev; struct ads1015_data *data; int ret; @@ -940,9 +941,9 @@ static int ads1015_probe(struct i2c_client *client) =20 chip =3D i2c_get_match_data(client); if (!chip) - return dev_err_probe(&client->dev, -EINVAL, "Unknown chip\n"); + return dev_err_probe(dev, -EINVAL, "Unknown chip\n"); =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -982,7 +983,7 @@ static int ads1015_probe(struct i2c_client *client) return PTR_ERR(data->regmap); } =20 - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, NULL, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, ads1015_trigger_handler, &ads1015_buffer_setup_ops); if (ret < 0) { @@ -1018,7 +1019,7 @@ static int ads1015_probe(struct i2c_client *client) if (ret) return ret; =20 - ret =3D devm_request_threaded_irq(&client->dev, client->irq, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, ads1015_event_handler, irq_trig | IRQF_ONESHOT, client->name, indio_dev); @@ -1032,18 +1033,18 @@ static int ads1015_probe(struct i2c_client *client) =20 data->conv_invalid =3D true; =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret) return ret; - pm_runtime_set_autosuspend_delay(&client->dev, ADS1015_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); - pm_runtime_enable(&client->dev); + pm_runtime_set_autosuspend_delay(dev, ADS1015_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); + pm_runtime_enable(dev); =20 ret =3D iio_device_register(indio_dev); if (ret < 0) { dev_err(&client->dev, "Failed to register IIO device\n"); - pm_runtime_disable(&client->dev); - pm_runtime_set_suspended(&client->dev); + pm_runtime_disable(dev); + pm_runtime_set_suspended(dev); return ret; } =20 --=20 2.39.5 From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 019FE4746B7 for ; Wed, 12 Aug 2026 16:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553114; cv=none; b=Mva7hCsb+DsWHMZaVZJBeoirLfiTklCZl6UqJzEIyGiiU1aPB44UY8dP7dhV9mmWcaTvnqZLr9byoiA+mvH/3p/xCk9VOYfeI7yRcDZD8OEKmxhW9FlMkyO9eDrj9hfs8XscR79rzvWBw8J1ucuBPzmmh9sXgAsiWr9rjXA+vnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553114; c=relaxed/simple; bh=Q3QPfXEGFxoothiTJDvk7VcDlkWfIzKXCxIkN0YIC+8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ae5riPMCmB3UpGFGZYF5+9Tx0Bf58vqBizGh34bkSuITZ3EAx5brG/CcNcJ5h2WEjC+sNQrdSXfakYd4RmA9fPd8ryNHdI/C2d/kQGLupZb5HCY7h9eQLpx3I6/qoPLO0VJ2qekZCY00LxNaz/jYM2dxfHJVV66rzv8HLfmDR8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hQZFUUsG; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hQZFUUsG" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2caea3f742bso16885535ad.0 for ; Wed, 12 Aug 2026 09:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553112; x=1787157912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nbwfQtvcIrPGhiFm4QeTVdd0S+tOeW++mabq1fEtHi8=; b=hQZFUUsG0WwHAMdcUWmqe0bv2gqwdxWqtBSQ2jMF0svGAWXShtXBN/A5h+8pJL97PL 8cSbNPWeSj0DiE2loxSZHLZLNqN6PeROg823gVENR+MHa9HXluisxMSf2ZLVPld3Bzsr Ri6yyFyUrQfJr+uHt671sEVXw25BtJVDBYSJiHOLZnMV0JS28fAAFccq9nsAMhWupnjF 7aP+FcM698SHXQOyduHDjjIsRRD+c5QhFHQRTqoCSrS7lNHrj4MI1ObvqgRJ1btu9uQ4 lyozjR5wLoHkTxhaJP2o9jT9FzUJMptAY5lcFO7ewgP5ylzEuqfz1MQmxOKGWRnLuJrc HeEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553112; x=1787157912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=nbwfQtvcIrPGhiFm4QeTVdd0S+tOeW++mabq1fEtHi8=; b=h+RuuJ/Ocy576nBe7oaQqNGyVNx7jg8UAkCW+zCkutm4Q+mwy6GYSHGA1Xj4j6GgXk WTRYVC8eBmYou+gys5JNm1+ts3eXTYV54Yok5cqWzNkSEaGeGS5/Hvh3d08+8lsKAero pGWUeTkn6OFmLcDJ5tzr7uIh01Ts9jYWA411QqD3c3fffuPbJJXRDUdbmUhoMMLRjljC 0LuqvmlKRVWodwSQ4viT9D/lPq/kkHBaNdEd3v/Wd2VjrW8d3/OL0CwlOA8N59C0Z1q0 sfMSXi9B6rBfHGNoa+sPxuLdxkTx8BPHhYiVk34vt3kPz9AsrTv5vN2RCCR1RagLqukD 2JdQ== X-Forwarded-Encrypted: i=1; AHgh+RqCOBuMfRsKRvluKKn4vQhKlauPsYW9H0+exWgEQ4uE/NWpab657w0QZ573dYTRfGTx5246paMnoascAoU=@vger.kernel.org X-Gm-Message-State: AOJu0YxNjXNdSFGXa27Z76aPIqohPbMnjSInfSEp4iGjGX3DUUWpOyOZ wDLeQQN64z2xwIhKT0p0MNB1b++WHc9nKfUpal2KPzZnZKmo19pVCO8v X-Gm-Gg: AR+sD13BxXGOeZu+8U7KNrYsuOBTg/P4JP/3mNFS70dqZfCGcmjEquBG0oaCilbVRNh zbxsGerOpogam7XmKD7xvVum9FvyWVZD+CQ//zAsuM9j665AA+nqOQDWbT/bdRpUE37DA8HnKY+ 73jJK3F7Cj6SpsRkWfNuZbc9zXnEga7jDszc6ZL7QKGObenkZMiFnwkFT2336ycGCvACh3zxZD6 sx13av1h3KA1HV23F+11GIDuYXWee+2D3eEE04MvLuM0Bl22qxNh9qZK5TQAhJ7VXtpPt2TAXRd XC2Ev1TQ8OE+Fn3VVT14KWH7KKgKJwNQiWTjiqaMldHZTOvydBwSBzSST8FuhVXrVhso9HIw0PU ND4Dky/Cpksk6KqmtHjAzsrD686aIbyy1gNYdeOB+YJvrsTObRXQV8wQOl/39puzdVY2LiwKy0R CenE9aimfUrWL84GStY1/JqDDgJL2jx2KUPLCeHtqlpqbm1YnrJPy+z8YbHdmj4Ys7+ZKLp9jqU 7CIHzWz0g+To+eeSS1Wp68g4aLuEI0LwWMVQVlo5o+MHA== X-Received: by 2002:a05:6a21:4603:b0:3c3:7f50:fc3a with SMTP id adf61e73a8af0-3cc3f821173mr8451560637.33.1786553112243; Wed, 12 Aug 2026 09:45:12 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:45:11 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 5/8] iio: adc: ti-ads1015: use dev_err_probe() for error handling Date: Wed, 12 Aug 2026 22:14:30 +0530 Message-Id: <20260812164433.23011-6-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify the error handling paths in ads1015_probe() and ads1015_client_get_channels_config() by converting dev_err() calls that are immediately followed by a return statement over to the modern dev_err_probe() helper. Note: This patch takes advantage of the previously introduced local 'dev' pointer when converting the legacy dev_err(&client->dev, ...) calls, avoiding unnecessary code churn. Suggested-by: Jonathan Cameron Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index c88904d7190d..895bce7859d2 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -883,18 +883,16 @@ static int ads1015_client_get_channels_config(struct = i2c_client *client) =20 if (!fwnode_property_read_u32(node, "ti,gain", &pval)) { pga =3D pval; - if (pga > 5) { - dev_err(dev, "invalid gain on %pfw\n", node); - return -EINVAL; - } + if (pga > 5) + return dev_err_probe(dev, -EINVAL, + "invalid gain on %pfw\n", node); } =20 if (!fwnode_property_read_u32(node, "ti,datarate", &pval)) { data_rate =3D pval; - if (data_rate > 7) { - dev_err(dev, "invalid data_rate on %pfw\n", node); - return -EINVAL; - } + if (data_rate > 7) + return dev_err_probe(dev, -EINVAL, + "invalid data_rate on %pfw\n", node); } =20 data->channel_data[channel].pga =3D pga; @@ -978,18 +976,16 @@ static int ads1015_probe(struct i2c_client *client) data->regmap =3D devm_regmap_init_i2c(client, chip->has_comparator ? &ads1015_regmap_config : &tla2024_regmap_config); - if (IS_ERR(data->regmap)) { - dev_err(&client->dev, "Failed to allocate register map\n"); - return PTR_ERR(data->regmap); - } + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "Failed to allocate register map\n"); =20 ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, ads1015_trigger_handler, &ads1015_buffer_setup_ops); - if (ret < 0) { - dev_err(&client->dev, "iio triggered buffer setup failed\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, + "iio triggered buffer setup failed\n"); =20 if (client->irq && chip->has_comparator) { unsigned long irq_trig =3D irq_get_trigger_type(client->irq); @@ -1042,10 +1038,10 @@ static int ads1015_probe(struct i2c_client *client) =20 ret =3D iio_device_register(indio_dev); if (ret < 0) { - dev_err(&client->dev, "Failed to register IIO device\n"); pm_runtime_disable(dev); pm_runtime_set_suspended(dev); - return ret; + return dev_err_probe(dev, ret, + "Failed to register IIO device\n"); } =20 return 0; --=20 2.39.5 From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07E5647ACD3 for ; Wed, 12 Aug 2026 16:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553119; cv=none; b=exjLS4rW0MXzzi4uXDEfNzG2OdTSbtDhb6G1xVsGOnn+/C/HK4P0lG5YOywdQD7JAfYmEVXXZ0lLvD+OgGN8ZLZ3BTlcIDaSXAAtIAqTVishHUbXcwJgZdZywbgtqJeSHTpe3TQLd7fdNkzPKNt3i9ZiI4uDTaIG8Jw3XnLz0uc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553119; c=relaxed/simple; bh=4fFAtjCq/gogDR/iC9hbCXAyAB0YwdsmCUxXp71uC5g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=emiSUgvyDl2fRd4H9NcxJsOlIDlR1505gofTD8A1wTqrOzoptm7lGdcrv8llAaXh9O5/n6yH457XdcYyt8aO4Cj8Ve70daFPJSkedgjq2Q5pOdckvxYtB92xpUZfk9EKa/qFcif7bsUsbDTNp1F7XcqeBL0UPk6OBNISJe3mBDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rtEVsdzE; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rtEVsdzE" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3900e39d935so1539047a91.0 for ; Wed, 12 Aug 2026 09:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553117; x=1787157917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GUVQGwAdKK76pB/K5waiwIxZzAwMiKqICZUp2BwS6s4=; b=rtEVsdzET4uPL4PY739QC4x72zbkalA86Ntqjf/fYi12sRDitDYE95vhiJUMtLlPTg R/LK+HE9CMdacJoj1Ag1UAyMSzyLoeYHQBfxcJ7Lq6UxjnGVDddCgKQH4q4aEZLk99tV AKewmOpyRPbhZVQ8qeYWvm99N1GITMK//lt2hVDyjN45HpxHrhoQW8PNus3XwENgTbs4 52dFhss7F6/4hNnG9QLieZGBdHa0GAxJsawyRYnJj81NeGdyd/L1jIm1tLXiQT0czHTW 9dcONbzozFhFz5C2P5z5a+x5EQ0/rkNGCotqCi/0rEbY1oqxZSa3dfdtwOKvO8plSyhR jSfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553117; x=1787157917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GUVQGwAdKK76pB/K5waiwIxZzAwMiKqICZUp2BwS6s4=; b=Map4o7Srmd/uZryk46zafcDk+lHDSwEfwM68OZg5gv9GgqX/Rz2wf18LTO12BmSQA4 Wfa04F/1e/WYLBvPLQ7ujnD2lyFcb1eg2Dl3zdEHQEM/XR/khiIjh6LqyzF+TMlRTTv5 0KADXRVIs7l1nJ2h8T9LjywkaIoFk9ec3NCKxNu7S+cOlXIQRDzOsqUjm6UwsZ4LlrO7 lK4VdHmT2BATW1XEBreN7TqOJv+Adhl5gT8HOh8aIuZ3Q1pAwwq+rw70NQvmH2o5ZESd U+pdLMvhFWflnlO6wSlQfgUR4baQd+JqS627LA17woN14JnFL3Ntfr0m14lnlvvrbW20 9JzA== X-Forwarded-Encrypted: i=1; AHgh+Rq6zoIb44qbgFrHq0naXt7LTfwWxuC0ZjplbwvQzCoLN2/UbdJI2AP64d1aeILmFY1fczirrS3JUKcIdkM=@vger.kernel.org X-Gm-Message-State: AOJu0YxQOpSgE6ThLxYoUuQDoAwVuzzI5kMcNqJgYTrv3DfHrDfO9qA0 1NxzB1Hvxqe38Pz2j3cLcl6W3jRYnA5Yml9AlB9ZDqLa8VC+LHJTqUwE X-Gm-Gg: AR+sD10BxMvcMNw4kLR0/4bjO5ndecskbkDnFfS0maI2e2jeFwyhsDZBngKZuOcKNvJ NEmngQRGfFtqc5rC68iHjTH0qIgej9DfNaRLEgkP3EaQTKBFLqzFeEMN06Pgaa/poHLPMkIsPeE rgDbZwyX++DFr9PScnt0K+GQtaX7R07VcFuFzg9py6GqpFyDi3yxuAZgdngTfmFyuJtxMNiJFFN XaLVi4Ki3/YJPx0THTY++WEDhb36kK+3vWZH6RiSxg9mK/aV6MOOoHGCqgN1RF7n8ZAg1KD52UC 8fc136Qzl9z3mgDbug+1XOQgqN9Wrx1KyNj3lWtm2oXSdCUF/V5JSLMxIh6ltpI47aICjy45OTb rJKGeOkZzVZFl5GSvjC35Zbpzp4rmX5xVWz089h3Q9MbFCNcSJHo2r+JFHD57IaJKhVozgwYUkj GBUg4H+5d1ixFY6YaOgsRlXe8yJLmZMas0dAajijGq9c/uNtSuFFzi8GLif2MjCFv4wCCrwbt1M fC7VSuow45R4r325w7uOAXcFTYcygOZFio= X-Received: by 2002:a17:90b:540c:b0:381:3b5d:30f4 with SMTP id 98e67ed59e1d1-3930124d1b0mr7207591a91.1.1786553117024; Wed, 12 Aug 2026 09:45:17 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:45:16 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 6/8] iio: adc: ti-ads1015: convert to fully managed resources Date: Wed, 12 Aug 2026 22:14:31 +0530 Message-Id: <20260812164433.23011-7-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor the driver to use devm_ allocations and power management, allowing for the complete removal of the ads1015_remove() Key changes: - Use devm_add_action_or_reset() to ensure the ADC is safely powered down upon driver removal. - Move to devm_pm_runtime_set_active_enabled() to manage the runtime PM lifecycle. - Convert iio_device_register() and mutex_init() to their devm_ variants. - Remove the thus obsolete ads1015_remove() function. Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 43 ++++++++++++++---------------------- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 895bce7859d2..f92ec5941c47 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -928,6 +928,11 @@ static int ads1015_set_conv_mode(struct ads1015_data *= data, int mode) mode << ADS1015_CFG_MOD_SHIFT); } =20 +static void ads1015_power_off(void *st) +{ + ads1015_set_conv_mode(st, ADS1015_SINGLESHOT); +} + static int ads1015_probe(struct i2c_client *client) { const struct ads1015_chip_data *chip; @@ -948,7 +953,9 @@ static int ads1015_probe(struct i2c_client *client) data =3D iio_priv(indio_dev); i2c_set_clientdata(client, indio_dev); =20 - mutex_init(&data->lock); + ret =3D devm_mutex_init(dev, &data->lock); + if (ret) + return ret; =20 indio_dev->name =3D ADS1015_DRV_NAME; indio_dev->modes =3D INDIO_DIRECT_MODE; @@ -1029,42 +1036,25 @@ static int ads1015_probe(struct i2c_client *client) =20 data->conv_invalid =3D true; =20 - ret =3D pm_runtime_set_active(dev); + ret =3D devm_add_action_or_reset(dev, ads1015_power_off, data); if (ret) return ret; + pm_runtime_set_autosuspend_delay(dev, ADS1015_SLEEP_DELAY_MS); pm_runtime_use_autosuspend(dev); - pm_runtime_enable(dev); =20 - ret =3D iio_device_register(indio_dev); - if (ret < 0) { - pm_runtime_disable(dev); - pm_runtime_set_suspended(dev); + ret =3D devm_pm_runtime_set_active_enabled(dev); + if (ret) + return ret; + + ret =3D devm_iio_device_register(dev, indio_dev); + if (ret) return dev_err_probe(dev, ret, "Failed to register IIO device\n"); - } =20 return 0; } =20 -static void ads1015_remove(struct i2c_client *client) -{ - struct iio_dev *indio_dev =3D i2c_get_clientdata(client); - struct ads1015_data *data =3D iio_priv(indio_dev); - int ret; - - iio_device_unregister(indio_dev); - - pm_runtime_disable(&client->dev); - pm_runtime_set_suspended(&client->dev); - - /* power down single shot mode */ - ret =3D ads1015_set_conv_mode(data, ADS1015_SINGLESHOT); - if (ret) - dev_warn(&client->dev, "Failed to power down (%pe)\n", - ERR_PTR(ret)); -} - static int ads1015_runtime_suspend(struct device *dev) { struct iio_dev *indio_dev =3D i2c_get_clientdata(to_i2c_client(dev)); @@ -1147,7 +1137,6 @@ static struct i2c_driver ads1015_driver =3D { .pm =3D pm_ptr(&ads1015_pm_ops), }, .probe =3D ads1015_probe, - .remove =3D ads1015_remove, .id_table =3D ads1015_id, }; =20 --=20 2.39.5 From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E397476CCB for ; Wed, 12 Aug 2026 16:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553123; cv=none; b=BCNLez2p10D1a2rtF1crLi1WesXokpfVzKln6AOJmFzXrQ8uV6jMBG6rItgYThxeSjAJMDDi5EPvFoBqBogGIaW1gLQTk66Mtq4ZdOs2pLsxuqTfrISuzP8n46gzEWMyVhxCd1oQ/Oi3EYD7S9cRqb9J4aOcc7vNLgP6NoWz3Bg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553123; c=relaxed/simple; bh=dpA+ZNBffKzsL4q2quIm0RIpAo30Tb2yFgSCok/RCmQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Vklr2EGgX1++fYfXVIs8kPSWHgqfPlftPUmHwbeN7+rcY7nd+QCnT03vHNpYu+wAkGze0bEyIywVnCOaJcTRa0Xm72s27mizcVNZ9izF1kLBZzm/Aj5/TAJS4ua35PNXMAUNdrGMNoylLRhae4t3+3K9l01fR/o1rNs2nBtKDRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JBKklI4E; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JBKklI4E" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c96c92c0980so759635a12.3 for ; Wed, 12 Aug 2026 09:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553121; x=1787157921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s4vX8r01+PCntUA3lkLfO0IIxeRuJPOajs9j+708JlI=; b=JBKklI4EFLqX3MLIk6sWI1ki2ajl6IuhgVTxGbz/MXwaA9rV/g5bIUOdmZwFFx4k3o IyvrfeUYg3q7ZoLjr69GsQBy+bFtdEewfgbgIfAJXzOVbXx3IQvzYYfFO30onfNXwg4t /dIwAEQSn9Or7SS1boe+qy7cXdyFHPm1kP8S0J6K+BGrCH1nxB7QLGhEgXzumfHlRrsd CYyc92aLOErQzbhnA59dSbCag7tsM7BSbzNwyfUbDi1+fDGcVOCahn6VRoPELXSCl4T2 diGWGZ5CO3DJtodRLDjerQ4O68GoTBX6WJyBbBI/CVRRQ+qqPWlFvTR/takBDm7kqvKP Pspw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553121; x=1787157921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=s4vX8r01+PCntUA3lkLfO0IIxeRuJPOajs9j+708JlI=; b=oGqZynNT8FqdBFC7NjbSbmBQZ7FOvTu+cqMK9j3y4iaPRwsf1cxE3F+jAEuO4sjHrr dMP9h62z9lAAz+bUYoxZFsqw2uRmJNJXTRika+Fud74lq7HfEgG9XubZO7hHEUj1qzpU aws/zpn9hyC4s0Q3CTT0ZkUnNVCLNnyd1Euh2qSnEaOeYglx+CjzSPsxXVP47AKd/3d0 bG0ZT+RXhiFKMhdNGFodwGu2Vts+rw6DgqJS2XX+dmczovifurUthXJrSQ4oSvljqtTO oZd5qzxE4sGjTCc/+MBuxnXPgSSXwGR0zY4A76ucgPMbeeCiDdZro811qeEF0flrMpRJ /HCQ== X-Forwarded-Encrypted: i=1; AHgh+RoIdUw65suxGAC5i+HAyDKpRYhUu5B7yug6MBHGkm6vPjv4oI/lBb7LyrBbn3cLhQBOaNQKaPVAYl0BhT4=@vger.kernel.org X-Gm-Message-State: AOJu0YxPhY6yjo4XVbej7Gz/TTvYTwb4r0eYI8BBXkRVmvFp9stWTyAZ MmsWhHZjgc2unx3muKIE5wF+T1XDZW1KnoGx6EV4Dvc0XXqgPao/E7yB X-Gm-Gg: AR+sD12UKMIBMVj4zydfogA/YwmgYG2Cl3feSA14u8e6EWQk893O72ilZokMPANI5UW 1YfO7BVZzHaw6vgpqrNWunTRL6NdFvu/rx0B7bw6jd5tm0KKEPIYOlV9Ig1LRnZmdEK/A6pMAKn mSe6YjMdm1atMWEPj2NeKCJYBxl03D+ym24yTPREtANIjXRpYeKxQwxqdsIvodYGH3TXKtlo15+ AwFB5oaAZVnDaBuaNlfaUCRPCmcDsqT70k41eyoGMtLjiw2tNHS3Ez08tbqF8KZyJBx/x9mG8IH 0oU3H3ba2ahwIDGHmv0kcLoD3ZCrlTSlGVDQryz+t+4/cX44ET2H5WBAXkKPWXlocjhgRY7txDw I9ViNWzLkpmft2UT3w2EtcfZkPa1iX9kyiShJwY8TKsFyJN8awhTvcnUFsbadky9DAihjIa6fX8 GHXCzHpFBL8zQINHoNGcurtsMxBXvyPxL9u+h+s7omvaV9POG/mlxRjSnDzXDZbS5gGhYAs5URs b8JQA0sMHMiEEUX5vJyAqBQAoPKPossXQg= X-Received: by 2002:a05:6a21:9d95:b0:3cb:9bb0:8b63 with SMTP id adf61e73a8af0-3cc3f5eb5damr8021399637.12.1786553121480; Wed, 12 Aug 2026 09:45:21 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:45:21 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 7/8] iio: adc: ti-ads1015: replace custom shift macros with FIELD_PREP/GET Date: Wed, 12 Aug 2026 22:14:32 +0530 Message-Id: <20260812164433.23011-8-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently uses custom _SHIFT macros and manual bitwise operations to read and write to the configuration register. Modernize the bitwise logic by replacing all manual shifts with the standard FIELD_PREP() and FIELD_GET() macros from . This improves readability and prevents potential bitwise errors. Remove the now-unused _SHIFT macros from the top of the file. Suggested-by: Jonathan Cameron Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 39 ++++++++++++++++-------------------- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index f92ec5941c47..3c78d85321e0 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -11,6 +11,7 @@ * * 0x4B - ADDR connected to SCL */ =20 +#include #include #include #include @@ -39,14 +40,7 @@ #define ADS1015_LO_THRESH_REG 0x02 #define ADS1015_HI_THRESH_REG 0x03 =20 -#define ADS1015_CFG_COMP_QUE_SHIFT 0 -#define ADS1015_CFG_COMP_LAT_SHIFT 2 -#define ADS1015_CFG_COMP_POL_SHIFT 3 -#define ADS1015_CFG_COMP_MODE_SHIFT 4 -#define ADS1015_CFG_DR_SHIFT 5 #define ADS1015_CFG_MOD_SHIFT 8 -#define ADS1015_CFG_PGA_SHIFT 9 -#define ADS1015_CFG_MUX_SHIFT 12 =20 #define ADS1015_CFG_COMP_QUE_MASK GENMASK(1, 0) #define ADS1015_CFG_COMP_LAT_MASK BIT(2) @@ -408,15 +402,15 @@ int ads1015_get_adc_result(struct ads1015_data *data,= int chan, int *val) dr =3D data->channel_data[chan].data_rate; mask =3D ADS1015_CFG_MUX_MASK | ADS1015_CFG_PGA_MASK | ADS1015_CFG_DR_MASK; - cfg =3D chan << ADS1015_CFG_MUX_SHIFT | pga << ADS1015_CFG_PGA_SHIFT | - dr << ADS1015_CFG_DR_SHIFT; + cfg =3D FIELD_PREP(ADS1015_CFG_MUX_MASK, chan) | FIELD_PREP(ADS1015_CFG_P= GA_MASK, pga) | + FIELD_PREP(ADS1015_CFG_DR_MASK, dr); =20 if (ads1015_event_channel_enabled(data)) { mask |=3D ADS1015_CFG_COMP_QUE_MASK | ADS1015_CFG_COMP_MODE_MASK; - cfg |=3D data->thresh_data[chan].comp_queue << - ADS1015_CFG_COMP_QUE_SHIFT | - data->comp_mode << - ADS1015_CFG_COMP_MODE_SHIFT; + cfg |=3D FIELD_PREP(ADS1015_CFG_COMP_QUE_MASK, + data->thresh_data[chan].comp_queue) | + FIELD_PREP(ADS1015_CFG_COMP_MODE_MASK, + data->comp_mode); } =20 cfg =3D (old & ~mask) | (cfg & mask); @@ -427,7 +421,7 @@ int ads1015_get_adc_result(struct ads1015_data *data, i= nt chan, int *val) data->conv_invalid =3D true; } if (data->conv_invalid) { - dr_old =3D (old & ADS1015_CFG_DR_MASK) >> ADS1015_CFG_DR_SHIFT; + dr_old =3D FIELD_GET(ADS1015_CFG_DR_MASK, old); conv_time =3D DIV_ROUND_UP(USEC_PER_SEC, data_rate[dr_old]); conv_time +=3D DIV_ROUND_UP(USEC_PER_SEC, data_rate[dr]); conv_time +=3D conv_time / 10; /* 10% internal clock inaccuracy */ @@ -758,8 +752,8 @@ static int ads1015_disable_event_config(struct ads1015_= data *data, =20 ret =3D regmap_update_bits(data->regmap, ADS1015_CFG_REG, ADS1015_CFG_COMP_QUE_MASK, - ADS1015_CFG_COMP_DISABLE << - ADS1015_CFG_COMP_QUE_SHIFT); + FIELD_PREP(ADS1015_CFG_COMP_QUE_MASK, + ADS1015_CFG_COMP_DISABLE)); if (ret) return ret; =20 @@ -999,19 +993,20 @@ static int ads1015_probe(struct i2c_client *client) unsigned int cfg_comp_mask =3D ADS1015_CFG_COMP_QUE_MASK | ADS1015_CFG_COMP_LAT_MASK | ADS1015_CFG_COMP_POL_MASK; unsigned int cfg_comp =3D - ADS1015_CFG_COMP_DISABLE << ADS1015_CFG_COMP_QUE_SHIFT | - 1 << ADS1015_CFG_COMP_LAT_SHIFT; + FIELD_PREP(ADS1015_CFG_COMP_QUE_MASK, + ADS1015_CFG_COMP_DISABLE) | + FIELD_PREP(ADS1015_CFG_COMP_LAT_MASK, 1); =20 switch (irq_trig) { case IRQF_TRIGGER_FALLING: case IRQF_TRIGGER_LOW: - cfg_comp |=3D ADS1015_CFG_COMP_POL_LOW << - ADS1015_CFG_COMP_POL_SHIFT; + cfg_comp |=3D FIELD_PREP(ADS1015_CFG_COMP_POL_MASK, + ADS1015_CFG_COMP_POL_LOW); break; case IRQF_TRIGGER_HIGH: case IRQF_TRIGGER_RISING: - cfg_comp |=3D ADS1015_CFG_COMP_POL_HIGH << - ADS1015_CFG_COMP_POL_SHIFT; + cfg_comp |=3D FIELD_PREP(ADS1015_CFG_COMP_POL_MASK, + ADS1015_CFG_COMP_POL_HIGH); break; default: return -EINVAL; --=20 2.39.5 From nobody Tue Sep 29 04:10:17 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF8D947D440 for ; Wed, 12 Aug 2026 16:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553128; cv=none; b=OmU9MnH0ZCry6FRxAHO+H4rWm2AyMZeaeDezi6bi82yacmR6PQk0mOcVzoFyFVeO99sMuBqu/+5oFVrYMU+omh3effNR8iurj2Ho8iHQDgFDg3qpRR3fvb6D80lBZML2LrUIxqGGAa8d60WOCw5srbRNdM8kNtzH58VGUNg7cxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786553128; c=relaxed/simple; bh=/XNQrm4QeKduCIHL5KJ2niPZuyeWQUlCBkBf8NacRTQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BrjqCiD/eTTj8vZLrOJTQaEb0p7KQxsjvAhzTZ1PmdZmZc9gAy4bNqXLPdEFDbOPOjVjNV7Ro4o52oQd+Tr8qVpuTbUTuf+ETgGQTtZmWUmmfXKVmG2BdQB4TiU3lly2HbLhh1tBqOd+FWD6+TouvHiBuWXar3fwsl7Td2RXTcY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XY+WICF6; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XY+WICF6" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so1275164a91.3 for ; Wed, 12 Aug 2026 09:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786553126; x=1787157926; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ftJ30PM4x/m5W9K7gtsE39EZFCZxBzR1FxNyACc2aDI=; b=XY+WICF6zkkq0TB5paXl2Nz30Y43sf9k9xvK7PlOVSCoS96EJ7v2ZIEQOORuA+0939 9IG+OAEAyz+NKKwSfgyTH8UnMjhihbuc4FpEMnrf2Bhaf9ji87AHeLVkZgOVyeFJRSLQ zyxX3hj6GzzSNLp6MUDse1Gaumk7oColL0FU0aBiclxWAdMSfctJzzGFtF0cmzmCa/2D DI0rzfa15/Sstlc4TZQzl6YWneEAnWebqDnb/WGaDBM99qYaz3EsgXzODS7ko4SrDLkh uU0TZcsGKtgMVg0lZM1AH3cxFrYqFT6kyFzh/f8iC1o2Fpk2H/8ZYAeMqBUul2s+6hXr IgYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786553126; x=1787157926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ftJ30PM4x/m5W9K7gtsE39EZFCZxBzR1FxNyACc2aDI=; b=U2HbcJt0xK2+tAJ3Xnup5ZrQT4Rmt5ZOx2fgRPa6Qgmemq3F188sNOwFJ4kVeNKt8/ iNH0OIIpPltl2fSF9umyMiVx/99BVCcG2SkTiCKeryar/KBpyWoNzCKn2GvhuylNyBSC FiKKag2usNkA8pWbs6CPhool392XlnTmC4Q+Mr1ut2dz/oBDER0CAC/Hy6om/4d15eZF e6E1kYb4dcCwAyedPNoetkPoKnpjzQ2eTL3r/5YmqhamKhj8Tw5OJZbJIKXfiZhi6377 IuZap8tvriOWaB7O99pmITKQA6iaWyHzzNGZ944qljkUinc5KcyQp84pA5XiaAtZ6gVO R4HQ== X-Forwarded-Encrypted: i=1; AHgh+RqBwhYXBsFa3l1ORvlfBa9gvF9z888h9T2RNfJSvKOq9/vnJwNIUia/pNTLXDvRbTbFUNjuQzsC0SEcG4Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyOiGSw/X4CZeBThQK7oDQJzsz8vwchDrUHXUoXvRkGWJd3qkHW J5nCH2hheIZYeH1LVuQe/+eilgMARZzvM5VcmoGb/Rw/BqpKM/81TF0a X-Gm-Gg: AR+sD107mxyFBwItPs85Q7M+Dg//j0bi6EQ1+7uGsaq+Walfe1dUQY52C0LqwdeN6Oj FB9j3xRYumvt2B1p5q8dlmWrxTJWQk+HI4A3u/uE72G5fBmr+DQX1zfXaaP2W5mB4ZREwoA+TDj MLYlmpJ3FtVFoQ6r/WY0O5vSlcqrIBEjJvzbpWqrzW44kJKtp33MfH0Nxc/LXsjL6OYJ2FeP8uz oi167twEW0HWLuVfsp2rc2w7iM1QW1fk7t2D4qSFoj0V+auNJ9wrI44Y7aWPH1hq+k5JhN1KQ0g IVN7/+N4d+TQrNLKrQbagMTqkbGkCM8OhFagTJ5iX2Nb9PJbKrOWM8vxy+G4CRYE9EdTQ7pcX88 qABbKf7VopFLz0S+8PENTrMx1AHmkz7mNEQceMHQY9Gon4qYZjsfLf8x9jarK8k+Db2Pdz9+zVm R3UQgxX01EwnLzjtSvsc5HiZGFicM0Fsui6rRHTFn9Sw35BpW1thPlUlKPuQs7frHsT+LByBKwx bNqCgcb0+gsMlc8Fr58GDiYZSdHBfFerqk= X-Received: by 2002:a17:90b:5828:b0:38e:5964:97a8 with SMTP id 98e67ed59e1d1-393014c10cemr8570598a91.16.1786553126066; Wed, 12 Aug 2026 09:45:26 -0700 (PDT) Received: from debian.ari ([47.30.26.35]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf40f7151sm12462621eec.12.2026.08.12.09.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 09:45:25 -0700 (PDT) From: Archit Anant To: jic23@kernel.org Cc: dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v3 8/8] iio: adc: ti-ads1015: inline ads1015_set_conv_mode() Date: Wed, 12 Aug 2026 22:14:33 +0530 Message-Id: <20260812164433.23011-9-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260812164433.23011-1-architanant5@gmail.com> References: <20260812164433.23011-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ads1015_set_conv_mode() helper function is a single-line wrapper around regmap_update_bits(). With the transition to the FIELD_PREP() macro, the raw register updates are now self-documenting and easy to read. Remove the wrapper function and inline the regmap calls directly at the call sites. This also allows for the removal of the final custom shift macro, ADS1015_CFG_MOD_SHIFT. Suggested-by: Jonathan Cameron Signed-off-by: Archit Anant --- drivers/iio/adc/ti-ads1015.c | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 3c78d85321e0..e6b6cf61489f 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -40,8 +40,6 @@ #define ADS1015_LO_THRESH_REG 0x02 #define ADS1015_HI_THRESH_REG 0x03 =20 -#define ADS1015_CFG_MOD_SHIFT 8 - #define ADS1015_CFG_COMP_QUE_MASK GENMASK(1, 0) #define ADS1015_CFG_COMP_LAT_MASK BIT(2) #define ADS1015_CFG_COMP_POL_MASK BIT(3) @@ -915,16 +913,14 @@ static void ads1015_get_channels_config(struct i2c_cl= ient *client) } } =20 -static int ads1015_set_conv_mode(struct ads1015_data *data, int mode) +static void ads1015_power_off(void *data) { - return regmap_update_bits(data->regmap, ADS1015_CFG_REG, - ADS1015_CFG_MOD_MASK, - mode << ADS1015_CFG_MOD_SHIFT); -} + struct ads1015_data *st =3D data; =20 -static void ads1015_power_off(void *st) -{ - ads1015_set_conv_mode(st, ADS1015_SINGLESHOT); + regmap_update_bits(st->regmap, ADS1015_CFG_REG, + ADS1015_CFG_MOD_MASK, + FIELD_PREP(ADS1015_CFG_MOD_MASK, + ADS1015_SINGLESHOT)); } =20 static int ads1015_probe(struct i2c_client *client) @@ -1025,7 +1021,10 @@ static int ads1015_probe(struct i2c_client *client) return ret; } =20 - ret =3D ads1015_set_conv_mode(data, ADS1015_CONTINUOUS); + ret =3D regmap_update_bits(data->regmap, ADS1015_CFG_REG, + ADS1015_CFG_MOD_MASK, + FIELD_PREP(ADS1015_CFG_MOD_MASK, + ADS1015_CONTINUOUS)); if (ret) return ret; =20 @@ -1055,7 +1054,10 @@ static int ads1015_runtime_suspend(struct device *de= v) struct iio_dev *indio_dev =3D i2c_get_clientdata(to_i2c_client(dev)); struct ads1015_data *data =3D iio_priv(indio_dev); =20 - return ads1015_set_conv_mode(data, ADS1015_SINGLESHOT); + return regmap_update_bits(data->regmap, ADS1015_CFG_REG, + ADS1015_CFG_MOD_MASK, + FIELD_PREP(ADS1015_CFG_MOD_MASK, + ADS1015_SINGLESHOT)); } =20 static int ads1015_runtime_resume(struct device *dev) @@ -1064,7 +1066,10 @@ static int ads1015_runtime_resume(struct device *dev) struct ads1015_data *data =3D iio_priv(indio_dev); int ret; =20 - ret =3D ads1015_set_conv_mode(data, ADS1015_CONTINUOUS); + ret =3D regmap_update_bits(data->regmap, ADS1015_CFG_REG, + ADS1015_CFG_MOD_MASK, + FIELD_PREP(ADS1015_CFG_MOD_MASK, + ADS1015_CONTINUOUS)); if (!ret) data->conv_invalid =3D true; =20 --=20 2.39.5