From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5C540B108 for ; Wed, 12 Aug 2026 11:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533651; cv=none; b=IlEA23DAS40F7F5TXxz0gYJpUICB+JI4fsAsi6PHASIB33lAYpu26UODFy1Xx/8sgjGCYdDl0EZElXwaErUB+7xD61uUJi2Kh3JhuWfl/bL79ZJZoTRC2Vz3SBy3AoimeUI9jHsG4hkSzscZAk6keLQNCD+IFRBY+GqsUq1QzS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533651; c=relaxed/simple; bh=+4UanzD44hCJmgC20DfI+OizByBl/tAq1xq63Nt1/hw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FyawYm5xb9AGLKxtfcglwWldI371yf7WvxmmxfUcQVrhHn+Qlm4PGv8QBvOSc5v00Vjhwv6frJzIBMTqw+a1mTqiFfrvY6YTrkscd9pXDzSwNSquyDzwhVj0DFRua/3+h1PYIY5HMK33pfCizGbnrn2/lN4LEOfO8gwsBNna1d0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kA0Dt27X; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kA0Dt27X" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cacb8416a1so10510655ad.1 for ; Wed, 12 Aug 2026 04:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786533649; x=1787138449; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qtuJK+NS7IlYpY3lUfxDpExS70jRA4KXDLtMxQhzExE=; b=kA0Dt27XPEg8AtDqlD0/tIcghWKbcJGQRYwtWBnMi5h1o/lY9hCX/LIRMZjwEU+cYN hUIxUtDwA7AnWCwNEiabIKgrDOjFsZ2w9m1jUd6NyEMx/IVoSaxp/LfnFUbmgNvdx3uX WyeuxYMUw3j65Is6w0+n7JZQIE1SHvj6yG5ivTfOccm3adHzEXheXnGRsLGYGNREJ2mN 13vIrBtXkNngk76UBJuCaAUcMsABZmDneXd0WR34RLPRir+BQIRpv5nuQGRB2+yTCTWv WKDxCG198/NQcLLxQDTRXW2Fssx9FhPKoDODPxq5d+wDhe2cw2Dl/COqq+HpXrxntTwl 5IRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786533649; x=1787138449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qtuJK+NS7IlYpY3lUfxDpExS70jRA4KXDLtMxQhzExE=; b=N0eMakJhpgA+TM4ApiJt+J3wHCmpH/uIbBAHjohxr3fyVAK2DsLHaFbaPkHwUblEhn xggsfLcYx9f7/bgFPPvfIzP5HvrhnCf6XVjYCe/QLphL2UgEqi9oBGf/dkQ0qMe8JE1J HAyamwX9u4SJeB2wN9hy5CyAMMVBYGkrUW842ZHyH9jEGU7xHXhA6WpufegvnD5MJ0MI 4vV1SFxYfhOkL+IPxGV8wu71cb6fqUigj0LPxCtgxjZv6737IgTWL/MF/X11HubANRK/ trHh791PYEI34cQQIb9i4mRJlukxZzSIR2ebcmqx2Nq/inDhFtUNLg9/HO3PCLzydW4J Zk5g== X-Gm-Message-State: AOJu0Yz1KZbqZ+xohLIVEJ0PN3KWd4pbyDl8RSe9IHPciHxQ1MTFtbDO R1toMglhThVwdDd5T8/NooRwrqMRKPjXbHORhQd+GTDbRIRI/18x6NYR X-Gm-Gg: AR+sD11prtxh1g/tn2VCktir3Mc8YnOUyH6reTe9itON5eb7VawaFHg5y2geQCWRp8u UxSUuTsCTUwOFs78BEIVkMcxu9ZFgTCgMJj4A/o6xxQbBT+GP5BiqzsED5agXhs/czggl1lLIub C0sLUcyzKWv0OPnNN+dwxuCc3XAOBHUErUxD7he+OeWHpd3iuD4WuX3pfnRldeeWJbt0Ag80rJ8 Jbdc2NvIVKMefDUtJl7r5xaN24QGaAutGL4QDGb9byPZOs0rHXEKCRDlxhSo89lMPWNAy5NQSxV WRyzKDrox1lw48176cY8uht/qndMqYaLCqBHs8vVNIFJSscr8/tDIytRxtUldZBYpwjZHXHfmMI Qni6q31/ZWct4udYemZa3SG8NiVdAZXAatj//e4NhYW2Yt4dUbeGe1aFOz5snqcPfIEwakNWCKh xJju85Rk70/ESqWTYqMv9NaN2SfUEHG6Kmy3RhEVS0OC3e+ky5go1R0qDxDqTaStHJVJMeXOk/e QfruJ/XUps850znkbBN49WmyyY8rYzu93QM3OuwtoEQJjQUWkGRSmCMHOIViRzf8YH9oBhjMCwx c8/O X-Received: by 2002:a17:90b:48c7:b0:38e:7168:281 with SMTP id 98e67ed59e1d1-39301490a70mr4771248a91.10.1786533649457; Wed, 12 Aug 2026 04:20:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f935f5ecsm3193765a91.5.2026.08.12.04.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 04:20:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/3] mmc: meson-gx: Handle errors from optional IRQ lookup Date: Wed, 12 Aug 2026 18:20:21 +0700 Message-ID: <20260812112023.42254-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812112023.42254-1-phucduc.bui@gmail.com> References: <20260812112023.42254-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. However, the driver currently stores the return value directly in cd_irq and continues probing. Propagate negative errors other than -ENXIO, and only assign the IRQ to cd_irq when a valid IRQ number is returned. Signed-off-by: bui duc phuc --- drivers/mmc/host/meson-gx-mmc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mm= c.c index 694bb443d5f3..af94c8138fcf 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1185,7 +1185,11 @@ static int meson_mmc_probe(struct platform_device *p= dev) if (host->irq < 0) return host->irq; =20 - cd_irq =3D platform_get_irq_optional(pdev, 1); + ret =3D platform_get_irq_optional(pdev, 1); + if (ret < 0 && ret !=3D -ENXIO) + return ret; + if (ret > 0) + cd_irq =3D ret; mmc_gpio_set_cd_irq(mmc, cd_irq); =20 host->pinctrl =3D devm_pinctrl_get(&pdev->dev); --=20 2.43.0 From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CF5435523 for ; Wed, 12 Aug 2026 11:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533656; cv=none; b=cOswCZ7F7jRsomHw6sy96ESptObRT6cmgnlf4g/vqZA3dH1Cu9RUtXJ26mVEI6rXcs6ioXcD032YWFXDul+qR1p/DtJNUfQcT8zYCAI17p/MCHQEbjCvWuppdhvUnk6yJYLIUIuTFTTVxWpSQkQQ2LS5sKXa6rXQabzMssRudDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533656; c=relaxed/simple; bh=UcFLOmXzIP0Dx04MjRqGimlzwiQeIWcaZfmLVU3HySc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=awG+DIf38kUBxozgQz2bjhhSpuD80IIrx1ytyx+5gq61B0V1dRY3oitbkeK7saoYr8rWLYmKfrZWiSBd8tey40acBmuwn9VpvQxBOA7pZA+hw5fhhYIh1ObB0hfeZlEOsiW68CZeIxXW8CCuk/pke1uIuRUKqdY5r/c3wMg4lko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LTKnLAn/; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LTKnLAn/" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cca0c5799eso11002895ad.0 for ; Wed, 12 Aug 2026 04:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786533655; x=1787138455; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CbzzHBH8DpqZehMLNcK23Xh4Yld6J3JsAmwo9QAsqAM=; b=LTKnLAn/UPQ5oiotFHAdF0PFcP1oQSB5lZImOWgvx+Hpy25tKcwt9s3bgscVeJ0G4M mfTQiWEM6hEa0n5FuYR+ZSwCsSOwZ+tSLTcrVAtvvJB//eCe+vqpjyNKxtUIpkZwY8OW N9h2b4bVM4EI01DK0L9ZWLVhs3svplkMKbyWD7Rs5C0JFZK1L6wXGzfsydjSFFQMks5t EnpAPqMbwzQ3q6yDDsQQVin1BY1q78NaAmv7DUW+U/XmYdSFRNT1U5p0YJ2SiadfWytL e3cRRQPvwOYr8TVf2xAydEoc2iGbLyJgVj8jvy6LOklDo8fSxk6EgXetkUUqPxBQGvbI c0Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786533655; x=1787138455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CbzzHBH8DpqZehMLNcK23Xh4Yld6J3JsAmwo9QAsqAM=; b=hjfeLp8vkdQyBuHgFN4AVMoRGDZg4NQa6Kdd02FqGIpJLRu9+0XemQx4TnYOtumvtx rEQXCRQ2bwC9gKOI/26FnllYkWr9sbnkt15coX4LVgGcLyHdlBeG09arZ/FdK4x8Db2H 7YFCKHhqEoZUm2JSvnsKwPhc6aEwsnV8kj1h8tu8KsAlmGbq7oVw4rvhzgg5TrEKNBJ3 miRl6xg2Mh1f9sHUZCJ8uH5d4EQPEbl4Vyf7dItc6xSmwmK/8BdKnBuUErsXmmG37Syi GNaEV8K4B+IjLNp7Ds1iEDMF4TmL6jWtQPAKr4QQ0UHypVs3oCCWBKL2ZOTlEfA81UgB 1kyA== X-Gm-Message-State: AOJu0YyezXc08RXCR8lKkizVu/1NZUzI7rsMbS0pCf6lvjN430/+rdPS UCK7dGRFvikaH7NuB9rTUnUh08tekr9niAQARe2GgZus2wBzexkvgCZg X-Gm-Gg: AR+sD11ntmaSd59gg4GBeRnwkYMlMOLjlf9c/rrWi0FQYtFTdJCwfmZZyhXuSzIR683 xnwIHyhZmbQCyGw0O7EAywOfRcGuVUF4B7GZeSUnwsN5YcC4qdt5CDhMZX46ZTaVANtMPw+FbWX C8+cHazIfjkIRBY/uEhJBJOko3aChN3nNzoYAe5IsJGcY73Da9wS4s6xepprhMmrRW0huEmi4Jp HLAGKTBIV2WYRb3g7HfMiQ8FuNceGUg9qIs4tSTNnIE/P2cZflm8Y8AmudMznoSGTH0b8FAi2il 81+rxl94BvU8Y08wa5DyWwVXoF5j5/bIhUA8TijSirw+HUUba0RktiTG0CtJzf4ZbvBgUP4sRm7 A+5e9OOg5YyBynPzd4IxSw6egUvyDhy8oWjlmW84imFQuqnEilltGX8cClpejoYRRkr6NO36lQv yHBma8zYl0l9NK6XoWg35Aq2xcUjn+XcJokLCI+fAklZNhwI6UTcQbOqI+tyoY7WIp0kZgwkCgs bVdTQemAWErF3JWVV1AIMubYagfADbqxwQwHIEOdG3H+gy/tC7bFEu5IUmyRkvTiZzw1fx6SHkG MOvW X-Received: by 2002:a17:90b:1dca:b0:366:10f1:3d91 with SMTP id 98e67ed59e1d1-3930123d0c3mr4872172a91.1.1786533654838; Wed, 12 Aug 2026 04:20:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f935f5ecsm3193765a91.5.2026.08.12.04.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 04:20:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/3] mmc: davinci: Handle errors from optional IRQ lookup Date: Wed, 12 Aug 2026 18:20:22 +0700 Message-ID: <20260812112023.42254-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812112023.42254-1-phucduc.bui@gmail.com> References: <20260812112023.42254-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. However, the driver currently stores the return value directly in host->sdio_irq and continues probing. Propagate negative errors other than -ENXIO, and only assign the IRQ to host->sdio_irq when a valid IRQ number is returned. Signed-off-by: bui duc phuc --- drivers/mmc/host/davinci_mmc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index cdb9fa94b56d..4765d2dee599 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1248,7 +1248,11 @@ static int davinci_mmcsd_probe(struct platform_devic= e *pdev) =20 host->use_dma =3D use_dma; host->mmc_irq =3D irq; - host->sdio_irq =3D platform_get_irq_optional(pdev, 1); + ret =3D platform_get_irq_optional(pdev, 1); + if (ret < 0 && ret !=3D -ENXIO) + return ret; + if (ret > 0) + host->sdio_irq =3D ret; =20 if (host->use_dma) { ret =3D davinci_acquire_dma_channels(host); --=20 2.43.0 From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE38438014 for ; Wed, 12 Aug 2026 11:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533665; cv=none; b=hJY8dQbAikMiA/+foIZTzDKFUBFEJg2vHWFMoChUstbvPbTiW5+bPhOkNNl1q7KPeLC5W8QLOSPRkRv/FuzJ4y/1YsyHe7UJ7Tp4aj4GhpfQmZIazwOd+EqJFs6oXKQ1bFL0S51YXHX5gdWpFrwqw4oV/cYzp7hMAgOIX69Ej9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533665; c=relaxed/simple; bh=AQEbC5gXjnq96gD4UbxnJsrrXRSK8uBtmRVGLbSyuhI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ujXtWgWTT/JKn5dXDx6GU+eJDUk9NQ04/0MX4sVpS1ffvCJw+pHLA85XK6YXusoUzRwXygtWLo/EwNa18TR9xBrFFmvUJ0tnV/JZw6VDceiZ3Sh2WuSMDfs3W1nXNIn9SCCY8bwJIWX9yYJEIsSYYLWhor/mpoOKDDAlfOYqGkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lILSSDuv; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lILSSDuv" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso1418568a91.1 for ; Wed, 12 Aug 2026 04:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786533663; x=1787138463; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=doym3QyHT8bL7rPyfRL2QEekEkOSH3JrEcV5LcFpHT4=; b=lILSSDuvd2PlLtSY2uzE95zBDvcg7bHZUUirPl3InUMuTh2qaUI/6tE4xa3QMTEM3x jSyMm55r0wUSVbMWwZ9oCu00JELdehFLAhwGdOPEkeaMKECLGsZfVmgbQDk7Ty/swtvK F1LYbqYHJpfu4A99pxObUQ7lT0sEJoa1beWeykipkHk5pK6TXYx95u+2V+nd2cimONV/ qaQXWn0vDvUxhc7ZLPZGSGQIxkudK7BuM+Q6e/f34dx4LZLySSoWhXGF/42rVyXUgkHo dUp11x0cgCp5OILA/wFYkHTw5KZypIaytF/ncOvE00WcydcDBw/gZ3moCpopjKGk/b9u 6GvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786533663; x=1787138463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=doym3QyHT8bL7rPyfRL2QEekEkOSH3JrEcV5LcFpHT4=; b=cNO2dn05Z1p2gom2NBEMf+iZukdk330ZOCeyTxKKh80oixPAKjnKvzFwSXJaCRqK1s LxynyNcSjTF0vL3W86VXuOrjo3mqjMLbYp1NspdIuxRLW4UfWgWLg32mR1sTULUHEPh1 +F78MS9QQNfy6xzIAmGR106yEBMCJgIUBGlPn1ypvMTd6fuLs/5igDd597/dHdIUPqV6 UD+ipSQj9kg1UUYDbpMCOARl1+udCYT2peOgXaIQzfTx4U9Y4kl6ahJWBd0bHYRUa/0c 05Ts2W6K6kZr+P+amxtDXvyfWgQOguiHWnXRDgw+ooAjJF4N8sopKOACZCWy1GPItgmM /WNQ== X-Gm-Message-State: AOJu0YyJfOlpN0zCM9ZIjECmo5le2R/59Sh/Qpp0Z1VO3VZ9hehchgj8 H8fgpGs3XDvPdMXNdPs3mLlI/sFTqYkgXlJEGF0/YBu9MdmCzwGsEdJ5 X-Gm-Gg: AR+sD102c82lPa2dloJkaIh+5+PGhu6YGSS6neF8ESalMUUctpEYXviSJlMwm+id/aT 7KucgqJyTWpowcxNOzcaJJxompjmYyJu0qKV7bdS2S9z9j46887eUysIeTI4vkp0B0bZASKzays R6XJLTqKnQdyQXXl/POZ5PMbeQL230X0Ch6jfQHRq/yEo15wfArZDEQnT9K5XW0bzpzVMQ44kBW xwIvnhjVb41zwBjkurShIebmGg5GxDQv+3ukTVrHQJxZwZ1PYhv/v/gTbGTOnkLWRa1Cyqrf6gY BVx8AAZwsjRxrz6vMo/tUOW5wJ35dBfCFOfWTCXx4VovAI+8HZ9nEnop7nYLuC9DBqzKLsHipQO 9nlDlJwWNTSjSFyrLn08wwkVqz+Wgt/3DDEgoxH/aw6183g0FKEzGt602YBlK4tpm4noRjglm6u DKrd1RLaccnsSa7MDL/cAbT0XtKoW0xZWx03mLsSgBAFalomQrQAUo7c4R4+IftZbQBkemdOy3f dNpwQk7BYwKw0UDKOjLB5i1jcRcy1Mj1vAjgJ0xDC3E/ULuYlas/zpNz4tLW5KE4lvIz93jHY6g xJbDRWr8fg== X-Received: by 2002:a17:90b:3807:b0:38d:f096:a1dc with SMTP id 98e67ed59e1d1-393013e58ecmr4752057a91.11.1786533662842; Wed, 12 Aug 2026 04:21:02 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f935f5ecsm3193765a91.5.2026.08.12.04.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 04:21:02 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/3] mmc: davinci: Handle optional IRQ return value correctly Date: Wed, 12 Aug 2026 18:20:23 +0700 Message-ID: <20260812112023.42254-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812112023.42254-1-phucduc.bui@gmail.com> References: <20260812112023.42254-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc host->sdio_irq is assigned from platform_get_irq_optional(), which returns a positive IRQ number on success or a negative error code on failure. Therefore, 0 is not a possible return value from this API. Check for a positive IRQ number before requesting the SDIO IRQ instead of treating zero as a valid IRQ. Signed-off-by: bui duc phuc --- drivers/mmc/host/davinci_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 4765d2dee599..dddd152d2ec4 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1303,7 +1303,7 @@ static int davinci_mmcsd_probe(struct platform_device= *pdev) if (ret) goto mmc_add_host_fail; =20 - if (host->sdio_irq >=3D 0) { + if (host->sdio_irq > 0) { ret =3D devm_request_irq(&pdev->dev, host->sdio_irq, mmc_davinci_sdio_irq, 0, mmc_hostname(mmc), host); --=20 2.43.0