From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ACAC325704 for ; Wed, 12 Aug 2026 08:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524737; cv=none; b=Ili9lB4UccHaeQmmsKKsaDwy2B4Bdx5nosh+8m0NlGWt/t8qieMeDaYwL2fJ3ulZR0GyUNmVYvIFovWj36KXCMpAnr3QSexBahyz53HF76IuoCR7jQbgdl5ghF+ajshKvoKJEIEVi84PrcN0X5NcC/iv57mKO01oYXO3bT+R74E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524737; c=relaxed/simple; bh=4SwQcIWJWlpsAy2UeX0JxQJgG84GGQZTWyXoO0gVZiE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YLNs9VwXsiaDlO4Md3YYWAk3xCtP4GnJKlcrj3BrRcLkLhghLWZSUqV//GaYCyzXf+UCCU1jOjN64J7WiiQGJ8/N9/GGwPYcuw2GJnRzG7bZ6zf5az9DEtREeEqLRkAtlnYw7wExKFd7hWHAH6kP9nAhbd8kkMmuelscMbxP5yQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ayJLZIQp; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ayJLZIQp" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3900e39d935so951410a91.0 for ; Wed, 12 Aug 2026 01:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524735; x=1787129535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wYQUVgZF/U0wEavvIRgRQfroGiCAdrHwYvc4Lgynj3E=; b=ayJLZIQpf4GhvdVX3lDGGTxrYqKDqj09/BjAgmd4qI5Rm7kwyllwv4xfuY5BXRt+Fj r7oR8Xv2XgnN10gv8zUZV7UG+bFkYCKzVJ6wt6sH7PBD0KJsDzP19XoVnUXEWeSGkMtJ /5iPUPilz6PTCOqKD9l7wrZOKVwFnhRtfKRXYpWnDRW6WAdw1S7MHSZ4Nagn72n8dwxx KXeqhmSSTsENZDqsH6P0c4H/HVtQHzx415L7v9M2eT/Xmbay+RC6/HIQ669LliNIv94y S6E2KxFwMlxnHX79Qr0vfImtYt0D249IQo1PU7gk1fA4gAM8X1Ssd2itTuTY6LnnzgsA CejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524735; x=1787129535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wYQUVgZF/U0wEavvIRgRQfroGiCAdrHwYvc4Lgynj3E=; b=Niv2w4lunhjWSHWJwbB9ubNe96w+5bZsnb8d+QFKyUoKBLWLL27R6FrauMvxNHBLK/ kyModEca1jaSv58ZCJ2LrOOpCUE4F+hPTZJo9rJUJeZ9i4eEN/WgsyWABHptsUbdznYc R6tTEkDxSNiPcabxVjslzBHIZ0Ulxh284+CR7nxkkLs+UiWOVbherZR8rcuLlQbQUHCk +UBve9AHq2/R1SIyB+Ebh1iBK+1UP5pOyLScjI7iTYUnIwKwjP1q48R1xQ4SfwMOHgsV +SQ27pKNAioVAbO4djWPveE6KXzJzUxSfE6PCsGct89RdLvYO9nfU6bm0rdzvAmpPD2E 7SrQ== X-Forwarded-Encrypted: i=1; AHgh+RqsjaNjqyxpxc7ijtfhFGlAQhRQH9hJNAcv1CWWpPfJMxBQm2F7L8vY2/iHc2w5EsQAbubgZ6wK1j3gg/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi4THVu2Wsb1KzEuE4g9amFDq2iZvqXTECa8MKrO1OLd8CWlUO Z2zkXktBGFXv8Z9cXgYq8UDIUXEX0lh7oI0mw4TPlC//+bPrOwdpPt1F X-Gm-Gg: AR+sD12uMo/goDZOhx0kDd/vKP2zHu1Ax7Rc1ou6Op05XqCbbj6PIEnR7h2vtfiG19r vZC2L/gwUB5vgtoUd8re7EZRfZjwBMgt3h8QwCEAErqJdCHGJ+0gtaGSH9arq3nvyRL/9H/vaA2 J9i9MCOcRSPAIwSV/hz56rms4R5wWNOG6Vcraz5bk5GiqWSfDdH1H61FvnZOGAsGQBT9h+zY+e7 WZPfW/+RvyskeoPUgUPb4IV+u0A2d8m7Ga+dYp4EJzH00MiEsF0BvlSYQ3/djZ/MslEg3xZfirl AUZelFWzuCyuVVxES9EsSSPrriprDZQ7ZIqqRrFPbciW6IGiZEhiQ9NLjRXNA8ZGt0njmSjrPsy Zu/ZVNGJUYi4lEq8g5zdpKWN7lBhXAAzcRCLxt03UMfyO9WMMZz4ASaQXC/ODmTgZ7wu+JT6ZfC BcIW6G+os68E3POoREw78UXCsJUugEufMDM9qS/xAmDAtz8oVP5+QFGOD2RVfRUdjC8XhmmB9qq QHqqanZP0eDsPYkmLhoQJxKotqIDBDdG+yGifxUdpyVC06DPd0aaCVm5uBqjJUAahsZRyYNH0MM 7s1s X-Received: by 2002:a17:90b:57ed:b0:38f:23d6:b4a9 with SMTP id 98e67ed59e1d1-3930164c8fcmr4000105a91.21.1786524735514; Wed, 12 Aug 2026 01:52:15 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94d30f4sm2916303a91.14.2026.08.12.01.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:15 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 1/6] ASoC: samsung: aries_wm8994: Preserve gpiod_to_irq() error codes Date: Wed, 12 Aug 2026 15:51:28 +0700 Message-ID: <20260812085133.29658-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812085133.29658-1-phucduc.bui@gmail.com> References: <20260812085133.29658-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc gpiod_to_irq() can currently return several error codes, including -ENXIO, -ENODEV, -EPROBE_DEFER, and -EINVAL. Return the original error code instead of overwriting it with -EINVAL, so that the actual failure reason is preserved. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v2: - Add Cezary Rojewski's Reviewed-by tag. sound/soc/samsung/aries_wm8994.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8= 994.c index 6db91b73f25c..58e3e08225de 100644 --- a/sound/soc/samsung/aries_wm8994.c +++ b/sound/soc/samsung/aries_wm8994.c @@ -374,7 +374,7 @@ static int aries_late_probe(struct snd_soc_card *card) irq =3D gpiod_to_irq(priv->gpio_headset_detect); if (irq < 0) { dev_err(card->dev, "Failed to map headset detect gpio to irq"); - return -EINVAL; + return irq; } =20 ret =3D devm_request_threaded_irq(card->dev, irq, NULL, --=20 2.43.0 From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2379C40098D for ; Wed, 12 Aug 2026 08:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524741; cv=none; b=j6yTjby+BcYRAoGwExCFjoiKaqKN2dN4kqFGBDDP0KBXbN5i/ei2bU6xjhp+dZw3gv+N1uwJjgGzolEgSqLijuK6cFBuJkEtGkFndA+vUyyYE+YsRGV6hh5Cgj37ETkki5JRVQaBfyVKAX/9pHtToQsAGGYcgm+qT5snnq+0dRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524741; c=relaxed/simple; bh=GOa4PCeZb3TNRPAngDxKwF15NFCECYzINypupzd8BtU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jVg/3GARxAM+29j3Tmp0OyTkP7MbLoaM1Tl7dmyZfn7N7ta4RsEouhIq76fcubSF9t2gCTqMRmUpaEbUXIARGW8Ir9kDSVJX4S213h7Ojk90HJ1eJpj/iduSh8JZOIB1bw4eqF+sszfbrMX3RgrZsJtkQu65VpzqNoEGcWORKmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ez2zOAnF; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ez2zOAnF" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cca0c5799eso9886345ad.0 for ; Wed, 12 Aug 2026 01:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524739; x=1787129539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4x5jxb12BWr160Ndtvg6XwQshT8/0VQ/I3/i+j54xi0=; b=ez2zOAnFdF807VXQRzcYTRMVH/P6OuTk4JPqvpptGohLUkyF2x9nZp+unc+FYWgFZy UotQrC3rxqvbK3D5t97dWklOE8ryRiAONcw7cabtJ+vQ06xoVN0rzZLEQ98O1289s4od zAe5fHDoya5/GxFuldk2BHM0OqA4VISVFSD1G4/Bg30KQXJTFXYRVHZoFZPXk+ZqjElz FiMp0Zh1+HnjRh0REvfYCzyGt70oRCi71K9vw3w8zRk1ZLEAWuNmWjyTAW9EmNSj0eDd VMB1c0PAYqDZTXzaSujS5KbVBTglC6TFC/4Bp7JLc8Jums0fzrqW9Hcv8fL0kGMxdhjk /i0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524739; x=1787129539; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4x5jxb12BWr160Ndtvg6XwQshT8/0VQ/I3/i+j54xi0=; b=Mo4Gi1dbIJgBRTFhly0t9I8Ki+h6TW7J0dVvHTqcSWiB5xjuAiOXyBieCiEsnecHlh jfeLmOAdsDO2/Vk8w9QQCpv3cCzJlffnQ2of1/5b2qOEibrVqpZ8wx/McIDvsc12w5JI 2yUxWptC69RGC7cuex5WLOGE1pF51/qReWtQ7/cMUhi02BSBMX297gch2JYGqGupe1Ky /CFv2cZqh4uqZZocbLP5HHjt/p7wXpHX78NnWwyOQz9vL0JGZznhAKIUH5QDVog48I9o OTsujZz1n2QGyuOC63jSs7K2zL2jGxYaXjo2tLjXkjcg6hCgfIbSY0HGWv2A3jVe2HFW 04Mw== X-Forwarded-Encrypted: i=1; AHgh+Rpzc0JFQvz7xqkKc0Ei1RhuWcSwLjqkTKqfC9CEzDjZHGwyKAtDO3cKEawsDCQc71l/lEwd/2QkfVmbc4c=@vger.kernel.org X-Gm-Message-State: AOJu0YweKE+VMle9+7loaxGGdCxKnVoEtXOOtXcAF69AGd/lWcMMa9kP dMSs8TysHQQyd+7wXLNABlr+dAzc/ilakAiSEN91eFRkrEM74WC5bbrFZ6/tsA== X-Gm-Gg: AR+sD118aigPdhEfbMgrurTUXaXs1YMOR2gc4Z8pTs5jz+/q83ZnoZpfQqjCqWyuLG2 feJfrBdTJva/DGvroPQ3tlYuU4YMHsi36GyoEhIxXs2p/tJ8fcgyWAuxmULs/3htR2+IDU3HOBp 1OKXCOkDK2A+AL6Cg+9499eGsxR28Ss+n0YvghIXVtTtNSEhFmbf4DWUmKB/2pNbKdd62nzzQBu dQRkitKnTKtB7KM9dFHAvqF03RMRrAM9l/LfAoLJPQX65r7bTlarUZ94Em0U2FzvjdlB7sGG24F zK6LR0gOSyttj5H1BLe2WoKhrXz5FTNMlAWUU6Zz9YCIWH8TKpk/5yDlZ/p/XleNohG+0pGobg0 h80hYBL/q6loazCHOkH26uMbxjM9iWontykGCevSXcaEsxz7Brtw7znbQpK0Q1m8fmRvb/5qKj6 fd5tOA1S82wL9jXdZOVpnft91KIhiPLrJZzMy3bXE+t6SvNwB9FCQceyQWj4pR5iFm4XHUGyur8 bSXtGZCBQVwaZmYkV6MeVTv84m7z1dFoxv/PiF18ZyAiSsCUrjbA6L5K7gFAHZOEV1FDPQiv0pE XL1B X-Received: by 2002:a17:90b:5448:b0:38e:6dd:a9ad with SMTP id 98e67ed59e1d1-3930106b2ddmr3589079a91.0.1786524739215; Wed, 12 Aug 2026 01:52:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94d30f4sm2916303a91.14.2026.08.12.01.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:19 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/6] ASoC: samsung: aries_wm8994: Drop redundant probe error messages Date: Wed, 12 Aug 2026 15:51:29 +0700 Message-ID: <20260812085133.29658-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812085133.29658-1-phucduc.bui@gmail.com> References: <20260812085133.29658-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The functions called here don't log the error themselves, but the error is already reported deeper in the call chain, so the dev_err() calls are redundant and can be removed. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- Changes in v2: - Update the commit message. sound/soc/samsung/aries_wm8994.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8= 994.c index 58e3e08225de..d189db96cf17 100644 --- a/sound/soc/samsung/aries_wm8994.c +++ b/sound/soc/samsung/aries_wm8994.c @@ -381,10 +381,8 @@ static int aries_late_probe(struct snd_soc_card *card) headset_det_irq_thread, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "headset_detect", priv); - if (ret) { - dev_err(card->dev, "Failed to request headset detect irq"); + if (ret) return ret; - } =20 headset_button_gpio[0].data =3D priv; headset_button_gpio[0].desc =3D priv->gpio_headset_key; @@ -623,10 +621,8 @@ static int aries_audio_probe(struct platform_device *p= dev) if (ret < 0) { /* Backwards compatible way */ ret =3D snd_soc_of_parse_audio_routing(card, "samsung,audio-routing"); - if (ret < 0) { - dev_err(dev, "Audio routing invalid/unspecified\n"); + if (ret < 0) return ret; - } } =20 aries_dai[1].dai_fmt =3D priv->variant->modem_dai_fmt; @@ -671,10 +667,8 @@ static int aries_audio_probe(struct platform_device *p= dev) =20 ret =3D devm_snd_soc_register_component(dev, &aries_component, aries_ext_dai, ARRAY_SIZE(aries_ext_dai)); - if (ret < 0) { - dev_err(dev, "Failed to register component: %d\n", ret); + if (ret < 0) goto out; - } =20 ret =3D devm_snd_soc_register_card(dev, card); if (ret) --=20 2.43.0 From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EE1F402428 for ; Wed, 12 Aug 2026 08:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524744; cv=none; b=MNoTF96I0VhXbVV5NBr0dCDp5ykR9yvT/5LXUNalZlDS0fUvQP95PUE3s+BSai+As5zw48KPVhyu7XhyGSlImUQ0ojaocvyDurzk3weTBlcTLSUQbQgNg0NCKh6WURYRdu8lRV9TkrP2845cBpdY+ASxqi4IXJLMqqM37WTQ4QM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524744; c=relaxed/simple; bh=nCiy2DUCpShDd+3DXepehYcep5suGKpuWAHwrwbI9CM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DS+eGs1wx+ZzxzkPS4Nyac73R4mQTtjLF9yFyZTTsEVuGAsIv6cKQ0SLezBMcPl13TGVPOFPrw6SzD84tkIYAAUNpDZgju/sJ4+GDdLM6SVunc60wI4S+gClWSlmCb+lM5WsWePYBcr7+ZAjBT9Y/j0XCg4GqCyoPS/AhrzueFk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ppt/sEKs; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ppt/sEKs" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so784560a91.3 for ; Wed, 12 Aug 2026 01:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524743; x=1787129543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5aGmw597IIRWNnOHjKAFhAAnhhQFEcLMwp7IcdSALMM=; b=ppt/sEKsUAwFqeGqsKOyvg8mbSe0xWnsn0l9rfUg1HXjvm/TvCEgupi+0Y3xwVnCvw 3EqIsSwzkc5hFBHEpAT4hdsEShyeS7hdD1kooZE0eAcG8qxp690PSr2Bo+MYn4dwwV1c 5dGGMpR7dg0N+CGpRw/6hs+n8voEHqiOmYGsj/F4m9BldjBFl7gdSAMjrsjKxCBT3cHb RvXaGBLg/EykVp8TTnZ+q4e00Jn1nz1C7CPRSM0uSvsRfpwB20vjO2VA/IwBJAKc+ki9 13b/T4QSpkO2K5V6BxKlBOHn6CAzMpIpIHFCBLy4JzUWTf6UGi0tPmu+2p4Dj4d13kIy MWjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524743; x=1787129543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5aGmw597IIRWNnOHjKAFhAAnhhQFEcLMwp7IcdSALMM=; b=Gn4OxeS2pfE5bpk8vBdblH3giSmxO/+LQiVmMmzpOhg3UH0MuJOT6E7AnWAVre4+AU jnrNPRVydN6OqublZF0GaAqRTDGU1XzNRQtb0ELtLj/LwCF/vyk0maHuxmRQHyr+w7qH TFvYe0JEwyg+QUVdue5qzVTiA4AtRiBQTOpfgS9zQJczxKBWWOqDslr3x406pZo5IjTq DexAJH+asU21qVKqelAiQaVIEFa9H91CzJwqpjf6umkfGDhFjTq9G7bz6gWE0RrGk+Ce jmJm7iMYIdL/+A5enY6P34f+/tGMv3aW6ZLkRvoH9PMgaoQx7TSPj3GYZ80Atdf/N5vM ktyw== X-Forwarded-Encrypted: i=1; AHgh+RpsuNNfsYFREj5sOD/dU20csY9RSY7/Md+XpRJlIj/glvtfHY8OzADp5idDPTq1W55U1fg4SR1/iGYIryg=@vger.kernel.org X-Gm-Message-State: AOJu0YzwyTkjnZ/RMrYkPmRixPeKJeNT6rWsUwXHVegpto9Zej4fVHiI LKT0AAi9NnLIZ97TC1s80QBiBkN4kFr7Jg/4tpGaqLSFpcitGbDmWl10 X-Gm-Gg: AR+sD10+Ld++ISxbD6cUl0vtZsR9rYxNuDs70VRx/31uajL7YD5/TzjshKDI9HLfi2A UiBHj7NiRIr7YLt5DZFDEKiPSCFJRquu6utBkCo05G05EYkZPEJJGFf/6P9etzoIcRlwAM0W2Tz vTBrJKHEXbYoHaCUYryq2Y0LmxQd6S9NkvtdRZPpaHDC2PqrBd0T0LcUSTpM9yvCmJ7BRwqJrvP ST+vIPTDbgW+AnRe+eH+H4uivmnqk2KDnKGkuLV1+yChQNGLPlv64mXo1rJFT9sUA/McyvKuTrS JEMlk4sLu8AOVeUo+gwo4oSXnesHqqpfaoaev0jkdG1bUmhYD3GK+kbP/j1nRXpf+7AS0++M/XJ 993LZOtJPo6RXVdPcqnm5yakHUdRv67/qqI8K1JNnJacQ/ctV7B6djDsJOlUDDxUMF1kjNpFLl9 EhX9Z8bDJfa+d9dHP7PMdbLL2btWR/XHG8FfxAkqcv11yTcmQrTU6sPfo0l0IMqj0IV3ncWUuTa J0IGIo+Ki037g0c3RALWIypxjn1qcjGyBiw2dkZm0pc8401QzaAAin1gc0fwBWm31zJ0evW07EW ptP1 X-Received: by 2002:a17:90b:540c:b0:381:3b5d:30f4 with SMTP id 98e67ed59e1d1-3930124d1b0mr3818301a91.1.1786524742709; Wed, 12 Aug 2026 01:52:22 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94d30f4sm2916303a91.14.2026.08.12.01.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:22 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/6] ASoC: samsung: pcm: Use dev_err_probe() for error handling Date: Wed, 12 Aug 2026 15:51:30 +0700 Message-ID: <20260812085133.29658-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812085133.29658-1-phucduc.bui@gmail.com> References: <20260812085133.29658-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v2: - Add Cezary Rojewski's Reviewed-by tag. sound/soc/samsung/pcm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 309f024bf2a4..7e7284125c3e 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -499,10 +499,9 @@ static int s3c_pcm_dev_probe(struct platform_device *p= dev) return PTR_ERR(pcm->regs); =20 pcm->cclk =3D devm_clk_get(&pdev->dev, "audio-bus"); - if (IS_ERR(pcm->cclk)) { - dev_err(&pdev->dev, "failed to get audio-bus clock\n"); - return PTR_ERR(pcm->cclk); - } + if (IS_ERR(pcm->cclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(pcm->cclk), + "failed to get audio-bus clock\n"); ret =3D clk_prepare_enable(pcm->cclk); if (ret) return ret; @@ -512,8 +511,8 @@ static int s3c_pcm_dev_probe(struct platform_device *pd= ev) =20 pcm->pclk =3D devm_clk_get(&pdev->dev, "pcm"); if (IS_ERR(pcm->pclk)) { - dev_err(&pdev->dev, "failed to get pcm clock\n"); - ret =3D PTR_ERR(pcm->pclk); + ret =3D dev_err_probe(&pdev->dev, PTR_ERR(pcm->pclk), + "failed to get pcm clock\n"); goto err_dis_cclk; } ret =3D clk_prepare_enable(pcm->pclk); --=20 2.43.0 From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24F54028E2 for ; Wed, 12 Aug 2026 08:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524748; cv=none; b=ReXNA5yGFAuJA8MUUuLmpgzRNrc0a7o5SQCWF9pkknOmNdEH4F4vYuvMRsaCcFW2l9yp9qfQwI4CudEamfBK23loCncbZeX5jnpS/i4sV5EnytUBq7d3Sxh7lMTcthMWxSdvH03FbJBwFIlhMn8+lUq13S1V4H+WTZJVAfL37AY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524748; c=relaxed/simple; bh=6cNiENYFBKbqUwsv2G8+gBfYkuwyflZwGvXYv0IGXNk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOaOsKhPdv+l3T916lZW9kOIVtLBcf+aDHmEjrYz08PW2v7F5X35ivmuaTUao+tUGAbSD5I8gkSV3TrQWjlw++UgXq/cnr9r9PdbTl4w87HOl0curjwVUGMEk6q6FiaON7BWbURirJ3R2ucjegKXWYSqtD99x+Xu+APmLnXA2WU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I2F2pUhO; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I2F2pUhO" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38fdeaed181so892971a91.1 for ; Wed, 12 Aug 2026 01:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524746; x=1787129546; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kNWpn+WAlaVre4gvCr/WeLyDTlvNNiQEtMb3bfvk9HI=; b=I2F2pUhOdOqzPWFdu+dvyPNP5j8zzw9ncSVDSiJVoOM4jIPVTlY6abWpjsNu6Ha8/R ijwgXMvWY0uGJTGA11KokEgQzzy90oWTlXK0iLh9vLomiINydQ3p+nKTquu89d6A+GQ+ S0+PoRs2xWUVJx4gQuMHTUDvEePb5sXhQ6PCDNvt6XJeiqMdC1vZnOJlJdqV1a8ct5pK GUymUUZvU6LccrOi5Y1R2PYe/545ALBIM6/0SE+lUllX3t/k4H+okf80BH1CoLjEMY7e szo9L9uLjKWln7FqKm46DcoW2cenWOY+dFUa67pRWicYOlM08w5kWjV9nC/gbFw+C/Gz +B9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524746; x=1787129546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kNWpn+WAlaVre4gvCr/WeLyDTlvNNiQEtMb3bfvk9HI=; b=UVY82L4f85ec0/L/hjvGEORUYGonkVjs+ENkAI06s43Cag9TVh7983n47ObvVz5pyF NRdp0wuI2VIm3ulnl7ZFeDjqpGCPs0YyMgVUexTG1xfBP2AJvFOGYsdyYpkWbZzDLIX0 ymnxMq30gNRUYcYlEiw98Cl470w+nC1DEHXTKOKeM2NG1XhCb7T9lJBVD96ElsX8EkUv Ijii/1kL9ltaLTsmJuBjYGSDLT3jE8HlCgnoFrvCnEBpra0enBpb36QA9MRxFLPWp17v 7fne0++FWIcGci7Rf4ZB/eSDeGJrMOgm0TXax9vRLzlFADoBxRx0D0B+D34gXyVEXsIo zQAg== X-Forwarded-Encrypted: i=1; AHgh+RooQJdXNuyc1qryMxtA7eNtNqORV3jF07PboOP6Mid8rriNj8IWwTXVo9NsMsUs1IRjsprJ3eyrJbrH/H8=@vger.kernel.org X-Gm-Message-State: AOJu0YxqWdsfKQE2YrKoYqCtHzbDv2rfa2ON47om2ChGaLeUWMs7ktms Ko4mzEl3nFhIEMkd9PhrF/DuhtwU5pMz8FJyxJWsbr8Mvn12YapBvJgw X-Gm-Gg: AR+sD122W6InCJJwjgxBieMCm6MZifKX+fqObzAQ6h3Rk5g6EW9pRyBl/00ChRnQw8b kN5bCcDhrLcBqFTeXfDenvNZLTOQb5BlSQmiK0IbEtizi1a8nxy6+sK2nTVVSCGZrsoTlkpMC8/ UqNppF3gGbqssGfJfAce1lDk0bLDysP/TafITkY6CCsvD99GNP+aFfy3lbFUBnygWfZtVSlG2F2 aMLmSXEzp3aGD74bqkLSt2fdPPDAxcDhPw0WUDzSqu7oQti2sL14Ya9KZYE2R0pgWP8rg8/n3Z8 TO43GOlJeZ8JbzmSPYD+NRIw5sYwsoOZb6Vd7BrDf9X8pv6XI9PtygqCdAf+zOtWnsp/ccz68Rg xTiM3SMFM33qx/sOWdynEiXyISqCMmE7xjUEM+WjhkBCdZPEQbg6U7wkcJyODw8yEGydoqxVoDN t9LE0jDSdjcijMd7i3/D2NjBz9u57u5OhwVV+xFprvuWzs/0Ook/aQVmOBO0ppRVoOoTUNkv6oX k6wV135eBvXO/X95oBCa7rvP9mFMdTpqJuj13VNHe/hxFGqXW44FqU+4EFKOdQ2AEA3wgIO0YSI +wUJ X-Received: by 2002:a17:90b:4b0b:b0:38e:2524:724f with SMTP id 98e67ed59e1d1-3930151d3camr3603942a91.12.1786524746243; Wed, 12 Aug 2026 01:52:26 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94d30f4sm2916303a91.14.2026.08.12.01.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:26 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 4/6] ASoC: samsung: pcm: Drop redundant probe error messages Date: Wed, 12 Aug 2026 15:51:31 +0700 Message-ID: <20260812085133.29658-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812085133.29658-1-phucduc.bui@gmail.com> References: <20260812085133.29658-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The functions called here don't log the error themselves, but the error is already reported deeper in the call chain, so the dev_err() calls are redundant and can be removed. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- Changes in v2: - Update the commit message. sound/soc/samsung/pcm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 7e7284125c3e..8430686760d7 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -534,19 +534,15 @@ static int s3c_pcm_dev_probe(struct platform_device *= pdev) =20 ret =3D samsung_asoc_dma_platform_register(&pdev->dev, filter, NULL, NULL, NULL); - if (ret) { - dev_err(&pdev->dev, "failed to get register DMA: %d\n", ret); + if (ret) goto err_dis_pclk; - } =20 pm_runtime_enable(&pdev->dev); =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &s3c_pcm_component, &s3c_pcm_dai[pdev->id], 1); - if (ret !=3D 0) { - dev_err(&pdev->dev, "failed to get register DAI: %d\n", ret); + if (ret !=3D 0) goto err_dis_pm; - } =20 return 0; =20 --=20 2.43.0 From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4452A3FB055 for ; Wed, 12 Aug 2026 08:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524751; cv=none; b=CCWhNCdPN85BipVxWAoJ6GHvCl3lvJxA6y/wEFtvTeky6h2gsPEuuW93kJX4dgHqB6Hb9xfQLkxdj3+/gb69CP4aQ3riCOGgbQS5XIMzgJ/hxqCBP+uJQkhZhRSj8mIhURAjlOnQJcDk+Vrlu+CfRn3LbFIBiyycirGXRPRqZ3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524751; c=relaxed/simple; bh=M0teJiHhZJB+s7lHKolMqcRLWg1902nbCV2zrE+V5PY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eLm7yUSmhjDYdvJ8VRCfc/Xlyfe6nusQzHqfj8gVdFoxTbcNjGyGeS90CAqYPna0ttApwsfoJViTjLyZZ6PwTax2FPPjD2YIutOpS7lwQwLro9HMYWe8vX2oXV7ZQuk/L55Tao6fPioE4l2/zJh0crQK5H8JZFoNTskJLV/1+tk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R0fzPZ3+; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R0fzPZ3+" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38a0c7e841fso1065555a91.2 for ; Wed, 12 Aug 2026 01:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524750; x=1787129550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VvVjFz5YIzhBE/JdIuURCqASBxrvK8z1MujXZBURz3A=; b=R0fzPZ3+8xszuhp0rEFEcyeBGTERyjKRsc9FQspjYpU3iScZxVsQ01e7wBW6zMkzNB z5jCq4XThkF0wxe5H/evVNCUv8QJZAIh4dIYkP/vbC5EENZvEvW9R7qZm4VpCGUMOBU9 IJu1VeqG5RnraiFFa4brDoi7NuKHUZpPvEytL1E8k5SIXzLyax8Y4IBAcuiA2G+eAXDu 4eqnKVfNVwazcrAAUh51/3UKEnL8gZhLt9+IKVFPjpN3u8gIcEvlisV+gQh5rJkL73HO c8xhrKylh9xxlMbNhbNWgHkc1MwjLU0HNmOcc9ajAlxSh3MCRTCQC5aFCaisCS8oQ797 5wlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524750; x=1787129550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VvVjFz5YIzhBE/JdIuURCqASBxrvK8z1MujXZBURz3A=; b=oXZavKsoSdGMs9fNhL5dxae9hos+mEQJBhNwoFFCvC3/oOpGqN5NGgVcNuTkTNhx30 fK+//RkVQ3cOt/5VQcls8WmFvxrbtwa9bCmlyym88fswJzm2MG4bQns+6FF9o8QUhuFJ yOXqJI3JqMkCp/YgfV8YeV5pQ0xbxxPmokT4m6S9XcYDc/1xQ6HpyPjpCDrUe6AO/kyV zMY+gQQjZ4oH0fVi+NJYvchz07iUgWZ+d5KBbyzp4YgprceRMupFKqYMO9X3xktpLiSY UqCPeAQNU9DqaE+lUSwt9F66SdfENZJ0f7+ehT+nRnANsWdl01HVX0oE9uXwpOLVYBIV IV5A== X-Forwarded-Encrypted: i=1; AHgh+RqtBdENvq9xPoyjMmiBNP9qHKM4we+ZmEmKJkeq1O8tmLiWw9xU/zGt9CEIKLDLJ423nT+AYPfsxVL99n8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4Jn0jBW9JcMHvUpXdRmblMLIelUl1lJTPW8xk94RIrHjvLDrB adYHl5WTkMIdXegM89hS8V93elpi85U6nUVK3NZD57v8+8/vcxafYmg8xawhIA== X-Gm-Gg: AR+sD13EQVAcxiBt1CVYc4BRWXbDOJWtUMfKfFgG9nc0ymvMiZ0hLwDTthd+nwtGXLX gCZHkSzoOCZzHcXvtWVobskd2qCJkishRuiZMTzCtZv00Ckl8JmwDQTTxTit/xFhI3lEfuNW9qR wDMg6ZpeNdpeuU0xEEPdvCzpa2gJ5dFmOpqfPg4qH8gXlvFdPcz9NrUnj0wMyQLPt2XNYa/oqmH EjH277npgB8+25pFfJr2cjkyA8Uexkds116JbhigjZZb130be4UYqQY44fpGYSgWybRVYMTAMni SdUL0BWWFo/G5c3SX9y+UhnleGIMM4oNEWq2s8PqrlrMrXP10TWK1MusHDNEouQNhM5KlY5t9I/ 0eh21isoYgRhQ05v5T1n65kDKCx0o1eMxebu2UVbUt6QxV9HDOFSTJVqYV09WaaD0RTHMWRTCOz Omt1PglS8YsdecS9JgjYNVHSo42nd2H6G66Qhp6z5c8CuMbhAx0ZSfDdgiaP7bpv45Mi0xVQoox 0zx/HMLOCMfTkdIz3ktSUTEDBhe/NdmbndFyFX5QhjB9QRnVrt6ltMFnw0CJV7DcGH4xk3EYGQ4 bT4S X-Received: by 2002:a17:90b:5623:b0:38e:70d5:b12d with SMTP id 98e67ed59e1d1-39301201440mr3869474a91.6.1786524749654; Wed, 12 Aug 2026 01:52:29 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94d30f4sm2916303a91.14.2026.08.12.01.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:29 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 5/6] ASoC: samsung: spdif: Drop redundant probe error messages Date: Wed, 12 Aug 2026 15:51:32 +0700 Message-ID: <20260812085133.29658-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812085133.29658-1-phucduc.bui@gmail.com> References: <20260812085133.29658-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The functions called here don't log the error themselves, but the error is already reported deeper in the call chain, so the dev_err() calls are redundant and can be removed. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- Changes in v2: - Update the commit message. sound/soc/samsung/spdif.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c index 53eaabaf8956..719083e8e89d 100644 --- a/sound/soc/samsung/spdif.c +++ b/sound/soc/samsung/spdif.c @@ -415,19 +415,15 @@ static int spdif_probe(struct platform_device *pdev) =20 ret =3D samsung_asoc_dma_platform_register(&pdev->dev, filter, NULL, NULL, NULL); - if (ret) { - dev_err(&pdev->dev, "failed to register DMA: %d\n", ret); + if (ret) goto err2; - } =20 dev_set_drvdata(&pdev->dev, spdif); =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &samsung_spdif_component, &samsung_spdif_dai, 1); - if (ret !=3D 0) { - dev_err(&pdev->dev, "fail to register dai\n"); + if (ret !=3D 0) goto err2; - } =20 return 0; err2: --=20 2.43.0 From nobody Tue Sep 29 04:38:52 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE17E3FF89F for ; Wed, 12 Aug 2026 08:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524755; cv=none; b=qx+/KALl4zNsQmE/AjIF4+5sPWXg/d4XCzRFfj82EgL65WipFpnsbspDOG6SSAhezZX8ytY1zaI6XgrBFzjLmA8fKhltwPfv9S+jS0OYTvg300c0eDWglDo7uBB2SPb9BIMuz/RfzM4HSnMqSKiE9JmNNcLXdSF3XEBOeIJ+Zhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524755; c=relaxed/simple; bh=vIVW2eGB4yvQ3yXCBBoo8CWBHiNsNWXoJi4ZAZ887rQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EiXVVOaaMFyvGvhi3MEfp5iTYQQ3I99OctSWiyP/RHCtMqBsNJ/7pUAx3ssH5DR+tVS0BltJkjLrxlBV6B6fYcWSstW2rkwZYbf2g5PtrmuMjjbpiIxUTRv7kBe8vjZwP0mbZ9jlZphedYojGYQp9nwmHL2EMHaB498AUMVfVn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e47HFYO+; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e47HFYO+" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cacb8416a1so9236235ad.1 for ; Wed, 12 Aug 2026 01:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524753; x=1787129553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pC+uMvMckRUJDqA3cMZLmR5d05+IX1EKa1AZw7dJ7+w=; b=e47HFYO+vSuEL3IKqnGb+Hi8NmWfuOIGEMThSiJT0tiOPOt5ruLHdrV1Y5o7XP/Mgx lqf8/DMHiznPb8kDqUUQtMcxXIKlKmeJ4tJPsSHF2aNIJVRT2e3lG632KsVcdxUeh68n ZwQCULp7ZgHFgiUcZMzJ9MCOjpjdJo/1bLAepERW4yZ8gMq8cG8IpK5Y7fety0qRqgoN UUhSouyMqDsTtoNSLojDnfBjFQ8vdsxAs/yDekRqGQj8J79WqPnUuyHqczctLWzgErOq eIUdVhxEzgt2g9sJfJ3giYQkAPGqsrnVooaI8bDECbB0lHivOMfhDglbkaTPbs0AohtW ZdxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524753; x=1787129553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=pC+uMvMckRUJDqA3cMZLmR5d05+IX1EKa1AZw7dJ7+w=; b=sG4RJLmViGopDsTU/+qY53qHRUN3O+ueId0xdI2YU7/7UxdGRxLxUmP+eQWI/6tWa6 +DGLxQ1GEn/hXQEtuspFED2/pF9ed/Lp9yOiQhvreWoQhSuhblXVaMYJT1WIllVPqtBN EoQN9MnF7/2IpLxh45oPeqM30/TYp9/ertlOyBFAsfVwuCrpZ3FLNX7IGfTZzpvtgM1g DSacnPu9bNSgnejiVhEL0rIrvQP0UsqHcEHC1Fwag/t7WhlFlAJtlbZlUhsCHxDtX9oi xmUS4YfqLf3OHNz+FnaWOozGSRWMTmAop95mKam3Of6LtZrlZ0wr5hNaEmWzcFq6p2Wu zhNg== X-Forwarded-Encrypted: i=1; AHgh+Rq5f8yJR6W1kI2YMUxHMH+/vIK8hqErLMY51V0FsqTlG5sS3Af6/2iPr15vaimQygJyp53CVEUaZnM24R8=@vger.kernel.org X-Gm-Message-State: AOJu0YxXg816FE6t1e4IXHBVGXQPAMDhdXQOwZJWSA7OO2q+8LuYPmCS R0O51UpCpwdd7gYUbRPouS0yhQzhtEBpwVmYHkZSb7yPPbqWpDbe+s4G X-Gm-Gg: AR+sD11DGmd/NVI/PhTFX/A99nqHO4n/DIK5iVSJ96SbOSfeaxCTDUGcp7Ct4IFcace hHrp9m+9HdcwVU8mUlCu6L1Y+QLet6aDjF4CUnzY6bnYMow/Gtu6W91DeFm1xSNeNQ8YKsljN7q S5jYqR2xjTWz7iLlqvYjASSh0qTQWQmG+ZJZFtTauwQujeeCISuxMMwTpHBmHy1OCawbjjMfURG 9AX4hGsTMnh5jTirPkwwuW2Us7/T/R7/P5z8rjiWqF8eIjxraD7ucojRX7+5j047/c58oS0EIzR Hej2iFIxgfgifbR8e9o8D3lYFW9HTHmz1whEvFLu+jATtPRJ3vv1sdUpkkeeUe5PEewYPd7BKkP K2EPYT34xWJOOeyKG+JMv8eb04h4/pAmmA//n8V5lq4p/HW3Q+ZFXbRVLHTIfQzAE+O13dlmUHu vht18FneggRqUClzyCJg1I/VK2ucVGWNzOBp/XnoDtCVKTmeHfU1wAnp+1MrCBVdvFGPQGagFSF ciSydNvOFYS9o7H2P7fmfJCVbnkj4mA8Dee2gGVW4xpkKtnWu0yRXCzvirh6HAxlLXNLxGagJI0 jCKU X-Received: by 2002:a17:90b:39cc:b0:38f:1a2e:6e56 with SMTP id 98e67ed59e1d1-393012af83dmr3484825a91.9.1786524752961; Wed, 12 Aug 2026 01:52:32 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94d30f4sm2916303a91.14.2026.08.12.01.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:32 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 6/6] ASoC: samsung: tm2_wm5110: Drop redundant probe error messages Date: Wed, 12 Aug 2026 15:51:33 +0700 Message-ID: <20260812085133.29658-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812085133.29658-1-phucduc.bui@gmail.com> References: <20260812085133.29658-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- Changes in v2: - Update the commit message. sound/soc/samsung/tm2_wm5110.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c index f1f59e059f5d..f4912826dfd4 100644 --- a/sound/soc/samsung/tm2_wm5110.c +++ b/sound/soc/samsung/tm2_wm5110.c @@ -518,19 +518,15 @@ static int tm2_probe(struct platform_device *pdev) } =20 ret =3D snd_soc_of_parse_card_name(card, "model"); - if (ret < 0) { - dev_err(dev, "Card name is not specified\n"); + if (ret < 0) return ret; - } =20 ret =3D snd_soc_of_parse_audio_routing(card, "audio-routing"); if (ret < 0) { /* Backwards compatible way */ ret =3D snd_soc_of_parse_audio_routing(card, "samsung,audio-routing"); - if (ret < 0) { - dev_err(dev, "Audio routing is not specified or invalid\n"); + if (ret < 0) return ret; - } } =20 card->aux_dev[0].dlc.of_node =3D of_parse_phandle(dev->of_node, @@ -609,10 +605,8 @@ static int tm2_probe(struct platform_device *pdev) =20 ret =3D devm_snd_soc_register_component(dev, &tm2_component, tm2_ext_dai, ARRAY_SIZE(tm2_ext_dai)); - if (ret < 0) { - dev_err(dev, "Failed to register component: %d\n", ret); + if (ret < 0) goto dai_node_put; - } =20 ret =3D devm_snd_soc_register_card(dev, card); if (ret < 0) { --=20 2.43.0