From nobody Tue Sep 29 04:42:43 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30AB73FF886 for ; Wed, 12 Aug 2026 08:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524734; cv=none; b=iVfXQDYxB6h5/EDV6r7D/Js61+sdllawPyO1+he07/x0qS9e1CpamIRqdaDYEblRAl/U4sK3zllONoFgYw0ySQP1iNnk2zUu/6G8Dld0G5HzeHSzMIuLfDEZYwHIo6WjV5KcduJ3F+o/DY7bA8eSfbt5E8TNy8OjAR4TAopcUnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524734; c=relaxed/simple; bh=+0xAuCLBDC5xjgD/Ro/yAaAIkXx5712HXKvTSxL8b/U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=la0YW9jPLVckKzxhaxMnZpbnuqxblSjcy7Rk6nNM7NyfOG9IRp5Sg2QvADV3IDYDoLfz+ZCW0dlQGI+o3v+F8vfbne+oMuXRCdB7vd3lChf+yXmgWBKXgSJO9a/K/k+VUhOYTefI0VMtzQHXjZu3O5tENWlab1EsJnAIcUR1aPg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hseiqhS+; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hseiqhS+" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c9b373d5af0so547696a12.2 for ; Wed, 12 Aug 2026 01:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524732; x=1787129532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=hEcl3LGAANT3DT4EdKMxprIzXUC4zQv09hEDAYBLKZc=; b=hseiqhS+gENyXeFD0j9XBQ1uKYvNHXWepsCQBLuRUC/I/4R2lA+ZiQ/aaQ+d/DWp72 6t9uduQ87mB7XJYG016MmmAw8QapzplCQ0V3g41RKr26q7CViG7GvIyYkG3PYugewPMW JZtXFYkMC4+PQWoPsMPX4Gsg2xvSy3HZRb+GgitNTgYMvVw9MGoPuOt99ILqJpYiLcsn +psZKBJHtQm8SDzdEjaYmCj0OOjiGG9JpoBikkD9Rs1llrK+7ffAf2yppTSd2tEB5/8A j7x3jjncAKu4hwnukBUceIH1/FCJnIVi3HfgtZyj3JflmqwwWSSxmpPLPPmHipNVTPeR p0mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524732; x=1787129532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hEcl3LGAANT3DT4EdKMxprIzXUC4zQv09hEDAYBLKZc=; b=q+kCVabxnQ9a0ZFaN7ojIGUv/gSnP93pZpn0jgVCABQ9WDYw+ErbPFhSvQ1vFV39KP IyZcFhIF2zKhSucfMzwNHc/ddHVQ1ThhjftZIm0AGDBtta+ZpTF1OFHqjePCQeGpoPW0 KlxfO4HYAta0k1N+m2Qoa2eZ8jtwl/n653t5a40WIwQ9ZffmN5ca0Hoz4EQ03WIAjA19 cWfgt+NPqztT8tqDv/A36w2WDJnubSCLtDZTjqjJNc0aSw8uF4d5yzOIRBPP3In7MBk7 GyAeslrh102je6KML5z4+4brQLpuceg5g5pxXl43MvRDj+LMjJ1z1v5VVTxbsA/twot/ nrAw== X-Forwarded-Encrypted: i=1; AHgh+RpsD3X8OXkUeQaTRdxOOIVBJCd8/ydSWJCDlvkh95wq+MQjYrMl28Haq8MtMgEl2rqxfLTk4FieusNRBAE=@vger.kernel.org X-Gm-Message-State: AOJu0YzxSGIqYiK86Qf8eE1sZ3cX3yZcctwMIg+NSocKx1w4BGI/COQ2 T4VZPXtlonmAY5ByrwWp4B+taSvjCjbRMWJQCan3IrdRNPyBkAjOwbeu X-Gm-Gg: AR+sD124RXuFr1hVvkaRb6QTkryLXf9qhQfvGso8TzjbkqHAhcYWP6lO9mYoHqvVPOz txrgKvczwkMbnivsICdPnGQpMLvM7P1/PDwqoGWHO1KhS46d7VXbwqemfh2NDt6T+RrBuuiWg1z vIetBLVFSpAO7OMZkyru1nDnfV26zQNrVtFCeI0LA1z4XjxiK+M6/TF5YSr3tDnub0HC0yNWcYq oU931P0CNgr3EWFUjzQkuNrAiZ5NHiPWXgXDLaSceLveF9KVOc6DziXkpJknk0qYiELxGBmATwm 3NN5LJ9z1AqAqNdDfpFmgIAVsiStxKI9BTS9lowkluRj/v7Ba36mzE6SldUM6PDAagiQSztWJjv 85qb5k2k+eOrlC77/fMKGbzfSSLx+H2z4ZfRhD6mG2xSYOqbrl05ak+Eie5bQ3hbcWCnZwpKDWy KrOMPjmhuMFGw3/TFFMt2UN38STLAnlUt508g4cVfBuiqPnX2spbZfq80MA6ZGySUWv1U= X-Received: by 2002:a05:6a20:c90d:b0:3c3:89cf:f3a with SMTP id adf61e73a8af0-3cc3f53694cmr3814066637.5.1786524732399; Wed, 12 Aug 2026 01:52:12 -0700 (PDT) Received: from localhost ([2401:4900:83a9:ec61:7129:9a57:4b26:1066]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf7094c8dsm9037138eec.31.2026.08.12.01.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:11 -0700 (PDT) From: Raushan Kumar To: Vaibhav Agarwal , Mark Greer Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Raushan Kumar Subject: [PATCH] staging: greybus: add missing newline to sysfs_emit() calls in audio_manager_module.c Date: Wed, 12 Aug 2026 14:21:17 +0530 Message-ID: <20260812085117.103875-1-mitramaurya80@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sysfs attribute show functions are expected to terminate their output with a newline. Add the missing \n to the format strings in gb_audio_module_name_show(), gb_audio_module_vid_show(), gb_audio_module_pid_show(), gb_audio_module_intf_id_show(), gb_audio_module_ip_devices_show(), and gb_audio_module_op_devices_show(), as flagged by checkpatch.pl. Signed-off-by: Raushan Kumar --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/stagi= ng/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *m= odule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_name_attri= bute =3D @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_name_attribute =3D static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attrib= ute =3D @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_vid_attribute =3D static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attrib= ute =3D @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_a= udio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } =20 static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } =20 static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } =20 static struct gb_audio_manager_module_attribute --=20 2.55.0