From nobody Tue Sep 29 04:43:02 2026 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435B53AFCF1 for ; Wed, 12 Aug 2026 08:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524608; cv=none; b=n0Yhg6w6eElATpnf7xKRlXwPHW+jVxC+frmIAUHyPoe2iiZvvQZUkh9bHNp9NED9zkITJcVvuOw9OrB3d6ZAkMB34IOL1KnbQMZeKrs49T+RuqW5LQy/4FrUMCpTykixCUZljcAB+EzzPCucw8jMGSnADqpMltaJXRF458KHBSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524608; c=relaxed/simple; bh=BnlANvI8WbeEf1Ztphy2XQiPW9daGoWnPs+LvO5U9AI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JEvYZt2sdNRD68Ash79Awb+O07bCT0C7TFLdXE4lWXrw+lQx6RObWvxUnY8+p9AmXWzLNDTvym4EUaWw+55bMtV7SSCvvHXVetaFU/hEKgLepakphs/3FyB+2+8ox5Icar4IaBRpNJI7ZnLRdaHLaxayKcewxqrP4nQlDqRzJF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gOl4qfCf; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gOl4qfCf" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c9ef3e1337fso527416a12.2 for ; Wed, 12 Aug 2026 01:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524606; x=1787129406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=MkRv/h1X+HN1BXMoAhiYtkmVo70dmlygE4GMmGeHZkE=; b=gOl4qfCfX+I9LHvp8EpvI9MrJ9ZZkRcuy+vgW9Htg5wY2Qluo4LeYv+yIcHt32fivI nb65PWmZjwPNgzzggY3WxIWjZPf6r/QhP0s+wlsMWQDBdezwBGJ5LhoA1kcYzh+d7yvv Zt5uqQ3Oq3xs9QtZjGgLUKBXxY8nEy/PJ+pTkzAOo5ZoAftCRRfvkpcM3wAPbu+g6SA2 rVKRTd5KB4OdE2rCuMWaEBfeZTTTtyhFXmEAjXOf7WM5KpWyqcZLqge+IDPjD2YtjTLn klj4UVmhhDP5zaI6vVKnOOKDBdQdNVVcyciLEnsSMgFIjT8wImPVgN7CeC6yoeQEMdov nvtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524606; x=1787129406; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MkRv/h1X+HN1BXMoAhiYtkmVo70dmlygE4GMmGeHZkE=; b=iczjnVZ+63ospUzR/MqiI1FDzuzwkqHX0scG/k8IJT7zvmiGEpjGMcig9THyDBLYRp S3NucijNR1wICLSl0mcAL8m3YYDoOs7eMdOQMJbE9eHf0GS8SLMeMSwGIHYnS4WNNpeu F3c3GHZ2rWILKgR4SAah5NPKuSeyDL8SroR+pjZ5oDpFdEWr1Ti+bljqgs9roRv/O7gJ HQIo0EWSTmMhYqocAtMLJL9Etyl0MsJI4beGryLjsKvBdQaWmEkadHllBu0bFIYKMM8n RuNYTX12zhY0rqFYiI7swERZF1h2bDRYSaqNsHsdVvujftQaqXTDRoXqII7UipNWpJAj Wtew== X-Forwarded-Encrypted: i=1; AHgh+RrX3l0hqh3OOjzDfBSM7RGceJlNQ/sB1CBOmYE0ZeksRMmMQJTgY8RHjTeuah1VP5NxV3q6TIPjt/bnUn8=@vger.kernel.org X-Gm-Message-State: AOJu0YwVEbKDaB6X0g67GV4ICiIvw19RF6WqPfi+8zYZegROuDsnRa+3 Py/wlCDmwYLZdzLG1tRhrf/hXPQmN9VYwqQDFjfMkyJpf29dRK6WqntS0IoUcw== X-Gm-Gg: AR+sD10v7/c4RRND4sxoWpJ2RYyp1kUJVleYVpt0fLRtH5BqxuXEHPDLtdsTh9gIr+E L5DIFDondEV5ZJ37ipRoPmLoa4R9/zn+GBQaR7joZAfDqEfdMU7R23VtRKtvBaRuNaBaPjnEFm9 D1BthOFa7SiFW1RK2UTnqZ+f5IzKJU+T1FfzW331J457b7Ty7TOOayEGe2V995CpLqxXIUZKZDn mx8JSDuUuwgzFdOdipwdX5iH4QqDC01tF53By24tB73Tmuq5cSZMftTREdO2q2xlnAHKNEh1CCt zk98Pt9eVBgmLqU5pm6PZZuNSXO9x2QqqDxf7eA78X//mHbu7GBFcGSq47amJjWLjfH8kWz/o9h b+TQYbELhBqD3SHZAlqFr+jtGsHy690lF6HrjCtTpNE/6b3udmJBFfgz6PTKH/LsCzJNannLA2S 9uqKZ3zKLDtP7UjKK32l+hVafNTRX3IStoEJ71q9iXTHyrOdVklf9GKA== X-Received: by 2002:a05:6a21:6e96:b0:3b1:882a:607b with SMTP id adf61e73a8af0-3cc3f6ea473mr4441127637.22.1786524605619; Wed, 12 Aug 2026 01:50:05 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbee7d528absm370351a12.29.2026.08.12.01.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:50:05 -0700 (PDT) From: Guangshuo Li To: Jean Delvare , Andi Shyti , Wolfram Sang , Jarkko Nikula , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] i2c: i801: fix usage_count leak when autosuspend_delay is negative Date: Wed, 12 Aug 2026 16:47:49 +0800 Message-ID: <20260812084749.3267780-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" i801_probe() calls pm_runtime_use_autosuspend(), but i801_remove() does not call the matching pm_runtime_dont_use_autosuspend() when tearing down the device. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during driver teardown, this reference is not dropped and usage_count remains unbalanced. Add the missing pm_runtime_dont_use_autosuspend() call in i801_remove() before restoring the runtime PM usage reference. This issue was found by manual code inspection. Fixes: a7401ca5596e ("i2c: i801: Add runtime PM support with autosuspend") Signed-off-by: Guangshuo Li --- drivers/i2c/busses/i2c-i801.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index b29c99ed3883..629115b5c76d 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -1698,6 +1698,8 @@ static void i801_remove(struct pci_dev *dev) =20 platform_device_unregister(priv->tco_pdev); =20 + pm_runtime_dont_use_autosuspend(&dev->dev); + /* if acpi_reserved is set then usage_count is incremented already */ if (!priv->acpi_reserved) pm_runtime_get_noresume(&dev->dev); --=20 2.43.0