From nobody Tue Sep 29 04:42:54 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA75E3AFB12 for ; Wed, 12 Aug 2026 08:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786522765; cv=none; b=YmcuG5Cy2YJ5jxoA18HbT92YBnTS4+P+PMwOnKzKbTzTEdg8nVNlc9dZ/KXbYhCm0pMNh8n3lDibLBsZEQdu5MQta9/rR+tUXQ2oL1/ZLhHtlzbu3LZM42S4j0rn5OLPppegfXmFAu86sggtHApvkbvPowmQWRgHJ6V5modQYFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786522765; c=relaxed/simple; bh=z9MnMQspr7pHxSREdgr9qgGI4U9g3l1vlz9eG6AcHiM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mQ0Qqto0ZCN6FDVsePBGVWtGgaqJsjXyt+L1nLzIB7QRJzIWGMulS6J7BoXlc2aRRiAzZRRcbxdPP42s9CXcvi+w+XsNci81lEKFckusq0PSOVBPKP4RP2TY6FZTs8RBOyXC5NIuQngK4tEPPiYkcUBgzHw9egEkygESugNKnY0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mi7pTKX4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YxOYm8xh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mi7pTKX4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YxOYm8xh" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67C62PWq3288560 for ; Wed, 12 Aug 2026 08:19:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cK0UgLKdPpY KRWf/TrsMoJaQjrikK0H8qeWdKHTd7II=; b=mi7pTKX4FkliG7dGs/4mw6KAQEr 0GdULkTJ1kG2HRuU2URdLpHUmaYLZXbnSbfnQCEBAx67hxEhSAJN/ko1caBIu1Ng k7gNjj+532HgTOwXb4pZzTR6zXLA4dLobqqfDOPGJZ4RBOrzW3f/3SNTqc3YEJUL 3+PVOPO2Q0/o2tH5QDj/h3GlJAxuz8cT5M6nkJy70dfl7Bw4Qv2rASDPDdRCwqLq P9ckfP5HMSOwAE7Uulws7EBV4z8udLsGB7V4/jOMZcL2eKpv7RkbYOehjU6AvIA+ NbMR87zTogFXO4GPOyTuOaKXORNdVAV+B6CaHPVBN/liNzjJxfQwtLm5U4Q== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g049ev6ht-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 08:19:22 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51a8db414c7so10599221cf.0 for ; Wed, 12 Aug 2026 01:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786522762; x=1787127562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cK0UgLKdPpYKRWf/TrsMoJaQjrikK0H8qeWdKHTd7II=; b=YxOYm8xhTL2AwXw9qHKtHKoZ8nQ2NeUGHF+82quKB+W4qZaeeYvRkhDxUTHQw6Y3Qo MqUWQBlcIV6KJEDUMkp000PgOpULZM0P3dtC3TSXHzITZzFkypzkq8MPbSg8Qz/PGLup YQL3GSYzG9WdFQyyNhFefTT6i+PK+3L3aS8k/1F7QrOPO+WLWjGamLtWlN/UtVcTimXi ZiIAGkLOiqE678Oqf4HPmLbtj6t5xsgm9ShSiOcCqJVGz0D4aIKWJ7n19UEfx4nNs7v/ YEgmTllgz9Fw97EhiPQV+Ij/9ci1PizLf1La3fBEwxuOVE7KG7ahKZWTfxAYeLl0aa/E SzAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786522762; x=1787127562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cK0UgLKdPpYKRWf/TrsMoJaQjrikK0H8qeWdKHTd7II=; b=ZYfyN/n/kJ8onr4w9WXINwCx/4RYII3d0qAeI5PN0JtyAFU1twiOHSreVDekwaTV3p EJEg0Nuxq1QLw1xpVQaW2UIpjdDjvbjC/2dXBrqR2CkIS5skJMsZ0zcI0TmuseRUW9l6 QJE/kGxNHzniG3MhY07NfsALoG8vMeJ0XF99yb/hQekitJehRCiAa6M3g61fa1Sw7+Ds V0HkbtJYMKd0fFOBq/0vKJ55M+cLk49EJ3oet8KDpQLjFz2R6p+3qkVcnB/NR/jxlyAK 5BAvRYCXZ6WyqhoZmtkVitnh8b1+gQKvLl/bWYh62mBs1O0jsjfK1rQns9E4BgdymUVc uKbg== X-Forwarded-Encrypted: i=1; AHgh+RqQpceZAbP7G2/GTp8R4Vkyw3u9k0uADVoAL5HrvTAykjHNCTaiKTYYAtCN/q+W3vv7zu1p2YHgKMrWK2k=@vger.kernel.org X-Gm-Message-State: AOJu0YwKBDkueBo8C9gRvcXrL34uZdHBajjTwHWqQZdmDJs4cNSPZ0FG 0puYBQwPR5vzeelmKOqZjJSAPoUFEdsTZSnq/JyubX7XsakRAEes9gjJP3PPtwq1PWtm9cUdppj I9Donzy81nVns5qcdXY0jKSQoY1X83T8zP4bB9/wIhmcmUBc7p9m4IDOXELvchd9s6UM= X-Gm-Gg: AR+sD12jYcsqw57a210ow4n9ZAC8AEfm0W6eioxlvEinmgYe4jIJf3Xc7v1MLKgZBEN 05ULXci3ZutHG91gG+3v4b6VjAiLObYb/34QAsEX/sna1nba33oosXO2/FEeeLEOCp+obvQEV6C vWWoigbE3DCrw5EV8sCc74iGGPv6m0q81Kq0hewd2IOyOap1q9bzbw4KH1tKphHEZLPcHuSHOdG wbRgQ8XlbDfHWIV3O6Qj+DLyDA4kvMyu3kRtYvKy6O6yEHC80vEkBhOrr1XA0R6AmLz3efwTWgc 4AquK2IEXySaQW36YGtOq/cv1EfRg6WM9/Hzcbz3WoU5zljv4EjkM2DqQFpDI6cYXP3aNkRZk9u vy3qlD1x46LCH4c3Te9faXbmZ0qhJpc4= X-Received: by 2002:ac8:5915:0:b0:51c:1a17:eba4 with SMTP id d75a77b69052e-52d647ec290mr26629401cf.24.1786522761959; Wed, 12 Aug 2026 01:19:21 -0700 (PDT) X-Received: by 2002:ac8:5915:0:b0:51c:1a17:eba4 with SMTP id d75a77b69052e-52d647ec290mr26629201cf.24.1786522761600; Wed, 12 Aug 2026 01:19:21 -0700 (PDT) Received: from QCOM-WFsSr66Fqw.qualcomm.com ([212.136.9.4]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c20f059195asm63327366b.0.2026.08.12.01.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:19:20 -0700 (PDT) From: Igor Skalkin To: Greg Kroah-Hartman Cc: Alan Stern , Seungjin Bae , Kees Cook , Sebastian Andrzej Siewior , Sebastian Urban , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Skalkin Subject: [PATCH v2 1/2] usb: gadget: dummy_hcd: fix SuperSpeed ep0 maxpacket Date: Wed, 12 Aug 2026 10:19:09 +0200 Message-ID: <20260812081910.6821-2-igor.skalkin@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812081910.6821-1-igor.skalkin@oss.qualcomm.com> References: <20260807075438.5566-1-igor.skalkin@oss.qualcomm.com> <20260812081910.6821-1-igor.skalkin@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDA2NSBTYWx0ZWRfX+bx4P3ogMziC obCPrv0s8dyLFRFUG5WdL+tGNsxU/+tBt46Ehbg6UzG/qWPQjqzgGl0W+SeLkeqU9ZbelRB1f3M QKfC5KV8YGuw0zPs+cLyUNdsx1ho1vE= X-Authority-Analysis: v=2.4 cv=DoFmPm/+ c=1 sm=1 tr=0 ts=6a7c2c8a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=dNlqnMcrdpbb+gQrTujlOQ==:17 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=9LMInSQd5oSPQDHo0H8A:9 a=ZXulRonScM0A:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 9mtkWU7UcbcaQ1KbWFXbhjoWyr1RNHjP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDA2NSBTYWx0ZWRfX9M/+WVUTWv9F dMC5IC5EyD7UV7uGXQ1acdrz5i+xXn0oJpY+bGZwLhMc7PwMi1/Ie3hCpZH7Y67pexQHcwxnEcK NKijMvXloMSoVM9mSnw3YiTcLqjjBUQSCV+Zj9h7HyxQoymvuxEoTpe9q/XskIGL3A8ebJ5+pMv hotdWHqY5JejzwYwlG6Ll0NnW3YOWEXxXwpnZtRs9CMTrnBrZvoTpxO45OAgZcrLeTivphBW37x YdLlzc8IEfcEtr6ZgxUKxfZ6cAAFHTIwyS08j4HrQw9Do2cW8jKqamBnJBYAxSuCjKnwqg6GI7Y 5lRvxPGpS88PQj5P06N88SztgPAICrwCOh87t9FQfJSCNvQdjjKT/sGq9U1Pm3l7n7X4kIg2qdL vaZSj0TiJA5/SLoD5XeQlweHPQkiru8LQDLbexYJStwGOFDj9IXFabUvJp6jmKkTftpMKFsut4j EvpGfP5+J/sh0MUz4eg== X-Proofpoint-GUID: 9mtkWU7UcbcaQ1KbWFXbhjoWyr1RNHjP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_02,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120065 Content-Type: text/plain; charset="utf-8" For USB_SPEED_SUPER, dummy_hcd sets ep0 maxpacket to 9. That is incorrect for SuperSpeed ep0 and breaks short packet handling in control transfer tests. Set ep0 maxpacket to 512 for SuperSpeed. Fixes: 1cd8fd2887e1 ("usb: gadget: dummy_hcd: add SuperSpeed support") Acked-by: Alan Stern Signed-off-by: Igor Skalkin --- drivers/usb/gadget/udc/dummy_hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index f47903461ed5..29f671c7b319 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -896,7 +896,7 @@ static int dummy_set_selfpowered(struct usb_gadget *_ga= dget, int value) static void dummy_udc_update_ep0(struct dummy *dum) { if (dum->gadget.speed =3D=3D USB_SPEED_SUPER) - dum->ep[0].ep.maxpacket =3D 9; + dum->ep[0].ep.maxpacket =3D 512; else dum->ep[0].ep.maxpacket =3D 64; } --=20 2.49.0 From nobody Tue Sep 29 04:42:54 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46CB539AD51 for ; Wed, 12 Aug 2026 08:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786522766; cv=none; b=JDNpM2OIyAalAUDCNZXDMYYUmTOgz0RtRs3D+uRSe+YWKPTaP/jBc4wWJ6psGtb3nXIGSQruM8aUo02niqvcb4ifOcph8VI0rUe1gSzmmhclrmWrhPhLdk6gQtbyaNOroFfEK45MmqD8K+zjjDXYJriiVkuGfYA79UOq1ueYdyM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786522766; c=relaxed/simple; bh=O4tS74Qpamlgy50ymq4f2hv0mNK8g08TXH3vrTvTCcU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fnSbvXS1eJnVvHlxAqsa62zBPD2lsshrE+U4Z8POWMbNDWt9sv1GWeM1rZhJBL/wLb1B6qwNaJOCuUoQ4uf7TafsTkop4RjZEwjMJi1sfAqJSTenUekx1BUeDOo7UuERThQGLL09qaCMmVuV5uV71DNvxoq17CB3n2Nlh+aMYGk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jP2QrAhV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eMzR6H0K; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jP2QrAhV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eMzR6H0K" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67C62EKt2646961 for ; Wed, 12 Aug 2026 08:19:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=yCvY8dTpd0m VJHRvRNyakrvKHP85LZh5EA/bbkoXk+c=; b=jP2QrAhVd2X9t6b9PolWGLVwmyY jTSuLjkHzlYqsQzwCZztmmKZKdamqaKwFG956agY5BPIcAY5prVoSn6lVCtGC1Cz 3wx29co/ly71FbKzwBFOxfHV6Sjbjlrk9l/kB3Izb4H9vaAu4yxjat4lDKf0NXC3 /w/0TUty+OmSmB9dM3fwzl62Q2oaIADoGlbN4ksGomQHp3Kg96hHYbBa8JQAs3Ew QGO0lfAyh2oBt3zPYNTDF4AnlyBise3q3d6glrJH8zUcBNzxqBRDpfVIIXg3QoM2 7MIOcUBtQbDNorEFPZxcfUYdU4ZM9OQoxnG2QruZtD5fBcDz9t1rtEdv9rQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g049km9sp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 08:19:24 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51bff5c7035so13519111cf.2 for ; Wed, 12 Aug 2026 01:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786522763; x=1787127563; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yCvY8dTpd0mVJHRvRNyakrvKHP85LZh5EA/bbkoXk+c=; b=eMzR6H0K5cB7bBvhOlnSa7yY+KTtsxPKOZm6grfKLTwmMd698Qn9R6Fq84HyOoIMXT tS5WtWWgLhiHOwOw9Mg7LAJwCqggw9JEyGKUsId+Ryl0E0B5ehmUQ80hhXrexo6nneNP 7EiDcGdG3TFpUIzdfVGNCWHjWSMnpwt1ztiUxo1CJPSF8v1Oard5UsgI8TKLACe67qYv uEhPyIS7lawocxAD4xk1ZiTMrt1aXQN/gXPZnKo5pqgFpESQ4oeqJgbzBwpPOfX74UzI lQNyKRLvk1BIpmIQUOKqW4my9CD5bcgnh+7Xf8ALvs8gy8IRCYwd1CA1NdNhwTDXaVHe Ez0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786522763; x=1787127563; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yCvY8dTpd0mVJHRvRNyakrvKHP85LZh5EA/bbkoXk+c=; b=Oyrl0pqgQG3CLwqyfhenumO+uDIw6lA+vWqS6MVXVJ0CieYA83O4N+a3fCR6178bQd lgfwgh6ZJflKd7Y2RsSDivSvcgv4WFBlwNKvIi+bvs5KmLY6fPdQUgewJRLFl9mJ69tx GsJNFX1moc5qgUOS6Kf5LDdNCwifX3bCsWLHPQY9kLTQZbvf9ZKROKz2e9IDLIYXR3j+ J1tL8dk1AMcL/iE9v9qQz2RiTNR4Ct9aQT4KN/JH/CLA5HNEecJko/D6TkxI2V0AkhZV 10nevipoje9dky5m0E76C2PvLzFhBpvhcs19ESxKwfR3eWoWOu521dxxxUUhh4gT5zG2 1ATA== X-Forwarded-Encrypted: i=1; AHgh+RqtZOZwxLP8JLyn0517lNNBbPp5rRhUSpGDDizCRs1fakyGLX/x4LqUh6GLvjPxFgMTj4XG7mC15c28pU8=@vger.kernel.org X-Gm-Message-State: AOJu0YzQeiF/mQa/UHtk/Fndatsaf/Mfzw8D2aI+HkDBSBVqhG3Q4rio k2ZDxiAyGJrh+R2j7HfRGB9L9avKJoZk33PxqVQ6JScA2vv4SVRqYT6ZcMSPJNapeiKs3DMLDLs xCBc8iSfKt0CYlNeAdvrzs8zgG0ELQXZqIYNootMowplhay0iW7cPXjmiaZiDpCXHJfo= X-Gm-Gg: AR+sD13JP/79tQA1vy7VsBDFWfuBMkQylzjr9jPqP4CdcTFP1q9L/lL6PwIjCgrUKQm fGGdiq4yNYAZgqL7AFuZYaW2wKj54ygUt9OxTw4esUGYA3SZ5NwJhdmtpnZuhthNRi+TFLuremO 1zmeXdjET+LLwRjuaz7WjDr2OpnS+Rz/VI2NcE0NCfu6Z2eO3PvJjkzJsi0gE+mKlHTA7xMj0fz 3F0yO/BF3maIG8BCcl/F1iiNTsL3bUTR5cp2VhNuJ6sda3a2t/A5Za4FE9KSuiedIr/Qs4wBD9G uQmSfzzW7VoH+od8Fr8y/20ig4nk9obKiErkuazQ+2Lh9WsXBelycQlzcgl4qtl1SdfgJl1NorG QZQPheExBCLn3XuW6u83gihfuRc867x8= X-Received: by 2002:ac8:5845:0:b0:51c:1a11:75cf with SMTP id d75a77b69052e-52d646b8fd9mr24139351cf.7.1786522763502; Wed, 12 Aug 2026 01:19:23 -0700 (PDT) X-Received: by 2002:ac8:5845:0:b0:51c:1a11:75cf with SMTP id d75a77b69052e-52d646b8fd9mr24139041cf.7.1786522763124; Wed, 12 Aug 2026 01:19:23 -0700 (PDT) Received: from QCOM-WFsSr66Fqw.qualcomm.com ([212.136.9.4]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c20f059195asm63327366b.0.2026.08.12.01.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:19:22 -0700 (PDT) From: Igor Skalkin To: Greg Kroah-Hartman Cc: Alan Stern , Seungjin Bae , Kees Cook , Sebastian Andrzej Siewior , Sebastian Urban , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Skalkin Subject: [PATCH v2 2/2] usb: gadget: dummy_hcd: set no_sg_constraint only on the SuperSpeed bus Date: Wed, 12 Aug 2026 10:19:10 +0200 Message-ID: <20260812081910.6821-3-igor.skalkin@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812081910.6821-1-igor.skalkin@oss.qualcomm.com> References: <20260807075438.5566-1-igor.skalkin@oss.qualcomm.com> <20260812081910.6821-1-igor.skalkin@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: Nb3ledVKuCP1f_hWm7uMkMVVpkmq_sDH X-Authority-Analysis: v=2.4 cv=IO4yzAvG c=1 sm=1 tr=0 ts=6a7c2c8c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=dNlqnMcrdpbb+gQrTujlOQ==:17 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=ErlKB2RathMbn5d_X_QA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDA2NSBTYWx0ZWRfX551oX/uOrTVR FBiw6WvbGZQeVIXg7YBwOowUvCOPFCQDRxPCeg2GdC3TNOE07ILDmCkbBQhNAcAvlgd+u5csCqO RHuxn97UYND6peolgbxcpovTCCPPDZJIpWpeDxnwZRRRe4DoNkFh54WvStOYeyIj1WNIlGJ+B6H ip4wJNujZt01r8DNktnjF/1Zmn8ifCJ/pFMiIKzGpGrKYDsHVQTL/FQdZrtkOwZSOQkmQQWbvKT j4t6iY74vjufLo+hAWmcisTb9TpBnhWFz5OQCvS5uYDZ4H9FXyBz9XFRdXMNEg3i1NONxDq42IH +tgiLCpzj98LDh4Kirwj+u9gZs2pB2ybHDcRVDXortRcZTGLnhEoytokjWHCgYFf7n6VcNHazEp 61X4nUvb8yMHYvuAUVxc5PX7NGYxU07u5adcxk098KHc6O8WO2XaoMavAx8gI3PC8mtPt+Wu35Z AlMNniB911tGZ9LvWtg== X-Proofpoint-GUID: Nb3ledVKuCP1f_hWm7uMkMVVpkmq_sDH X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDA2NSBTYWx0ZWRfX9g2ZLWew/OBi c2qayEVILpkWf2yPB/QgzL2tSG/aSUnw034FVxfy+FlDFWm1zzAVJnE1yG5xsUZAUDv9UPHNe4+ NFUhIydTMI8ODqEOC1Jv1P4ctVGGfPk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_02,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120065 Content-Type: text/plain; charset="utf-8" dummy_hcd registers two separate root hubs/buses: a HighSpeed one emulating an EHCI-class controller, and a SuperSpeed one emulating an xHCI-class controller. usb_submit_urb() rejects SG URBs whose non-final segments are not a multiple of the endpoint maxpacket size, unless the bus has no_sg_constraint set. For SuperSpeed bulk endpoints maxpacket is 1024 bytes; usbtest generates SG lists with varying segment sizes (e.g. 512 bytes) that are valid transfers but not maxpacket-aligned, causing usb_submit_urb to return -EINVAL before the URB reaches the host controller. xHCI-class controllers have no such DMA alignment requirement, so set no_sg_constraint on the SS bus to match. Leave the HS bus unchanged: EHCI-class controllers do have this requirement in hardware, and dummy_hcd's HS roothub is meant to emulate that behaviour, so the constraint should stay enforced there. Suggested-by: Alan Stern Assisted-by: OpenCode:claude-sonnet-5 Signed-off-by: Igor Skalkin Acked-by: Alan Stern --- drivers/usb/gadget/udc/dummy_hcd.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index 29f671c7b319..0ae600159478 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -2578,6 +2578,15 @@ static int dummy_setup(struct usb_hcd *hcd) dum->ss_hcd->dum =3D dum; hcd->speed =3D HCD_USB3; hcd->self.root_hub->speed =3D USB_SPEED_SUPER; + + /* + * xHCI-class SuperSpeed controllers have no maxpacket + * alignment requirement for non-final SG segments. Only + * relax the constraint on the SS bus; the HS bus keeps + * emulating the alignment requirement of EHCI-class + * controllers. + */ + hcd->self.no_sg_constraint =3D 1; } return 0; } --=20 2.49.0