From nobody Tue Sep 29 04:42:53 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69E17330B0E for ; Wed, 12 Aug 2026 08:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786522637; cv=none; b=rF3kAqEGzNIQigzVHxDkcHrN7A3YyGU3fZdausWq1uWe2GowM0iqtPA3YCOKDDV06XpX10zd21onwVKuqGg9NwhEichNDKM67DdVkqQC3DQrsMWlN8yARllDcftwNxP79dKUWSZZxdywreQoXrxBVJDgkc4j0rfxQuDjUnKLwW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786522637; c=relaxed/simple; bh=Y0uZGCzRn1YmiowHTnD0wM6/o+ZrqweK6Nz/sIWUVVQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lxjIHobphpgKJ2jeOWMS1DNIs5Me2ufpA0N73jNJsQU0CPAdM8JZHGmLv5WJ6rbz9O4mcxfidQwF1xKV6ECSw7nPmBskFz9goSQ2uefun7ld6LcrALemzWpcu/v5vfgs3e92E0A6LYx1s2/nM5dFt4d/5uLnqVEMltnij/DYntM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j2x+M9gA; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j2x+M9gA" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-6a1f80fd2e4so1214630a12.1 for ; Wed, 12 Aug 2026 01:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786522635; x=1787127435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=WpdgLehVURcj1cYaXkv5Z1ZvsLVBkUIn6mZBt+a5n+8=; b=j2x+M9gA1yQsRQYGBOjx2HXmN/nw1A4TEqKtRQshBU20mj+fX/3qJjx7qkDFwdAKiv vnM+/WOAMxZJ3630RRSzWfFiKMECDzv/fjxo3BTEwJRooQDwgiZj2m5kVLuNqtj3nv5E zsicN1CDiwxwezdfBJ4tuuK4g7QPjq60mgvG6qNdws9uEdRkZ4ThHJ+1TG0cB9OA98hh 47kVOkASfiCErsRUyIevBNwCmPD5kUR3ZhktUjz4lkaDLc6zEFkdlqhUEqC+vj0s8MzX xJhinEucWGjTntJT9demgWPMH329R0aYJMlbl0JP3b1iKbp8PkIh5PpHfdBBeDnjHfr2 mo3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786522635; x=1787127435; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WpdgLehVURcj1cYaXkv5Z1ZvsLVBkUIn6mZBt+a5n+8=; b=q4ZFjqGU/HFlYPTxPsB4LAcyOXK9WhfL44hePLXHS+D0vF4p+Cfw2XWqpZSFxDQjmb nio6GUJUBb1AcaH8hyrR5b+YtBmNi6C2n5u8JtbmTJGQuka3wUVsySVdivUBRCFD5FIH k5qulIwU98EG5Cm23AszJGfjVpG02BBrl27ldUCeLqzSi89VV19vdEe7C4DUqCpwic0p rcZKettK9+BOPd0sAisWfXtAw9UETCLLv2RjGeaC8RyJRIgA3Wl34vhs3N2TJr9dQUSy ayQaALYDu6O90Kdi9I31QUct20kSLx0PBwwVkHvHSuKEX1msrlq0wkPL0IEN7k+p9s69 xRYA== X-Forwarded-Encrypted: i=1; AHgh+Roxs9iRiEkTCzKFSxCy4Dnj6Whwc9FJSdqO9E0ugpkrWxorvpQTPubYtEMlhF/hHglEpJfLv9CiWSjjOiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2CVsw6cYz+M+M196yjqFAG8LIeBDulbzEdoxAe31FulIptJ49 c1mVh1SGGTp0pmgvxRL68KLuCfUDOYbHcjvSRJmSXdB+zfv/EaWA4eEEK/lMYblCpps= X-Gm-Gg: AR+sD13RyqS5F54aDUolbpLNIzXjDnJF5XcyIaRQCWz13wiYcTV1rpKffH07My7eRk7 A6g7Ja1XCwelleEt7TrqwPTXPTjgtkx5t3zxWM9IhzSgibDJWY4SSAZ0483vps+Dnw2pHsuysG8 /6Xm71EtQCWSSHxnM1HiXMS2vhEN9vdiVMkOlpN4othgeCeh7DKQYqqXJxo5k0GQrkbMHigQMWw JoyIQCuog+nqdgMMOXFPuXol1HKCZEKkpeEBT5fTf3X+UMEW1Xm5BvlByj0xUIDlVekez7WRIX2 iz0CcIw3RGi+ZlhOBdv2qBBV/Xyahnun4jop1NwkXNZKp0Ekp3tbc3meMiy1WE5bwcuqW9H9VON seD1dwunGPfhQiZCOVm+e+h8VeiX9oSGszv8Au+8WvPAtAv4oCCMIaM4J/WceJUo8quqUH1vkyP GU1El1NkkoEDuz1InaFo6+6yFkq6xYO+Kz7H4hK/0uPVEk0IfbPf2MgumrwjyD+PqaVLXhB9ezE H0ivUMS8EfxBBLeaeiTZp1tODtuUXhGytkOCewg60XrybjdShakaK6sqtpmwoIMVEKb4fRfykUt nU586rZUnQDUDlv1ProFbS4MV+OkfCPUO64zZA== X-Received: by 2002:a05:6402:2789:b0:6a0:de1e:c4c4 with SMTP id 4fb4d7f45d1cf-6a375ec0f50mr1270353a12.10.1786522634330; Wed, 12 Aug 2026 01:17:14 -0700 (PDT) Received: from Ubuntu.ts.net (87-205-15-91.static.ip.netia.com.pl. [87.205.15.91]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3769d97b7sm365276a12.20.2026.08.12.01.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:17:13 -0700 (PDT) From: Krystian Kaniewski To: Jason Gunthorpe , Leon Romanovsky , linux-rdma@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Or Har-Toov , Paolo Abeni , Selvin Xavier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot+5fe14f2ff4ccbace9a26@syzkaller.appspotmail.com Subject: [PATCH v4] RDMA/core: Reject unregistering netdevs in ib_get_eth_speed Date: Wed, 12 Aug 2026 10:16:41 +0200 Message-ID: <20260812081708.32468-1-krystianmkaniewski@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ib_device_get_netdev() intentionally returns a referenced net_device even when it is unregistering, so matching and cleanup callers can still find the association. The reference keeps struct net_device allocated, but does not guarantee that the device remains operational. ib_get_eth_speed() uses the returned device operationally by invoking its ethtool callback. Although that call is made under RTNL, the function does not verify the registration state first. An asynchronous RDMA port query can therefore call into a netdev after NETDEV_UNREGISTER and ndo_uninit have completed. Check for NETREG_REGISTERED while holding RTNL and return -ENODEV for a device which is being unregistered. Keeping RTNL across the check and the ethtool operation prevents unregister from starting between them. Keep the speed fallback and warning under RTNL as well, so the warning can safely read netdev->name. Drop the netdev reference before releasing RTNL once all accesses to the device are complete. Fixes: d41861942fc5 ("IB/core: Add generic function to extract IB speed fro= m netdev") Reported-by: syzbot+5fe14f2ff4ccbace9a26@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D5fe14f2ff4ccbace9a26 Signed-off-by: Krystian Kaniewski --- v4: - Keep the speed fallback and warning under RTNL and use netdev->name directly, as suggested by Jason Gunthorpe. - Release the netdev reference before rtnl_unlock() on both paths. - Drop the [PATCH net] subject prefix because the patch targets RDMA. - Rebase onto the RDMA for-next branch. v3: https://lore.kernel.org/all/20260810133124.44513-1-krystianmkaniewski@g= mail.com/ v2: https://lore.kernel.org/all/20260803121140.261329-1-krystianmkaniewski@= gmail.com/ drivers/infiniband/core/verbs.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verb= s.c index 367822efff36..b31d61513335 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -2058,11 +2058,13 @@ int ib_get_eth_speed(struct ib_device *dev, u32 por= t_num, u16 *speed, u8 *width) return -ENODEV; =20 rtnl_lock(); - rc =3D __ethtool_get_link_ksettings(netdev, &lksettings); - rtnl_unlock(); - - dev_put(netdev); + if (READ_ONCE(netdev->reg_state) !=3D NETREG_REGISTERED) { + dev_put(netdev); + rtnl_unlock(); + return -ENODEV; + } =20 + rc =3D __ethtool_get_link_ksettings(netdev, &lksettings); if (!rc && lksettings.base.speed !=3D (u32)SPEED_UNKNOWN) { netdev_speed =3D lksettings.base.speed; } else { @@ -2071,6 +2073,8 @@ int ib_get_eth_speed(struct ib_device *dev, u32 port_= num, u16 *speed, u8 *width) pr_warn("%s speed is unknown, defaulting to %u\n", netdev->name, netdev_speed); } + dev_put(netdev); + rtnl_unlock(); =20 ib_get_width_and_speed(netdev_speed, lksettings.lanes, speed, width); --=20 2.53.0