From nobody Tue Sep 29 05:34:18 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 072C8336886 for ; Wed, 12 Aug 2026 06:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786514864; cv=none; b=b8FkalrxJM8go75NodQx65Ee4IlBrQB3QZdRTFRUm5nvA9Kqrje5reiyXX3IzamcWnqJx0l+6jbWaZa87DkidvGXoX4r9BKomTVWhHwjEPjHLyR+cSUzupNN33X6Gw3tJI+o7XbiQXQOHfL9i3wy/OMhFgEEtuWVDR8gYAlOBv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786514864; c=relaxed/simple; bh=VXPqmmbzfn+RvfwbL6ygzQo0kyt9LdFzU8OQGMNFM5k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=r1trdAgJJpXWDqdQE5aT/WfNk2VTW0p4vK+WgjM6U4GwQWjz4X51LvWY+ywQqpI5VeTM2yLsC0dLC43xHqUKt4O2MZ0qw8P/GbbdGcmT26nGPWexWQhZieC0mU0ppj4eWdkGM2jvH8KDPzN6DiSJu8++qKwurVy2YP3zR1zNu/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p+VmkA1L; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p+VmkA1L" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47f633e6058so452190f8f.0 for ; Tue, 11 Aug 2026 23:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786514857; x=1787119657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7Cd+LEEyd3TXyxLex7677AjSY0WWkR48elXEAfm8gqg=; b=p+VmkA1LzLYsFf3pj0t3lWJjTkgaosYQE9wccXmkqVQF1LcYKMKs+2BP7W9jbN7co2 SQDToOT7uaZjDgX/cU6f1zOzCV+oS36dnJzwNmdf2AbONdUDz1kDPI5SBwmLS1OmKFrG mAmQKt+iFdhVbA330YwDDnVKj4Eow5aondfctIJUGJv2xT0TI0vDi/Qd+oq+NA/XdjPp SZ0aT+PVoqkRsAgOuZ3Snzt5KiPce3zqbPTAp3DGVhevXhd87zIE9i5zPN5odAsbAFnL TKYabIZoTmDc5CfxcmksjSlvUGbxapVzGsa/gTJXQ6z563m5+HPmXvYQ176oej6NuYO7 TzBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786514857; x=1787119657; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7Cd+LEEyd3TXyxLex7677AjSY0WWkR48elXEAfm8gqg=; b=X02rLw42EqWXbmbLku9XpNYAUQnVx4ewqQ8RyLJftf7+rBs2XRPinkC46hJ3bpZUHG cbEoghR/epowTpIkgHVa7K5S/SFXBK6tWzAUNoMeDv+tW2FNka6pRhiPEslXWIvFC560 xB2mf9SygkcvKB5NGRqL2+6hrxTlPnsMDY3j9VGJ+UH6+TCC/37THAxrfZdroOGWWT0U NO1p+asjfUDkBOqu2hFZkE0NjDN54dlPX8OsDFTvqjIIn1vhLuKtYhVpPw5L8fqvH/Qf geMdrdVoLqeMdWb5A6MlbR+Wfyf2B4pFtgxgJ7JOv3sM5XeCbGJp9euwaD2wQE/nSgsd yewQ== X-Forwarded-Encrypted: i=1; AHgh+RoSW6u0dPZ/rDEpbRhCZdJI/vHLV86hBZ+d2mt+CfsvruP3OaMzunwVHFZALrCEOVhOIOoiowN7n7f+kaA=@vger.kernel.org X-Gm-Message-State: AOJu0YzmaS30h6+fDRNPQkRgk+APDmeGGUVKRSs0BqItnv9Yu3ce7j2g dN/4Yq+5XsqZ5R/w7MHnrUZ/Rhi+64qRuajE6iISgfnoEyIL7fYMubSq X-Gm-Gg: AR+sD10avFKf7i1hK00Hg3hr70qp9UX6Spsseq5SiXC3uoffshtb1Gy5SgtCiMnOPMY 8O4ZzglcsDaJ7QHhw7iXjMNqbAerC0Nt+QMjv71Z4h37ADryxYEp4QTTk4rUn5Vin10Mez8Am4m k+MZIN9Cqs5NDXfaVqtD1T5+dJLrOvgL0xEgn72+f0lgKkUIhe4V2GNHFzn6aztgwXOL7OVLXMK DTPNCMrA/kDVyaz3lPGuZXoGnHuz2v9oth7pyT/mElKnJ05/r57PQx1IEaI2chtzwhKfR6aw4b6 bKveG7AOnSy+l53DfkKdDm/uqoFOvIpRqNEg/7LWW/E2tFDrYbccy+6PtNRMgKcoIw7QdlTq2Ou vr9ambgsucF830f+h5DGom2KGf8WwMM4MN6mJv1Ec16dFA0TzF9UXL15rZn8I9wJo/Tjeq8Y6Mx m8NwYPIUamnsmYOzpxhbTZQk47SVJpW2X3QSg1r0o0Yx8tT6LF0con1kLYG1t85MmRmbF18k/VY KNO3CcCk8wBEu/rTbThc7WfzvrHSeWiayWAM/6G4OlPGsAeeTlClSuK0SjjBmptlNFR38zn5MkH SJUds92Pzvbo4Cer3DFUpadMTIqAAJYHDSvsMw== X-Received: by 2002:a05:6000:41dd:b0:47f:c62e:9cca with SMTP id ffacd0b85a97d-4815290583emr3188068f8f.22.1786514856838; Tue, 11 Aug 2026 23:07:36 -0700 (PDT) Received: from MBP-von-Karl.localdomain (dynamic-095-117-170-147.95.117.pool.telefonica.de. [95.117.170.147]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d4c10asm4168555f8f.20.2026.08.11.23.07.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 11 Aug 2026 23:07:36 -0700 (PDT) From: Karl Mehltretter To: Sunil Goutham , Ratheesh Kannoth , Geetha sowjanya , Subbaraya Sundeep Cc: Karl Mehltretter , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] octeontx2-af: initialize lmac_bmap in rvu_mcs_set_lmac_bmap() Date: Wed, 12 Aug 2026 08:07:30 +0200 Message-Id: <20260812060730.6181-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rvu_mcs_set_lmac_bmap() declares lmac_bmap without initializing it and only sets bits for valid lmacs with set_bit(), which ORs into the word without clearing it first. Bits for invalid or skipped ports keep whatever was on the stack, and the garbage is stored into mcs->hw->lmac_bmap. Initialize lmac_bmap to 0 so only valid lmacs are marked. Found with Clang's -Wconditional-uninitialized. Fixes: ca7f49ff8846 ("octeontx2-af: cn10k: Introduce driver for macsec bloc= k.") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter Reviewed-by: Ratheesh Kannoth Reviewed-by: Simon Horman --- drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c b/drive= rs/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c index d98b49f47970b..fce22e314cac0 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c @@ -856,7 +856,7 @@ int rvu_mbox_handler_mcs_ctrl_pkt_rule_write(struct rvu= *rvu, static void rvu_mcs_set_lmac_bmap(struct rvu *rvu) { struct mcs *mcs =3D mcs_get_pdata(0); - unsigned long lmac_bmap; + unsigned long lmac_bmap =3D 0; int cgx, lmac, port; =20 for (port =3D 0; port < mcs->hw->lmac_cnt; port++) { --=20 2.53.0