From nobody Tue Sep 29 04:10:46 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DFAB46EF73 for ; Wed, 12 Aug 2026 14:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786546320; cv=none; b=jCs4YW/psaJe136t7l1x8KL9G/tSkJ98XVj0bluP+TEkEJ38h0pdiWPV7HY+VcAHRIt1X71KcfCC/96skV1joIoB9/LOrMC0hgpyIItns1ujrgftmW83965GRqymYg/jSX74WV4+cGVDELBAgEgfn+iFQZj2kVHJ80UCwH+cDHs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786546320; c=relaxed/simple; bh=Y11hNluv2icyTm8lnL/Bn2Xr3Nk5hYxyS/uz2OwDTlE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=sw0mBsrcQ9DJ6m8P2mxFnKt2L3zq80oJFQLpmH0+033WI1DadSdwfwZBMC4YohOXIQxWItCqoS0yPvT1FzPUn3ITA73r5/i6EFVSXsa1dvtGmHRVQIoSaEhUZGx+VKg2N6smj7hHeMhoiRZbNRDCNXoMsmiQ7VWpukZnv/AmkcE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bIpNDwDa; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bIpNDwDa" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-498012a61f6so59505e9.0 for ; Wed, 12 Aug 2026 07:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786546313; x=1787151113; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XFEQDpKGBGfe2eFcLfrei3wf2IxikY9MSg+V8LKW8dU=; b=bIpNDwDaNoDqkoC3l8CEzoYUDyT3Q0MvK3PidvJvVtkbnSvlh1vf4QQaKNYrQpJvvQ rL5bw+ymA9ZUwWOyDUcyuMjvtqjwc+sCkuhZAIlLVH9wHS+bJT3j7GMzdZmUeGhNzerZ VxjKcsm6mOy/EksYQUK61FsZFyh0sdCo1I4IEce/Ncaw479U6l1TGrpzK9QOInzjUj/L /4n47azrAuS6vCopKJ9K/5DqRuQWVr6lhaASh64QB/V98CN8Tts1kVRKl27niuuRB+cP IpbjGeI4YcmASQRCkaMwDaA/1zfu323zYP35tfgaTdtBerL2ADV5RkfQDeh4vCS+A/hr rBbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786546313; x=1787151113; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=XFEQDpKGBGfe2eFcLfrei3wf2IxikY9MSg+V8LKW8dU=; b=GIJjlF4mclXsARYxLHBk94KAAMC5/v9wY+RvqgEaNZfi9yDjOO5L12u08SCNQPIHEC 5KbhxTkAbHKbQbbpUi9BKR5dDLoXISMY/CB+EsdjVuKirvzt0OoQ6KOa6LyncJv0488c Xm7EhkwdFrmKDjxwpp37t9UxmQwjBiQ+rC3AslgK1W0OoRnCpsbQsfnRFVk+H/E9sRQC ttViRFF8f5gAMfRjJG+X8gSpX1aRlQslVeCcEM2iaLDZDxK5lpuSBucueSIB8qwwy1t3 B161VeZk6OqNLmYl9HYilTCSe1LloEu/fadUwG3TJwa6Xb2ufn4LDKmk0A6KcRkhxmEr 26/A== X-Forwarded-Encrypted: i=1; AHgh+RqlB4jf/x+Srm9DWnnzIPbbOrJxpZSPya2O37QNWPTZ4BbsGeTUhYnt+Pg5yE6ZFiFcZDeSkY1AcO0IOM0=@vger.kernel.org X-Gm-Message-State: AOJu0YyU9cJ7rWWXCPBFpShbxd6B0GCV3mtJWnPr/TtrZGLq5e3OdYgH 7Ax61E3BZRjcprDEvBjT5OG31+vAZzU7D6cZjRryrZtLt10MFpANKbQvXZOeuH9ptg== X-Gm-Gg: AR+sD129s6r6Gig5Z42AoDZK4WegAf/ax0d+Mcm2JJ22Z+rQ1krspsTzTZtJ3l6q8Kt kjtpvoDr/+qF27oLneun7FS6kYx+wRUwOGxwYq8g2YToxXh7shRRbA1A70k2a3njl5Gt0eTHhxq Wxj5KTYwNL0xCN43ebDdTDmL70LhEU6FYD86jO7ZB9+LB7D1Xs7/Db2drVaYEs3n+Xt6Tp09gIj QvmPTFIUxevYhxeB0FA7kLh1Xg3j+thz5SbLzKSFcJmys+LiUWpsvT3FSBGeZcOZBN9RgSPpk4i BBjcKjGWTEvvDsudf/x5eCtm2k5NVs4+poWMecWC84k/0TlFUU0E77TqLUO52vOrtvDLHBFagV+ H22VEaY+XUono6pj0LFyOsPsInjvLKpE6SeQN7EYLBlbXOkm0GMftjbIDLSbE6jzSV+tmpyeq7f wBoIm4JvN1QfSoorG/37q50FaGtS1tdHWUzPTuIZOwszrOWDFN3iSPCWkRu/Mp1Z4uvcMJX/50b CDGy0BArEaFRxdc5W7hoWyjQ0zJ1zFrKZYOFw0HqVlehhZ3mwyMmfuC4mzb X-Received: by 2002:a05:600c:a210:b0:495:51b1:3b7c with SMTP id 5b1f17b1804b1-4997ae8fa87mr1131525e9.8.1786546312851; Wed, 12 Aug 2026 07:51:52 -0700 (PDT) Received: from localhost ([2a00:79e0:288a:8:d358:790c:76c6:1a58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d4e3f5sm7852708f8f.22.2026.08.12.07.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 07:51:51 -0700 (PDT) From: Jann Horn Date: Wed, 12 Aug 2026 16:51:46 +0200 Subject: [PATCH] cred: remove RCU initializer for init_task.cred Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260812-task-cred-fixup-v1-1-318440888adc@google.com> X-B4-Tracking: v=1; b=H4sIAIGIfGoC/yXMSwqDQBCE4atIr9OgI4rkKsHFPEptA0amnRAQ7 +5olh9F/TspokDpWewU8RWVz5JRPQryk11GsIRsMqVpy64yvFl9s48IPMgvrWzQ+CY4tLZ2lF9 rRB7u4qv/W5Ob4bcrQ8dxAnvxW6VzAAAA X-Change-ID: 20260812-task-cred-fixup-2e5c5dbe6a3b To: Paul Moore Cc: "Serge E. Hallyn" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Jann Horn X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786546307; l=1236; i=jannh@google.com; s=20240730; h=from:subject:message-id; bh=Y11hNluv2icyTm8lnL/Bn2Xr3Nk5hYxyS/uz2OwDTlE=; b=iin2C2yYQ5icjSiLi/dBPRCgsywT3zE78fmJNMR5iknlWOt7ts2xtWfrUVm/Moc11GnsHrCwd pm7bN3axQGsD7sevRgPL73yTDOYXXsnc4uOXvaXDEo4Br5f2oHErHs6 X-Developer-Key: i=jannh@google.com; a=ed25519; pk=AljNtGOzXeF6khBXDJVVvwSEkVDGnnZZYqfWhP1V+C8= sparse noticed that an RCU initializer was left behind for init_task.cred, which is no longer marked __rcu. Fix it up. Fixes: a4229a2a16a8 ("cred: clarify that task_struct::cred is only for the = current task") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202608121153.nzs6HZg7-lkp@int= el.com/ Signed-off-by: Jann Horn --- maybe squash this into the original commit, if that is a thing you do on the dev-staging branch? --- init/init_task.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/init_task.c b/init/init_task.c index b67ef6040a65..6529b002135b 100644 --- a/init/init_task.c +++ b/init/init_task.c @@ -159,7 +159,7 @@ struct task_struct init_task __aligned(L1_CACHE_BYTES) = =3D { .sibling =3D LIST_HEAD_INIT(init_task.sibling), .group_leader =3D &init_task, RCU_POINTER_INITIALIZER(real_cred, &init_cred), - RCU_POINTER_INITIALIZER(cred, &init_cred), + .cred =3D &init_cred, .comm =3D INIT_TASK_COMM, .thread =3D INIT_THREAD, .fs =3D &init_fs, --- base-commit: 1f2f7a1fd1fc34e757107e3a3849f8d22b14cc6b change-id: 20260812-task-cred-fixup-2e5c5dbe6a3b Best regards, -- =20 Jann Horn