From nobody Tue Sep 29 05:35:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ED143ACA46 for ; Wed, 12 Aug 2026 07:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786520946; cv=none; b=NfJ3+f0ZNdeA30NzVQlBvJ++z92yvJtKHio2cPFVbyQsLv1m+BqzJHpbYK3oCUx+iyomXe1i5Doq/S2c9MisaC82QDsbmcH4FZh1WMUfzbQYR7DDxAZ3sxUiF0K82KUG2AslpTBVLuzFKPcBCapxnBuSjPupNxAMMGHYdXqFt9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786520946; c=relaxed/simple; bh=T4VuJfMx9MxRf7rLbt01upUu+iKdhsLLEDcpS9X1wrY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=L43Z7IJfeDwax3Ayak8HAFVLn2DZtwUo0atCZBEPgmtMyoNrMDekSLLfv004MNHF6dzc7joJcZo6J7eS+l4wxSCGP1ZAWqekaYu8gK5VU7pcsNp7b3/u2aST7Wr0mjAuVvcaMIJb2zhERBtaq2COWmnINIMLSmE+2qowqN17Xt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B+iIWQwO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iWpGvQbc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B+iIWQwO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iWpGvQbc" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67C626un2593484 for ; Wed, 12 Aug 2026 07:49:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=tLSra2wpYTEdApChSyIfbP 2TyrOLtjRXXKtLYInygb8=; b=B+iIWQwOCl3gqnVrqIpnByCuAfFV5jKOkLBGV4 ckWVmnEN9ab5jfg9x1XJoX60OS5DnfUs7Un9xS82uWXz/qh/PEIIPovdimzKuArS G9dqX5r7OEJsudWw2K1U6yMIX2gVJrBbdpKAFYyllINGupb2/Qy8hmERRptE8Qx8 X8MT7sucs+aM1BDBYQNdB0S6eGyvPeIu9crrPneVN25ClvRQLRzCaYtU/WAFOOC5 tiEzb1rMqi5zvtMTBRg7BRpJ5KTl7JpkqZYDrbefN0cGTPtq/dPKzpva9dQ6q4yr tJvWvgte0SWKaSfTduwMah+aZaxvULXSW6SW141a5CZX/mXA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g08jrjrk9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 07:48:59 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ccb6823efcso7301345ad.0 for ; Wed, 12 Aug 2026 00:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786520939; x=1787125739; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tLSra2wpYTEdApChSyIfbP2TyrOLtjRXXKtLYInygb8=; b=iWpGvQbcng7axdiFCWr3IezgbqCUBuAVe1xKy0adEjr4M1QEVgwVystnxOSXUnvHxB GlX5SZn89C91u/0PK9dfeZW8DpZeFjMcKxEL003Fd3wK7ZrOLDViCNfTKZ6hOTniGElT Xev0+jp/0eyoOSVL8etS43vnr5wl9fGbC5H5Egrou1Jy18sYg4iAlnVQHLoLoYm4t+Sv GYArd6ARJaYp6q4H3LSLdblb3Mr2SyTI9hzvnUhy41Rn6UurcZ6x5aMRSzJKMeiCFhHx 41HtlFOAqf0a3cFtBwMmz/YLC56I7IensPdbXUAMTae3O64ZvRFL7y76q5+elfCffJWR 1Vjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786520939; x=1787125739; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=tLSra2wpYTEdApChSyIfbP2TyrOLtjRXXKtLYInygb8=; b=HS8DwIkF4BRZ9myJWpJ/93PBUHYm3xClDVhokWl6uLjZVc7ScvbjfVsWp2IXV4bsUy NAEPNqNRwHDlPgOBwprMvDQt2GLrJVZa03rOWIqr8yx4CAwWsdoexKscIZgleSMecvLS vinseMYyCme/L5Q1Sl+Pw9N5nRwgIKTALcB9syX+iv/EeyteDhMJq5/YAyMzas8PTQMy 8U/RfFSCeMSj09icaFDqAjtfH4facUXqggn6U8xbZpycnh7aGI/j4q3XKc53KTKsNl/4 GQOfSTJnfykghT7gSbZ/u+ZCX6CYOmvBJfrXCej/8lGPG6YasTGbKvr97eJswGJoIGgm PZrQ== X-Forwarded-Encrypted: i=1; AHgh+RrhDFf6W3hSq2N6t8ZG3HPjVg+DDRIXnf5V34192fd9vq/5zyxNn3avCRVYkH0aFkmQDCHNvTzDQqae/II=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5LLplE1hfLwtVd4FRwyP4dJX9aEYQC1kIeHMJr6RXxbw1FNTN SX7x4Z773mO1I1cTONuDUru53K0crNLei+CnQFDcgEPJxvjtENKtKl+KVT60BDc1k02zpmaWvu5 XUsuF0pye1AZUIyy2gGLarHUgM9lyRJPhjXdCNfFNamzyKfaQpqxAhxgeHijmPhv6HMk= X-Gm-Gg: AR+sD10f8E3FJ9322P9rwK/oXtFkcNEZwxR39YxgoxbgrdpD6fLrlCYfqAQDeDTCEU0 Y5nhl8pXZVyN7MWPGvdl7uiGe4mHYJU+5jOiHd94+zY8eC9/v0OK6b2Q+4AuMo8eRXIK9wwPcxq uic5Qoo6WQlEFocJWpBq61vrAg8OxmUmbX9VvtviTk2zdA4UjpwY5hnbj1Hhzxro4zSccMbc9D0 kRKGwbMeUkbbopTa7MxfMAjqop7SkE6ax28YlLo8TAW3ubzZZ666XMtfUQnBlmDlJT8shF3BCeN 16jps0hrg2fY/83Gbkirg6JdwRVO5EyCz32LRemdy6y3TmeZ+HT+vSAZaQ5wjN2kLi2tB/bMCD0 +pKvlDRzNBGwccGMRlVgKbyyoGfs31f+9U/6UdEL5O5K23Qwe2P24vxjB X-Received: by 2002:a17:90b:254a:b0:38d:eaec:4396 with SMTP id 98e67ed59e1d1-393013f86edmr3419182a91.11.1786520939111; Wed, 12 Aug 2026 00:48:59 -0700 (PDT) X-Received: by 2002:a17:90b:254a:b0:38d:eaec:4396 with SMTP id 98e67ed59e1d1-393013f86edmr3419136a91.11.1786520938561; Wed, 12 Aug 2026 00:48:58 -0700 (PDT) Received: from hu-tingguoc-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141243819eesm7057741c88.0.2026.08.12.00.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 00:48:58 -0700 (PDT) From: Tingguo Cheng Date: Wed, 12 Aug 2026 00:44:47 -0700 Subject: [PATCH] power: supply: qcom_battmgr: fix battery chemistry strncmp length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260812-fix-qcom-batt-chemistry-strn-v1-1-458545e02641@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAG4kfGoC/y2NQQqDMBBFryKz7oBRK8WrFBdJOq1TSKzJWCzi3 Tutbj48eLy/QqbElKErVkj05sxjVDCnAvxg44OQb8pQlVVbXkyFd15w8mNAZ0XQDxQ4S/qgTsS 2qRvf1oa8O4MmXonU/+ev/c55dk/y8mseRqJp1l/ZNXA2E+pBYOmKSIvg8W2g37YvAHwxirEAA AA= X-Change-ID: 20260812-fix-qcom-batt-chemistry-strn-6434c631ecb5 To: Sebastian Reichel Cc: Rakesh Kota , Fenglin Wu , Kamal Wadhwa , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Tingguo Cheng , Tingguo Cheng X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=ed25519-sha256; t=1786520937; l=1600; i=tingguo.cheng@oss.qualcomm.com; s=20260316; h=from:subject:message-id; bh=eDN+VD7WGKURC4qtRBVyk3xkee3IcFWDykNx6qhUbzg=; b=TmAuTe8pIsGoVETXya8flEHdBPufgI5iw8qBiZk8MeIRcUJCJfn772tDLbpo/9XHNcBQIwiyU HnSKkKqWGoyC1dEAskOhFiTcV/+OyB+yXLJpB8vbt9aNyWaS/tZtaTs X-Developer-Key: i=tingguo.cheng@oss.qualcomm.com; a=ed25519; pk=T3R0T4olG2WHVswcdTJHHRrxxxuOHDk1nafJK500cms= X-Proofpoint-GUID: 8C2x9vi5rdzbqiFaYK9Do0RwWNE-HxPa X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDA2MSBTYWx0ZWRfXzn3x9doyPcxy XOsGLDFIO6hrwbWBpiXHYi9Fx15TrIf7beK7k0b3u0KWZNX8Na8/e8t2MyAa1s6y/LQ6ucFxFAB AkZW9UX6O+b8E7CptchYj5UnDa+ftxA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDA2MSBTYWx0ZWRfX4bw4Lri9yeRX pV0QGSyOkGI3N3t9+IOThJgi43qYjNYxUfqTgQv7hcOhZXSp+tqiAHfZLJUdxC5DmsHptkvkDcZ C504fPsmVwhDJDMGRH/0+hAs/4uy+nb/ewYhWN6fAETmJrdrVopALNIWj9X8yDwna/GxXsQwr9C BD7bjGwg3BVY8fvyPMa4Iu9449+jDkD2BpN18JrRv0fu5BSsS3vSonhzrwFjg5lNJQDE+XNFuC7 RYfmtDlpSxvfHIYXD87svC88mKR+uY8ZToxWBm6As9HuGADDM08LJvu+Fc6ZEFHszANxsX7rG9B BQQZIN2Gt37YORQTQijsRMHRV8d67LkZvCHWlZHDPiiEW4WiOAlRnpCyj0epu1+4e9XF7JEuVZ5 Wrxr5W7Ui7yj/VyOK+JVJFfCf1GmFM5mHgKCWi56V/zCDoTldC02I1IoKAoq30xxiDWh1VnPzsm juENIgAvR4MXDYGvsaw== X-Authority-Analysis: v=2.4 cv=Z7Dc2nRA c=1 sm=1 tr=0 ts=6a7c256b cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=5RUhaqmk56rKhqzsUy0A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: 8C2x9vi5rdzbqiFaYK9Do0RwWNE-HxPa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_02,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120061 From: Tingguo Cheng The battery_chemistry field is a 4-byte array without guaranteed null termination. Using BATTMGR_CHEMISTRY_LEN (4) as the strncmp length for 3-character string literals implicitly requires chemistry[3] =3D=3D '\0', which may not hold. Use 3 instead to match only the significant bytes. Signed-off-by: Tingguo Cheng --- drivers/power/supply/qcom_battmgr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qco= m_battmgr.c index 91cf39b0083a..7716eb9e1aff 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -1238,11 +1238,11 @@ static void qcom_battmgr_sc8280xp_strcpy(char *dest= , const char *src) =20 static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *che= mistry) { - if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) || - (!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN))) + if ((!strncmp(chemistry, "LIO", 3)) || + (!strncmp(chemistry, "OOI", 3))) return POWER_SUPPLY_TECHNOLOGY_LION; - if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) || - !strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN)) + if (!strncmp(chemistry, "LIP", 3) || + !strncmp(chemistry, "LiP", 3)) return POWER_SUPPLY_TECHNOLOGY_LIPO; =20 pr_err("Unknown battery technology '%s'\n", chemistry); --- base-commit: 8ca3d2492e247e36fa9a4350fba2010ea5eec6f6 change-id: 20260812-fix-qcom-batt-chemistry-strn-6434c631ecb5 Best regards, -- =20 Tingguo Cheng