From nobody Tue Sep 29 06:08:42 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 778D647798F for ; Tue, 11 Aug 2026 19:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477363; cv=none; b=qo4ITL5FeWXU9cafH5uYEnhingQVdsoBOGjzjpjTngqMok45i4EYHj4DUDAkh21qbKonBYW7KFSbSkNaDMSelCxAiNwAr6MoSGEUdp4+eYKCq2FGe2iTQ0XaZcy+0UlJ7TUplu165TdsUVJNFb/41Xgyo5S5+uiPOaQl87GcR/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477363; c=relaxed/simple; bh=sD2zqEI8mU6Stm2UFCGxVthy9dR8oc2MSeMLosLduRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=STA1fj2IPeU2m3zbyXWlg+UQg0GoYLe4+pjkKyWpUgwnG0WI4+IUCiwWqL8c6IZSTpcb1Mk68tMXqaZva4RrK4rxLcvVmhu8j81Shmg9FWvHh7w8qRtK0FqS2dIVbaBiUWQfBFa1IN/ZZJ1ReA+s080KckXkBxpYek+VFRuSdlU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C25d6HM8; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C25d6HM8" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso1393065e9.3 for ; Tue, 11 Aug 2026 12:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477360; x=1787082160; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Yi6COyPD9cih637RhWmDl/GrYJABMEvAXSPzHDaHyRc=; b=C25d6HM8BL3i+Xm0ff+3ZyeovlzqLMX4MJk64OcFVarbvLv/KI5ug2I4fvbLdPHs29 bd/9ELmKqpICGAUNmM026TKljQZIcy1A5Dd2eLWzRFQyUOZzZUAUxF+G9TcCMIGEzNQS gBBnUaPmrQB+NzyghT86SrX4skoCzAnq0bxcgQhWq7NC/EA0I9TpqMBvryCGqFjfGyeW QjYvazo6Cd9Db6u6lR1lPAl/qX/0IjhvwFGrGjDqFkzfTvj40yyXD3HsqMoJLHb0OhU8 oQjOTzAnmd27BrI2+82vDQUbPTIWxSIddzwQ1Ja4kzkJEY1a1lRPLlGgLovwJuNUwKYf Yfig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477360; x=1787082160; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Yi6COyPD9cih637RhWmDl/GrYJABMEvAXSPzHDaHyRc=; b=Tk90JYJYQKlZ7x54rWhj29/f2j2VTHXXwz3XnBkdDOOrDFOxjaPxDckHAfYXXJS6lh SUggSbSKIDHXdfDHv/hmoFoWFHFfGD3yyIAROJXwB6YD1Qx0nzwaExUKPIOP8B0ldTk7 /EvzWLmpiSjPFLLU82AFbaJQAvRMwq1aIQZsxO8ycQ/8pWIXd721Lr65mdY2e2cmRFk5 gEdH8qiDi1rPiRK+1iwxBh+ao1U4In5V8aeGI7dOKUnjjYdn1lKHACCNTjo3zQSnmoDN Td8kz/HEtbXisvf2Z1wh+2eR4JctXygSFj98MXPqOcQqAq2DOpNQoV3o3FCEonr7pYt/ mGbA== X-Forwarded-Encrypted: i=1; AHgh+Ro4b7pfb59RJdgk86+lOKQ9mj442HkI9kK06YlHJWgevaWR5Alr2grPjVnyAaZ6NTaGJG7GOr3s8Y/lRcM=@vger.kernel.org X-Gm-Message-State: AOJu0YwlAY6yWxAsuQUqfmQR5TrQ4Iupf3/E2cB3e0GkJHNLGGddi29s A6uJCReOjRQj84VDobMM+jGvdJKb2dy6Nlo542Y4h+3oFjTxyStECSAl X-Gm-Gg: AR+sD12fvtpOvc3fgAvBbHgYUZps+snM87T4SgL6tQOF0lxDqD7/bkRnmnHyIcaIEXg Au6btFsg2v7V2I2r+9JJbujzAQ1hZd9HY+ruRRhmcE5q3yaFEtWiFzTpQ9M0GaD9RGP3I/YGUA5 Lq524CSLETzAcQDs6BRPyAJHZn4WemA7UxrSMMDlhtEJtUDCE61mYt3ITtzaYeLes3ZB4DkXueX f7cN5kT0ZCnMfAbUsR9uXnPALwScsoMeGeE8GnGE0kqOi5sfHSvMv+2tqkjwxWyoW2s+LphPMp+ aIl1WENoqQJ2n6CzeaMTcyUbkxB1d9j89LgUzABybmp/xxjfSIw3vVDv1hMQrnpxqcmvy9tG5jV NoyhU3qZ8k1TUCUg1v79FaRBNOBfE1OkxGj5qaf3pkEO7M3rNrWFtH12G67oGSCDkEWl+evYnnz NLDktSsRNFYin5Y2InCVCaaXHQXGxRh6zlQeK40kem3jZ3oV5ECT17pSkkl7Ev5AK6W+BHXhHXC XC1CpkyimL4P82BGsvjRgtsof5bnLPMQo/MS6P948cU0yHbbg14 X-Received: by 2002:a05:600c:4f86:b0:496:c378:6420 with SMTP id 5b1f17b1804b1-4997843b3famr69845395e9.8.1786477359442; Tue, 11 Aug 2026 12:42:39 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:39 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 1/6] Memory leak error in qxl unbind Date: Tue, 11 Aug 2026 21:42:16 +0200 Message-ID: <20260811194224.121597-2-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I discovered an OOM after run the script below (I updated it and added a sleep to allow enough time for the cache to recover): while [ 1 -eq 1 ]; do\ i=3D$((i+1)); echo 0000:00:01.0 > /sys/bus/pci/drivers/qxl/unbind;\ if (($i%1000=3D=3D0)); then\ echo i=3D$i; free;\ grep nr_free_pages /proc/vmstat;\ grep -E "PageTables|VmallocUsed|Slab|Reclaimable" /proc/meminfo;\ sync; echo 3 > /proc/sys/vm/drop_caches;\ echo 1 > /proc/sys/vm/compact_memory;\ sleep 10s;\ free;\ grep nr_free_pages /proc/vmstat;\ grep -E "PageTables|VmallocUsed|Slab|Reclaimable" /proc/meminfo;\ uptime;\ fi;\ echo 0000:00:01.0 > /sys/bus/pci/drivers/qxl/bind;\ done The OOM isn't just a simple leak; it's a refcount corruption which renders the list_lru fix dead code after the first mid-init failure. Fixed check if shrinker_list is empty holding shrinker_lock. Fixed check return value from ttm_pool_type_init and run ttm_pool_type_fini and list_lru_destroy for every pt initialized. Fixed change return value from ttm_pool_init to int. This patch depends on patch ("[PATCH v3] drm/qxl: fix use-after-free in qxl_irq_handler on PCI"), link [1] below. Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Link: https://lore.kernel.org/lkml/ 20260727110212.64913-1-megia.oscar@gmail.com/ [1] Link: https://lore.kernel.org/dri-devel/ 20260731053047.24503-1-megia.oscar@gmail.com/ [2] Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: =C3=93scar Meg=C3=ADa L=C3=B3pez --- Changes in v2: - Bug 1: ttm_global_init ignores ttm_pool_mgr_init() return. If shrinker_alloc() fails under memory pressure, ttm_pool_mgr_init returns -ENOMEM with pool types already initialized (64 list_lru_init calls done). ttm_global_init ignored this and returned 0, leaving orphan= ed pool types with a NULL mm_shrinker. Fix: Check ret from ttm_pool_mgr_init; if non-zero, goto out cleans up refcount + debugfs. - Bug 2: ttm_pool_mgr_init leaks pool types on shrinker_alloc failure If shrinker_alloc fails after all 64 pool types were list_lru_init'd, the function returned -ENOMEM without undoing them. With Bug 1 now triggering proper error handling, this undo is necessary. Fix: err_shrinker: label that finalizes + destroys all 64 pool types before returning. Changes in v3: - Fix: "Unchecked list_lru_init() return value in ttm_pool_type_init() causes a deterministic NULL pointer dereference in the newly added error path." Now check list_lru_init return value in ttm_pool_type_init() and returns error if any. - Solved pre-existing issues reported by kernel test robot: - [High] `ttm_pool_type_init()` ignores the return value of `list_lru_init()`, leading to a NULL pointer dereference if allocation fails. Fix: get return value from list_lru_init and return error if any. - [High] `ttm_pool_shrink()` assumes `shrinker_list` is never empty, causing memory corruption and crashes during module unload if triggered. Fix: Check if shrinker_list is empty and return 0 if it is empty. Changes in v4: - removed check return value in ttm_pool_mgr_init, now in new patch ("[PATCH] ttm: Add error handling for ttm_pool_mgr_init()") link [2] above. - Fixed check empty shrinker_list. - Check return value from ttm_pool_type_init. - Move up shrinker_alloc. - Deleted dput(backup_fault_inject.dname); - Fixed issue [High] The patch introduces a use-after-free race condition between `ttm_pool_type_fini()` and the active memory shrinker `ttm_pool_shrink()` by calling `list_lru_destroy()` prematurely as reported by kernel test robot. Fix: separate ttm_pool_type_fini and list_lru_destroy. Then, add ttm_pool_synchronize_shrinkers between them. --- drivers/gpu/drm/ttm/ttm_pool.c | 62 ++++++++++++++++++++++++---------- include/drm/ttm/ttm_pool.h | 2 +- 2 files changed, 46 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 278bbe7a11ad..88c0d33eed1a 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -437,13 +437,21 @@ static unsigned int ttm_pool_shrink(int nid, unsigned= long num_to_free) LIST_HEAD(dispose); struct ttm_pool_type *pt; unsigned int num_pages; + int empty =3D 0; =20 down_read(&pool_shrink_rwsem); spin_lock(&shrinker_lock); - pt =3D list_first_entry(&shrinker_list, typeof(*pt), shrinker_list); - list_move_tail(&pt->shrinker_list, &shrinker_list); + if ((shrinker_list.prev =3D=3D &shrinker_list) && (shrinker_list.next =3D= =3D &shrinker_list)) { + empty =3D 1; + } else { + pt =3D list_first_entry(&shrinker_list, typeof(*pt), shrinker_list); + list_move_tail(&pt->shrinker_list, &shrinker_list); + } spin_unlock(&shrinker_lock); =20 + if (empty) + return 0; + num_pages =3D list_lru_walk_node(&pt->pages, nid, pool_move_to_dispose_li= st, &dispose, &num_to_free); num_pages *=3D 1 << pt->order; =20 @@ -1122,6 +1130,18 @@ long ttm_pool_backup(struct ttm_pool *pool, struct t= tm_tt *tt, return shrunken ? shrunken : ret; } =20 +/** + * ttm_pool_synchronize_shrinkers - Wait for all running shrinkers to comp= lete. + * + * This is useful to guarantee that all shrinker invocations have seen an + * update, before freeing memory, similar to rcu. + */ +static void ttm_pool_synchronize_shrinkers(void) +{ + down_write(&pool_shrink_rwsem); + up_write(&pool_shrink_rwsem); +} + /** * ttm_pool_init - Initialize a pool * @@ -1132,10 +1152,13 @@ long ttm_pool_backup(struct ttm_pool *pool, struct = ttm_tt *tt, * * Initialize the pool and its pool types. */ -void ttm_pool_init(struct ttm_pool *pool, struct device *dev, +int ttm_pool_init(struct ttm_pool *pool, struct device *dev, int nid, unsigned int alloc_flags) { - unsigned int i, j; + unsigned int i, j, k; + int ret; + struct ttm_pool_type *initialized[TTM_NUM_CACHING_TYPES * NR_PAGE_ORDERS]; + unsigned int n_initialized =3D 0; =20 WARN_ON(!dev && ttm_pool_uses_dma_alloc(pool)); =20 @@ -1152,23 +1175,28 @@ void ttm_pool_init(struct ttm_pool *pool, struct de= vice *dev, if (pt !=3D &pool->caching[i].orders[j]) continue; =20 - ttm_pool_type_init(pt, pool, i, j); + ret =3D ttm_pool_type_init(pt, pool, i, j); + if (ret) + goto error; + + initialized[n_initialized++] =3D pt; } } -} -EXPORT_SYMBOL(ttm_pool_init); =20 -/** - * ttm_pool_synchronize_shrinkers - Wait for all running shrinkers to comp= lete. - * - * This is useful to guarantee that all shrinker invocations have seen an - * update, before freeing memory, similar to rcu. - */ -static void ttm_pool_synchronize_shrinkers(void) -{ - down_write(&pool_shrink_rwsem); - up_write(&pool_shrink_rwsem); + return 0; + +error: + for (k =3D 0; k < n_initialized; ++k) + ttm_pool_type_fini(initialized[k]); + + ttm_pool_synchronize_shrinkers(); + + for (k =3D 0; k < n_initialized; ++k) + list_lru_destroy(&initialized[k]->pages); + + return ret; } +EXPORT_SYMBOL(ttm_pool_init); =20 /** * ttm_pool_fini - Cleanup a pool diff --git a/include/drm/ttm/ttm_pool.h b/include/drm/ttm/ttm_pool.h index 26ee592e1994..66248323c2c1 100644 --- a/include/drm/ttm/ttm_pool.h +++ b/include/drm/ttm/ttm_pool.h @@ -81,7 +81,7 @@ int ttm_pool_alloc(struct ttm_pool *pool, struct ttm_tt *= tt, struct ttm_operation_ctx *ctx); void ttm_pool_free(struct ttm_pool *pool, struct ttm_tt *tt); =20 -void ttm_pool_init(struct ttm_pool *pool, struct device *dev, +int ttm_pool_init(struct ttm_pool *pool, struct device *dev, int nid, unsigned int alloc_flags); void ttm_pool_fini(struct ttm_pool *pool); =20 --=20 2.55.0 From nobody Tue Sep 29 06:08:42 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8344C478851 for ; Tue, 11 Aug 2026 19:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477364; cv=none; b=l9ZZltfKdB8Z4z4asn09Mhp7WvaifSC1ceREy9wYl/tLnGo3XlAM2FYAA7jqT0SpCfxhfQVGUK7LEE76iR9/YTnwHD61P/ordnlOdLhPq/3uEdnIvJ1MAWEGJZFNcp2/mvr0BizX5gKStUsW5XxCX/V1zRjERaoGFz3VJr13kmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477364; c=relaxed/simple; bh=0MSVQNAfX1H3iU3xjsiD/tQTHV1nkB6xpxwoTTdwURs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m2f8FQVH/SKWrXW9bBsytNUBrlyrD/dmty4ZSKjm/0MRNhxLox2F+2M/szz6CLWKnz2YvjHylsj7hNn8Zf1NcekQjU8m2OPP9bCi5jGlO0a0nFvt93OmJ6e4ltuR5eLTG+HLizVyWl5Sy42XGAGbuB8saIfCoEeve+uw3XHcyuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wpv1ZjD0; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wpv1ZjD0" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4954aff6088so513655e9.3 for ; Tue, 11 Aug 2026 12:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477361; x=1787082161; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=maGvDaUsV8Puzc/vzM2VfATUwgjtE+oqcHZemKrSRow=; b=Wpv1ZjD0PEaB6UzCTwI9FgPHMo5nOjXQhXQJbXm5GL+tIjVf2TRJUlLtkFAwRA7373 qabMYMlX/g5Qc4dfrkT4R20HUPy6clBLtycSfTWC17GELlVWr4NgTFKoPctZmpEbQhat 99lPnJKn1EM3R/5QwcPa0Dh13HBKpsoWLfY38L3f81mHImdSNEOCFcIYdQA3a1YgEYCF K74S6Ft9LrBeh3GmbEUJB/s1NwwnVlPluqn9uKVxYLKsbNCgVsIhU6SiiGgrsztZ49mV wykBjJUGDJCOTlfq63RXdzEruL7K/5pUqMgpk+GZgQ0u1yv4NyqY4YtSIamyH6yRNJAs Obxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477361; x=1787082161; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=maGvDaUsV8Puzc/vzM2VfATUwgjtE+oqcHZemKrSRow=; b=KjdJLdA+tVjhuEgnGn9zNzG45X8adXHQpOMTAU/4z0SEnXAVnYExWct2R7fEg9ChAl ON67S6VzgmiUU7g8y0qYvMLyWhoRqBGadff44T6qW4HDn57DKFYcgDVRu65caINqvuhf IO7s/TZOi/qwCGmVECTyUE8qBGlZG5VDQDcFsMiZKxlTfduKpjYz+hj50+Yv4PFZG8aB sFq2x2DtD83NEzcUdfXTtHsrT/e/3z4YlBUMT+am0MErO1MYJaXLLhBy6/sdwCvsi2OR geJWEt+X7hLozjG45KDr8KyjkvMebidhWepJD9VCD5aYX80QGGDFVC3prrGSsdeH5nQ/ ONWg== X-Forwarded-Encrypted: i=1; AHgh+Rp1kUnI3smGFMYl5C5rzGNAU5trFnwGWN2nxBB2b147I3rm0gjGPq/R1q1G4y9AWD3QrjD6gDF4Ynzukx0=@vger.kernel.org X-Gm-Message-State: AOJu0YxWdAVTgK2wWOox8TLPcM9XK0YY2UXf32ckkY8lvMPQcfibp+va CDlirlDYmuCqPDyTH0HpVws3+s1Pmnl23LiglBOWi5fLgjVYQJt0GO7t X-Gm-Gg: AR+sD12OSfBie8YEu+e6YCDo5cN2s4UDXiydAJH4mO9BO18DzfbRoyeACn9W8JEDqWo 4tk5N3TgP7n1WJhk4nD1QSU4tq48ma8v1POCZX+tviRUHOkvzYWvFfW3vQJ90S2VpcIitm3RcY1 GK+92wyyfQkFK+OjrirgwmYNNihyVP2+fNsL2vup9H+0sAkdOk8FZfrjHAAMzo7LGn6pRB3UqMK wtQv8x7UvnRtGr2u/Hed3kzQPDv/rh1VRlpNOzmUSIU9t5lkBdXIhxhWwMSZrrNBZQcVB6ZVyC0 Jy80GsrrhIHqY1yUXPc3ecGi8VQ3EiE5fktV+AjU9/4gFbO2Q8fkwnBNZho9p5k5dWucOVeQ5lE BIMapXdFixMQmu2oDE3Ko7cbiCpY2IGlTdQ7gNCvy/ijC+f5UJPzO41DSKPBwgN2Ut0XucpuwxB bOfXEmBO79PyVUEkOTvbJuVfQswpykxfrFWej5Pjm6gFlIkdEIwJdrv8TQLv3bNWOptIQexNhMA W/UwQzAyMPV5frwIqrKk09bzBlqUzBrGlDd6X2EyLuDl8pUF5+L X-Received: by 2002:a05:600c:1d0c:b0:495:6bc9:62b0 with SMTP id 5b1f17b1804b1-499784611c4mr86084415e9.17.1786477360587; Tue, 11 Aug 2026 12:42:40 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:40 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 2/6] list_lru_init() does not check return value Date: Tue, 11 Aug 2026 21:42:17 +0200 Message-ID: <20260811194224.121597-3-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bug: list_lru_init() does not check return value in ttm_pool_type_init(). Fix: Check the return value from list_lru_init() and propagate the error. Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: =C3=93scar Meg=C3=ADa L=C3=B3pez --- drivers/gpu/drm/ttm/ttm_pool.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 88c0d33eed1a..8637f7942347 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -354,17 +354,23 @@ static struct page *ttm_pool_type_take(struct ttm_poo= l_type *pt, int nid) } =20 /* Initialize and add a pool type to the global shrinker list */ -static void ttm_pool_type_init(struct ttm_pool_type *pt, struct ttm_pool *= pool, +static int ttm_pool_type_init(struct ttm_pool_type *pt, struct ttm_pool *p= ool, enum ttm_caching caching, unsigned int order) { + int ret =3D 0; + pt->pool =3D pool; pt->caching =3D caching; pt->order =3D order; - list_lru_init(&pt->pages); + ret =3D list_lru_init(&pt->pages); + if (ret) + return ret; =20 spin_lock(&shrinker_lock); list_add_tail(&pt->shrinker_list, &shrinker_list); spin_unlock(&shrinker_lock); + + return 0; } =20 static enum lru_status pool_move_to_dispose_list(struct list_head *item, --=20 2.55.0 From nobody Tue Sep 29 06:08:42 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C881147DF8D for ; Tue, 11 Aug 2026 19:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477365; cv=none; b=LuObet44I2yn/ldGsYs/RMsdyeqRdcKm4odurOHFcTBylUAiWOecs9HoY9FZGMeRmDTM7/iHnmJq+5o2KpCK4G0W3DQ7ptSFm8fHv76f6/5Kf1k88BL1fBYTtwE2gcrJnYxkrib9b/dDhfLZT4pd0Zrwp+rm513O8vQSYcqVjZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477365; c=relaxed/simple; bh=JqKxq/IOJGoEcnOQcFWHghdDL43RcY0jUPwMdDnrmpA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pLppb245ptGAD/66VPpJhjCEpwyg6ufIXIPhYO60bzKk7h1N9t2gjGlz+WzAeP4Sy0gXct0z7/QQJEVfLWM7thSL9P3NmrvKzGAeAqRfCOFQmTQmlVY+wli9ySi2hEjhWbZBV4XZxTSwfiK1NokltMoTpM7OKpJTVmw4gvJ0cqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=scDbh4T5; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="scDbh4T5" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4954a32cf1eso679565e9.3 for ; Tue, 11 Aug 2026 12:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477362; x=1787082162; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=4v0iZboq/uLDu8mV5Gkz82xHeLB+QGVZ8axU862tksE=; b=scDbh4T5G/QwAqtllmYTLjlzOW2uSJ2TlsFx9AyxHOM6ubfyyAyHdfcaaXirIYtm69 0Fhr0ws4xAqi1aYViuYEd4z9nZOW9EGPKmljE8rm5z1LIVietEK4H+zBptwAH1/0pEIQ gi5PkZJEZ8lftKx2ciaDQcTOqvzGneGr9AHLilk0+t1V86zaeoSLbBl71lb76+jdZvbE emfxuXzR07cqhgX74E9v2JW+nJHjpl78fvReZFikqINnihKdfd5xkp/O5v+VU5KAI4gL W1wdOu5b3WAjX2d96wkg6tQ7VlSjquCvT9pBGGDdaVzPcFm3gSdNSRL7Fgoi1WtF7aId SFyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477362; x=1787082162; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4v0iZboq/uLDu8mV5Gkz82xHeLB+QGVZ8axU862tksE=; b=FhEza5fmrbbUMAJzJRl7G63ie9RXaOxmR74z+/uSeus0vIAZjGfOGNG22TbKVMcvcf C+c9nIZ1nUQAa5VIO69ua1CccMV6aRo7TCtcP/i3EW3rl9NiYOxvdo3a/KTkQsgKccES aszu/QJZzQ4EZKy+peSU0kBf6p4tImAdkQcWuTfuSbFcjOdbthlC6RjfKlmJpsIwJbRN JYjED8KUCZ9RjwE/3LsYJVFM5rXfrDC+dFn9BWjhOxVIUJ4nsdgfXvX90MjT182S5sD6 I+tKFqjte7LsNDaq2GoiIFfiJ121sMRpncsgG9Awg0WzPBVB+yYxbaBkHZUs/IKu7SM8 bfsA== X-Forwarded-Encrypted: i=1; AHgh+RpciLnWSwdusz0ticKvf/NKHJTsgn9p/+vm+2NTqGJtuosxKGxSglZVhBGfdvhvbN4Dc4BqJ0F+xVK/5p0=@vger.kernel.org X-Gm-Message-State: AOJu0YzPPcz8WXgZFfTQkrMyCtpebQ0FIqxPzDcGJU/KiWSMTlKAaZ6M qHbDefnOVKdg5SXzSngJz1VADvDgDK+Agaxkh0KAK4oyDNJTMXAR1CBP X-Gm-Gg: AR+sD13YXNc2iCRSGRNRDk2+8ne9UoIfnSv6XbL81NM9uydjjlA/J9ai+bUpOImwGZ+ Y+QtlWxO3VlcnqRyzqE6t8J/Q76GauuG7DA75s42yJndo96yN8NR0HwcQvl/PKj0NYNUIbHlDks 99cp3aboyja4/ZulUILOzZXtL8yewGVOF5WUNIUvzW1hfmZZDSR4HDnl/pd/lLmFpALik206PJs IRTSkVqCFZiCXKJiVgJ4LqnaRkL0vCdjBgQAFgetTJ0gC7UYK96SKjYSEON7E47PhdlGCz6BFjw Ex4MYLIJGGAcUHOUHWTrDiEQnEJHxieGyaf+0snYo7Y9wQb2T07thODY0NzOgcwiO/287LXmikw XNSa0BV+Ee8pXyE/Equ15Po0tUgSOjDxiK21YTzGKCNyZBmR+nlWMjXlOYZ9CtnBWlj5o3JtvFE iITs6ry81M+Kyf7iNNB1FQw0gDdxxp6gneyXhKag+SVNyl5mtFF35LM4FV54aU52Z/KC6GdzP2a oCeT++di9XAlxxmthxAysEnBbtBH+xKPgODyn0vHHYrdHjcNZXX X-Received: by 2002:a05:600c:34d3:b0:499:6eac:36d2 with SMTP id 5b1f17b1804b1-4997846d9c5mr93834455e9.17.1786477361645; Tue, 11 Aug 2026 12:42:41 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:41 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 3/6] ttm_pool_fini() does not destroy list lru Date: Tue, 11 Aug 2026 21:42:18 +0200 Message-ID: <20260811194224.121597-4-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bug: ttm_pool_fini() does not destroy list lru with list_lru_destroy(). Fix: Add list_lru_destroy() after ttm_pool_type_fini(). Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: =C3=93scar Meg=C3=ADa L=C3=B3pez --- drivers/gpu/drm/ttm/ttm_pool.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 8637f7942347..87c843f52736 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -1232,6 +1232,17 @@ void ttm_pool_fini(struct ttm_pool *pool) * that no shrinker is concurrently freeing pages from the pool. */ ttm_pool_synchronize_shrinkers(); + + for (i =3D 0; i < TTM_NUM_CACHING_TYPES; ++i) { + for (j =3D 0; j < NR_PAGE_ORDERS; ++j) { + struct ttm_pool_type *pt; + + pt =3D ttm_pool_select_type(pool, i, j); + if (pt !=3D &pool->caching[i].orders[j]) + continue; + list_lru_destroy(&pt->pages); + } + } } EXPORT_SYMBOL(ttm_pool_fini); =20 --=20 2.55.0 From nobody Tue Sep 29 06:08:42 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B17ED47ECC5 for ; Tue, 11 Aug 2026 19:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477366; cv=none; b=p7FRwONZF8DAU8owsWprvKhsBOXvXKDwcbOpAepRxy03qnxD4CA0tmtm/JEGuWr5wLrdI6SSMV6xUslKSBGLBKBMn1D3rM+bGXDY+wyOAig77/JpuJMVdcACQESizeyW8Pt1/Qe11mfh2bv/x+HMsc8ozT9NonH2JU0J25T1MpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477366; c=relaxed/simple; bh=U1vS2hAziy9qUItkEoTyRmbezIqMpTHDIy3iBj2cyM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QezyzU9xdc6UwoEdCr6vkNcP0chiWQJHXM8C5LibUzUGVIXNk9NSpetA0AgTNuC4ZsEaUFE7xR90NS6GIkPjWCYSbW88hV3txli6SLOR0Nxn9pDu+aPM5quSGML6hX2d4kHq3EHjnAYiWusPjxEklMFO2ymx0JQ/TshJG08Tx8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NGm56c+a; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NGm56c+a" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4954aff6088so513935e9.3 for ; Tue, 11 Aug 2026 12:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477363; x=1787082163; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ThEXNcRr1uXZthkNQc1yyhogFUr1K8iZ1YVWwE63FbE=; b=NGm56c+aCWP/l58H2V1CRfpFp8lr6tPBhLTbD+n9TyELFNa/PLbcoBaPWP7rwjWO+9 0Q6n/SlHCFx66NvBjbA1Jm7ZorAJFSSY9wcSGvCXfeSTRhp1Gf1GbLt7icV1U0QsCQH2 Tgw941ZC9vgqtdYK4SPXePgU5P/4EO+WhZhgButpuwKhAjrT7xJimL8xZQ2QQW5Z0iRh 4iGyhbGmbM7Sl5tS6vpPxnBOWPFPmzstynoiB3sqMfzqaBmj8s9UPnFeiRPixDhUPb5P v5jGFK7OZbWFjjs+PDgfwoZdNoVZ62YGWLt4RnQGQwuEh0ZIn0ZEoASRUy9EkrSGSDLc xIcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477363; x=1787082163; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ThEXNcRr1uXZthkNQc1yyhogFUr1K8iZ1YVWwE63FbE=; b=HCLPVpoCL8hpp3MNVsC6YDHT2ykca1t1pjYoL0EmpyJd7b3WclOIHNwKz50xoi7HZu g8+N7r6jR/PVOKBs8ywme/L/4oIqniaW5S6QtYhbAM3AMkrx5X8dxCQn1tgjogPxfcGK FpHf6q+2aEiyv+HXRgv5xlBmtHTVE/pDhYZvJI6MV+KR2KQbPsDRHNsbjgBo8lM1JzJ0 7E09lkgmyv+RPxn53r59G1zwGP6wm/QO3VWKK02W8dkeadBrScI2obkIz9ySOd+xXQ4V V+byolYrtA2NjIjx9Hg3irmba/3T/JuwasXW/Mc7LJrl7zXYsG53bs1IVbU3O0iEuwGv racA== X-Forwarded-Encrypted: i=1; AHgh+RqcGdci8vNYWtC41ZONBVBELrd5m4Qn7gQZX3GD1s63RVpnK0pf7h5Hpm/oHswWYmNM8JOrlhWqjEbnAMQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1JSbPYE2Vj3k9bqMqrYnA+OdOfep9fdFBJ+32gG1ly4+nYBNR aO65z3rn5RfOZV/MQVNEVQAU4UTsYNRym22J0xYddoD/5ZcnXmRVylT+ X-Gm-Gg: AR+sD12cJ36p/pntDgC/qvH/uaqEk3+4GZQLKKlf4aKgQydrF1SrP9EspWcLG4PKYag 4xKhiqZuYgejinJMRde7vHtvIdegin5TiJjhrHpllka4vPMA26eXJvuhJpPUNSAKS9OP/fHDrtr d7RLC9348DDR3IHgr4HBLCSS6Ux6wdouEni9t+1e/54JuNn5IiQcgAkm6Bk4LvArF5+nNzQ8b7X nImnfP7uEcQTq3bHSW/DiOWLhE3JYhvSuiDu2uFE1vry1DFxqPwd8j14MHGXxqN+kb3YXEzUo9B 9HCIp7rk5DE7hZOdXWvj1ai7mIQZZmzQxpCas1LXt9MFqEqvCw28PvZRcT1P5hGCZqcrEhB9hyY 1YXb5jmqNPB08NTj4AZzSgnJthQFY2DE2EMzx5ycpXyFkr5bxXEi0ayS3p4zQzEhx3Llt1glhjh KTf8smafRgKrP1Z5ibyVPF6RvF1rmTtYQHmw6pReY23pTOr6wmiqx1kRZ53xKYnckiYK50P9h1j 9CB1JJMkZOfW2AS4DNSrjXeilFU7cYxT4qL0xkIuExeVIbhqsu0vIlCdRiy/pA= X-Received: by 2002:a05:600c:1f83:b0:499:4e47:eaf2 with SMTP id 5b1f17b1804b1-49978413130mr87241535e9.6.1786477362706; Tue, 11 Aug 2026 12:42:42 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:42 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 4/6] ttm_pool_type_init() does not check return value Date: Tue, 11 Aug 2026 21:42:19 +0200 Message-ID: <20260811194224.121597-5-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bug: ttm_pool_mgr_init() does not check ttm_pool_type_init() return value and does not free pool if returns error. Fix: Move up shrinker_alloc(), check ttm_pool_type_init() return and free pool types and shrinker if non-zero and return error. Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: =C3=93scar Meg=C3=ADa L=C3=B3pez --- drivers/gpu/drm/ttm/ttm_pool.c | 100 ++++++++++++++++++++++++++++++--- 1 file changed, 92 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 87c843f52736..74d8770f41d8 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -1421,6 +1421,54 @@ static inline u64 ttm_get_node_memory_size(int nid) return managed_pages * PAGE_SIZE; } =20 +static void ttm_pool_type_fini_and_list_lru_destroy(unsigned int nr) +{ + unsigned int i; + + if (nr =3D=3D 0) + return; + + for (i =3D 0; i < nr; ++i) { + ttm_pool_type_fini(&global_write_combined[i]); + ttm_pool_type_fini(&global_uncached[i]); + ttm_pool_type_fini(&global_dma32_write_combined[i]); + ttm_pool_type_fini(&global_dma32_uncached[i]); + } + + /* We removed the pool types from the LRU, but we need to also make sure + * that no shrinker is concurrently freeing pages from the pool. + */ + ttm_pool_synchronize_shrinkers(); + + for (i =3D 0; i < nr; ++i) { + list_lru_destroy(&global_write_combined[i].pages); + list_lru_destroy(&global_uncached[i].pages); + list_lru_destroy(&global_dma32_write_combined[i].pages); + list_lru_destroy(&global_dma32_uncached[i].pages); + } + +} + +static void ttm_pool_type_fini_and_list_lru_destroy_partial( + struct ttm_pool_type *types[], unsigned int n) +{ + unsigned int k; + + if (n =3D=3D 0) + return; + + for (k =3D 0; k < n; ++k) + ttm_pool_type_fini(types[k]); + + /* We removed the pool types from the LRU, but we need to also make sure + * that no shrinker is concurrently freeing pages from the pool. + */ + ttm_pool_synchronize_shrinkers(); + + for (k =3D 0; k < n; ++k) + list_lru_destroy(&types[k]->pages); +} + /** * ttm_pool_mgr_init - Initialize globals * @@ -1431,6 +1479,8 @@ static inline u64 ttm_get_node_memory_size(int nid) int ttm_pool_mgr_init(unsigned long num_pages) { unsigned int i; + int ret =3D 0; + struct ttm_pool_type *types_free[3]; =20 int nid; for_each_node(nid) { @@ -1445,15 +1495,53 @@ int ttm_pool_mgr_init(unsigned long num_pages) spin_lock_init(&shrinker_lock); INIT_LIST_HEAD(&shrinker_list); =20 + mm_shrinker =3D shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); + if (!mm_shrinker) + return -ENOMEM; + for (i =3D 0; i < NR_PAGE_ORDERS; ++i) { - ttm_pool_type_init(&global_write_combined[i], NULL, + ret =3D ttm_pool_type_init(&global_write_combined[i], NULL, ttm_write_combined, i); - ttm_pool_type_init(&global_uncached[i], NULL, ttm_uncached, i); + if (ret) { + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } + + ret =3D ttm_pool_type_init(&global_uncached[i], NULL, ttm_uncached, i); + if (ret) { + types_free[0] =3D &global_write_combined[i]; + ttm_pool_type_fini_and_list_lru_destroy_partial(types_free, 1); =20 - ttm_pool_type_init(&global_dma32_write_combined[i], NULL, + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } + + ret =3D ttm_pool_type_init(&global_dma32_write_combined[i], NULL, ttm_write_combined, i); - ttm_pool_type_init(&global_dma32_uncached[i], NULL, + if (ret) { + types_free[0] =3D &global_write_combined[i]; + types_free[1] =3D &global_uncached[i]; + ttm_pool_type_fini_and_list_lru_destroy_partial(types_free, 2); + + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } + + ret =3D ttm_pool_type_init(&global_dma32_uncached[i], NULL, ttm_uncached, i); + if (ret) { + types_free[0] =3D &global_write_combined[i]; + types_free[1] =3D &global_uncached[i]; + types_free[2] =3D &global_dma32_write_combined[i]; + ttm_pool_type_fini_and_list_lru_destroy_partial(types_free, 3); + + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } } =20 #ifdef CONFIG_DEBUG_FS @@ -1467,10 +1555,6 @@ int ttm_pool_mgr_init(unsigned long num_pages) #endif #endif =20 - mm_shrinker =3D shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); - if (!mm_shrinker) - return -ENOMEM; - mm_shrinker->count_objects =3D ttm_pool_shrinker_count; mm_shrinker->scan_objects =3D ttm_pool_shrinker_scan; mm_shrinker->batch =3D TTM_SHRINKER_BATCH; --=20 2.55.0 From nobody Tue Sep 29 06:08:42 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE2547F2C3 for ; Tue, 11 Aug 2026 19:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477367; cv=none; b=j2XQwbJU2FR7GUcvrsIaHW+v9s45MDf7hyCEdwgnKmWmFErBU3rSx8dzLiE1KuYapE2fXG4TI7CGdOUga90jX+8n/5g7X6Q0di0QcbfvG4liibu0vIfckUiSLDvQ6RUnL1ML7EZOEwVP1oeg02IPI3hJK7UMnzj18YCSzbHijdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477367; c=relaxed/simple; bh=l4VG0FqV/vJrXP9/bYAlLrRX5IxIiYLLx7pkgrMFnTg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eqyFFd5ECTuHJwiG9ebZF7SvHohh+cuyAG7C1dA/Z50RU6NGF8BK/kOI64BmR81YvVYwzFfjzh5TQW6TG9pXeiVJMjlWynujl4KJ7KZe/PNAGS/bOf21ds+AZP9F/J0kU3SeI8Z9VAiWkAgOEnj/XwzI0GxdBRpbH8gXxSLoeJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XLwLP5IJ; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XLwLP5IJ" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4954a2e73a9so408425e9.3 for ; Tue, 11 Aug 2026 12:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477364; x=1787082164; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=F8qrj8CmLGjwQMZeVA2ZOifuwHu1xiIsioWlV9Mw2Jg=; b=XLwLP5IJlXW7enAxfH6H2OmXyX7rk3ZQj3CiyxKMYS7z1WWLBhQt9eDirC8qfKUZpP U8KuBalr42WAXUNqtS3AxSbcvJAMZtL1RMYxk2cnks8Cl5XWYKk6of/PrDLMZiOZNhjw TWkBMbJRKBE+L8fFpy3x5ONYNtwDGcqgvgiNODsItFY/6rGoFzCIswTd/SCPCxFuIPrv uRrB1tAk3D9fr3XzNeMzBXu4DQrtTQyjBQ7BuHkpFpdv/uVXGDX+GVxC5hEADy7eNn0P KbnaJw27xYLGNN1fQA8NpgXUe8YBQGM5nTeRXHRsNaCJzCag0eWWuS8VlB4bBjZMH8MF xLpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477364; x=1787082164; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=F8qrj8CmLGjwQMZeVA2ZOifuwHu1xiIsioWlV9Mw2Jg=; b=Flxk0wQlS1cTwrL+Fq/ilcl2CuImwAt6mVC0God2+NtiuDR/3TOuMtQDuEDgUiv/ZC yIyraq9W/alsswjQlUqTRE7HtkYSprI6bs4uw3Cbqg+jTHs3zVjiEp7YXdjlGHocJP4o 9w5cAXIGge7Lxhk4wqxQjSAM8Nw0sqGoMYoBdrsVReG3m7Lm5NWprbsChUMUngCrSPnE UG+nsDV+XtrDRpp2whiGujy1q/bupVs73FUVo5kXwmsfGbU4btSQbcHbbstXihdUsIF8 BhBaBR24Ncl8q+7cGyZhzkfUSICCITwDms2QQs6C1RtoyVPR/4OnMj2xobHhZ/o4Ww6X 2NhQ== X-Forwarded-Encrypted: i=1; AHgh+RoRZogC+joelicxmihrz+mCd/bDYLhrKPE2fYFrNgHiWYt2J6XmFx+OfRxOt6nQm3fbwnjmqBHzV3Y1ypM=@vger.kernel.org X-Gm-Message-State: AOJu0YyTjjsaCUtn5VFvdFasEPdgwg2gF4zIbeRqJuNsRYhh555wmrJE VIHNICRKHW/wIgHEi6PcKRYNIU8dOFMcHn5Gwi2V6+5AvdOkWFIUpa4/ X-Gm-Gg: AR+sD12XwBaF5pQaTnVwnn2bjEboU9eK75W9x4iEDtk4jzVCNW2/QdXufrrXJ20203s RPG2b0jsNRUNXSGKOfc57UdTGKEURx1hJClaLp4qKbJPuolWFv9U/w0Ow/htGC2HU6eIHp0dYqQ nga0Q4CS3iYpGRSAlbhZvXl7aJSBIOOw3F/S3nBZjy/jpdDSiuzuAf1HyxWdfIn32x6iX4aWWBh zOx9u1lqynO/izzVkUcJL001SVqUkE6030MHzfKvSO0vYkLSRiu9EiVOaBLFWCx/qh3uQmAlM/B tyNt+yInV9XxwcFfkHUcyiCSpwhHjG+Aiivb92oeRJYhHVMzFApLw3Nbnq+HaJhvWHXMIRJZBNJ e/e0P6FU04M9NC8JdPgJktt3UDRW6fhY3m4RX2wHNrPFUDy+eJtvCb1j0BKnR/zvzCaCaj3ZBtj jh2TdCF/IeqN++qDsw2tTVQ0adAT+aUuv66EUaCRo5iG2Iir54exA3GHdjZPD37F0ihxXnulAOH qUrgBomc6L/yEWx5HJhIdd+M5jVq5I8v6tahqRvJ3DirpGMLCv4 X-Received: by 2002:a05:600c:1d0b:b0:499:51b8:d649 with SMTP id 5b1f17b1804b1-4997a5f2427mr38053465e9.3.1786477363864; Tue, 11 Aug 2026 12:42:43 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:43 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 5/6] ttm_pool_mgr_fini() does not destroy the list_lru Date: Tue, 11 Aug 2026 21:42:20 +0200 Message-ID: <20260811194224.121597-6-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bug: ttm_pool_mgr_fini() does not destroy the list_lru. Fix: Add list_lru_destroy() after ttm_pool_type_fini(). Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: =C3=93scar Meg=C3=ADa L=C3=B3pez --- drivers/gpu/drm/ttm/ttm_pool.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 74d8770f41d8..876b6d3a632d 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -1572,16 +1572,7 @@ int ttm_pool_mgr_init(unsigned long num_pages) */ void ttm_pool_mgr_fini(void) { - unsigned int i; - - for (i =3D 0; i < NR_PAGE_ORDERS; ++i) { - ttm_pool_type_fini(&global_write_combined[i]); - ttm_pool_type_fini(&global_uncached[i]); - - ttm_pool_type_fini(&global_dma32_write_combined[i]); - ttm_pool_type_fini(&global_dma32_uncached[i]); - } - shrinker_free(mm_shrinker); + ttm_pool_type_fini_and_list_lru_destroy(NR_PAGE_ORDERS); WARN_ON(!list_empty(&shrinker_list)); } --=20 2.55.0 From nobody Tue Sep 29 06:08:42 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDB8247F762 for ; Tue, 11 Aug 2026 19:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477368; cv=none; b=He9xA9H4S4YKSS7uxgQFZFzvWvrZw8ynSHdm1YHWUrJjx4VyYpoTpWbfV9N3nEad882ICTRtJfOhtaIBQx+8jnVAUctBA5KOUKBFj5QodoR/7eZAL3sWJwP4OjqADy3BhflC1PkVV4D9Qo8tYYd9PCnwXp/WpPyYN/SPjFJBi7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477368; c=relaxed/simple; bh=ddu9DCVg5CNBBxYAZ7C2IjQ6tIBqi+R18l9PMT0/plU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B+pd2icUDTpKMhi2+JLdt5nP77F5oTVOAXbq1W07/jLJvAd5xVZvGvbz2HnxjrtjHj8FpoAft0C2u38+D+dI0mGl88aSqK1UBhGT1MgRT6lDkvik9Iy9MTE51yLTIQfyk+UkMSPX8JL5LlBS1Utvx3xKEhyu9aP2jXymP828lkA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BlSFve13; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BlSFve13" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4954df200ddso1198885e9.0 for ; Tue, 11 Aug 2026 12:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477365; x=1787082165; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BuMfkemM9Oz2WhvZaC2ZnN/4G8tTmAb8WWo8t6gaQkk=; b=BlSFve13Gb9f+zra3PMJQEo3FBkG/BjUHf4SiSWqf9K0jNsdph37XeV4aa6j1F8lkT 8gOqAyjsVrUiGke821I+GY/PEx15MkY6vNLvvjMFU3Rx5IMVH5wXNjeUFuihKiUGRNok e0ivNuJ9KLQSDuqljEFVA7HZjvWgEgty9cWlojShwbvG3anOSHfXj9u96qvEzHcp1M8p P4oBCFH7pPvcR8k0FlEMdLGLxNPc5aDnhuGpMrrzy7Z4bqpg3aox/NOIbg/s/SMawUSr cz+aKcDygUHU6LK6eKBzEGgDxHLsOTXzDSrswd6AD5wCkgeeteuj1ysC348FDPhjzL5d hTpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477365; x=1787082165; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BuMfkemM9Oz2WhvZaC2ZnN/4G8tTmAb8WWo8t6gaQkk=; b=TaWauvWErLyp2fu/+n9A4SNZ/ROm35a6vn0gNKpsX0dcAkW/gngvvOZYXGOK7xElNM VMqUEfwEd+sPMpfxUA2rld5s/pjYgf8cSTyMOm8sCMg8vLIJCn3iU0X8L1x0s5jla+Na U1qUmTo2zS3DNRET8vkbpGrBzrw7mo7UACd0cdT6SG/xthnyRjDRmHQmpY8te4ux/fHw rBDqVYC1jrkBBzHN9kwu1RzMovSupFl/FOPbmFm1qfAjmYOgcfAhi9EGe7BIIujdDMS1 yXzzAwrN4jtxLTwwscBt8YnWpGwIZ1K3++uvv/CBnkGR2Z2o4w8WZ2HoOnpzbqyoWJVh Tziw== X-Forwarded-Encrypted: i=1; AHgh+RoMyjZWpnmp6arO2bydd7nnmBoRVMop0Llq06RMdP1NuWYwymy86sb6n1FaPQ0eH6s9vlVw5zo7t+OJiqk=@vger.kernel.org X-Gm-Message-State: AOJu0YylaXoOXXnAI1BcjZDb0Y8epTnfzEdhbV/ljocJAnvzQl5QHK1G Y14NkSWw8QYFoxcBlAUquQe2etIwtbq1DoAloTd36VnrK3o+274ydFmH X-Gm-Gg: AR+sD10VAmNPOjpGWxQ3rEiCSYT32pagtSZRbcgfzNituFbDqVkf1hFUoDLLRPKUnO7 5OTjT2z1OirMxioqYMv06bZb2OPKoCGBhyCCGYzuaLKs5VQ6nrhhiOniSqoXu0I1lBvQXzl3Z9S h080ph1yziCahDgyWD52ZhIPnsv8YBAK9YCroxS5bcOsnbzB8RIqoi3Qg5rKa3VhYZdFq4czQCI SkarIirDMQWjPPyRfnGwUJB0WMWlKXAqdgEBZzevam5TvwwhRDCFV2zbrs9zc/BLUS/+9+6AhPB SUoBeZcC4ThsQvlt/Ii0M23nKyhmijqZO2xu0n3FvdgeBYl/Li5XtRJGRot3adk4634CogqezK8 /J1vISXwFG6GuzdevKVLn1hfs5XkNY4rLQRxLFKNta+ecWJoVszgGJTpo0SykYu8aWwIiIMV2fx lq6NbHDqfaSPFsPT0l3lpoRy73Ja7MP+GrucY+SeiZ/aoItAsHmlNsIYSKZyupHIf85X0Qzkn7v SDOQRgYkCkw0no2VrR03CzviIhuu9GxuP37HjS7HXzg6U01Y8tx X-Received: by 2002:a05:600c:c4ab:b0:493:aa0a:45ad with SMTP id 5b1f17b1804b1-4997842c213mr78119195e9.2.1786477364935; Tue, 11 Aug 2026 12:42:44 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:44 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 6/6] ttm_pool_mgr_init() does not check return value Date: Tue, 11 Aug 2026 21:42:21 +0200 Message-ID: <20260811194224.121597-7-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bug: ttm_pool_mgr_init() does not check return value in ttm_global_init(). Fix: Check the return value from ttm_pool_mgr_init() and propagate the error. Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: =C3=93scar Meg=C3=ADa L=C3=B3pez --- drivers/gpu/drm/ttm/ttm_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_dev= ice.c index d3bfb9a696a7..896b766712d0 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -96,7 +96,9 @@ static int ttm_global_init(void) >> PAGE_SHIFT; num_dma32 =3D min(num_dma32, 2UL << (30 - PAGE_SHIFT)); =20 - ttm_pool_mgr_init(num_pages); + ret =3D ttm_pool_mgr_init(num_pages); + if (ret) + goto out; ttm_tt_mgr_init(num_pages, num_dma32); =20 glob->dummy_read_page =3D alloc_page(__GFP_ZERO | GFP_DMA32 | --=20 2.55.0