From nobody Tue Sep 29 06:08:45 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD55353A77 for ; Tue, 11 Aug 2026 19:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786475692; cv=none; b=tQpjWKbXWXYkfbDja+cD5bBENCMs6/80hXk6QURLDrl+cR3v+eOBuZcZezIQEtikL9I1W+f7qfIJ/YCQ8Shr0rUpz3Jw3tYUaudaT7Nq+F3Ergsg6yVBPMc6oUkDsRmZDmXkOlEVhWCeucobZFbrLIfvoFdj557nb4ihAT0jY4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786475692; c=relaxed/simple; bh=gBWo9AyzWIeuNRgHzGN+F6t1VuZvIVG8Y+FNnHmWRlQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Ko8I59V1cLC2J1qRv0+fbQLoViUfw+yuBn+ahBtVwTmTv8bOaG7k6A7fXzZ2/1IxQmFAh1FizMEp9nYexEz37T7vvAznpHALlrTQZUm4F2Uem5eMl6jnyC3gVcaBLcBYg0mWkzPpdhrIiyT3BgGOPWtUDYXbGe9MRNJlPburKEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cOm7Rtp1; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cOm7Rtp1" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5b0148201fbso147586e87.3 for ; Tue, 11 Aug 2026 12:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786475689; x=1787080489; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1vfCosfGDgubIzMK4sWDVsbVlOYO+Vi0Sfhuvut6WsA=; b=cOm7Rtp1at1U5jVWVTHR3ICsPRVYws9VIyXLMvcbnWffCgsx4LGt6YPL53LE+QkGfF bA7e08KrneD/Cu0UQIPLkFDd7Gq7pSPcF26UswfI7Is1/3c7OuPuu0cLPX64jsfLt5fc BrIyiPhM5kbB+ak2zK70MyNO4TUv4cocTL3X3IyxnqxW+zaoM9dhcB0TrAFEI17cBOeo zkNlZ9QV5ilcynQilnflfLJ7Kl7f1M+HoJcyOqULhFQ7hS6w3fcmEnJjGzv9iUIRe5yi ve7AOYV/v6vY0cvB/bAb1Q5kN9A5aYblGkvAlKhYsvqZpMQhK+yf2HAdDUJqHUeu8dDk +IhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786475689; x=1787080489; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1vfCosfGDgubIzMK4sWDVsbVlOYO+Vi0Sfhuvut6WsA=; b=QyEvNJPrnv3hQxkBUuGveZnK3tYv0z/8yDVXAdxmMX9tYzyL1W7XezpA2EbgAXBSqc ajrC199LiebfAPnqymPiZCdvP+XXxjrFcCIDrK77AJnU5F4Q8LfJVDGdRi8y1kan6YdT 9lLxhV1L+USzhbW3ilEivV5sGTv3IbQ13shWYH1Er3gKskV6N1qFez4p0hNio08TYRsB gf8FWa61xyOVhBaMHHhz84YWPRK89X93UxJj5wl9AlX2KsJi7vmfFzhWJVJmT8lLGf5W ibX1i7xaXoJ2bHgTBDM2c9acVvYo1zqi2FOHJ/4GvJFZdrS+iAnJLuJxwhWwAWgUM4vT GbLw== X-Forwarded-Encrypted: i=1; AHgh+RqMEQ/ytH2m15dSTcK6iV3XYmn0GHBt0AR00sWObnH4XETsqNEMfwK/En2hX3jQMSTWS6/HEUcLBRJGQJU=@vger.kernel.org X-Gm-Message-State: AOJu0YxcjsEuZode/RFeS8Md9O7V89Q4RY+1Of/yQjlnCXydka5bJdh+ at7N0fEBuMwyvU67UCN1cwVEpblR+mmqcthyxz/4TGq251uZshK/tsj2 X-Gm-Gg: AR+sD12rvFCN+4BZkzAFO8c1CCsBU6EDbEZAVuoZqH6LIEsySGINbFCmTT7fo3ATpBJ JC/Stbl0fgWI3bY/5WGPABWcGHY7wwxCz1snRKoY3R6jNacUX2tZYRxSE4ILgc7kTNfmBMjnqa/ kqDpAxKljnxSy27hcazc6i/9qB0kp/NxiFszg6o/SYhLlUpPditt4MwFES1EZlHf47Kul9ZgatE PjnBsTG9ux040oSXC38ECcMhJnYQEt/0ABfiUYg1gzqROCtWVY20bdoAUo+Q3ey/7KGMiGjHHcV SdhBnV3QsXRUtlwBr2y/U3PcJCOh9ImbPKJZX+4AMeWtaWQMSH22h9RPdMmI9oaimva1sMmOdbW sbbeor/VgCkPVPVE8eNWnkO6BITxeeD8TWoZE+W/F10du/NjMz5CVHYovKB8mBcxCT/nxF1ifOs 9BPHmrwo5bQCaOOFgUnRNCec/vssWmxlGqfzip6gDy2bgsYo/vtbf39K29OLPkXnVhkeiXz67Zc CbjnBM90Lr78tqoB8Dam+I= X-Received: by 2002:a05:6512:33cc:b0:5b1:55a0:f7e0 with SMTP id 2adb3069b0e04-5b448641ca1mr825856e87.44.1786475688877; Tue, 11 Aug 2026 12:14:48 -0700 (PDT) Received: from localhost (host-80-73-162-2.rev.as20985.net. [80.73.162.2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b44cfc4217sm61840e87.28.2026.08.11.12.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:14:48 -0700 (PDT) From: Andrey Golovko To: Mark Brown Cc: Charles Keepax , Pierre-Louis Bossart , linux-kernel@vger.kernel.org Subject: [PATCH] regmap: sdw-mbq: don't call an unset readable_reg callback Date: Tue, 11 Aug 2026 22:14:35 +0300 Message-ID: <20260811184500.5312-1-andrey.golovko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" regmap_sdw_mbq_poll_busy() decides whether to poll the Function Busy bit by calling ctx->readable_reg(), which is a straight copy of config->readable_reg. That callback is optional: regmap_readable() treats a NULL ->readable_reg as "every register is readable", and drivers rely on that. es9356 and tac5xx2-sdw both build an MBQ regmap without one. Since commit ca1b11b36d82 ("regmap: sdw-mbq: Allow defers on undeferrable controls") the poll runs on every -ENODATA, not only for Controls the driver marked deferrable, so any of those devices answering COMMAND_IGNORED takes the kernel through a NULL function pointer. Treat a missing callback the way the rest of regmap does and poll. Fixes: 5bc493bf0c37 ("regmap: sdw-mbq: Add support for SDCA deferred contro= ls") Signed-off-by: Andrey Golovko Reviewed-by: Charles Keepax --- Found while reading the deferral path after the discussion on Ville Saarinen's tas2783 patch [1]; I have no device here that answers COMMAND_IGNORED, so this is a code fix and not backed by a measurement. It applies on top of ae7fd6ff4c67 ("regmap: sdw-mbq: Fix swap of timeout and retry times") and does not touch the fallback behaviour that patch's discussion settled on: a driver that does describe Function Status keeps being asked, only a driver that describes nothing now polls instead of faulting. [1] https://lore.kernel.org/all/20260809101541.4969-2-wiza@saarinenkoti.fi/ drivers/base/regmap/regmap-sdw-mbq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap-sdw-mbq.c b/drivers/base/regmap/reg= map-sdw-mbq.c index 6d7c760cbef2..b0312f57c980 100644 --- a/drivers/base/regmap/regmap-sdw-mbq.c +++ b/drivers/base/regmap/regmap-sdw-mbq.c @@ -56,7 +56,7 @@ static int regmap_sdw_mbq_poll_busy(struct sdw_slave *sla= ve, unsigned int reg, reg =3D SDW_SDCA_CTL(SDW_SDCA_CTL_FUNC(reg), 0, SDCA_CTL_ENTITY_0_FUNCTION_STATUS, 0); =20 - if (ctx->readable_reg(dev, reg)) { + if (!ctx->readable_reg || ctx->readable_reg(dev, reg)) { ret =3D read_poll_timeout(sdw_read_no_pm, val, val < 0 || !(val & SDCA_CTL_ENTITY_0_FUNCTION_BUSY), ctx->cfg.retry_us, ctx->cfg.timeout_us, base-commit: ae7fd6ff4c6713270d2efe6db87a4a58ccb7cc61 --=20 2.53.0