From nobody Tue Sep 29 06:58:33 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF3231D372 for ; Tue, 11 Aug 2026 09:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439175; cv=none; b=mG5yBniua2hLlMwl/j9z6V3tVBYkNgRozPJnP85Lj11Rr6YPODnWh+3FVtY+Q5VFyICTU7cS/Ffom+CtCOgvgg1BiRbX450yXO6oH6D/dLeNcdvaRbwd6/2eVkHCbcwZevJJ3pBCyAoZKkL05oWnkhbxNPjiRkqRfHAPiUQpYMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439175; c=relaxed/simple; bh=PuTYmgJrEnQxPveBP59x89dzsHEHg9UMpTyG/rFkWVI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rjOJz6D6Moojk2/6txAUxG46dJgp2g7Ogtin+JYpg4f+O9yHupgod5eHbsSveVuSaro2dN1Lf0Efl/7X5gnl3GHn7G8BLBFrjLNTdlw40Isgu8OJMxvsklbxuKLG8aHwRzDcQjtSrMoWl9RkvDdAlrhC1zwgyDQAnUPrJLXC5uc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FXiuiAwE; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FXiuiAwE" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38ec1402b05so2143292a91.2 for ; Tue, 11 Aug 2026 02:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786439174; x=1787043974; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ve/AxYf9jmTt+HISjsfKMmply9MP5YI1a9fhUjibAHI=; b=FXiuiAwEtu7XdqjRt64MUcACrqBOdSWaHGU7cVeM+E8Kj37WEUBWfNWv6/bHEIUZFU px7xda2O/I+yACLPfL4HUlNtA28mZBqc/ejwNPH9myqPW238jAsApdaOk7KBEKmup12p fkzmRxOL5WdZMsBJgPvBBLVu/PgktnNISg2sCekCwKrJHivJahP1UtoaRXwP+3VCfLv4 BS4AseRHMfICVPvhQNb/biWCYEvIiPccQFDqan+KMRnAQp6cOocZlRjUe+yQReZRpIEI 38VDhQAGYKmsHIBjK2zdkcEv3J7kjdg6zFmAqh+zse2cQAIYCijwDEPyJNeV60htqV/k Yxig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786439174; x=1787043974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Ve/AxYf9jmTt+HISjsfKMmply9MP5YI1a9fhUjibAHI=; b=TKM2De5qjAxuXsnjQrJtAVRVh1NdpZEvS3iD02Nxl18629JhtfKm2ieRmd+8QOewIE HTQCq6crFgcrdQxzT1nLbSoheuGPeRHyJM5p8QGL2g8qezdy/w4g1NF3Z9wshoyAJxAC JQqcUwRHxZJGyyFD2aAFAFVJqv3nW0CPITohtrpNfxil4obm+9yEDfeoLxYHOp+5/Bh3 elp0oI3/u3AMQAsjtNiANtydXQ1kHrOWX9zDy3VUwRhmRfEqKTTirxOaaEmE11Q2G1+z Gt8sjZ/qZIjXrYUsYsKigFDjeOiiqdrsf8BD5+veruuOwOx0teWXujO47xs0b4Db3ZVi w2BA== X-Forwarded-Encrypted: i=1; AHgh+RpAB+mOEcEdj9ywCrFYm+gGZ1ngnWoGw19nu0SNhliGKyHaXFtsa3XRd411OsStF26vZtI8bjOH+t8UpzQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzbfDMVWPe3F1Ikb4qh963gZ5YygSxoiUT3OyMcwaGvKD7G6m+t kWnwnGckWB6NTvX4xUhUxzqACF9dBfE2GfpU5ky6yq33yz5pqq/bbuU0 X-Gm-Gg: AR+sD12jso/YLcMt/V9tSAgyy0mhp+DJ2zNC4pmGwVV45MEKmQ5JSlNOrZvBu0oYFEV XknvNkypwsI7xBZE3V8Q2l7nAq/we9jq80eJ6yF81MR6Z9Bj6V5j9V11dNpcK8cNIGloo++kQ8x K4x6Q+VvaMxs0uweUIC+7Zno49isjcZxnOV0nkpryBmN2iJBlQ+b94X9kNhRcv/kdvMTFqKXn9P qcetgOzZ+VSckVoByO3REmD13TW2CGHx+lCpZykTPdjs4D5xkyneFwGUyrv6xE1YRP+UTbbNWrk cm5ouZMnmJ4yN2eSZinY3EPeFHeFCNVTO4Iif39isLMOdeDwmezX6OqzS7Hdcvye7jttFpBB4H4 VxMFV0Hh4aRr0jx0PMKCZa0Ev6HY+TIyfnVKsdyzeM/pLuXoJkOQ/Lb5vEzDnyaw0Hfdh0fOUoA txdw7WS5NSQkcLHlp9Bt9p/1iRiqPCN9238c4OOKynnnaH7WeTLxaumXm8h1+p/Ekm6rvEmiAlX tHYK0gsdPSWFpyo0ENS/zdZqezlT1EPZNdf6tZETsejvTtL5yS3BPstgkbhQJydNybUgU5dTcQZ pwbu/ykzxWn67SI= X-Received: by 2002:a17:90b:280d:b0:38f:240d:b857 with SMTP id 98e67ed59e1d1-392ec393372mr2078382a91.2.1786439174023; Tue, 11 Aug 2026 02:06:14 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392ee41936asm1128999a91.14.2026.08.11.02.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:06:13 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/6] ASoC: samsung: aries_wm8994: Preserve gpiod_to_irq() error codes Date: Tue, 11 Aug 2026 16:05:45 +0700 Message-ID: <20260811090550.38930-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811090550.38930-1-phucduc.bui@gmail.com> References: <20260811090550.38930-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc gpiod_to_irq() can currently return several error codes, including -ENXIO, -ENODEV, -EPROBE_DEFER, and -EINVAL. Return the original error code instead of overwriting it with -EINVAL, so that the actual failure reason is preserved. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- sound/soc/samsung/aries_wm8994.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8= 994.c index 6db91b73f25c..58e3e08225de 100644 --- a/sound/soc/samsung/aries_wm8994.c +++ b/sound/soc/samsung/aries_wm8994.c @@ -374,7 +374,7 @@ static int aries_late_probe(struct snd_soc_card *card) irq =3D gpiod_to_irq(priv->gpio_headset_detect); if (irq < 0) { dev_err(card->dev, "Failed to map headset detect gpio to irq"); - return -EINVAL; + return irq; } =20 ret =3D devm_request_threaded_irq(card->dev, irq, NULL, --=20 2.43.0 From nobody Tue Sep 29 06:58:33 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B3A04248D7 for ; Tue, 11 Aug 2026 09:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439179; cv=none; b=qIkGBdTIfwqY7EQx1h+Sc5lq6cK8FbPgghUMzWNvu9vZzFzHa+JUOtJgQFwXqWpeI0a2lELSR9wCxm0G+wP8cA0edEhblW0rJ0/CSvGaVmvasEnzExHNNFsbYjiZF4n664O5QzI6Ys8qkLqBvscVvD1aNx5j4SfWIJYczjVF3C4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439179; c=relaxed/simple; bh=BySdOifFf8Y6zuhIPQKfV05XjhOObYj9M6tyXBhqX1s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b9mvM0QE38D9BJRzvWhKEjqU2wDNvGjPai6b6DMVAq9vyUgUOHDUWPP/sfgS78Q2XBVV/8WSswkHl6c1xg3MauLLVQWFIX2St3YU5ICLU4T9fzrPgdrdxrKZi/8P7CkbSVLFIIs0woLdgGtCgyjM7mrJZWfx4AqLpTDiiKeebK4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WhLmimbv; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WhLmimbv" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so2367772a91.0 for ; Tue, 11 Aug 2026 02:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786439178; x=1787043978; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hD/iT4iwK6mqdxyxeSvFzfrctiLQS7TKv4VcHOqvJ5o=; b=WhLmimbv4uDsx2q78nBqwmjU36fRIxHbH5w5sRG2bZU1jxA2/VedbNIUrZl2LfxkSc ykPuDaD/IxFY4tE/tsO/DCQWgznDQDqozh0qTCbrUSfBbOYktEJECoY6Dzl5oxbeOBYj nAdZrdZfDJ2klkg/PdHEkP+dt8DUjpaNkc6vKjiGNX3k2l+99nQifqRYcWxka+Pf4uZk ru+aecci7tlCllHJOR6mcTohHPcFgM65RnIYX4GDFA+anUU/z3Bqn/2okEAx9qTKN8No JySVD1iIXPW5cA9YTpiCGGSlz4s87JnAD9jowyIE4nRoc264xTDgMALgqiHiWpjaJ44E sTZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786439178; x=1787043978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hD/iT4iwK6mqdxyxeSvFzfrctiLQS7TKv4VcHOqvJ5o=; b=p3mm2xI0f+85O6kcyXTHluh/5R/6+N0FJSo7NfGTg1SrK8Kn8Wb7ZB+7wINidr6bCI eOk8MJ/teUFPIFe4cnmAWWbCcfBHM3SQT9suloeXxHXhuG6Ep8k2o3A4vPzqhwg175OF Zvbi5KqhSRCmnSEG1Bmz/khp3XyoT2ibUtcgYVQmcM/EeO5DZEedP5gp7C1BssIqGTdl +YkChGFM65e7b2xu2IMUPg8Kn52onOSN8qIyDFMsBtqFC7WassTZPy3NRIAX2TZmIzdY 9YySjR4rloQyaGtY1/XpZiqoBlc6fioJXzn0vVdhJ6ZlZYaTZOz0r/ZNcOqcL5K0+vn7 ujag== X-Forwarded-Encrypted: i=1; AHgh+RrrBDGD0ERvJM/+/gDImWI66w4+1//sFePFyOTWmekS3jPdDp1wxhTbeOhZs1be8IcE6k8F05N4sz/XCTg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/EbtMts5RztTRXh2uR6pGUaselyl5pLNaqBO9S/PkMW6IJxcq 53+/jaZuT5wT6uNtMUMvxsdLv5eD7BAIyAiK/PAiAOACdF3WOe8JzNfS X-Gm-Gg: AR+sD10dUA3qpDf3jgbtmzpOlMHk7OLtY6q9NK9TAypbB+7HuYUPW5Qu38LKa3MtC9q sHgx4jUjzf/9yBycvzbHZlGq0NiVN1IEDLVwyuRCj6jp76ATg0Frn0d4oomqdWKrzyEOOGoyGU7 78ylztSUPi+YeLc3leLUu5098go4ezgRkM1QJBsaDkbPrqOso7IOe0rMySNqxpfQsBjnsOiQrz1 q9/Hnq5p0RJnVfFETZK+xEkjEVvs6p6pjJHoKMV834miL1i03FRqR+eCzKY+yzvx3v/7Hdvz8W8 zif3VEy7XWk5trBfn37975JWyiZnOdzhbMI+Nq+iDD25YehMWj6ewVB1Vhvky76raB9A4ltmaMM Gb9kpllQExHywuzGsRilDrjnWeN50ddXQAhUyE82b5vQZZ3yaae9ZfrCuKp7r/yeB1gNA6oWmpc rNkgsKllek+wG1Fin4EBDdFXSnNUik3Zq3jpwc8V/UD4B4DLdNgQS0AJ/b5L1+A+KMrt++qoICU zgT2nr8u7/fO6dz0+wQ5BnTg6v7i4iXBtkg3zQ1xP707prmYeeDgglMKd6YJVjTB/s9jY7T2WNJ IETH X-Received: by 2002:a17:90b:3bc6:b0:380:f389:447b with SMTP id 98e67ed59e1d1-392ec5b6ac4mr1829394a91.11.1786439177663; Tue, 11 Aug 2026 02:06:17 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392ee41936asm1128999a91.14.2026.08.11.02.06.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:06:17 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/6] ASoC: samsung: aries_wm8994: Drop redundant probe error messages Date: Tue, 11 Aug 2026 16:05:46 +0700 Message-ID: <20260811090550.38930-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811090550.38930-1-phucduc.bui@gmail.com> References: <20260811090550.38930-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/samsung/aries_wm8994.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8= 994.c index 58e3e08225de..d189db96cf17 100644 --- a/sound/soc/samsung/aries_wm8994.c +++ b/sound/soc/samsung/aries_wm8994.c @@ -381,10 +381,8 @@ static int aries_late_probe(struct snd_soc_card *card) headset_det_irq_thread, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "headset_detect", priv); - if (ret) { - dev_err(card->dev, "Failed to request headset detect irq"); + if (ret) return ret; - } =20 headset_button_gpio[0].data =3D priv; headset_button_gpio[0].desc =3D priv->gpio_headset_key; @@ -623,10 +621,8 @@ static int aries_audio_probe(struct platform_device *p= dev) if (ret < 0) { /* Backwards compatible way */ ret =3D snd_soc_of_parse_audio_routing(card, "samsung,audio-routing"); - if (ret < 0) { - dev_err(dev, "Audio routing invalid/unspecified\n"); + if (ret < 0) return ret; - } } =20 aries_dai[1].dai_fmt =3D priv->variant->modem_dai_fmt; @@ -671,10 +667,8 @@ static int aries_audio_probe(struct platform_device *p= dev) =20 ret =3D devm_snd_soc_register_component(dev, &aries_component, aries_ext_dai, ARRAY_SIZE(aries_ext_dai)); - if (ret < 0) { - dev_err(dev, "Failed to register component: %d\n", ret); + if (ret < 0) goto out; - } =20 ret =3D devm_snd_soc_register_card(dev, card); if (ret) --=20 2.43.0 From nobody Tue Sep 29 06:58:33 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F14422E35 for ; Tue, 11 Aug 2026 09:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439182; cv=none; b=P+oaVIeFbpKnCvbI3ezsUJq8sAJtTsvF3X0Hw3CiHOK+gOX/G7c0clKw2jnhF9FUde4WGShWbI1TIjFMYZwoBuap+cYR8ZBws3UvHzDcH2QeSKtIqFClVFVKNV3UAdLu+egpYwIoHXfoPksC17vMFqK6WOQxTfGeZSWXYLPb62I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439182; c=relaxed/simple; bh=YhVJo70jkulbyd4wNCcrK+71b5/22m+Z4P3D4l5sVnk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=edvldFBIyl8sHqykRZKyVTU9ZByUMCKWA50MrL6hZOG4NAOP43UjhJ1OkFbuUkI7jnl7NdfeD7BkROyzcJhvZvJy8AG6FmB7alpUtWGu3paMSbfpUghrFCrQCV6EO9I6S+TGBYmHcDB+u5yJqcqMikjMAT/HPEE3lQGS0wQD5wE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HlW4RWo/; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HlW4RWo/" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso3384169a91.2 for ; Tue, 11 Aug 2026 02:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786439181; x=1787043981; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iZA/PnHaNXH4Xhxd+45+XSGsTu7F85iYW+CAMfYWS7U=; b=HlW4RWo/0PrhQmvbQHBAGZYGc6gAUiFfrryiMve8E0GvZX877MYVgRvQoLiTEIX+1A UoQBr9ywY/eVjsAfGvBVgCj0rG6od6uDk2qrz5aq+6iyfb5DMej/UddVNH4+f/SrQzim tXLe00UpMMcwWXh3enZUw1Co9k2rJxed7zz3cyD0hpIo0dFV5ZJVt+zJww5XXRKCd2iQ wbMAMGeuQnWq4maA3sEzl54YSuNqxW4jrnI+jLkoIK5B84C7q0PzJtdbzjFRWZkFtYuz kzFFGsWQ75iQ725kKAGh9qQozEfBidB42iIoNnAbosNc7DwOGCznLoyrNS50Fla7pbzo dHmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786439181; x=1787043981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iZA/PnHaNXH4Xhxd+45+XSGsTu7F85iYW+CAMfYWS7U=; b=o7/4wAJZ52+zngbTPSqul5sthmtvsH8YP7jCy4nVp1XopzkbnrklIXaHeEYK3PYjHh vgksqI5UYTPWT6CUnoQiyXk1Irx6MWeTEYR6YdlQAj7x7d7mX8WUhUja7R1VP7crBp3A KtjITqoEYOt1pHXfnYMr8CrXXmT0g7lt8VXnCUHKGEfOZPzXbGuXB61NxV8zk+crxEK9 Xe5K62g/XJCs0wSzNjwVOZ1of67B5Gb2FB71IHWBm1cf2xP1IMeLwmQFvAN7n2GKaWkQ VhcDEIQ+epuJEBDn4TIMxVuye3/CT/giR21qwu4eQPLGI9e/ECQWtIKeaC2dTw5qu/Ki R/QA== X-Forwarded-Encrypted: i=1; AHgh+RresZZ5gv1Y11K63ZOtCotr8CnLCZUrecsvnpkLNqrqOJfEQoj/DMLOhwSCPfBrYhHCFvf3+v3ryzzWtZI=@vger.kernel.org X-Gm-Message-State: AOJu0YytXm34LSunQJAD6Q7tP3od6a7/NXXLdR7LFfksN1oG0ZsAG/Pi EZUG5RlXPIk7Gh+jdHwr6fQabQ0cmBhB/jUlRo14AJDTyE5J2F72fUwS X-Gm-Gg: AR+sD12SKzTH5gySqjRhUFaBCkmJF+NDvZ01PgKfEs1fIYj9BS53UDHh9spZeY9eftj NGWBbbkVDeMvenhA+UCg232h8Cxykm4NzczRqeapE86z185bfId4xoyYKlvyXGt7kzz0IjfiJvi pyxOXq3Z2PR5U8kPdQBjRApG2bku28xFdYIFq3VmIgV8QvtGtYUkbkFt0LxkNRAcUpAUD2P9Uyf A9Llmn5ImOaBDr1VnSBCMo53t/iOcWUjNgAIWp4rHR87amekw+xSqlKrzFliuTrd8UOnyRnrZPy rykKe/OELPGx+LlAN4yeL56hICw3W362RaVPwvg0ZtYBnuTZ0pIk8HhkVycIhTTKKMKzY1/46mr 6pCLEdZ2sswtEA9Rv+YfpAjjdnraGphR9tgS51ZI5/82CmLrmoKghChz+LElR/5NKn7Swgh0bQS qHQ6MJ2bIDGaxccpPoqqubyS6t2cv5XUF/V7xeI3qpWw9O0TdhrfqQ+cbMuQBDkNJ9rjmAoB1wZ f6vobP6cOxYpU/vBckqwH3KcyQTWminyZtCPaNwBCnJyTTIUK4I9rnnbOiQi1b3rcghAJZ8d494 uLuP X-Received: by 2002:a17:90b:3fc5:b0:38d:dfd1:7a8 with SMTP id 98e67ed59e1d1-392ec3a8b23mr1791896a91.2.1786439180873; Tue, 11 Aug 2026 02:06:20 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392ee41936asm1128999a91.14.2026.08.11.02.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:06:20 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/6] ASoC: samsung: pcm: Use dev_err_probe() for error handling Date: Tue, 11 Aug 2026 16:05:47 +0700 Message-ID: <20260811090550.38930-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811090550.38930-1-phucduc.bui@gmail.com> References: <20260811090550.38930-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- sound/soc/samsung/pcm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 309f024bf2a4..7e7284125c3e 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -499,10 +499,9 @@ static int s3c_pcm_dev_probe(struct platform_device *p= dev) return PTR_ERR(pcm->regs); =20 pcm->cclk =3D devm_clk_get(&pdev->dev, "audio-bus"); - if (IS_ERR(pcm->cclk)) { - dev_err(&pdev->dev, "failed to get audio-bus clock\n"); - return PTR_ERR(pcm->cclk); - } + if (IS_ERR(pcm->cclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(pcm->cclk), + "failed to get audio-bus clock\n"); ret =3D clk_prepare_enable(pcm->cclk); if (ret) return ret; @@ -512,8 +511,8 @@ static int s3c_pcm_dev_probe(struct platform_device *pd= ev) =20 pcm->pclk =3D devm_clk_get(&pdev->dev, "pcm"); if (IS_ERR(pcm->pclk)) { - dev_err(&pdev->dev, "failed to get pcm clock\n"); - ret =3D PTR_ERR(pcm->pclk); + ret =3D dev_err_probe(&pdev->dev, PTR_ERR(pcm->pclk), + "failed to get pcm clock\n"); goto err_dis_cclk; } ret =3D clk_prepare_enable(pcm->pclk); --=20 2.43.0 From nobody Tue Sep 29 06:58:33 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F148D4248D2 for ; Tue, 11 Aug 2026 09:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439186; cv=none; b=sjQ0eVSDSN2xinY9d4fruXHa1ou/FhGNwJPvfAl4Bop+kS9K278DM4aq4lFhbkXtvYxVksLNYRQ4wld7kvDpW2ENY/FwGQNu/wZXp5r2ikSOS8ZCJPJvbhn7RRh+1P43p64NvFSUPMhnjqv2OXpLcfBiryKKhc0bNDiQKfDwgIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439186; c=relaxed/simple; bh=DpUKsaHZ5eP27ej6xpp9j7hdepW2/QcJqeiu5sg8GU4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I6+scNifPoOc1iRHKBR7KN7GF9mQtDfua/sD+/pylsLF4CA0T6CZx+qm6DSX5OubT4b6Z8AyYEzgu/6UPrIyUSy8B2MRWZyWOwEEEnUKNPCzpTcx2SRLOmO6I6riCxIBgn3ClUNtXA7Rovd5VgWP5w63cFhD4P4iKIKI3D76jak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lhJnMKBi; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lhJnMKBi" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3811f512167so3936550a91.3 for ; Tue, 11 Aug 2026 02:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786439184; x=1787043984; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A4yof5CDWnwWSYe6G3R74LbfCCdpQ9nNQH0CPOtEBsI=; b=lhJnMKBiTNr4HAytrZVaGgVmSuxrFR/wD8k1mBfP6bEVCdy+1k2Yv6MLFuDXpBPL5+ SUis25AK5wwAR0vVGhqZ8x2wUD834gtmATE968eAJ4tizhQHzM+xZpIrA+rwXJRMr21A BwDLBRxk6oYGc3MKqnMsuVZ9cFrxLLPw9twlw2+UZ2KCoKbxKAC9hbAhsgRFaXzWEQWU vcmEIPxG3iOF9WIZpnIyZ2zMi8LZL5uHV4XDf7A7Yc+R68vNefoaghlKRaYiCa1oHtgZ CfMDhHhUGttPib9P9HbBpglGwJ0MeMwYsZb0ap5RAMtVcuLXtAYb0dkgDwZ+0SFlXvFx ifpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786439184; x=1787043984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=A4yof5CDWnwWSYe6G3R74LbfCCdpQ9nNQH0CPOtEBsI=; b=pGFOo/vQg0VIxNb/8kpR2wWKgNOG7GNpOM1KswSynzssfNKCy6mKioespZSmVA7cIh GP1+HKabBfydIU6Ed88tgd+wGWehSl+q6bLb3PQz694wMp+qzVrcWZCCrL6rUUbTzgMi qV4VAzBH8hvm0YWvs1dNs7MTVo4S9QOtHsNJzbLgMJjtoyVoYq6897bIzLBTCjBX1GN8 zkVH2o1scyzxaVLCqrSU6/GwBoQN5HiGYrvvVWTBMe4f/yl4+WMm+qJalTWWo0OXWEWc OywhaHEBV403hjTYHMnxpvdovXxkURoAhTX9xl3ctane0evw+qFyYFXtbKMvo4MCdwh+ oe5w== X-Forwarded-Encrypted: i=1; AHgh+RrwI97laswerjbrhODLqf0Ei6G7dUf9VNiJ04IZU2v4cbVIBtpMrojEnxeGXFtOthq0QachyabyiSlDLPo=@vger.kernel.org X-Gm-Message-State: AOJu0YxksHGRWFiiySvEmMdgMJPQV0Kx7JrRmvdAsSiTHri94BBEOQdn NEd1XmNpldxS8xgiPzWe6QdzycvBCTheggOWt9thEm078LlEAQW5tzoz X-Gm-Gg: AR+sD11aKIjdcVasg81Rtun2B28RWp23jxxncU+ws1hvYrj1Xo7CSTBUdh40DZNZRFY wGF67WP3PEb9wF7UDulvq+BPZatJk0dI0hh2YVSbMvEvdZZcNl6FQuas16JDIB2w3AMuHYB9iGE usm50u5f8nGITpQUuwlE/+kFxAxXU46Vtwb9HquN/+Wh7SvY0/I3Jhgvksj62ff5B9wYbec6QQy Vy4dj9WEfHl82HDsDEF8CAIlZw4R4EGOfffb0ca+NBQfPuTtJ0BaGL5Lcg1aoSn88FMhY0h1ybq ZgvyGdelZWfFeUZtQ3vgja8ebATgK+KAMUkRlaV6Z8HJxVBY7pJmx4umEkCxH8Ps2kGUmjtBvll k81H8xDBWRAcc06IA51HacD0Pwe6LW1nnjAT+2KP+tcnw0B4OM1Hpk6tGv2jNGDbnDvlvkStagn 5ZS3TlkM905Ysg90DDl4y++2Xvn5/qKbBl4WR41N4NP2T/NpZQqQs1A4cDk+4rJT1Gn3+k/42B2 Sd7lofSALzinAh5clqjflnBc//z7CL2qY0IN9dcU90Unrk7BISZMevjmzc1GptJUOlkhGJCQw8u Ggf3 X-Received: by 2002:a17:90a:d004:b0:38e:1497:af5b with SMTP id 98e67ed59e1d1-392ec2fc2ebmr1983371a91.1.1786439184090; Tue, 11 Aug 2026 02:06:24 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392ee41936asm1128999a91.14.2026.08.11.02.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:06:23 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 4/6] ASoC: samsung: pcm: Drop redundant probe error messages Date: Tue, 11 Aug 2026 16:05:48 +0700 Message-ID: <20260811090550.38930-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811090550.38930-1-phucduc.bui@gmail.com> References: <20260811090550.38930-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/samsung/pcm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 7e7284125c3e..8430686760d7 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -534,19 +534,15 @@ static int s3c_pcm_dev_probe(struct platform_device *= pdev) =20 ret =3D samsung_asoc_dma_platform_register(&pdev->dev, filter, NULL, NULL, NULL); - if (ret) { - dev_err(&pdev->dev, "failed to get register DMA: %d\n", ret); + if (ret) goto err_dis_pclk; - } =20 pm_runtime_enable(&pdev->dev); =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &s3c_pcm_component, &s3c_pcm_dai[pdev->id], 1); - if (ret !=3D 0) { - dev_err(&pdev->dev, "failed to get register DAI: %d\n", ret); + if (ret !=3D 0) goto err_dis_pm; - } =20 return 0; =20 --=20 2.43.0 From nobody Tue Sep 29 06:58:33 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D0C4248BB for ; Tue, 11 Aug 2026 09:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439189; cv=none; b=TGNS8uGAbx/Rf175DJI/8aizGLqyuMCl+x7GXA+RUQmyFPUoAPjfUE3Dq1cF8bdRTgFoHsMzbYXb0cieG5uuMxwW0Y88euPagOb7VFeY2hChOGnZeFsIpveYYpVvRMoa2I8z7VYIPQQ2aP5Mcj2zJaz184snR8X6n7ceKgrdMkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439189; c=relaxed/simple; bh=NUN9c84wMofpIprFRnCda8aqoz5pVig6Wq+bDcU9FTU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lD35UVXt4YXThQsJozLWDP3bxBVy7H/5JfzAGTRu6H3CzK56NVssuU4wZpJT1HHx7MOmKLCS8kRMkMNDOdEntyypOOrifP74OEN33cY9Ka4ERqnG9TS8vgnUIr2XFweaBtczG9qvFgI4TNj9BLBlIFcZ5k+XG3Mx3GVKOkW1zbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UiSNmAy0; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UiSNmAy0" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2cfbbdfa60bso24923995ad.3 for ; Tue, 11 Aug 2026 02:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786439187; x=1787043987; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZqlDkb8lVI89Ppp6MgURkz1R9mD8bz5ox4eMgoIY4X8=; b=UiSNmAy0RCPqqAHJ2lcllS2sqAIOSvImo5XNk6Vqfn8XBV0BWfU8K/4oHR9r4u6RpZ w8SJgKfhqK7dQJaxVe6GvTbCBbLPDmTAREIxJbOMDg5ers4nORmW74UWz1cWbS44sHKw sn2mlthaMXGr42eA8OKMkR+bU2Hk0gkGjfz6rCdSWxz3NlKKnxmkz28lbRpYnmTBpMJS 4rP0ROmcp+luErfDWK/pmMRKWPySY/i6Biynsb9Xbmy8Mr/qOZvZVKs5ja6eKX376brz CH8uBjFSUWBlRiJNdKiTtjr1CASz/z4FKE3QrSaZ61CV8qlrpDVa28nCHf9beiASqfCf sY1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786439187; x=1787043987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZqlDkb8lVI89Ppp6MgURkz1R9mD8bz5ox4eMgoIY4X8=; b=KaKG5ORTI+KXbV43IDa2/TDXiwJI8SpO7aXyuYO5OX13BYjCnHHbkh741kmHVruO7e /+wmmvbB/hta/ZwfQsMPITTi4boznDaRvUGBkFdcr2FlTpC4zWpadp9eYL//TnfTMdIc s3H7h6CfvRUbajZ3K5fqVbbThsYJ+0CmQdWoGrKP6Nnz2gSe8E8h3R05ck49vdaJJl8X lw3J0BG5oboXJbIhHyjrIYLw40j+Y4C657uINNC/VYMISA7iCH+vmN2JYJTOuGXo94mZ xLRLbUoAGXtXYc4PNy/o79j/vXdxddZy30001K4LAmKTuZfqWcJADX0CxKgngLThuDYt x6SQ== X-Forwarded-Encrypted: i=1; AHgh+RrdgpgCiDqffeeJdzYhOCJ7IDPtqf5u/c6mlYjJfYywMVLMs7f4iykEQyRWyr6HuvvZVoufLJVX+lnZEe8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+vMvABUY4bmO6O045UQq78ce91TgeUR693p4yvqDazQH1RfLj u4UvjI/zKvf2wj7ExMNg3u0OL96QmSVXTO7+g+DxS5k29S2Xt9tiIzsm X-Gm-Gg: AR+sD12i1kB1mIAObZ8RF4A58dJd5HrANGaZAb3LzYHSFfEWyWFWrJjiHxTGLHW32WZ 2FxUlXs5UoXyjwQEwyW6NAG5pmsdGsO/JxJGQjSxATgv7Wd4oXB0WI/ZQSQsUGbvqG9uy+74Fdy B7WufHK5iwYGFgEv54cVWuOQC+5mV5Wfp4tQQ2Ity9YH2JonF6F1zIdOSnjZHUC7bE7OHXCE0nx Nhz6gyrNIcJiaQ5KQZ4LIA80NmX3H+UpUuzYIrdoz1AGY8/C5P4b4G/hFL1wHCXpk3Hjx23xzaO rhw9ym7RSyByF0BzqzdOq7nJDOoY9+0hdx6prO0ufKSoD/lZOQNe5ddNx4vMI3hQqPE668PMco2 0C5RMbbLbwXuPgH7thYN/hipZUVclismDqJuBrhAvaXGwwax1tiq+xtcaNNzyIWvC/oS2PWE7iT 122gGvpLmDsbo5+Xq3XMBsZVrATk+8Y52ZZRySpswkJzVjwRjD8IkaShWC/ThIYHXx8JCpNvCIW jJCWCKKDwISzEMJaETL1wb2SgiD4zXFNm4sPyz1BAWzk8SoSl7nagGikwfnEiPestQeTerB16p5 mFwSwRzAkrTEOJOh X-Received: by 2002:a17:90b:28c3:b0:38e:c232:9d3f with SMTP id 98e67ed59e1d1-392ec357ddcmr1780816a91.5.1786439187322; Tue, 11 Aug 2026 02:06:27 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392ee41936asm1128999a91.14.2026.08.11.02.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:06:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 5/6] ASoC: samsung: spdif: Drop redundant probe error messages Date: Tue, 11 Aug 2026 16:05:49 +0700 Message-ID: <20260811090550.38930-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811090550.38930-1-phucduc.bui@gmail.com> References: <20260811090550.38930-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/samsung/spdif.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c index 53eaabaf8956..719083e8e89d 100644 --- a/sound/soc/samsung/spdif.c +++ b/sound/soc/samsung/spdif.c @@ -415,19 +415,15 @@ static int spdif_probe(struct platform_device *pdev) =20 ret =3D samsung_asoc_dma_platform_register(&pdev->dev, filter, NULL, NULL, NULL); - if (ret) { - dev_err(&pdev->dev, "failed to register DMA: %d\n", ret); + if (ret) goto err2; - } =20 dev_set_drvdata(&pdev->dev, spdif); =20 ret =3D devm_snd_soc_register_component(&pdev->dev, &samsung_spdif_component, &samsung_spdif_dai, 1); - if (ret !=3D 0) { - dev_err(&pdev->dev, "fail to register dai\n"); + if (ret !=3D 0) goto err2; - } =20 return 0; err2: --=20 2.43.0 From nobody Tue Sep 29 06:58:33 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFA34119E5 for ; Tue, 11 Aug 2026 09:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439193; cv=none; b=pmhBapELKu4N6smPwFt+ssgnXj2jHDnfe0ZmZNB360gq3uASjEeG83kuw1yfDkOc6Z1xjXLb3HOhA75YFf+DsqbT3wdOoM6EDXcVRQVBZ1dlQrdDspSqxZjYddj6kW9fSjFpe9rulfhaQJwxzCy4Q+X2Xq4wvFUgk8zs+2FhOvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439193; c=relaxed/simple; bh=4mUojggEy1knp1MnY+PfbTcC4djrvXzQSYTre0uaYrM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Onvf7TSmkeJFqYeua2pqV2hzp7eDRIZwlsPDQab5r1kfdZfAM8cvqoEbE585rBg4piO1J6x007DD9H2HEvV4HuPL9Ami+sS3SSn3B3D3hSJUeGKO20HD0G9LPrkROPU+r4O5wGEqhl762l5GuNUAeUXSrsG1q+imAqtT93McpNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fipuMWcP; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fipuMWcP" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so2367903a91.0 for ; Tue, 11 Aug 2026 02:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786439191; x=1787043991; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zfzZGWrbIuaZkYm/++FY2BeY8xbOOs6ZKnXqGfLmJ+A=; b=fipuMWcPupOK7rrlmtLknwjIBsLUww1pt7q4d+Ku1HDee+3O5AR2bq8qwGUSVzjW0Y PjzytUGhxe/xUq1Gc1M8zThbeZzPmnUnsxyOGgzAltmCsfyIs0vdA0sGupM7cQeprZsj fTJACEHm/xICm/oGL+Q+4/ORSHciaLKxpN6LVGAKWRIodTYN0Vl+Dqv+Eksz7VKXt3F1 tU6ZUGQZjibrKrpG9gF6W+h2ylMuaKgGzA8WQfAG/DOc14p0V05Chl4K0zIpFytCA1EB ihtPkVwnN6h6o2608BDnHWuWmhvP9kpnMrDRtCDDSkRhKlZbVR3pRVXLpt2ggbBCLmB9 +BBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786439191; x=1787043991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zfzZGWrbIuaZkYm/++FY2BeY8xbOOs6ZKnXqGfLmJ+A=; b=W9Z3WkORaWdHGhg8YSfyC+a3st1Avy1aGd9OBrxdmZHC4zbpuyUmER7xywwPG8/oMH Mk4i8wc2Zd1v730bJ2JzDnVPQPhfbl3BFxNO/qswGYxGw/QLKIyTxz2SMac6UJbaXg5K WwxFOWnppBiqRuIrOuaF4KnfrmkIdeTDiCESxK2pnVAtjbM2Dca21o6wNYJjSfBzFuwE sZbXeHm4tOMFuTDgShnnDKZtv+m5CaB0x6+g+1ULaMez19YYAHIeU9o3wbxmEWFLxE7h hhniHyOQ0A5HhvDZTrHoerJfPEwBIlnVv0XzkH+giNa6f6lbTyAcN3aVz0WP5S6tk5B2 Pxcg== X-Forwarded-Encrypted: i=1; AHgh+RpC7GtL7EUdtNY7VPMhIE9khwhKOaZ/kwLoK5tIb+JSe+GBc7niO3B/ZjJnLhLVpBu/ufabaCVZYqt49u0=@vger.kernel.org X-Gm-Message-State: AOJu0YzENkVMvvvEaislM7D6CCcQUofoNpGPWy65WZNgPokU51zUV4A0 9VdTHK+PE3OYaB3ojQg5UKzD/J25L3e4NKHIORPDi/QdHWtElcXwX22O X-Gm-Gg: AR+sD123wCOO3kaKPFhhkmsg7s10gYAZ0heda1/n+oqG+K5uCJKuyx9X2JmZHWqEh5M XAuinXhsIuzAnVqYq7hFUW4XPLIn6Gcj1xdsI1/5qXFi2cd9kLXUcE/bmzzO+wmUQRcyxJNQqxp GAXzSQLA/5RXJbxc5LhlXWCPtz7XwzaxQAiZVAt28GWHhVda/6ebMjIgpa2QChOWRmtckYp0znE k4RZwyo4fT6R2CY55oU71blWfQT9Fiptwk+FcSPc5ELRPbWLKx6agdw6kxRj9zpYZIMkzOtD1PI H0xdTI82v0qTZ2yIG6HJx8ck6IpsoaLSfRLu3Rsc0ROBLlHEfoIAlRCJIZn9LZCM2DO1ZWZ858C E26V8PxLo7wxnaHMgiChZFpFnxtkj/TyuUqiuPTnE2nRMSJTNiDN8Tdn9eRSuoXK+Us7S3Lxkei ynfCHa+KW8ebFi2aVjhX4SFTFQ0+N+2M1j3vajeA/FEIAzKLFBNhzEqdhn/UgCZAtC4jlgzH85s zwyGWLI9N9/gjbhyE8wtnash8ig1M89uTj4t9bGNglcq0UK8kyO3bDAOKh54bo/d2IVC7kPJv8v bUPt X-Received: by 2002:a17:90b:3d92:b0:38e:59c2:cbc5 with SMTP id 98e67ed59e1d1-392ec73153bmr1690736a91.18.1786439191056; Tue, 11 Aug 2026 02:06:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392ee41936asm1128999a91.14.2026.08.11.02.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:06:30 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 6/6] ASoC: samsung: tm2_wm5110: Drop redundant probe error messages Date: Tue, 11 Aug 2026 16:05:50 +0700 Message-ID: <20260811090550.38930-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811090550.38930-1-phucduc.bui@gmail.com> References: <20260811090550.38930-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Remove the probe error messages to avoid duplicate error reporting, since the error is already reported by the called functions. Signed-off-by: bui duc phuc --- sound/soc/samsung/tm2_wm5110.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c index f1f59e059f5d..f4912826dfd4 100644 --- a/sound/soc/samsung/tm2_wm5110.c +++ b/sound/soc/samsung/tm2_wm5110.c @@ -518,19 +518,15 @@ static int tm2_probe(struct platform_device *pdev) } =20 ret =3D snd_soc_of_parse_card_name(card, "model"); - if (ret < 0) { - dev_err(dev, "Card name is not specified\n"); + if (ret < 0) return ret; - } =20 ret =3D snd_soc_of_parse_audio_routing(card, "audio-routing"); if (ret < 0) { /* Backwards compatible way */ ret =3D snd_soc_of_parse_audio_routing(card, "samsung,audio-routing"); - if (ret < 0) { - dev_err(dev, "Audio routing is not specified or invalid\n"); + if (ret < 0) return ret; - } } =20 card->aux_dev[0].dlc.of_node =3D of_parse_phandle(dev->of_node, @@ -609,10 +605,8 @@ static int tm2_probe(struct platform_device *pdev) =20 ret =3D devm_snd_soc_register_component(dev, &tm2_component, tm2_ext_dai, ARRAY_SIZE(tm2_ext_dai)); - if (ret < 0) { - dev_err(dev, "Failed to register component: %d\n", ret); + if (ret < 0) goto dai_node_put; - } =20 ret =3D devm_snd_soc_register_card(dev, card); if (ret < 0) { --=20 2.43.0