From nobody Tue Sep 29 07:00:07 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB004386C37 for ; Tue, 11 Aug 2026 06:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786431423; cv=none; b=FAtmFdCuEHiOqZKExOI2l0gk4Hf1k0363ZA94QCuBEoeqz0j75pr4EQrsW9iIIbGTF5gFO2lj+MyI829kEJ1tDetFaASjtwptOo9LQd9Fuv+qY3fQWhKtmYFsUIG/mJmuZj25huQhWvX/3D0r7BXaIBv8n7SLt6kSv1kXCip9So= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786431423; c=relaxed/simple; bh=YVbebQqcgLozUmVD06WnYq/HbjIGs1wDxsza6cHmvco=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ErdwKdWfoWHFXCH7COyKHn72L5xj666r/o6D/yQgSpY5YSC2zhsksuBDNoQ+DM4m+PEtm9BddGsMWm7C5BLZmuDyLH6di4I2MaHvvfhJbNFuJ6eJzwsDOvMZPnOlkxZBCIeAcA0jqnhO2CPDvk4IsOgN9579U09tTZFHACmWIxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: d39dc9f4955111f1aa26b74ffac11d73-20260811 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:29bfe68e-fcfe-420c-9344-c20a17e34ee6,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:d47660827bff5ee2b9483309721501eb,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|865|898,TC:nil,Content:0|15|50,E DM:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA :0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: d39dc9f4955111f1aa26b74ffac11d73-20260811 X-User: gonglinkai@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 284839150; Tue, 11 Aug 2026 14:56:50 +0800 From: Linkai Gong To: Arnd Bergmann , Greg Kroah-Hartman , Michal Simek Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linkai Gong Subject: [PATCH] char: xilinx_hwicap: check device_create() return value Date: Tue, 11 Aug 2026 14:56:44 +0800 Message-Id: <20260811065644.379601-1-gonglinkai@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" device_create() can fail, but the driver ignored the return value and still reported probe success. That leaves a registered char device without its /dev node. Check the return value, report the error, and delete the cdev on failure. Fixes: ef141a0bb0dc ("[POWERPC] Xilinx: hwicap driver") Signed-off-by: Linkai Gong --- drivers/char/xilinx_hwicap/xilinx_hwicap.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xili= nx_hwicap/xilinx_hwicap.c index 34a345dc5e72..338588b7bf08 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -660,9 +660,17 @@ static int hwicap_setup(struct platform_device *pdev, = int id, goto failed; } =20 - device_create(&icap_class, dev, devt, NULL, "%s%d", DRIVER_NAME, id); + retval =3D PTR_ERR_OR_ZERO(device_create(&icap_class, dev, devt, NULL, + "%s%d", DRIVER_NAME, id)); + if (retval) { + dev_err(dev, "device_create() failed: %d\n", retval); + goto failed_cdev; + } + return 0; /* success */ =20 + failed_cdev: + cdev_del(&drvdata->cdev); failed: mutex_lock(&icap_sem); probed_devices[id] =3D 0; --=20 2.25.1