From nobody Tue Sep 29 07:00:32 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A463E3ACEED for ; Tue, 11 Aug 2026 06:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786431348; cv=none; b=PPJ4YMUX3ZyQkwZJGeHhW0fzIqo8dqjwpSXMC8PEF3dZazBpcFf4J5EmWMqkAVVfVmuNEvrF2dSSNYxBPukZgv30KeA/3owlO12c3N/toiCW9bggNzN26SA/Sapvay5vhAuuy3kuC6h5HU1LDFsczAaC7SwNLjPXm0ge1b1OMmc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786431348; c=relaxed/simple; bh=FcOiLSofzv4Kvyq0VX3cHSjjQ8VzMuvRf+K19o6nan8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ho4jrRc81hh538uOFx5Pab3dpn1ZaYOHiFHdiS8BaIFWIZRpxibl6f1lhIBXPgHVXkJpYJ1RV+/Nco9grTJMT4sqvK1prj9omkCCutZ22MsNuTK6QVKWVFq3SLqRqFV7ORxJ1MhMOvT67NHOr02elipdnSxJWVrOtCogy22gXMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: a8470d7e955111f1aa26b74ffac11d73-20260811 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:cc61473a-456f-4549-9158-ece0059376c5,IP:0,U RL:0,TC:0,Content:0,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:25 X-CID-META: VersionHash:e7bac3a,CLOUDID:8a29026f25aa01d56f80fb099bfb61bb,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|865|898,TC:nil,Content:0|15|50,E DM:5,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA: 0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: a8470d7e955111f1aa26b74ffac11d73-20260811 X-User: gonglinkai@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1663956657; Tue, 11 Aug 2026 14:55:37 +0800 From: Linkai Gong To: Jim Cromie , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Linkai Gong Subject: [PATCH] char: pc8736x_gpio: check cdev_add() return value Date: Tue, 11 Aug 2026 14:55:32 +0800 Message-Id: <20260811065532.361061-1-gonglinkai@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cdev_add() can fail, but the driver ignored the return value and still reported success. That leaves a registered chrdev region without usable file operations. Check the return value, report the error, and unwind the chrdev region and I/O region on failure. Fixes: babcfade4737 ("[PATCH] pc8736x_gpio: fix re-modprobe errors: fix/fin= ish cdev-init") Signed-off-by: Linkai Gong --- drivers/char/pc8736x_gpio.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/char/pc8736x_gpio.c b/drivers/char/pc8736x_gpio.c index 5f4696813cea..1a8adf1e8fa2 100644 --- a/drivers/char/pc8736x_gpio.c +++ b/drivers/char/pc8736x_gpio.c @@ -321,12 +321,17 @@ static int __init pc8736x_gpio_init(void) =20 pc8736x_init_shadow(); =20 - /* ignore minor errs, and succeed */ cdev_init(&pc8736x_gpio_cdev, &pc8736x_gpio_fileops); - cdev_add(&pc8736x_gpio_cdev, devid, PC8736X_GPIO_CT); + rc =3D cdev_add(&pc8736x_gpio_cdev, devid, PC8736X_GPIO_CT); + if (rc) { + dev_err(&pdev->dev, "cdev_add failed: %d\n", rc); + goto undo_chrdev_region; + } =20 return 0; =20 +undo_chrdev_region: + unregister_chrdev_region(devid, PC8736X_GPIO_CT); undo_request_region: release_region(pc8736x_gpio_base, PC8736X_GPIO_RANGE); undo_platform_dev_add: --=20 2.25.1