From nobody Tue Sep 29 07:39:18 2026 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B90D306746 for ; Tue, 11 Aug 2026 04:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786423198; cv=none; b=FV2mav2X5dpjtame/YLmQuk4GH7hvs0+rd96D+TDHGYk+Q40wkjuNXvc5nyJZOUWr4LcKTkqmOZDdSb54AkjnUpsDH3OGk6ywYjGO+zyI0mC0FztF46oIWJRfK7MnuYedhITZ6UMKXyvY0F5zt6FhtKMBFfcTMHmhIjwXlDpgPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786423198; c=relaxed/simple; bh=dVnC8L0/sSxN9C4zfBd3149vpmTDHVJRvq0RsDP37fc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=P8eW/YcvgJ2aVrh7rvEmkpMc1eSxBk1eibXbJuAh86V+PQV1+aeHZvsdPWSqTF5rt9G9qh/Cat91g+BJyuZJQXvfWd7wlbI0mDlBuy+uchfa4t7w+kPQS/5Yf1G/vgvOt2ozBtmQyrylqCM4TxNf9PvlhPAn9KnkorWq2mYqeus= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JQdMPGRg; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JQdMPGRg" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-92e65e18969so41845785a.1 for ; Mon, 10 Aug 2026 21:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786423196; x=1787027996; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=8btNxdr/sEbsixqeO0kHXxTmMEi//7b7qBEAg0b5Zi4=; b=JQdMPGRg8eyH/m4+3yF2ZElbVzmxWKcxwAJUb/sLmfMBZkTl+NoTN6UVW2gdvGTV9F VzIhoFEefA1n22+/UU8M19M3vwklhpYY/XJwnYpZH11/Ssh0BFT2lzY0SjFXm0DFDIoh wLC5B8Dgk4YqtMMobMgnBHQ9NnLxcki9AOIyT/st1dV7z902HLmPsAUCmcdQXDujPTKv MtJdqJ1Yf0D24qGarpPJIVjCitT6A8zdB1EKdtcH41jlew9BSzhYZZZ17k+1CLPSRhen G4gWybhUeNbdJf9RMhlBI/tH36DBLo8Y+4NAzXwH7Mi6KQnSeXrO52ZSaBJj7McyDxj1 NR8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786423196; x=1787027996; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8btNxdr/sEbsixqeO0kHXxTmMEi//7b7qBEAg0b5Zi4=; b=C3uob18SFzZE4q6kOEu4rKu3v/hFtIiczNjsZMknKVT5wVii14GSDtowYH40w+5N1Z mccYoElhkes66nDGsaEe6JRELsIAYPlzIZEfdziztoZBQE0zResXob1zilxz/LXir+ah AdXYEFe3rDMPknbM94Q9xVAPBMpK2ihUd1wGAllH1k1N/QdI7Kle1fGRlK/XzlsIB9Cp hW/NrVtrYW3uY9uqCz6poSpDVz2vrW1TcXVCz5ZDOp163LqH86l6FPRqYC3Q9zDl4qzE emaaEKlZAdgqw5vM2e6eioGzW8zy01MHynFOG9OMvPZ+UyiJ1TqFEcYK31dVfVbVyB93 8h1g== X-Forwarded-Encrypted: i=1; AHgh+Rovr5Zkn6bP53lO17HtaNlynlJ0gfjHU3vxgEGA+8IKns+7PKcy0CzqSCCyDCmJpiV+HEK4eZL5A8XF4tw=@vger.kernel.org X-Gm-Message-State: AOJu0YyUfmvaPT68ZfVaO3AyfZLrAnXtfOoXmxhhRY3tgGhWrHQ2QPV/ 51Ry9Q+ShGAyUDh1KQZaWWBUt9R3IvOQPSWI4DkSTY6NyAWL+0H1M6EiSFAxyA== X-Gm-Gg: AR+sD135+MlyulkkbSOVILWbjZWpL9Tah3NAkDYEvdIoJ8FxqS7sTEGqKDL6t1jNee/ fOzbV039Ft8NVuwm2s2d5ZyZP1nNrGxEnx9r07OW49kPUDreL3hKOgZ+NRK44k/OKGxOdYr0Df6 sfwLXWoqWPwrHORGnqJSLJxpkNq2/JcQLksDyEOSYw7WzF/UsT0xem3kPIeP+DCOwLUuxoXhqrG 8lYmkCixBOtMQ1to5ELbK/ijWPSa9SJNjj+c7en5zgUns0vkgZfUR+b04E86nuhNeGSdKPPkDoX 0E8cCbAb6lZT9kK62AkoQjrOX0oQ6kYzIcAXaLtCIUvVu2hePH7BVncLnTxAoGXQVH6NR+vIDSg sO0uGhGQCzGHcqo+f128I2A0vHd7JuOllKzT/0Y8GmcC9jHzUgWr5nOWmj3EJYhHwwEgDmmSwmf D8bZ5v8MgsMDFuccAd0qEDZobkWFr8IOfnkjACfZwrs/eT0cMqhGe9gDjLb8WcrXl6OZjiuR9pX PakylvTXeIC/h/uj11H2VYGDm2Ckk4Pne6Jfldsq/JePDVvHuQeo2OO5ntHAMR55umsjS80fDRC 5U542Cez67Xa4jI4694I/0Q0EIubQ/GnbxWN7A== X-Received: by 2002:a05:620a:890a:b0:918:7e9e:de74 with SMTP id af79cd13be357-936a944b1bfmr20788685a.17.1786423196168; Mon, 10 Aug 2026 21:39:56 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id af79cd13be357-936a848fc8fsm32826685a.13.2026.08.10.21.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 21:39:55 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: talitos: pass talitos_private to irq handlers Date: Mon, 10 Aug 2026 21:39:53 -0700 Message-ID: <20260811043953.150589-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The irq handlers only need priv, which they can get from the dev_get_drvdata() they currently perform on the struct device passed as data. Pass priv directly as the irq handler data and drop the dev_get_drvdata() call, while deriving dev from priv->dev where still needed. Assisted-by: opencode:deepseek-v4-flash-free Signed-off-by: Rosen Penev --- drivers/crypto/talitos.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index fa96b6bf17e3..89e00581ebb7 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@ -751,8 +751,7 @@ static void talitos_error(struct device *dev, u32 isr, = u32 isr_lo) #define DEF_TALITOS1_INTERRUPT(name, ch_done_mask, ch_err_mask, tlet) = \ static irqreturn_t talitos1_interrupt_##name(int irq, void *data) \ { \ - struct device *dev =3D data; \ - struct talitos_private *priv =3D dev_get_drvdata(dev); \ + struct talitos_private *priv =3D data; \ u32 isr, isr_lo; \ unsigned long flags; \ \ @@ -765,7 +764,7 @@ static irqreturn_t talitos1_interrupt_##name(int irq, v= oid *data) \ \ if (unlikely(isr & ch_err_mask || isr_lo & TALITOS1_IMR_LO_INIT)) { \ spin_unlock_irqrestore(&priv->reg_lock, flags); \ - talitos_error(dev, isr & ch_err_mask, isr_lo); \ + talitos_error(priv->dev, isr & ch_err_mask, isr_lo); \ } \ else { \ if (likely(isr & ch_done_mask)) { \ @@ -786,8 +785,7 @@ DEF_TALITOS1_INTERRUPT(4ch, TALITOS1_ISR_4CHDONE, TALIT= OS1_ISR_4CHERR, 0) #define DEF_TALITOS2_INTERRUPT(name, ch_done_mask, ch_err_mask, tlet) = \ static irqreturn_t talitos2_interrupt_##name(int irq, void *data) \ { \ - struct device *dev =3D data; \ - struct talitos_private *priv =3D dev_get_drvdata(dev); \ + struct talitos_private *priv =3D data; \ u32 isr, isr_lo; \ unsigned long flags; \ \ @@ -800,7 +798,7 @@ static irqreturn_t talitos2_interrupt_##name(int irq, v= oid *data) \ \ if (unlikely(isr & ch_err_mask || isr_lo)) { \ spin_unlock_irqrestore(&priv->reg_lock, flags); \ - talitos_error(dev, isr & ch_err_mask, isr_lo); \ + talitos_error(priv->dev, isr & ch_err_mask, isr_lo); \ } \ else { \ if (likely(isr & ch_done_mask)) { \ @@ -3361,7 +3359,7 @@ static int talitos_probe_irq(struct platform_device *= ofdev) =20 if (is_sec1) { err =3D request_irq(priv->irq[0], talitos1_interrupt_4ch, 0, - dev_driver_string(dev), dev); + dev_driver_string(dev), priv); goto primary_out; } =20 @@ -3372,18 +3370,18 @@ static int talitos_probe_irq(struct platform_device= *ofdev) /* get the primary irq line */ if (priv->irq[1] < 0) { err =3D request_irq(priv->irq[0], talitos2_interrupt_4ch, 0, - dev_driver_string(dev), dev); + dev_driver_string(dev), priv); goto primary_out; } =20 err =3D request_irq(priv->irq[0], talitos2_interrupt_ch0_2, 0, - dev_driver_string(dev), dev); + dev_driver_string(dev), priv); if (err) goto primary_out; =20 /* get the secondary irq line */ err =3D request_irq(priv->irq[1], talitos2_interrupt_ch1_3, 0, - dev_driver_string(dev), dev); + dev_driver_string(dev), priv); if (err) { dev_err(dev, "failed to request secondary irq\n"); priv->irq[1] =3D 0; --=20 2.55.0