From nobody Tue Sep 29 07:41:47 2026 Received: from mail-pj2-f5.google.com (mail-pj2-f5.google.com [74.125.227.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16685304976 for ; Tue, 11 Aug 2026 02:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786414955; cv=none; b=Aa9xEw6EtJwVXlG0EzjwOQ0DiI2TqI19uhSMcP4cngDKQgXbnD5liK15WIObnVKFQAg6o/1E5hwV8va0LsrSQVrbr4vGqYFB/SVBowYGep5TNZlS1h7ZGibjterXzOfiYIbGj9A5q49PiVZCWZ3fDSNbeqiSyfMEL7E6L0tob/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786414955; c=relaxed/simple; bh=Kn0zI7rxyZegx1vgsxplNTyY4hoKLKQ2bDgVGgQ9eYA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Qdautv7BVr9gdDcBQVXj8TN3c0tAKVF5aKniGrTdH6rGUzPvMdtTvD+y8FBZGHYo4v30rxRui7iDbDTZ5RTtBvmV4Iyd8o5JAXVlLhCVCvdKoJx5zWeq1x1/oDoljiiYGke4kVEexOT2VUJVRb3jonH/mkJf/co/H1fxmMpY2EU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.227.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj2-f5.google.com with SMTP id d9443c01a7336-2d0344e1ce9so12344295ad.1 for ; Mon, 10 Aug 2026 19:22:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786414952; x=1787019752; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AiV0HEnxmelGmu45/owXrOpkoTF5j4XifJDvDbQKI/8=; b=iY4LclL/yeaXM7qP29YH4ReIS1QPWoYERuPEqpCkWLALVxJBhPQOm/SYkSju0e98eY /icrbGfSgUFpkZZpXmQmxcU24/03UydRaJeN69fHyHiFfcMht6PkOD7SxwMpPRdcYWXn ComBB78YCJAwc/5+j/uiO346dGz3j6IRP32QYhi19HFmJ184WSgeNSWmOU5TdpbtuB6L DnGCGqwYLjFINk0An4EF9kLkb9ZUGpWNlOO1f4j+kpzKavY/5kUCkfpeutBRr3vTw3Wa aGcjepExbbWz/hZ9Nq6PI6+7yMjurgKf+6aVWH8HoAynYsJ6xo+D/YFlkuewH/ABuCIR 6rtA== X-Forwarded-Encrypted: i=1; AHgh+RpvaypXfGgycXSiN9EnvlZcp86P+i24rFJJPQ/4Lsuv9QKK/OE1KXy+D+VSz3I/jhfkPXSLS5cX5+shxJs=@vger.kernel.org X-Gm-Message-State: AOJu0YzpCrqFFmyG2akfmVotTmUn1WCZYmZFl0TxKUum4gf6FA9sfJOv rSndOfvfvyNHvMT4RroBzirvW9BrpFKRBaQmokDcJBDRsO9eVdYgecDK X-Gm-Gg: AR+sD11M/n1mwML5+FnKmiyUr3HUqed2UaSfVlJ3SX91msGXBO5FZOJfaNHHwRtpL2X thGxmESSL6gduwdv2lobLyE0BHGj7XhOmttz23YRpEOzJL6f8hHkRZH0BI7YzF73qJXBYtMbx8k PdiJY8MZAVxW/zvmZkG1MEbVQoqAZ3210nHZAhTiw+EZBGvnBrUgNKaGeOhYrvbawxezjxLQ8LF JUalbnZ/V6NII3adHbA+SfQGdgdjoIh+bgC3l0QXbxT3TnKEEV4a95bO28POv8/Caydyplydk1w JRWv+n1fivYh91sv1NKbHtdBu5HCZHA7BiGT7CCZAP/3/a1NswQrz5QTc9y0YJoGaeeLOfExmhk 50pFFhk7rYnSL0TeKb0bKQWiIliTJ4BbEs2lmkuntVRQlLb2L1SCKIPu05G82WG+m7c775+SrsR 7Be8m9e3wu9OFsLvAjTKa1oVB5+E5CyVavd6cGOTUr4iR+EWHrgw/Toi/p71Cy7wXrkte+aUrc1 GhTTwFJLw== X-Received: by 2002:a17:902:f689:b0:2c9:ff29:3f91 with SMTP id d9443c01a7336-2d31779b7e9mr1705365ad.6.1786414952391; Mon, 10 Aug 2026 19:22:32 -0700 (PDT) Received: from kylin-XiaoXinPro-16-AHP9.. ([116.128.244.171]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d315f29afdsm389365ad.19.2026.08.10.19.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 19:22:31 -0700 (PDT) From: Xueqin Luo To: herton@canonical.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, rafael.j.wysocki@intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Xueqin Luo Subject: [PATCH] platform/x86: Add ACPI_COMPANION() NULL check in topstar_acpi_probe Date: Tue, 11 Aug 2026 10:21:15 +0800 Message-ID: <20260811022115.338595-1-luoxueqin@kylinos.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add NULL check for ACPI_COMPANION() in topstar_acpi_probe() to prevent NULL pointer dereference when driver_override matches a device without ACPI companion. Fixes: 3471415c8186 ("platform/x86: topstar-laptop: Convert ACPI driver to = a platform one") Signed-off-by: Xueqin Luo Reviewed-by: Rafael J. Wysocki --- drivers/platform/x86/topstar-laptop.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/topstar-laptop.c b/drivers/platform/x86/t= opstar-laptop.c index 0e842c55dcc5..730a599abf0f 100644 --- a/drivers/platform/x86/topstar-laptop.c +++ b/drivers/platform/x86/topstar-laptop.c @@ -287,10 +287,14 @@ static const struct dmi_system_id topstar_dmi_ids[] = =3D { =20 static int topstar_acpi_probe(struct platform_device *pdev) { - struct acpi_device *device =3D ACPI_COMPANION(&pdev->dev); + struct acpi_device *device; struct topstar_laptop *topstar; int err; =20 + device =3D ACPI_COMPANION(&pdev->dev); + if (!device) + return -ENODEV; + dmi_check_system(topstar_dmi_ids); =20 topstar =3D kzalloc_obj(struct topstar_laptop); --=20 2.43.0