From nobody Tue Sep 29 06:58:49 2026 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D623E417D7E for ; Tue, 11 Aug 2026 08:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436866; cv=none; b=g/zOMcW5YGdiReE9Ndh+9OsP3xdMnQEacjVlgzjzskiHLRRVElm50S1ou0Hn4bHFR8RmsepAeT0fAZ9xaAXI1OHR7YwVSABodh/6DjjKtsiRRD4EwS4ZdN1YaRnkLwEV/nnfznuERItjNKU0DGE+M+EKWKHR8xMXS6f+vDUAXN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436866; c=relaxed/simple; bh=vXJST93REa+QH10dPJYzmKclTq5eGMoIGhB/tPIJFyE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GMsZa8bDWh+at7M5BMz4PPnhx7VBQf1cFvIZdyRftr1Nur7LQSIx6wS7Sl7N45SchxQ9UvOK+X7FIbCP6cUplK5wPQHEwo8ozWhnCT+KWZis9dkdh+tkko6MPdmVw3WvPCqFPJU0i/iasTfyShQ2h4GrPBmF4FQ1CgZklx5JjoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eRQKYwPQ; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eRQKYwPQ" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-49fa951b2c6so1493379b6e.1 for ; Tue, 11 Aug 2026 01:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786436864; x=1787041664; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6fiFh2L3bx9YuuvYvD9BsidmGnYklyUdwY2Tqg6czVo=; b=eRQKYwPQkwuIOgUrdwlGYAttYx/t6TpLuMDF4MmhipnyHkZzCaG+aFt9NeSu6G27gJ yWfkkpOPtWog7NJs7IP2BntC9XvSTpxeKUTX3oN6BKsdlCkho0lisOjCNfnKYXy5dvOy ln6JwvxOfJLVYoB/w2v4KAwqMQZDqCtq7IlGcXBjknLHdM6VFyy4mIhwMRbuBe8ESebe gVtcBm8shiA50KYjfEA+yTogqXfEu/cPPhPOrjDtrYyV/cyXbk8XaM1T4+i7q+FK8hv7 5J2Zmgu7erOB/IWudDjvv08I2xTQ+8sAYwulob+tGJUfK/oETjWJxLI/gnffPZMnjZr9 16jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786436864; x=1787041664; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6fiFh2L3bx9YuuvYvD9BsidmGnYklyUdwY2Tqg6czVo=; b=AiFzmL3jfc3LNJ9o+3nMprSy3Kc9ov7LVG7LUBuKMWi4qwXDOtvgel/15gwpM7yNua V3zTWCdnvHmMI6Hbifsp6qJpMqvKmZtIVTsEUHox+ao91enjRgpF3BPxvYB3dPfXcOLa pOz0j65uZpHuV8oBvnbcnBvDzLnEwWe40hBoJm+AHShs0aOpmJ0Sy+COALtaWVzzK54B pMTdTR97w7KuEncpSl6s16+VL3lFzmxmgAjstLuBPIhdgbGDUSWCnCe1yz9Ho9Uj3Gds aWLzWJUtezKpL2prRcJmfgvDSymfCYm/dEv4ldEWKz2jXcv+a0Hh1K1zRgT7d5k5FdeS Pxxg== X-Forwarded-Encrypted: i=1; AHgh+Rpna515JH6HMDzPmoOpTbKnVJ1zs4k+CIuroi/c12W3d+BxJQ1CYJfzw8DhqcgvQc6p/FnACdTtStCU1hY=@vger.kernel.org X-Gm-Message-State: AOJu0YxVDS2iHprJmsrs0mtrVxazsaVwgTdXYFec0lVwct7Ti8W6kDGg Y0H+Sh1B5j7w1zNENOWuK5TVFoQtF4TLn6NBBRRp+J/D/dMKPReq6zK1 X-Gm-Gg: AR+sD10ik0OpfkZdgUIVdn43+X1h1ILKthyBP4L772sr1+WttgaEq3y/qjpA5npCe7A tmdHq2iT5FxH/LQ16lfqjahDMvu0i5skk9M+l+YBui8zw9znqDLAeUGZEPOwMn6iEu2qWgGor3Y hsCWhkVB5uUKN54XKfhwkWp6ualZ36u3mfC8hxv+ALaWGfCK3FjJPCCaTaAELEBf8wssPnH/03P KHhi1KH43WawMLG68oMbhw1//vwgREzoAGzJxlYJQ+kuToo+qEcCy73NiMLcyonQhZS4YmOC+8l gK/WgWgcYWL15vJkIzwIXObPtNryjsvTwNyXwhYwu1VfheK3sOHkjP3bH1IagSnetm//BVQNFo0 mDfV2oX2+nHuftLqkNEW29xdeUJfFeqTHDQp17L9JSuQfShPXzFiShmxz0s4+LifDVXY+8dUvFr Tp+7moBHzH1uxD/qNOAo9VrA6yMNlOgrpJXK9pOaurjH9M8U6pRXL3l3h+pFvO9m+ZlYiGzctQQ P/gIECg41QTazl6q0U1T6dQFdXzz0KZ+71fv+inBg5zZB73pIGHyNmUq4ac+W9OzW9bG7qsA4Gl hCUamGsOMmDjS9HBvSYIDPe97D3Ae0NAIBgqn34PZIk6oyrB0bNfkglM0//QDFLRVLom+isbM8W qt/fQ/G9ObYfGBTHFrTStE/50/ioy X-Received: by 2002:a05:6808:bc4:b0:4a4:c12:46f6 with SMTP id 5614622812f47-4b1fd5ef03dmr1111568b6e.2.1786436863681; Tue, 11 Aug 2026 01:27:43 -0700 (PDT) Received: from [127.0.1.1] (184-96-154-59.hlrn.qwest.net. [184.96.154.59]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b1fff55fdcsm318095b6e.6.2026.08.11.01.27.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 01:27:42 -0700 (PDT) From: James Hilliard Date: Tue, 11 Aug 2026 02:27:23 -0600 Subject: [PATCH v6 1/3] dt-bindings: mfd: x-powers: Add AC200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260811-submit-ac200-mfd-v6-1-c5b1292c8498@gmail.com> References: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> In-Reply-To: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> To: Lee Jones , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Hilliard Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 The AC200 is an I2C-controlled mixed-signal companion IC containing audio, video, RTC and Fast Ethernet PHY functions. Describe the parent device and its shared input clock. The Ethernet PHY is represented by a PHY package on its MDIO bus, with a phandle back to this device for access to the package control registers, so it does not require an MFD child node. Function-specific supplies belong to their consumer bindings rather than the shared parent. The input clock must run at 24 or 27 MHz when the Ethernet PHY is used, matching the rates encoded by its documented clock selector. Signed-off-by: James Hilliard --- .../devicetree/bindings/mfd/x-powers,ac200.yaml | 49 ++++++++++++++++++= ++++ 1 file changed, 49 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml b/Do= cumentation/devicetree/bindings/mfd/x-powers,ac200.yaml new file mode 100644 index 000000000000..609831b15c80 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/x-powers,ac200.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: X-Powers AC200 mixed-signal IC + +maintainers: + - James Hilliard + +description: + The AC200 is a mixed-signal companion IC containing audio, video, RTC and + Fast Ethernet PHY functions. Its control registers are accessed over I2C. + +properties: + compatible: + const: x-powers,ac200 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + description: + AC200 input clock. When using the Ethernet PHY, its configured rate = must + be 24 or 27 MHz, matching the rates encoded by the documented EPHY c= lock + selector. + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + mixed-signal@10 { + compatible =3D "x-powers,ac200"; + reg =3D <0x10>; + clocks =3D <&pwm 5>; + }; + }; +... --=20 2.53.0 From nobody Tue Sep 29 06:58:49 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11D664192F8 for ; Tue, 11 Aug 2026 08:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436869; cv=none; b=iH4d/bL8msnNgTbHKSfWeBTw3taG5QV+6rOcy0PT/n4rEzQ5RNnipaN8tqMXbnde6i/6bR6mFWDgqV9C/rVzTVwtj9PD6pBBxA73cgGj80ZYLl41owBQBhfsFSNmOzLNTQKmUL09hJfhrxnmDRr9yh7xdXeuRamD8C1p+Aa06ug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436869; c=relaxed/simple; bh=IzRlEU23yfQQ6x4BYmQXGZqejxD9TteX1wiEO5R8YME=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JPAn70OLIq/yT9CNDHONLbazpmGj4QRI/wLVOu1UEtk6M8/djlaVYOf8jJI4UxBh/jOu2iitUIT7wUR0AAmAuz9UK0eA+hbfnuiAGoKZ36dPkRAfG27XUjv30FFKQfwD3cWtEPaDt98MmF7vzci13e9Qhq3yGYEgQN1lOIl00N8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EtdVI2b/; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EtdVI2b/" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-4af173320f9so1470275b6e.2 for ; Tue, 11 Aug 2026 01:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786436867; x=1787041667; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gyzPxN0hN+8W2JU9IAdx12pcVnDBJDk0tQrb35djIKE=; b=EtdVI2b/D3bDM3lFQnz5p2POUYPO36ver9oYtWmCUsd28/gYM2LYR4wPynBeDZfFic VfEz1PQiOleHeI+T5RIOcY1V/rR1PDDpF6iY9gr07NDdBXK0IqC5PjiHnBWPpwD6pGW1 jiNT9hLwOri7RYr/7hZRdoygTZEZOYZ7Mo9nuNCj4mk4tj161O2fzV2aewYjRH75jGbs c0d57uSkhlA7YtK/aWz4boEF9WIFsDF3W4eodKs0tzLhkBrIfb7+niVQXmOpdtK5FdrV nXAjUJKSSs8yalfrl9gFY+bJzQ8PHyU+SgMW+OYgrhjLowBt4CUGzAS/cSCQ4YTXscra DCIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786436867; x=1787041667; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gyzPxN0hN+8W2JU9IAdx12pcVnDBJDk0tQrb35djIKE=; b=UkRadokPACqlVTELT5JUzHwKsxlfQBXG8rgZ9wKPmdc6QJ9eAckEXyiralTE7qWxcK 8SIn7iGL2lUytqQ/E28zBNGuB31MU9GgqH3oZCkhw6VdJHf4kzv+K6Q/GNCkddDoKa6h a5FLEMxqc0T9qe2x0VHfCpAse7Fz8KtG/hZ88hv84RCXn1eB7m9O4Uuohfyh1jVO9ScL sk5xbu5TnsA4PJyT/HpAcE8OkKSRvh+Valh3lHYZ+tuuO3msT1OXzUS008Q31eVkJVqM gkBRbOrQ68OrON5E0/MW+xZbV0CnGsC6Q1OE9bbD8j+8WDpY55xpRBp4W6q+i2TvG/2x L9/g== X-Forwarded-Encrypted: i=1; AHgh+RrqJ9FjX6kR/MPIpEN+pWH7y39qC9wVPqDV9US7MU6gx76cdy/YjL+EnDtFVfKO90KbObKaYXTSWjhEgcI=@vger.kernel.org X-Gm-Message-State: AOJu0YxDJp6E39iZgk2IWJ5QtOVZF6xF96dSfNc91I5a78WZ8E4wjpqO p+aUVCesBiSe34O7YqEkDQ7SaGvxc6Jz5wElYR1KxzHvdSwJN0kFsFNH X-Gm-Gg: AR+sD126hydaHI+HxOywFVfzYRVDEYk4VV7Oi+MHnvEZLK0vWZ2VOHjc7c3qAr6pB63 SyXXYhHAriP8xOZ1G4/FVRtx8Pd3G1gBmkVzbd0XQy5PboPPGKW0dsncQ3XfEyWsE1hoVB4E2kG CAenM5wvVkbgEkzVPb6jQtEp3zjjPkCK9/EIu3/wqndGoYP0QYof4/Ruh/+aJY6j88zszY/XUl7 BqEEfgCe8UYdd+4P31u2HQTgFDkZqoAttgpp0zCGMQVhJiMWrxqvhB1BKlAmvIBi/BKq7KS2rGs si13arLryBxBXU9rCdzY3arTPIeJBAE5JAELkPciWORB04x7NPN2JT7hhmczll9A/cNE2iq4s+w R433UUu2H5M4WqSUqsS4W26vLztNBdJ6dd1mfX+HIDMXsUHmqHrxHCMrQD4y0E6iS4hzxshz223 QJtqyPhHQi4ZysERomfY9BacjAEeYZFsRBrHbDQCeqTdEO+AFuuwbF3kYccEPBAKdFYhd8IoZG2 x9lXDQn+SCrGeur6y/0ZxQXBhXyPKPCAmKAI/hipstI8J3I8h+TL+oX5djap7V0xr8G5mn3M7/w hCiJz/W06wTbwHsE3bWPRACGyM3pphaZMt533Ag2rtQ8xCx3GBflrkEYsSL6mbEJLplU0sJdDi8 NahT1JacBHuK/RqUx X-Received: by 2002:a05:6808:bc6:b0:495:da3c:1aa with SMTP id 5614622812f47-4b1fd9af94amr998551b6e.16.1786436866871; Tue, 11 Aug 2026 01:27:46 -0700 (PDT) Received: from [127.0.1.1] (184-96-154-59.hlrn.qwest.net. [184.96.154.59]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b1fff55fdcsm318095b6e.6.2026.08.11.01.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 01:27:45 -0700 (PDT) From: James Hilliard Date: Tue, 11 Aug 2026 02:27:24 -0600 Subject: [PATCH v6 2/3] mfd: syscon: Add managed registration for external regmaps Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260811-submit-ac200-mfd-v6-2-c5b1292c8498@gmail.com> References: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> In-Reply-To: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> To: Lee Jones , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Hilliard Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 of_syscon_register_regmap() publishes an externally owned regmap in the global syscon list, but provides no way for a removable driver to withdraw it. Registering a devm-managed regmap from such a driver would therefore leave a stale pointer after unbind. Factor external registration through an internal helper and add devm_of_syscon_register_regmap(). The managed action removes the entry under the syscon list lock before later devres actions release the regmap. Hold a device-node reference for the lifetime of every externally registered entry so its lookup key also remains valid. Consumers of a removable provider remain responsible for ordering teardown, for example with a managed device link. Signed-off-by: James Hilliard --- drivers/mfd/syscon.c | 87 ++++++++++++++++++++++++++++++++++--------= ---- include/linux/mfd/syscon.h | 12 +++++++ 2 files changed, 77 insertions(+), 22 deletions(-) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index 21a7fcdd2737..448422fe4f21 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -10,6 +10,7 @@ =20 #include #include +#include #include #include #include @@ -193,53 +194,95 @@ static struct regmap *device_node_get_regmap(struct d= evice_node *np, return syscon->regmap; } =20 -/** - * of_syscon_register_regmap() - Register regmap for specified device node - * @np: Device tree node - * @regmap: Pointer to regmap object - * - * Register an externally created regmap object with syscon for the specif= ied - * device tree node. This regmap will then be returned to client drivers u= sing - * the syscon_regmap_lookup_by_phandle() API. - * - * Return: 0 on success, negative error code on failure. - */ -int of_syscon_register_regmap(struct device_node *np, struct regmap *regma= p) +static struct syscon * +of_syscon_register_regmap_internal(struct device_node *np, + struct regmap *regmap) { struct syscon *entry, *syscon =3D NULL; - int ret; =20 if (!np || !regmap) - return -EINVAL; + return ERR_PTR(-EINVAL); =20 syscon =3D kzalloc_obj(*syscon); if (!syscon) - return -ENOMEM; + return ERR_PTR(-ENOMEM); =20 /* check if syscon entry already exists */ mutex_lock(&syscon_list_lock); =20 list_for_each_entry(entry, &syscon_list, list) if (entry->np =3D=3D np) { - ret =3D -EEXIST; - goto err_unlock; + mutex_unlock(&syscon_list_lock); + kfree(syscon); + return ERR_PTR(-EEXIST); } =20 syscon->regmap =3D regmap; - syscon->np =3D np; + syscon->np =3D of_node_get(np); =20 /* register the regmap in syscon list */ list_add_tail(&syscon->list, &syscon_list); mutex_unlock(&syscon_list_lock); =20 - return 0; + return syscon; +} + +/** + * of_syscon_register_regmap() - Register regmap for specified device node + * @np: Device tree node + * @regmap: Pointer to regmap object + * + * Register an externally created regmap object with syscon for the specif= ied + * device tree node. This regmap will then be returned to client drivers u= sing + * the syscon_regmap_lookup_by_phandle() API. + * + * Return: 0 on success, negative error code on failure. + */ +int of_syscon_register_regmap(struct device_node *np, struct regmap *regma= p) +{ + return PTR_ERR_OR_ZERO(of_syscon_register_regmap_internal(np, regmap)); +} +EXPORT_SYMBOL_GPL(of_syscon_register_regmap); + +static void devm_of_syscon_register_regmap_release(void *data) +{ + struct syscon *syscon =3D data; =20 -err_unlock: + mutex_lock(&syscon_list_lock); + list_del(&syscon->list); mutex_unlock(&syscon_list_lock); + + of_node_put(syscon->np); kfree(syscon); - return ret; } -EXPORT_SYMBOL_GPL(of_syscon_register_regmap); + +/** + * devm_of_syscon_register_regmap() - Register a managed external syscon r= egmap + * @dev: Device that owns the regmap + * @np: Device tree node associated with the regmap + * @regmap: Pointer to the externally created regmap + * + * Register an externally created regmap object with syscon and remove it = when + * @dev is unbound. Consumers must stop using the regmap before the provid= er is + * unbound, for example by establishing a managed device link to @dev. + * + * Return: 0 on success, negative error code on failure. + */ +int devm_of_syscon_register_regmap(struct device *dev, + struct device_node *np, + struct regmap *regmap) +{ + struct syscon *syscon; + + syscon =3D of_syscon_register_regmap_internal(np, regmap); + if (IS_ERR(syscon)) + return PTR_ERR(syscon); + + return devm_add_action_or_reset(dev, + devm_of_syscon_register_regmap_release, + syscon); +} +EXPORT_SYMBOL_GPL(devm_of_syscon_register_regmap); =20 /** * device_node_to_regmap() - Get or create a regmap for specified device n= ode diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h index aad9c6b50463..3e804fc1b03e 100644 --- a/include/linux/mfd/syscon.h +++ b/include/linux/mfd/syscon.h @@ -15,6 +15,7 @@ #include =20 struct device_node; +struct device; =20 #ifdef CONFIG_MFD_SYSCON struct regmap *device_node_to_regmap(struct device_node *np); @@ -30,6 +31,9 @@ struct regmap *syscon_regmap_lookup_by_phandle_optional(s= truct device_node *np, const char *property); int of_syscon_register_regmap(struct device_node *np, struct regmap *regmap); +int devm_of_syscon_register_regmap(struct device *dev, + struct device_node *np, + struct regmap *regmap); #else static inline struct regmap *device_node_to_regmap(struct device_node *np) { @@ -75,6 +79,14 @@ static inline int of_syscon_register_regmap(struct devic= e_node *np, return -EOPNOTSUPP; } =20 +static inline int +devm_of_syscon_register_regmap(struct device *dev, + struct device_node *np, + struct regmap *regmap) +{ + return -EOPNOTSUPP; +} + #endif =20 #endif /* __LINUX_MFD_SYSCON_H__ */ --=20 2.53.0 From nobody Tue Sep 29 06:58:49 2026 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 794FE419314 for ; Tue, 11 Aug 2026 08:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436873; cv=none; b=gEV9oFYepYl1X9uMgh/KbhyOpKalt9SMCIzHlLc+uJaFh42b8TKfigpm3uhJrJYVkN88IqkMgSIDMR6vTFtoMEZH42bWH+hNyeQLU1jPohnWf/u7ARpBlKyad+uxcZF/N01RrW7Jp1Di9CEAy4+E9RecrMs4DEQei3QwJY1Ayz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436873; c=relaxed/simple; bh=0NFMkiI9cGUJGQu0nU9aq2ncgiF85JLhExyubCYkRTE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MprLixhLm6Hbj68jYyaIcvP8YgKCRUrxtnq3X60oWjPfHYGdR03BS1ZbhTmehMLcmSiNLBjGMDIDo+rNATLXLjDzh/UjLFNu2VORDI8QZljxTDjcstyPglamxpBnlOiLzO4Svg3+qSzJv1eQpYQvrWQYzNzMADea41H8d3aZA0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E/SQHQZ6; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E/SQHQZ6" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-4a475409044so603683b6e.1 for ; Tue, 11 Aug 2026 01:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786436870; x=1787041670; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cY5JFkhr2MFK4a7Q8KfriRWA+QTcA2VyYLDaWVkulWM=; b=E/SQHQZ6kXKICHorM0s2Cz83MfOJ8Kp/9BEBBVd2v194uV1gXl3XsYR1+68j82WuuC LgaApsgtgax0VFyPxr8JOCefaM2uGK7VXVvD8zIsPX3b2NYptCFDVFs3P+aqC6aVgUIP H9LhYyOURBYJ6MdPcrLucdfSK7qDgRAYUoPoxcP4e8z82b7hhUBxqEuq+c47j5y5lhJi psnbD4F7ytApkFyDzxTU+JIjzgOeY0UmWaoNNpM36ftUUuzKrMxhiUpjUxJRkSiJrHcg /RmkBO2MhFiHLB2rvk61Gd0BSp9SwaDdeqq9urZ6r78puLRyJ+kmaQ6FOEE+tPPoq2tV 2FYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786436870; x=1787041670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cY5JFkhr2MFK4a7Q8KfriRWA+QTcA2VyYLDaWVkulWM=; b=LtDnQSHFeS1I2b9jKHjS3KY9gbVPLr1TaVq4DXbGq7OE12t1cW0TPMSXnvl9uBnI8K HfvkrbdYJAGyPs5TdhVpJqtgOzkWW5AsycSdMRPYVbmJ+s6QuiKZZvIJ6XuBEDRZIm+s FcmmXwVRoYaFmILRkTN1OLW5eRtXLbGrsuLWeH6DJCLk5/CLLR1UnWxeiB20TbjvxbIh wX+YyLMbe89/1zgoDU4YpuFVb4qV3q82EM5tHHCLiKAZTw+orgd8YtENntR6UDK9P/dG 4KU4Z9YzUxTOIxEoeXHjmwj6cyrSL3oDv6Zbbl6s97/JI4yTXQFcrzcu4csD3sz39nQ1 Lsug== X-Forwarded-Encrypted: i=1; AHgh+Ro/ayF1Q4+DHMbIDllN7ubz8On4JtoHaLW+5tHUd6nMEa84+dCK9aZ1FAetaL/AxJRs6Ky6HBp7YsLHULI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7t2AipWaTXok1a5WtWKP7FOGGm4Aa1GyP8970Nhh1xXJlykdN d+TQ3zYJ9FZAp9+LLzsT5E7KnVuMAucifBYEy9Brp/MQ5BLvx8qqHmmU X-Gm-Gg: AR+sD11Dq246eyXadFQYfgrVwNBMO+btMPsbeLJwiJkxwVRPi1nVRiwzzAJWn+Fdxvh Y7gL7X/9qf84LhQDrXK56IiZqMRVvl4H4pH7+OkExvtZBjAEJLCC6Av1N2HL4QPGBg3AgpKhi69 6IhuNtOQEecYtcxZOa5lfKVMR0w438aGq+fWxakjTNlnmlqLZTZUhpkJzLOFv54n4d97F5fGpGD 5rljmjyPl8gR1N/uyaZsCNT4Tzl/i//GHXn0HEiJ9tXK+ckHjWbC3admTUybke5LNg0+3Kxiwc8 6Q5LIf7cOpyLw9/XF6PIfMqE6j2PybCL0S5HRfmfZamA5TXSg+ukVp8CNcp1/p10YAdnsO1M7VT PP8ohxF6e+Fj3bVQ+TvE5tRVbA09fKr6bfUh3Zrzr+2r1XQlUSpk9ScP5vCo075296uewhGU3S2 Rg0zQWu6lmksAjKTVA3/dNthD7pWZ+L7d/6xckY4AX8ewBjH8yUNmhWsCOiuvt/xG9fgBNnT2kG tcaKxVr9w+FvvESKLYFwixmy1pmhEc0ZWrF7VBCIoRQyK7gbs+4P7eDBJgByNiRktd/k/x0gQzC X5KGw2ofHnf+l23rAvkeGBQHc/DyKZHjxO/9AILvDoqwpI0iYrI8t4PRX+RdNMR9uxSqbtCv383 Y1rwMmiceTAVymUuA X-Received: by 2002:a05:6808:4f47:b0:495:f67c:d96a with SMTP id 5614622812f47-4b1fd77a01cmr907432b6e.12.1786436870348; Tue, 11 Aug 2026 01:27:50 -0700 (PDT) Received: from [127.0.1.1] (184-96-154-59.hlrn.qwest.net. [184.96.154.59]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b1fff55fdcsm318095b6e.6.2026.08.11.01.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 01:27:48 -0700 (PDT) From: James Hilliard Date: Tue, 11 Aug 2026 02:27:25 -0600 Subject: [PATCH v6 3/3] mfd: ac200: Add X-Powers AC200 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260811-submit-ac200-mfd-v6-3-c5b1292c8498@gmail.com> References: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> In-Reply-To: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> To: Lee Jones , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Hilliard Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 The X-Powers AC200 is a mixed-signal companion IC with a paged register map accessed over I2C. Enable the shared input clock and prevent its rate from changing. Match the vendor driver's 40 ms wait before the first register access, initialize the paged regmap, report the chip and package revision, and apply common reset. The Ethernet PHY link endpoint is independently enumerated on its MDIO bus, so publish the regmap through managed syscon registration for lookup through its AC200 firmware reference rather than creating an artificial MFD platform child. The managed entry is withdrawn before the regmap is released, while the function driver separately manages the PHY analog supply. Cache only the common page selector. Individual functions can reset independently and invalidate their other registers without regmap's knowledge, so leave all functional registers volatile. Reset the chip during managed teardown and system shutdown. Consumers can use device links to ensure that they unbind before the shared AC200 resources are released. Signed-off-by: James Hilliard --- drivers/mfd/Kconfig | 12 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/ac200.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 183 insertions(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e4fd4572472f..f8354a0f6b5c 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -205,6 +205,18 @@ config MFD_AC100 This driver include only the core APIs. You have to select individual components like codecs or RTC under the corresponding menus. =20 +config MFD_AC200 + tristate "X-Powers AC200" + depends on I2C + depends on OF + select MFD_SYSCON + select REGMAP_I2C + help + Support for the X-Powers AC200 mixed-signal companion IC. The AC200 + contains audio, video, RTC and Fast Ethernet PHY functions and is + co-packaged with some Allwinner H6 and H616 SoCs. This driver provides + the shared register access used by the individual function drivers. + config MFD_AXP20X tristate select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 72d3944b0ad8..f8101d2a9ce9 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -150,6 +150,7 @@ obj-$(CONFIG_MFD_DA9052_SPI) +=3D da9052-spi.o obj-$(CONFIG_MFD_DA9052_I2C) +=3D da9052-i2c.o =20 obj-$(CONFIG_MFD_AC100) +=3D ac100.o +obj-$(CONFIG_MFD_AC200) +=3D ac200.o obj-$(CONFIG_MFD_AXP20X) +=3D axp20x.o obj-$(CONFIG_MFD_AXP20X_I2C) +=3D axp20x-i2c.o obj-$(CONFIG_MFD_AXP20X_RSB) +=3D axp20x-rsb.o diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c new file mode 100644 index 000000000000..25066bb36ac7 --- /dev/null +++ b/drivers/mfd/ac200.c @@ -0,0 +1,170 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * MFD core driver for the X-Powers AC200 + * + * Copyright (C) 2019 Jernej Skrabec + * Copyright (C) 2026 James Hilliard + * + * Based on the AC100 driver: + * Copyright (C) 2016 Chen-Yu Tsai + */ + +#include +#include +#include +#include +#include +#include +#include + +#define AC200_SYS_VERSION_REG 0x0000 +#define AC200_SYS_VERSION_PACKAGE_MASK GENMASK(15, 14) +#define AC200_SYS_VERSION_CHIP_MASK GENMASK(11, 0) + +#define AC200_SYS_CONTROL_REG 0x0002 +#define AC200_SYS_CONTROL_CHIP_RESET_DEASSERT BIT(0) + +/* Interface register accessible from every register page. */ +#define AC200_TWI_REG_ADDR_H 0x00fe +#define AC200_MAX_REG 0xa1f2 + +struct ac200 { + struct regmap *regmap; +}; + +static const struct regmap_range_cfg ac200_range_cfg[] =3D { + { + .range_max =3D AC200_MAX_REG, + .selector_reg =3D AC200_TWI_REG_ADDR_H, + .selector_mask =3D 0xff, + .window_len =3D 256, + }, +}; + +/* + * Each AC200 sub-block can reset independently, invalidating its register + * contents without regmap's knowledge. Cache only the common page selecto= r; + * this avoids a selector read-modify-write for every access on the same p= age + * without ever returning stale functional-register values. + */ +static bool ac200_volatile_reg(struct device *dev, unsigned int reg) +{ + return reg !=3D AC200_TWI_REG_ADDR_H; +} + +static const struct regmap_config ac200_regmap_config =3D { + .name =3D "ac200", + .reg_bits =3D 8, + .reg_stride =3D 2, + .val_bits =3D 16, + .ranges =3D ac200_range_cfg, + .num_ranges =3D ARRAY_SIZE(ac200_range_cfg), + .max_register =3D AC200_MAX_REG, + .volatile_reg =3D ac200_volatile_reg, + .cache_type =3D REGCACHE_MAPLE, +}; + +static void ac200_disable(void *data) +{ + struct ac200 *ddata =3D data; + + regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, 0); +} + +static int ac200_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + unsigned int version; + struct ac200 *ddata; + struct clk *clk; + int ret; + + ddata =3D devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return -ENOMEM; + + clk =3D devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to enable input clock\n"); + + ret =3D devm_clk_rate_exclusive_get(dev, clk); + if (ret) + return dev_err_probe(dev, ret, "failed to lock clock rate\n"); + + ddata->regmap =3D devm_regmap_init_i2c(client, &ac200_regmap_config); + if (IS_ERR(ddata->regmap)) + return dev_err_probe(dev, PTR_ERR(ddata->regmap), + "failed to initialize regmap\n"); + + i2c_set_clientdata(client, ddata); + + /* + * No minimum delay is documented. Match the vendor driver's 40 ms delay + * before its first AC200 register access after enabling the input clock. + */ + msleep(40); + + ret =3D regmap_read(ddata->regmap, AC200_SYS_VERSION_REG, &version); + if (ret) + return dev_err_probe(dev, ret, + "failed to read chip version\n"); + + dev_info(dev, "AC200 revision %#lx in package %lu\n", + FIELD_GET(AC200_SYS_VERSION_CHIP_MASK, version), + FIELD_GET(AC200_SYS_VERSION_PACKAGE_MASK, version)); + + /* Reset the chip after dependent function drivers have unbound. */ + ret =3D devm_add_action_or_reset(dev, ac200_disable, ddata); + if (ret) + return ret; + + ret =3D regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, 0); + if (ret) + return ret; + + ret =3D regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, + AC200_SYS_CONTROL_CHIP_RESET_DEASSERT); + if (ret) + return ret; + + ret =3D devm_of_syscon_register_regmap(dev, dev->of_node, + ddata->regmap); + if (ret) + return dev_err_probe(dev, ret, + "failed to register regmap\n"); + + return 0; +} + +static void ac200_shutdown(struct i2c_client *client) +{ + ac200_disable(i2c_get_clientdata(client)); +} + +static const struct of_device_id ac200_of_match[] =3D { + { .compatible =3D "x-powers,ac200" }, + { } +}; +MODULE_DEVICE_TABLE(of, ac200_of_match); + +static const struct i2c_device_id ac200_i2c_ids[] =3D { + { .name =3D "ac200" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, ac200_i2c_ids); + +static struct i2c_driver ac200_driver =3D { + .driver =3D { + .name =3D "ac200", + .of_match_table =3D ac200_of_match, + }, + .probe =3D ac200_probe, + .shutdown =3D ac200_shutdown, + .id_table =3D ac200_i2c_ids, +}; +module_i2c_driver(ac200_driver); + +MODULE_AUTHOR("James Hilliard "); +MODULE_DESCRIPTION("X-Powers AC200 MFD core driver"); +MODULE_LICENSE("GPL"); --=20 2.53.0