From nobody Tue Sep 29 08:31:07 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD14404BF9 for ; Mon, 10 Aug 2026 15:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786374735; cv=none; b=mb+4y+R+mJl0CB7Xchlx8zTrw6LfeazHgZ+Zcue8/2kSpNSoo7tSt+klHQBVBW2J4Ua7H6/8Xsslvj4e6jFDlunLL0MA6acieHGcDNu7ZXcgkcsSiGNHlVzkXszS2NyHB6ZMs6U2br7AvWq4d4jhxTYdWStvKqkmC8TPnJZ01Lc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786374735; c=relaxed/simple; bh=a/s/YPLDFQF7KULWTXcHJRBQx4jWQPH7Uu3b9bsySwY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pD1+QDOvNsX5rz5RWZRY9fAk/mHNvNn470Q1BhSVTecT53dEy9AeODuq3+w7X1XFZn8JUtJes7wVHH8T7+x6DnFAyLOr5zjVJfJbMxtAFj4x5XZncFyQoNdt8rvZeB6rPZdicWxT3sFXVTtIKK8iDuOSDJ0p74882+PyCthWgNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=csyU+SCr; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="csyU+SCr" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so1525387a91.0 for ; Mon, 10 Aug 2026 08:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786374733; x=1786979533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=w8RyNvaah3FCOAzqxtftiLKU42GLXlNmR8aNo1U11oQ=; b=csyU+SCrw1ieK5idWNSNF+nxBquyxfctKgdn5PU/fJw81gjmA+aPHMP6hPfc7qkSNS N2nsUbv4g+sT5BPOft5lxJm5sSIlcr9IUvMUz3GHkw1XNwVBjoLFpGI5tUCv5nmAQ66Y 1X0LJDIAaWyunKQzHoh3eJFyI7aXFojNdQoRMc8braWbm9w+iesAyBThnYfhlKtWsTk9 HjptAL7YyVuT1wSa25GSAs8fOeyuPxdzBXhNEcm814PAVUSw9MnzLwVCf9MZSPSwXX96 v9LDcpiL6XwXNx2nTGFidgiUCN9n3eZo9Jc6guY2icE0N6+ibhsBybc+bYZYXUoHRnUU SwJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786374733; x=1786979533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=w8RyNvaah3FCOAzqxtftiLKU42GLXlNmR8aNo1U11oQ=; b=fl3fP5uAgcThEU4Wkb5+mvUTc8Q5Dj6W3/I2OnXrnC4XIN9l3ApB5+yxcLPyprUKDW OHs6w7wfydSYluu0rVoRsGabjNLfhjjX146mKboCXLvouVfRVx+1XdISx1ZZzp9JgLXc 9v6XWlFyQGHk6hpU0QJQJEj2tJ3q1pSO/jfafGgkQI2Da3Sh1EtPBZge/mgCAmaWnN5b t3IjSpICWJwn4tDaw/CVVpRv2wFsBpRZW4+o66BStbtF0OG8Q5MsA4aSSoCfK5yfa813 ZFkKHU9mfMVUPVPoKOlEVAh+vWLka4rUbl4QeLzs6bnKCtyTisLCHDIzr1cJCC4gZa6u GjbQ== X-Forwarded-Encrypted: i=1; AHgh+RpSKO1UwJJzcsc5cuHG8TAg2ktIWLcebzVgbEN6vZBMAXhmO9ANyuXTxJ1yzgmCB9NqK5Q/Z3Rs6NKdFlc=@vger.kernel.org X-Gm-Message-State: AOJu0YxP3QUiD890lNxdDS+Vyxde2UwSaWHA9Xgsa9lk4gQv/VDIBmTp 6ULeYzkL9l2kuw/VtLeXewtX+qspP62l6vJIwDl9XQLsxmsL5OO+TvJn X-Gm-Gg: AR+sD10TwcfhlwAd8b37c0qdFpJ6xLI5CZrbaO3zBpNTMfXP7fSjvC2WOHRJ9OoIwzB Z0P7bxQDX6gB1uyI/mp75+bQ7cqm4gyLEHdKDc7dQCXc9Q+03BmZlFW74qCBDip9kw45TRsuYmB mYmY1sY3brnFl53sxDeoBwjG07hQxLPPbauGS7uuOnOAEo45Zy1wdhE2bUvDB5Vfw+WS1748v6h P7DsutC7mfGp1Omh9BxkHWuLdIFkvNT/AoEXLB7I5OMph/kftu1dOH7ONAeLoYlGbhFuPuH4stK 0rjuNFu7xvFWBeS4ByEOFdt3eait3zrXmT8lZ8dZ6MOs0+PPHHGkJr1h81Fpzc7nMc7FN+fLrXz AqA5B7xT0o1gNfujSKBsnWZIWTyS6BxtjcAN7YUz57ebhXEXAuhGvJCbG/fLBxMXFPY4ww+YpAT stDLG0ciVrTwIeYil/4ZuZVugKRmcLAuko5XDg5hP6WvY/kRvFKB4R6+8IFziqLegXk9vsqts5c sLuID0= X-Received: by 2002:a17:90b:2e4d:b0:38e:4e61:c9e with SMTP id 98e67ed59e1d1-392847a9bc6mr9243225a91.21.1786374732777; Mon, 10 Aug 2026 08:12:12 -0700 (PDT) Received: from n232-175-066.byted.org ([36.110.163.106]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95270sm13065069a91.5.2026.08.10.08.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:12:12 -0700 (PDT) From: guzebing To: tytso@mit.edu Cc: adilger.kernel@dilger.ca, libaokun@linux.alibaba.com, jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com, yi.zhang@huawei.com, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, guzebing Subject: [PATCH] ext4: only update tune mount options when requested Date: Mon, 10 Aug 2026 23:12:00 +0800 Message-Id: <20260810151200.1405562-1-guzebing1612@gmail.com> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" EXT4_IOC_SET_TUNE_SB_PARAM uses set_flags to indicate which superblock fields the caller wants to update. ext4_sb_setparams() checks set_flags before updating the other supported fields, but always copied mount_opts into the on-disk s_mount_opts field. As a result, callers that do not set EXT4_TUNE_FL_MOUNT_OPTS can still clear or alter the on-disk default mount options through their unused mount_opts buffer. This can affect subsequent mounts by changing the filesystem's stored default mount options. Only copy mount_opts into s_mount_opts when EXT4_TUNE_FL_MOUNT_OPTS is set, matching the set_flags semantics used by the other tuneable superblock fields. Fixes: 04a91570ac67 ("ext4: implemet new ioctls to set and get superblock p= arameters") Signed-off-by: guzebing Reviewed-by: "Darrick J. Wong" --- fs/ext4/ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index c8387e6a2c6e9..1f6d7afb62ec7 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -1362,7 +1362,8 @@ static void ext4_sb_setparams(struct ext4_sb_info *sb= i, es->s_encoding =3D cpu_to_le16(params->encoding); if (params->set_flags & EXT4_TUNE_FL_ENCODING_FLAGS) es->s_encoding_flags =3D cpu_to_le16(params->encoding_flags); - strscpy_pad(es->s_mount_opts, params->mount_opts); + if (params->set_flags & EXT4_TUNE_FL_MOUNT_OPTS) + strscpy_pad(es->s_mount_opts, params->mount_opts); if (params->set_flags & EXT4_TUNE_FL_EDIT_FEATURES) { es->s_feature_compat |=3D cpu_to_le32(params->set_feature_compat_mask); --=20 2.20.1