From nobody Tue Sep 29 08:26:40 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC6BD311C2A for ; Mon, 10 Aug 2026 13:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786369123; cv=none; b=HukZlxklR0XRslGQV38WceVttkQ4+Um9/0cwx7eW+p3kPkMfZ/AMuQcnFjkq2ex36QO/AD0JrixLvsDrzLiGx6rgh4iY09cZzvKZ9xibKgE3nFdKMbJ5nbdrydxt8NVaQCh2r5EvenGY6gK3Sb6l6qklnqMCyos7/HXTy9tGVmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786369123; c=relaxed/simple; bh=kQ6y28TcwupsE3sMPowMp3Wzh9QMMyihSNza0/fheQM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Rvzn7walhtba5mPkjgW3LcYOZP1bPquihzMZtoOezMUS2fnkyMkuBAi+BqAky0XDYrIZqNaZ6sbPUQY9bXnihmFG2+i4gvz7S4LbzHp2KSfRFU2aoCqepOB/qFlzrhF9BrWDeLh3qBjE59XnXVB/zaLgAoIWCIrV0DKf+DfQNUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lzbRazw0; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lzbRazw0" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cca0c5799eso18317305ad.0 for ; Mon, 10 Aug 2026 06:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786369121; x=1786973921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fJp0RS2rFbYkW5aZcn85LfnPX0NVVRI/dLOcgjhJTg0=; b=lzbRazw0Xc81EJ2cVvpIxx/reWtMXZw/+xJIOU1aZ6VO3YgUYmqhYLf+3JFb9aQr3W eMggD9mlhMl3MO6Wxo0HJBGYCyVwjY2MpNEoma1k2DKMv8HtFVJbPQUBVHoSgaMgH6hO FEZ/4QhgfhnSboYj27W2TJ8xSJBK+Nz6qUaf12l6363/LPW3LyYOTdlVXHYCuSX7tqaC 6ctryRCl+vt1FGEEG5vXq42yqpFklNNhaTWVhPgahKIX5G6/AjYUAK6pctBWGv6DM7MN ILOyABItEVY0gg93I6odEyzlXFdXaXx4osUW0tAxJnxiJd3OffNDhq2Q+XqXtflB87Jx l0LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786369121; x=1786973921; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fJp0RS2rFbYkW5aZcn85LfnPX0NVVRI/dLOcgjhJTg0=; b=DLjOCRDK9m4OyZECwkzvl86jHY8KtDs6buNkPFVwxHucN4hySfuJ8QBGdLRSa790dZ EI6nvSDfqUA/YuNsEFxpQJejHd/YmBmjlems8q33MKk2yp2pxMGG7e+sJNXbFTHadSuG sJiYn+jaKXgveqYTDRAFNwvUASh1rhhF8vOfiS7LPfwNN9CNJnwwK9KmhkZD1zlxAf2y oIWLUIZw+ujgCznd42kJsX4/1XRO7TMA7w3HM3ljSBUMTyNlTyPxQmYDw54h172pCX7J wSHL8peA+7/w2e+PgKiu0HX8Zzb7LgJtch5lK9MqPI2v8Zip03+iwJn3ZXhrDsZsnhH4 fljg== X-Forwarded-Encrypted: i=1; AHgh+RqIXs7VcowhEUGC99rhnBMZOrDWyFIvmshGJ/S+0weCgNkaaHWgZId0CQ8EPWUoaybbbkLh6/NW/XTYsvY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxs5yZUCZSUxJD9Y8WIML3bimgzhW0N4DjZo9FsVSzNA/DCJxPZ KyV0EJOyc0Cs5LuosDw0nwYgcHTUNeaeICFMF+CaiAZj/z/d91ISs9VS X-Gm-Gg: AR+sD11uD1ecqar0ZFrpnbvnToXtkyzGfOzKcvoq5HfEEvlglElg5ok11Sx5xOFfabR oOhezD9kDnQVDjCup0h6Hj5TfOPXRLyPe2I3WQsBiFO2bwOYObanPUu5vqK+yUAqI6qDhNlRjXn 76cWEXijjbKuvxqh6t7JCPi7xks8OdTDa28/ZVA2ecr59Uw4E/6kvtvQwxEfcLIKQsqRJmH0zVO J6sk5FhlQybJaoiTbFLYnf5LuBNKgU86txE9m7avVSRCcv1NZ0lmB88r0Dwn8KzT3ah4YNPjmgm PyoAxqJaiD3D1TsYRrV/H1oKNd1Ugy5vphKQnVoH4/OyWI8xHrohEtdDPoCOU146/o0ZrKVPOf4 2R43+FxspFxy1bogbW1hw3+AyaAI96NFAjIHT/5Y3MsD79JI+CW7M9q4ND5kSSQ5lF568TZiQ5Q PY86TEI0GDBnpI+ipIKSwSR1HysFsOlJ4rifO8gVlEfufj5+GknGvr692HE6hYovydRdOelG/7z Q+ISUX+CKWDJhRSmvjujy408cBAeS2vfM8= X-Received: by 2002:a17:903:32c5:b0:2ca:ed57:8586 with SMTP id d9443c01a7336-2d2a8fd38b5mr232240785ad.23.1786369120819; Mon, 10 Aug 2026 06:38:40 -0700 (PDT) Received: from qiwenjie-ThinkCentre-M760t.mioffice.cn ([43.224.245.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d16c4fc743sm36278955ad.80.2026.08.10.06.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 06:38:39 -0700 (PDT) From: Wenjie Qi X-Google-Original-From: Wenjie Qi To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@kernel.org, qiwenjie@xiaomi.com, qwjhust@gmail.com Subject: [PATCH v2] f2fs: return symlink writeback errors Date: Mon, 10 Aug 2026 21:38:32 +0800 Message-ID: <20260810133832.3530016-1-qiwenjie@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" F2FS writes long symlink data with page_symlink() and then flushes the symlink mapping to reduce the chance of exposing a broken symlink. That flush result is currently ignored. If the writeback fails, symlink() still returns success even though the symlink is not durable and the same operation can already surface -EIO through syncfs(). Return the writeback error to userspace and skip the dirsync flush once the symlink data flush has failed. Fixes: d0cae97cb600 ("f2fs: flush symlink path to avoid broken symlink afte= r POR") Cc: stable@kernel.org Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu --- Changes since v1: - fix the Fixes tag to point to the real introducing commit Reproducer: - enable FAULT_WRITE_IO on the mounted F2FS filesystem - create a long symlink so the target is written through page_symlink() - old kernel: symlink() returns 0, syncfs() returns -EIO, and the symlink is absent after remount - new kernel: symlink() returns -EIO fs/f2fs/namei.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 7ffdf23cea5e..a8db3928c8b5 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -707,15 +707,16 @@ static int f2fs_symlink(struct mnt_idmap *idmap, stru= ct inode *dir, * performance regression. */ if (!err) { - filemap_write_and_wait_range(inode->i_mapping, 0, - disk_link.len - 1); + err =3D filemap_write_and_wait_range(inode->i_mapping, 0, + disk_link.len - 1); =20 - if (IS_DIRSYNC(dir)) + if (!err && IS_DIRSYNC(dir)) f2fs_sync_fs(sbi->sb, 1); - } else { - f2fs_unlink(dir, dentry); } =20 + if (err) + f2fs_unlink(dir, dentry); + f2fs_balance_fs(sbi, true); goto out_free_encrypted_link; =20 --=20 2.43.0