From nobody Tue Sep 29 09:09:41 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D3A3AE187 for ; Mon, 10 Aug 2026 10:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786357269; cv=none; b=JuZgCzGqckhs3UIK5EVYM32lh98h/gBvZxxVyVCNd9v7R3U2/+wBR5JQTNA/ahegCsO+jHjoUZSS4P40I/oNxz6g6fFCsIT/9XdErAdf2rvfR8p58knBp7H7v1g/Is/lyjGEORZG/ipVz4vfZjuyjvJ105kt40swL+p32RvCbPc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786357269; c=relaxed/simple; bh=jluzJusjx8HFXTzca86JgoRcy38vgjw9MxDZ6gYe/IU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZppJiQ/RQGb8WnTCJf3p55D5L8/SvRC/Yids+Kb5WfnqTTOEHBGhURUD+DnPNMOjkg5gQiZ55DbKc8RDTSnKwNdAVtkJFhVo4LRllLoEe2d7NV/DhufMIyqUM8zyk91Q0XoUGhvSuasV8hHkiMczOEmCIp9UffYV+GleqvVZpys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j+HmNpaA; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j+HmNpaA" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-84874b52eabso2155751b3a.0 for ; Mon, 10 Aug 2026 03:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357267; x=1786962067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FVhnTJBrATFNd+yhmpURH5NgNQs7Wgyvv9zxL1wJeP4=; b=j+HmNpaARsiK5Ee9saYOLe/40P7/nCrn1HK2ebQ5vbqRGyQZ6hhZdkvlOMtf/Ot6oY TdkWZIyaL5qChjlIBlOlAuN2YZs9aM1g6ptvnihox1poFyMtckO7Xbf779HBMSsCCHtM GjVeTIO4nuRRffg2TgPnF11s+hemfQaQjaZv89PrRrmuU56Pblp3hxYubYQ7TY3la0Fd k5MTnW+b2SDZZHY00dikPwDOCCqlBWZWhk8uIg/stq5cyVwgWzf9Ecpt6/PTGrzZDr2L aNt9a75RrqfyP8BIPkYplBYI6vvUf3fVst+MmFocZ//dcH68VKZ9KaTZhZwwo6D207IX sezA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357267; x=1786962067; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FVhnTJBrATFNd+yhmpURH5NgNQs7Wgyvv9zxL1wJeP4=; b=mPN0GSo+J1L5bOeOrVqOw1fEB6xE3PZvz55KpHVT40o5xiRWKBBaQFDXKZikVqFJ8j D2YzzfR9/3OFkOEf6WEJxRy3yor7knqyR3bhyopATx1jMg4UdBrTxkk4Syn+Bff39Cb8 /RoFG2vIo23GmhocJB2qn3f4bByMi3V14jfx3tm1dfu4wimLHorKW/J9kv2YJVkd8LKp 2VkSaXj7a2uLobbIplaPVpfkwM47kYlMgtTpixnrIKdzWmedc+ljqEc1Y8JIOptC7Rt5 Sy/o9bIwNGa8nfN6liUsJxB5HpPeXE7nGqlG/Zm3dVrb+J8HsDBu1ZDkDqEKqg2k1xer HSug== X-Forwarded-Encrypted: i=1; AHgh+RobS+93bY04jJoZ4B1LBMAPF5yQmIAIltN+UJ1oDtGSD3S4j4V7fcyRpK+ggive3GpFWD47aJRVRfOF+bA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywumftt9JBECsXw8mADz7ogIKfdOPlP7VIvNdJ3q73zjWaUMpnn 96cGsf2rchqroyehRJQryiHmpMFSLlA/EJ4hZentbfuKnONQHb8CP3Ru X-Gm-Gg: AR+sD11lgYf7sXdi7QKigcbLlLRJyWJqgoTSO/eqytrfIw0E22GIcHac5axDsUlPL44 5NmgLP0nwfj4WVE1QGE2MnDV8kvzaYmV2rU58NBENdRk9Gnxz4rfDCpzMEe78uC/LtNBZeHdJSq 4FfKQoVl1ySxK1Hj5K1VJY/oPxteX2lZPS1LI66QFW/f7TPsrn0I4K7/odKUDGnHz72QNXWnMf5 mAERQ4iEylMGHcmlWM8YpUXBgQ7C9A+tqOah2VOpKZM/A5SrnjYijJ5dmqNpk6NAfrn5DMHo+ek FeMAOFaP3nF9BJHnebOUVrR4ayrTBbFOlxWA+C3h6gZSR56mZ4x9K1mdVcad9Tykcv/IEgXOLAH jYJIF6vFYH/I59NUVEwrm0lUU+yHzDJl5wsK/b2g4+IoEozNPIqbVy8Whw3fmQTN4YlCPDyhmUf GoUnFHwj0v4vny1cNXXE3WqyTyuQzYAwAA4/nGM+y5xm0OT6wlEx61DtNYOQb1fzNvpWOQAzNev A== X-Received: by 2002:a05:6a20:728c:b0:3c0:b4f8:bbfb with SMTP id adf61e73a8af0-3cbc03b5531mr22783805637.22.1786357267350; Mon, 10 Aug 2026 03:21:07 -0700 (PDT) Received: from amd.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bec68468sm44276912eec.31.2026.08.10.03.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:21:06 -0700 (PDT) From: Chaithanya Lagisetty To: Vinod Koul , dmaengine@vger.kernel.org Cc: Frank Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Chaithanya Lagisetty Subject: [PATCH] dmaengine: sun6i: fix use-after-free in descriptor error path Date: Mon, 10 Aug 2026 10:20:44 +0000 Message-ID: <20260810102044.1725649-1-nagachaithanya9911@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The err_lli_free cleanup loops in sun6i_dma_prep_slave_sg() and sun6i_dma_prep_dma_cyclic() free each LLI node with dma_pool_free() and then dereference the freed node to obtain v_lli_next and p_lli_next for the next loop iteration. Save the next pointers before freeing, matching the pattern already used in sun6i_dma_free_desc(). Fixes: 9aa48806edb8 ("dmaengine: sun6i: Do not use virt_to_phys") Signed-off-by: Chaithanya Lagisetty Reviewed-by: Frank Li --- drivers/dma/sun6i-dma.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index f47a326dd7ff..2439fa6564f2 100644 --- a/drivers/dma/sun6i-dma.c +++ b/drivers/dma/sun6i-dma.c @@ -720,10 +720,10 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep= _slave_sg( struct sun6i_dma_dev *sdev =3D to_sun6i_dma_dev(chan->device); struct sun6i_vchan *vchan =3D to_sun6i_vchan(chan); struct dma_slave_config *sconfig =3D &vchan->cfg; - struct sun6i_dma_lli *v_lli, *prev =3D NULL; + struct sun6i_dma_lli *v_lli, *v_next, *prev =3D NULL; struct sun6i_desc *txd; struct scatterlist *sg; - dma_addr_t p_lli; + dma_addr_t p_lli, p_next; u32 lli_cfg; int i, ret; =20 @@ -789,8 +789,11 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_= slave_sg( =20 err_lli_free: for (p_lli =3D txd->p_lli, v_lli =3D txd->v_lli; v_lli; - p_lli =3D v_lli->p_lli_next, v_lli =3D v_lli->v_lli_next) + p_lli =3D p_next, v_lli =3D v_next) { + v_next =3D v_lli->v_lli_next; + p_next =3D v_lli->p_lli_next; dma_pool_free(sdev->pool, v_lli, p_lli); + } kfree(txd); return NULL; } @@ -806,9 +809,9 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_d= ma_cyclic( struct sun6i_dma_dev *sdev =3D to_sun6i_dma_dev(chan->device); struct sun6i_vchan *vchan =3D to_sun6i_vchan(chan); struct dma_slave_config *sconfig =3D &vchan->cfg; - struct sun6i_dma_lli *v_lli, *prev =3D NULL; + struct sun6i_dma_lli *v_lli, *v_next, *prev =3D NULL; struct sun6i_desc *txd; - dma_addr_t p_lli; + dma_addr_t p_lli, p_next; u32 lli_cfg; unsigned int i, periods =3D buf_len / period_len; int ret; @@ -870,8 +873,11 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_= dma_cyclic( =20 err_lli_free: for (p_lli =3D txd->p_lli, v_lli =3D txd->v_lli; v_lli; - p_lli =3D v_lli->p_lli_next, v_lli =3D v_lli->v_lli_next) + p_lli =3D p_next, v_lli =3D v_next) { + v_next =3D v_lli->v_lli_next; + p_next =3D v_lli->p_lli_next; dma_pool_free(sdev->pool, v_lli, p_lli); + } kfree(txd); return NULL; } --=20 2.43.0